[02:46]  * bschaefer smspillaz hey, are you around?
[02:46] <bschaefer> opps
[02:46]  * bschaefer ments msg haha
[09:16] <smspillaz> jrr: might be worth giving my branch a try later today
[09:17]  * smspillaz just got regional updates working again for unity
[09:18] <sil2100> \o/
[09:45] <smspillaz> sil2100: these numbers are basically meaningless, but I've seen a 1000fps boost in glxgears
[09:46] <sil2100> Well, that makes sense, now it finally doesn't redraw everything as it goes meaninglessly again
[09:57] <davidcalle> sil2100, hi
[09:57] <larsu> sil2100, hi, sorry for not getting back to you on Friday - I was crazy busy
[09:58] <larsu> I did try the package with my indicator-appmenu patch, and it works as expected
[09:58] <larsu> can you tell me again how you're able to still reproduce this?
[09:58] <larsu> I used this package: lp:ubuntu/raring-proposed/indicator-appmenu
[09:59] <sil2100> larsu: hello!
[10:00] <sil2100> larsu: hm, ok, let me try building this specific package - since I was testing on a locally compiled version of  indicator-appmenu  from the staging PPA
[10:00] <davidcalle> sil2100, nevermind, found my answer :)
[10:00] <sil2100> larsu: also, it seems to fail on the autopilot testing machines for raring, when using the latest package (i.e. 12.10.4daily12.12.14-0ubuntu1)
[10:01] <sil2100> davidcalle: hello! Good :)
[10:02] <larsu> sil2100, hm, that's exactly the one I built... which staging ppa do you mean? I can try the package from there as well
[10:04] <sil2100> larsu: https://launchpad.net/~unity-team/+archive/staging
[10:04] <sil2100> larsu: which is strange, since I remember it working before too!
[10:05] <sil2100> larsu: btw. would you mind trying to run an autopilot tests with your package?
[10:05] <sil2100> And tell me if it works or not?
[10:06] <sil2100> larsu: could you add the ppa:autopilot/ppa, install python-autopilot from it, then, bzr branch lp:unity; cd unity/tests/autopilot
[10:06] <larsu> sil2100, sure
[10:06] <sil2100> larsu: and finally: autopilot run unity.tests.test_panel.PanelHoverTests.test_hovering_indicators_open_menus
[10:07] <sil2100> And check if the test fails or not - since if with your package the cursor suddenly goes to some strange position while hovering over the menus, it means there have to still be some hidden indicator entries
[10:07] <sil2100> larsu: thanks!
[10:10] <larsu> sil2100, that ppa is not enough, apt-get complains about missing deps:  python-junitxml, python-testscenarios, python-testtools, python-xlib
[10:12] <sil2100> larsu: hm, those should be in main I think?
[10:12] <sil2100> In main and universe
[10:13] <larsu> sil2100, ah sorry, I messed up earlier when force-install indicator-appmenu-tools. Nevermind :)
[10:13] <sil2100> ;)
[10:17] <larsu> sil2100, haha watching those tests is awesome!
[10:17] <larsu> sil2100, it fails though
[10:23] <larsu> sil2100, so gedit is opened and the cursor moves to open the File, Edit, View, Search, Tools menus, and then it suddenly goes to 0,0
[10:24] <larsu> then it times out
[10:24] <larsu> and considers the test failed
[10:24] <larsu> is this the same failure you were talking about=
[10:24] <larsu> ?
[10:25] <sil2100> larsu: yes :|
[10:25] <sil2100> larsu: when the mouse moves to 0,0, it means that it encountered an empty indicator in-between menu entries, which has some broken x,y coordinates
[10:26] <sil2100> When you edit unity/tests/test_panel.py, go to test_hovering_indicators_open_menus and simply paste 'print entries' after the list of entries is fetched, you'll get a print-out of the indicators u-p-s is getting through DBus
[10:27] <sil2100> And there are still those strange empty entries inbetween those proper menu indicators
[10:28] <larsu> sil2100, ah, that's a different issue from the one I solved, though
[10:29] <larsu> I mean, the reason those empty indicators are there is different
[10:33] <sil2100> larsu: any idea why? Since when I dbus-monitor, I also see them being sent through DBus
[10:34] <sil2100> By one of the libappmenu.so's ;p
[10:34] <larsu> sil2100, I'm trying to find out right now, but it looks like gedit itself creates those empty menu items
[10:34] <larsu> and indicator-appmenu doesn't filter those
[10:34] <larsu> my patch only makes sure that indicator-appmenu doesn't create empty items by itself
[10:35] <sil2100> larsu: charmap also suffers from this problem
[10:35] <sil2100> Ah, ok ;)
[10:36] <larsu> sil2100, really, I don't see empty items in charmap
[10:36] <sil2100> larsu: since I remember browsing through the sources of gedit and gucharmap and didn't notice any of them adding such empty indicator/menu entries, but maybe those are not planned
[10:37] <larsu> sil2100, how can I test gucharmap with autopilot?
[10:38] <sil2100> larsu: uh oh! Wait!
[10:38] <sil2100> larsu: you're right!
[10:38] <sil2100> charmap is no longer affected!
[10:38] <larsu> sil2100, and gedit is affected because it inserts a separator itself. WTF?
[10:38] <sil2100> So maybe indeed gedit is doing something strange - but this means that your previous patch worked fine
[10:38] <larsu> why would it do thaT?
[10:39] <larsu> sil2100, so I could filter out GtkSeparatorMenuItems, but that still wouldn't fix all the cases because apps could still insert normal menu items with a "" label
[10:39] <sil2100> larsu: anyway, if you would liek to see it in action for charmap, simply edit the test_panel.py I mentioned earlier, search for test_hovering_indicators_open_menus and simply replace "Text Editor" with "Character Map"
[10:39] <larsu> I think the safest bet is to handle this case in autopilot
[10:40] <sil2100> larsu: true, I think I will have to simply fix the autopilot tests to filter those out
[10:40] <sil2100> Yes
[10:40] <larsu> sil2100, okay, thanks. This won't be a problem anymore once all applications are using GMenuModel
[10:40] <sil2100> Big thanks! At least now I know why it worked before, since it seems when I was testing your patch, I was using charmap instead of gedit for testing
[10:40] <larsu> (which might take some time :P)
[10:40]  * sil2100 feels a bit stupid now ;)
[10:41] <larsu> sil2100, well, I honestly wouldn't have thought that any app puts separators in its menu bar...
[10:42] <larsu> sil2100, I could watch those tests all day :)
[10:42] <sil2100> larsu: just in case you know - is there a way in which the seperators are 'differenciated' from normal menu entries in DBus?
[10:42] <sil2100> hehe
[10:43] <larsu> sil2100, sadly not. I'd filter out everything that has a label with an empty string
[10:43] <larsu> sil2100, and no icon!
[10:43] <larsu> (otherwise you'll miss the indicators)
[10:43] <sil2100> Indeed! Ok, thanks again, going to fix all those things now
[10:44] <larsu> sil2100, very cool. Thanks for all the great testing work you guys are doing!
[10:52] <MCR1> @all: Hi :)
[10:56] <MCR1> Top job. Since ages I was suffering from bug 1047232. I do not know which commit exactly fixed it, but it is fixed since I updated Unity today. Great \o/
[10:58] <MCR1> https://bugs.launchpad.net/unity/+bug/1047232 -> this is a video showing the bug, which is now fixed, in action: https://bugs.launchpad.net/unity/+bug/1047232/+attachment/3297777/+files/launcherhide.mp4
[10:59] <MCR1> Also all click-through and minimize/restore bugs, which were recently introduced in lp:compiz (r3513) are fixed. Great !
[11:00] <MCR1> Place plugin also worx perfectly.
[11:00] <sil2100> \o/
[11:04] <MCR1> sil2100: Many people (including myself) mostly come here to complain, but this time I am here to honor you and thank you 4 your top work. Keep it up that way ;)
[15:04] <gatis> hello, i have this problem, when i use xcb_grab_keyboard on my client i still get Unity "run command" (on Alt) and  seach window (on Windows key)
[15:05] <gatis> can somebody tell me more, how those parts are implemented in the unity?
[15:06] <gatis> if i do xcb_grab_keyboard on the screen's root window then i dont get all those unity extras..
[17:04] <fginther> Trevinho, bschaefer, Can you please take a look at http://paste.ubuntu.com/1447957/? It looks like recent bamf merge broke unity
[17:05]  * bschaefer swore he compiled unity with that branch MP
[17:05] <bschaefer> fginther, I can take a look
[17:06] <fginther> bschaefer, thanks. found your name on the review :-)
[17:06] <bschaefer> fginther, yup :)
[17:06] <bschaefer> though it should have just been cleaning up dead code....maybe it wasn't completely dead
[17:17] <bschaefer> fginther, hmm it looks like that function is used in unity ApplicationLauncherIcon....which im not sure if its needed... Trevinho would know more about this
[17:17] <bschaefer> fginther, soo im thinking if unity needs it, then we might have to revert that change in bamf
[17:18] <bschaefer> and re propose the correct fixes in bamf
[17:24] <fginther> bschaefer, I'm glad to help if I can.
[17:24] <fginther> bschaefer, thanks for investigating so quickly
[17:24] <bschaefer> fginther, np, I just got on :)
[17:24] <bschaefer> fginther, mostly im hoping for Trevinho to magically appear
[17:25] <bschaefer> but he stayed up late
[17:26] <bschaefer> fginther, let me prepare a branch to revert that change
[17:27] <bschaefer> fginther, wait...it didn't merge
[17:27] <bschaefer> fginther, sorry, I thought it was in trunk bamf merged, and unity was failing to build :)
[17:28] <bschaefer> fginther, just let Trevinho fix his branch now :)
[17:28] <fginther> bschaefer, my mistake. I thought the branch had merged also
[17:28] <bschaefer> no worries :), jenkins caught it
[17:28] <bschaefer> \o/
[17:29] <Trevinho> bschaefer, fginther: sorry I was busy
[17:29] <bschaefer> Trevinho, your branch needs a fixing!
[17:29] <Trevinho> bschaefer: Oh, that functionality was added recently... I don't think that we need it in unity
[17:29] <Trevinho> bschaefer: do we need indicators in unity?
[17:29] <bschaefer> well its used in ApplicationLauncherIcon
[17:30] <bschaefer> Trevinho, that is what I wanted to ask you :)
[17:30] <fginther> bschaefer, Trevinho, I'll be afk for a bit. if you need me, just leave a message
[17:30] <bschaefer> fginther, will do, thanks for pointing that out!
[17:30] <bschaefer> Trevinho, I just built my unity with it removed and am about to test it
[17:31] <Trevinho> bschaefer: I think that functionality is in libunity now
[17:31] <Trevinho> bschaefer: I'll fix unity and all will be fine again
[17:32] <bschaefer> Trevinho, o really? That would be nice, it just looked like ApplicationLauncherIcon was using that list for that array ...
[17:33] <Trevinho> bschaefer: yeah... But that was to control the dynamic quicklist that are handled by libunity nowadays
[17:33] <bschaefer> Trevinho, sweet, I haven't touched those things in a while :)
[17:33] <bschaefer> ping me when you have a branch that needs a review, then we can get your bamf branch merged!
[17:34] <Trevinho> bschaefer: ok
[17:34] <Trevinho> bschaefer: sorry for breackage, I acually tought that the code in unity was removed
[17:35] <bschaefer> Trevinho, no worries, and I thought I tested unity with that bamf branch!
[17:35] <bschaefer> Trevinho, jenkins caught it :)
[17:35] <Trevinho> bschaefer: yeah, nice thing
[18:23] <Trevinho> bschaefer: https://code.launchpad.net/~3v1n0/unity/remove-bamf-indicators/+merge/140519 I'm also looking to remove something from indicator-application
[18:24] <bschaefer> Trevinho, cool
[18:24]  * bschaefer looks at branch
[18:24] <bschaefer> Trevinho, also your working full time now?
[18:25] <Trevinho> bschaefer: no, still part-time... But I've changed contract
[18:25] <bschaefer> Trevinho, o, cool, I just saw you in that email
[18:33] <bschaefer> Trevinho, well it seems andyrock beat me to the review
[18:33] <bschaefer> but it compiled here :)
[18:33] <andyrock> ;)