| StevenK | wgrant: Raring +queue for NEW on prod: 91 queries/external actions issued in 0.94 seconds | 00:24 |
|---|---|---|
| === slank is now known as slank_away | ||
| wgrant | Excellent | 00:37 |
| StevenK | Done is still dreadful, at 3.3 seconds | 00:37 |
| wgrant | But the search query is only about 300ms | 00:38 |
| wgrant | So that bit's fine | 00:38 |
| wgrant | Well, "fine" | 00:38 |
| StevenK | It was 70ms on qas :-( | 00:38 |
| wgrant | It'll probably be quicker now it's hot | 00:38 |
| wgrant | Let's see | 00:38 |
| wgrant | Yeah, 75ms now it's hot everywhere | 00:39 |
| StevenK | cjwatson: I'm going to close bug 33700, and you should able to change the queue API script now too | 00:56 |
| _mup_ | Bug #33700: could queue filters match source as well as binaries? <lp-soyuz> <qa-ok> <Launchpad itself:In Progress by stevenk> < https://launchpad.net/bugs/33700 > | 00:56 |
| cjwatson | StevenK: ok, great, thanks - I'll sort that out tomorrow morning, with the bug closure mail serving as a reminder | 00:56 |
| cjwatson | I just need to flip over the exact-match default, right? | 00:57 |
| StevenK | Right | 00:58 |
| StevenK | versions will have exact_match no matter the setting of it now, too | 00:58 |
| cjwatson | yeah, I don't think we'll notice that bit in the script :) | 00:59 |
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| === frankban changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On-call reviewer: - | Firefighting: - | Critical bugs: <150 | ||
| cjwatson | StevenK: queue client changes done now | 10:24 |
| StevenK | cjwatson: \o/ | 10:35 |
| cjohnston | anyone have an idea as to why https://code.launchpad.net/~chrisjohnston/launchpad/181725 didn't pick up the code changes? | 12:18 |
| StevenK | It probably failed to scan | 12:29 |
| StevenK | cjohnston: I'll get it re-done, hold a mo | 12:29 |
| cjohnston | ty | 12:29 |
| * StevenK grumbles at the branch scanner. | 12:34 | |
| cjohnston | hehe | 12:34 |
| StevenK | cjohnston: To unblock you, you can rename the branch and re-push, or I can look again after I wake. | 12:35 |
| cjohnston | StevenK: ack | 12:35 |
| cjohnston | StevenK: it seems to have refreshed | 12:48 |
| cjohnston | StevenK: looks like one of your branches may have had the same issue | 12:48 |
| === yofel_ is now known as yofel | ||
| czajkowski | cjohnston: you trying to buil up brownie points :) | 14:02 |
| cjohnston | depends.. what can I get with them | 14:03 |
| sinzui | cjohnston, I expect both your branches to land in about 6 hours | 14:06 |
| cjohnston | sinzui: cool.. I'm hoping to have a couple more over the holidays | 14:07 |
| sinzui | I will be about to review | 14:07 |
| cjohnston | is there a direct link to the 500 error page? | 14:08 |
| czajkowski | sinzui: you're meant to be on hols mister :) | 14:09 |
| cjohnston | deryck: ping | 14:09 |
| sinzui | I could be if we turned Lp off for the holidays | 14:10 |
| cjohnston | can we turn everything off? | 14:10 |
| czajkowski | sinzui: I'll keep an eye on Rts next week so don't worry | 14:10 |
| czajkowski | and I've already sent a reminder mail to canonical list re commercial projects | 14:10 |
| czajkowski | and had 7 mails :) | 14:10 |
| cjohnston | https://bugs.launchpad.net/launchpad/+bug/483945 needs to become super most highest absolutely critical ;-) | 14:11 |
| _mup_ | Bug #483945: No way to ask Launchpad to refresh a stale diff <code-review> <lp-code> <mp-preview-diff> <openstack> <trivial> <Launchpad itself:Triaged> < https://launchpad.net/bugs/483945 > | 14:11 |
| czajkowski | cjohnston: no it doesnt :) | 14:11 |
| sinzui | bug reports cannot be ignored. Lp was attacked twice during holidays by spammers | 14:11 |
| czajkowski | our criticals are triaged as oops or timeouts or stuff like that | 14:11 |
| cjohnston | its bothering me and keeping my code from being able to land in launchpad | 14:11 |
| cjohnston | it was sarcastic | 14:11 |
| czajkowski | cjohnston: bothering is a a bit flippiant also :) | 14:12 |
| deryck | hi cjohnston | 14:12 |
| cjohnston | What's the chance that there are ton's of bugs that are open that arent accurate anymore | 14:12 |
| cjohnston | deryck: bug #413597 | 14:12 |
| _mup_ | Bug #413597: "clearfix" class should be removed from multiline editor widget <css> <javascript> <lp-web> <opera> <trivial> <Launchpad itself:Triaged> <LAZR Javascript Library:Triaged> < https://launchpad.net/bugs/413597 > | 14:12 |
| cjohnston | I'm wanting to take a stab, but seems things have changed in the code base, so I just want to make sure I do it right | 14:13 |
| rick_h_ | cjohnston: I'll help you out with that if you need. I hacked on it a bunch when I added the auto expanding and such when I first started | 14:13 |
| cjohnston | rick_h_: sure thing | 14:13 |
| deryck | cjohnston, yeah, that was about to me my suggestion, to talk to rick_h_ :) He's deeper in all that now than me. | 14:14 |
| rick_h_ | oh hmm, opera is blacklisted? | 14:14 |
| sinzui | cjohnston, we now have unscan branch that fixes the stale diff. Someone could add an action to the UI to run it. the root issue is that Lp fails to scan branches. No one would want that bug fixed if Lp's branch-scanner could be trusted | 14:14 |
| deryck | rick_h_, in the day it was one of those, if Y.UA == Opera return kind of things. | 14:14 |
| rick_h_ | deryck: yea, I think I cleaned some of that up. Will have to refresh. | 14:14 |
| deryck | rick_h_, not a black list per se. | 14:14 |
| deryck | rught | 14:15 |
| sinzui | rick_h_, I test with opera. It works | 14:15 |
| rick_h_ | cjohnston: but yea, I'm probably the guy you want on that stuff | 14:15 |
| deryck | right, even | 14:15 |
| cjohnston | sinzui: ya, I want that button ;-) | 14:15 |
| cjohnston | rick_h_: I think it may be in lib/lp/app/doc/lazr-js-widgets.txt now | 14:15 |
| deryck | rick_h_, cjohnston we should probably close any tasks on lazr js too, since we don't use that anymore. | 14:15 |
| cjohnston | It doesn't look like anything was ever decided on bug #666379, and its been two years since it was last commented on.. Suggestons? | 14:17 |
| _mup_ | Bug #666379: "Community" term is misused <lp-code> <trivial> <Launchpad itself:Triaged> < https://launchpad.net/bugs/666379 > | 14:17 |
| cjohnston | and sinzui could you please take a look at bug #666738.. I commented on it, though may also want lifeless' input as well as to how to best fix | 14:18 |
| _mup_ | Bug #666738: cannot tell who is 'essential' and who is not for a spec <confusing-ui> <lp-blueprints> <trivial> <Launchpad itself:Triaged> < https://launchpad.net/bugs/666738 > | 14:18 |
| cjohnston | deryck: does that mean that the bug isn't a bug anymore? | 14:19 |
| deryck | cjohnston, the js bug? it's still relevant for launchpad, just not lazr-js. we moved all the lazr-js code in tree, and don't maintain it separately now. | 14:19 |
| cjohnston | gotcha.. just the effects lazr-js stuff | 14:20 |
| sinzui | cjohnston, I replied with an idea | 14:21 |
| cjohnston | ty | 14:22 |
| rick_h_ | cjohnston: so on the js bug, looks like the clearfix is in the template used, but watch out as there's matching css rules in forms.css for .lazr-multiline-edit .clearfix h3 | 14:24 |
| rick_h_ | but like sinzui says, might just work if the conditional was removed for opera so we'd want to check if the issue still exists first | 14:25 |
| cjohnston | conditional? | 14:26 |
| sinzui | rick_h_, I think we have one in the code because it was unhappy with the *last* version of YUI | 14:26 |
| rick_h_ | if (Y.UA.XXX | 14:26 |
| sinzui | We absolutely should remove the guard and test with the current version | 14:26 |
| rick_h_ | sinzui: ah | 14:26 |
| rick_h_ | cjohnston: so yea, there's no opera conditionals in inlineedit/editor.js any more | 14:27 |
| sinzui | most the other opera guard were fixed by yui 3.4 | 14:27 |
| cjohnston | rick_h_: so that means it just needs to be tested in opera? | 14:27 |
| rick_h_ | cjohnston: yea, and looks like just tested to work and then closed off as fixed released long ago | 14:27 |
| * cjohnston goes to install opera | 14:28 | |
| sinzui | Is this about the icon placement and field is not outlined bug for opera? | 14:28 |
| rick_h_ | ah, yea it refernces the icon placement | 14:28 |
| rick_h_ | #412579 | 14:28 |
| _mup_ | Bug #412579: Icons are not aligned properly for multi-line editor in Opera <LAZR Javascript Library:Won't Fix> < https://launchpad.net/bugs/412579 > | 14:28 |
| rick_h_ | so guess check that, if it's still not right we can go after the clearfix in the template | 14:28 |
| sinzui | rick_h_, cjohnston. it is mostly fixed | 14:30 |
| sinzui | there is a 2 pixel misalignment | 14:30 |
| cjohnston | does that need to be fixed? | 14:31 |
| sinzui | no | 14:31 |
| cjohnston | so just mark fix released? | 14:31 |
| sinzui | the issue was worse when the tab-treatment obscured text. | 14:31 |
| sinzui | The editor works very well now that we can wee what is being edited | 14:33 |
| === Ursinha is now known as Ursinha-afk | ||
| cjohnston | I'm guessing that #483945 isn't the most easiest bug out there.. even though it says trivial? | 14:34 |
| _mup_ | Bug #483945: No way to ask Launchpad to refresh a stale diff <code-review> <lp-code> <mp-preview-diff> <openstack> <trivial> <Launchpad itself:Triaged> < https://launchpad.net/bugs/483945 > | 14:34 |
| cjohnston | too had I'm not fixing any critical bugs to make the critical bug chart go down.. lol :-( | 14:37 |
| czajkowski | cjohnston: tis ok we have purple doing a shopping job on that list | 14:37 |
| cjohnston | czajkowski: ya, but it would be cool for me :-P | 14:38 |
| cjohnston | czajkowski: did you see the pictures of the book I posted on FB? | 14:38 |
| czajkowski | narp | 14:39 |
| cjohnston | http://goo.gl/hOuIt | 14:41 |
| czajkowski | congrats | 14:42 |
| cjohnston | deryck: so does your comment from earlier mean that all of https://bugs.launchpad.net/lazr-js needs to be marked effecting lp and closed for lazr-js? | 14:52 |
| deryck | cjohnston, basically, yes. assuming the bug still exists, and assuming the bug wasn't filed on behalf of another project using lazr-js. | 14:58 |
| cjohnston | deryck: that maybe sounds like something someone with more experience should do | 14:59 |
| === slank_away is now known as slank | ||
| deryck | cjohnston, yeah, unfortunately. rick_h_ could advise if you take a stab at it. | 15:00 |
| cjohnston | I feel like unless its blatantly obvious I may ask more questions that it would just be best for him to sort | 15:00 |
| rick_h_ | ugh, yea. That'd take some processing to see if they still apply. Many of the 'lazy should haveXX' would just go away. if LP doesn't need it then it's never going to happen | 15:05 |
| sinzui | I am template to close all those "lp should" bugs reported by Lp staff over 5 years ago. If no user want the feature, I don't want to see the bug in listings | 15:14 |
| sinzui | s/template/tempted/ | 15:14 |
| czajkowski | sinzui: want a hand? | 15:14 |
| sinzui | sure, sort the listing by age, look for bugs reported by former staff, close the bug if it is about an idea that with no dupes or affects other users | 15:15 |
| czajkowski | ok | 15:16 |
| === Ursinha-afk is now known as Ursinha | ||
| czajkowski | sinzui: what about the rosetta bugs? https://bugs.launchpad.net/launchpad/+bug/1420 | 16:28 |
| _mup_ | Bug #1420: IRosettaStats current interface doesn't suit database/pofile.py very well <lp-translations> <tech-debt> <Launchpad itself:Triaged> < https://launchpad.net/bugs/1420 > | 16:28 |
| sinzui | POTs are still misusing the code | 16:28 |
| czajkowski | pots are misunderstood :) | 16:28 |
| === deryck is now known as deryck[lunch] | ||
| === deryck[lunch] is now known as deryck | ||
| lifeless | cjohnston: oh hai :) | 18:54 |
| cjohnston | hey lifeless | 19:01 |
| cjohnston | lifeless: https://code.launchpad.net/~chrisjohnston/launchpad/666738/+merge/140758 work for you? | 19:02 |
| cjohnston | lifeless: updated | 19:33 |
| cjohnston | lifeless: do I have to do anything special when wrapping the text into two lines? | 19:50 |
| lifeless | cjohnston: do you need to wrap it? | 19:50 |
| cjohnston | depends on how long you guys want it | 19:51 |
| lifeless | Dunno :). sinzui ? ^ | 19:51 |
| cjohnston | makes the line 124 char | 19:51 |
| sinzui | wrap what? in what | 19:52 |
| cjohnston | src="/@@/subscriber-inessential" | 19:52 |
| cjohnston | title="This person has indicated interest in the blueprint but is not required to be present at every discussion." | 19:52 |
| cjohnston | /> | 19:52 |
| sinzui | CSS rules in page do the wrapping for us. | 19:52 |
| cjohnston | in the file | 19:53 |
| cjohnston | template file I guess | 19:53 |
| sinzui | pt can be exempted from wrapping because of cases like this | 19:53 |
| cjohnston | ok. so a 124 char line is fine? | 19:54 |
| cjohnston | lifeless: just pushed, should be ready in a momeny | 19:55 |
| cjohnston | moment | 19:55 |
| sinzui | flacoste, I thought I deleted mailing-list-experts from production | 20:49 |
| flacoste | sinzui: feel free to merge it into oblivion | 20:49 |
| sinzui | The team is not used. It is only mentioned in Lp's comments | 20:49 |
| sinzui | oh, and those are disabled tests too | 20:49 |
| === almaisan-away is now known as al-maisan | ||
| === al-maisan is now known as almaisan-away | ||
| StevenK | wgrant: http://pastebin.ubuntu.com/1451041/ | 22:47 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!