| === mattuk1972_ is now known as mattuk1972 | ||
| bac | good morning frankban and teknico | 12:03 |
|---|---|---|
| frankban | hi bac | 12:03 |
| teknico | bac, good morning | 12:03 |
| bac | no mayan sightings in italy i presume | 12:04 |
| === mattuk1972_ is now known as mattuk1972 | ||
| teknico | bac, none that I know of | 12:13 |
| teknico | bac, trunk and uistage are both broken right now, gary_poster's branch in review fixes them | 12:30 |
| * bac looks | 12:32 | |
| teknico | just a fyi | 12:32 |
| bac | teknico: ok, i'll review it now | 12:33 |
| bac | frankban: are you working on gary's card or just reviewing it? (your face is on it) | 12:34 |
| bac | teknico: how is staging broken? is there anything heroic i can do to get it up in the short term? | 12:35 |
| bac | i can try to figure it out but wondered if you had thoughts | 12:35 |
| teknico | bac, frankban and I already reviewed that branch, we're only waiting for gary_poster to land it | 12:41 |
| teknico | bac, since trunk is broken, I assume staging also is as a consequence | 12:42 |
| bac | teknico: i don't see your review here: https://codereview.appspot.com/7005044 | 12:42 |
| bac | also neither of you added tags to the kanban card | 12:42 |
| bac | so i didn't think it was fully reviewed | 12:42 |
| bac | tsk, tsk | 12:42 |
| teknico | bac, right, sorry, the tags | 12:43 |
| teknico | bac, I'll add them now, it was a pair review, as apparent from the review text | 12:43 |
| teknico | oh, you added frankban's tag already, ok | 12:44 |
| teknico | I'm having lunch now | 12:44 |
| * gary_poster is about to land, teknico and bac | 12:48 | |
| bac | gary_poster: cool | 12:48 |
| bac | gary_poster: i'm logged into uistaging so let me know when it lands and i'll kick it in the shins | 12:51 |
| gary_poster | thanks bac. double checking then will let it fly | 12:51 |
| gary_poster | bac, done. note that the "build" directory will need to be manually removed--it is now called "build-shared." thanks again. | 12:56 |
| bac | gary_poster: i'll just let the cron job do it's thing at :00 | 12:57 |
| gary_poster | ok bac, but you may need to manually remove build still. Maybe after :00 though, yeah | 12:57 |
| bac | gary_poster: the cron job may blow everything away. let's wait and see | 12:58 |
| bac | ooh the excitement | 12:58 |
| gary_poster | ok | 12:58 |
| gary_poster | :-) | 12:58 |
| bac | T-75! | 12:58 |
| gary_poster | the tooth I had a root canal on officially cracked all the way through yesterday :-/ Gonna try to find someone who can pull it for me today so I don't have to worry about all during break | 12:59 |
| bac | ooh, yuck | 12:59 |
| gary_poster | yeah :-/ | 12:59 |
| bac | there is nothing left to put a crown on? | 12:59 |
| gary_poster | no, just two halves | 12:59 |
| bac | ugh. that's gross. i'm very squeamish about teeth issues | 13:00 |
| gary_poster | :-) sorry | 13:00 |
| gary_poster | dunno what uistage looked like before but seems to be happy now | 13:01 |
| benji | ooh, gary_poster; sorry to hear that | 13:07 |
| gary_poster | thanks :-/ | 13:09 |
| bac | gary_poster: so the update worked with no intervention | 13:09 |
| gary_poster | bac, awesome. I didn't know it blew things away | 13:10 |
| bac | that kapil is smrt | 13:10 |
| gary_poster | I mean, I expected it to work, I just didn't expect it to clear out the old build dir | 13:10 |
| gary_poster | :-) | 13:10 |
| hazmat | any preference on commercial cert vendors? godaddy, namecheap, thawte? | 13:51 |
| bac | thawte! | 13:52 |
| bac | nah | 13:52 |
| bac | not godaddy | 13:52 |
| gary_poster | I have a bad taste in my mouth from godaddy for various reasons, but that probably shouldn't influence you | 13:52 |
| bac | i like gandi.net for domain registration. they probably do certs. | 13:53 |
| hazmat | namecheap is like 10/usd yr.. comodo cert based | 13:53 |
| * hazmat checks gandi | 13:53 | |
| bac | i have a weird testing issue i haven't seen before. my 'before' gets called if i run the whole suite, but if i run just the one group of tests it does not. | 13:53 |
| bac | it jumps right into beforeEach | 13:53 |
| gary_poster | bac, benji has been having slightly related issues. his solution *might* affect your problem | 13:54 |
| bac | gary_poster: it seems to have happened after i merged your latest commit. :( | 13:54 |
| gary_poster | (if he doesn't jump in to describe it I remember what he told me :-) ) | 13:54 |
| gary_poster | huh | 13:54 |
| gary_poster | not sure what I would have done to influence that | 13:54 |
| bac | gary_poster: but i may have merged other versions of trunk earlier. can't recall the ordering. | 13:55 |
| gary_poster | bac, if you push your branch I can try to help | 13:55 |
| benji | bac: which is defined first, the before or beforeEach? | 13:55 |
| bac | before | 13:55 |
| benji | actually, that shouldn't matter because the tests (I assume) are defined after both | 13:55 |
| bac | before, beforeEach, afterEach, it, it | 13:56 |
| teknico | hazmat, I use gandi too, certificates included | 13:58 |
| teknico | hazmat, startcom is nice too: https://en.wikipedia.org/wiki/Comparison_of_SSL_certificates_for_web_servers | 13:58 |
| hazmat | teknico, thanks | 13:58 |
| bac | benji, gary_poster: more oddness. the problem only occurs with test-debug but not test-prod | 14:02 |
| benji | that is odd | 14:03 |
| gary_poster | bac, dunno. :-/ like I said, happy to dig in if you think it would help | 14:03 |
| benji | maybe the minifier is doing bad things to... something | 14:03 |
| gary_poster | he said prod was good, debug was bad | 14:03 |
| gary_poster | the minifier is automatically fixing our problems! | 14:04 |
| gary_poster | who knew that skynet started with a js minifier? | 14:04 |
| bac | gary_poster: you wanna pair or just grab the branch? | 14:04 |
| gary_poster | bac, your branch you choose. can do both | 14:05 |
| bac | let's go to g+:\\juju-ui | 14:05 |
| gary_poster | k | 14:05 |
| benji | heh | 14:08 |
| frankban | gary_poster: maybe we could consider byg 1086822 fixed? | 14:16 |
| frankban | bug 1086822 | 14:16 |
| _mup_ | Bug #1086822: charm is very slow to start <juju-gui:Triaged> < https://launchpad.net/bugs/1086822 > | 14:16 |
| gary_poster | frankban, yes! thank you | 14:16 |
| gary_poster | mark as fixed by frankban :-) | 14:16 |
| frankban | Cool, :-) first bug fixed between the coffee and the cigarette | 14:17 |
| bac | benji: fixed it. added 'done' to before() and it works. verified another test that didn't use 'done' was broken too and adding it was the cure. | 14:23 |
| bac | benji: add that to your test hygiene stuff you're presenting | 14:23 |
| benji | bac: interesting; was the before() doing anything asynchronous? Well, I guess it was. Rephrased: do you know what it was doing asynchronously? | 14:24 |
| * benji wonders when he started doing a presentation. | 14:24 | |
| bac | no | 14:24 |
| bac | benji: gary said you had a list of things to clean up tests. perhaps i misinterpreted | 14:25 |
| bac | benji: the before just grabbed namespace references | 14:25 |
| bac | juju = Y.namespace('juju'), etc | 14:26 |
| benji | bac: hmm, I wonder if the done() call is adding just enough delay that the YUI modules get loaded. If you are interested in experimenting, remove the done() and put in a busy wait that counts to 100000 or so before the namespace grabbing. I bet it will work just as well. | 14:27 |
| bac | benji: any theories on why it only occurs when running a test in isolation? | 14:28 |
| benji | my hypothesis is that when run with other tests the modules have already loaded before the test is even started, so there is no race; when run in isolation there is a race between the (asynchronous) test runner and the (asynchonous) YUI module loader | 14:29 |
| bac | benji: i removed the done and added this: | 14:32 |
| bac | while (!Y.Lang.isValue(models)) { | 14:32 |
| bac | models = Y.namespace('juju.models'); | 14:32 |
| bac | } | 14:32 |
| bac | and it works | 14:32 |
| benji | much more elegant than a busy wait | 14:32 |
| bac | benji: but i put the trap around the getting of juju which happens before, and models was still undefined | 14:32 |
| bac | i thought they might all come available about the same time, but no | 14:33 |
| benji | nope... ASYNCHRONOUS! | 14:33 |
| benji | in 1000 years "asynchonous" may be a swear word | 14:34 |
| bcsaller1 | ... still be a swear word | 14:34 |
| === bcsaller1 is now known as bcsaller | ||
| bac | benji: i read your previous comment as "ASYNCHRONOUS, BABY!" in the voice of dick vitale, fwiw | 14:35 |
| benji | heh | 14:35 |
| bac | so, in summary, the use of 'done' is an unrelated hack that just happens to work and muddies the water? | 14:37 |
| benji | that is my strong hunch | 14:37 |
| hazmat | ugh | 14:42 |
| hazmat | benji, bac does it matter if we pass async: false to the loader | 14:42 |
| benji | hazmat: that helps some (and that is what my branch does; which I hope to land today) | 14:43 |
| benji | I believe there is still a race even with that. And I haven't been able to figure out how to remove it. | 14:43 |
| bac | benji: with your branch try running 'juju application notification' in isolation | 14:44 |
| benji | k | 14:44 |
| benji | bac: 10 runs, all passed | 14:45 |
| bac | good. in the name of science, try on trunk? | 14:45 |
| benji | sure | 14:46 |
| benji | bac: does test-prod or test-debug matter? | 14:46 |
| bac | yes. i only see it fail on test-debug | 14:47 |
| benji | k, that is what I used for running the test on my branch | 14:47 |
| benji | three good runs and then "Uncaught TypeError: Cannot read property 'Database' of undefined" | 14:48 |
| benji | 10 runs, 1 with that error | 14:48 |
| benji | not a statistically significant difference between the two tests | 14:48 |
| bac | that is the error i see | 14:55 |
| bac | but i get it all of the time | 14:55 |
| benji | bac: one thing to remember is that I have a slow computer, so the races seem to affect me less | 14:56 |
| hazmat | argh have to setup email on jujucharms.com to finish the cert setup | 14:56 |
| bac | benji: well i'm on a fast, new, shiny computer but running in a vm | 14:57 |
| hazmat | bac.. mac? | 14:57 |
| hazmat | just curious | 14:57 |
| bac | hazmat: yeah, i looked around, considered the sputnik but couldn't live with the lower res and smallish display | 14:58 |
| * hazmat tries to remember how to setup a mail server | 15:11 | |
| hazmat | ah.. google you've made it so easy to forget so much | 15:11 |
| benji | hazmat: step one, get a google apps account :) | 15:12 |
| benji | heh | 15:12 |
| hazmat | benji, i would have except now they want folks to pay for it. | 15:12 |
| * hazmat bails out to postfix | 15:12 | |
| benji | yeah, I had been meaning to set up my kids' email for a while and now I had to pay for it :( | 15:12 |
| benji | but I've been using apps for free for about five years, so I don't feel to bad about it | 15:13 |
| gary_poster | bac bcsaller benji frankban hazmat Makyo teknico_ call in 2 | 15:28 |
| hazmat | ah.. email used to be so much simpler.. i think i need domain keys setup | 15:28 |
| === mattuk1972_ is now known as mattuk1972 | ||
| mattuk1972 | see ya juju team -all the best for 2013 - its been a pleasure | 16:27 |
| hazmat | mattuk1972 have a good one | 16:29 |
| hazmat | mattuk1972, its been fun, good luck on the future | 16:29 |
| hazmat | bac, testing out notification tests in isolation | 16:32 |
| gary_poster | I think everybody was on depressants for that call :-P | 16:33 |
| bac | hazmat: yes, that test fails in isolation as written | 16:33 |
| bac | hazmat: is that what you are asking? | 16:34 |
| hazmat | bac, yes | 16:34 |
| bac | hazmat: and for that particular test, adding 'done' to 'before' makes it work | 16:34 |
| bac | it looks to be related to what benji described with YUI and mocha async interactions. that test has before using the YUI.use() style setup | 16:35 |
| bac | hazmat: unrelated, you assigned a card to francis, which is probably not what you intended. | 16:35 |
| hazmat | doh | 16:35 |
| gary_poster | :-) | 16:36 |
| hazmat | assigned a card to posterity, today's his last | 16:36 |
| hazmat | bac, which card? | 16:37 |
| === teknico_ is now known as teknico | ||
| hazmat | bac, there's also some interaction with the browser cache trying to make these tests work, i either get a blank page, js error loading utils.js (registerHandler for handlebars), the database undefined error, or working tests. | 16:40 |
| hazmat | er blank page with the util.js error | 16:40 |
| benji | yep, I think the behavior around caching is part of the (or "a") race; loading the resources changes the timeings a bit | 16:41 |
| hazmat | isolating just the notifiy tests in index.html makes things a little bit more sane | 16:43 |
| hazmat | <!-- other tests --> | 16:43 |
| gary_poster | oh benji, I thought we had a card to discuss your test pattern :-/ | 16:43 |
| hazmat | leads to a new non failure, failure mode.. where the test runner finds no tests, and no console errors. | 16:43 |
| gary_poster | I forgoy yp ask you to talk about it explicitly | 16:44 |
| hazmat | but also run sometimes | 16:44 |
| gary_poster | s/yp/to/ | 16:44 |
| benji | hazmat: that failure mode is the one I was getting in my branch | 16:45 |
| hazmat | benji, why are there two different styles here? | 16:46 |
| hazmat | describe wrapper vs yui wrappre? | 16:46 |
| hazmat | the describe wrappers seem to be better behaved with the async: false | 16:46 |
| benji | I don't know for sure, I suspect people just tried different things at different times. | 16:47 |
| hazmat | benji, ic... from history you added it to the test_notifications.js ... i'm going to remove that .. that's the issue with the non failure / failure | 16:49 |
| teknico | hazmat, anyone else, does it make sense to try to connect to rapi via wss (encrypted) if the gui browser access is not happening via https? | 16:50 |
| hazmat | teknico, no | 16:51 |
| hazmat | teknico, commonly the cert for the wss is not valid without user ack | 16:51 |
| hazmat | so the wss won't load/connect | 16:51 |
| teknico | oh right, was forgetting about that | 16:51 |
| * hazmat grabs some coffee bbiam | 16:52 | |
| hazmat | benji, confirmed that was the issue | 17:02 |
| hazmat | test notifications running reliably now.. | 17:03 |
| hazmat | hmm.. no reviews on that commit? | 17:04 |
| hazmat | https://codereview.appspot.com/6845084 | 17:04 |
| hazmat | that turns the actual fix into a one liner.. | 17:06 |
| hazmat | hmm.. firefox doesn't like extra param to the replace | 17:11 |
| gary_poster | hazmat the yui wrapper was the solution thiago had advocated, that we tried for a while and then agreed relatively recently to discard. So basically reverting https://codereview.appspot.com/6845084/diff/2002/test/test_notifications.js is the fix you have found? (I have been unable to dupe some people's errors, btw, so just because it works on one machine unfortunately does not guarantee it is a solution for others | 17:11 |
| gary_poster | , IME on this stuff) | 17:11 |
| hazmat | gary_poster, in conjunction with async: false.. i'm still playing with it.. trying to make tests run in firefox | 17:12 |
| gary_poster | cool | 17:12 |
| hazmat | teknico, frankban did you guys have success with the gallery / loader issue? | 17:12 |
| teknico | hazmat, gary_poster did :-) | 17:13 |
| hazmat | cool | 17:13 |
| hazmat | gary_poster, what was the solution? | 17:13 |
| gary_poster | hazmat, change the base and explicitly host the gallery files ourselves | 17:13 |
| hazmat | cool | 17:14 |
| gary_poster | lunch and car to shop. biab | 17:15 |
| hazmat | working in firefox reliably as well. needs a tweak to mocha timeout | 17:26 |
| hazmat | still some odd interactions between suits | 17:27 |
| hazmat | ugh.. ordering issues | 17:28 |
| hazmat | running application_notifications tests before notification tests fails, but works fine in reverse | 17:28 |
| hazmat | apologies, i'm in blather mode | 17:28 |
| teknico | hazmat, when I run "juju deploy local:precise/juju-gui" and I have changes in the local copy | 17:29 |
| teknico | hazmat, what's deployed, the modified local copy, or the latest committed revision? | 17:29 |
| hazmat | teknico, if its already been deployed in the env.. it will use the cache copy | 17:29 |
| teknico | hazmat, I run "juju destroy _environment" every time | 17:30 |
| hazmat | teknico, so two axis.. one is namespace.. cs: vs local: | 17:30 |
| hazmat | teknico, those are separate charms to juju so it will always deploy what you tell it | 17:30 |
| hazmat | teknico, second axis.. juju caches charms in the environment.. so if you update a charm locally and try to deploy again without incrementing the revision, it will deploy the older version | 17:31 |
| hazmat | teknico, there's a -u/--upgrade flag on deploy | 17:31 |
| hazmat | teknico, that will automatically increment the revision | 17:32 |
| teknico | hazmat, oh, right, the revision | 17:32 |
| hazmat | teknico, i suggest always using deploy -u local:precise/juju-gui | 17:32 |
| teknico | hazmat, and running destroy_environment does not change anything, right? | 17:32 |
| hazmat | teknico, it doesn't.. its stored in the control bucket which survives the env | 17:32 |
| teknico | hazmat, great, thanks for the -u tip | 17:33 |
| hazmat | i heard some rumor that juju-core may end up storing/deploying all the charms via git | 17:33 |
| hazmat | i presume to address this issue | 17:33 |
| hazmat | of easy mutability | 17:34 |
| teknico | hazmat, via git? ;-o | 17:34 |
| teknico | while working with juju, gnome-keyring-daemon blowing up and forcing me to enter gazillion passphrases is not exactly helping... | 17:36 |
| hazmat | teknico, bad session? | 17:36 |
| teknico | hazmat, it's been happening right after login for a few days now | 17:37 |
| teknico | hazmat, how do I clean up the session? | 17:37 |
| hazmat | teknico, i'd retry logout/login | 17:37 |
| hazmat | or reboot if that fails | 17:38 |
| hazmat | teknico, alternatively use a passwordless ssh key | 17:38 |
| teknico | hazmat, it's happened on login right after boot for a few mornings now | 17:38 |
| hazmat | for the env | 17:38 |
| hazmat | er.. juju | 17:38 |
| teknico | hazmat, uhm, yeah, where's it configured? | 17:38 |
| hazmat | teknico, https://juju.ubuntu.com/docs/provider-configuration-ec2.html see authorized-keys-path | 17:39 |
| hazmat | or alternatively authorized-keys | 17:39 |
| teknico | ok | 17:41 |
| frankban | hum... I am seeing "error: old chunk mismatch" in all files in my MP (at least in the side by side view)... | 17:51 |
| hazmat | frankban, we saw that a few days ago in another mp. i would suggest trying to propose again | 17:52 |
| hazmat | not sure what triggers that | 17:53 |
| frankban | hazmat: trying... | 17:53 |
| frankban | hazmat: patch set #2 works, thanks | 17:54 |
| teknico | uhm, I'm getting: "Uncaught INVALID_STATE_ERR : Pausing to reconnect websocket" | 17:59 |
| teknico | I think I need a way to locally test encrypted connections to rapi first | 18:00 |
| benji | has anyone seen this error when trying to send data down the websocket? "INVALID_STATE_ERR: DOM Exception 11" | 18:02 |
| benji | the Internet says that it is because the ws isn't ready, but I am gating the call on env.get('connected') which is set from the we.on_open handler, so it should really be ready. | 18:03 |
| hazmat | benji, which browser / version? | 18:03 |
| benji | hazmat: Chromium. | 18:04 |
| benji | version = whatever is current in 12.10 | 18:04 |
| hazmat | 22 then.. offhand not sure, i'd check the logs from the improv/websocket side just as a sanity check.. or from the browser net panel | 18:06 |
| bcsaller | https://github.com/mbostock/d3/wiki/3.0 | 18:06 |
| hazmat | bcsaller, benefits? | 18:07 |
| bcsaller | hazmat: not clear yet how much it impacts us, but the delta to support it looks small so its worth tracking the upgrade | 18:08 |
| bcsaller | the smooth zooming plugin made it in tough, we might want to use that | 18:09 |
| hazmat | bcsaller, yeah.. the upgrade notes dont look like they'll hit us that bad | 18:09 |
| hazmat | https://github.com/mbostock/d3/wiki/Upgrading-to-3.0 | 18:09 |
| hazmat | not sure though.. haven't looked at the env code in a while | 18:09 |
| benji | hazmat: ooh, it is something about the ws not being ready even though env.get('connected') is true: instead of calling the login RPC right away, I put it in a setTimeout for one second later and the call worked | 18:12 |
| hazmat | benji, we've got a transparently reconnecting websocket.. as well.. so reconnects could be happening.. connected should work unless there's a reconnect happening | 18:13 |
| hazmat | benji, does it fail reliably? | 18:14 |
| hazmat | without the timeout | 18:14 |
| benji | from the improve.py log it doesn't look there are any reconnects happening | 18:14 |
| benji | yep, very reliably | 18:14 |
| hazmat | i wonder if we're firing connected to early then | 18:14 |
| hazmat | benji, login should happen after the server greeting | 18:15 |
| benji | hazmat: hmm, that may be it, env.get('connected') means the WS is connected, not that the server is ready | 18:16 |
| benji | I can change around my event sending so it will happen after the greeting | 18:16 |
| benji | another question, does the server conform to this: http://paste.ubuntu.com/1397723/ | 18:16 |
| hazmat | hmm.. not quite.. the error suggests something more fundamental.. the message would still go down the wire to the server | 18:16 |
| benji | ah, indeed | 18:17 |
| hazmat | but in the interests of being well behaved, we shouldn't login till we get a helo from the server | 18:17 |
| benji | well, if I wait until after the welcome message it will work either way | 18:17 |
| hazmat | that's fairly classic for network old-school net protocols (pop, imap, etc) | 18:17 |
| benji | re. conforming interface: it doesn't look like it | 18:17 |
| benji | yep | 18:17 |
| hazmat | making good progress on the testing front fwiw | 18:19 |
| * hazmat grabs some food | 18:19 | |
| benji | hazmat: does the login process work like this: http://paste.ubuntu.com/1397723/ | 18:19 |
| benji | or I should say, it doesn't look like it works like that | 18:19 |
| hazmat | benji, right.. login isn't required atm, till we have the ability to login.. else everything would break. | 18:20 |
| hazmat | benji, but the login flow should be the same | 18:20 |
| benji | hazmat: in particular I am not getting and {'op': 'login', 'result': 'success', ...} messages | 18:20 |
| benji | s/and/any/ | 18:20 |
| hazmat | benji, that's a bug/broken then in rapi | 18:21 |
| hazmat | benji, what do you get on the wire in response to send_rpc login? | 18:21 |
| benji | hazmat: I get a {"log": [["info", "Login success"]], "request_id": 2, "user": "admin", "op": "login", "password": "admin", "result": true} back | 18:21 |
| benji | I could use that to know if the login was successfull or not, but "log" messages sound like something that could be turned off. | 18:22 |
| bac | hi bcsaller, i have questions about the zoomHandler and rescale | 18:23 |
| hazmat | benji, yeah.. the current structure on the log messages isnt optional.. it was to help the wrapping on cli stuff for feedback, i could disable the message for the login method, but its still going to come back with an emty log array | 18:24 |
| hazmat | so that looks correct just w/ a delta to the initial proposal | 18:24 |
| bac | bcsaller: nm | 18:25 |
| benji | so I should be using the log message to know whether or not the login was successful, right? | 18:25 |
| hazmat | benji, result: true | 18:25 |
| benji | cool, thanks | 18:25 |
| hazmat | benji, if it fails .. there will be an err: true instead per the pastebin | 18:26 |
| benji | k | 18:26 |
| teknico | gary_poster, I proposed my branch, but maybe shouldn't have, I added some disclaimers to not land without further testing | 18:26 |
| teknico | gary_poster, it's also going to conflict with frankban's branch, that I also reviewed | 18:27 |
| teknico | since it's EOY now, I thought I'd better put it out there so that it can be completed | 18:29 |
| gary_poster | thanks teknico | 18:30 |
| gary_poster | If I have time I might try to resolve for the heck of it | 18:30 |
| gary_poster | it would be cool to have this stuff really done :-) | 18:30 |
| teknico | and for the heck of the objectives, yeah :-) | 18:30 |
| gary_poster | teknico, you say "Also, this is not yet working while deploying manually, and needs | 18:31 |
| gary_poster | further testing. Do not land without checking first." | 18:31 |
| gary_poster | so, my crazy story would be this: | 18:31 |
| gary_poster | - get frankban's branch. | 18:32 |
| gary_poster | - turn https back on | 18:32 |
| gary_poster | (hacking branch) | 18:32 |
| gary_poster | try it out | 18:32 |
| gary_poster | - merge your branch | 18:32 |
| gary_poster | -resolve whatever needs to be resolved | 18:32 |
| gary_poster | - try it out | 18:32 |
| gary_poster | - (you say it won't work without some tweaks) | 18:32 |
| gary_poster | (so fix tweaks) | 18:33 |
| gary_poster | - profit! | 18:33 |
| gary_poster | which might mean trying to land the combined branches | 18:33 |
| gary_poster | yeah? | 18:33 |
| teknico | gary_poster, that sounds like an eminently reasonable plan :-) | 18:33 |
| gary_poster | heh ok :-) | 18:33 |
| gary_poster | thanks teknico | 18:33 |
| gary_poster | teknico, frankban have a great holiday break! | 18:33 |
| gary_poster | see you in 2013 | 18:33 |
| teknico | well, frankban's branch will likely be landable without problems | 18:34 |
| teknico | but that's details :-) | 18:34 |
| teknico | so, happy holidays everyone, and see you in the new year! | 18:34 |
| bac | bye teknico. have a nice break | 18:44 |
| frankban | bye all, and happy holidays | 18:47 |
| hazmat | frankban, teknico happy holidays | 18:49 |
| * hazmat tries to deciper.. TypeError: Cannot read property 'charm-search-result' of undefined | 18:50 | |
| gary_poster | template is not compiled/included? | 18:51 |
| gary_poster | that assumption that Templates is on juju-views module might simply be fragile | 18:53 |
| gary_poster | looks reasonable on the face of ith though | 18:54 |
| Makyo | Things work, tests pass, yuidoc explodes. Ah well. | 18:59 |
| gary_poster | Makyo, you know we have the helper command to make that disappear, right? | 19:00 |
| gary_poster | yuidoc-lint complaints, I mean--I assum that's what you are talking about | 19:01 |
| hazmat | gary_poster, bad dependencies it looks like | 19:02 |
| hazmat | gary_poster, charm-panel.js didn't declare its use of juju-templates | 19:03 |
| Makyo | gary_poster, What was the command again? I can get the ones that are just improperly formatted, at least. | 19:06 |
| gary_poster | hazmat, looks like I have to restart. Makyo lemme see if I can find it before I do | 19:07 |
| hazmat | ack | 19:07 |
| gary_poster | Makyo, ``make undocumented`` | 19:07 |
| === gary_poster is now known as gary_poster|away | ||
| Makyo | Thanks | 19:08 |
| === gary_poster|away is now known as gary_poster | ||
| benji | hazmat: that error is one I have seen too; it happens when the Templates data structure has not been define yet | 19:21 |
| hazmat | benji, yeah.. it looks like charm-panel wasnt including the dep, i included and got to a diff errr | 19:22 |
| Makyo | gary_poster, Should I propose and work on docs in the meanwhile? | 19:22 |
| hazmat | gary_poster, instead of rebooting again, let's table to next year ? | 19:23 |
| gary_poster | hazmat bah | 19:23 |
| gary_poster | ok :-) | 19:23 |
| gary_poster | have a nice holiday | 19:23 |
| benji | I never could figure out how the templates got loaded. I'm glad you fixed it. | 19:23 |
| gary_poster | Makyo, you mean while you are waiting on reviews? docs would be good, or maybe bac or bcsaller could use a pair? | 19:24 |
| bac | i'm good. just slogging through tests. | 19:25 |
| Makyo | gary_poster, Yeah, that's what I was thinking. On lunch now, but can do whatever's best after. | 19:25 |
| gary_poster | Makyo, cool. frankban and teknico have charm branches that need reviews. If your branch is up for review I'll also try to get to it ASAP | 19:25 |
| gary_poster | talk to you after lunch | 19:25 |
| * gary_poster restarts :-/ (G+ hangouts normally are not quite this flaky for me!) | 19:26 | |
| === gary_poster is now known as gary_poster|away | ||
| === gary_poster|away is now known as gary_poster | ||
| hazmat | aha.. forgot to poke a hole in the security group for inbound mail | 19:42 |
| hazmat | aha. working email | 19:59 |
| gary_poster | hazmat, is this complaint from rapi? does it indicate anything to you? http://pastebin.ubuntu.com/1455528/ | 20:07 |
| gary_poster | that is from a test run | 20:08 |
| gary_poster | Makyo, "with undocumented methods and custom events, may get larger yet": undocumented methods were pre-existing though, yeah? | 20:11 |
| Makyo | gary_poster, Yes, they just moved to different files, so the undocuented file didn't list them. | 20:18 |
| gary_poster | Makyo, then don't worry about it for this round :-) | 20:19 |
| Makyo | gary_poster, Alright. May still need to document events fired, as was done with panzoom, but something for later. | 20:19 |
| bac | hi bcsaller | 20:21 |
| hazmat | gary_poster, its indicating the ws client is not valid | 20:21 |
| bcsaller | bac: one sec, on a call with gary | 20:21 |
| bac | ok | 20:21 |
| hazmat | gary_poster, and then terminating the connection | 20:21 |
| hazmat | and yes its from rapi | 20:21 |
| gary_poster | hazmat, oh, right. that may be ok then. tests are failing for me | 20:22 |
| hazmat | i assume this is from a wget to the endpoint in a unit test | 20:22 |
| bcsaller | bac: whats up? | 20:22 |
| bac | bcsaller: in panzoom/rescale fcn at the end it fires a 'rescaled' event. is anyone using that right now? | 20:23 |
| gary_poster | hazmat, yeah. charm tests use a simple http check to see if the ws is there, and expect an error. That's a red herring for whatever the problem is. thank you | 20:23 |
| bcsaller | bac: not as of that branch, but the viewport code and some of the menu repositioning code in service will | 20:24 |
| bac | bcsaller: can we do a quick chat? | 20:25 |
| bcsaller | yeah, I'll see if normal g+ is open | 20:25 |
| bcsaller | bac: it is | 20:25 |
| Makyo | bac, bcsaller relations uses it. | 20:29 |
| bcsaller | bac: froze there | 20:30 |
| Makyo | gary_poster, ready when you are for call. | 20:33 |
| bcsaller | Makyo: when you're done with the call give me a ping please | 20:40 |
| Makyo | bcsaller, Free now. | 20:40 |
| bcsaller | Makyo: getting on g+ | 20:40 |
| benji | allrighty, the login branch is available for review at https://codereview.appspot.com/7007047 | 20:54 |
| benji | after I take a short break I will see if anyone else needs reviews | 20:54 |
| bac | hazmat: i just got golang 1.0.2 and rebuilt lbox using it. i still see the same problem authenticating. | 21:00 |
| hazmat | argh | 21:00 |
| hazmat | bac, clean build, sure about the executable ? | 21:00 |
| hazmat | its possible they've slipped for multiple releases but that's sad | 21:01 |
| bac | hazmat: oh, wait it is an old executable | 21:02 |
| hazmat | gary_poster, cert should be in place by eod, just configuring nginx | 21:16 |
| hazmat | going to run an errand, bbiab | 21:16 |
| gary_poster | thanks hazmat | 21:17 |
| * gary_poster has to go back to car shop | 21:17 | |
| bac | Makyo: could you review my panzoom test branch? | 21:21 |
| Makyo | bac, in a bit | 21:21 |
| bac | thanks | 21:21 |
| bac | maybe it'll be on rietveld by then | 21:21 |
| benji | yow, after merging in the trunk I get massive test failures | 21:35 |
| benji | "Uncaught TypeError: Cannot read property 'notifier' of undefined" | 21:36 |
| * Makyo dogwalkinates. | 21:38 | |
| gary_poster | benji, any resolution on that? | 21:52 |
| benji | gary_poster: nope; I am pretty sure it is another initialization race, but I haven't figured it out yet. | 21:54 |
| gary_poster | ok benji. I think hazmat may have a fix-all-the-tests branch coming up | 21:54 |
| benji | hmm, that is interesting: GET /juju-ui/templates.js 404 1ms - 54 | 21:54 |
| gary_poster | but I know that's not very satisfactory | 21:54 |
| hazmat | gary_poster, incidentally your consistency in testing may be the result of browser cache | 21:55 |
| gary_poster | hazmat, maybe so | 21:57 |
| gary_poster | though I do clear it out for various reasons | 21:57 |
| benji | ahh, a "make clean" and "make build" cleared up the tempate.js 404; it must have moved | 21:58 |
| benji | most of the tests pass on my branch now | 21:58 |
| gary_poster | um. I think d3 just changed all their file names in their npm package. | 22:07 |
| gary_poster | ah. | 22:08 |
| gary_poster | we are getting 3.0.0 | 22:08 |
| bac | i'm going to call it a day. i'll check back later and land my branch if it gets favorable reviews. | 22:12 |
| benji | well, I guess I have a race to fix in the new year; see you guys then | 22:13 |
| gary_poster | sounds good bac. I want to go take a break too. Have a great holiday. I'll shoot you a review in a bit if noone else has | 22:13 |
| bac | hope everyone has a good break. | 22:13 |
| gary_poster | benji have a great break | 22:13 |
| benji | gary_poster: thanks, you too! | 22:13 |
| * bac o/ | 22:13 | |
| gary_poster | hazmat, bcsaller, Makyo, have a great holiday, & see you in 2013! | 22:14 |
| Makyo | See ya :) | 22:14 |
| bcsaller | :) | 22:14 |
| hazmat | gary_poster, happy holidays | 22:14 |
| === gary_poster is now known as gary_poster|away | ||
| hazmat | <hazmat> still a work in progress.. but its up.. https://jujucharms.com/ | 23:31 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!