therve | hazmat, https://code.launchpad.net/~therve/juju/rapi-uuid/+merge/143662 adds the UUID to the API | 11:03 |
---|---|---|
therve | I hope that makes sense, let me know if I miss something | 11:03 |
hazmat | therve, cool. i've got an in progress branch that requires login.. | 11:10 |
hazmat | therve, also merge proposal target should be the rollup branch (i resubmitted the mp) | 11:10 |
hazmat | therve, looks good though | 11:11 |
hazmat | thanks | 11:11 |
therve | hazmat, thank you! | 11:17 |
hazmat | gary_poster, benji i don't suppose either of you have that login required communication pastebin link | 11:57 |
gary_poster | hazmat not sure what you are asking for | 13:09 |
hazmat | gary_poster, just trying to work out if 'login-required' was in the greeting or if there was a separate not auth greeting | 13:16 |
hazmat | currently we're disclosing provider type and soon uuid in the greeting | 13:16 |
hazmat | we had a pastebin text doc we passed around as an example | 13:17 |
hazmat | just trying to locate a ref to it | 13:17 |
gary_poster | oh | 13:17 |
gary_poster | I think I know what you mean | 13:17 |
gary_poster | but benji told me it was pretty different from what ended coming from juju. may be misremembering. I can find, one sec | 13:18 |
gary_poster | hazmat, http://paste.ubuntu.com/1397723/ ? | 13:19 |
hazmat | gary_poster, thanks | 13:19 |
benji | yeah, that doesn't match reality (at least the reality that existed when I was working on the branch) | 13:19 |
hazmat | benji, well it wasn't required before... so no. but my current branch makes it required.. just wanted to match more closely to that doc | 13:24 |
benji | sounds good | 13:25 |
gary_poster | bug for these backend changes is bug 1074419 fwiw | 13:25 |
_mup_ | Bug #1074419: Enable simple user & password login to rapi-rollup websocket <deploy-story> <juju-gui:Triaged by hazmat> < https://launchpad.net/bugs/1074419 > | 13:25 |
hazmat | gary_poster, https://plus.google.com/hangouts/_/7eba46242c127e6b2d38ec9e3db2a8a5898dece9 re rapi | 13:34 |
gary_poster | thanks hazmat. forgot to press Join :-P | 13:34 |
gary_poster | frankban, it strikes me that bac's approach of protecting within the login method is nice in that it also protects from the unlikely but possible situation of someone typing in a password in the login page and submitting it before the connection is ready. I suppose we could not draw the login page in that case...but something else to consider. One other edge case to consider is whether multiple login requests migh | 14:52 |
gary_poster | t be pending. Maybe not an issue, but just came to my mind. | 14:52 |
frankban | gary_poster: ack | 14:53 |
gary_poster | thx | 14:54 |
gary_poster | frankban, https://codereview.appspot.com/7138054/ : land as is, thank you | 14:56 |
frankban | gary_poster: cool, thanks | 14:57 |
frankban | gary_poster: just for curiosity, is there a reason why we don't indent if blocks in our makefile? | 14:58 |
gary_poster | frankban, probably because didn't know we could, within the context of these macros. I think indentation has meaning, and macros don't dedent. If it works though I agree that it would definitely increase readability | 14:59 |
frankban | gary_poster: ok, I'll add a slack card to investigate that | 15:02 |
=== _mup__ is now known as _mup_ | ||
gary_poster | bcsaller, benji frankban goodspud hazmat teknico call in 1 | 15:29 |
hazmat | http://paste.ubuntu.com/1537964/ | 15:41 |
hazmat | top 50 charms by download including inflation from gui simulation | 15:41 |
* gary_poster has to run go pick up car from repair. back in 30 | 15:44 | |
goodspud | I've just shared the link in the Canonical juju-gui room to the current set of wireframes for the "vision" piece | 15:48 |
goodspud | Ale is presenting a reduced set from this to Mark in 10 mins | 15:49 |
goodspud | "Alejandra" | 15:49 |
benji | I have a review up at https://codereview.appspot.com/7129049 | 16:14 |
gary_poster | on it | 16:15 |
benji | frankban: was I going to review something for you? I don't see anything on the board. | 16:15 |
gary_poster | Nicola beat you to punch | 16:15 |
frankban | benji: teknico did that review, thanks | 16:16 |
benji | k | 16:16 |
teknico | bcsaller, can you help me with understanding a test behavior? no hurry | 16:33 |
bcsaller | teknico: sure, hangout? | 16:33 |
teknico | bcsaller, yeah, https://plus.google.com/hangouts/_/02bb45411739e441fe107c9f66e2a8cc36ba4ba7?authuser=0&hl=en# | 16:34 |
goodspud | Good news. Mark has given the thumbs up to the concept | 16:51 |
* benji takes an early lunch. | 16:58 | |
teknico | why is bzr pushing way more stuff than usual? o.O | 17:23 |
gary_poster | congrats goodspud | 17:34 |
gary_poster | benji, land with changes, thank you | 17:34 |
benji | gary_poster: I replied to your review. There are a couple of small discussions therein. | 19:27 |
gary_poster | benji, on call, will look soon | 19:28 |
benji | k | 19:28 |
gary_poster | benji looks great. I'm fine with all of your decisions, but will try to succinctly reply in line to the various questions/points you raised. Wish me luck on the "succinctly" part ;-) | 19:54 |
* benji lends gary_poster a -q | 19:54 | |
gary_poster | :-) thanks | 19:54 |
benji | :) | 19:54 |
gary_poster | benji, made simple replies. summary: cool, sounds good, and you should eat chocolate ice cream. | 20:03 |
gary_poster | benji, maybe once you have a new version made you can ping bcsaller and see if he can review. He's the only one we have today. (bcsaller, talking about https://codereview.appspot.com/7069068) | 20:04 |
benji | sounds good | 20:05 |
benji | chocolate is my favorite flavor of ice cream | 20:06 |
gary_poster | :-) | 20:10 |
benji | bcsaller: I will gladly pay you Tuesday for a review of https://codereview.appspot.com/7129049 today. | 20:32 |
bcsaller | benji: I can look it over in a minute | 21:35 |
bcsaller | didn't see this before | 21:36 |
hazmat | require login for ws branch in review.. https://codereview.appspot.com/6935068/ | 23:21 |
hazmat | also in card | 23:23 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!