* StevenK stabs specification filtering01:24
StevenKTwo methods use SpecificationFilter.{ACCEPTED,PROPOSED,DECLINED} for utterly different things01:25
wgrantSeries and sprints?01:28
StevenKThe sprint stuff doesn't use search_specifications(), it's just too wacky01:28
StevenKBack down to one failure01:29
wgrantStevenK: https://code.launchpad.net/~wgrant/launchpad/handleStatus-refactor-2/+merge/14420301:56
StevenKwgrant: r=me, perhaps you could run update-copyright. I'm a little concerned about the BUILDERFAIL method now, you just reset the BQ record, and merrily go on your way.02:43
wgrantStevenK: The thing is that BQ.reset already sets the status to NEEDSBUILD02:44
wgrantBut I think BUILDERFAIL is the case that causes some of the broken builds we occasionally see02:44
wgrantSo it probably already doesn't work for some reason anyway :/02:44
wgrantIt'll all be reworked when BFJO dies soonish02:44
StevenKwgrant: Right03:13
StevenKwgrant: I've been staring at this failure for too long. Can haz help?03:37
wgrantStevenK: Sure03:37
StevenKwgrant: http://pastebin.ubuntu.com/1557408/ is the diff (It's -r submit:, so should include everything)03:38
StevenKwgrant: lp.registry.tests.test_person.TestSpecifications.test_in_progress is the failing test, which is failing since the query is returning both the STARTED and IMPLEMENTED specs03:39
wgrantStevenK: Looking03:44
wgrantStevenK: Look around line 1170 of the diff03:52
wgrantin_progress was previously handled inside a "COMPLETE not in filter" guard03:52
wgrantWhich also added an INCOMPLETE filter03:53
StevenKBah, and that fixes it03:55
StevenKAdding INCOMPLETE to the block was probably the kicker03:55
wgrantIs it really worth having a separate in_progress flag on the underlying method?03:55
wgrantShould Person.specifications just map it to (STARTED, INCOMPLETE)?03:55
StevenKI can drag that bit back to Person.specifications03:56
wgrantIt doesn't seem valuable to have that flag on the underlying infrastructure03:58
wgrantGiven only a single method exposes it03:58
* StevenK refactors the second if default_acceptance block out04:04
StevenKwgrant: https://code.launchpad.net/~stevenk/launchpad/use-specification-aag/+merge/143630 updated05:12
wgrantStevenK: That's quite a diff05:14
wgrantI may be a while05:14
StevenKwgrant: Do you want a rope around the waist so you don't get lost? :-)05:15
wgrantCan you do the neck instead?05:15
wgrantStevenK: Are Milestone and Sprint likely to be portable?05:21
StevenKwgrant: I've run out of steam05:23
StevenKMilestone.getSpecifications() is nothing like anything else, and wants people too05:24
StevenKSo that's a bit difficult05:24
wgrantStevenK: For in_progress, I was hoping you could just add INCOMPLETE and STARTED to the filter.05:24
wgrantAlthough I'm not sure if those filters are meant to be unioned or intersected.05:25
StevenKOh, spec_filter.extend([INCOMPLETE, STARTED]) and get_specification_filters adds get_specification_started_clause ?05:25
StevenKThose filters are a mess05:25
wgrantDepends if they intersect or union05:25
wgrantBut I was hoping to keep all those workflow filters in one place05:26
StevenKAttributeError: type object 'SpecificationFilter' has no attribute 'STARTED'05:28
StevenKNo clean up for you05:29
wgrantStevenK: Sure, it probably doesn't exist already05:29
wgrantBut that doesn't mean it shouldn't.05:29
StevenKwgrant: Right, so that's been abstracted back into search_specifications05:32
StevenKwgrant: http://pastebin.ubuntu.com/1557550/05:32
wgrantStevenK: I think you double-join product a couple of times, don't you?05:35
wgrantAs search_specifications includes the Product.active filter05:35
StevenKwgrant: Which callsites do you suspect do so?05:36
wgrantStevenK: ProjectGroup.specifications05:36
wgrantThough it doesn't rejoin Product, it does duplicate Product.active05:36
StevenKwgrant: Right, dropped05:37
wgrantStevenK: At the top of search_specifications, can you explicitly put both default/options sets in a branch?05:42
wgrantie. if not default_acceptance: default = ...; options = ...; else: default = ...; options = ...05:43
wgrantIt's very difficult to understand now05:43
wgrantAlso, that for option in options thing looks like someone reinvented set intersection05:44
StevenKwgrant: http://pastebin.ubuntu.com/1557566/05:46
wgrantStevenK: The series targets had a different interpretation of SpecificationSort.DATE, too05:47
wgrantStevenK: After adding STARTED was a perfect place to commit :)05:47
* StevenK reads the SpecificationSort.DATE code in distroseries and groans05:50
wgrantStevenK: Also, does get_specification_privacy_filter want an admin shortcircuit like I think the others do?05:50
StevenKget_branch_privacy_filter has no admin shortcut05:50
wgrantProbably OK, then05:51
wgrantStevenK: Does _preload_specifications_people still need the SQL() bit now that most callsites are ported?05:52
wgrantAlso, is that deliberately avoiding getPrecachedPersonsByID?05:53
StevenKwgrant: I have *no* idea about that code05:54
StevenKI touched it once, and the world broke, so I left well enough alone05:54
StevenKRight, I get the series change for DATE05:54
StevenKwgrant: STARTED code seperated out and commited, http://pastebin.ubuntu.com/1557578/ is remaining06:00
wgrantStevenK: Don'y youy need the PROPOSED/ALL filter in the sorting bit?06:02
StevenKI was ignoring that bit, since it acts the same06:03
wgrantIt's a change in behaviour06:03
wgrantPreviously if I asked for ALL or PROPOSED from a distroseries it'd order by datecreated06:03
wgrantNow it will order by date_goal_decided06:03
StevenKI misread date_completed as datecreated06:04
StevenKwgrant: http://pastebin.ubuntu.com/1557587/06:08
wgrantStevenK: Isn't that show_proposed check inverted?06:10
wgrantAlso, you use .intersection there but & in the previous hunk06:10
wgrantIn fact, I'd merge the show_proposed into the else06:10
wgrantso 'if default_acceptance and not (show_proposed & spec_filter):"06:11
StevenKwgrant: http://pastebin.ubuntu.com/1557595/06:12
wgrantStevenK: Looks reasonable06:14
StevenKwgrant: Diff on the MP updated06:24
stub$ bzr branch lp:ubuntu/postgresql-9.106:27
stubbzr: ERROR: Revision {package-import@ubuntu.com-20120925054023-lv75ptpdzvjdhkbw} not present in "Graph(StackedParentsProvider(bzrlib.repository._LazyListJoin(([CachingParentsProvider(None)], []))))".06:27
stubAnyone know if that means my repo is screwed, or if the lp branch is screwed?06:27
wgrantStevenK: The LP branch06:28
wgrantEr, stub06:28
StevenKwgrant: Still looking?06:38
wgrantStevenK: r=me with a comment06:41
* StevenK has fear06:41
wgrantStevenK: https://code.launchpad.net/~wgrant/launchpad/bfjo-shrink/+merge/14422706:55
StevenKwgrant: The first paragraph of the description almost requires a diagram.06:57
StevenKHowever, r=me06:58
wgrantThankyou sir06:58
wgrantIs your spec branch going through EC2?06:58
StevenKNo, I'm playing buildbot bingo06:59
wgrantI was hoping for a 10 commit streak.06:59
StevenKI've ran -m registry -m blueprints enough06:59
StevenKSo BFJO is dead. But only sort of, since you rename another class to its name07:00
wgrantBFJOD delegated to BFJO07:00
wgrantAnd everything inherited BFJOD07:00
wgrantBut BFJO didn't do anything07:00
wgrantSo I merged them07:00
wgrantAnd the new class is not terribly long for this world.07:02
StevenKHoly crap. I won buildbot bingo.07:40
wgrantI guess the blueprint tests are crap :)07:40
lifelessis bingo a false ok07:40
lifelessor an ok ok07:40
StevenKlifeless: An ok ok07:42
StevenKIE, toss the branch at buildbot and see if it passes, since it's so much faster than ec207:43
lifelesscunning plan07:54
stubAnyone know where the button to create a new sourcepackage recipe lives?08:20
wgrantstub: On the branch page08:21
wgrantIt's not there for private branches, as recipes don't support private branches.08:21
stubfound it. not my branch so first step is working out where it was :)08:23
StevenKwgrant: You lose buildbot bingo08:45
wgrantI'm well aware :)08:46
lifelesswait, what?08:57
czajkowskilifeless: Goood morning08:59
lifelessczajkowski: ;) good morning09:00
czajkowskinothing good about snow mister nothing!09:00
* czajkowski cries at her inbox 09:00
czajkowskiit was all nice and tidy yesterday09:00
lifelessczajkowski: heh09:01
czajkowskihow's the little one doing?09:02
adeuringgood morning09:03
lifelessshe was wandering around with my t-shirt on as an over-shirt this evening09:03
lifelesscutest thing ever09:03
czajkowskilifeless: is the heat bothering her at all ?09:05
lifelessczajkowski: heat?09:07
czajkowskiyou're in AU aren't you?09:09
lifelessAU == boiling heat, why I left there 2.5 years ago :)09:14
czajkowskinow makes more sense09:14
czajkowskiI'll swap boiling for -8 and poxy snow!09:15
lifelessmuch easier to warm up than cool down09:15
czajkowskiI like cjwatson and lifeless bugs, they can never be invalid or rarely a duplicate.09:16
* lifeless aims to please09:16
czajkowskiafter this mornings lot of mails it makes me happy09:16
wgrantStevenK: https://code.launchpad.net/~wgrant/launchpad/ttbj-comply/+merge/14425009:26
=== almaisan-away is now known as al-maisan
=== slank_away is now known as slank
=== al-maisan is now known as almaisan-away
=== matsubara is now known as matsubara-lunch
=== matsubara-lunch is now known as matsubara
=== yofel_ is now known as yofel
=== matsubara is now known as matsubara-afk
wgrantStevenK: Can you QA your blueprints thing?23:47

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!