[00:03] cjwatson: r=me [00:04] Great, thanks === slank is now known as slank_away [00:04] cjwatson: Do you want to cowboy it onto mawson while it plays through buildbot, or what is your plan? [00:05] If you have bright ideas on disentangling the underlying cause (notes in the bug), that'd be lovely, or else I'll try to mock something up in tests [00:05] StevenK: I was about to go to bed, TBH [00:06] cjwatson: If you want to crash, I can land it for you [00:06] Will it be a problem if I don't QA it until tomorrow afternoon? I'm going to be out tomorrow morning (hence wanting to go to bed) [00:06] Well, I can land it [00:06] cjwatson: We have one revision waiting, and nothing urgent, so it should be fine [00:06] Just QA will be with slightly less alacrity than usual [00:07] Given that we still have no builders and the change is isolated and trivial, QA on that seems less than essential. [00:07] As I suggested in the MP, we can QA this without builders by injecting a production upload [00:07] Probably quicker too [00:08] True [00:08] Though I guess we need to mock up the build id in the directory name or something to get it into the right archive, but that's easy enough [00:09] Anyway, it's on its way into buildbot, so I'll deal with that tomorrow; feel free to revert if it causes a problem, obviously [03:37] wgrant: How goes the BFJO murder? [03:38] I think all the failures are fixed [03:38] Another ec2 run is 3/4 done [03:38] Ah, how bad was the ec2 carnage? [03:38] Only about 60 failures. [03:39] Not bad. [03:47] StevenK: Looking [03:50] StevenK: Does the context of that specificationdependency.py change reveal another place that needs to respect privacy? [03:52] Unsure [03:53] Also, have you confirmed that this actually fixes the blocking issue? [03:54] I've confirmed it passes tests [03:54] Shall I cowboy it onto mawson? [03:55] If you can reproduce it on mawson today, that would indeed be a good idea [03:55] Reproduce the problem? [03:55] But the existing tests do not catch the blocking issue [03:55] Yes [04:04] 16:09 < ajmitch> heh [04:04] *Bah* copy-paste fail. [04:05] quite [04:48] wgrant: https://blueprints.dogfood.launchpad.net/production-auditor/+spec/spec-c [04:50] I think I need to revert the change to make use of all_deps, rename dependencies to _dependencies, and write a method called dependencies that filters by visibility [04:50] StevenK: Why not just make dependencies filter by visibility? [04:51] 1) You need a user, and 2) dependencies is a SQLRelatedJoin [04:51] Sure [04:51] Does dependencies need to be an SQLRelatedJoin? [04:52] Hm, but if it's an SQLRelatedJoin then it shouldn't recurse [04:52] So how's it relevant? [04:52] We don't want it to recurse for the dep tree [04:52] Oh, does it only show immediate deps? [04:52] That is exactly what is causing bug 1095235 [04:52] <_mup_> Bug #1095235: Bogus dependencies in Blueprint graph < https://launchpad.net/bugs/1095235 > [04:53] Yeah, dependencies and blocked are immeadiate children and parents [04:53] Sure, but I thought the graph showed more than that [04:53] r16333 changed the dep tree to use all_deps and all_blocked, which is the entire tree [04:54] wgrant: It uses dependencies and blocked for each node [04:54] spec-c all_blocked shows 'spec-a' and 'spec-b' since it's recursive [04:54] spec-b all_blocked shows 'spec-a' [04:54] StevenK: So it just uses the recursive query to grab all the nodes, and then queries them all anyway? [04:55] If not, then what's the recursive query for in the first place? [04:55] I'm not sure, but the deptree didn't used to use them [06:05] OH [06:05] * StevenK finally figures out this traceback [06:06] lib/lp/_schema_circular_imports.py, I will DESTROY you === almaisan-away is now known as al-maisan === al-maisan is now known as almaisan-away === yofel_ is now known as yofel [08:51] good morning [08:52] adeuring: morning [08:52] hi czajkowski! [08:54] adeuring: cold and snowing over there? [08:55] czaqright, we have snow :) But "cold" is more a question of peception. It's not like in sebreia here ;) [08:56] s/sebreia/siberia/ [08:56] lol [08:56] we have snow too :) [08:56] poxy snow :( [08:59] czajkowski: It's currently 29 here ... [09:00] SWAP [09:01] czajkowski: it was 45 a week ago [09:02] tad warm :) === matsubara-afk is now known as matsubara === almaisan-away is now known as al-maisan === Ursinha-afk is now known as Ursinha === Ursinha-afk is now known as Ursinha === slank_away is now known as slank === matsubara is now known as matsubara-lunch [15:32] wgrant,StevenK: Review of https://code.launchpad.net/~cjwatson/launchpad/avoid-copy-archive-spam-2/+merge/144727 would be good when you have a chance (and now I'm glad I bothered to QA that) === matsubara-lunch is now known as matsubara === al-maisan is now known as almaisan-away === benji___ is now known as benji === almaisan-away is now known as al-maisan === al-maisan is now known as almaisan-away === matsubara is now known as matsubara-afk [19:11] hey [19:21] I was wondering if there was anything new regarding bug 1100164 . I know you guys are crazy busy, just curious how far back this has been pushed. [19:21] <_mup_> Bug #1100164: Private projects are forbidden from having releases when only files are problematic < https://launchpad.net/bugs/1100164 > === almaisan-away is now known as al-maisan === slank is now known as slank_away === slank_away is now known as slank === al-maisan is now known as almaisan-away