Controlsfreekbschaefer, yeah, so I'm thinking draw 1 happens before the options are loaded. Draw >2 is when the option is properly loaded00:05
bschaeferControlsfreek, yeah, resize was showing 65 twice for me before it switched to the actual launcher size, but the options are generated xml code that you cant get00:06
bschaeferControlsfreek, so we create the launcher controller, and we can grab the current value and set the option00:06
bschaeferControlsfreek, the problem is we have some of that logic in the unityshell.cpp....which we shouldnt...00:07
bschaeferControlsfreek, look at unityshell.cpp around line 2933, that happens when an options gets changed/or loaded00:08
bschaeferand you can see optionGetIconSize(), is what gets the actual icon size in CCSM00:08
bschaeferso we should be able to set this right when we create the launcher controller, but that function logic will need to be moved00:08
Controlsfreekbschaefer, I'00:08
bschaefer(switch logic, as its in a huge function)00:08
Controlsfreekbschaefer, I'll have to dig into this after I get the kids to bed.. Thanks for the help.. Very much appreciated!00:09
bschaeferControlsfreek, np! It takes a bit to wrap your head around the compiz options...00:09
Controlsfreekbschaefer, Stupid Question- How to you revert back to the non-hacked version of Unity when you are done testing?00:59
bschaeferControlsfreek, rm -rf ~/.compiz-100:59
Controlsfreeki ran unity --replace, then made the mistake of hitting ctrl-c which of course hosed my desktop01:00
bschaeferControlsfreek, haha, I do that all the time, after that you just got to Ctrl+Alt+F<1-6> and just type unity01:01
Controlsfreekah okay. I tried that, but unity never seemed to start properly, so i rebooted01:01
ControlsfreekI'll try it again if (when) i end up in the same spot01:01
bschaeferyeeah, I still kill my unity a lot with ctrl+z (and then the bg doesn't work sometimes)01:02
bschaeferso I have to do that often01:02
Controlsfreekbschaefer, hard to determine sequence of events when its all event driven!01:14
bschaeferControlsfreek, yeah, thats where print statements come in handy :)01:56
bschaeferif you wanna see when those options get set in unityshell.cpp, add a printf there (or cout), and keep one in Resize, then you get your order :)01:56
Controlsfreekbschaefer, yeah, i'm peppering the code with debug printf's :-)02:18
didrocksthomi: hey, still around?08:00
didrocksveebers: I guess you are sleeping by now? :)08:06
didrockshey sil210008:06
didrockssil2100: how are you?08:06
didrockssil2100: i'll again need your help, still a lot of tests are failing08:10
didrockssil2100: if you can't, I propose reverting all the changes in the refactoring, it's been 3 days it's stuck…08:10
sil2100didrocks: in a moment I'll fire up the VPN08:10
didrockssil2100: run 49 of unity08:11
didrockssil2100: those are just the result on ati and nvidia, intel didn't run08:11
thomididrocks: I'm around now, for about 2 minutes - what's up?08:13
didrocksthomi: see the email I just sent08:14
didrocksthomi: a little teaser before your week-end of an issue we are seeing with autopilot :)08:14
thomididrocks: ahhhh. so if the problem is just with the math, we could run something similar to: 'autopilot list unity | wc -l' to work out how many tests there should be.... rather than using the number of tests reported from AP08:15
didrocksthomi: I don't really care as long as jenkins is providing the right number of tests it should run :)08:16
didrocksthomi: so if you can work this out next week with chris/fginther (I'm on vacations)08:16
thomiyup, I'll talk to them next week.08:17
thomididrocks: I commented on my unity MP - not sure if you've had the time to look at it again... but it'll be next week before it gets merged now anyway...08:17
didrocksthomi: thanks a lot :) I'll have a look for the unity MP, with the main promotion and so on, I would appreciate the transition only happening once I'm around08:17
thomididrocks: sure08:18
didrocksthomi: great, enjoy your week-end!08:18
thomididrocks: I will - the weather is amazing - I just ate dinner outside in 25 degree sunshine!08:18
thomididrocks: enjoy your vacation in the cold :P08:18
didrocksthomi: you can't skii in 25 degree, doesn't fit with my plans either way! :p08:19
thomiok, let's catch up when you're back. Cheers08:19
didrockssil2100: what do you think? Should we revert?08:28
sil2100didrocks: one more moment, firefox does some problems here...08:30
sil2100Jesus, my system is broken today, hoho08:34
didrockssil2100: use your phone, you just need a browser! :)08:35
sil2100IndexError: list index out of range <- funny08:37
didrockssil2100: ValueError: ('No icon found that matches: %r', {'tooltip_text': 'Workspace Switcher'})08:40
didrockssil2100: test_launcher_keynav_expo_focus_Single_Monitor_08:40
didrockssil2100: we don't have a workspace switcher icon anymore if we just have one ws08:41
sil2100didrocks: ah, ok, right!08:41
sil2100I'll fix that - but for the rest, well, looking into how much work it would be ;/08:41
didrockssil2100: all the rest is the list out of range?08:41
didrocks(apart from the traditional test failing)08:41
sil2100didrocks: won't reverting be troublesome?08:42
didrockssil2100: so, I would say grep for the workspace switcher first08:42
didrockssil2100: well, it will be, but it's been 3 days everything is stalled08:42
didrockssil2100: I would have prefer we wouldn't commit something that didn't work at all08:42
didrockssil2100: isn't that the switcherModel children items are just not exposed?08:43
sil2100didrocks: most apparently, I just hope that's the last thing that's not exported after the refactoring08:44
sil2100No one thinks about autopilot when doing refactoring :(08:47
didrocksyeah, that's annoying, I should have reverted within the same day08:47
sil2100From now on I think I'll simply review every unity refactoring bug to make sure it doesn't break anything for AP08:47
didrockssil2100: also that one:
didrockssil2100: seems a cleanup issue?08:47
didrocksAssertionError: The test left the system in show_desktop mode.08:47
didrockssil2100: yeah, and ask on them if people tested with autopilot08:48
didrockssil2100: another out of range:
didrocksso something is not exposed as well in the lens previews?08:48
sil2100didrocks: good catch - the test_window_buttons might be easily fixable08:49
didrocks(this one wasn't failing before)08:49
didrockssil2100: as I'm not around next week, I really wish we can release an unity today. Do you feel it's feasable?08:50
sil2100didrocks: I think so - I'll do what I can with AP and unity till noon, and if it'll be more work than this we'll simply think about reverting again...08:51
didrockssil2100: ok, thanks a lot dude! :)08:51
didrocksdoing the SRU round meanwhile08:52
didrocksboth quantal and precise08:52
sil2100Thanks :)08:54
didrockssil2100: ok, sponsoring bamf, for unity-lens-files, I wonder if we are going to get yielled at for all the noise is the diff (empty lines)09:25
sil2100didrocks: ah, I saw those indeed - I was silently hoping we won't, as those are like 'empty'09:27
didrockssil2100: it's making the reviewing team angry most of the time09:27
sil2100didrocks: btw. I just hacked away the IndexError: list index out of range for switcher09:27
didrockssil2100: can you preemptively reach out RAOF next week?09:27
sil2100didrocks: will do09:27
didrockssil2100: oh sweet! what was it about? :)09:27
sil2100didrocks: during the refactoring, well, Sam moved the switcher controller implementation to a pimpl class - and along with it, the switcher's controllers children were moved to the impl object09:28
didrocksok, as we expected this morning then09:28
sil2100didrocks: AP tried accessing those children, but they were moved to the impl, so he couldn't find them09:29
didrocksthat will fix most of the issues09:29
didrockssil2100: you're now fixing the 2/3 small ones that I signaled before? ^09:29
didrocksthen, we can rerun a test I guess09:29
didrockssil2100: nice work :)09:29
sil2100didrocks: but without the need of modifying unity code, I simply made AP aware of that there's that impl09:29
didrocksoh sweet09:29
didrocksthat's even better :)09:29
sil2100didrocks: Trevinho just fixed the small missing-workspace icon fixes ;p09:29
sil2100didrocks: I approved and it will be merged09:29
sil2100Now I'll take care of the other small thing09:30
didrocksgreat! :)09:30
* didrocks has again some hope for a new release today09:30
didrockssil2100: both SRU sponsored :)09:32
didrocksMirv: your turn now! :)09:32
didrocksMirv: can you remove the doc/ content from your branch? this is adding some noise for no good reason.09:36
didrocksMirv: also, sil2100's branch had some new .desktop files for the tests, I think you need to include them09:36
didrocksMirv: once done, I'll sponsor, looking good :)09:36
jibeldidrocks, autopilot test done on intel. 46 failures09:39
didrocksjibel: thanks! yeah, still the refactoring that was done… sil2100 is working on fixing it :)09:42
sil2100didrocks: thanks ;)09:43
sil2100didrocks: ah, and the leave-show-desktop issue, ah, it's also a mistake of mine ;) Due to a known show-desktop bug09:43
didrocksah sweet! :-)09:43
didrocksone less09:43
didrockssil2100: while those things are merging, do not hesitate to compare with a last well known state (run on the 18th)09:44
didrockssil2100: but you can propose a branch that we can approve already09:44
sil2100Make sure everything is ok ;)09:44
Mirvdidrocks: hey!09:51
didrockshey Mirv ;)09:51
Mirvdidrocks: well there were tidifications to the build but they were reverted from the stable branch for not being SRUable09:51
didrocksMirv: ok, the tests are passing without the .desktop files?09:52
didrockssil2100: approved, ping me with the other fixes once you have them ready :)09:52
Mirvdidrocks: no, the tests pass when the .desktop files are there, but as another reverted commit was the thing of including them in tarball in addition to bzr - so when you run the tests with those .desktop files on top of tarball, tests pass09:52
Mirvso the .desktop files are in the bzr 0.2 branch as well, but not in the tarball09:53
didrocksMirv: hum, I would prefer having them in bzr, as we have for quantal (and without the doc/) if possible09:53
Mirvdidrocks: ^09:53
didrocksMirv: ah, interesting09:53
didrocksMirv: ok for the .desktop files then, just remove the doc/ changes please09:54
sil2100didrocks: fix for the SDM issue ^09:55
sil2100didrocks: will look into the preview things in the dash in a moment09:55
didrocksgreat :)09:56
Mirvdidrocks: so should I create a new tarball that has manually reverted the doc/ changes that make dist creates?09:56
didrocksMirv: yeah, I would say, just open the tarball, put back old files09:57
didrocksMirv: to get the SRU team happy about the diff09:57
didrocksMirv: normally, we don't really do new releases :)09:57
didrocksMirv: another way is just cherry-pick the commit09:58
didrocksmaybe just easier for you?09:58
veebersdidrocks: sorry, missed your previous message :-) I've read the back log, will talk w/ thomi10:06
Mirvdidrocks: one way now here: pull  lp:~timo-jyrinki/bamf/ubuntu.02126 again and use https://launchpad.net/bamf/0.2/0.2.126/+download/bamf-0.2.126-nodoc.tar.gz as the orig.tar.gz10:08
Mirvsame stuff, just doc/ unchanged from
didrocksveebers: thanks!10:08
didrocksMirv: excellent, having a look!10:09
didrocksMirv: gorgious, taking your tarball as well :)10:09
Mirvdidrocks: great! and I agree that this is neater for the SRU team.10:10
didrocksMirv: yeah, I can understand why they do have this position :)10:10
didrocksMirv: thanks again, good work :)10:10
Mirvyou're welcome10:11
didrocksveebers: I still don't get why the nvidia tests are failing, and not when we run all the tests :/10:15
sil2100didrocks: I suddenly dont have imternet right now10:36
didrockssil2100: sux :/10:36
sil2100Using my phone and some internet packets10:36
didrockssil2100: I'll rerun the release once your branches merged10:37
sil2100didrocks: I'm looking what could have changed that the files lens had no results, but no internet doesnt help :/10:40
didrockssil2100: indeed, good luck :/10:40
=== sil2100_ is now known as sil2100
sil2100Ok, I got internet back!10:41
didrockssil2100 is back with full powers \o/10:44
MCR1Trevinho: Hi. :) Are you here ?11:00
MCR1Trevinho:  I did intensive testing regarding the Alt+Enter Fullscreen/Un-Fullscreen shortcut to be sure to not introduce any new issues and found a bug already in Unity trunk:11:03
TrevinhoMCR1: what's hte problem?11:04
MCR1It is currently still possible to invoke the HUD for fullscreened windows11:04
MCR1but it is invisible then11:04
TrevinhoMCR1: one "regression" with that alt+enter I have is that... I used alt+enter to open a new URI in a new tab in ff/chromium and this shourtcut would miss it... .P11:05
TrevinhoMCR1: yeah, as the menus11:05
TrevinhoMCR1: we had a problem with that11:05
MCR1solution: we should forbid to invoke the HUD and menus -> should be easy11:05
Trevinhothere's a bug in compiz...11:05
MCR1but it should be done11:05
MCR1really ?11:05
MCR1Trevinho: Don't you think that it would be better to handle this problem in Unity ? I am sorry about your shortcut :-[11:08
MCR1Because you can trigger this bug now in trunk.11:09
MCR1Simply open a video player with video, double-click it to fullscreen it and then tap ALT to invoke the HUD.11:09
MCR1It will still come up, but behind the fullscreened window11:09
TrevinhoMCR1: well, it depends, for sure we should make unity to draw its window above the fullscreen ones (in certain cases)11:10
MCR1I think the best solution would be forbidding starting the HUD for fullscreen-windows.11:11
TrevinhoMCR1: the same is for the dash11:11
TrevinhoMCR1: mh, no... it should above them11:11
MCR1uh, did not think about that yet...11:11
Trevinhothere's a bug available11:11
TrevinhoMCR1: the HUD is needed also to control apps fullscreen (is one of its most useful cases)11:11
MCR1The HUD is a great innovation -> I 100% agree. Who did come up with that ?11:12
MCR1Trevinho: Thanks 4 all the info, I am not sure though how to force Unity to draw on top of everything yet, but I'll investigate...11:17
MCR1The Panel should already have some code-magic done as On-Top-Windows are still behind it...11:20
MCR1The Dash and HUD should probably use the same magic...11:21
MCR1It would probably also fix the problem that Docks are on top of Unity's Fullscreen-Dash, making it more or less unusable...11:22
sil2100Strange things with the files lens, hm hm11:30
sil2100didrocks: I think the test is badly written11:34
sil2100didrocks: test_files_lens_preview_open_close <- I'll have to rewrite it, because it works on a broken principle11:34
=== _salem is now known as salem_
didrockssil2100: ok, I'll try to make a run with the rest meanwhile :)11:44
luvlast night, I finally got my patch somehow working - so when I right-click a BamfLauncherIcon I get a list of open windows and I can click them to switch between windows quickly - neat11:53
sil2100luv: awesome!11:53
luvthought there are still bugs in it and one or two memory leaks - I will post the patch (hopefully) next week11:53
luvthanks :-)11:53
sil2100luv: show it to us once you think it's in good shape ;)11:55
MCR1sil2100: bug 627195 is already fixed isn't it ?12:16
ubot5bug 627195 in unity (Ubuntu) "Window management - Apps raised from indicators sometimes dont have the focus" [High,Triaged] https://launchpad.net/bugs/62719512:16
MCR1I cannot reproduce it anymore...12:17
MCR1sil2100: Please forget it - false alarm...12:17
andyrockMCR1, that bug is actually a gtk bug + indicator bug + standard bug12:20
MCR1I am having troubles to reproduce it reliably - sometimes it works, sometimes not12:21
andyrockMCR1, in a nutshell gtk_window_present uses a wrong timestamp12:21
ryeandyrock: is this the same reason why https://bugs.launchpad.net/ubuntu/+source/unity/+bug/1098753 happens?12:22
ubot5Launchpad bug 1098753 in unity (Ubuntu) "[raring] Launching media files from dash opens them below active window" [Undecided,New]12:22
andyrockrye, it's linked but it can be solved on unity-side12:23
andyrockrye, unity-lens-* should use startup notification to launch an app12:24
andyrockrye, for example try this: open a nautilus window, than try to open another nautilus using the dash12:25
ryeandyrock: oh12:25
andyrockrye, click on another gtk window before opening the dash12:25
ryeandyrock: this is weird12:26
andyrockrye, now try to open do the same thing using the launcher12:26
* rye found this - https://bugs.launchpad.net/unity/+bug/721974 12:26
ubot5Launchpad bug 721974 in unity (Ubuntu) "Unity should have startup animations for Panel and Launcher" [Undecided,Incomplete]12:26
andyrockwith the launcher should be fine12:26
andyrockubot5, well the Launcher partially support it12:27
ubot5andyrock: I am only a bot, please don't think I'm intelligent :)12:27
ryeandyrock: yep, launcher is ok12:27
MCR1andyrock: I think one of the workarounds is actually working -> CCSM->General Options->Focus Prevention Level->Off (at least for the Indicator Raise issue...)12:27
andyrockMCR1, yeah but it's a bad workaround12:27
andyrockMCR1, disabling the focus prevention is a bad idea12:27
didrockssil2100: I'm relaunching an unity build + tests now that the switcher branch is merged12:28
ryeI remember i disabled focus prevention just because nautilus was not playing well (and menus of different app was displayed when nautilus was fullscreen). Now nautilus works properly (for some reason)...12:28
andyrockrye, if you use the launcher to launch nautilus yeah it should be fixed12:29
andyrockif you want I can tell you how can you fix it for unity-lens-application too12:30
sil2100didrocks: ok - will have some more branches/merges ready soon12:30
didrockssil2100: awesome \o/12:31
=== dandrader is now known as dandrader|afk
ryeandyrock: to fix - look how the launcher handles app startup and do the same for app lens?12:48
andyrockrye, yup :) just make sure to think about testing too12:49
ryeok, last question - has anybody knows/spotted anything weird with how the panel is rendered in unity - I am still obsessed over https://bugs.launchpad.net/ayatana-design/+bug/723167 and it's definitely not antialiasing settings that break it12:52
ubot5Launchpad bug 723167 in unity (Ubuntu) "Panel does not use standard GTK/Pango font rendering/antialiasing, causing fuzzy fonts" [Medium,Triaged]12:52
* rye thinks that title needs to be updated12:52
=== MacSlow is now known as MacSlow|lunch
sil2100didrocks: https://code.launchpad.net/~sil2100/unity/autopilot_dash_lens_previews_fixed/+merge/14493413:27
sil2100didrocks: this should fix 2 dash lens preview tests failing13:27
=== rsalveti_ is now known as rsalveti
=== dandrader|afk is now known as dandrader
sil2100Let me take a look at some others13:52
=== chiluk_away is now known as chiluk
didrockssil2100: excellent!14:20
didrockssil2100: ATI doesn't seem in a good shape now :(14:21
didrocksWaiting for Unity14:21
didrocksUnity seems to be unavailable (for test suite: unity.tests.test_home_lens)14:21
didrocksdo you think it can be a timeout issue?14:21
didrocks(run 51, ATI)14:21
=== MacSlow|lunch is now known as MacSlow
jibelil aurait planté?14:22
didrocksjibel: seems so…14:22
jibeloops, wrong window :)14:23
didrockssil2100: same than with one ws btw on the tests, I think adding some video files for the integration tests will be nice14:23
didrocksmterry: hum, needed coffee this morning, I read the message the other way around :)14:26
didrocksand blocked on "python" :)14:26
didrocksmterry: btw, in addition to what I sent about the crash during the indicator tests on nvidia (I put you on the loop so that you can help them debugging), can you mention as well that it will be good if we can collect in addition to the crash files ~/xsession-errors and /var/log/syslog?14:27
didrocks(archived as jenkins artefacts)14:27
mterrydidrocks, k14:35
didrocksthanks :)14:35
didrocksmterry: my emails were clear enough I hope?14:35
mterrydidrocks, I think so.  After skimming, I put it on my TODO this morning, haven't read explicitly14:38
didrocksmterry: ok, do not hesitate if any question arise before I disconnect14:38
didrocksmterry: I still need to relaunch the tests once now that sil2100 fixed most of the issues due to the refactoring14:38
mterrydidrocks, who's working on the autopilot side of that issue?  (to write empty failed tests before starting any of them)14:39
didrocksmterry: it's another issue, nobody right now AFAIK, I just bootstrapped the discussion14:40
didrocksmterry: people in CC of this emails should be the right contacts14:40
sil2100didrocks, mterry: you can count on me if anything, for now I'll work on reducing the number of failures more - just I'm having lunch right now14:44
didrockssil2100: excellent, I'm sure mterry will abuse of your kindness :)14:45
mterryfginther, hello!14:50
mterryfginther, in there was a test failure caused by a crashing Xorg14:51
mterryfginther, but the crash files aren't part of the artifacts.  Is that because crash files aren't picked up yet, or is it some weird bug with this build?14:51
fginthermterry, I believe veebers was looking into this issue14:52
fginthermterry, the crash files should be saved14:52
didrocksfginther: they aren't, we have the same issue on the unity autopilot job14:53
fgintherwe may be able to manually extract them if the machine has been wiped14:53
didrockslike here, we have another crash on ati + some dconf crash14:53
didrocksthey are not archived14:53
=== dandrader is now known as dandrader|lunch
fginthermterry, didrocks the dconf crash is available on the ati box14:56
didrocksfginther: it's not on the artefacts or did I miss anything?14:56
fgintherdidrocks, it's not being copied. it's still sitting on the test machine14:56
didrocksfginther: jibel reported it manually, but yeah, we need to copy them over jenkins14:57
fgintherdidrocks,  veebers mentioned an issue with apport-retrace which I think is the reason they are not being copies14:57
fgintherdidrocks, I'll investigate a workaround14:57
mterryfginther, thanks!14:57
didrocksfginther: also, as I was telling tome lines above, we should as well put ~/xsession-errors, /var/log/syslog and Xorg.0.log as artefacts I think14:57
didrocksthanks :)14:58
fgintherdidrocks, will do14:58
didrocksgreat ;)14:58
didrocksfginther: there are always the 3 jobs to change: indicator/oif/unity14:58
mterrydidrocks, so I see indicators-head needs manual packaging approval.  Once I review something and llike it, how do I approve it?14:59
didrocksmterry: I did it for today to have unity moving, but we can "simulate" what I did14:59
rperierhey, could someone look at the merge request 144773 ? I have committed the corresponding autopilot unit test14:59
didrocksmterry: so, you did see that the global status was "unstable", isn't it?14:59
didrocksclicking on indicators head15:00
didrocksthe publish job was yellow15:00
rperierthanks in advance15:00
mterrywell, yellow anyway15:00
didrocksyeah,  unstable is yellow :)15:00
didrocksmterry: look at run 3915:00
mterrydidrocks, yeah I got as far as reviewing the packaging diff for individual packages15:00
didrocksah good :)15:00
didrocksso, then, we need to force the publication15:00
mterrydidrocks, is this where cu2-run comes in?15:00
mterrydidrocks, I want a fancy web buttton  :15:01
didrocksin jenkins/15:01
didrocksmterry: well, we need credentials :)15:01
mterrydidrocks, oauth me!15:01
didrocksahah! :)15:01
didrocks./cu2d-run -P indicators head15:01
didrocksfor publishing indicators-head15:01
mterrydidrocks, but OK.  Cool.  Do I have to publish the whole stack or can I specify individual packages on that line too?15:01
didrocksI think it's time to share the credentials btw15:01
didrocksmterry: no, we validate the integration tests per stack, so the publication is per stack15:02
=== dandrader|lunch is now known as dandrader
sil2100didrocks: one of the failures *might* be a real regression16:35
didrockssil2100: I can test, I'm on the latest ppa16:36
sil2100didrocks: for instance the unity.tests.test_dash.PreviewInvocationTests.test_preview_key sometimes fails, it usually fails on a first start - I noticed it's not 100% reproducible, but I noticed that unity sometimes ignores keystrokes when it's still not loaded completely16:37
sil2100didrocks: for instance, I reproduced the problem once on my guest session when trying to run the music lens right after starting16:37
didrockssil2100: ah, interesting, so we need to tests, once after loading, one trying to do that as early as possible :)16:37
sil2100didrocks: the Super key got registered, but the 'm' stroke went behind unity and landed on my terminal ;p16:38
didrockssil2100: yeah, you're probably right :)16:38
didrocksbtw, new results for ati/intel, run 5216:39
didrocksstill waiting on nvidia, crossing fingers16:39
sil2100I just hope it's enough for a release ;/16:39
didrockssil2100: I hope as well that we won't get Xorg crash this time :)16:39
fgintherdidrocks, hello. if we enable merges to skip the jenkins build process for changelog only updates, can we later run into problems if the changelog contained a version bump?16:42
didrocksfginther: not really, because we can't bump build-dep automatically, but if we do that at some point, yeah, it can be16:43
didrocksfginther: or you should just add the daily-build ppa as a source16:43
didrocksand so we won't have this problem16:43
fgintherdidrocks, ok, that makes sense. thank you16:45
didrocksyw :)16:46
rperiersomeone might review a merge request ? (this is a small fix)16:46
bregmafginther, rumour has it you know where I can find useful test coverage reports for Unity.... is this true?16:46
didrocksbregma: ^^16:46
sil2100rperier: show us ;)16:46
fgintherdidrocks, the changes to enable this are working, just need some tests, reviews and job config changes...16:46
rperiersil2100: https://code.launchpad.net/~rperier/unity/exec-len/+merge/14477316:46
fgintherbregma, one moment16:47
didrocksfginther: oh great! if we have a manual publish in 10/15 minutes, I'll let you know :)16:47
sil2100rperier: oh, autopilot test added - nice! Checking it out16:47
didrocksfginther: for the unity stack, but then, you'll have to update everyjob16:47
didrocks(you really need to automate the job update)16:47
rperiersil2100: hehe16:48
rperierthe fix itself is not *amazing*16:48
fgintherdidrocks, thanks, just give me a heads up on the branch before you push the branch16:49
rperierbut it does the trick ;)16:49
fgintherdidrocks, I'll try it for real with a branch or two first16:49
didrocksfginther: well, if we don't have any packaging change, it will be pushed automatically16:49
didrocksfginther: but I can revert approved to needs review16:49
sil2100didrocks: can I approve a merge globally, or do you prefer to not merge any new things before the release right now?16:49
didrocksif we do that quickly enough, that's fine :)16:49
fgintherdidrocks, ah I see. the revert will work. thanks16:50
didrockssil2100: wait for 15 minutes for safety, but normally, I don't plan to rebuild unity :)16:50
rperiersil2100: the bug has been tagged for unity 7.0 ...16:50
sil2100rperier: it looks good, thanks ;) Get used to google-test and autopilot, since we have a rule that everything that is testable needs to have an automatic test provided in the branch16:50
sil2100So you might be writing a lot of tests in the future ;p16:50
rperierif this is required, np16:51
bregmain fact, if all you do is write tests and not change the software, that is a valuable contribution16:51
mterrydidrocks, et al: I noticed we have a lot of test failures, but that ya'll were working on them.  Where are we on that?16:51
didrocksmterry: what do you mean by "a lot"? :)16:52
sil2100mterry: what failures do you have in mind ;) ?16:52
fgintherbregma, does this work? https://jenkins.qa.ubuntu.com/job/unity-mbs-autolanding/357/build=pbuilder,distribution=raring,flavor=amd64/cobertura/?16:52
didrocksrperier: I would add to bregma's statement a *very* valuable one :)16:52
didrocksgrrr, game of the day, thanks UTAH, this times, nvidia didn't restart…16:54
sil2100So no nvidia :( ?16:54
bregmafginther, that report doesn;t seem very accurate, since it doesn't show about half the code16:55
alesagefginther yes it's sneaky b/c it only reports on files *with tests*16:56
rperierI might help you fixing/writing tests after this merge if you want :)16:56
fgintherbregma, yes, there is a problem with one of the coverage tools that causes it to not include files that are not executed during testing. very unfortunate16:57
mterrydidrocks, sil2100 : Ah nevermind.  I got confused reading the Jenkins page between the 40 unity ones and the indicator (thought we had 40 indicator stack failures)16:58
bregmafginther, OK...  do you know how I can build Unity for gcov analysis locally? (I'm  not an expert at cmake)16:58
rperiersil2100: thanks to have approved it16:59
fgintherbregma, I can dig up something16:59
fgintherbregma, I'll send you mail16:59
bregmaK, thanks, I need to cross some stuff off my to-do list17:00
didrocksmterry: no, it's on the whole unity here ;)17:00
didrocksmterry: sil2100: the last run with nvidia, where this time intel UTAH failed was good17:00
didrocksmterry: sil2100: I'm powdering just running the publisher job right now and release as it is17:01
mterrydidrocks, 40 is about normal for unity though right?17:02
didrocksmterry: 40/50 yeah17:02
didrocks(sum of the 3 configurations)17:02
didrocksso 15+ on each17:02
=== dandrader is now known as dandrader|afk
sil2100didrocks: can I globally approve a merge request, or should I wait a moment ;p?17:04
didrockssil2100: you can approve17:04
sil2100Ah, I see bregma already did17:04
didrocksyeah, seems that he's not really reading IRC :/17:04
rperierthanks !17:04
rperierthat's cool ;)17:05
didrocksmterry: so, as you can see, arm is still not published17:05
didrocksrperier: thanks for your contribution17:05
didrocksmterry: once, done, as the tests fails and we are going to "bypass/workaround", I'll just run the publisher job17:05
didrocksmterry: similar thing than a manual publishing17:05
didrocksso ./cu2d-run -P unity17:06
didrocks(head is the default release)17:06
mterrydidrocks, why are we manually publishing this run?  Is 40 tests over the error threshold?  (still not clear at what level those have been set)17:09
didrocksmterry: see my discussion above about nvidia not rebooting ^17:09
didrocksmterry: so we don't have any nvidia result17:09
didrocksbecause UTAH didn't make it reboot17:09
rperierI might help you fixing non-bitesize bugs now, what do you think ? (I try to increase difficulty step by step)17:09
didrocksmterry: the previous run, it was UTAH not making intel rebooting :/17:09
didrocksmterry: so if one configuration is failing, we are not going to the next step17:10
mterrydidrocks, sure, OK17:10
didrocksbut if take this run, and look at the previous one for nvidia17:10
didrocksthe results are fine17:10
mterrydidrocks, what is the threshold for errors?17:10
didrocksmterry: 8% (but we can get down to 5% in reality) on each configuration17:10
didrocksmterry: it's config per config17:10
didrocksfor unity17:10
didrocksfor the indicators, it's 2% (meaning, 1 test failing)17:11
didrocksper config again17:11
didrocksone config being ati, intel or nvidia17:11
didrocksif only UTAH was stable…17:11
mterrydidrocks, and are sil2100 and crew still working on getting to all tests passing, or are we happy with where are and working on features/bugs?17:11
didrocksmterry: sil2100 is working on getting the number lower17:11
mterrydidrocks, cool.  Just trying to get a sense of where we are17:12
didrocksmterry: I would be happy to keep the threshold at 3% personnaly, but getting all tests that reliably fails fixed would be a nice improvment17:12
didrockssure sure :)17:12
mterrydidrocks, oh, gnome-control-center-unity should be added to the unity stack, btw17:12
mterrydidrocks, any objection?17:13
didrocksmterry: not at all :)17:13
mterrydidrocks, alright, will push to bzr and poke fginther17:13
didrocksgreat! :)17:13
didrocksshould be in the "misc" stack, maybe?17:13
didrocksas no integration tests, and (mostly) independant component17:13
mterrydidrocks, it doesn't have tests true17:14
mterrydidrocks, sure, misc stack17:14
didrocksmterry: TBH, I'll just try to release unity and go then, we can see once I'm back and I'll let you add it once you get your creds :)17:15
mterrydidrocks, add gnome-control-center-unity?  Why wold I need creds for that?17:16
didrocksmterry: to the daily release stack17:16
didrocksyou need to reconfigure the jenkins jobs for the daily release :)17:16
mterrydidrocks, ah earlier you said fginther did that, but I guess you meant only because I didn't have creds.  OK17:16
didrocksmterry: ah no, fginther needs to do the jenkins bot to merge the upstream code17:17
sil2100didrocks, mterry: next week the number will be again lower17:17
didrocksmterry: this part http://blog.didrocks.fr/public/ubuntu/daily-release/merge-upstream-branch.png17:17
didrockssil2100: excellent!17:17
didrocksmterry: we are deploying automatically our jobs for that part: http://blog.didrocks.fr/public/ubuntu/daily-release/daily-release-jenkins-jobs.png17:18
didrocksfginther: around for the publication?17:18
mterrydidrocks, what does this have to do with adding gccu to the misc stack?17:18
fgintherdidrocks, yes17:18
mterrydidrocks, that's not about landing an upstream branch17:18
didrocksmterry: we need to have the facility to land upstream branches17:19
didrocksmterry: when we merge back the "latest snapshot"17:19
didrocksthe branches needs to be merged :)17:19
didrocksit's just opening a MP17:19
didrocksmterry: <unrelated> so as you can see the check step failed (because of nvidia being stuck) and the rest is green17:19
didrocks("heads" reflect the global status)17:20
mterrydidrocks, and that's some configuration step above and beyond jenkins being told that this project is part of the misc stack...  OK17:20
didrocksmterry: yep :)17:20
didrocksso, now, to force the publication, I'm just rerunning the publish job in "force mode"17:20
mterrydidrocks, alright, will wait until you get back then  :)17:20
didrocksmterry: this unfortunately doesn't refresh the "head" job to become green17:20
didrocksmterry: so I run  ./cu2d-run -P unity17:21
didrocksyou can see the publish job running now17:21
sil2100Ok everyone, I'll be going for some shopping!17:21
mterrydidrocks, sure17:21
sil2100didrocks: have a nice holiday! ;)17:21
didrockssil2100: have a good week-end! :)17:21
sil2100See you17:21
didrockssil2100: thanks, good luck with the tests ;)17:21
didrocksfginther: I reverted the status for:17:21
didrocksfginther: so you have 3 to play with :)17:22
didrocksfginther: just ensure that they are merged by the EOD :)17:22
fgintherdidrocks, excellent! thanks17:22
didrocksfginther: yw :)17:22
didrocksmterry: so, as you can see this is the merge back of the snapshot17:22
didrocksmterry: the rest is green and the sync file is generated17:23
didrocksat 30', a rsync from lillypilly will happen17:23
didrocksand sync those 3 components from the ppa17:23
didrocks(the cron is running every 15 minutes)17:23
mterrydidrocks, k17:24
mterrydidrocks, why does fginther have to do something manual for those snapshot merges?17:24
didrocksmterry: oh, he wants to experiment this time to skip rebuilding when merging those snapshot17:25
didrockslike just taking the MP, recognizing it's this kind of merge and bzr push17:25
didrockswill avoid 3 hours of build on compiz for instance17:25
didrocksmterry: so, the only thing I don't like is that the global status is showing the "head" one in that case (which can be yellow if there is a manual publish and we rerun the "publish" mode17:27
didrocksmterry: I don't want that we rerun all the jobs to skip them (can take time if we have multiple "prepare" packages)17:28
rperierI might help you fixing non-bitesize bugs now ?17:28
rperierwhat do you think ?17:29
mterrydidrocks, I don't follow.  It's red now, but you wish it were yellow if we manually pushed?17:29
didrocksmterry: yeah, it's read because the "check" step is read17:29
didrocks(because of nvidia failing)17:29
didrocksmterry: normally, if UTAH behaves correctly17:29
didrockswe can only have red is the build failed17:29
mterrydidrocks, are UTAH failures like this common usually?17:30
didrocksmterry: yeah :(17:30
didrocksmore than common17:30
mhr3davidcalle, ping/17:30
mterryDo we understand why/are we working on that?17:30
davidcallemhr3, pong17:30
didrocksmterry: I was asked by qa to "open bugs"17:30
didrocksand that's what I'm doing17:30
didrocksbut the poor level of logs makes them generally just closing them17:30
didrockswithout knowing why it failed…17:31
mterryopen a bug for more logs  :)17:31
didrocksit's already there :/17:31
didrocksI got the promess that all issues will be fixed in the 2 weeks coming…17:31
didrocksif not, I'll escalate…17:31
didrocksbecause it's really creating a pain for us, provisionning a machine isn't the most complexe piece of the process…17:32
didrocksmterry: so yellow on the global status happens if:17:33
didrocks- we are in manual publishing mode (packaging changes or upstream stack failed/is in manual publishing mode)17:33
didrocks- or if one component were skipped because the version in distro is higher than what we have in trunk17:33
didrocksgreen is… well you got it :)17:34
didrocksmterry: btw, part 4 on stack dependencies published :)17:34
didrocksmterry: so right now, the two blockers, to some up are:17:35
mterrydidrocks, ah more homework  :)17:35
didrocks- UTAH and its reliability17:35
didrocks- autopilot in case there is a crash stopping its tests (and silently)17:35
didrocksmterry: heh, indeed17:35
jibel- UTAH and how to ping jibel to relaunch the jobs ;)17:36
mterrydidrocks, so UTAH team is slowly looking at UTAH issues.  And autopilot work is unscoped?17:36
didrocksjibel: I've already given your name and tell them you can be highly bothered :)17:36
mterryer, unworked-on right now17:36
didrocksmterry: yep, please push the thread I CCed you forward :)17:37
mterrydidrocks, I imagine Thomi makes sense there17:37
didrocksyep :)17:38
didrocksmterry: seeing the road we had to ride (like 120+ tests failing, UTAH failing even more…) we are going in the right directions17:38
didrocksthose 2 are the last baby steps, I hope :)17:38
didrocks(I forgot about the "no test on indicators" that we workarounded by stealing the ones from unity which made sense)17:39
mterrydidrocks, is that so bad?  I assume they exercise them somewhat well.  But we fear gaps I imagine17:40
didrocksmterry: we have quite some gap, that's why I'm not that confident and put the failure trigger to 2% for only one test failure17:40
didrocksmterry: once we got more, like for the HUD thanks to libcolumbus (so the other email), I hope that it's a starting point17:40
didrocksbut like, we have none for changing volume, click on the power indicator, and so on…17:41
didrocksor changing telepathy presence status17:41
didrocksmterry: the team is quite rigorous, but having at some point a safety net will be good17:41
didrocksnot as high at all as the 2 other points I mentionned though ^17:42
andyrockrperier, any contributon is welcome ;)17:43
andyrockrperier, so yeah you don't have to ask to fix bitesize bug17:43
rperierno I am asking for fixing non-bitesize bugs :D17:44
andyrockrperier, it's ok too17:45
andyrockjust make sure there is a bug report17:45
* mterry hugs rperier 17:48
rperierI fixed 2 bitesize bugs, I was just asking if I could help you fixing tests or important blocking bugs in unity :)17:48
andyrockrperier, we have a list: https://blueprints.launchpad.net/ubuntu/+spec/desktop-r-unity-polish17:50
andyrockrperier, but most of them are fixed now17:50
andyrockfeel free to pick one on bugs.launchpad.com/unity17:50
mterrydidrocks and I were just talking how we could use more tests written too17:50
rperierokay, It's noted ;)17:50
didrocksrperier: indicators autopilot tests would be awesome as mterry noted!17:51
didrocksfginther: do not forget to have the 3 MP merged before the EOD :)17:56
didrocksotherwise, you will give a rough start next week to mterry to understand why some jobs are yellow (even if normally, the logs should be clear ;))17:57
=== salem_ is now known as _salem
=== _salem is now known as salem_
=== dandrader|afk is now known as dandrader
fgintherbregma, bschaefer unity autolanding jobs have been running without issue (16 total) after https://code.launchpad.net/~bregma/unity/initialize_horizontal_drag/+merge/14457918:54
bschaeferfginther, \o/18:54
=== dandrader is now known as dandrader|afk
bregmawe still have out work cut out for us18:56
bregmarperier, are you looking for a bug to fix?  there's one that is vexing and irking me daily: https://bugs.launchpad.net/unity/+bug/106088718:59
ubot5Launchpad bug 1060887 in Unity "Multiple files rebuilt on each run of make" [Undecided,New]18:59
=== dandrader|afk is now known as dandrader
=== cyphermox_ is now known as cyphermox
=== salem_ is now known as _salem

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!