=== slank is now known as slank_away
StevenKwgrant: https://code.launchpad.net/~stevenk/launchpad/cache-known-viewers-specification/+merge/14529903:15
=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
* StevenK grumbles at bug 1107811. The edit function calls tag_input.focus()03:29
_mup_Bug #1107811: Clicking "Add tags" or "Edit tags" doesn't focus the tags field <bug> <form-focus> <regression> <Launchpad itself:Triaged> < https://launchpad.net/bugs/1107811 >03:29
wgrantStevenK: Looking03:31
wgrantStevenK: Can't you unnest _preload_specification_people?03:32
StevenKwgrant: I probably can. Then I append the bare function to the decorators array?03:34
wgrantStevenK: Right, a function that takes no arguments and then returns a function is not useful; you can just use the inner function directly.03:34
StevenKwgrant: http://pastebin.ubuntu.com/1584386/03:36
wgrantStevenK: That looks more reasonable :)03:37
StevenKwgrant: Is that your only issue, or still pawing at the rest?03:37
wgrantStevenK: The rest looks fine :)03:38
StevenKwgrant: TBH, I was expecting you to complain about the function I added to test_specification :-)03:39
wgrantMeh :)03:39
StevenK(And ISpecification.userCanView() is finally readable again)03:40
StevenKwgrant: That MP has updated03:47
wgrantStevenK: r=me03:53
=== Ursinha is now known as Ursinha-afk
StevenKwgrant: Shall we pull apart that checkwatches core on carob, or you give me a clue about mpt's latest bug?04:06
wgrantStevenK: Have you traced mpt's in a debugger?04:07
StevenKIn the five minutes or so I've spent on it, I've reproduced it on prod, and read the code.04:07
* StevenK goes looking for Firebug04:11
StevenKSo the focus() gets called04:23
wgrantDoes the widget exist?04:26
StevenKIt's hidden at the time04:27
StevenKhttp://pastebin.ubuntu.com/1584453/ seems to work04:27
wgrantSounds plausible.04:29
StevenKNFI how to test it04:29
StevenKHow do I check which widget has focus in a YUI test?04:40
wgrantStevenK: document.activeElement might work04:41
wgrantStevenK: https://code.launchpad.net/~wgrant/launchpad/ttb-refactor-create/+merge/14530504:51
StevenKwgrant: Won't 90+ return ubuntu.currentseries.nominatedarchindep.default_processor die horribly when a new series is in the midst of populating?04:53
wgrantStevenK: Yes, and it does04:54
wgrantBut fixing that is harder04:54
wgrantWe generally lose a couple of jobs each time we initialise04:54
StevenKwgrant: I'd prefer the one-line comment on line 89 die, and be replaced by the XXX on line 95-9804:55
StevenK95-97 even04:55
wgrantStevenK: Any other objections?05:08
StevenKwgrant: Sorry, was distacted by phone05:10
StevenKwgrant: r=me, looks great05:11
StevenKExpected: [object HTMLBodyElement] (object) Actual: INPUT#tag-input yui_3_5_1_1_1359436804933_377 (object)05:20
StevenKAnd Firebug does not love the test page at all05:26
wgrantChromium :)05:26
StevenKHaven't used Chromium's JS tools05:27
wgrantThey're not implemented in XUL05:27
wgrantWhich puts them a fair way ahead of Firebug05:27
StevenK+a few million05:28
StevenKUncaught TypeError: Cannot read property 'style' of null /home/steven/launchpad/lp-branches/devel/build/js/yui/dom-style/dom-style.js:6505:29
StevenKAt least it doesn't cause Chromium to spin, but it is increasing a timer for that error very quickly05:30
wgrantAh, archive.txt, my old nemesis...05:35
StevenKHmmm, so the _yuid of the #tag-input and document.activeElement are different05:37
wgrantStevenK: It looks like the activeElement is the <body>, doesn't it?05:37
wgrantWhich probably means that activeElement doesn't do what you wnat here05:37
StevenKHmmm, not sure about that05:38
wgrant16:20:24 < StevenK> Expected: [object HTMLBodyElement] (object) Actual: INPUT#tag-input yui_3_5_1_1_1359436804933_377 (object)05:38
StevenKOh, innerHTML is LARGE05:38
StevenKChromium helpfully shows me one line05:38
StevenKRight, looks like the <body>05:38
StevenKGoogling for YUI docs is pretty useless05:44
StevenKwgrant: I wonder if r16453 is qa-meh ...05:47
wgrantStevenK: It's easy to do05:48
wgrantStevenK: Find a project with lots of proprietary specs05:48
wgrantCheck that the query count is sensible for a user that can see them05:48
wgrantAnd check that users who can't see them indeed can't see them05:49
StevenKAnd since qas has been reset, this easier said than done05:49
wgrantEasier done that said, you mean05:50
StevenKwgrant: http://pastebin.ubuntu.com/1584603/06:12
wgrantStevenK: person_ids.remove(None) might be nicer, but otherwise that seems sensible.06:15
StevenKwgrant: .remove will raise a KeyError if we happen to get all specs with everything set. -= will not.06:15
wgrantAh, true.06:16
wgrantCarry on, then06:16
jtvHmm...  I'm getting an Unauthorized error when  viewing the translations import queue.  That's new, and a potential problem for maintenance.  Is it a private-projects thing?07:01
wgrantjtv: The traceback will tell you07:03
jtvI'm well out of practice with deciphering zope tracebacks...  Last line is: Unauthorized: (<ProductSeries at 0x2aac8d794d90>, 'name', 'launchpad.LimitedView')<br />07:03
wgrantSomehow a private project has managed to get translations...07:04
jtvLetters and thoughts to that effect occurred.07:04
wgrantjtv: What's the URL?07:04
wgrantOh, right07:05
wgrantWell, there's the problem07:05
wgrantThe relevant items have been in the queue for 18 days07:06
wgrantSo I guess the importer knows to ignore them07:06
wgrantBut one wonders why they were allowed to be created in the first place.07:07
wgrantjtv: Can you see it now?07:07
jtvwgrant: yup, that works07:08
jtvWhat did you do?07:08
wgrantI set the problematic imports to Blocked to get them to what I assume is near the end of that list.07:08
jtvYuck :)07:09
wgrantRather, but better than a 403 :)07:09
StevenKYay, another critical07:09
jtvczajkowski: it'd be a lot easier for everyone if that Bosnian project could just chuck their templates into a branch.  Assuming they're well-structured, approval will be fully automated.07:11
StevenKwgrant: https://code.launchpad.net/~stevenk/launchpad/better-person-preloading-specsearch/+merge/14531607:12
wgrantjtv: Why haven't UTC vetoed the Bosnian project?07:12
jtvI don't know that they haven't.07:14
jtvLast I heard, we were eager to see that project into a shape07:14
jtvthat we could be happy with.07:15
jtvBut I haven't kept track.07:15
jtvAs far as I know, the UTC aren't really organized at the moment.  But my position is:07:16
jtvideally there should be one Universe translation project.07:16
jtvIf we can't have that, we should try not to get in the way of useful contributions too much.07:17
jtvThe _problem_ with the project, as I see it, is that it invites doomed translations to other languages.07:17
wgrantIf a universe translation project is desired then it might as well be done under the normal Ubuntu translation infrastructure07:17
jtvWhat we suggested for that was: set up a translation group with just a Bosnian translation team, and set permissions to Restricted.07:17
jtvYes, absolutely.  Question is: who could manage such a thing?07:18
jtvIf we don't have manpower to manage it, we should take a minimal-suffocation look at what the actual problems are, because the old policies aren't serving us well enough.07:19
StevenKwgrant: Can haz review, or your peer at the pastebin earlier was enough?07:21
wgrantStevenK: r=me07:22
=== almaisan-away is now known as al-maisan
czajkowskihmm no jtv to work out what to do with this translation community09:22
=== al-maisan is now known as almaisan-away
=== almaisan-away is now known as al-maisan
mptI've forgotten ... How can I log in to staging.launchpad.net?09:59
mptsince login.staging.launchpad.net doesn't accept my 2-factor auth09:59
czajkowskiyou'll need to ask webops for help there mpt09:59
=== matsubara-afk is now known as matsubara
wgrantStevenK: If you feel like doing another small spec branch tomorrow, preloading specificationbranch should make the page constant10:28
StevenKwgrant: I meant to look at that -- what's prod versus qas now?10:30
StevenKwgrant: I guess that will just be a load_referencing() call in the pre_iter_hook10:31
wgrantStevenK: qas is 85 to prod's 18510:31
wgrant50 of those 85 are specificationbranch10:31
wgrantAnd yeah, it should be a matter of populating a cachedproperty with load_referencing10:31
StevenKwgrant: Well, it would be nice to get the page to <40 queries10:32
wgrantAnd this one thing seems to be all of the repetition10:33
StevenKwgrant: I'll circle back after I sort out the tests for mpt's latest critical.10:36
wgrantStevenK: Great10:38
=== Ursinha-afk is now known as Ursinha
=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
=== Ursinha is now known as Ursinha-afk
=== al-maisan is now known as almaisan-away
=== mpt_ is now known as mpt
=== frankban_ is now known as frankban
=== adeuring1 is now known as adeuring
=== gary_poster|away is now known as gary_poster
=== Ursinha-afk is now known as Ursinha
=== almaisan-away is now known as al-maisan
=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
=== slank_away is now known as slank
=== Ursinha is now known as Ursinha-afk
=== al-maisan is now known as almaisan-away
=== Ursinha-afk is now known as Ursinha
=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
=== matsubara is now known as matsubara-afk
=== Ursinha is now known as Ursinha-afk
=== yofel_ is now known as yofel
StevenKwallyworld: O HAI22:36
=== Ursinha-afk is now known as Ursinha
StevenKwallyworld: O HAI23:47
StevenKLet's see if you ping out again23:47
wallyworldhello there23:47
wallyworldhow's lp?23:47
StevenKwallyworld: Do you have a few seconds to help with some JS, or has Go rotten your brain?23:47
wallyworldoh yes, Go has well and truely started that process23:47
wallyworldbut i may still have some cells left23:47
wallyworlda few23:48
StevenKAnd then you had wine with dinner last night, so they're dead ...23:48
wallyworldif not, Go will finish them off today23:48
StevenKwallyworld: http://pastebin.ubuntu.com/1587421/ is my in progress diff23:49
StevenKwallyworld: I've shifted the call to .focus() when the widget isn't hidden to fix a critical, but my test breaks because document.activeElement is <body>23:49
wallyworldi'm not sure all browsers support activeElement?23:50
StevenKIs there any way to see which widget has focus?23:50
wallyworldisn't there a yui call to do that?23:51
wallyworldie there should be an attr which reflects the current focus state23:51
wallyworldi'll have a quick look23:51
StevenKI couldn't find one when looking through yuilibrary23:51
StevenKBut you and rick have always managed to find stuff when I can't23:51
wallyworldStevenK: there's a :focus css selector23:53
wallyworldperhaps you can select a child of the form which has focus and see if it it the element you want23:54
wallyworldactiveElement appears to be supported across major browsers now, but I'd have to check to see if :focus is also widely supported23:54
StevenKwallyworld: I've pulled out the element I want, I do .one('#tag-input:focus') ?23:55
wallyworldform_node.one("#tag-input:focus")? i think so23:56
wallyworldor even Y.one((...) i guess23:56
wallyworldi'm not sure why activeElement would not be working23:57

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!