=== slank is now known as slank_away [03:15] wgrant: https://code.launchpad.net/~stevenk/launchpad/cache-known-viewers-specification/+merge/145299 === Ursinha is now known as Ursinha-afk === Ursinha-afk is now known as Ursinha [03:29] * StevenK grumbles at bug 1107811. The edit function calls tag_input.focus() [03:29] <_mup_> Bug #1107811: Clicking "Add tags" or "Edit tags" doesn't focus the tags field

< https://launchpad.net/bugs/1107811 > [03:31] StevenK: Looking [03:32] StevenK: Can't you unnest _preload_specification_people? [03:34] wgrant: I probably can. Then I append the bare function to the decorators array? [03:34] StevenK: Right, a function that takes no arguments and then returns a function is not useful; you can just use the inner function directly. [03:36] wgrant: http://pastebin.ubuntu.com/1584386/ [03:37] StevenK: That looks more reasonable :) [03:37] wgrant: Is that your only issue, or still pawing at the rest? [03:38] StevenK: The rest looks fine :) [03:39] wgrant: TBH, I was expecting you to complain about the function I added to test_specification :-) [03:39] Meh :) [03:40] (And ISpecification.userCanView() is finally readable again) [03:40] Indeed. [03:47] wgrant: That MP has updated [03:53] StevenK: r=me === Ursinha is now known as Ursinha-afk [04:06] wgrant: Shall we pull apart that checkwatches core on carob, or you give me a clue about mpt's latest bug? [04:07] StevenK: Have you traced mpt's in a debugger? [04:07] In the five minutes or so I've spent on it, I've reproduced it on prod, and read the code. [04:11] * StevenK goes looking for Firebug [04:23] Hmm [04:23] So the focus() gets called [04:26] Does the widget exist? [04:27] It's hidden at the time [04:27] http://pastebin.ubuntu.com/1584453/ seems to work [04:29] Sounds plausible. [04:29] NFI how to test it [04:40] How do I check which widget has focus in a YUI test? [04:41] StevenK: document.activeElement might work [04:51] StevenK: https://code.launchpad.net/~wgrant/launchpad/ttb-refactor-create/+merge/145305 [04:53] wgrant: Won't 90+ return ubuntu.currentseries.nominatedarchindep.default_processor die horribly when a new series is in the midst of populating? [04:54] StevenK: Yes, and it does [04:54] But fixing that is harder [04:54] We generally lose a couple of jobs each time we initialise [04:54] Mmmm [04:55] wgrant: I'd prefer the one-line comment on line 89 die, and be replaced by the XXX on line 95-98 [04:55] 95-97 even [04:56] Done [05:08] StevenK: Any other objections? [05:10] wgrant: Sorry, was distacted by phone [05:11] wgrant: r=me, looks great [05:11] Thanks [05:20] Expected: [object HTMLBodyElement] (object) Actual: INPUT#tag-input yui_3_5_1_1_1359436804933_377 (object) [05:20] Hmmm [05:26] And Firebug does not love the test page at all [05:26] Chromium :) [05:27] Haven't used Chromium's JS tools [05:27] Well [05:27] They're not implemented in XUL [05:27] Which puts them a fair way ahead of Firebug [05:28] +a few million [05:29] Uncaught TypeError: Cannot read property 'style' of null /home/steven/launchpad/lp-branches/devel/build/js/yui/dom-style/dom-style.js:65 [05:30] At least it doesn't cause Chromium to spin, but it is increasing a timer for that error very quickly [05:35] Ah, archive.txt, my old nemesis... [05:35] Haha [05:35] DESTROY [05:37] Hmmm, so the _yuid of the #tag-input and document.activeElement are different [05:37] StevenK: It looks like the activeElement is the , doesn't it? [05:37] Which probably means that activeElement doesn't do what you wnat here [05:38] Hmmm, not sure about that [05:38] 16:20:24 < StevenK> Expected: [object HTMLBodyElement] (object) Actual: INPUT#tag-input yui_3_5_1_1_1359436804933_377 (object) [05:38] Oh, innerHTML is LARGE [05:38] Chromium helpfully shows me one line [05:38] Right, looks like the [05:44] Googling for YUI docs is pretty useless [05:47] wgrant: I wonder if r16453 is qa-meh ... [05:48] StevenK: It's easy to do [05:48] StevenK: Find a project with lots of proprietary specs [05:48] Check that the query count is sensible for a user that can see them [05:49] And check that users who can't see them indeed can't see them [05:49] And since qas has been reset, this easier said than done [05:50] Easier done that said, you mean [06:12] wgrant: http://pastebin.ubuntu.com/1584603/ [06:15] StevenK: person_ids.remove(None) might be nicer, but otherwise that seems sensible. [06:15] wgrant: .remove will raise a KeyError if we happen to get all specs with everything set. -= will not. [06:16] Ah, true. [06:16] Carry on, then [07:01] Hmm... I'm getting an Unauthorized error when viewing the translations import queue. That's new, and a potential problem for maintenance. Is it a private-projects thing? [07:03] jtv: The traceback will tell you [07:03] I'm well out of practice with deciphering zope tracebacks... Last line is: Unauthorized: (, 'name', 'launchpad.LimitedView')
[07:04] aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa [07:04] Somehow a private project has managed to get translations... [07:04] Letters and thoughts to that effect occurred. [07:04] jtv: What's the URL? [07:04] https://translations.launchpad.net/+imports [07:05] Oh, right [07:05] Well, there's the problem [07:06] Hmm [07:06] The relevant items have been in the queue for 18 days [07:06] So I guess the importer knows to ignore them [07:07] But one wonders why they were allowed to be created in the first place. [07:07] jtv: Can you see it now? [07:08] wgrant: yup, that works [07:08] What did you do? [07:08] I set the problematic imports to Blocked to get them to what I assume is near the end of that list. [07:09] Yuck :) [07:09] Rather, but better than a 403 :) [07:09] Quite. [07:09] Yay, another critical [07:11] czajkowski: it'd be a lot easier for everyone if that Bosnian project could just chuck their templates into a branch. Assuming they're well-structured, approval will be fully automated. [07:12] wgrant: https://code.launchpad.net/~stevenk/launchpad/better-person-preloading-specsearch/+merge/145316 [07:12] jtv: Why haven't UTC vetoed the Bosnian project? [07:14] I don't know that they haven't. [07:14] Last I heard, we were eager to see that project into a shape [07:15] that we could be happy with. [07:15] But I haven't kept track. [07:16] As far as I know, the UTC aren't really organized at the moment. But my position is: [07:16] ideally there should be one Universe translation project. [07:17] If we can't have that, we should try not to get in the way of useful contributions too much. [07:17] The _problem_ with the project, as I see it, is that it invites doomed translations to other languages. [07:17] If a universe translation project is desired then it might as well be done under the normal Ubuntu translation infrastructure [07:17] What we suggested for that was: set up a translation group with just a Bosnian translation team, and set permissions to Restricted. [07:18] Yes, absolutely. Question is: who could manage such a thing? [07:19] If we don't have manpower to manage it, we should take a minimal-suffocation look at what the actual problems are, because the old policies aren't serving us well enough. [07:21] wgrant: Can haz review, or your peer at the pastebin earlier was enough? [07:22] StevenK: r=me === almaisan-away is now known as al-maisan [09:22] hmm no jtv to work out what to do with this translation community === al-maisan is now known as almaisan-away === almaisan-away is now known as al-maisan [09:59] I've forgotten ... How can I log in to staging.launchpad.net? [09:59] since login.staging.launchpad.net doesn't accept my 2-factor auth [09:59] you'll need to ask webops for help there mpt === matsubara-afk is now known as matsubara [10:28] StevenK: If you feel like doing another small spec branch tomorrow, preloading specificationbranch should make the page constant [10:30] wgrant: I meant to look at that -- what's prod versus qas now? [10:31] wgrant: I guess that will just be a load_referencing() call in the pre_iter_hook [10:31] StevenK: qas is 85 to prod's 185 [10:31] 50 of those 85 are specificationbranch [10:31] And yeah, it should be a matter of populating a cachedproperty with load_referencing [10:32] wgrant: Well, it would be nice to get the page to <40 queries [10:33] Exactly [10:33] And this one thing seems to be all of the repetition [10:36] wgrant: I'll circle back after I sort out the tests for mpt's latest critical. [10:38] StevenK: Great [10:38] Thanks === Ursinha-afk is now known as Ursinha === Ursinha is now known as Ursinha-afk === Ursinha-afk is now known as Ursinha === Ursinha is now known as Ursinha-afk === al-maisan is now known as almaisan-away === mpt_ is now known as mpt === frankban_ is now known as frankban === adeuring1 is now known as adeuring === gary_poster|away is now known as gary_poster === Ursinha-afk is now known as Ursinha === almaisan-away is now known as al-maisan === Ursinha is now known as Ursinha-afk === Ursinha-afk is now known as Ursinha === Ursinha is now known as Ursinha-afk === Ursinha-afk is now known as Ursinha === slank_away is now known as slank === Ursinha is now known as Ursinha-afk === al-maisan is now known as almaisan-away === Ursinha-afk is now known as Ursinha === Ursinha is now known as Ursinha-afk === Ursinha-afk is now known as Ursinha === Ursinha is now known as Ursinha-afk === Ursinha-afk is now known as Ursinha === Ursinha is now known as Ursinha-afk === Ursinha-afk is now known as Ursinha === matsubara is now known as matsubara-afk === Ursinha is now known as Ursinha-afk === yofel_ is now known as yofel [22:36] wallyworld: O HAI === Ursinha-afk is now known as Ursinha [23:47] wallyworld: O HAI [23:47] Let's see if you ping out again [23:47] hello there [23:47] how's lp? [23:47] wallyworld: Do you have a few seconds to help with some JS, or has Go rotten your brain? [23:47] oh yes, Go has well and truely started that process [23:47] but i may still have some cells left [23:48] a few [23:48] And then you had wine with dinner last night, so they're dead ... [23:48] perhaps [23:48] if not, Go will finish them off today [23:48] Haha [23:49] wallyworld: http://pastebin.ubuntu.com/1587421/ is my in progress diff [23:49] ok [23:49] wallyworld: I've shifted the call to .focus() when the widget isn't hidden to fix a critical, but my test breaks because document.activeElement is [23:50] i'm not sure all browsers support activeElement? [23:50] Is there any way to see which widget has focus? [23:51] isn't there a yui call to do that? [23:51] ie there should be an attr which reflects the current focus state [23:51] i'll have a quick look [23:51] I couldn't find one when looking through yuilibrary [23:51] But you and rick have always managed to find stuff when I can't [23:53] StevenK: there's a :focus css selector [23:54] perhaps you can select a child of the form which has focus and see if it it the element you want [23:54] activeElement appears to be supported across major browsers now, but I'd have to check to see if :focus is also widely supported [23:55] wallyworld: I've pulled out the element I want, I do .one('#tag-input:focus') ? [23:56] form_node.one("#tag-input:focus")? i think so [23:56] or even Y.one((...) i guess [23:57] i'm not sure why activeElement would not be working