[13:13] gary_poster: did you see the message from StevenK (indirectly) about bug 1112799? [13:13] thanks for helping StevenK benji [13:13] <_mup_> Bug #1112799: Uploading a release to stable is broken < https://launchpad.net/bugs/1112799 > [13:13] :-) [13:13] yes [13:13] heh [13:13] the change that caused the problem is here: http://paste.ubuntu.com/1612461/ [13:16] I wonder why my upload yesterday to the trunk series worked [13:17] I /think/ the problem they were trying to solve is that some browsers send UTF-8 encoded text without specifying so in the request headers. [13:17] oof yeah. that's not a good change for us [13:17] right [13:17] and who cares about binary blobs :-) [13:17] they reverted the change, thats why it started working again [13:17] gotcha [13:17] heh [13:18] the log says "moo", no wait, the log says that they were trying to fix https://bugs.launchpad.net/launchpad/+bug/897053 [13:18] <_mup_> Bug #897053: apport generated urls can trigger UnicodeDecodeError

< https://launchpad.net/bugs/897053 > [13:19] ah ok [13:19] Martin Pool's presentation is really good. read 2/3 of it earlier this morning [13:19] https://docs.google.com/presentation/d/1awg1CHM1w128iOBp_JOxE2DgHfywBeyjDe2bkx1vfVQ/edit#slide=id.p [13:20] Some of it touches on topics we've discussed lately (tested fakes) [13:20] it seems to me that the right place to introduce this sort of guessing (if we really must) would be the text widget [13:21] * benji gets some coffee. [13:21] yeah [14:28] gary_poster, as it turns out, wsgi doesn't support %2F. But we can encode things on our end I think [14:30] therve, wow! I'll try to file that away. Thanks for investigating further. Glad you encode further. Double encoding? :-P %252F (saw somebody do that when I did my quick search) [14:30] gary_poster, yeah something like that. [14:30] k cool [14:30] I'm not sure there is anything to file. I've seen people complaining, but there is just not an obvious solution apparently [14:31] frickin' telecom "technicians", instead of fixing my line they broke the neighbor's one, leaving me stranded :-P [15:07] bcsaller, Makyo, hi. how is landing your reviewed branches going? Over WIP limit: important to get those through the queue. [15:07] gary_poster: mine was merged yesterday [15:08] ah cool bcsaller thanks. [15:08] gary_poster, no answer from others on whether or not my branch is needed anymore. If not, should I just trash the card? [15:08] Makyo, it isn't a nice improvement anyway? [15:08] * gary_poster goes to look at it [15:09] gary_poster, No, not really, unless we change history and call it 'name magic numbers', in which case, it's a four line change. [15:11] Makyo, ack. updateLinkEndpoints docstring in relation.js is fixed in your branch too. I will disconnect the bug from your card, and then you can quickly land just the trivial but still valuable bits and move on? [15:12] gary_poster, sure, sounds good. Will make a new branch. [15:14] thank you [15:14] card changed to reflect new focus, bug marked as fixed, Makyo [15:15] gary_poster, thanks [15:28] bac bcsaller benji frankban goodspud hazmat Makyo teknico call in 2 *in new Canonical-account-only jujugui room* [15:29] gary_poster, could you email me the link please [15:31] bcsaller, Can I get a quick +/- on https://codereview.appspot.com/7311046 since you have to deal with this code most? [15:32] gary_poster: having trouble joining, logged into g+ with canonical account but its still rejecting me on the link [15:32] benji bcsaller hazmat starting. bcsaller try starting from calendar daily standup link? [15:32] * benji wonders how to get the new hangout to use the right account [15:32] bcsaller, i opened incogonito and logged back in [15:33] the multi account auth doesn't seem to like these hangouts [15:33] benji, http://tinyurl.com/jujugui [15:33] "You are not allowed to join this hangout." [15:34] My evil plan is now complete :-P [15:34] Try link from calendar benji [15:34] or incognito like Kapil said [15:35] link from calendar doesn't work [15:42] benji incognito worked for you? [15:42] gary_poster: yep; I guess I'll have to do that and log in every time [15:42] not a big deal, just slightly annoying [15:42] I find that if Canonical is your first logged-in Google identity it works for me [15:42] * bac must resist the urge to eat lunch immediately after the call since it is an hour early [15:43] and if Canonical is my first logged-in Google identity then the rest of the Google world breaks for me :) [15:44] benji, ack. If this doesn't let us break the 10-participant barrier (we will be 10 people by default once Jeff joins, so that would mean other people like Ale, Jovan, Antonio and so on would have trouble joining) I'm happy to switch back [15:45] yeah, if it has no advantages we should go back, but breaking the 10-participant barrier is a biggie [16:40] could anyone make the second review for https://codereview.appspot.com/7306045? thanks! [16:42] guihelp ^^^ [16:42] * gary_poster goes to agile meeting lunch. back in 1.5 hours [16:45] frankban, I'll do it [16:46] teknico: thanks === bcsaller_ is now known as bcsaller [17:27] frankban, review done, nice running tests remotely :-) [19:17] benji, ping re: #1091273 [19:17] <_mup_> Bug #1091273: Style can be applied with different orderings resulting in slight visual differences < https://launchpad.net/bugs/1091273 > [19:18] Makyo: pong [19:18] benji qa lab machines cannot access outside world other than local deb repos and LP, so we will need to change the test script build machines in the way that we discussed [19:18] I will write up [19:19] gary_poster: interesting; sounds good [19:19] benji, it looks like we switched to a 'build-shared' target for prod, debug, and devel at some point, and there's now no difference between build-prod/index.html and app/index.html or the files they include. Suspecting it's no longer an issue, but want to make sure. [19:20] Makyo: ah; yeah it may be a non-issue now. An easy way to verify would be to take a screenshot of each and compare (flip-book style). [19:20] benji, Alright, will do. [19:29] benji, verified no difference. gary_poster, what to do with the card? [19:30] cool [19:39] Makyo, move to done Done, close card as fix released [19:39] I mean close bug [19:41] gary_poster, cool, thanks :) [19:41] :-) [20:55] * benji fights with the linter. [20:58] * benji is kicked by the linter and falls out a window. [20:59] * benji falls on his horse which gallops away. [20:59] * benji lives to fight another day. [21:00] review of source maps branch at https://codereview.appspot.com/7305047 [21:22] benji, taking a look, but also have a question. [21:25] * benji waits in rapt anticipation. [21:25] HAd to grab the bug ID, sorry. Would this maybe help with #1116320? It seems like the problem is using the un-minified version of YUI, which loads the event stuff from the yahooapis site. [21:25] <_mup_> Bug #1116320: External resources still loaded by test-debug < https://launchpad.net/bugs/1116320 > [21:25] benji, ^^^ [21:26] hmm, looking [21:28] Makyo: nope, I don't think it will help that. The using of un-minified versions is only done in the context of minifying it ourselves in the prod flavor. The debug flavor is the same as it ever was. [21:28] benji, Alright, thanks. Figured I'd check :) [21:28] :) [21:42] gary_poster: that presentation from Martin was good. The bit about Mocks living beside the thing they mock got me thinking and lead to this paper: http://jmock.org/oopsla2004.pdf -- which I have not entirely digested but seems important [21:43] benji, the abstract was too abstract. :-P I will look at it later. thanks for link [21:43] heh [22:09] Makyo: thanks for the review, you should tag the card [22:10] benji, Good catch, thank you. [22:10] if anyone else would enjoy a review, it is there for the taking