| hazmat | bcsaller, final branch is up for review, still haven't been able to get the review diff right.. it looks fine by hand | 00:07 |
|---|---|---|
| hazmat | bcsaller, revno 52 has the complete diff, all the other revs are on trunk.. | 00:14 |
| bcsaller | hazmat: did a review on lp for you | 01:17 |
| hazmat | bcsaller, thanks for the review.. commented back. surprised your coverage report didn't pickup the test, was it only being run against a particular test module instead of the full suite? | 03:16 |
| bcsaller | hazmat: it was 'make coverage' | 03:17 |
| hazmat | odd | 03:17 |
| hazmat | there's a test that explicitly checks for the backoff content in the logs in test_session | 03:18 |
| hazmat | ie. test_managed_client_backoff | 03:19 |
| bcsaller | your version of coverage shows it being trigged in manage then? for me managed only shows 83% but most of that is missing calls to error logging | 03:19 |
| hazmat | coverage locally reports its covered | 03:19 |
| hazmat | for the package i have 94% for the managed module 89% (mostly exception handling) | 03:20 |
| bcsaller | hmm, maybe I have an old coverage package | 03:20 |
| hazmat | well for the test to pass it has to hit those lines, which is what's od | 03:20 |
| hazmat | odd | 03:20 |
| bcsaller | hazmat: I'll look into it, I'm guess its something with my environment | 03:23 |
| === rogpeppe2 is now known as rogpeppe | ||
| gary_poster | teknico, feeling any better about the bug today? If not, why don't you ask to pair with Ben or Matt this morning? | 13:06 |
| teknico | gary_poster, having lunch now, but maybe a quick call? | 13:07 |
| gary_poster | sure teknico. I'm free for 53 minutes, then we have our regular call in another hour. Can do it whenever you like within my available time | 13:08 |
| teknico | gary_poster, I'm in jujugui | 13:09 |
| benji | gary_poster: when you get a second I would like to discuss the UX of the browser compatability warning | 13:39 |
| gary_poster | ack benji | 13:39 |
| bac | guihelp - anyone free to review my css branch? | 14:22 |
| hatch | good morning | 14:32 |
| benji | morning, hatch | 14:32 |
| gary_poster | morning | 14:40 |
| === teknico___ is now known as teknico | ||
| gary_poster | bac, on it | 14:42 |
| bac | gary_poster: cool. won't take long | 14:43 |
| gary_poster | cool | 14:43 |
| === teknico__ is now known as teknico | ||
| bac | thanks gary_poster | 15:07 |
| gary_poster | welcome | 15:10 |
| === teknico_ is now known as teknico | ||
| bac | gary_poster: here is a bit of a rambling explanation: http://dalelane.co.uk/blog/?p=2222 | 15:13 |
| bac | the reason i suggest we add this is it keeps IE from behaving differently when it sees the server is on the same LAN. seems like a recipe for disaster to have it work one way in development and then another when deployed. | 15:14 |
| gary_poster | bac +1. Just add a link to the blog post maybe? Not sure | 15:15 |
| gary_poster | thank you | 15:15 |
| bac | +1 | 15:15 |
| * bac looks for something more authoritative | 15:16 | |
| === teknico_ is now known as teknico | ||
| Makyo | bcsaller_, benji frankban gary_poster call now? | 15:31 |
| gary_poster | baf | 15:31 |
| gary_poster | sorry | 15:31 |
| gary_poster | thanks | 15:31 |
| gary_poster | benji frankban hazmat like Makyo said :-) | 15:32 |
| gary_poster | goodspud too :-) | 15:32 |
| frankban | guihelp: is the "failfast" behavior of the GUI test suite a bug or something we precisely decided? | 15:45 |
| gary_poster | frankban, bug I think | 15:46 |
| frankban | gary_poster: ok thanks | 15:46 |
| bcsaller_ | frankban: I think there is a 'bail' flag in mocha that is being set | 15:48 |
| bcsaller_ | bcsaller_: I suspect we can pass bail: false to the mocha init | 15:50 |
| bcsaller_ | talking to myself now, great | 15:50 |
| teknico | bcsaller_, that's ok, as long as you listen to yourself | 15:51 |
| bcsaller_ | all about good manners | 15:51 |
| frankban | :-) bcsaller_ : it works | 15:52 |
| frankban | gary_poster, bcsaller_: do we want failfast? otherwise I'll add "bail: false" in my branch. | 15:53 |
| gary_poster | :-) I vote for not failfast, but don't feel strongly about it frankban | 15:54 |
| bcsaller_ | frankban: I don't mind fail fast on the cli tests as we are mostly doing a sanity check at that point, I do the actual debugging in the browser | 15:54 |
| bcsaller_ | but I don't feel strongly either, usually with the cli tests though a single failure would prevent a lbox submit | 15:55 |
| gary_poster | mm, lbox is a good point | 15:56 |
| === jovan2_ is now known as jovan2 | ||
| hazmat | guihelp re cs:precise/juju-gui anyone know why it would result in 2013-02-07 11:10:16,812: hook.output@INFO: E: Unable to locate package python-charmhelpers | 16:15 |
| gary_poster | hazmat, that used to happen if person was not using juju from ppa. supposed to be fixed now, because we add ppa at start anyway | 16:16 |
| hatch | is `guihelp` a string that I should set to ding in my chat? | 16:17 |
| hazmat | yup | 16:17 |
| hazmat | its a group broadcast | 16:17 |
| gary_poster | hatch, yes, guihelp (among ourselves) and jujugui (on #juju channel for user help) | 16:17 |
| hatch | that's a very smart idea :D | 16:17 |
| hazmat | gary_poster, is that fixed in the ~charmers version only the ~juju-gui version? | 16:18 |
| hazmat | s/only/or only | 16:18 |
| gary_poster | hazmat, ~charmers, pretty sure. verifying. | 16:18 |
| teknico | hatch, hi, you might also want to configure your IRC client so that it shows your first name and last name too | 16:19 |
| gary_poster | hazmat, ~charmers. bootstrap_utils.install_extra_repositories('ppa:juju/pkgs') in install hook | 16:20 |
| hatch | teknico: in my whois information? | 16:20 |
| teknico | hatch, yep | 16:20 |
| hatch | oh cmon I need some kind of anonymity ;) | 16:20 |
| gary_poster | frankban, you happen to have any experience with what hazmat mentioned above in charm? I don't see why/how it would happen | 16:21 |
| teknico | hatch, do you? :-) | 16:21 |
| frankban | gary_poster: hum... no, looking at the ~charmers revision | 16:22 |
| gary_poster | frankban, http://bazaar.launchpad.net/~charmers/charms/precise/juju-gui/trunk/view/head:/hooks/install fwiw | 16:22 |
| gary_poster | hazmat, are they running on precise? | 16:24 |
| gary_poster | hazmat, or more pertinently, are they trying to run on raring. We only test on precise. the juju ppa does not have charm-tools for raring | 16:25 |
| gary_poster | python-charmhelpers are in the charm-tools version supplied by both precise and quantal | 16:26 |
| hazmat | gary_poster, its all precise | 16:27 |
| hazmat | gary_poster, the problem is actually ppa add because its a proxy environment | 16:28 |
| hazmat | the add apt repo ends up adding junk the apt repo | 16:29 |
| gary_poster | ah :-( | 16:29 |
| frankban | :-/ | 16:29 |
| hazmat | after that it fails because adding nodejs and we don't have a key for it.. | 16:29 |
| hazmat | nodejs ppa | 16:29 |
| hazmat | imo the charm shouldn't be downloading things it doesn't need for it current configuration | 16:30 |
| hazmat | ie. i'm using a release i don't need nodejs/imagemagick/etc.. i'm not using staging mode.. i don't need java/zookeeper | 16:30 |
| gary_poster | hazmat, added bug for that yesterday on your comment then. triaged as low given that it was nice to have, but put it on kanban as slack task. if this is blocker for important things then we can reprioritize. | 16:31 |
| hazmat | its a blocker for important things.. but the timeline is tight.. | 16:32 |
| hazmat | i might just hack do a hack for it | 16:32 |
| hazmat | sadly lacking access to fix directly | 16:32 |
| gary_poster | hazmat, right. is this a drop everything? The change would be risky IMO | 16:32 |
| gary_poster | you could hack and put it in your own branch? | 16:33 |
| hazmat | gary_poster, yeah.. or just pass them to the hook | 16:33 |
| gary_poster | risky only in the sense that it would need to be tested. we would have to move downloading prerequisites into config-changed | 16:34 |
| hazmat | gary_poster, understood, i'm testing a hack fix now (just commenting out all the unesc pkgs) | 16:36 |
| gary_poster | cool, sounds good | 16:36 |
| frankban | Makyo: quick hangout? | 16:42 |
| Makyo | frankban, sure. | 16:42 |
| frankban | Makyo: http://tinyurl.com/see-emily-code | 16:43 |
| Makyo | frankban, There. | 16:46 |
| hazmat | odd the gui deploys and gets to started (no hook errors) without the extra packages but it doesn't actual run.. the nginx config gets odd | 17:14 |
| * benji tweaks the unsupported browser wording. It now reads "Your browser is bad and you should feel bad." | 17:24 | |
| frankban | hazmat: what oddities are you seeing? | 17:25 |
| teknico | benji, is "now" before or after the tweaks? :-) | 17:27 |
| benji | heh | 17:27 |
| benji | we should replace all of our UI elements with memes | 17:27 |
| hazmat | frankban, nginx is running but not serving traffic.. all the pieces look like there in place but i can hit the front end webserver (its exposed) | 17:28 |
| hazmat | ie. api server running, files on disk | 17:29 |
| frankban | hazmat: any error in /var/log/upstart/juju*? | 17:34 |
| hazmat | frankban, no.. afaics the only issue is the nginx config | 17:39 |
| hazmat | the hooks all run to completion without error | 17:40 |
| hazmat | nginx config : http://paste.ubuntu.com/1621578/ charm log: http://paste.ubuntu.com/1621582/ | 17:41 |
| frankban | hazmat: is "gui" the name of the charm you deployed? | 17:47 |
| hazmat | frankban, its the name of the service charm | 17:48 |
| hazmat | hmm.. i deployed ~juju-gui's charm version | 17:48 |
| hazmat | with this diff http://paste.ubuntu.com/1621609/ | 17:49 |
| hazmat | i meant to deploy the ~charmers version.. i'll retry with that to verify | 17:49 |
| frankban | hazmat: aha! ppa:juju-gui/ppa is required so that the ssl-enabled haproxy is installed, not the precise one | 17:51 |
| hazmat | frankban, gotcha.. that's not in the ~charmers version yet right? | 17:54 |
| frankban | hazmat: right | 17:55 |
| hazmat | jovan2, the new gui vision looks much improved | 18:04 |
| jovan2 | hazmat glad you like it | 18:05 |
| Makyo | >:/ | 18:19 |
| gary_poster | Makyo, ? | 18:37 |
| Makyo | gary_poster, Firefox and Flash problems. | 18:38 |
| gary_poster | gotcha | 18:38 |
| gary_poster | bac you available to review Matt's branch? When that lands I can move some more of the CI Jenkins stuff forward | 18:40 |
| bac | gary_poster: i can. trying to get that hatch patch to work | 18:41 |
| hatch | bac - I've never actually tested that code so I would be interested to hear your results :) | 18:41 |
| bac | hatch: not good so far | 18:42 |
| bac | i expect the ie10 class to be added to <html> but it isn't | 18:42 |
| hatch | hmm is the js executing? | 18:42 |
| bac | not sure. | 18:43 |
| bac | not too adept at using the ie tools | 18:43 |
| hatch | inside the script tags console.log('it works!'); | 18:43 |
| gary_poster | thank you bac | 18:44 |
| hatch | I need to close some chrome tabs (I'm out of ram haha) and then I can boot up a Win8 VM if you like | 18:45 |
| bac | hatch: cool. i'm doing a review now but will be back at it in a bit | 18:46 |
| bac | Makyo: done | 18:48 |
| Makyo | bac, thanks | 18:49 |
| bac | hatch: got it to work. | 18:55 |
| hatch | oh excellent - what was the issue? | 18:55 |
| bac | hatch: there was a typo in the code i copied from you. missing a closing > before script. no biggie. | 19:18 |
| hatch | oh woops I should fix that in the gist | 19:19 |
| hatch | thanks | 19:19 |
| hatch | bac: I may be doing this review this wrong but I think you forgot the console.log() in the html ;) | 19:21 |
| bac | ergh, probably | 19:21 |
| bac | thanks for the catch | 19:22 |
| hatch | np and I updated the gist with the missing > :) | 19:23 |
| bac | having trouble submitting my changes due to lbox.check | 21:27 |
| bac | and then it worked | 21:42 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!