[01:26] wgrant: https://code.launchpad.net/~stevenk/launchpad/use-timeout-for-checkwatches/+merge/147586 [01:41] StevenK: Have you tested locally that it actually works? [01:42] Haha [01:43] You tell funny jokes [01:43] Now I have to remember how to do that [01:49] wgrant: 2013-02-11 01:48:53 INFO Updating 1 watches for 1 bugs on http://bugzilla.abisource.com [01:53] StevenK: But does the timeout work? [01:56] wgrant: I've also discovered mantis and trac also call their own urllib2.open, so I've changed them too [01:56] I'll check the timeout itself after lunch [01:56] Great [02:19] 2013-02-11 02:19:13 INFO Error updating http://bugzilla.abisource.com/: http://bugzilla.abisource.com: [02:24] 2013-02-11 02:23:26 INFO Updating 1 watches for 1 bugs on http://tracker.ardour.org [02:24] 2013-02-11 02:23:56 INFO Error updating http://tracker.ardour.org: http://tracker.ardour.org: [02:24] (ardour is Mantis) [03:17] wgrant: Are you happy enough with that? [03:17] That's XMLRPC and Mantis [03:17] I can dig for Trac and old Bugzilla if you wish [03:19] StevenK: Seems fine to me [03:19] No further changes? [03:19] Let me push them up [03:20] I'm tempted to refactor Mantis and Trac so there is one callsite for urlopen in base [03:21] That seems like a good idea, and it shouldn't be too hard [03:22] Current idea: Set a self.url_opener on both Mantis and Trac and teach urlopen in the base class to use it if it's set [03:23] For bonus points, set a variable to the function and call it as a function [03:35] wgrant: The MP is updated [03:37] StevenK: Can you just default url_opener to urllib2.urlopen? [03:38] How does that help? I can't call .open on that? [03:39] Ah, true. [03:39] r=me [03:59] StevenK: You lose! [04:01] Blink [04:01] I hate the checkwatches tests [04:08] - def raise404(request, data): [04:08] + def raise404(request, data, timeout=None): [05:10] * StevenK peers at these branch vocab tests [05:10] There is a test to make sure a vocab doesn't return branches owned by a OPEN or DELEGATED team [05:34] StevenK: That sounds like the series branch picker [05:38] Which is on product [05:39] Since that deals with IProduct or IProductSeries [05:54] Right, thanks to some hideous code, the branch vocab tests pass [05:54] Except my last lot of refactoring broke them [06:09] wgrant: OMG, these changes work [06:10] :) [06:12] 6 files changed, 196 insertions(+), 199 deletions(-) [06:17] * StevenK accidently deletes IBranchCollection.search [06:17] 6 files changed, 197 insertions(+), 445 deletions(-) [08:53] good morning === yofel_ is now known as yofel === jam2 is now known as jam [12:20] StevenK: Oh [12:20] StevenK: You still lose at buildbot [12:20] StevenK: Look at those test counts [12:21] There's one very long error which apparently breaks the subunit stream [12:21] lp.bugs.tests.test_bugtracker.TestMantis and checkwatches.txt, from my ec2 run [12:21] Bleh [12:21] I did wonder why the test count was quite low [12:23] wgrant: So I managed to destroy another ec2 run of yours? === almaisan-away is now known as al-maisan [12:25] StevenK: Yup [12:25] And I've only run two batches of them in the last month... [12:25] you sabotaged both! [12:28] * StevenK adds another stroke to his "wgrant's ec2 runs I've doomed by accident" board [12:29] Lies [12:33] Probably shouldn't be too bad to sort out [12:43] wgrant: Testfix landing. [12:48] StevenK: Thanks === Ursinha-afk is now known as Ursinha === wedgwood_away is now known as wedgwood === pinky is now known as brianchid === al-maisan is now known as almaisan-away === deryck is now known as deryck[lunch] === Ursinha is now known as Ursinha-afk === Ursinha-afk is now known as Ursinha === deryck[lunch] is now known as deryck === Nigel_ is now known as G === StevenK_ is now known as StevenK === cyclicflux is now known as Guest64364 === Guest64364 is now known as cyclicflux === cyclicflux is now known as Guest34077 === Guest34077 is now known as cyclicflux === cyclicflux is now known as CyclicFlux