[00:36] <StevenK> wgrant: http://pastebin.ubuntu.com/1654509/
[00:43] <wgrant> StevenK: Mmm
[00:43] <wgrant> StevenK: That's a bit of a regression
[00:44] <wgrant> I wonder if LimitedView might be better reserved for the "you can only see this archive because a build was copied out of it into a public archive" case
[00:44] <wgrant> Which might mean that an intermediate permission is required
[00:45] <StevenK> wgrant: Well, we can override getBuildRecords on IArchive to return [] if the requestor is a subscriber and it's a private archive
[00:45] <wgrant> StevenK: Ew
[00:46] <wgrant> A proper solution would not involve hacks like that, and would remove the +packages hack that is in place today
[00:46] <StevenK> Yes, which I did, and you say it's a regression
[00:47] <wgrant> StevenK: The regression is that +index no longer works
[00:48] <StevenK> I didn't know the baselayot template will only show the not shared with you string if you hold LimitedView
[00:49] <wgrant> Sure
[00:49] <wgrant> It's still a regression
[00:49] <wgrant> Not realising that something was going to break does not make it not broken :)
[00:49] <StevenK> Sure. But what can I do instead?
[00:49] <wgrant> Use a non-LimitedView permission, I guess
[00:49] <StevenK> launchpad.NotQuiteView doesn't help either
[00:50] <StevenK> Do we have a list of them?
[00:54] <wgrant> StevenK: lib/lp/permissions.zcml
[00:55] <StevenK> Hmmmm
[00:55] <StevenK> None of them are a good fit
[03:01] <StevenK> wgrant: Hmmmm, where is view/macro:is-page-contentless defined? My quick grep didn't turn up much
[03:02] <StevenK> Bah
[03:03] <StevenK> It's in app/browser/tales
[03:03] <StevenK> And it's as I feared, it checks for !View
[03:03] <wgrant> Luckily it is code
[03:04] <wgrant> You could alternatively reassign View, I guess
[03:04] <StevenK> wgrant: I've added launchpad.SubscriberView, does that make me terrible?
[03:04] <mwhudson> i think it would have upset stevea about 5 years ago
[03:04] <StevenK> Haha
[03:05] <StevenK> The comments in lib/lp/permissions.zcml make some interesting reading
[03:05] <StevenK> mwhudson: Never mind that, most of the launchpad team managed to annoy stevea in Budapest
[03:08] <StevenK> wgrant: Reassign View?
[03:08] <wgrant> StevenK: You could make +packages etc. require more than View, potentially
[03:08] <StevenK> Indeed
[03:09] <StevenK> +packages requires View in the ZCML, but the view wants Append
[03:09] <StevenK> +delete requires Edit
[03:09] <StevenK> So it's a mess
[03:09] <wgrant> Hmm?
[03:10] <wgrant> Append is for uploading/copying packages in
[03:10] <wgrant> +packages does not need Append
[03:10] <StevenK> -            # To see the +packages page, you must be an uploader, or a
[03:10] <StevenK> -            # commercial admin.
[03:10] <StevenK> -            if not check_permission('launchpad.Append', self.context):
[03:10] <wgrant> Oh, you mean for a private archive
[03:10] <StevenK> Yes
[03:11] <wgrant> Anyway, Append is clearly wrong here
[03:11] <wgrant> Because you can't protect the view with it
[03:11] <StevenK> It is already is if it's private
[03:11] <wgrant> No
[03:11] <wgrant> There's a hack that you are to entirely disregard
[03:11] <wgrant> The view is not protected
[03:13] <StevenK> Right, +edit and +delete require .Edit, and +builds and +packages require View
[03:14] <StevenK> And +subscriptions requires Append
[03:15] <wgrant> Right
[03:16] <wgrant> The key is that subscribers need to be able to see +index but not +packages
[03:16] <StevenK> Yes
[03:16] <wgrant> So you need multiple view permissions
[03:16] <wgrant> And LimitedView probably doesn't fit
[03:16] <wgrant> => you probably need another viewish permission
[03:16] <wgrant> Not Append or Edit
[03:16] <StevenK> So I've created SubscriberView
[03:17] <wgrant> Right, but you need to consider how that will interact with things that like View
[03:17] <StevenK> But that trips straight over the is-page-contentless, because that fires if you don't hold View
[03:17] <wgrant> I think lazr.restful checks for LimitedView now instead, so it's probably fine
[03:17] <wgrant> But stuff like is-page-contentless will not be
[03:50] <lifeless>  OOPS-cb18303a07bb367312fd6366522207cc
[03:50] <wgrant> Hmm?
[03:51] <wgrant> What exactly did you expect? :)
[03:51] <lifeless> not a timeout ;)
[03:51] <wgrant> It's an unbatched page that probably isn't linked from anywhere
[03:51] <wgrant> Oh, it is batched
[03:51] <wgrant> But not very well
[03:52] <StevenK> The BTF UNION BTF UNION BTF query is horrible
[03:52] <wgrant> Still, AFAIK it's unlinked and unreleased and well known to be horrible
[03:52] <wgrant> You got what you ordered :)
[03:56] <lifeless> so delete it
[04:01] <StevenK> Person:+subscriptions 19 13.25
[04:09] <wgrant> I'm not sure it's necessarily worth deleting at this point
[04:13] <lifeless> whats the current top freq timeout ?
[04:14] <wgrant>       455 /    0  POFile:+translate
[04:14] <wgrant> Most of the time
[04:14] <lifeless> thats not so bad
[04:14] <wgrant> Sometimes someone runs a dreadful bot that calls getMergeProposals on project groups, which can exceed that
[04:14] <lifeless> well done