/srv/irclogs.ubuntu.com/2013/02/21/#launchpad-dev.txt

wgrantStevenK: r=me, thanks00:01
StevenKwgrant: QA for r16500 ?00:32
StevenKNot that it matters for approximately 70 minutes00:32
wgrantStevenK: It's going to take quite a while00:35
StevenKMmmm00:37
StevenKAnd requires DF00:37
StevenKSince you have to run the PPA publisher00:37
wgrantYes00:39
wgrantIt still works. I checked yesterday.00:39
=== Ursinha is now known as Ursinha-afk
=== wedgwood_away is now known as wedgwood
wgrantStevenK: https://code.launchpad.net/~wgrant/launchpad/hide-deleted-ppas/+merge/14973703:20
StevenKHm, don't we have a array for ACTIVE, DELETING already?03:23
wgrantDon't think so03:25
StevenKwgrant: There's a check in model/person that wants to check the same thing, it can likely be simplified03:26
wgrantStevenK: Not really sure it's worth it03:39
StevenKwgrant: Eh. r=me03:46
wgrantStevenK: Thanks03:52
=== wedgwood is now known as wedgwood_away
StevenKwgrant: https://code.launchpad.net/~stevenk/launchpad/filter-spec-lists/+merge/14974806:04
wgrantStevenK: "specifications" isn't really a valid method name06:11
StevenKgetSpecifications ?06:11
StevenKHm, and I forgot to tell the interface that it's a method and not a property06:12
wgrantStevenK: Does Branch.getSpecificationLinks provide value over Branch.getLinkedSpecifications?06:13
StevenKwgrant: All the branch stuff wants the actual SpecificationBranch06:13
StevenKWhich took far too long to work out, since I originally had it returning the specs itselfs06:14
wgrantOK06:14
StevenKwgrant: So IBug.specifications -> IBug.getSpecifications() ?06:14
wgrantStevenK: Probably nicer than getLinkedSpecifications, yeah06:15
StevenKwgrant: http://pastebin.ubuntu.com/1697353/06:18
wgrantStevenK: Right. I'd also like the tests to check that an unauthorised but non-anonymous user can't see private things that they can't see06:19
wgrantAnd also, what's an accepted user?06:19
StevenKI had a brainfade06:20
wgrantAnd why has p-d-r slowed down so much...06:21
StevenKwgrant: visible_user doesn't work either06:21
wgrantauthorised06:21
wgrantshared06:21
StevenKwgrant: http://pastebin.ubuntu.com/1697385/06:22
wgrantStevenK: Sounds more reasonable06:23
wgrantI think that's it06:23
=== almaisan-away is now known as al-maisan
StevenKwgrant: Oh, that 'OK' meant your objection of getSpecificationLinks was withdrawn?06:24
=== al-maisan is now known as almaisan-away
wgrantStevenK: Yes06:28
wgrantStevenK: Given you can't easily avoid it06:28
StevenKwgrant: https://code.launchpad.net/~stevenk/launchpad/filter-spec-lists/+merge/149748 is updated06:35
StevenKwgrant: So .using(Specification, SpecificationBug).find(Specification, SpecificationBug.bugID == self.id, Specification.id == SpecificationBug.specificationID, *get... ?07:15
wgrantStevenK: No need for .using07:17
wgrantIt'll use autotables if there's no .using07:17
StevenKwgrant: http://pastebin.ubuntu.com/1697683/07:19
wgrantStevenK: Right07:19
StevenKLet me land it then07:19
=== almaisan-away is now known as al-maisan
=== al-maisan is now known as almaisan-away
=== danilos is now known as danilos-afk
=== wedgwood_away is now known as wedgwood
=== Ursinha-afk is now known as Ursinha
=== danilos-afk is now known as danilos
=== yofel_ is now known as yofel
=== deryck is now known as deryck[lunch]
=== dpm is now known as dpm-afk
=== deryck[lunch] is now known as deryck
=== BradCrittenden is now known as bac
wgrantStevenK: Bug #1131407 may be of interest23:00
_mup_Bug #1131407: BranchView.landing_candidates needs preloading <easy> <lp-code> <timeout> <Launchpad itself:Triaged> < https://launchpad.net/bugs/1131407 >23:00
StevenKAh, indeed23:01

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!