[00:01] <wgrant> StevenK: r=me, thanks
[00:32] <StevenK> wgrant: QA for r16500 ?
[00:32] <StevenK> Not that it matters for approximately 70 minutes
[00:35] <wgrant> StevenK: It's going to take quite a while
[00:37] <StevenK> Mmmm
[00:37] <StevenK> And requires DF
[00:37] <StevenK> Since you have to run the PPA publisher
[00:39] <wgrant> Yes
[00:39] <wgrant> It still works. I checked yesterday.
[03:20] <wgrant> StevenK: https://code.launchpad.net/~wgrant/launchpad/hide-deleted-ppas/+merge/149737
[03:23] <StevenK> Hm, don't we have a array for ACTIVE, DELETING already?
[03:25] <wgrant> Don't think so
[03:26] <StevenK> wgrant: There's a check in model/person that wants to check the same thing, it can likely be simplified
[03:39] <wgrant> StevenK: Not really sure it's worth it
[03:46] <StevenK> wgrant: Eh. r=me
[03:52] <wgrant> StevenK: Thanks
[06:04] <StevenK> wgrant: https://code.launchpad.net/~stevenk/launchpad/filter-spec-lists/+merge/149748
[06:11] <wgrant> StevenK: "specifications" isn't really a valid method name
[06:11] <StevenK> getSpecifications ?
[06:12] <StevenK> Hm, and I forgot to tell the interface that it's a method and not a property
[06:13] <wgrant> StevenK: Does Branch.getSpecificationLinks provide value over Branch.getLinkedSpecifications?
[06:13] <StevenK> wgrant: All the branch stuff wants the actual SpecificationBranch
[06:14] <StevenK> Which took far too long to work out, since I originally had it returning the specs itselfs
[06:14] <wgrant> OK
[06:14] <StevenK> wgrant: So IBug.specifications -> IBug.getSpecifications() ?
[06:15] <wgrant> StevenK: Probably nicer than getLinkedSpecifications, yeah
[06:18] <StevenK> wgrant: http://pastebin.ubuntu.com/1697353/
[06:19] <wgrant> StevenK: Right. I'd also like the tests to check that an unauthorised but non-anonymous user can't see private things that they can't see
[06:19] <wgrant> And also, what's an accepted user?
[06:20] <StevenK> I had a brainfade
[06:21] <wgrant> And why has p-d-r slowed down so much...
[06:21] <StevenK> wgrant: visible_user doesn't work either
[06:21] <wgrant> authorised
[06:21] <wgrant> shared
[06:22] <StevenK> wgrant: http://pastebin.ubuntu.com/1697385/
[06:23] <wgrant> StevenK: Sounds more reasonable
[06:23] <wgrant> I think that's it
[06:24] <StevenK> wgrant: Oh, that 'OK' meant your objection of getSpecificationLinks was withdrawn?
[06:28] <wgrant> StevenK: Yes
[06:28] <wgrant> StevenK: Given you can't easily avoid it
[06:35] <StevenK> wgrant: https://code.launchpad.net/~stevenk/launchpad/filter-spec-lists/+merge/149748 is updated
[07:15] <StevenK> wgrant: So .using(Specification, SpecificationBug).find(Specification, SpecificationBug.bugID == self.id, Specification.id == SpecificationBug.specificationID, *get... ?
[07:17] <wgrant> StevenK: No need for .using
[07:17] <wgrant> It'll use autotables if there's no .using
[07:19] <StevenK> wgrant: http://pastebin.ubuntu.com/1697683/
[07:19] <wgrant> StevenK: Right
[07:19] <StevenK> Let me land it then
[23:00] <wgrant> StevenK: Bug #1131407 may be of interest
[23:00] <_mup_> Bug #1131407: BranchView.landing_candidates needs preloading <easy> <lp-code> <timeout> <Launchpad itself:Triaged> < https://launchpad.net/bugs/1131407 >
[23:01] <StevenK> Ah, indeed