[00:01] StevenK: r=me, thanks [00:32] wgrant: QA for r16500 ? [00:32] Not that it matters for approximately 70 minutes [00:35] StevenK: It's going to take quite a while [00:37] Mmmm [00:37] And requires DF [00:37] Since you have to run the PPA publisher [00:39] Yes [00:39] It still works. I checked yesterday. === Ursinha is now known as Ursinha-afk === wedgwood_away is now known as wedgwood [03:20] StevenK: https://code.launchpad.net/~wgrant/launchpad/hide-deleted-ppas/+merge/149737 [03:23] Hm, don't we have a array for ACTIVE, DELETING already? [03:25] Don't think so [03:26] wgrant: There's a check in model/person that wants to check the same thing, it can likely be simplified [03:39] StevenK: Not really sure it's worth it [03:46] wgrant: Eh. r=me [03:52] StevenK: Thanks === wedgwood is now known as wedgwood_away [06:04] wgrant: https://code.launchpad.net/~stevenk/launchpad/filter-spec-lists/+merge/149748 [06:11] StevenK: "specifications" isn't really a valid method name [06:11] getSpecifications ? [06:12] Hm, and I forgot to tell the interface that it's a method and not a property [06:13] StevenK: Does Branch.getSpecificationLinks provide value over Branch.getLinkedSpecifications? [06:13] wgrant: All the branch stuff wants the actual SpecificationBranch [06:14] Which took far too long to work out, since I originally had it returning the specs itselfs [06:14] OK [06:14] wgrant: So IBug.specifications -> IBug.getSpecifications() ? [06:15] StevenK: Probably nicer than getLinkedSpecifications, yeah [06:18] wgrant: http://pastebin.ubuntu.com/1697353/ [06:19] StevenK: Right. I'd also like the tests to check that an unauthorised but non-anonymous user can't see private things that they can't see [06:19] And also, what's an accepted user? [06:20] I had a brainfade [06:21] And why has p-d-r slowed down so much... [06:21] wgrant: visible_user doesn't work either [06:21] authorised [06:21] shared [06:22] wgrant: http://pastebin.ubuntu.com/1697385/ [06:23] StevenK: Sounds more reasonable [06:23] I think that's it === almaisan-away is now known as al-maisan [06:24] wgrant: Oh, that 'OK' meant your objection of getSpecificationLinks was withdrawn? === al-maisan is now known as almaisan-away [06:28] StevenK: Yes [06:28] StevenK: Given you can't easily avoid it [06:35] wgrant: https://code.launchpad.net/~stevenk/launchpad/filter-spec-lists/+merge/149748 is updated [07:15] wgrant: So .using(Specification, SpecificationBug).find(Specification, SpecificationBug.bugID == self.id, Specification.id == SpecificationBug.specificationID, *get... ? [07:17] StevenK: No need for .using [07:17] It'll use autotables if there's no .using [07:19] wgrant: http://pastebin.ubuntu.com/1697683/ [07:19] StevenK: Right [07:19] Let me land it then === almaisan-away is now known as al-maisan === al-maisan is now known as almaisan-away === danilos is now known as danilos-afk === wedgwood_away is now known as wedgwood === Ursinha-afk is now known as Ursinha === danilos-afk is now known as danilos === yofel_ is now known as yofel === deryck is now known as deryck[lunch] === dpm is now known as dpm-afk === deryck[lunch] is now known as deryck === BradCrittenden is now known as bac [23:00] StevenK: Bug #1131407 may be of interest [23:00] <_mup_> Bug #1131407: BranchView.landing_candidates needs preloading

< https://launchpad.net/bugs/1131407 > [23:01] Ah, indeed