/srv/irclogs.ubuntu.com/2013/02/25/#launchpad-dev.txt

wgrantStevenK: Hmm02:23
wgrantStevenK: That's not really sufficient02:23
wgrantI don't think02:23
StevenKWhy not?02:23
StevenKThe access checks will check only branch rows02:23
wgrantDoesn't the existing preload thing handle stacking etc.?02:23
StevenKIt does do stacking as well, yes02:24
StevenKBut almost all of preloadDataForBMPs isn't needed02:25
wgrantYou probably need prereqs as well02:26
StevenKwgrant: Okay, I agree in terms of stacking, since that will impact the access checks.03:19
StevenKwgrant: Why prereqs?03:19
StevenKThose will already been pulled in via target_branch == self?03:20
wgrantStevenK: Howso?03:33
wgrantStevenK: prereq != target03:33
StevenKOh, it may be checked for access03:34
StevenKRight03:34
wgrantyou need access to all three branches, and their stacked-on branches03:34
wgrantStevenK: https://code.launchpad.net/~wgrant/launchpad/ppa-pub-skip/+merge/15026404:46
=== cinerama_ is now known as cinerama
StevenKwgrant: r=me, with one niggle.05:25
StevenKwgrant: https://code.launchpad.net/~stevenk/launchpad/preload-landing_candidates/+merge/150255 again?05:46
StevenKwgrant: And we'll have to go through and delete all of the empty dirs when that fix is deployed?05:47
wgrantStevenK: Yes05:48
StevenKIt would have create pool and dists and everything?05:49
StevenKI'm just wondering how much of the tree it did create off the bat05:49
wgrantYes, it created pool/ and dists/05:49
wgrantAnyway05:49
wgrantYou've checked that this change actually works?05:49
wgrantaccessing source_branchID doesn't call into the security proxy?05:49
StevenKIt does not seem to05:50
wgrantGreat.05:51
wgrantOh05:51
wgrantBecause you added them to zope.Public?05:51
wgrantYes05:51
=== almaisan-away is now known as al-maisan
wgrantThat's one bad bad security declaration05:52
=== al-maisan is now known as almaisan-away
StevenKsource_branch and prerequisite_branch were already there05:52
StevenKBut yes, IBranchMergeProposal needs fixing05:52
wgrantYes05:52
wgrantYour changes aren't worse05:52
wgrantBUt what's there today is awful.05:52
wgrantr=me, then05:53
StevenKShall I rip that crap out now in a seperate branch?05:53
wgrantFixing it may be challenging, but is necessary05:53
wgrantSo yeah, a followup would be good05:53
StevenKIBranchMergeProposalPublic etc etc05:53
StevenKLike the fun I had for IBug05:53
wgrantNot necessarily05:54
wgrantBut you can if you want05:54
wgrantThe problem is not that the attributes are listed in the ZCML05:54
wgrantThe problem is that they are all public.05:54
StevenKOh, no permission means zope.Public, not launchpad.View?05:56
wgrant<allow> means zope.Public05:57
StevenKwgrant: You lose at buildbot bingo07:32
wgrantYeah, landing now07:34
StevenKI do like one line testfixes07:37
adeuringgood morning08:27
=== almaisan-away is now known as al-maisan
czajkowskijml: you about ?11:25
=== gary_poster|away is now known as gary_poster
=== wedgwood_away is now known as wedgwood
=== al-maisan is now known as almaisan-away
cjwatsonwgrant: Any thoughts on my last set of fixes for https://code.launchpad.net/~cjwatson/launchpad/bpph-phase/+merge/144154 ?17:39
=== deryck is now known as deryck[lunch]
=== deryck[lunch] is now known as deryck
=== wedgwood is now known as wedgwood_away
=== wedgwood_away is now known as wedgwood
=== almaisan-away is now known as al-maisan
=== al-maisan is now known as almaisan-away
StevenKwgrant: My QA looks good -- aside from the extra 50 odd queries by something failing to preload people23:01
wgrantStevenK: I assume that's the subscriber list23:02
wgrantSo should be trivial to fix23:02
wgrantCare to look into it? :)23:02
StevenKI'm reading the traceback from one of the queries23:03
StevenKWhich looks to hit TAL, then view and then TAL again23:03
StevenKSome indication what line is implicated in the template would be awesome23:06
wgrantStevenK: Any luck on Branch:+index?23:53

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!