[02:23] <wgrant> StevenK: Hmm
[02:23] <wgrant> StevenK: That's not really sufficient
[02:23] <wgrant> I don't think
[02:23] <StevenK> Why not?
[02:23] <StevenK> The access checks will check only branch rows
[02:23] <wgrant> Doesn't the existing preload thing handle stacking etc.?
[02:24] <StevenK> It does do stacking as well, yes
[02:25] <StevenK> But almost all of preloadDataForBMPs isn't needed
[02:26] <wgrant> You probably need prereqs as well
[03:19] <StevenK> wgrant: Okay, I agree in terms of stacking, since that will impact the access checks.
[03:19] <StevenK> wgrant: Why prereqs?
[03:20] <StevenK> Those will already been pulled in via target_branch == self?
[03:33] <wgrant> StevenK: Howso?
[03:33] <wgrant> StevenK: prereq != target
[03:34] <StevenK> Oh, it may be checked for access
[03:34] <StevenK> Right
[03:34] <wgrant> you need access to all three branches, and their stacked-on branches
[04:46] <wgrant> StevenK: https://code.launchpad.net/~wgrant/launchpad/ppa-pub-skip/+merge/150264
[05:25] <StevenK> wgrant: r=me, with one niggle.
[05:46] <StevenK> wgrant: https://code.launchpad.net/~stevenk/launchpad/preload-landing_candidates/+merge/150255 again?
[05:47] <StevenK> wgrant: And we'll have to go through and delete all of the empty dirs when that fix is deployed?
[05:48] <wgrant> StevenK: Yes
[05:49] <StevenK> It would have create pool and dists and everything?
[05:49] <StevenK> I'm just wondering how much of the tree it did create off the bat
[05:49] <wgrant> Yes, it created pool/ and dists/
[05:49] <wgrant> Anyway
[05:49] <wgrant> You've checked that this change actually works?
[05:49] <wgrant> accessing source_branchID doesn't call into the security proxy?
[05:50] <StevenK> It does not seem to
[05:51] <wgrant> Great.
[05:51] <wgrant> Oh
[05:51] <wgrant> Because you added them to zope.Public?
[05:51] <wgrant> Yes
[05:52] <wgrant> That's one bad bad security declaration
[05:52] <StevenK> source_branch and prerequisite_branch were already there
[05:52] <StevenK> But yes, IBranchMergeProposal needs fixing
[05:52] <wgrant> Yes
[05:52] <wgrant> Your changes aren't worse
[05:52] <wgrant> BUt what's there today is awful.
[05:53] <wgrant> r=me, then
[05:53] <StevenK> Shall I rip that crap out now in a seperate branch?
[05:53] <wgrant> Fixing it may be challenging, but is necessary
[05:53] <wgrant> So yeah, a followup would be good
[05:53] <StevenK> IBranchMergeProposalPublic etc etc
[05:53] <StevenK> Like the fun I had for IBug
[05:54] <wgrant> Not necessarily
[05:54] <wgrant> But you can if you want
[05:54] <wgrant> The problem is not that the attributes are listed in the ZCML
[05:54] <wgrant> The problem is that they are all public.
[05:56] <StevenK> Oh, no permission means zope.Public, not launchpad.View?
 means zope.Public
[07:32] <StevenK> wgrant: You lose at buildbot bingo
[07:34] <wgrant> Yeah, landing now
[07:37] <StevenK> I do like one line testfixes
[08:27] <adeuring> good morning
[11:25] <czajkowski> jml: you about ?
[17:39] <cjwatson> wgrant: Any thoughts on my last set of fixes for https://code.launchpad.net/~cjwatson/launchpad/bpph-phase/+merge/144154 ?
[23:01] <StevenK> wgrant: My QA looks good -- aside from the extra 50 odd queries by something failing to preload people
[23:02] <wgrant> StevenK: I assume that's the subscriber list
[23:02] <wgrant> So should be trivial to fix
[23:02] <wgrant> Care to look into it? :)
[23:03] <StevenK> I'm reading the traceback from one of the queries
[23:03] <StevenK> Which looks to hit TAL, then view and then TAL again
[23:06] <StevenK> Some indication what line is implicated in the template would be awesome
[23:53] <wgrant> StevenK: Any luck on Branch:+index?