[02:23] StevenK: Hmm [02:23] StevenK: That's not really sufficient [02:23] I don't think [02:23] Why not? [02:23] The access checks will check only branch rows [02:23] Doesn't the existing preload thing handle stacking etc.? [02:24] It does do stacking as well, yes [02:25] But almost all of preloadDataForBMPs isn't needed [02:26] You probably need prereqs as well [03:19] wgrant: Okay, I agree in terms of stacking, since that will impact the access checks. [03:19] wgrant: Why prereqs? [03:20] Those will already been pulled in via target_branch == self? [03:33] StevenK: Howso? [03:33] StevenK: prereq != target [03:34] Oh, it may be checked for access [03:34] Right [03:34] you need access to all three branches, and their stacked-on branches [04:46] StevenK: https://code.launchpad.net/~wgrant/launchpad/ppa-pub-skip/+merge/150264 === cinerama_ is now known as cinerama [05:25] wgrant: r=me, with one niggle. [05:46] wgrant: https://code.launchpad.net/~stevenk/launchpad/preload-landing_candidates/+merge/150255 again? [05:47] wgrant: And we'll have to go through and delete all of the empty dirs when that fix is deployed? [05:48] StevenK: Yes [05:49] It would have create pool and dists and everything? [05:49] I'm just wondering how much of the tree it did create off the bat [05:49] Yes, it created pool/ and dists/ [05:49] Anyway [05:49] You've checked that this change actually works? [05:49] accessing source_branchID doesn't call into the security proxy? [05:50] It does not seem to [05:51] Great. [05:51] Oh [05:51] Because you added them to zope.Public? [05:51] Yes === almaisan-away is now known as al-maisan [05:52] That's one bad bad security declaration === al-maisan is now known as almaisan-away [05:52] source_branch and prerequisite_branch were already there [05:52] But yes, IBranchMergeProposal needs fixing [05:52] Yes [05:52] Your changes aren't worse [05:52] BUt what's there today is awful. [05:53] r=me, then [05:53] Shall I rip that crap out now in a seperate branch? [05:53] Fixing it may be challenging, but is necessary [05:53] So yeah, a followup would be good [05:53] IBranchMergeProposalPublic etc etc [05:53] Like the fun I had for IBug [05:54] Not necessarily [05:54] But you can if you want [05:54] The problem is not that the attributes are listed in the ZCML [05:54] The problem is that they are all public. [05:56] Oh, no permission means zope.Public, not launchpad.View? [05:57] means zope.Public [07:32] wgrant: You lose at buildbot bingo [07:34] Yeah, landing now [07:37] I do like one line testfixes [08:27] good morning === almaisan-away is now known as al-maisan [11:25] jml: you about ? === gary_poster|away is now known as gary_poster === wedgwood_away is now known as wedgwood === al-maisan is now known as almaisan-away [17:39] wgrant: Any thoughts on my last set of fixes for https://code.launchpad.net/~cjwatson/launchpad/bpph-phase/+merge/144154 ? === deryck is now known as deryck[lunch] === deryck[lunch] is now known as deryck === wedgwood is now known as wedgwood_away === wedgwood_away is now known as wedgwood === almaisan-away is now known as al-maisan === al-maisan is now known as almaisan-away [23:01] wgrant: My QA looks good -- aside from the extra 50 odd queries by something failing to preload people [23:02] StevenK: I assume that's the subscriber list [23:02] So should be trivial to fix [23:02] Care to look into it? :) [23:03] I'm reading the traceback from one of the queries [23:03] Which looks to hit TAL, then view and then TAL again [23:06] Some indication what line is implicated in the template would be awesome [23:53] StevenK: Any luck on Branch:+index?