/srv/irclogs.ubuntu.com/2013/02/26/#juju-gui.txt

=== Makyo is now known as Makyo|out
* bac is back12:44
benjifrankban: if you have a couple of minutes, I have a branch up for review that fixes the charmheplers problem with log messages containing "--" (bug 1130793).  The MP is at https://code.launchpad.net/~benji/charm-tools/bug-1130793-add-log-option-escaping/+merge/15044213:11
_mup_Bug #1130793: For safety, Python charm-helpers juju-log command should insert a "--" before the log message. <Juju Charm Tools:In Progress by benji> < https://launchpad.net/bugs/1130793 >13:11
gary_posterbenji, I don't think any of us are reviewers.  Was thinking about that last night after the baby woke me up again :-P  We may need to ping Mark Mims13:12
benjigary_poster: ah; will do13:12
gary_posterbenji, utlemming *might* also be able to give a review.  both he and m_3 are out west though (UT and CO respectively), so probably won't show up till later.13:21
benjigary_poster: yeah, after I invoked him I wonderd where he was and looking him up; I'll try again later13:22
gary_postercool benji.13:23
rogpeppebac: feel free to submit that CL13:40
bacrogpeppe: already done.  thanks.13:41
rogpeppebac: ah, only just showed up in my inbox. thanks.13:42
gary_posterhey frankban and teknico.  I was thinking of asking Roger if the watcher branch is far along enough for the three of us to talk with him about what you might do to start exploring the mega watcher.  Does that sound good/interesting/workable?13:47
frankbangary_poster: sounds good13:47
gary_postercool13:47
frankbangary_poster: do you have a minute? juju-gui?13:47
rogpeppegary_poster: the watcher branch is hopefully ready to be submitted - just a prereq to be submitted and a final signoff required.13:48
gary_postersure frankban great rogpeppe.  you available for a call with us soonish?  Maybe in half an hour or hour, so we have time for teknico to return, and to review the code some more13:49
rogpeppegary_poster: yeah. i've got a in 70 mins, otherwise i'm free.13:49
gary_postercool thanks13:49
hatchabout 2" of snow lastnight....of course right after I washed my truck hah14:09
teknicogary_poster, I'm back14:12
gary_postercool teknico.  frankban, teknico, how do you want to do this?  I propose that the three of us get on juju gui and look together at  https://codereview.appspot.com/7390043/ and talk about it; once we feel good, we ask Roger to join us.  I'm open to ther plans too. :-)14:13
gary_posterother14:14
frankbangary_poster: sounds good14:14
teknicogary_poster, SGTM :-)14:14
gary_postercool frankban teknico let's do it!  I'm there14:15
rogpeppegary_poster: i'm afraid that CL is showing spurious noise because of the undeclared prereq (oh how i wish we could add prereqs after creating a merge request!)14:18
gary_posterrogpeppe, s'ok :-) we're doing our best and will call you in when we give up/understand everything 14:18
hatchis ther any way to adjust the frequency of emails from a group on lp?14:26
benjibac: I added some notes to that document14:29
bacbenji: thanks14:31
hatchgary_poster: so I have been attempting to write proper tests for this app-extension branch - but I can't really do it properly without the sub-app class and fake subapp which are in other branches. What is the policy regarding this issue?14:35
gary_posterhatch will ping14:37
rogpeppegary_poster: re-warning: i'm in a call from 15 minutes from now, for probably around 30 mins.14:44
gary_posterrogpeppe, ack, we just finished our call, and since you only have 15 minutes now, I was going to suggest we have a call in 1 hour from now.  Good?14:45
rogpeppegary_poster: how about i ping you when i'm out of my call? it's sometimes pretty quick.14:45
gary_posterrogpeppe, we have a 15 minute call in 45 minutes :-)14:45
rogpeppelol14:45
rogpeppegary_poster: ok, 1600 UTC sounds good14:46
gary_posterso one hour works for us14:46
gary_postercool thanks talk to you then14:46
rogpeppegary_poster: rather, 1545 UTC, presumably14:46
gary_posterrogpeppe, yes, exactly14:46
gary_posterhatch, sorry for wait.  call in juju gui?14:46
rogpeppegary_poster: did you manage to penetrate the code BTW?14:46
hatchgary_poster: np sure14:47
gary_posterrogpeppe, yes, pretty well we think!  We have several questions to verify assumptions and so on, so you can evaluate our understanding yourself :-)14:47
rogpeppegary_poster: cool14:49
=== Makyo|out is now known as Makyo
bcsaller_Makyo: did you seem my message yesterday about the two branches?15:04
Makyobcsaller_, yeah, looked through the diffs, makes sense.  Will try them out before the call.15:05
bcsaller_Makyo: great, thanks15:05
m_3gary_poster: I'm prepping two talks for later today... so sorry tomorrow's best for me15:06
gary_posterm_3, cool,  Are you the only ~charmer who is doing regular reviews now?15:07
gary_posterOr is there someone else we can ping15:07
m_3gary_poster: nope, jamespage, negronjl, marcoceppi, imbrandon, bbcmicrocomputer, SpamapS15:08
m_3gary_poster: should all be in the rotation15:09
gary_posterm_3, oh, cool!  thanks.  didn't know SpamapS was still active15:09
m_3gary_poster: np, yup... I'll check out the queue tomorrow for a bit to see if somebody's hit it15:10
gary_postercool15:10
m_3bbcmicrocomputer is on point this week15:10
gary_posteryeah, looks like he is flooded15:10
m_3ack15:10
hatchbcsaller_: I'm a little confused as to what you wanted me to do on your last review - were you saying i should change the code? or were you just pointing that out? re the middleware route stuff15:11
bcsaller_hatch: talking about the problem, if any action was needed it would happen in another branch15:12
hatchalright thanks15:12
gary_posterbcsaller_, I liked both options.  I might prefer the second (ordering one) but if the wind blew the other direction I might switch sides. :-)15:13
Makyobcsaller_, running juju/delta-annotations and merging my work with juju-gui/landscape-links, I now see the landscape controls on the bottom bar as applicable \o/15:24
bcsaller_Makyo: sweet15:25
gary_posterjujugui call in 215:28
gary_posterbac not sure if you are here but starting without you.15:30
baci am.  have my sound off so i didn't hear the alert.  joining now.15:33
gary_postercool15:33
bcsaller_improv changes  lp:~bcsaller/juju/delta-annotations  gui-side  lp:~bcsaller/juju-gui/landscape-links15:39
hatchbac: do you call in ondialup? :)15:41
bacer, no15:42
bachatch: usually my 4G phone is better, though.  i'll start using it for daily.15:42
bachatch: though i had trouble a few weeks ago when in NC using FIOS.  go figure.15:43
hatchheh maybe it's your laptop :)15:43
bacbenji: i just added the new section. take a look.15:52
benjibac: looking now15:52
rogpeppegary_poster: are we doing the call?15:56
gary_posterrogpeppe, yes.  sorry, on call with mramm now, almost done15:57
rogpeppegary_poster: np15:57
benjibac: looks good, I had a couple of suggestions15:58
gary_posterrogpeppe frankban teknico https://docs.google.com/a/canonical.com/spreadsheet/ccc?key=0AoQnpJ43nBkJdEFIZVg0dnN0SXNNREpTMTd6X1FMS1E#gid=115:58
bacbenji: great15:58
gary_posterrogpeppe, frankban teknico oops :-P https://plus.google.com/hangouts/_/7fb7c30f3a232db57dd8549738fb98e723d90d4a16:00
teknicogary_poster, nice X's though ;-)16:01
gary_poster:-)16:01
hatchdoes mocha have a way to log to the console?16:03
hatchtheir documentation kind of sucks :)16:04
bcsaller_hatch: console.log16:08
hatchbcsaller_: yeah odly enough nothing is getting logged to the console16:08
hatchthe test is showing as completing16:08
bcsaller_using the prod build the console is disabled, maybe thats what you're seeing16:09
hatchI'm getting loader: Has Skin? cssreset-context : false  these logs in there16:10
bcsaller_you're using make test-server and using the browser?16:10
hatch`make test-server debug`16:10
hatchand in the browser16:10
bcsaller_the browser should have no issue with logs16:10
bcsaller_mocha-phantomjs can fail on logging objects that can't serialize to JSON (usually objects with cycles)16:11
bcsaller_but the browser can handle it 16:11
hatchhmm then wth is going on here16:12
hatchwe really need a way to run individual test suites heh16:13
bcsaller_hatch: its easy, there are a few ways to do this, the simplest is to change describe to describe.only16:14
bcsaller_or change 'it' to 'it.only'16:14
bcsaller_to run a suite or a single test 16:14
hatchso there is some type of command which will only run a single js file?16:14
bcsaller_with .only applied any method of running the tests will do the right thing16:15
bcsaller_another option is to pass ?grep=somestring at the end of the URL you're accessing16:15
bcsaller_which also works16:15
bcsaller_but .only is very simple if you have the test in the editor already 16:15
hatchyeah the grep fails every time with a 40416:15
hatchbut the only worked nicely16:16
hatchnow to figure out what's going on with this logging16:17
bcsaller_the current skin around grep puts a trailing slash where there shouldn't be on, remove the slash and it works16:17
hatchhttps://gist.github.com/hatched/5638c5dde8fcfeac49b816:18
hatchso those console.logs should output to the browser console?16:19
hatchI just want to make sure I didn't mess something up which would cause them not to16:20
hatchif I enable YUI debug logs those end up in the console so I'm going to guess that these console.logs are being trapped somehow16:21
hatchI should mention that if I use console.log in any other test file the logs aren't outputed to the console16:22
hatchyeah looks like console.log is being clobbered16:28
hatchdarn16:28
teknicogary_poster, sorry, lost both land lines at once, connected via mobile now, which is not very much conducive to hangouts16:30
=== teknico is now known as teknico_mobile
gary_posterteknico, :-( sorry.  we'll fill you in when we can16:31
hatchyikes - must be a lot of construction around you guys :)16:32
hatchor the nom nom fiber eating moles16:32
teknico_mobilehatch, nah, just rotten countryside copper wires :-/16:32
hatchahh that'll happen16:34
hatchour primary telco is a crown corp so we have pretty unreal communications16:34
hatchsomething like 95% of the prov can get high speed internet16:35
hatchand we only have ~1M people hah16:35
hatchof course that comes with its own side effects....primarily being that the customer service SUCKS!16:36
hatchthere is only one real competitor for landline/internet but they have bandwidth limits16:38
hatchand there are a ton of mobile competitors but they don't have many towers16:38
=== teknico is now known as teknico_mobile
hatchvictory!17:05
hatchat least debugger; still worked :)17:05
hatchgary_poster: ok subapp-extension branch now has tests - much to the chagrin of mocha I'm sure17:16
hatch:P17:16
gary_poster:-) will look soon17:17
benjigary_poster: I'm looking to start a new card (pausing my slack one) since my charmhelpers branch was reviewed and approved.  The "Story 1" lane is the only one not at the WIP limit and it has no high priority cards.  Is there one you would prefer I take?17:28
gary_posteron call...17:28
gary_posterbenji, new command?17:29
benjigary_poster: sounds good, that's what I was thinking17:29
gary_postercool17:29
benjigary_poster: should "get_annotations" be blocked because there aren't "annotations" in go-juju?17:30
gary_postery benji17:30
* benji blocks that card, and set_annotations17:30
benjier... "update_annotations"17:31
benjiand "remove_annoations"17:32
Makyobcsaller_, minor on the delta-annotations branch.  The annotation is being passed as 'landscape-needs-rebooot'.  Can we settle on either two or five 'o's for 'reboot'?17:38
bcsaller_ha, wonder how that happened, I'll push an update now17:38
bcsaller_Makyo: pushed17:39
Makyobcsaller_, thanks.17:39
Makyobcsaller_, everything's working with one change to the gui branch.  Will grab a diff.17:59
bcsaller_Makyo: excellent17:59
Makyohttp://pastebin.ubuntu.com/5568288/18:00
Makyobcsaller_, er, the last bit is from merging, never mind that.18:01
bcsaller_ha, ok18:02
hatchlunch &18:06
benjigary_poster: let me know when you have a second for a post-pre-implementation call18:54
bcsaller_Makyo: ahh, thanks for the diff, I read it wrong the first time missing _where_ in the file you were doing the update, makes sense and applied19:02
Makyobcsaller_, thanks.  +1 from me, then.19:02
gary_posterbenji can have quick one now or longer one later19:03
gary_posterwhich do you prefer19:03
benjigary_poster: lets try now19:03
gary_posterok19:03
benjithe regular place?19:03
gary_posteryeah19:03
Makyoguihelp - If someone's got time, a quick review of https://codereview.appspot.com/7369054/ would help move the landscape stuff along quickly.19:05
hatchI'll take one19:06
hatchgive me a few19:06
Makyohatch, thanks.19:06
hatchMakyo: does this after update stuff have anything to do with the reason the app call dispatch() so much?19:07
Makyohatch, possibly on views other than the environment view.19:08
Makyohatch, that'd be another branch, though.  Goal is to try and have branches for the rest of the landscape work today.19:09
hatchyep that's fine19:09
hatchso this 'update' event is actually from another view/model?19:11
bacbenji: do you know how to run 'go test -gocheck.v' for juju-core?  it seems to have a different syntax.19:12
Makyohatch, update happens when a delta is received from the server.19:12
bacthat is, you can run 'go test ./...' from launchpad.net/juju-core19:12
bacbut if you add -gocheck.v it says there is no go source there19:12
bacannoying19:12
gary_posterbac is the jujucore exercise done now that you sent out the email with instructions?  (have not yet read and will do so)19:13
bacgary_poster: i think yes19:14
gary_postercool thanks19:14
baccard moved19:14
gary_posterthx19:14
hatchMakyo: can you point me to the file where it's being fired from?19:16
bcsaller_hatch: app/models/models.js:Database is the primary source19:17
Makyohatch, bcsaller_ line 51119:17
hatchgot it thanks guys - just writing my response right now19:18
bacbenji: nm, it doesn't look like you can run 'go test -gocheck.v' recursively.19:18
hatchbcsaller_: Makyo done19:23
bacgary_poster: roger is working on 'juju set' config, bug 1130169.  not sure how you want to handle the card19:26
_mup_Bug #1130169: Support set_config in juju-core env <jujucore> <juju-gui:In Progress by rogpeppe> < https://launchpad.net/bugs/1130169 >19:26
baci linked the bug to his branch and assigned him the bug19:26
gary_posterbac set_config bug 1130169 also right?19:26
_mup_Bug #1130169: Support set_config in juju-core env <jujucore> <juju-gui:In Progress by rogpeppe> < https://launchpad.net/bugs/1130169 >19:26
bacgary_poster: that is the same bug19:27
gary_posterbac I put it in tracking for now19:31
hatchgary_poster: because it looks like you aren't doing anything today ;) I have added tests to both of the tasks blocking the kanban19:32
bcsaller_Makyo: its in if you didn't get that notification19:32
gary_posterhatch, heh19:32
gary_posterlooking19:32
Makyobcsaller_, thanks, grabbing some food now, will merge after lunch.19:32
hatchcrap sorry I committed the test code with only in it19:35
gary_posterhatch, huh?19:35
hatchdescribe.only()19:35
hatchvs describe()19:35
gary_posteroh19:35
hatchre-proposing now19:35
gary_postercool, will be back in a few19:36
bacgary_poster: ping me when you're back19:53
gary_posterbac, I'm back19:53
bacgary_poster: for things like bug 1130159 the work entails only the juju-core side, no?19:54
_mup_Bug #1130159: Support expose in juju-core env <jujucore> <juju-gui:In Progress by bac> < https://launchpad.net/bugs/1130159 >19:54
bacit has that right in the title but the body shows juju-gui env bits19:55
gary_posterbac, the bug represents both sides.  You are welcome to subdivide it19:55
bacgary_poster: is it your expectation that they be done in lockstep?19:55
bacor close19:55
gary_posterbac, juju-core env can also refer to the JS juju-core env19:55
gary_posterbac, close19:56
gary_posterbac, we should verify practically each step of the way that JS is working fine with what we implement on the Go side, so we don't get nasty surprises19:56
gary_posterI don't expect them, but that's why they are called surprises :-P19:57
bacgary_poster: not to nit picks, but those bugs should at least have two bug tasks, one for juju-core and one for juju-gui.  i'll update the expose one.19:58
gary_posterthanks bac19:58
bacrats, i can't change importance on the juju-core bugtask.20:00
benjiteeny-tiny review up at https://codereview.appspot.com/737705620:07
gary_posterbenji and bcsaller, I philosophically support both of your small branches, though I won't have time for reviewing them till later.  hatch, am I right in assuming that your changes to the branch have been ready for me for some time now?20:24
hatchgary_poster: yeah :) I knew you were busy so that's alright20:24
benjigary_poster: my branch has been reviewed and landed.  Where is your philosophy now!?20:24
hatchlol20:24
gary_posterbenji, lol, happy to see that was unnecessary20:25
benji:)20:25
gary_posterbcsaller and hatch I have to specify goals for the sprint.  I'd like you to focus on getting the continuous integration and IE fixes.  The goal would be to have CI working with Jenkins on Canonistack, which will have a few interesting challenges; to have at least some of the integration tests passing on IE, which will also be interesting; to fix at least four IE bugs; and to identify remaining necessary work.20:27
gary_posterIs that alright?  I can help as possible.  We can have some remote help to from Diogo Matsubara20:27
gary_posterwho has done some Jenkins set up in the past20:27
hatchgary_poster: I won't have any way to test IE10 there20:27
gary_posterhatch, no virtualbox?20:27
hatchmy laptop only has 4GB of ram but I could attempt it :)20:28
gary_posterheh20:28
gary_posterI hear ya20:28
hatchif I can get it running then I have no issues with that task20:28
hatchok I lied I only have 3GB according to `free -m`20:30
hatchso it doesn't look like I'll even be able to run win 820:30
hatchor am I going to have to buy a new laptop before Sunday? ;)20:32
gary_posterheh20:33
gary_posterno, but darn.  best laid plans20:33
hatchmaybe I can buy some more ram20:34
hatchI wonder if my old mac mini ram will fit20:34
hatchif so then....problem solved20:34
MakyoI only have 4GB20:38
MakyoI think I assigned 2 to the Win8 VM.20:38
gary_posterhatch ^^20:38
Makyohatch, It'll run IE, at least, but not much more :)20:38
hatchyeah I only have 3 - I tried to assign less than 2 on my desktop here and it locked up every time20:38
hatchit appears to be running...20:40
hatchubuntu loaded20:40
hatchfree -m gives me.....20:41
hatchBOOM20:41
hatch8GB20:41
hatchok problem solved20:41
hatchpfft and my wife always complains that I keep too much junk around20:41
hatch:P20:41
hatchjujugui - any chance I could get final reviews on https://codereview.appspot.com/7384059/ and https://codereview.appspot.com/7381055/ today please ? :)21:08
benjihatch: if your original reviewers can't make a return appearance, let me know and I can take a look21:09
gary_poster:-) I will do mine starting in 5.  21:09
bcsaller_hatch: I'll review in 5 or 10 as well21:09
hatchthanks!21:10
gary_posterhatch https://codereview.appspot.com/7381055/ is done22:08
gary_posterlooking at others22:08
hatchthanks - loosk like I have a few things to add/change I'll be sure to do those tonight22:08
hatchbcsaller_: thoughts on passing in factories vs strings for the sub app registration?22:13
hatchgary_poster would prefer factories/constructor, I used strings to match the view syntax22:13
hatchbut I'm impartial either way22:13
* gary_poster waves22:14
bcsaller_hatch: I think explicit passing is pretty simple, I went with that for the component system we use as well.22:15
hatchok I'll change that syntax then22:15
hatchbcsaller_: wrt the navigate overwrite - it worked as expected in the prototype but I also anticipate there will be side effects but without a more complex example I have no idea what those might be22:16
bcsaller_hatch:  topo.addModule(views.ServiceModule); It is explicit and can still reveals the namespace.22:16
bcsaller_hatch: maybe it leaves enough of the code inert, but there are still bound handles to history events I think, guess we'll see22:18
hatchI'll spend some time tonight to investigate further22:19
hatchthanks for the reviews!22:21
gary_posterok hatch, did the other one now :-P https://codereview.appspot.com/7384059/22:35
hatchthanks :) I want this out of my hair so I'll fix everything in the comments and have it ready in the morning22:37
gary_posterhatch, is the namespace you describe just a convention, or part of a YUI feature?  https://codereview.appspot.com/7369054/diff/1/app/app.js#newcode25922:37
hatchit's a little bit of both actually22:38
gary_postercool hatch.  I said LGTM, so for me you don't need me follow-up review unless you want it22:38
hatchone sec let me find an example22:38
gary_posterThe "cool" was re the "fixing everything"22:38
gary_posterok thanks22:38
hatchhere is an example of it being part of yui archiecture http://bazaar.launchpad.net/~hatch/juju-gui/1130790-extend-app-subapp/view/head:/test/test_sub_app.js#L3022:40
hatchsee because I 'published' the event and included a 'facade' it namespaces the events automatically22:40
gary_posterah!22:41
gary_posterok cool22:41
gary_posterty22:41
hatchhttp://bazaar.launchpad.net/~hatch/juju-gui/1130790-extend-app-subapp/view/head:/app/assets/javascripts/sub-app.js#L1922:41
* gary_poster is exhausted :-P 22:41
gary_posterI need to run22:41
gary_posterhave a great evening everyone22:41
hatchalrighty have a good night :)22:41
bcsaller_nite22:41
gary_posterhatch, yeah I remembered that from review, thx22:42
gary_posterbye22:42
hatchyeah so if you don't publish the event it's usually convention to namespace it22:42
hatchjust to avoid collisions22:42
hatch:)22:42
hatchand then anyone reading the code knows where it's from too22:42
hatchbut yeah, my comment was moreso just a `FYI` :)22:43
bcsaller_Makyo: https://codereview.appspot.com/7381060/  is the menu wip branch, I suspect we both have code to push the landscape object to the topo, but thats a minor merge.22:53
Makyobcsaller_, Was just about to ping.  Running into scope problems.22:54
bcsaller_Makyo: need a call about it?22:54
Makyobcsaller_, Yeah, I think I'm basically stuck :P22:54
bcsaller_Makyo: in hangout22:55

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!