| rick_h_ | is there a known way around lint issue with 'event_caught.should.be.true;' ? just change it to an equal and move along? | 01:16 |
|---|---|---|
| bcsaller_ | event_caught.should.equal(true) | 01:23 |
| rick_h_ | k, yea, changed up to that and moved along | 01:24 |
| gary_poster | bcsaller__, Makyo heads up: we need designer review for your landscape branches before landing. I'll give more details later today | 13:26 |
| therve | gary_poster, hi | 13:28 |
| gary_poster | hey therve | 13:29 |
| therve | gary_poster, I'm sorry I didn't follow on annotations testing. Where are you at? | 13:29 |
| gary_poster | therve, np. We have a branch ourselves to provide some testing data. We have all infrastructure ready in GUI and are just hooking up assets. I expect it will be all landed by tomorrow, at which point we will be done unless told otherwise. :-) | 13:30 |
| therve | ok great | 13:30 |
| therve | gary_poster, it will end up quickly in the charm store version I guess? | 13:31 |
| gary_poster | therve on our regular schedule it would be up sometime this coming Monday. We have a sprint next week so that schedule might be a little rocky. If you would like it in the charm store asap we can try to make a release end of this week. That probably would be reasonable anyway | 13:32 |
| therve | gary_poster, that's ok. If you can just ping me when it's up there, we'll be able to test on our side end to end | 13:33 |
| gary_poster | therve, great! sounds perfect, will do | 13:34 |
| therve | sweet thanks | 13:34 |
| gary_poster | thank you | 13:34 |
| rick_h_ | morning all, anyone have some spare tmie for a review this today? https://codereview.appspot.com/7363055/ | 13:39 |
| rogpeppe | gary_poster: FYI the watcher branch has landed | 13:42 |
| gary_poster | Morning rick_h_ . I think we should have a call with you, hatch, maybe bcsaller__ if he wants, and myself when they show up (should be in 20 minutes or so). charmbrowser should work in context of subapp and multi-dimensional url code. | 13:43 |
| gary_poster | pre-imp might be good plan for branches at the statr now | 13:44 |
| gary_poster | pre-imp with gui team | 13:44 |
| bcsaller__ | gary_poster: we have assets from the newer design so things don't match at all, we'd either need old style versions or new versions of the existing ones | 13:44 |
| rick_h_ | gary_poster: yea, saw the subapp branches fly by. There was talk of one of us on your stand ups but not heard any updates on that | 13:44 |
| gary_poster | rogpeppe, awesome! | 13:44 |
| rick_h_ | gary_poster: rgr. | 13:44 |
| gary_poster | rick_h_, I mentioned to sinzui that you all are completely welcome | 13:44 |
| gary_poster | bcsaller__, ack. Could you make a quick screenshot to show goodspud? | 13:45 |
| rick_h_ | gary_poster: yea, he was going to check on the timing of your stand up and get back to us but haven't heard | 13:45 |
| rogpeppe | gary_poster: am just playing around with proof-of-concept bottom-up stuff for the megawatcher | 13:45 |
| gary_poster | awesome rogpeppe . Did you see the novel I wrote for the spreadsheet? | 13:45 |
| rick_h_ | gary_poster: but yea, would love to have a conversation and a chance to brain dump. | 13:45 |
| rogpeppe | gary_poster: not sure i did actually | 13:45 |
| gary_poster | rick_h_, 10:30 EST, 1530 UTC | 13:45 |
| gary_poster | rogpeppe, https://docs.google.com/a/canonical.com/spreadsheet/ccc?key=0AoQnpJ43nBkJdEFIZVg0dnN0SXNNREpTMTd6X1FMS1E#gid=1 | 13:45 |
| rick_h_ | gary_poster: ok cool good to know | 13:46 |
| rogpeppe | gary_poster: i see what you mean by "novel" :-) | 13:47 |
| gary_poster | :-) | 13:47 |
| gary_poster | rogpeppe, if you have any concerns would be happy to talk/adjust | 13:48 |
| bcsaller__ | gary_poster: https://docs.google.com/a/canonical.com/file/d/0B4VD02DIPjvMRS02dzlKS1hlX2s | 13:48 |
| bcsaller__ | brb | 13:49 |
| gary_poster | bcsaller__, "Sorry, the file you have requested does not exist." | 13:49 |
| gary_poster | try sharing with me explicitly? | 13:49 |
| rogpeppe | gary_poster: any chance it could be bullet pointed? (aside: i find the present tense style a little odd - it sounds like we already have some of this stuff; perhaps "make read-only GUI work with juju-core" might read better than "Read-only GUI works with juju-core". ignore this trivial suggestion at will! | 13:50 |
| gary_poster | rogpeppe I couldn't add any in-cell newlines. wil try again | 13:51 |
| rogpeppe | gary_poster: hmm, maybe it's not possible. | 13:52 |
| rogpeppe | gary_poster: maybe just 1) xxxx 2) yyyy, then | 13:52 |
| gary_poster | ok cool rogpeppe | 13:53 |
| gary_poster | rogpeppe, future tense and identifying numbers/letters added | 14:00 |
| hatch | morning | 14:00 |
| hatch | gary_poster: just making coffee then I'll be ready for a call | 14:01 |
| gary_poster | morning hatch. thanks | 14:01 |
| rogpeppe | gary_poster: looks great, much easier to take in, thanks! | 14:01 |
| gary_poster | cool, thanks for review and suggestions | 14:01 |
| bcsaller__ | gary_poster: is https://docs.google.com/a/canonical.com/file/d/0B4VD02DIPjvMRS02dzlKS1hlX2s/edit better? | 14:01 |
| gary_poster | yes bcsaller__ thanks | 14:02 |
| === bcsaller__ is now known as bcsaller | ||
| gary_poster | goodspud, hi. bcsaller points out that icons we've received for landscape integration are for the future, not the present--note icon size (and color?) of https://docs.google.com/a/canonical.com/file/d/0B4VD02DIPjvMRS02dzlKS1hlX2s/edit | 14:03 |
| hatch | bcsaller__: did you want me to make any changes to the subapp branch? https://codereview.appspot.com/7384059/ | 14:03 |
| gary_poster | goodspud, how would you like to proceed? | 14:03 |
| goodspud | gary_poster, I'm just having a chat with Greg about it. Please hold caller... | 14:04 |
| bcsaller | hatch: If you made the previous changes it should be fine :) | 14:04 |
| gary_poster | thanks goodspud | 14:04 |
| hatch | gary_poster: ok ready | 14:06 |
| gary_poster | hatch, cool. rick_h_ hatch and bcsaller if he wants to (I'll call you in if we have a deep discussion of the URL namespace stuff) let's meet in the juju gui room | 14:07 |
| bcsaller | gary_poster: I can join in a minute, coffee is almost ready :) | 14:08 |
| gary_poster | heh ok | 14:08 |
| gary_poster | cool | 14:08 |
| goodspud | gary_poster, bcsaller__ , Greg is going to provide you with icons at a reduced size. He based the updated designs on the specifications provided by Matt Chapman which weren't fully implemented anyway. So at some stage we'll have to update the pop-up menu.... unless we get rid of it completely for 13.10 (which is a possibility). | 14:12 |
| goodspud | gary_poster, bcsaller__ . Greg is working on them now. The text shouldn't be blue though. Same colour/style as the text for other menu items. | 14:16 |
| goodspud | gary_poster, bcsaller__ , updated icons are here: https://drive.google.com/a/canonical.com/#folders/0B1IM--9A1RkTUEpZN2h6cEwtVFk | 14:21 |
| gary_poster | thanks goodspud sorry on call | 14:21 |
| goodspud | np | 14:21 |
| gary_poster | bcsaller, do you have enough info for landscape branch now? | 14:43 |
| bcsaller | gary_poster: looks that way, updating now, thanks | 14:43 |
| gary_poster | cool ty | 14:43 |
| gary_poster | frankban, approved FF testfix branch, ty. Don't see card (slack I guess?) but you can put me on tag if there is one | 14:50 |
| teknico | gary_poster, the card is down in slack, I put your tag on it | 14:51 |
| frankban | gary_poster: thanks | 14:51 |
| hatch | bcsaller: hey are you looking for reviews for 7381060? | 15:08 |
| bcsaller | hatch: yes, that would be helpful | 15:10 |
| hatch | ok anything special I need to do to view these new features ? | 15:10 |
| hatch | or just checkout and run | 15:10 |
| hatch | er....branch and run | 15:10 |
| * hatch smacks git out of head | 15:10 | |
| bcsaller | hatch: oh, you need the special rapi-rollup branch for it to work, lp:~bcsaller/juju/delta-annotations/ | 15:11 |
| bcsaller | that should get merged soon, but for now. | 15:11 |
| bcsaller | I'll put it on the card | 15:11 |
| hatch | deal | 15:12 |
| bcsaller | it is however a pretty simple branch | 15:13 |
| hatch | yeah looks like it - how do I get the icons to show? | 15:19 |
| bcsaller | hatch: if you click on services in the env view some of them will be tagged (at random) in ways that make the new menu items appear. | 15:19 |
| * hatch doesn't belive you :P | 15:22 | |
| hatch | tried sample and large | 15:22 |
| bcsaller | hatch: you're using improv from the delta-annotations branch? | 15:23 |
| hatch | that I am | 15:23 |
| bcsaller | sample starts with 15 units, there is a 33% chance of any unit being flagged with either of the annotations so the odds that none of them are flagged is... very low | 15:25 |
| hatch | ok let me restart them | 15:25 |
| bcsaller | hatch: you see the normal service menu but the new items don't appear or you're not sure where to look still? | 15:26 |
| bcsaller | hatch: on the improv console you can see the annotations in the outgoing delta stream as well, thats something to look for | 15:26 |
| hatch | view, build relation, destroy are the only ones that appear | 15:26 |
| hatch | jujugui in 30s? | 15:29 |
| gary_poster | I's comin | 15:32 |
| gary_poster | benji | 15:33 |
| benji | coming | 15:33 |
| benji | gary_poster: google+ browser plugin is broken; diagnosing | 15:34 |
| bac | gary_poster: can you paste that here? | 15:41 |
| gary_poster | "designreview" | 15:41 |
| bac | can't believe you fell for that | 15:41 |
| gary_poster | LOL | 15:41 |
| bac | LGTU | 15:42 |
| teknico | benji, lots of hum noise when you open the mic | 15:50 |
| Makyo | Shoot, bcsaller goodspud, did you want to do the review now? | 15:55 |
| goodspud | Makyo, when you guys are ready | 15:55 |
| Makyo | I ran away too fast. | 15:55 |
| bcsaller | Makyo, goodspud we can try the screen share now | 15:55 |
| Makyo | goodspud, we're in jujugui | 15:55 |
| goodspud | Coming! | 15:55 |
| hatch | here goes - attempting to work solely from my laptop | 16:42 |
| rick_h_ | hatch: laptops ftw | 16:43 |
| rick_h_ | laptops + dock for more win | 16:43 |
| hatch | yeah that won't happen with this laptop - it only has an HDMI port and my monitor is too high resolution | 16:43 |
| hatch | but I need to make sure I have everything for the sprint | 16:43 |
| rick_h_ | hatch: ah, gotcha | 16:44 |
| rick_h_ | yea, I'm always ready to get home to larger displays/real keyboards by the end of sprints | 16:44 |
| hatch | stretching 1920x1080 to 2560x1600 make it look REALLY bad heh | 16:44 |
| rick_h_ | hah | 16:45 |
| hatch | I've already found I have no tunes on here....that's a serious issue | 16:46 |
| hatch | :P | 16:46 |
| rick_h_ | heh, just downloaded all my Google music onto the laptop second drive yesterday myself | 16:47 |
| hatch | I also noticed that thunderbird has a lot of chrome | 16:51 |
| hatch | makes for very small views on a laptop :) | 16:52 |
| rick_h_ | *cough* tilingWM *cough* | 16:52 |
| hatch | right now I have each app in it's own desktop | 16:53 |
| hatch | the top 1/5th of my monitor is still chrome :) | 16:54 |
| gary_poster | jujugui, does anyone happen to have a nexus 10? this is a work-related question :-) | 17:09 |
| hazmat | gary_poster, nexus 7 in hand | 17:10 |
| hatch | n7 here as well | 17:10 |
| hatch | :) | 17:10 |
| hatch | good news - I changed the sub app code and my tests failed.....at least I know those are working :D lol | 17:11 |
| * benji considers several options for "does anyone happen to have _______? this is a work-related question" jokes. | 17:11 | |
| hatch | I see what you did there... | 17:11 |
| gary_poster | cool hazmat and hatch, thanks. we need to support nexus 10 by April, at least at minimal demo level. We can check out the GUI on the n7 at the sprint and see how we are doing. | 17:11 |
| hatch | can I requisition one? ;) | 17:11 |
| gary_poster | yeah, I tried that already ;-) | 17:12 |
| rick_h_ | yea, been hovering over the buy button since I saw the touch demos | 17:12 |
| benji | gary_poster: nexus 10 running Android or Ubuntu? | 17:12 |
| gary_poster | benji, android I think | 17:12 |
| hatch | gary_poster, right now sorry they are out of stock in Canada so I can't even buy one | 17:12 |
| gary_poster | But Ubuntu would be cool | 17:12 |
| rick_h_ | hmm, in stock here in play store :) | 17:13 |
| benji | in that case testing on another tablet might give us a good start | 17:13 |
| rick_h_ | abentley: has an android tablet, is it a 10"? | 17:13 |
| hatch | I have access to a Surface RT just FYI | 17:13 |
| Makyo | I still have the touch improvements branch laying around. I dropped it when we said we were moving the touch story to 13.10, assuming it's back on track? | 17:14 |
| gary_poster | Makyo, we have demo requirements, that's it. Your touch improvements might be all we need | 17:14 |
| abentley | rick_h_: Yes, it's the original Asus Transformer, a TF101. | 17:14 |
| Makyo | gary_poster, alright, will merge it with trunk and keep it on hand,then. | 17:14 |
| Makyo | gary_poster, !!! Will merge trunk with it, sorry :S | 17:15 |
| gary_poster | cool Makyo thanks. :-) | 17:15 |
| rick_h_ | abentley: does it run chrome for android? might work for a test case | 17:15 |
| abentley | rick_h_: Yes, it does. | 17:15 |
| rick_h_ | gary_poster: ^ so that might work since N10 comes with chrome ootb anyway. Just be a performance diff | 17:15 |
| goodspud | FYI, we were able to do some user testing of the "prototype" over the weekend at the SCALE conference (I don't actually know what that is). We get the feedback from our researcher on Monday. | 17:16 |
| gary_poster | rick_h_, cool, thanks. | 17:16 |
| gary_poster | goodspud, sounds great. Look forward to hearing | 17:16 |
| bac_ | hey benji have you run tests for juju-core lately? i'm seeing 9 failures in trunk. | 17:43 |
| benji | bac_: I have a couple of failures on my branch, but they are about openstack things that I probably don't have the right environment for testing anyway | 17:43 |
| benji | I haven't updated my branch since yesterday though, so that might be part of it | 17:44 |
| bac_ | benji: i'm getting these (from 'go test ' |grep FAIL) http://paste.ubuntu.com/5571126/ | 17:45 |
| benji | bac_: nope, I haven't seen that. I can get a fresh trunk and try it, if that would help. | 17:45 |
| bac_ | benji: if it isn't too much trouble | 17:46 |
| benji | sure, one sec | 17:46 |
| hatch | gary_poster, bcsaller - just fyi final push of the app extension code was pushed - I was pretty sure you were both LGTM with changes but just making sure b4 I push | 17:53 |
| hatch | er submit | 17:53 |
| benji | bac_: I get some failures, but they look environmental; as for the tests that fail for you, they pass for me: | 17:54 |
| benji | ok launchpad.net/juju-core/worker/uniter 89.878s | 17:54 |
| bac_ | ok | 17:54 |
| bac_ | thanks! | 17:54 |
| === bac_ is now known as bac | ||
| hatch | lunch & | 18:07 |
| hatch | I think we have a layout bug on trunk...when running I need to scroll up/down to see the whole app - it's a little bit more than the height of the footer too tall | 19:00 |
| hatch | I dont' see a min-height anywhere but I might be missing something obvious | 19:01 |
| gary_poster | hatch, there is a min height and width. | 19:01 |
| gary_poster | http://uistage.jujucharms.com:8080/ looks ok to me | 19:01 |
| gary_poster | height and width is controlled in environment IIRC | 19:02 |
| hatch | ahh it's not hardcoded into the css | 19:02 |
| hatch | gotcha | 19:02 |
| bcsaller | sort of, the env is scaled on viewport size change | 19:02 |
| * hatch goes back to work :) | 19:02 | |
| bac | benji: have you seen this: http://labix.org/cobzr -- the How It Works section you may find interesting | 19:31 |
| benji | bac: heh, I had not | 19:32 |
| bac | benji: if you wanted to do a non-binding review, my 'expose' branch is at https://codereview.appspot.com/7369058/ | 19:45 |
| bac | i figure it is good for us to start doing reviews to gain exposure. you agree? | 19:46 |
| benji | sounds good, I'll take a look | 19:46 |
| bac | i did one today prefaced with "i'm not a juju-core reviewer, but..." | 19:46 |
| gary_poster | ...I play one on the interwebs | 19:46 |
| benji | I'll start mine with "I don't always review juju-core code, but when I do...". | 19:47 |
| bac | benji: i'm particularly interested in feedback on the issue with api_test.go we discussed, regarding the silly second test. | 19:47 |
| gary_poster | heh | 19:47 |
| benji | k | 19:47 |
| hatch | wrt conflicts with bzr - is the workflow to head into the conflicted file, fix the merge, commit, and done? | 20:09 |
| hatch | same as git? | 20:09 |
| rick_h_ | gary_poster: N10 acquired | 20:10 |
| gary_poster | rick_h_, woohoo! | 20:10 |
| hatch | lucky! | 20:10 |
| rick_h_ | local walmart had it in stock, now I need a shower | 20:10 |
| hatch | clearly the play.google.ca UPS sled dogs are slow at this time of year | 20:10 |
| hatch | :) | 20:10 |
| rick_h_ | hah | 20:10 |
| hatch | lol @ need a shower | 20:11 |
| hatch | have some new additons to `people of walmart` ? | 20:11 |
| Makyo | According to this recruiter email (grrr Monster), I have the right mix of skills to be an "Independent Insurance Sales Agent." I guess that's a valid backup career... :P | 20:12 |
| hatch | Makyo, are those skills "sentient being" ? | 20:13 |
| hatch | ;) | 20:13 |
| Makyo | hatch, I'm assuming so :) | 20:14 |
| hatch | haha | 20:15 |
| hatch | hmm bzr is saying i have conflicts but those files don't have any of the <<<<< | 20:16 |
| Makyo | hatch, are there .THIS and .OTHER files? | 20:16 |
| hatch | negative | 20:16 |
| Makyo | hatch, sorry, <conflictedFile>.THIS | 20:16 |
| hatch | still no - this came after lbox submit | 20:17 |
| hatch | so maybe they are in another branch | 20:17 |
| Makyo | Oh, huh. | 20:17 |
| hatch | are they usually in a separate branch? | 20:18 |
| hatch | I don't see an lbox folder anywhere | 20:18 |
| hatch | and find doesn't find any THIS or OTHER files | 20:18 |
| hatch | first bzr conflict :) | 20:19 |
| rick_h_ | hmm, so if it's in the lbox submit part then someone submitted something that lbox is breaking when trying to update to trunk | 20:20 |
| rick_h_ | go back to your branch and do a fresh pull with trunk to see what's up | 20:20 |
| hatch | ok doing a pull on trunk | 20:20 |
| bac | hatch: lbox submit creates a new branch in the parent directory and then erases it when done (though i would've thought it would keep it on error) | 20:21 |
| hatch | yeah that's what I thought although the branch doesn't stick around | 20:21 |
| hatch | so....what's the workflow for this ;) | 20:22 |
| gary_poster | bzr merge lp:juju-gui | 20:22 |
| gary_poster | manually resolve any conflicts | 20:22 |
| gary_poster | bzr resolved [FILES THAT YOU RESOLVED] | 20:22 |
| gary_poster | bzr commit -m 'merge with trunk' | 20:23 |
| gary_poster | or similar | 20:23 |
| hatch | ok so then my branch will have trunk in it | 20:23 |
| * bac hearts smerge.el | 20:23 | |
| gary_poster | y | 20:23 |
| hatch | and then the proper way to push that to trunk? | 20:24 |
| hatch | merge mybranch into trunk and push? | 20:24 |
| gary_poster | lbox submit should work AFAIK | 20:24 |
| hatch | ahh ok | 20:24 |
| hatch | great lemme give that a go | 20:24 |
| benji | bac: I finished my non-review of your branch. | 20:24 |
| bac | benji: cool | 20:24 |
| hatch | running tests and builds on this laptop kills the battery heh | 20:34 |
| hatch | guess it isn't a huge fan of 100% CPU | 20:34 |
| hatch | :) | 20:34 |
| gary_poster | Makyo, out of curiosity was Nick happy with the design aspect of the bottom link work you are doing? | 20:34 |
| gary_poster | :-) | 20:34 |
| gary_poster | I wonder what it is about me that prefers noses for my smileys... | 20:35 |
| hatch | they are more personal | 20:35 |
| gary_poster | ...my older son might tell me it is because my own is rather large... | 20:35 |
| gary_poster | personal noses? | 20:35 |
| gary_poster | :-) | 20:35 |
| hatch | yeah look at that thing....it just says so much about that emoticons life | 20:36 |
| Makyo | gary_poster, happy with the bottom links, unhappy with the other controls on the bottom of the service view. Expose and destroy were to be moved up to the top bar. He just got me assets this morning, though, so that's going in this branch to pass UX check. | 20:36 |
| Makyo | And for what it's worth, I used to use :o) (and still do sometimes), until I got asked if it was a clown. Confidence: shattered. | 20:36 |
| gary_poster | lol | 20:36 |
| hatch | haha now I can't unsee that as a clown | 20:37 |
| hatch | damn | 20:37 |
| gary_poster | cool about Nick, thanks Makyo | 20:37 |
| Makyo | RIGHT? I will never not be a clown :( | 20:37 |
| gary_poster | LOL | 20:37 |
| hatch | hahaha | 20:38 |
| hatch | poor you | 20:38 |
| hatch | :'o( sad clown | 20:38 |
| Makyo | Sometimes the nose just adds too much width. | 20:38 |
| Makyo | Like the Charlie Brown face :S That 'S' is too wide already. | 20:39 |
| Makyo | The Design and Aesthetics of Emoticons, by Jujugui | 20:39 |
| hatch | amazon best seller right there! | 20:40 |
| benji | there's always \u1F443 (http://www.fileformat.info/info/unicode/char/1f443/browsertest.htm) | 20:41 |
| gary_poster | :-) | 20:43 |
| Makyo | Me, I'm a fan of http://www.fileformat.info/info/unicode/char/1f63c/index.htm | 20:43 |
| hatch | hmm it looks like the merge chose the trunk over some of the changes in app.js | 20:54 |
| hatch | does that happen often? | 20:54 |
| hatch | oooooor | 20:57 |
| hatch | I screwed something up.....the more likely case | 20:57 |
| hatch | :) | 20:57 |
| hatch | bcsaller, gary_poster when you guys have a moment could you please check out the updated app extension branch https://codereview.appspot.com/7381055 | 21:23 |
| hatch | I somehow missed the code which called the callbacks in the proper context | 21:23 |
| hatch | :/ | 21:23 |
| gary_poster | hatch, whassup? That one is submitted? ok looking for diff from submission... | 21:24 |
| hatch | Set 11 on that link | 21:24 |
| gary_poster | right | 21:24 |
| hatch | it was missed because technically it's the router code - my bad | 21:25 |
| gary_poster | hatch, charmbrowser was originally supposed to be default url namespace--the name doesn't matter but the idea was that existing charm browser urls, like http://jujucharms.com/~juju-gui/precise/juju-gui, would still resolve correctly in the charm browser sub app. It looks like you assume that root is *not* a subapp | 21:26 |
| bcsaller | hatch: you should do this as another branch if the other is submitted already. Also this code isn't correct, router has a .defaultNamespace which isn't 'root' as you suggest. Additionally the callback is triggered with .call below and is passed self. This could be a var which is the subapp or self depending on where we found the callback | 21:27 |
| gary_poster | not only would existing urls resolve correctly, but the urls for the charm browser would be attractive when you started in the full charm browser experience | 21:28 |
| hatch | hmm, can we chat about this? | 21:29 |
| gary_poster | bcsaller, I think he changed the defaultNamespace by changing the instantiaton of the router, yeah? | 21:29 |
| gary_poster | hatch, who, me? :-) | 21:29 |
| hatch | you and bcsaller :) | 21:29 |
| hatch | because I must have totally misunderstood something | 21:29 |
| gary_poster | ok | 21:29 |
| gary_poster | to the juju gui cave | 21:30 |
| gary_poster | kinda like bat cave, y'know | 21:30 |
| bcsaller | gary_poster: he did which is an issue, but you wouldn't encode that string both places, you'd still use the attr assigned when you init the object if that type of check was what you wanted | 21:30 |
| gary_poster | bcsaller, ah gotcha | 21:30 |
| hatch | bcsaller, are you coming? | 21:31 |
| hatch | into the call? | 21:31 |
| bcsaller | hatch: var callingContext = subapp[callback] ? subapp : self; callback.call(callingContext, ...) | 21:32 |
| gary_poster | var callingContext = subApp && subApp[callback] ? subApp : self | 21:58 |
| hatch | bcsaller, just before I commit this i want to make sure I'm on the same page again :) https://gist.github.com/hatched/d2ea9b39964c477b924e | 22:27 |
| bcsaller | hatch: yes and then passing callingContext as callback.call(callingContext, ...) | 22:29 |
| hatch | yeah sorry - didn't include that part in the paste | 22:29 |
| hatch | ok perfect, and it appears to work properly | 22:29 |
| hatch | :P | 22:29 |
| hatch | sorry about that - I didn't really understand the direction we were going with that stuff | 22:29 |
| bcsaller | hatch: no prob :) | 22:31 |
| Makyo | Dogwalkination. | 22:33 |
| hatch | enjoy! | 22:33 |
| hatch | hmm almost forgot tests! | 22:35 |
| hatch | although..... it looks like the current tests might cover this change | 22:35 |
| hatch | nope | 22:36 |
| hatch | need one more | 22:36 |
| gary_poster | hm, att uverse router appears to be dying | 23:39 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!