| === arosales is now known as arosales-afk | ||
| === gary_pos` is now known as gary_poster | ||
| === benji___ is now known as benji | ||
| gary_poster | oops | 14:02 |
|---|---|---|
| hatch | morning | 14:21 |
| hatch | bcsaller_, in my subapp scaffold I'm running into an issue where the 'namespace' property is being stripped from the route object | 14:22 |
| bcsaller_ | hatch: looks like someone merged out the changes to App.route that fixed that, let me see if I can verify this | 14:23 |
| hatch | yeah thats what I thought last night but I was running out of steam so I called it quits :) | 14:24 |
| bcsaller_ | hatch: wait, I gave you that patch, no? I thought it was going to be in your branch as mine had already landed | 14:28 |
| bcsaller_ | maybe you didn't port it from the prototype? | 14:28 |
| hatch | it was in the `match` method right? | 14:29 |
| bcsaller_ | no, route | 14:29 |
| bcsaller_ | match is in trunk | 14:29 |
| hatch | ok comparing | 14:29 |
| hatch | ahh that's what it was thanks | 14:30 |
| hatch | next time I'm definitely doing things differently :) | 14:30 |
| hatch | hoooooly linter does not like the 'lined up' spacing you did you the properties | 14:43 |
| hatch | :P | 14:43 |
| === jovan2_ is now known as jovan2 | ||
| hatch | bcsaller_, when you get a second could you review https://codereview.appspot.com/7430043/ plz thx | 14:54 |
| frankban | hi benji: were you able to deploy charms in a precise env using lxc? | 15:13 |
| benji | frankban: I haven't tried using lxc. | 15:14 |
| frankban | benji: you used any other workaround? | 15:16 |
| therve | frankban, I am | 15:16 |
| frankban | therve: with gojuju? | 15:16 |
| therve | frankban, ah, not that one no :) | 15:17 |
| frankban | therve: :-) | 15:17 |
| benji | frankban: I'm afraid I don't understand the question. Workaround for what? | 15:19 |
| frankban | benji: for creating a juju-core precise environment, workarounf for bug 1131608 | 15:20 |
| _mup_ | Bug #1131608: deployed series is arbitrary <juju-core:New for fwereade> < https://launchpad.net/bugs/1131608 > | 15:20 |
| benji | frankban: oh, my "workaround" was to install the version of the OS juju-core wanted. :\ | 15:20 |
| frankban | benji: ack :-/ | 15:21 |
| gary_poster | jujugui call in 2 | 15:28 |
| bac | frankban, teknico: could one of you grab lp:~bac/juju-core/api-expose and run the tests? | 15:41 |
| bac | go test launchpad.net/juju-core/... | 15:41 |
| teknico | bac, I'll do it | 15:42 |
| bac | thanks! | 15:42 |
| bac | maybe |tee test.out so you can paste it | 15:42 |
| bac | hatch: was my audio quality any better after i changed headsets? | 15:46 |
| hatch | I still had to turn you up to match the others | 15:46 |
| hatch | but that was just a preference | 15:47 |
| hatch | you were still easy enough to hear | 15:47 |
| gary_poster | bac I endorse hatch's statements :-) | 15:48 |
| hatch | :-) | 15:51 |
| hatch | bcsaller_, would you prefer console.error() or throw for the warning? | 15:51 |
| hatch | what's the convention used elsewhere in the app? | 15:51 |
| teknico | bac, shortly: you were too soft :-) | 15:52 |
| bac | so i can be too quiet on my phone, or garbly vis DSL. | 15:54 |
| bac | luckily next week we should get wimax installed and ditch dsl. | 15:55 |
| gary_poster | cool | 15:55 |
| bcsaller_ | hatch: we'd already get an exception when the callback.call happened, I think an error with more information about the route and the callback name make sense | 15:55 |
| gary_poster | too quiet on phone is vastly better than garbled on DSL, bac, fwiw | 15:55 |
| hatch | bac I endorse gary_poster's staements :-) | 15:57 |
| hatch | statements even | 15:57 |
| gary_poster | :-) | 15:57 |
| hatch | bcsaller_, agreed | 15:57 |
| bac | yay we reached concensus on my crappy connectivity | 15:58 |
| gary_poster | lol | 15:58 |
| hatch | haha - you might want to call someone about that | 15:58 |
| hatch | see if you can get some free dialup | 15:59 |
| hatch | :P | 15:59 |
| gary_poster | hatch gave you review of https://codereview.appspot.com/7429044/ . LGTM with trivial | 16:01 |
| hatch | thanks | 16:02 |
| hatch | much appreciate | 16:02 |
| hatch | d | 16:04 |
| teknico | bac, here's the test output: http://pastebin.ubuntu.com/5573695/ | 16:05 |
| bac | teknico: cool. so at least my branch isn't breaking things. i get all kinds of worker/uniter failures | 16:06 |
| bac | maybe i'll blow that package away and try again | 16:06 |
| bac | teknico: thanks for taking the time to run those. | 16:10 |
| teknico | bac, yw | 16:11 |
| hatch | bcsaller_, have a second to respond to gary's comments on https://codereview.appspot.com/7429044 plz :-) | 16:13 |
| benji | bac: if you start a "Potential Improvements" list, I have a candidate or two for inclusion. | 16:18 |
| bac | benji: why don't you do that while i go down the street to fatty's for some fried chicken? | 16:18 |
| bac | and plantains | 16:18 |
| benji | I think I am getting the short end of the stick in this deal. :) | 16:19 |
| hatch | iunno | 16:19 |
| hatch | bac might die of a heart attack | 16:19 |
| hatch | from all that fried chicken | 16:20 |
| hatch | in which case you would be getting the good end | 16:20 |
| hatch | lets see how this plays out first | 16:20 |
| hatch | :P | 16:20 |
| bac | no, it's ok. i ride my bicycle, so it cancels out | 16:20 |
| hatch | ohhh well then....carry on! | 16:22 |
| bac | and i only allow myself to go once a week | 16:22 |
| hatch | bring me back some popcorn chicken | 16:22 |
| hatch | :P | 16:22 |
| benji | gary_poster: is there a new wiki home for yellow (i.e., on wiki.canonical.com instead of dev.launchpad.net)? | 16:23 |
| gary_poster | benji, no. interesting question. is it for public info or private? | 16:23 |
| gary_poster | we could put something on ubuntu wiki too maybe? I think there is one. if it is public | 16:23 |
| benji | is our "Potential Improvements" list public or private? | 16:24 |
| gary_poster | benji if we say it nicely it can be public :-) | 16:25 |
| benji | darn | 16:25 |
| benji | ;P | 16:25 |
| gary_poster | :-0 | 16:25 |
| gary_poster | :-) | 16:25 |
| benji | so... ubuntu wiki then? | 16:26 |
| gary_poster | I intended the smiley rather than the "gary opens his moth to reveal a single tooth" | 16:26 |
| gary_poster | mouth | 16:26 |
| benji | I figured you were so happy with your dental work that you were showing it off. | 16:26 |
| gary_poster | heh | 16:26 |
| hatch | haha | 16:26 |
| hatch | couple of my buddies are dentists.....oh the stories | 16:27 |
| gary_poster | benji trying to figure out where it might go...https://wiki.ubuntu.com/Teams but looks official-y | 16:27 |
| * benji invisions a Dali painting with a moth spreading his wings and his thorax is instead a single bicuspid. | 16:27 | |
| gary_poster | disturbing, really | 16:28 |
| hatch | rofl | 16:28 |
| benji | the melting clocks will make it all ok | 16:28 |
| hatch | ^5 benji | 16:28 |
| gary_poster | oh ok, good | 16:28 |
| benji | yeah, https://wiki.ubuntu.com/BuildingCommunity/CreatingTeamGuide makes it sound like "Teams" are more focused on a single topic. We could break that mold, but I'm not sure it would be for the best. | 16:32 |
| benji | ^5 hatch (I didn't want to leave you hanging) | 16:32 |
| hatch | oh thanks | 16:33 |
| hatch | my arm was getting tired | 16:33 |
| gary_poster | benji https://wiki.canonical.com/CDO/CloudEngineering/Yellow | 16:33 |
| gary_poster | have at it and move on :-) | 16:33 |
| benji | cool, thanks | 16:34 |
| benji | I wondered why I hadn't seen that before and then I looked at the page history and saw that you just created it. | 16:34 |
| gary_poster | yes :-) | 16:35 |
| benji | bac: https://wiki.canonical.com/CDO/CloudEngineering/Yellow/PotentialJujuCoreImprovement | 16:55 |
| benji | bac: oops, wrong URL: https://wiki.canonical.com/CDO/CloudEngineering/Yellow/PotentialJujuCoreImprovements | 17:04 |
| gary_poster | hatch, bcsaller, if I read bcsaller's reply correctly (https://codereview.appspot.com/7429044/diff/1/app/app.js#newcode1083) I'm +1 on the switch to Y.Array that I mentioned, and removing the back-compat callback attr | 17:04 |
| gary_poster | hatch, so if you address my three comments then pleae land away | 17:04 |
| gary_poster | please | 17:04 |
| gary_poster | rogpeppe do you have a moment for a quick status update on the megawatcher in https://plus.google.com/hangouts/_/7fb7c30f3a232db57dd8549738fb98e723d90d4a ? | 17:06 |
| hatch | alright I'll take a look - sorry just trying to understand the less workflow | 17:06 |
| gary_poster | cool hatch. for less, just edit, and use make devel. less changes will automatically update so you can just reload | 17:07 |
| rogpeppe | gary_poster: i'm there :-) | 17:07 |
| hatch | gary_poster, ahh ok - almost done that ticket | 17:08 |
| hatch | when the designers say 'pt' do they mean 'px' ? | 17:11 |
| bac | thanks benji | 17:12 |
| hatch | I ask because 14pt is a massive header text where 14px looks good | 17:13 |
| hatch | but they also use px | 17:14 |
| gary_poster | hatch ask goodspud | 17:15 |
| hatch | oh ok - I didn't know that they were in here :D | 17:15 |
| gary_poster | we have 45 more minutes of goodspud goodness | 17:15 |
| goodspud | hatch, we are always watching | 17:15 |
| goodspud | ... unless we aren't | 17:15 |
| hatch | uh oh! | 17:15 |
| hatch | haha | 17:15 |
| gary_poster | :-) | 17:15 |
| hatch | so https://bugs.launchpad.net/juju-gui/+bug/1125424 | 17:16 |
| _mup_ | Bug #1125424: Tweaks to loading messages and login visuals <juju-gui:Triaged by hatch> < https://launchpad.net/bugs/1125424 > | 17:16 |
| hatch | you will see that someone said 14pt but that makes that header text huge! requiring the warning box to actually increase in width | 17:16 |
| goodspud | hatch, just chatting with Greg (designer) | 17:16 |
| hatch | okee | 17:17 |
| hatch | Ubuntu Medium at 14pt also looks blurry but that could just be my monitor | 17:17 |
| goodspud | hatch, could you send me a screen shot at 14pt and 14 pixels? | 17:20 |
| hatch | umm | 17:21 |
| hatch | yes I just need to find a good screenshot tool :) | 17:21 |
| hatch | I'm used to working on my mac which has Skitch | 17:21 |
| hatch | heh | 17:21 |
| goodspud | You can just do C<D | 17:21 |
| goodspud | doh! | 17:21 |
| gary_poster | hatch printscreen pops something up | 17:21 |
| goodspud | hatch, yeah, printscreen should work or (on a mac) CMD+shift+4 | 17:22 |
| gary_poster | hatch, otherwise gnome-screenshot | 17:22 |
| hatch | yeah printscreen will work for this case - I just like skitch's crosshairs so you can select a section of the page and then add text to it | 17:23 |
| hatch | I'll look into gnome-screenshot afterwards thx | 17:23 |
| hatch | goodspud, can you pm me your email plz | 17:24 |
| hatch | ok sent | 17:26 |
| hatch | I THINK 12pt = 16px | 17:27 |
| bac | benji did you notice the 'roommate' column has been removed from the sprint wiki? | 17:30 |
| benji | bac: I didn't. I guess that means that either we each get a room or we will all be sleeping on the floor of the conference room. | 17:30 |
| gary_poster | the latter | 17:31 |
| hatch | yay sleepover! | 17:31 |
| gary_poster | benji is responsible for the sleeping bags | 17:31 |
| gary_poster | hatch brings the tents | 17:31 |
| * benji packs his footy pajamas | 17:31 | |
| gary_poster | lol | 17:31 |
| hatch | haha - my tent has a solar panel on the root with built in led lighting | 17:31 |
| hatch | yeah...I'm THAT guy at the camp site | 17:31 |
| hatch | roof* | 17:31 |
| gary_poster | I definitely chose the right guy then | 17:31 |
| benji | is it also bigger on the inside than on the outside? | 17:32 |
| gary_poster | :-) | 17:32 |
| hatch | haha | 17:32 |
| bac | i see on google maps our hotel is right close to "Cabbagetown". can't wait to find out what that is all about. | 17:36 |
| * bac practices for georgia by using phrases like "right close" again. | 17:37 | |
| hatch | lol | 17:39 |
| benji | bac, since I will have a car I can "carry you" places | 17:40 |
| hatch | benji, do you live close to atlanta? | 17:45 |
| benji | yep, middle Tennessee (about a 3.5 hour drive) | 17:46 |
| hatch | ahh cool - I have about an 8h travel time by flight heh | 17:46 |
| benji | therefore I will be fully versed in the local vernacular | 17:46 |
| hatch | Ooo - I'm hoping there is a good seafood restaurant near by | 17:48 |
| hatch | I'm pretty landlocked so I don't get much in the way of fresh seafood :) | 17:49 |
| hatch | well....salt water seafood | 17:49 |
| benji | hatch: bac had proposed a trip to a seafood place, but I don't remember if it was fresh water (catfish, etc.) or salt water | 17:53 |
| bac | more mud based | 17:53 |
| bac | crawfish shack | 17:53 |
| hatch | oooo I'll go@ | 17:53 |
| hatch | ! | 17:53 |
| bac | i saw a reference to it on anthony bourdain's new show. i added a link to the wiki. please don't listen when he talks about the unsavory parts of atlanta. | 17:54 |
| hatch | ehh every city has unsavory parts | 17:56 |
| hatch | bac, I don't see the link | 17:58 |
| hatch | which wiki? :) | 17:58 |
| bac | hatch: the one where i forgot to press 'save'. it is there now. https://wiki.canonical.com/CDO/Sprints/JujuEcosystemSprintMarch13 | 17:59 |
| hatch | :D | 17:59 |
| hatch | looks like it's also lunch time so I'll watch the vid now :) | 18:01 |
| Makyo | Ugh, tried reproposing with -for, still wants to merge into the wrong branch. | 18:14 |
| Makyo | One more try... | 18:25 |
| bac | benji: ping | 18:33 |
| Makyo | Fixed, sorry if that leads to extra emails. | 18:34 |
| benji | bac: what's up? | 18:35 |
| benji | (I'm lunching) | 18:36 |
| bac | benji: not much, just trying to figure out how the 'deny' mechanism works. ping me when you're back. | 18:36 |
| benji | k; it'll be about 20 minutes | 18:36 |
| bac | benji: ok | 18:42 |
| === deryck is now known as deryck[lunch] | ||
| hatch | bac, oh that guy is quite the character haha (just finished watching the video) | 18:53 |
| benji | bac: I'm looking at the deny bits now. | 19:01 |
| hatch | *sigh* I long for chrome dev tools in FF | 19:08 |
| hatch | the log out panel is wrapped in an unnamed div which is causing it's position to be incorrectly calculated - can someone point me to where this panel is created? | 19:12 |
| gary_poster | hatch, maybe index.html? not quite sure what you mean by panel in context | 19:12 |
| hatch | ok when you go and click 'log out' a panel is shown | 19:13 |
| hatch | or the 'log in' panel I suppose | 19:13 |
| gary_poster | oh, to enter your password hatch? | 19:13 |
| gary_poster | that's on index.html | 19:13 |
| gary_poster | pretty sure | 19:13 |
| benji | bac: I think I have figured out the allow/deny bits (those in state/api/api_test.go at least) | 19:15 |
| bac | benji: you want to chat? | 19:16 |
| benji | I also think there is a bug or at least a mis-design in that functionality. There is nothing guarding against someone having both allow and deny set for a test, if so only the deny will be tested and the allow will be ignored | 19:16 |
| hatch | gary_poster, no such luck - it's in the handlebars rollup I'm just not sure where those are stored | 19:16 |
| benji | sure; how about the regular hangout if no one is in there | 19:16 |
| hatch | I can find them though :) | 19:16 |
| bac | benji: i think the opposite. note the early return in the allow part | 19:16 |
| gary_poster | hatch, oh! app/templates/login.handlebars ? | 19:17 |
| benji | bac: yep, you're right | 19:17 |
| benji | the regulr place is free | 19:17 |
| hatch | oh son of a.....sublime didn't show that folder (`watch` issue again) | 19:17 |
| hatch | thanks | 19:18 |
| hatch | :D | 19:18 |
| gary_poster | :-) np | 19:18 |
| hatch | ok branch is done and proposed - so I have three screenshots, should I add them to the bug? Or is there another preferred place for them? | 19:31 |
| hatch | ^ gary_poster | 19:32 |
| gary_poster | bug is fine, and then give links to designers | 19:32 |
| hatch | goodspud_, you shouldn't have come back...I just pushed the changes ;) | 19:32 |
| goodspud_ | :) | 19:32 |
| goodspud_ | I'm sure it's all perfect | 19:33 |
| gary_poster | hatch, https://codereview.appspot.com/7429044/ just needs a few tweaks then you can land it | 19:34 |
| gary_poster | if it's not clear what they are we can have quick call | 19:34 |
| hatch | goodspud_, hah! https://bugs.launchpad.net/juju-gui/+bug/1125424 in the right column at the bottom are the three screen shots | 19:35 |
| _mup_ | Bug #1125424: Tweaks to loading messages and login visuals <juju-gui:In Progress by hatch> < https://launchpad.net/bugs/1125424 > | 19:35 |
| hatch | gary_poster, sure thing let me check that out | 19:35 |
| goodspud_ | hatch: looks good. | 19:37 |
| hatch | great - so do you comment on https://codereview.appspot.com/7452043/ ? | 19:37 |
| goodspud_ | hatch. done | 19:39 |
| hatch | awesome | 19:39 |
| goodspud_ | Time for my dinner. Catch you all tomorrow | 19:39 |
| hatch | so does this workflow work pretty good for you? | 19:39 |
| hatch | okee :) cya | 19:39 |
| hatch | enjoy dinner | 19:39 |
| goodspud_ | hatch, yes | 19:39 |
| benji | bac: I am 90% sure that maps in go are magic, and that is why you can assign the results of a map lookup to either one or two variables | 19:43 |
| hatch | gary_poster, so just to clarify that I understand the comments on 7429044 - we will remove the backwards compatibility because multiple callbacks can't be supported anyways - and - a result of that we no longer need to flatten so we can simply create an array of routes | 19:45 |
| hatch | bcsaller_, the callbacks 'backwards compatibility' section on the namespace branch - is that required? I don't think you commented on that directly | 19:58 |
| bcsaller_ | hatch: I was trying to say that I think our codebase has been cleared of any references but I don't know if YUI depends on it anywhere | 19:59 |
| bcsaller_ | I suspect removing it the tests will all still pass, but we don't test dispatch very well so I just left it in there | 20:00 |
| hatch | oh ok sorry I misunderstood - I'll make a note and leave it in - I was reading the YUI tests of router last night and I think once I split this stuff out into an extension then we will be able to properly test this stuff | 20:01 |
| === deryck[lunch] is now known as deryck | ||
| benji | Granted, it's early going, but I'm not real keen on go's decision that getters should just be the name of the thing being retrieved. | 20:20 |
| hatch | I'm not sure I follow | 20:22 |
| hatch | need one more review on some css https://codereview.appspot.com/7452043/ | 20:22 |
| benji | if a method returns a value (say a unit's status) then instead of being named something like "GetStatus" it is simply named "Status" | 20:24 |
| benji | Asymmetrically, setters are still named like "SetStatus". | 20:24 |
| benji | At least they don't use the idiom I've seen in some JS of having a method named "status" that if called with a value is a setter and if called without one is a getter. I had to lie down for a little while after I saw that for the first time. | 20:25 |
| gary_poster | hatch sorry was on call. reading | 20:26 |
| hatch | ugh I hate inconsistent api's | 20:26 |
| hatch | gary_poster, ben already answered my q's and it's been submitted :) | 20:26 |
| gary_poster | great hatch, thanks. | 20:26 |
| hatch | benji, I spent a while in PHP - if you want inconsistent api's....that's your language | 20:27 |
| hatch | foo_bar or fooBar ? needle, haystack or haystack, needle? | 20:27 |
| hatch | lol | 20:27 |
| benji | yep, PHP takes the cake | 20:27 |
| hatch | gary_poster, I just need one more to sign off on my less changes then that ticket can also go away | 20:29 |
| gary_poster | ok hatch looking | 20:31 |
| hatch | hmm it looks like the rail from the airport to the hotel isn't that bad | 20:33 |
| hatch | anyone else planning to take the rail? | 20:33 |
| gary_poster | hatch, if you mean MARTA, yes | 20:34 |
| gary_poster | haven't looked at it het | 20:34 |
| gary_poster | yet | 20:34 |
| gary_poster | hatch approved your branch | 20:34 |
| gary_poster | you need another code review though | 20:34 |
| gary_poster | 2 code + 1 design if UX is involved | 20:34 |
| hatch | gary_poster, http://goo.gl/maps/yWAay it looks pretty straight forward | 20:34 |
| hatch | ohh ok | 20:35 |
| gary_poster | hatch, cool, no changes | 20:35 |
| hatch | nope just hop on at the airport and then a block walk | 20:36 |
| hatch | I don't even think a city bus goes to our airport lol | 20:36 |
| benji | interesting, there is no NotEquals checker in launchpad.net/gocheck | 20:46 |
| rogpeppe | benji: Not(Equals) | 20:54 |
| rogpeppe | benji: and there's NotNil as well, which is (interestingly) slightly different | 20:54 |
| benji | rogpeppe: heh, I was just looking for a negation operator in there, thanks! | 20:54 |
| benji | yeah, the existence of NotNill threw me off initially | 20:55 |
| rogpeppe | benji: nil is a little special when you're dealing with interfaces. | 20:55 |
| rogpeppe | benji: because interface{}((sometype*)(nil)) != nil | 20:56 |
| benji | If I understood that sequence of symbols I'm sure I would now be enlightened. ;) | 20:56 |
| rogpeppe | benji: the left hand expression is just a sequence of type conversions | 20:56 |
| hatch | gary_poster, so are you alright with be getting back on that scaffold? | 20:57 |
| rogpeppe | benji: nil converted to *sometype (oops, got that wrong) converted to interface{} | 20:57 |
| benji | ah, so casting nil to a pointer to any interface is not nil? | 20:57 |
| rogpeppe | benji: in general typeExpression(foo) converts foo to the given type (assuming it's assignment compatible) | 20:57 |
| rogpeppe | benji: an interface value is not nil if the underlying value has any concrete type | 20:58 |
| rogpeppe | benji: this might be of some help: http://play.golang.org/p/r2DfTUbasP | 21:05 |
| gary_poster | hatch, +1 | 21:06 |
| hatch | this may be a case of looking in the wrong place - but do we not 'render' the app anywhere? | 21:08 |
| bcsaller_ | index calls it once | 21:12 |
| bcsaller_ | use to anyway | 21:14 |
| hatch | :) | 21:15 |
| hatch | yeah I'm baffled | 21:19 |
| hatch | bcsaller_, I'm pretty confident that it isn't being called | 21:24 |
| hatch | when you render an app yui3-app class gets added to the container | 21:25 |
| hatch | I guess it doesn't really matter - would be a good point of investigation though | 21:28 |
| hatch | gary_poster, bcsaller_ do we want to render all subapps on registration? | 21:40 |
| gary_poster | on call will think later | 21:41 |
| hatch | issue I'm running into is that the namespace is calling methods on the subapps but they aren't rendered | 21:41 |
| hatch | deal | 21:41 |
| bcsaller_ | hatch: I suspect not, though a callback or event when registered would allow that | 21:42 |
| hatch | yeah I wasn't thinking so either | 21:42 |
| hatch | so will need to lazy-render these subapps | 21:42 |
| hatch | **will this never end!!!!** | 21:43 |
| hatch | heh | 21:43 |
| hatch | awesome that works | 21:53 |
| Makyo | Got go env sorta set up, but test complains there are no Go source files in $GOPATH/src/launchpad.net/juju-core Did I miss a step? | 21:55 |
| Makyo | guihelp ^^^ (not sure who to ping specifically) | 21:56 |
| hatch | could I get a quick less review on https://codereview.appspot.com/7452043/ thx | 21:56 |
| hazmat | Makyo, i'd blow away and refetch assuming its not a branch | 21:56 |
| hazmat | just the juju-core dir | 21:56 |
| hazmat | and use -v on go get | 21:56 |
| Makyo | hazmat, Alright. | 21:57 |
| Makyo | hazmat, no luck :/ can't load package: package launchpad.net/juju-core: no Go source files in /home/makyo/work/juju-core/src/launchpad.net/juju-core | 22:00 |
| hazmat | hmm | 22:01 |
| hazmat | Makyo, what command are you running to test? | 22:02 |
| Makyo | go test -gocheck.v | 22:02 |
| Makyo | I've also tried specifying go test -gocheck.v launchpad.net/juju-core/... | 22:02 |
| hazmat | Makyo, the later should work though the flag needs to come last i'm told | 22:03 |
| hazmat | Makyo, does go test launchpad.net/juju-core/... work? | 22:03 |
| hazmat | there aren't any source files directly in the juju-core directory which leads to that message.. tests need to be run in a dir with go source files.. or spec'd as top level recurse | 22:06 |
| bac | Makyo: best i can tell, -gocheck.v is not recursive | 22:06 |
| bac | so you can do 'go test launchpad.net/juju-core/...' from anywhere as long as GOPATH is correct | 22:07 |
| Makyo | URK. | 22:07 |
| bac | or you can cd into a specific directory and do 'go test -gocheck.v[v]' and only get those tests | 22:07 |
| Makyo | Works quite well, thanks hazmat. | 22:07 |
| Makyo | Blows up my computer pretty well. | 22:07 |
| hazmat | cool | 22:07 |
| hazmat | testing is hard work ;-) | 22:07 |
| hazmat | speaking of go build/test issues anyone seen.. pack: cannot open $WORK/labix.org/v2/mgo/_test/_go_.8 i get that on most of the packages | 22:10 |
| hazmat | oh.. dev version of go maybe | 22:11 |
| hazmat | yeah.. that was it mixed a tip and stable versions | 22:12 |
| hatch | oh this is beautiful | 22:24 |
| * Makyo -> dogwalk | 22:24 | |
| hatch | bcsaller_, if you're still around I'd like your input on the lazy rendering code https://codereview.appspot.com/7444046/ | 22:35 |
| gary_poster | hatch I was on call and then catching up on mail before leaving. do you have review you want? | 22:35 |
| hatch | oh umm lemme check sorry I just finished the delay rendering code | 22:36 |
| hatch | I still need one more code review on the css layout changes | 22:36 |
| hatch | and if you would like to weigh in on the lazy render code that would be great | 22:36 |
| gary_poster | k trying | 22:36 |
| gary_poster | hatch I already gave you a review of https://codereview.appspot.com/7452043/. That's the CSS one, right? | 22:39 |
| hatch | yep | 22:39 |
| gary_poster | Maybe ask Makyo to look at it? The coder is responsible for drumming up reviewers :-) | 22:40 |
| gary_poster | hatch, https://codereview.appspot.com/7444046/ LGTM with trivial | 22:43 |
| gary_poster | need to run. night all | 22:43 |
| hatch | thanks, have a good night! | 22:43 |
| gary_poster | you too | 22:43 |
| Makyo | hatch, which branch? | 23:00 |
| Makyo | Lazy render? | 23:00 |
| * Makyo reviews it anyway, already open. | 23:03 | |
| hatch | hey Makyo sorry I stepped away | 23:05 |
| Makyo | No worries :) | 23:05 |
| hatch | umm the css one https://codereview.appspot.com/7452043/ | 23:05 |
| hatch | if you have time :) | 23:05 |
| hatch | well both really | 23:05 |
| hatch | hah | 23:05 |
| hatch | :D | 23:05 |
| Makyo | Hah, alright. On it. | 23:06 |
| hatch | thanks! | 23:07 |
| bac | hazmat: you around? | 23:15 |
| hatch | Makyo, thanks for the reviews | 23:16 |
| bac | hazmat: i'll ask anyway: i am using cobzr, am in the 'master' checkout of juju-core, and see it is on rev 949. i do a 'go get -u -v launchpad.net/juju-core/...' and it does stuff. however, juju-core is still shown to be rev 949. i then do a 'bzr pull lp:juju-core' and it fetches rev 950. what's going on? why didn't 'go get' go get it? | 23:18 |
| Makyo | hatch, re: @ubuntu-font, I just meant a definition at the top of the stylesheet: @ubuntu-font: Ubuntu Medium, Helvetica, Ariel; However, it turns out there already is one, and you can just do font-family: @font-family; | 23:42 |
| Makyo | I know you just submitted, but yeah, future reference thing. | 23:42 |
| Makyo | Sorry, @font-family-medium; | 23:42 |
| hatch | ohh I thought you were referring to an actual font file....oops :) | 23:42 |
| Makyo | No worries. Just a LESS thing. And boy howdy is that file big now. | 23:43 |
| hatch | I actually want to split the less file up into modules at some point | 23:43 |
| hatch | that'll probably be a slack task | 23:43 |
| Makyo | Yeah, for sure. | 23:46 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!