| StevenK | wgrant: Hmmmm, the OOPSes for bug 1135518 make me sad. | 00:57 |
|---|---|---|
| _mup_ | Bug #1135518: +merges times out <branches> <fallout> <privacy> <timeout> <Launchpad itself:Triaged> < https://launchpad.net/bugs/1135518 > | 00:57 |
| wgrant | StevenK: Why? | 01:06 |
| wgrant | There's nothing of particular note. | 01:06 |
| lifeless | presumably that is why | 01:07 |
| StevenK | wgrant: Because I think I caused the breakage, and I can't work out what bit would benefit from preloading from the tracebacks. | 01:07 |
| wgrant | The top three repeated queries in 161287 are visibility/series/stacking preloading | 01:07 |
| wgrant | I don't think it's a regression | 01:07 |
| wgrant | It's just an awful page with a fairly easy fix. | 01:08 |
| wgrant | And the second OOPS is the same | 01:08 |
| wgrant | visibility, series, then stacking | 01:08 |
| wgrant | I don't see any reason to believe that it's a regression | 01:09 |
| wgrant | Person:+merges had a request with >600 queries last week | 01:13 |
| wgrant | So not a regression. | 01:14 |
| StevenK | Excellent | 01:14 |
| StevenK | I'll fix it anyway | 01:14 |
| StevenK | wgrant: I have a failing test for IHasMergeProposals:+merges, and it includes the SELECT 1 FROM () query madness | 04:58 |
| wgrant | StevenK: Right. | 04:59 |
| StevenK | My first attempt didn't | 04:59 |
| wgrant | Oh, why no? | 05:00 |
| wgrant | t | 05:00 |
| StevenK | Probably not enough privacy sprinkled in | 05:01 |
| === almaisan-away is now known as al-maisan | ||
| === al-maisan is now known as almaisan-away | ||
| noodles775 | wgrant: Thanks for the review - I've pushed 16527 with your test changes for query counts. | 08:04 |
| wgrant | noodles775: Great. Do you still have PQM privs, or do you want someone to land it for you? | 08:05 |
| noodles775 | wgrant: that would be great (I don't think so). | 08:05 |
| wgrant | noodles775: Done | 08:09 |
| wgrant | Hopefully buildbot won't hate it | 08:09 |
| noodles775 | heh, let's see :) Thanks! | 08:10 |
| wgrant | np | 08:11 |
| === wedgwood_away is now known as wedgwood | ||
| === gary_poster|away is now known as gary_poster | ||
| cjohnston | could someone maybe explain what https://code.launchpad.net/~vorlon/launchpad/lp.994110/+merge/105078/comments/303500 means please? I don't understand how the MP doesn't fix that problem. | 16:39 |
| === deryck is now known as deryck[lunch] | ||
| === deryck[lunch] is now known as deryck | ||
| === BradCrittenden is now known as bac | ||
| === Ursinha-afk is now known as Ursinha | ||
| === wedgwood is now known as wedgwood_away | ||
| === wedgwood_away is now known as wedgwood | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!