/srv/irclogs.ubuntu.com/2013/03/07/#launchpad-dev.txt

=== wedgwood is now known as wedgwood_away
StevenKwgrant: https://code.launchpad.net/~stevenk/launchpad/hide-build-portlet-archive/+merge/15186400:23
wgrantStevenK: Have you confirmed that there are no similar cases?00:24
StevenKOn Archive:+index? Yeah00:25
wgrantStevenK: Great00:27
wgrantWhile you're on the PPA pages...00:27
wgrantBug #114954400:27
_mup_Bug #1149544: PPA +packages timeout when too many package copy errors are shown <Launchpad itself:New> < https://launchpad.net/bugs/1149544 >00:28
wgrant15s or so of non-SQL time00:28
wgrantRendering PCJ errors00:28
wgrantSeems a bit odd00:28
StevenKwgrant: I have a second branch on archive pages already00:29
StevenKwgrant: I'll look at that bug after I clear my plate. That MP is first on my list.00:41
wgrantStevenK: I'm not sure it's worth having display_latest_updates, rather than just using context/required:launchpad.View in the template00:41
StevenKwgrant: Oh, I didn't know about that pattern.00:42
* StevenK tries to swap back in the changes for that branch00:44
StevenKwgrant: http://pastebin.ubuntu.com/5591925/00:45
StevenKwgrant: Any other issues?00:49
wgrantStevenK: Seems fine otherwise00:50
StevenKStrange that r16519 turns up as an unmerged revision00:53
wgrantThe scan of the last landing probably failed00:53
StevenKIndeed00:53
* StevenK stabs the branch scanner more00:53
wgrantWas that the spec notification fix?00:53
StevenKYeah00:53
StevenKname => Name00:53
StevenKwgrant: MP updated00:54
wgrantStevenK: Done00:56
wgrantThanks00:56
StevenKwgrant: https://code.launchpad.net/~stevenk/launchpad/preload-subscriptions/+merge/15207301:20
wgrantStevenK: We do not want to link to Archive:+index01:22
wgrantAs it's completely useless to the subscriber until they've activated their sub to get a token01:22
StevenKwgrant: Gar.01:24
StevenKwgrant: So I have to cache a negative permission01:29
wgrantStevenK: An easy change01:31
wgrantHowever01:31
wgrantYou'd need to actually do the view check as well01:31
wgrantOr you can just fix +archivesubscriptions so it never links :)01:31
StevenKThat sounds good01:31
StevenKIt uses subscription/archive/displayname and subscription/archive/fmt:reference01:33
StevenKSo the PPAFormatterAPI is doing the linking01:33
wgrantAre you sure that it actually does link?01:33
wgrantI don't get links01:34
wgrantAnd I can see every PPA01:34
StevenKIt looks up View to see if it should link01:34
wgrantAre you sure?01:34
wgrantBecause it doesn't link even though I do have View01:34
StevenKThe code that's on prod is odd01:34
StevenKIt checks if you're a subscriber if it's private01:35
StevenKOh01:35
StevenKIt doesn't link01:35
StevenKBut it should still check permission so it doesn't leak01:36
wgrantAh, right01:36
wgrantSo, that bit could be adjusted to SubscriberView01:36
StevenKRight01:36
StevenKwgrant: http://pastebin.ubuntu.com/5592006/01:41
wgrantStevenK: Sounds reasonable.01:43
StevenKwgrant: Can haz +1?02:02
wgrantStevenK: Done02:16
StevenKwgrant: Current plan is to deploy after r16521 is QA'd.02:39
StevenKwgrant: One failure in tales.txt03:32
StevenKwgrant: Trying to fmt:link a disabled ppa for anonymous results in <BLANKLINE> now, rather than <span>displayname</span>03:33
wgrantStevenK: Hm, I guess you'll need to reintroduce the private special case03:35
StevenK280 PCJs makes me sad05:39
StevenKwgrant: I wonder if we want to limit the view method to only return 5 and show somehow that there are X others05:42
wgrantStevenK: Quite possibly, yes05:43
wgrantBut it's also worth investigating why they take so long to render without queries05:43
StevenKBecause TAL hates life?05:43
StevenKwgrant: The view method that drags them out of the DB is quite good and preloads everything05:44
wgrantSure, but what sort of data do they have?05:45
wgrantCan't be that huge05:45
StevenK                  tal:attributes="class python: 'failed' if job.status.title=='Failed' else 'non-failed'"05:45
StevenKThat can't be helping05:45
wgrantWhy not?05:45
StevenKLet's see. It pulls out job.status, job.package_name, job.package_version, job.source_archive, job.requestor, job.target_distroseries and job.error_message05:47
=== almaisan-away is now known as al-maisan
=== wedgwood_away is now known as wedgwood
=== al-maisan is now known as almaisan-away
=== deryck is now known as deryck[lunch]
=== wedgwood is now known as wedgwood_away
=== wedgwood_away is now known as wedgwood
=== ajmitch_ is now known as ajmitch
=== deryck[lunch] is now known as deryck
StevenKwgrant: OOPS-7ed453c05c38c1f860dcf3c63e47eb6c22:10
StevenKwgrant: https://code.launchpad.net/~stevenk/launchpad/preload-subscriptions-redux/+merge/15230222:56
wgrantStevenK: k23:01
cjwatsonwgrant: existing_publishing_status> what would a legal method name be?23:33
* cjwatson digs through style guides23:34
cjwatsonOh, whoops, you mean existingPublishingStatus?23:35
wgrantcjwatson: Technically it should be a verb too, but there is precedent for just mixedCasing it, yes23:36
cjwatsonOK.  In an earlier version it was just a class attribute, hence the misnaming23:37
cjwatsonSod it, I"23:40
cjwatson'll be lazy and prepend "get".  There's precedent in the same file23:40
wgrantYup23:41
cjwatsonNow, will bzr-pqm work on this new machine ...23:43
cjwatsonYes.  Excellent.23:49

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!