| JoseeAntonioR | cjohnston: hey, about bug 1146984, what would be your suggestion to the issues I found? | 01:48 |
|---|---|---|
| ubottu | bug 1146984 in Summit "Link directly to Youtube, Etherpad and irc:// in the summit schedule" [Wishlist,In progress] https://launchpad.net/bugs/1146984 | 01:48 |
| cjohnston | commented | 01:52 |
| * JoseeAntonioR checks | 01:54 | |
| JoseeAntonioR | cjohnston: so, agenda.meeting.youtube_video_url would get me the video url? | 01:55 |
| cjohnston | i dont think that exists | 01:57 |
| JoseeAntonioR | then, how should I call what you're specifying? | 01:58 |
| JoseeAntonioR | mhall119: hey | 03:50 |
| mhall119 | JoseeAntonioR: hi | 03:50 |
| JoseeAntonioR | mhall119: busy now? | 03:50 |
| mhall119 | nope | 03:51 |
| mhall119 | ok, so let me go over real quick what the problem is, and what the solution will need to look like | 03:51 |
| JoseeAntonioR | sure | 03:51 |
| mhall119 | so the hover javascript comes from daily.html | 03:52 |
| mhall119 | which is based off the schedule | 03:52 |
| mhall119 | which means is iterates over Slots and Agenda items | 03:52 |
| mhall119 | however, mine.html and review.html just list meetings, they don't care about schedule | 03:53 |
| mhall119 | so you don't have agenda or slot variables | 03:53 |
| mhall119 | with me so far? | 03:53 |
| JoseeAntonioR | yep | 03:53 |
| mhall119 | ok, now another part of daily.html is a hidden div that contains the meeting details | 03:54 |
| mhall119 | <div id="agenda-{{agenda.id}}-{{slot.id}}-details" class="agenda-details"> | 03:54 |
| mhall119 | we had to make them labeled by agenda and slot, rather than by meeting.id, because a 2-slot meeting needed to show the popup in 2 places | 03:55 |
| mhall119 | you don't need that in mine.html and review.html, but you will need to duplicate the hidden div in those templates | 03:55 |
| mhall119 | all the javascript functions do is find the div element, based on the agenda.id and slot.id, and either make it visible or hide it | 03:55 |
| mhall119 | so, what you need to do is the following: | 03:56 |
| * JoseeAntonioR listens | 03:56 | |
| mhall119 | 1: re-create the hidden div in your template, but make it id="meeting-{{meeting.id}}-details" | 03:57 |
| mhall119 | 2: change the javascript functions to take a meeting id, rather than agenda and slot ids | 03:57 |
| mhall119 | 3: change the function calls to pass the meeting id, instead of the agenda and slot ids | 03:57 |
| JoseeAntonioR | ok, let me take a look | 03:58 |
| JoseeAntonioR | would I only have to change that in review.html? as it's working perfectly fine in mine.html as it is | 03:58 |
| mhall119 | you're getting a popup with meeting details in mine.html? | 04:00 |
| JoseeAntonioR | yep | 04:00 |
| JoseeAntonioR | want me to run it so you can test it? | 04:00 |
| mhall119 | yeah | 04:01 |
| mhall119 | I tried it on my localhost but didn't get a popup | 04:01 |
| JoseeAntonioR | give me a sec | 04:01 |
| * JoseeAntonioR changes dns | 04:02 | |
| JoseeAntonioR | mhall119: does joseeantonior.com:8000 resolve? | 04:04 |
| mhall119 | yup | 04:04 |
| JoseeAntonioR | ok, just login | 04:04 |
| JoseeAntonioR | with your openid | 04:04 |
| mhall119 | done | 04:05 |
| JoseeAntonioR | ok, add sessions, and go to your schedule | 04:05 |
| JoseeAntonioR | it should work | 04:06 |
| mhall119 | yeah, I'm not getting a popup | 04:07 |
| mhall119 | http://joseeantonior.com:8000/uds-r/mhall119/meetings | 04:07 |
| JoseeAntonioR | oh, that's mine.html? | 04:07 |
| mhall119 | I think so, yes | 04:08 |
| mhall119 | what were you looking at? | 04:08 |
| JoseeAntonioR | blargh, I thought /uds-r/participant/mhall119 was mine.html | 04:08 |
| mhall119 | no, that's by_participant.html | 04:08 |
| mhall119 | which is like daily.html, in that it's schedule-based | 04:09 |
| JoseeAntonioR | aah, right! | 04:09 |
| JoseeAntonioR | oh, then I'll modify both of them as you said | 04:09 |
| mhall119 | ping me tomorrow if you need any help | 04:10 |
| JoseeAntonioR | sure, thanks! | 04:10 |
| mhall119 | np, thank you for taking the time to work on Summit :) | 04:10 |
| JoseeAntonioR | no worries! :) | 04:15 |
| mhall119 | cjohnston: what would we need to do in order to run https://wiki.ubuntu.com/UbuntuSDKDays/Prep on Summit? | 16:40 |
| nigelb | Buy him large amounts of beer. | 16:41 |
| jhodapp | hey mhall119 | 18:00 |
| mhall119 | hey jhodapp, #ubuntu-meeting not #ubuntu-website :) | 18:02 |
| jhodapp | mhall119, was wondering if that was true :) | 18:02 |
| cjohnston | mhall119: what nigelb said | 20:07 |
| mhall119 | cjohnston: I'd say I'll buy you one at UDS, but you'd just come over to claim it | 20:09 |
| cjohnston | I'm on my way.. I could use a few drinks right now and you know why | 20:09 |
| cjohnston | daker: https://code.launchpad.net/~chrisjohnston/loco-team-portal/bzr-apps-url-fixes/+merge/152509 mhall119 <<< | 20:27 |
| mhall119 | cjohnston: will IS be able to use those? | 20:28 |
| cjohnston | thats what is used in summit | 20:28 |
| cjohnston | afaik | 20:28 |
| mhall119 | good enough for me | 20:29 |
| cjohnston | that matches the bzr_apps part of the code to summit | 20:29 |
| cjohnston | mhall119: do you want to throw it into production to make the release work correctly? | 20:37 |
| mhall119 | cjohnston: yeah, go ahead | 20:38 |
| mhall119 | unless they've already done it manually | 20:38 |
| cjohnston | that wasn't the question. | 20:38 |
| cjohnston | it doesnt appear to have been updated | 20:39 |
| daker | hi | 21:10 |
| cjohnston | hi ho, hi ho, it's off to work i go | 21:13 |
| daker | hi mhall119 FYI now you need to tell them to run ./manage.py update_openids because we are swithing to login.u.c | 21:14 |
| mhall119 | oh we are? ok. has that been deployed already? | 21:15 |
| cjohnston | i dont think its been deployed | 21:15 |
| daker | ah i sorry | 21:16 |
| daker | mhall119: i can do another release before they deploy | 21:24 |
| mhall119 | daker: let's do that | 21:25 |
| daker | ok i'll do it | 21:25 |
| cjohnston | be careful that you dont get *too* complicated | 21:32 |
| cjohnston | daker: I just created lp:loco-team-portal/production | 21:34 |
| daker | cjohnston: and ? | 21:35 |
| cjohnston | just letting you know.. its easier to type/remember than lp:ltp-devs/loco-team-portal/production or wahtever it was | 21:36 |
| daker | ok but for now i think i'll the ~ltp-devs | 21:36 |
| cjohnston | It's the same branch.. lp:loco-team-portal/production == https://code.launchpad.net/~ltp-devs/loco-team-portal/production | 21:37 |
| cjohnston | just a 'prettier' name | 21:37 |
| daker | ah ok | 21:37 |
| cjohnston | daker: does ltp still use twidenash? | 21:42 |
| daker | yes | 21:42 |
| daker | we still use it | 21:42 |
| cjohnston | the twitter api on summit still needs to be fixed :-/ | 21:43 |
| daker | mhall119: done https://code.launchpad.net/~ltp-devs/loco-team-portal/production | 22:13 |
| cjohnston | daker: update the RT | 22:13 |
| cjohnston | please | 22:13 |
| daker | now we need to run ./manage.py update_openids | 22:13 |
| daker | and ./manage.py lcupdate | 22:13 |
| cjohnston | gotcha | 22:15 |
| cjohnston | so add that stuff please | 22:15 |
| mhall119 | lcupdate or lpupdate? | 22:27 |
| cjohnston | lc | 22:28 |
| cjohnston | https://bazaar.launchpad.net/~ltp-devs/loco-team-portal/0.2/view/head:/loco_directory/teams/management/commands/lcupdate.py | 22:28 |
| daker | lc | 22:29 |
| mhall119 | ah, ok | 22:30 |
| cjohnston | mhall119: | 22:31 |
| cjohnston | https://code.launchpad.net/~chrisjohnston/summit/csrf/+merge/152298 | 22:31 |
| cjohnston | https://code.launchpad.net/~chrisjohnston/summit/i18n/+merge/152525 | 22:31 |
| cjohnston | https://code.launchpad.net/~chrisjohnston/summit/track-display-name/+merge/151846 | 22:31 |
| daker | this used to update the LC members on /loco-council | 22:32 |
| mhall119 | cjohnston: ignore the MP comment, something else is causing those errors | 22:39 |
| cjohnston | mhall119: on the csrf page, please play with actually moving stuff around | 22:51 |
| mhall119 | cjohnston: I need to figure out why I'm getting these test failures | 22:58 |
| daker | LTP test are also failling :( | 23:01 |
| mhall119 | :( | 23:02 |
| daker | something related to the switch to login.u.c | 23:02 |
| daker | https://drone.io/daker/ltp/23 | 23:02 |
| mhall119 | wtf, now they all pass :( | 23:04 |
| mhall119 | summit ones anyway | 23:04 |
| daker | hhhh | 23:04 |
| cjohnston | mhall119: we really have to figure out how to harden our test | 23:26 |
| cjohnston | s | 23:26 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!