wgrantStevenK: Does the PCJ count thing look reasonable?00:06
StevenKwgrant: Look reasonable in terms of layout, or query count?00:21
wgrantStevenK: layout00:24
StevenKwgrant: http://wedontsleep.org/~steven/ff.jpg01:00
wgrantStevenK: Looks good01:04
lifelessflacoste: o/01:25
StevenKcjwatson: r=me01:33
StevenKwgrant: Can I have a +1 then?02:27
wgrantStevenK: That's a reasonable point02:28
=== Ursinha_ is now known as Ursinha
StevenKwgrant: https://code.launchpad.net/~stevenk/launchpad/person-deactivate-job/+merge/15280903:25
wgrantStevenK: Might it make sense to set the account status immediately?03:51
wgrantSo they're kicked out immediately but the references are purged over the next few minutes03:52
StevenKwgrant: I was wondering about that03:52
StevenKwgrant: In the view, or IPerson.deactivate() ?03:54
StevenKwgrant: Or both?03:57
wgrantStevenK: I think both, I guess03:57
wgrantSet the status, kill off the preferredemail (and possibly other emails) and anything else reasonably sane, within the request03:57
StevenKOh, so split the work up03:58
wgrantStevenK: So perhaps kill off deactivate()04:07
wgrantStevenK: Split it into two methods04:07
wgrantOne which does the easy stuff04:07
wgrantHave both the view and the deactivation job call the easy one04:07
wgrantJust in case, and so that a deactivation job is sufficient if we ever end up needing to deactivate without going through the view04:08
wgrantThe view just takes a bit of a shortcut to make it appear more instantaneous.04:08
StevenKwgrant: http://pastebin.ubuntu.com/5606844/04:11
wgrantThat's no method name.04:13
StevenKI couldn't think of a better one04:14
StevenKearlyDeactivate made me sob04:14
wgrantIt's not a bad method name, it's not a method name at all :)04:14
wgrantBut pre or early or something might be an improvement04:15
StevenKwgrant: IPerson.preDeactivate(), just checking tests04:22
StevenK    bug_task.transitionToAssignee(None)04:35
StevenKUnauthorized: (<BugTask for bug 16 on <Product at 0xf49e8d0>>, 'transitionToAssignee', 'launchpad.Edit')04:35
_mup_Bug #16: "Swedish" and "Swedish (Sweden)" should be the same language <lp-translations> <Launchpad itself:Fix Released by daf> < https://launchpad.net/bugs/16 >04:35
wgrantStevenK: The job should run in PermissiveSecurityPolicy04:37
wgrantSo that can't happen04:37
StevenKwgrant: How do I set that?04:38
wgrantIt does automatically04:38
wgrantYour test may not be doing that, so you might have to log in as an admin04:38
wgrant(or use ZopelessLayer)04:38
StevenKwgrant: UserCannotEditBugTaskAssignee: Regular users can assign and unassign only themselves and their teams. Only project owners, bug supervisors, drivers and release managers can assign others.04:42
wgrantWhich test is this, and what did you change?04:42
StevenKwgrant: http://pastebin.ubuntu.com/5606881/04:42
wgrantSo a new test :)04:45
wgrantWhat's the traceback now?04:46
StevenKI'll be extending the test to add things like branchsubs and things to make sure DB perms are right04:46
StevenKwgrant: http://pastebin.ubuntu.com/5606888/04:47
wgrantStevenK: Recall that the deactivation job will now probably run with no interaction, where previously it ran as the user being deactivated.04:48
StevenKwgrant: Should I grab the janitor and log in as that, then?04:49
wgrantBut check what transitionToAssignee checks04:49
wgrantYou may be able to simply pass in the janitor04:49
wgrantI forget.04:49
StevenKIt grabs the user from the bag04:50
wgrantIt doesn't have an override?04:50
StevenKIt does not04:50
wgrantSee if there is precedent for impersonating jobs, eg. merges04:51
StevenKMerges are done via direct DB access04:53
StevenKMaybe we should just set the bag user to the person04:54
wgrantPossibly, or the entire interaction for the durating04:54
StevenKwgrant: I can't really use person_logged_in in the job's run(), can I?04:55
wgrantI don't believe so04:56
wgrantSee, this is why model stuff should never use launchbag04:56
wgrantStevenK: Perhaps there are few enough methods that adding override arguments makes sense04:58
StevenKMaking use of person_logged_in in job.run() has the test pass, but it makes me sob04:59
wgrantAnd it makes me murderous :)05:00
StevenKwgrant: I think that's everything05:41
StevenKwgrant: That MP is updated.06:01
wgrantStevenK: Thanks06:49
wgrantWill look in a sec06:49
* StevenK stabs the branch scanner06:54
StevenKwgrant: I think it's fair to say that sec is up.07:06
wgrantStevenK: Sigh, longpoll, sorry07:13
wgrantFixed now07:13
StevenK% bzr grep 'All rights reserved' lib/lp | grep -E '\.(py|js):' | wc -l07:27
StevenKwgrant: ^07:27
StevenKI think I might fix that up tomorrow morning07:30
* StevenK grumbles at the loss of buildbot bingo08:03
=== mthaddon` is now known as mthaddon
=== almaisan-away is now known as al-maisan
=== alexlist` is now known as alexlist
=== deryck_ is now known as deryck
=== Ursinha is now known as Ursinha-afk
=== teknico_ is now known as teknico
=== matsubara is now known as matsubara-lunch
=== al-maisan is now known as almaisan-away
=== yofel_ is now known as yofel
=== deryck is now known as deryck[lunch]
=== BradCrittenden is now known as bac
=== maxb_ is now known as maxb
=== Ursinha-afk is now known as Ursinha
=== matsubara-lunch is now known as matsubara
=== Ursinha_ is now known as Ursinha
=== deryck[lunch] is now known as deryck
butlerni'm trying to get a source package built in my launchpad ppa, the source package requires the source of another package to be installed but it seems there are no deb-src repos available in the chrooted build env, what's the best approach to getting apt-get source <package> to work? or is that not supported?19:21
maxbbutlern: It's not really supported - it's not a normal thing ever done for official packages19:35
butlernmaxb: gotcha, i guess i'll bump the varnish maintainers to add a -dev package for header files required by vmod compilation, thanks19:37
maxbbutlern: That's certainly the normal way to get access to header files.19:39

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!