[00:06] StevenK: Does the PCJ count thing look reasonable? [00:21] wgrant: Look reasonable in terms of layout, or query count? [00:24] StevenK: layout [01:00] wgrant: http://wedontsleep.org/~steven/ff.jpg [01:04] StevenK: Looks good [01:21] https://code.launchpad.net/~cjwatson/launchpad/testfix-delete-unmodifiable-suite/+merge/152807 [01:25] flacoste: o/ [01:33] cjwatson: r=me [01:34] Thanks [02:27] wgrant: Can I have a +1 then? [02:28] StevenK: That's a reasonable point [02:30] (done) === Ursinha_ is now known as Ursinha [03:25] wgrant: https://code.launchpad.net/~stevenk/launchpad/person-deactivate-job/+merge/152809 [03:51] StevenK: Might it make sense to set the account status immediately? [03:52] So they're kicked out immediately but the references are purged over the next few minutes [03:52] wgrant: I was wondering about that [03:54] wgrant: In the view, or IPerson.deactivate() ? [03:57] wgrant: Or both? [03:57] StevenK: I think both, I guess [03:57] Set the status, kill off the preferredemail (and possibly other emails) and anything else reasonably sane, within the request [03:58] Oh, so split the work up [03:58] Yeah [04:07] StevenK: So perhaps kill off deactivate() [04:07] StevenK: Split it into two methods [04:07] One which does the easy stuff [04:07] Have both the view and the deactivation job call the easy one [04:08] Just in case, and so that a deactivation job is sufficient if we ever end up needing to deactivate without going through the view [04:08] The view just takes a bit of a shortcut to make it appear more instantaneous. [04:11] wgrant: http://pastebin.ubuntu.com/5606844/ [04:13] That's no method name. [04:14] I couldn't think of a better one [04:14] earlyDeactivate made me sob [04:14] It's not a bad method name, it's not a method name at all :) [04:15] But pre or early or something might be an improvement [04:22] wgrant: IPerson.preDeactivate(), just checking tests [04:35] Hmmmm [04:35] bug_task.transitionToAssignee(None) [04:35] Unauthorized: (>, 'transitionToAssignee', 'launchpad.Edit') [04:35] <_mup_> Bug #16: "Swedish" and "Swedish (Sweden)" should be the same language < https://launchpad.net/bugs/16 > [04:37] StevenK: The job should run in PermissiveSecurityPolicy [04:37] So that can't happen [04:38] wgrant: How do I set that? [04:38] It does automatically [04:38] Your test may not be doing that, so you might have to log in as an admin [04:38] (or use ZopelessLayer) [04:42] wgrant: UserCannotEditBugTaskAssignee: Regular users can assign and unassign only themselves and their teams. Only project owners, bug supervisors, drivers and release managers can assign others. [04:42] Which test is this, and what did you change? [04:42] wgrant: http://pastebin.ubuntu.com/5606881/ [04:43] TestPersonDeactivateJob.test_deactivate [04:45] Oh [04:45] So a new test :) [04:46] Yeah [04:46] What's the traceback now? [04:46] I'll be extending the test to add things like branchsubs and things to make sure DB perms are right [04:47] wgrant: http://pastebin.ubuntu.com/5606888/ [04:48] StevenK: Recall that the deactivation job will now probably run with no interaction, where previously it ran as the user being deactivated. [04:48] Indeed [04:49] wgrant: Should I grab the janitor and log in as that, then? [04:49] Possibly [04:49] But check what transitionToAssignee checks [04:49] You may be able to simply pass in the janitor [04:49] I forget. [04:50] It grabs the user from the bag [04:50] It doesn't have an override? [04:50] It does not [04:51] See if there is precedent for impersonating jobs, eg. merges [04:53] Merges are done via direct DB access [04:54] Maybe we should just set the bag user to the person [04:54] Possibly, or the entire interaction for the durating [04:54] duration [04:55] wgrant: I can't really use person_logged_in in the job's run(), can I? [04:56] I don't believe so [04:56] See, this is why model stuff should never use launchbag [04:56] Heh [04:58] Still [04:58] StevenK: Perhaps there are few enough methods that adding override arguments makes sense [04:59] Making use of person_logged_in in job.run() has the test pass, but it makes me sob [05:00] And it makes me murderous :) [05:41] wgrant: I think that's everything [06:01] wgrant: That MP is updated. [06:49] StevenK: Thanks [06:49] Will look in a sec [06:54] * StevenK stabs the branch scanner [07:06] wgrant: I think it's fair to say that sec is up. [07:13] StevenK: Sigh, longpoll, sorry [07:13] Fixed now [07:27] % bzr grep 'All rights reserved' lib/lp | grep -E '\.(py|js):' | wc -l [07:27] 98 [07:27] wgrant: ^ [07:30] I think I might fix that up tomorrow morning [08:03] * StevenK grumbles at the loss of buildbot bingo === mthaddon` is now known as mthaddon === almaisan-away is now known as al-maisan === alexlist` is now known as alexlist === deryck_ is now known as deryck === Ursinha is now known as Ursinha-afk === teknico_ is now known as teknico === matsubara is now known as matsubara-lunch === al-maisan is now known as almaisan-away === yofel_ is now known as yofel === deryck is now known as deryck[lunch] === BradCrittenden is now known as bac === maxb_ is now known as maxb === Ursinha-afk is now known as Ursinha === matsubara-lunch is now known as matsubara === Ursinha_ is now known as Ursinha === deryck[lunch] is now known as deryck [19:21] i'm trying to get a source package built in my launchpad ppa, the source package requires the source of another package to be installed but it seems there are no deb-src repos available in the chrooted build env, what's the best approach to getting apt-get source to work? or is that not supported? [19:35] butlern: It's not really supported - it's not a normal thing ever done for official packages [19:37] maxb: gotcha, i guess i'll bump the varnish maintainers to add a -dev package for header files required by vmod compilation, thanks [19:39] butlern: That's certainly the normal way to get access to header files.