| frankban | rogpeppe1: morning. already asked William, but could you please take a look at our comments in https://codereview.appspot.com/7598043 ? | 10:36 |
|---|---|---|
| rogpeppe1 | frankban: will do. just getting back up to speed. | 10:36 |
| frankban | rogpeppe1: cool, thanks | 10:36 |
| === rogpeppe1 is now known as rogpeppe | ||
| teknico | uhm, cannot submit a branch, make beautify stops with this: http://pastebin.ubuntu.com/5610507/ | 12:21 |
| gary_poster | teknico, I wonder if this is another case of " we should specify our versions" | 12:22 |
| teknico | I removed the virtualenv directory, to no avail | 12:22 |
| teknico | gary_poster, probably | 12:22 |
| gary_poster | Let's see if we can figure out what our respective versions of the closure linter are | 12:22 |
| bac | guihelp: i'm trying to run individual tests in the browser but get this: | 12:22 |
| bac | Cannot GET /test/index.html/?grep=Go%20Juju%20environment | 12:22 |
| bac | anyone seen this before? work-around? | 12:22 |
| bcsaller__ | remove the / after index | 12:23 |
| gary_poster | yup | 12:23 |
| gary_poster | hey bcsaller__ (that's a long tail!) would appreciate your thoughts on https://code.launchpad.net/~gary/charms/precise/juju-gui/bug1117896/+merge/152973 | 12:24 |
| bac | thanks bcsaller__ | 12:24 |
| gary_poster | teknico, I ran virtualenv/bin/python, imported closure_linter, called help(closure_linter) and saw in the file that I had closure_linter-2.3.6.1-py2.7.egg | 12:27 |
| gary_poster | nowe making sure that it works but pretty sure it does | 12:27 |
| gary_poster | it does | 12:27 |
| gary_poster | teknico, another possibility: beautify is encountering a particular case in your code that it barfs on. You could try running make beautify on trunk | 12:28 |
| gary_poster | if it is the same version | 12:28 |
| * gary_poster goes to look on pypi | 12:28 | |
| teknico | gary_poster, same version as mine, yes | 12:28 |
| bcsaller__ | gary_poster: I wrote it with the intention that socket_url when defined would continue to work as before. I thought that would be enough | 12:28 |
| gary_poster | bcsaller__, it gives backwards compatibility with the GUI but not the charm, do you see what I mean? | 12:29 |
| gary_poster | If the charm takes advantage of the new functionality, it will break old versions of the GUI | 12:29 |
| gary_poster | I would like the charm to default to the new, improved behavior whenever possible | 12:29 |
| teknico | gary_poster, make beautify in trunk works correctly here, so your idea about something in my code is plausible | 12:30 |
| bcsaller__ | gary_poster: I would as well. When would the charm deploy an old version of the GUI? | 12:30 |
| gary_poster | teknico, does make gjslint succeed in your branch? If so, you could fix manually | 12:30 |
| teknico | gary_poster, nope, it stops with the same error | 12:31 |
| gary_poster | bcsaller__, first answer is "whenever it wanted to" because we allow configuration of this. | 12:31 |
| gary_poster | teknico, ugh, suck. I don't know, have not encountered. You could try putting in a pdb and seeing if you diagnose or at least work around | 12:32 |
| teknico | gary_poster, I'll try that | 12:33 |
| gary_poster | bcsaller__, second answer is that the tests ran the 0.2.1 release, and broke. They only succeeded when I changed it to 0.2.2. That's what smelled like a problem we ought to address | 12:33 |
| gary_poster | bcsaller__, corrollary to both of those is that the error condition--the gui spins forever trying to connect to the back end, never succeeding--does not lend itself to knowing what to do to fix the problem | 12:35 |
| gary_poster | I phrased that poorly, but hopefully you know what I mean | 12:35 |
| bcsaller__ | I do | 12:35 |
| bcsaller__ | I think if anyone saw that I'd rather put it in a FAQ saying redeploy than carrying special code for that case. We already have a screen indicating it can't connect to the backend. If it sits on that screen they will have to read about socket_url anyway so I think it could be solved with docs. *not sure* | 12:40 |
| bcsaller__ | brb | 12:40 |
| gary_poster | ok | 12:41 |
| * gary_poster is surprised that no-one erupted in excitement at my discovery of chrome://appcache-internals/ . Maybe benji or Makyo will give me a half-hearted cheer later. :-) | 12:43 | |
| goodspud | HOooray! | 12:44 |
| benji | heh, I haven't looked at it yet. I'm sure it will be fabulous. | 12:50 |
| frankban | gary_poster: chrome://appcache-internals/ is awesome! :-) and re: the charm proposal: why do we use {{insecure}} to comment out code in a tempita template? | 12:50 |
| gary_poster | goodspud, benji, frankban thanks! I feel so much better now that my excitement is shared. :-) | 12:51 |
| gary_poster | frankban, ah! yes! I knew I didn't like that for some reason. Duh. :-) I'll fix that, thanks | 12:52 |
| gary_poster | bcsaller__, I thought about this. ISTM that we simply need to invert the precedence of the old/new config options | 12:52 |
| gary_poster | right now, if you provide socket_url, and one of the new variables, socket_url wins | 12:53 |
| gary_poster | there's no reason for that to be the case AFAIK, and if we invert it, the charm can support old and new trivially | 12:54 |
| bcsaller__ | gary_poster: auto generation with manual override seems right to me. I guess its still like that if you delete reference to _port and _protocol though | 12:55 |
| gary_poster | bcsaller__, exactly | 12:56 |
| gary_poster | the question is what does the GUI do if you provide both, and this solution seems reasonable in the abstract, and solves a problem with the specific case of the charm or other automation that wants to support old and new versions of the GUI | 12:56 |
| === bcsaller__ is now known as bcsaller | ||
| teknico | oh wow, this is not good | 12:59 |
| gary_poster | bcsaller, are you ok with me proceeding with that plan? | 12:59 |
| teknico | gary_poster, problem was a missing closing curly+round bracket pair | 13:00 |
| bcsaller | gary_poster: I think its fine. The other made more sense to me but for the most part people still don't need to define anything for it to work (except in development) | 13:00 |
| gary_poster | right cool bcsaller thanks | 13:00 |
| gary_poster | teknico, eek! sounds like an opprtunity to become a closure contributor :-) | 13:01 |
| teknico | really weird thing was that tests passed, that syntactically invalid file notwithstanding! | 13:01 |
| gary_poster | ...wow, that is weird | 13:01 |
| teknico | and now the test right above fails, so somehow that missing line was causing that test to be skipped | 13:02 |
| bcsaller | teknico: a failure in a test file like that will usually skip the file | 13:03 |
| teknico | bcsaller, yeah, if I really look for it, I can see this in the test output: "SyntaxError: Parse error" | 13:05 |
| teknico | and with no hint of which file is the offending one :-P | 13:05 |
| bcsaller | chrome's console log should make it clear | 13:05 |
| teknico | bcsaller, I was running "make test-prod", everything looked hunky dory | 13:06 |
| rick_h_ | so thought it was cool. At my local LUG a guy was demo'ing ceph and used the juju gui to 'visualize' the environment as he created it and added ceph nodes, gateway nodes, haproxy, etc | 13:24 |
| gary_poster | rock, rick_h_ ! | 13:24 |
| rick_h_ | worked pretty nice to translate his juju commands he was running to 'wtf that means' in the big picture | 13:25 |
| bac | rick_h_, so he did it all by hand and then just viewed via the gui? | 13:25 |
| rick_h_ | bac: right | 13:25 |
| bac | rick_h_ did you point out the obvious? | 13:25 |
| rick_h_ | he was ssh'ing into the machines to run ceph status, showed some of the config, etc | 13:26 |
| rick_h_ | bac: yea, he mentioned how you *can* do it from the gui, but he was using local charms and had the juju commands scripted out | 13:26 |
| bac | righto | 13:26 |
| rick_h_ | was still cool to just go to a meeting and be like "Well that looks familiar" :) | 13:27 |
| rick_h_ | he used teh charm to deploy it into his env first | 13:27 |
| rick_h_ | so charm'ing the gui ftw | 13:27 |
| gary_poster | yay! | 13:27 |
| frankban | cool | 13:28 |
| gary_poster | Makyo, when you are around, lemme know and we'll try to arrange a quick call with you, frankban, rogpeppe, fwereade and me to see if we can quickly unblock the annotations thing | 13:30 |
| Makyo | gary_poster, 8 minutes? | 13:52 |
| === matsubara_ is now known as matsubara | ||
| Makyo | Would like a coffee first. | 13:52 |
| gary_poster | Hey Makyo. Understood. :-) I'll arrange something after that, thanks | 13:52 |
| gary_poster | teknico, are you available now? | 13:53 |
| gary_poster | oh duh | 13:53 |
| gary_poster | today is not Thursday :-) | 13:53 |
| gary_poster | nm teknico, sorry | 13:54 |
| gary_poster | Makyo, frankban call in 62 minutes hopefully, if that works with Roger (and Makyo, join #juju-dev :-) ) | 13:59 |
| frankban | gary_poster: ack, thanks | 14:03 |
| Makyo | gary_poster, got it. Will be there. | 14:04 |
| gary_poster | thanks | 14:05 |
| gary_poster | (still no confirmation from Roger though) | 14:05 |
| hatch | aww I was deactivated from the gophers group :'( | 14:06 |
| Makyo | Me too. | 14:06 |
| hatch | yikes and you're working on Go....I sense a disturbance in the force! | 14:06 |
| gary_poster | All of us. Not sure about meaning--seems odd--but not a practical issue. | 14:08 |
| hatch | maybe it's now an invite only thing - you need to be invited to code Go | 14:08 |
| hatch | ;) | 14:08 |
| benji | me too; good, now I can throw away the go code I've been working on ;P | 14:09 |
| hatch | lol | 14:10 |
| frankban | me too, this means I will never have one of these: http://www.mikespook.com/wp-content/uploads/2011/05/gopher.jpg | 14:12 |
| gary_poster | :-) | 14:12 |
| gary_poster | ah! ~gophers was deactivated entirely | 14:13 |
| gary_poster | so it's not just us :-) | 14:13 |
| hatch | oh gary, wrecking the conspiracy theories | 14:14 |
| benji | my first chance at being an outcast: pfft! it's gone | 14:14 |
| gary_poster | I know, I'm a spoilsport | 14:14 |
| gary_poster | :-) | 14:14 |
| hatch | benji, first chance? You must not have been a geek in school then...lol | 14:14 |
| benji | I majored in misstating the truth for comedic effect. | 14:15 |
| Makyo | Well played :) | 14:15 |
| gary_poster | benji has sarcasm running through his veins, like mello yello, his favorite drink, flowing through...a straw? | 14:15 |
| benji | LOL | 14:15 |
| hatch | hahaha | 14:16 |
| gary_poster | jujugui, call in 2 in guichat | 14:27 |
| gary_poster | bac goodspud starting without you | 14:31 |
| gary_poster | rick_h_, miss you too :-) | 14:31 |
| rick_h_ | gary_poster: all good | 14:33 |
| teknico | bac, shall we hangout, in a few minutes maybe? | 14:44 |
| bac | teknico: yes, i'll ping you in a few minutes | 14:44 |
| teknico | ok | 14:44 |
| hatch | bcsaller, I happened to have the sauce labs account info page open while you were running the tests this am and it was running the FF and Chrome tests at the same time | 14:51 |
| hatch | so if they are using the same back end that could cause issues no? | 14:52 |
| bcsaller | hatch: I don't *think* thats is what happens but I can read up on it. Its odd though as the tests wait for the response so they shouldn't be able to run at the same time | 14:53 |
| hatch | yeah it may have just been spinning the other one up - but there were definitely two 'Running' flags on at the same time | 14:54 |
| bac | benji: what is wrong with this: tb receive xmpp:nicola.larosa@gmail.com | 15:00 |
| benji | bac: are you getting "ValueError: too many values to unpack"? | 15:00 |
| bac | yep | 15:00 |
| benji | if you update it should work (a new version was built 31 minutes ago with a fix) | 15:01 |
| bac | benji: did the cl change? | 15:01 |
| benji | nope, lack of CI caused me to unleash a bug onto the world | 15:01 |
| teknico | benji, I'm getting no tb update though | 15:03 |
| bac | benji: my tb is 0.4.0-1~115~qua and no update is available | 15:03 |
| benji | hmm, let me double-check | 15:04 |
| hatch | It doesn't look like the lbox is working so I manually triggered this to need review for merge | 15:04 |
| hatch | https://code.launchpad.net/~hatch/juju-gui/ci-documentation/+merge/153165 | 15:04 |
| benji | darn, it hasn't been pushed to the PPA yet, https://code.launchpad.net/~benji/+recipe/termbeamer-daily says it will take 30 minutes | 15:04 |
| benji | you could run it from trunk; other than that I don't know what to do... wait, I could give you a file for you to replace the one with the bug | 15:06 |
| teknico | benji, thanks, no hurry, we'll work around it for these few minutes | 15:10 |
| benji | I regret the inconvenience, but am happy that enough people are using it that my screw up was noticed. :) | 15:11 |
| bac | benji: glad to be part of your vast QA team! | 15:20 |
| benji | heh | 15:20 |
| benji | I really have to get CI set up so this doesn't happen again. | 15:20 |
| bac | so yesterday for my flights AA was $356 and DL was a few hundred more. today they are both $356. i guess if you wait long enough they will all reach parity on a given route. | 15:22 |
| teknico | bac, false alarm, I was missing those brackets *again*, test still failing :-/ | 15:24 |
| teknico | I'll try with the wsclient | 15:24 |
| hatch | bcsaller, any idea what the eta on that CI stuff might be? I was thinking I'd jump on the router stuff if you're going to be a while | 15:37 |
| hatch | just to keep the boat moving :) | 15:38 |
| bcsaller | hatch: feel free to look at it, I was going to override the afterHistoryChange event and attempt the fix there | 15:38 |
| hatch | alrighty - did you make any changes from trunk so far? | 15:40 |
| bcsaller | hatch: I don't see anything important, I'd be happy to talk things over with you if you don't see a way to make progress though and hopefully we could pair on it later, but I want to get the CI stuff working better still | 15:43 |
| hatch | sounds good! Right now I'll browse through it and reproduce the error to see what I can come up with | 15:46 |
| === matsubara is now known as matsubara-lunch | ||
| hatch | I think we have a bug in the init code for the GUI on the very first load from make devel it doesn't appear to make the websocket request | 16:20 |
| hatch | it needs to be loaded again to do so | 16:20 |
| hatch | has anyone else ever seen this? | 16:20 |
| gary_poster | no | 16:33 |
| gary_poster | jujugui, I am unable to propose a GUI branch because lbox propose, in the check, fails with the following: Failed to start mocha: Init timeout \n make: *** [test-debug] Error 255 (fuller pastebin http://pastebin.ubuntu.com/5611150/). Anybody know what is up with this? It looks liek mocha has some kind of timer that I don't know how to configure. Note that make test-debug works finr from the commandline | 16:37 |
| bcsaller | gary_poster: that can be intermittent, usually retrying works | 16:37 |
| benji | gary_poster: teknico had this problem on Friday at the sprint; we investigated until it went away | 16:37 |
| teknico | gary_poster, I'm having the same problem, and make test-debug times out too | 16:38 |
| teknico | benji, it didn't really go away, it just occasionally succeeds :-) | 16:38 |
| gary_poster | ok will retry bcsaller. This has happened a few times already. benji, teknico interesting. :-/ I'll look a little deeper if I can | 16:38 |
| benji | s/went away/(temporarily) went away/ | 16:38 |
| teknico | also, in weekly discuss we have a card saying "Remove test-debug from lbox check?" to which I'd emphatically reply "yes" :-) | 16:39 |
| gary_poster | https://github.com/metaskills/mocha-phantomjs/blob/master/lib/mocha-phantomjs.coffee#L112 ... | 16:39 |
| gary_poster | I don't agree in theory, but looking forward to the discussion. | 16:39 |
| teknico | rather than removing it we could swap it out for make test-prod, which works reliably | 16:40 |
| gary_poster | We do both | 16:40 |
| gary_poster | which is appropriate if we want both to work after commits | 16:40 |
| hatch | I have run into that issue before, usually trying again and it works | 16:42 |
| hatch | :) | 16:42 |
| rick_h_ | yea, I only get that very infrequently. I've only had it once during a local test run and once during an lbox run. | 16:43 |
| gary_poster | .option('-t, --timeout <timeout>', 'specify the test startup timeout to use', parseInt, 6000) | 16:43 |
| gary_poster | ... | 16:43 |
| rick_h_ | I'd not thought it so widespread | 16:43 |
| gary_poster | I have never encountered before. I assume it is tied to the number of files/amount of code we have | 16:44 |
| gary_poster | hm, increasing timeout does not help. we appear to have some kind of intermittent hang? | 16:47 |
| gary_poster | timeout clearly is being honored | 16:47 |
| gary_poster | interesting | 16:47 |
| hatch | faster computers! | 16:49 |
| hatch | looks like we all need to requisition new computers to be able to do our jobs... | 16:50 |
| gary_poster | neither phantom nor mocha-phantom have any kind of verbosity flag :-/ | 16:50 |
| gary_poster | as I said, that doesn't seem to be the problem here | 16:50 |
| gary_poster | it's a hang of some sort | 16:50 |
| hatch | no...it is...new computers....;) | 16:50 |
| gary_poster | or something else that takes > 20 seconds | 16:50 |
| gary_poster | heh | 16:50 |
| hatch | but yeah, I have nothing to add here other than every time it happens to me I run it again and it works the second time | 16:51 |
| hatch | I haven't looked into it | 16:51 |
| gary_poster | virtually consistent for me. and make test-debug now fails as well, which it was not before | 16:51 |
| hatch | hmm that's odd | 16:51 |
| hatch | jcsackett, am i supposed to re-review that branch? | 16:51 |
| jcsackett | hatch: only if you want to, i was pushing up changes requested for rick_h_. | 16:52 |
| hatch | jcsackett, hmm - I see that you went away from widget to base but aren't using any base methods....is this going to be expanded at some point? | 16:54 |
| hatch | or is it pretty much done? | 16:54 |
| jcsackett | hatch: not sure. there's some work with a view that will use this, and i don't know if it will need to be updated then. | 16:55 |
| rick_h_ | hatch: it'll be wrapped in a Y.View() in the future. It's just a wrapper for prettyprint.js | 16:55 |
| jcsackett | rick_h_: it's a *little* more than that man, don't go hurting my feelings now. :-P | 16:55 |
| rick_h_ | hatch: the old code needed to be passed an ATTR for the file content and I didn't want to hold onto the file content in JS memory since it's not needed to be reused/etc | 16:55 |
| rick_h_ | jcsackett: trying to simplify for hatch :P | 16:56 |
| hatch | oh ok - in that case you can probably get away from Y.Base entirely and go with a Object.create() on a constructor fn | 16:56 |
| hatch | Y.Base is pretty heavy - and if you aren't using any of it's lifecycle methods then there is really no bennefit | 16:56 |
| jcsackett | hatch: you just like throwing entirely new ways to do things at me. | 16:56 |
| jcsackett | :-P | 16:56 |
| hatch | benefit | 16:56 |
| rick_h_ | hatch: yea, that's true. I guess we can go all the way down and then if we do need something once it's wrapped in the view add it back into play. | 16:56 |
| hatch | jcsackett, haha - best way to learn ;) | 16:57 |
| jcsackett | so, Object.create syntax is documented where now? | 16:57 |
| gary_poster | teknico, does this let make test-debug run for you? http://pastebin.ubuntu.com/5611209/ | 16:57 |
| hatch | jcsackett, one second | 16:57 |
| teknico | gary_poster, I just lot mo' fancier breakage from our friendly "lbox submit": http://pastebin.ubuntu.com/5611208/ | 16:58 |
| teknico | gary_poster, I'll try | 16:58 |
| hatch | jcsackett, https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/Object/create | 16:58 |
| hatch | and it's being used in assets/routing.js | 16:58 |
| hatch | jcsackett, it's basically the ES5 way of doing Y.Base.create | 16:59 |
| hatch | and if you want to know the old school manual way of doing it | 16:59 |
| hatch | http://fromanegg.com/post/41107863511/prototypes-and-class-like-objects-in-javascript | 16:59 |
| hatch | you can read that blog post, and the previous one | 16:59 |
| rick_h_ | jcsackett: and at this point might as well add it to the prettify wrapper and stick it on a namespace so it's one module vs two. | 16:59 |
| hatch | I haven't had time to write the followup | 16:59 |
| jcsackett | right, i'll just kill fileviewer at this point. | 17:00 |
| rick_h_ | jcsackett: basically after the point point, assign a helper to a namespace the module provides and we can use thast | 17:00 |
| rick_h_ | jcsackett: sorry :( | 17:00 |
| rick_h_ | lol, point point...after the "paste point" | 17:00 |
| teknico | gary_poster, yes, with that change make test-debug worked thrice out of three | 17:00 |
| jcsackett | rick_h_: so to be clear, we'll just update Y.prettify.prettyPrint to take code and container? | 17:00 |
| gary_poster | teknico, for your first and last error I'm guessing that's just because you have the test server already running. For the rest...I dunno. | 17:00 |
| gary_poster | yay teknico! | 17:01 |
| jcsackett | hatch, you good with that idea? | 17:01 |
| teknico | gary_poster, shall I commit to the code? pretty please? :-) | 17:01 |
| gary_poster | OK, you are trying to submit, right? see if it works now | 17:01 |
| gary_poster | teknico, yes :-) | 17:01 |
| rick_h_ | jcsackett: so in https://codereview.appspot.com/7762045/patch/11001/12004 add a helper function on the ns | 17:01 |
| rick_h_ | ns.render_to_node(node, code) kind of thing | 17:01 |
| jcsackett | rick_h_: ok. | 17:02 |
| hatch | jcsackett, sure - it wasn't my intention to say your approach was wrong, just pointing out an alternative approach | 17:02 |
| hatch | I'll let you go whichever approach you feel best suits your task | 17:02 |
| jcsackett | hatch: well, but if we're going to object.create, there's the questino of do we even need the object. | 17:02 |
| rick_h_ | jcsackett: definitely still check out Object.create though, good stuff :) | 17:02 |
| jcsackett | when i was thinking we stored the code, we needed an object. i think after rick's suggestion it's clear we just need a fn. | 17:02 |
| hatch | that's valid - I don't know the end goal of what you're doing :) | 17:02 |
| hatch | gary_poster, FYI while Ben fights with the CI issues I have taken over the NS router issues - first step is to convert it into an extension, so that's what I'm working on now | 17:03 |
| gary_poster | cool hatch sounds good | 17:05 |
| teknico | ooh, branch landed, coool :-) | 17:08 |
| teknico | I'm buying a faster computer anyway ;-) | 17:09 |
| rick_h_ | teknico: has the right of it. If tests are too slow, need a faster ssd and more ram! | 17:10 |
| hatch | lol faster ssd | 17:11 |
| teknico | nope, not OCZ, not going there :-P | 17:11 |
| * hatch has an OCZ ssd | 17:11 | |
| hatch | it was the cheapest :P | 17:11 |
| teknico | "OCZ: the MySQL of storage" | 17:11 |
| hatch | rofl | 17:11 |
| hatch | so does that mean 'general use and reliable' ? ;) | 17:12 |
| teknico | not exactly :-) | 17:12 |
| rick_h_ | intel or bust! :P | 17:12 |
| hatch | haha | 17:12 |
| teknico | it means "gimme speed now! who cares if your data will be there tomorrow?" | 17:12 |
| gary_poster | writing to /dev/null is pretty fast, I think | 17:13 |
| hatch | good thing I have a 3tb synology nas with it's own backup ;) | 17:13 |
| hatch | gary_poster, lol | 17:13 |
| === matsubara-lunch is now known as matsubara | ||
| gary_poster | hatch, bcsaller would appreciate a review of https://codereview.appspot.com/7703047 when you get a chance. This is the GUI code needed to get the charm to behave as I think we want. | 17:27 |
| * gary_poster lunches | 17:27 | |
| hatch | okee | 17:28 |
| bac | guihelp: anyone have time for a quick review of my gui-only 'get service' branch? https://codereview.appspot.com/7777045/ | 17:30 |
| bcsaller | bac: on it | 17:31 |
| bac | thx | 17:31 |
| bac | i'm reviewing gary_poster's. don't see a card for it. | 17:31 |
| hatch | bac, yep I can do that | 17:33 |
| bac | thanks hatch | 17:34 |
| hatch | bac, review done! | 17:40 |
| bac | thanks hatch | 17:47 |
| hatch | gary_poster, review done! | 17:48 |
| gary_poster | thanks hatch, bac, and bcsaller! | 17:48 |
| bac | bcsaller & hatch, thanks for your review comments. it isn't clear to me what you suggest we do wrt the bind. if not 'this' then what? | 17:57 |
| bac | if not now, when? if not us, who? | 17:57 |
| bcsaller | bac: I think we should document that 'this' isn't meaningful to the callback, its most likely not whats expected | 17:58 |
| bac | bcsaller: since the context is not used in the callback, can i just pass null? | 18:00 |
| bcsaller | bac: I don't think so, no, its just worth noting in the docs I think. | 18:01 |
| bac | bcsaller: null works...at least in the tests | 18:01 |
| bcsaller | bac: I guess that would make it clear, this.<anything> will fail for the most part now | 18:02 |
| bac | yep | 18:02 |
| bac | i'll document it too | 18:02 |
| bac | i just thought we needed to bind *something* | 18:03 |
| gary_poster | bcsaller, the CI tests are with trunk, right? Not the most recent release? | 18:04 |
| gary_poster | that would seem like the right place to start :-) | 18:04 |
| bcsaller | gary_poster: they will be, if you look in the CI config you can see the custom branch we're using pre-merge | 18:05 |
| gary_poster | bcsaller, ok cool thanks | 18:05 |
| hatch | lunching | 18:06 |
| benji | wierd, the go regex library does a "search" when you ask for a "match" and there is no way to actually get a "match" | 18:10 |
| bcsaller | at least I see whats happening with the CI test now, that too way too long to figure out | 18:10 |
| bcsaller | benji: it doesn't support ^ at the start? | 18:10 |
| benji | bcsaller: it does, but that also means that you are forced to use them, making combining regular expressions harder (you have be continually stripping off or adding on ^ and $) | 18:11 |
| bac | white smoke! | 18:12 |
| bac | how long until the cathedral bells start up? | 18:12 |
| bac | guess the bishop here doesn't have the NYT app | 18:13 |
| benji | bac: I assume that means there is white smoke somewhere in the world. | 18:14 |
| bcsaller | at least I see whats happening with the CI test now, that too way too long to figure out. Not sure how to properly handle it either | 18:17 |
| bcsaller | hatch: got a second to talk through this? | 18:17 |
| bac | and the bells have started | 18:17 |
| hatch | sure one minute let me get to my comp | 18:17 |
| hatch | white smoke...bells? what are our CI tests passing? :P | 18:18 |
| bac | yes, saucelabs is going old school | 18:18 |
| hatch | lol | 18:18 |
| hatch | bcsaller, ok in guichat? | 18:18 |
| bcsaller | I am | 18:18 |
| rogpeppe | benji: you could always do a FindIndex and check that the returned indexes cover the whole string | 18:19 |
| benji | rogpeppe: that is a possability. | 18:19 |
| rogpeppe | benji: unfortunately that assumes that the regexps match with leftmost-longest, which i don't think they do. | 18:20 |
| rogpeppe | benji: (you can get that functionality in tip, but that won't help much) | 18:20 |
| rogpeppe | benji: in general, i just add ^ and $ as appropriate | 18:21 |
| bac | gary_poster: did you check uistage after landing your branch? it's dead now...one of us did it. :) | 18:28 |
| gary_poster | bac, no, thanks and sorry. almost certainly me, with a conflict in config. will look | 18:29 |
| bac | gary_poster: i've done it | 18:30 |
| bac | restarting now | 18:30 |
| gary_poster | thank you bac. conflict? | 18:30 |
| bac | it was you. :) i meant to add a reminder during the review but forgot | 18:30 |
| gary_poster | :-) | 18:30 |
| gary_poster | sorry and thanks again. my "card" was the charm card, since that's what this is for, but should have made another. | 18:31 |
| bac | happy now | 18:31 |
| gary_poster | yay | 18:31 |
| hatch | ugh it's getting warm enough for the door to door sales people | 19:33 |
| * hatch hopes for -40 again | 19:33 | |
| rick_h_ | lol | 19:33 |
| rick_h_ | interesting, -40C == -40F? | 19:33 |
| hatch | yeah - see at -40 even Americans know to stay the F inside | 19:33 |
| hatch | rofl | 19:33 |
| hatch | oh sometimes I crack myself up :P | 19:34 |
| rick_h_ | it was -5C earlier...had some fun ice on the way to day care | 19:34 |
| hatch | around freezing is the worst because then you get black ice | 19:34 |
| rick_h_ | woot, up to a light and sunny -2.5C | 19:34 |
| hatch | at least when it's really cold the ice isn't hidden | 19:34 |
| rick_h_ | hatch: yea, right at the end of the subdivision I got to keep on going wheeeee | 19:34 |
| hatch | haha | 19:34 |
| rick_h_ | I now know the new car can make it in/out of a ditch nicely :) | 19:35 |
| hatch | lol - no car can get out of a ditch here unfortunately | 19:35 |
| hatch | usually a couple feet of snow in them | 19:35 |
| hatch | My real question is....who goes door to door at 1:30PM? Don't they know people work during the day? | 19:37 |
| benji | casing the joint? (most home burglaries happen during the day when no one is home) | 19:43 |
| hatch | entirely possible | 19:45 |
| hatch | My guess is that they were from one of the many churches in the area | 19:47 |
| hatch | I think there are 5 different kinds within a mile or so | 19:47 |
| hatch | actually there are 3 all on the same corner | 19:48 |
| hatch | well...intersection | 19:49 |
| benji | hrm, go doesn't have negative indexing (i.e., my_string[:-1]) | 19:53 |
| hatch | that's a good thing...no? | 19:57 |
| hatch | wait, nm I misread | 19:57 |
| hatch | :) | 19:57 |
| bac | gary_poster: i went ahead and moved the "'deploy' in juju-core" card. if rog wants retroactive changes i'll have to do another card anyway to avoid confusion | 20:12 |
| gary_poster | +1 bac | 20:12 |
| hatch | hmm 64 failures after moving the ns routing code into it's own module | 20:17 |
| hatch | me thinks the tests r broken ;) | 20:17 |
| hatch | oh 52 this time.... | 20:18 |
| hatch | hmmm | 20:18 |
| hatch | and now 2 | 20:18 |
| * hatch is confused | 20:18 | |
| hatch | ok it looks like it's decided on 2 | 20:19 |
| hatch | Makyo, did you ever figure out how to get console logs working in mocha? | 20:32 |
| Makyo | hatch, Didn't have time to look into it, sorry :/ | 20:32 |
| hatch | no problem | 20:32 |
| hatch | yay they all pass | 20:35 |
| bac | call me crazy, but i don't think this file should be in our tree: state/api/apiserver.go.THIS | 20:35 |
| gary_poster | CRAZY! | 20:35 |
| bac | doh | 20:35 |
| hatch | you're crazy! | 20:35 |
| hatch | haha | 20:35 |
| hatch | oh I was too slow | 20:36 |
| bac | oh, i know, to regain sanity i'll check in OTHER too | 20:36 |
| gary_poster | lol | 20:36 |
| hatch | does the file actually end in an uppercase THIS ? | 20:36 |
| Makyo | That's how bzr does conflicts. You get a THIS, OTHER, and BASE | 20:37 |
| Makyo | But you can bzr revert state/api/apiserver.go.THIS if you get a conflict. Just ran into that. | 20:38 |
| Makyo | s/revert/resolve | 20:38 |
| hatch | ohh I knew that | 20:38 |
| hatch | I swear! | 20:38 |
| Makyo | I was gettin " Conflict adding file state/apiserver/api_test.go.BASE. Moved existing file to state/apiserver/api_test.go.BASE.moved." and resolve fixed that, FWIW | 20:38 |
| Makyo | On a bunch of files. | 20:39 |
| Makyo | Happened when I switched without committing | 20:39 |
| * Makyo rambles. Could go on for hours. | 20:40 | |
| hatch | my computer jumps about 15C when I lbox propose haha | 20:41 |
| hatch | could I get a review of https://codereview.appspot.com/7757046/ plz it's about a 1000+ln diff but most of that is copy/paste | 20:44 |
| hatch | I lied, I'm that good and wrote 1000 lines of code today | 20:45 |
| gary_poster | :-) | 20:45 |
| hatch | haha | 20:45 |
| gary_poster | I'm looking hatch, while waiting on the charm...again... | 20:45 |
| hatch | gary_poster, are you deploying it on canonistack? | 20:46 |
| hatch | and thanks | 20:46 |
| gary_poster | hatch, no, ec2. but the tests run, and then they fail, and that took half an hour, and you don't really have diagnostics, so you have to bring the charm up again outside of the tests and investigate, which takes time, and then everything is fine, so you try a different configuration, which takes time...I'm just complaining :-) | 20:47 |
| hatch | haha yup, that's what we were doing during the sprint | 20:47 |
| hatch | it takes a toll....mentally | 20:48 |
| hatch | haha | 20:48 |
| gary_poster | hey hatch, you up for a call? I think I understand everything in your branch...well, almost everything :-P...but I want to ask some questions. guichat? | 21:07 |
| hatch | yeah sure | 21:13 |
| hatch | Makyo, ol buddy ol pal.... any chance I could get a review on my nsRouter > extension branch? :-) | 21:25 |
| Makyo | hatch, need to walkadoggy, can it wait until I get back? Still have an hour and a half until EOD | 21:25 |
| hatch | oh yeah for sure | 21:25 |
| hatch | :) thanks | 21:26 |
| Makyo | Back in a few, then. | 21:26 |
| hatch | jcsackett, review done! | 21:29 |
| jcsackett | hatch: thanks! | 21:29 |
| hatch | bcsaller, were you successful with the ip caching method? | 21:32 |
| bcsaller | hatch: I might be, its take a couple rounds to get right, it wasn't passing through the env properly before | 21:37 |
| hatch | ahh, yeah it's such a slow moving process | 21:52 |
| hatch | thanks for the review Makyo | 22:08 |
| Makyo | Thanks for the branch :_ | 22:08 |
| Makyo | :) | 22:08 |
| hatch | hmm what's the process for resolving lbox merge conflicts? Was it merge in trunk first then submit? | 22:40 |
| gary_poster | yes hatch | 22:40 |
| hatch | ok thanks, just wanted to confirm | 22:40 |
| hatch | does anyone know of any 'build your own website' services that are any good? | 22:51 |
| hatch | person I know is looking to put together a quick site for a rental | 22:51 |
| gary_poster | hatch http://www.squarespace.com/ may be more than what the person wants but I had good luck with them for a friend | 22:54 |
| hatch | great thanks I'll pass that off | 22:57 |
| hatch | the only thing I had was templatemonster.com + wordpress host | 22:57 |
| hatch | :) | 22:57 |
| gary_poster | :-) | 22:58 |
| gary_poster | hatch, what's the rietveld for your CI doc branch? Don't see it on card | 22:59 |
| hatch | it wouldn't rietveld it kept giving me errors about a diff | 22:59 |
| hatch | I manually requested a merge - I'll grab the link | 22:59 |
| hatch | https://code.launchpad.net/~hatch/juju-gui/ci-documentation/+merge/153165 | 23:00 |
| hatch | I think I will make a couple small changes though | 23:00 |
| hatch | I want to add a link to the wiki with our u/p's for the various services | 23:00 |
| gary_poster | ok hatch, lemme know when that's up and will review. maybe not tonight. :-) | 23:01 |
| gary_poster | charm landed btw | 23:01 |
| hatch | great! | 23:01 |
| === arosales1 is now known as arosales | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
