/srv/irclogs.ubuntu.com/2013/03/15/#juju-dev.txt

davecheneyarguably this function is serving two masters00:00
davecheneyso there will be some uglyness00:00
wallyworld_thumper: tests pass in raring now :-D https://code.launchpad.net/~wallyworld/juju-core/fix-raring-tests/+merge/15348801:14
thumperwallyworld_: seriously?01:14
thumperyou're my hero if it works01:14
* thumper grabs the branch01:14
wallyworld_thumper: works for me, ymmv01:15
wallyworld_i had the same issues as you, so easy to see it was fixed or not01:16
* thumper wonders if his raring branches for goamz and goose are recent enough01:18
thumperI'd love not to have to work in that VM01:19
thumperit is a PITA01:19
wallyworld_thumper: i have goose trunk (tip) and whatever goamz i got a while ago and it's all good for me01:19
davecheneywallyworld_: thumper i fixed all the issues I could find in atlanta01:19
davecheneynobody can replicate your git problem01:19
davecheneywhich is le shit01:19
* wallyworld_ can01:19
davecheneyORLY01:19
thumperdavecheney: wallyworld_ has01:20
wallyworld_davecheney: https://code.launchpad.net/~wallyworld/juju-core/fix-raring-tests/+merge/15348801:20
davecheneyther was the one with the message difference01:20
wallyworld_fixed :-)01:20
wallyworld_fixed too01:20
* wallyworld_ now has a clean test run under raring01:20
thumperdavecheney: I think https://codereview.appspot.com/7809043/ is ready now01:21
davecheneythumper: ta01:21
thumperwallyworld_: umm... your tests have hung01:25
wallyworld_some do take a while for me01:25
thumpergo test ./... is hanging01:25
wallyworld_but they always have01:25
wallyworld_the uniter ones take ages01:25
thumperthis has been over 5 minutes01:25
thumperand stuck in one place01:25
thumpernormally faster than that for me01:25
wallyworld_which place?01:25
thumperwhatever comes after cmd/charmload01:26
thumperwhich may not be where it is stuck01:26
wallyworld_the changes are/should be very unobtrusive01:26
thumperas it is using buffered i/o01:26
wallyworld_just setting some env vars01:26
wallyworld_mine has always "stalled" after charmload01:26
wallyworld_even before the changes01:26
wallyworld_thumper: these ones for me always take a while01:29
wallyworld_ok      launchpad.net/juju-core/cmd/juju        65.754s01:29
wallyworld_ok      launchpad.net/juju-core/cmd/jujud       38.378s01:29
wallyworld_they are logged always just after charmload01:29
wallyworld_also these01:30
wallyworld_ok      launchpad.net/juju-core/state   29.673s01:30
wallyworld_?       launchpad.net/juju-core/state/api       [no test files]01:30
wallyworld_ok      launchpad.net/juju-core/state/api/params        0.006s01:30
wallyworld_ok      launchpad.net/juju-core/state/apiserver 59.152s01:30
wallyworld_ok      launchpad.net/juju-core/worker/uniter   67.571s01:30
thumperI'm pulling latest bits, and will try again01:31
thumperyour branch doesn't look wrong01:31
thumpermust be something else01:31
wallyworld_did you try rerunning?01:31
wallyworld_thumper: funny, i just ran the juju tests with gocheck.vv and it took ~40 seconds even with all the extra trace, as opposed to 65s above01:32
* thumper runs with gocheck.vv01:33
wallyworld_you can't to that at the top level and recurse afaik01:33
davecheney.vv == vroom vroom ?01:33
thumpertheoretically .vv means unbuffered I/O01:33
thumperbut I think it lies01:33
thumpervery verbose :)01:33
wallyworld_yeah01:33
thumperseems to be stuck in the same place01:33
thumpernormally the command tests use all my cores01:33
thumperbut running at virtually 5%01:34
wallyworld_blocked on i/o i guess01:34
thumperno, just not doing anything01:34
davecheney*cough* sleep *cough*01:34
thumperwallyworld_: have you tested in raring?01:34
davecheneyback in lisbon a lot of test failures were hit with the sleep hammer01:35
thumperbecause this is broken for me01:35
wallyworld_thumper: i am running raring01:35
thumperhmm...01:35
wallyworld_and i could reproduce you git failures01:35
thumperwondering if I've hit a different race condition01:35
* thumper has a fast machine01:35
* wallyworld_ has a slower machine and a smaller penis01:35
wallyworld_thumper: maybe try and underclock your cpus and see what happens?01:36
thumperwallyworld_: how would I do that?01:36
wallyworld_power settings - battery mode?01:37
wallyworld_or cpu greq select?01:37
wallyworld_freq01:37
thumperhmm...01:37
thumperpoos01:37
thumperstill stuck01:37
thumperkilled it01:37
thumperat 5 minutes of wall time01:38
thumperI wish there was a way to send it a signal and get it to dump where it was at01:38
wallyworld_yeah01:38
wallyworld_maybe paste the vv output?01:38
thumpernothing to see01:38
thumper?   launchpad.net/juju-core/cmd/charmload[no test files]01:39
thumperthat was the last output01:39
thumperdavecheney: should I have any mongod process running after the tests have finished?01:39
thumperI have one01:39
thumpershould I kill it?01:39
wallyworld_thumper: you need to cd to just the juju tests01:40
wallyworld_to use gocheck.vv01:40
wallyworld_since ./... and gocheck args don't work together01:40
thumperseriously?01:40
* thumper sighs01:40
thumperwhich ones were failing before/01:40
thumper?01:40
wallyworld_thumper: the git tests01:41
wallyworld_are the easiest to see01:41
davecheneythumper: no, but they do leak01:41
wallyworld_also the uniter ones01:41
wallyworld_and deployer ones01:41
davecheneyi go thought and clean them up01:41
davecheneyor learn not to ^C the tests01:41
wallyworld_davecheney: question, this had be stumped - cmd/jujud/unit_test.go:20: s.agentSuite.SetUpSuite(c)  <--- i had to add this and didn't know why the call just didn't drop through01:42
wallyworld_why does aliasing the import fix it?01:42
* davecheney scrolls back to find the CL01:43
davecheneywallyworld_: it's not aliasing01:43
davecheneyhang on01:44
davecheneywhich file are we talking about ?01:44
wallyworld_unit_test.go01:44
wallyworld_i misread the diff a bit01:44
thumperwallyworld_: stuck here http://pastebin.ubuntu.com/5615399/01:44
wallyworld_davecheney: you wanted testing.GitSuite renamed to GitSuite01:45
davecheneywallyworld_: right, sorry was looking at wrong CL01:45
davecheneyit's not renaming, it is giving it a name01:45
davecheneyat the moment both fields in the struct are anonymous01:45
davecheneywhich embeds them01:45
wallyworld_but i don't understand why that is needed and why i had to add the explicit call throughs01:45
davecheneyhowever that creates and ambiguity on who defines the embedded UnitSuite.SetUpSuite01:46
wallyworld_thumper: you have thr wrong mongo01:46
thumperah... wat?01:46
wallyworld_thumper: you need to install the one from the tarball and set your path to that one01:46
wallyworld_thumper: since ssl is not supported in the packaged version01:46
davecheneythumper: yes, don't use mongo 2.0 from raring01:46
thumperInstalled: 1:2.2.3-0ubuntu101:47
wallyworld_and something about lawyers says we can't add ssl01:47
davecheneythumper: bzzt, that one does not have ssl enabled01:47
thumperwallyworld_: I think the lawyers are still arguing01:47
thumperclucking bell01:47
thumperjuju dev sucks the big kumara01:47
wallyworld_yeah, sucks balls01:47
thumperdidn't bigjools have a ppa somewhere01:47
wallyworld_this is out of our control sadly01:47
thumperI don't like the tar ball answer01:47
wallyworld_yes, believe so01:48
davecheneywallyworld_: by giving testing.GitSuite a name, you break the ambiguity01:48
bigjoolsI do01:48
thumperwallyworld_: nothing is out of our control01:48
thumperwe control EVERYTHING01:48
thumperbigjools: you may need to rebuild01:48
thumperbigjools: plzfix01:48
* davecheney contols both the horizontal and the vertical01:48
wallyworld_davecheney: ah thanks, i 'll re-read the code with that though in mind. i need to think about it so i fully grasp it01:48
bigjoolsthumper: hmmm?01:48
davecheneythumper: that osn't bigjools' version, it's coming from raring01:48
davecheneywallyworld_: no worries01:48
bigjoolsmine has SSL01:49
thumperyeah.. I know01:49
thumperbigjools:  needs to make a new one01:49
bigjoolspebkac01:49
davecheneythe other part of the solution is, when you embed a structure, its field name is the name of the structure01:49
bigjoolsthumper: what's up with it?01:49
thumperhmm...01:49
wallyworld_thumper: so now you can +1 my mp when i fix davecheney's issues01:49
davecheneyso by naming testing.GitSuite, GitSuite, none of the rest of the code notices, as that was what it called it originally01:49
wallyworld_:-)01:49
thumperperhaps the ppa has been disabled01:49
davecheneythumper: bigjools packaged 2.2.201:50
bigjoolsapt-cache policy .... tells you all01:50
davecheneyraring offers 2.2.301:50
davecheney^ sorta guess01:50
thumperand the ppa was disabled on upgrade01:50
thumperbigjools: make a new one and I'll buy you a beer01:50
* wallyworld_ is glad he just used the barball01:50
wallyworld_tarball01:50
bigjoolsarf01:50
davecheneywallyworld_: right first time01:50
wallyworld_hah01:51
thumperbut I don't want to use the dumb tarball01:51
davecheneymy favorite mongo feature is the 60hz timer it sets up01:51
thumperwallyworld_: where are the instructions?01:51
davecheneyspecifically to waste your battery01:51
davecheneythumper: they _should_ be in the README01:51
* davecheney scratched head01:51
wallyworld_thumper: not sure, i just figured it out - untar to /opt (say) and update yuor path01:51
thumperit just feels SO wrong, that I'm resisting01:52
davecheneythumper: they would ahve to be in the README (checking)01:52
thumperuntil we get a better solution01:52
davecheneywe onboarded so many juju devs in Atlanta01:52
* bigjools agrees with thumper01:52
* wallyworld_ agrees too01:52
wallyworld_but we encountered some resistence trying to change it01:52
* davecheney also agrees, but points the phalanax of lawyers that lie between us and our desired solution01:53
* thumper gathers all his toys in one corner01:53
bigjoolsyeah I only built for quantal01:53
davecheneybigjools: that would be it01:53
bigjoolsI'll do another01:53
thumperbigjools: awesome, ta01:53
thumperdavecheney: who can I poke to make this go faster?01:54
thumperthere is that long email thread01:54
thumperbut I'm prepared to go higher01:54
* thumper is sick of it01:54
davecheneythumper: antonio and jamespage have identified themselves as the owner of the issue01:54
bigjoolsgo thumper, go thumper, go thumper.... oooo yeaahhhh go girl01:55
davecheneythe last status update I got said they were waiting on 10gen to do something for them01:55
* thumper goes to look them up on the direcdtory01:55
davecheneyso, we're waiting on the good graces of the 10gen lawyers01:55
davecheneyGLWT01:55
thumperdavecheney: in which cases they'll be waiting forever01:55
davecheneyexactly01:55
thumper...01:55
davecheneythumper: are you cc'ed on that email thread01:56
thumperdavecheney: yeah, and I'm about to reply and start kicking tires01:56
davecheneygo thumper go01:56
thumperok, it seems that james did create a version for raring, but it has been superseded by the raring release02:01
* thumper emails everyone02:02
bigjoolsthumper: an ssl version?02:02
thumperyeah02:02
thumperaccording to the email02:02
bigjoolsI'll build anyway02:02
bigjoolshmmm02:05
thumperbigjools: how long will it take?02:06
bigjoolsthumper: iirc about 30-60 mins02:07
thumperok... I'll wait02:07
thumperand use your one02:07
* bigjools can bump ppa priority :)02:07
thumper\o/02:07
bigjoolsin fact there's a little know changelog trick to get more priority too02:07
bigjoolsknown*02:07
wallyworld_davecheney: thanks for the review - with the empty SetupSuite() methods, I cargo culted those from elsewhere. So I guess those other places should be fixed too at some point02:19
davecheneywallyworld_: stick a card in leankit to refactor that shit02:20
wallyworld_will do02:21
davecheneythe contract for gocehck.Suite() takes an interface{}02:21
davecheneyso there is no requirement for every Suite to have those methods02:21
davecheneythey are only needed if used02:21
davecheneyand empty ones dont' really help02:21
davecheneyapart from that, get thumper to LGTM02:21
wallyworld_yeah, i thought so too, but figured it must have been needed for some reason/convention02:21
davecheneythen you'll be in sweet sweet raring heaven02:21
wallyworld_oh yeah :-)02:22
davecheneywallyworld_: i think you were right wen you said cargo cult02:22
wallyworld_it happens if one is a bit unsure when implementing something and one assumes that what was done before was correct :-)02:22
wallyworld_and yet we have two +1's required02:23
wallyworld_so it seems stuff still slips through02:23
davecheneywallyworld_: i don't think you want to argue for quorum on a change request02:25
davecheney:)02:25
wallyworld_sure :-) but my point is with two reviewers, perhaps "obvious" stuff could be caught02:25
davecheneybuddha says "when arguing with loved ones, don't bring up the past"02:26
wallyworld_not meant to be negative, just an observation02:27
davecheneyan observation well made02:27
wallyworld_davecheney: i only found one place to fix as it turns out - LoggingSuite has empty Setup/TearDownSuite() and a few calls to those - i'll just fix it up as a drive by02:37
davecheney+102:37
wallyworld_thumper: as soon as you +1 my mp, i can land the raring test fixes :-)02:37
thumperlink?02:38
bigjoolsthumper: it's building https://launchpad.net/~julian-edwards/+archive/mongodb/+packages02:39
wallyworld_thumper: https://codereview.appspot.com/7677044/02:41
thumperwallyworld_: acked02:42
thumperdo it02:42
thumperland it02:42
thumpernow02:42
wallyworld_\o/02:42
wallyworld_thumper: just doing a quick driveby to remove some redundant code, will be done in a few minutes02:43
* davecheney away -- lunch02:48
wallyworld_davecheney: i've removed the empty setupsuite stuff, but am thinking - perhaps it was done that way so that stuff could be added if required without needed to then go and add setupsuite calls to all the structs which embedd the logging test suite02:49
davecheneywallyworld_: maybe leave the drivebys for another day02:51
wallyworld_yeah, i just reverted them :-)02:51
davecheneyi'll just leave this here http://www.youtube.com/watch?v=Ktbhw0v186Q02:51
davecheneyafk for reals this time02:51
wallyworld_you are a sadistic man02:52
bigjoolsthought it was going to be a rickroll02:53
wallyworld_or worse02:53
wallyworld_thumper: can you feel it?02:59
thumpercan I feel what?02:59
bigjoolshaha02:59
wallyworld_that's not the first time someone has said that to me03:00
* bigjools lunches03:00
wallyworld_thumper: if you give it a oull, it will come03:00
wallyworld_pull03:00
bigjools...03:00
wallyworld_the raring test fixes i mean03:00
jtv1oh03:00
jtv1not his lunch?03:00
=== jtv1 is now known as jtv
wallyworld_you all have dirty minds03:00
thumperwallyworld_: I need bigjools's mongo branch first03:01
bigjoolswell given who was saying it ...03:01
thumperand I'm kinda busy actually working03:01
wallyworld_sure, just letting you know :-)03:01
jtvwallyworld_: except Julian, who has dirty hands.03:01
wallyworld_lol03:01
* bigjools wipes03:01
jtv...03:01
wallyworld_bigjools: on the curtains?03:01
jtvThat's it.  No food for me this lunchtime.03:02
bigjoolsthumper: at least 30mins left to build03:02
bigjoolsit takes an hour03:02
* bigjools heads off03:02
jtvMeanwhile, a question for the juju experts: we need to implement EnvironProvider.InstanceId() for the maas provider, but the EnvironProvider has no idea what maas it's supposed to talk to.03:02
jtvIt's not like the ec2 provider where you have a fixed IP address for the metadata service.03:04
wallyworld_jtv: in the vm world, it is the machine id on which the provider is running03:04
jtvSo... the bootstrap node?03:04
wallyworld_yeah03:04
wallyworld_and others too i think03:05
jtv:(03:05
wallyworld_the id is used to update the state03:05
wallyworld_so the agent can see that the machine has been provisioned03:05
wallyworld_i think03:05
jtvThe fact that the method lives on EnvironProvider suggests that no provider needs to be running.03:05
jtvOtherwise it'd be on Environ, where we have a real chance of getting the information required.03:05
wallyworld_yes03:05
wallyworld_this is done before that happens03:06
jtvDamn.03:06
wallyworld_on ec2 and openstack, there's the metadata service03:06
wallyworld_which provides this03:06
jtvOn MAAS too, but at this point we don't know its address.03:06
wallyworld_:-(03:06
wallyworld_i *think* the update of the state can be delayed03:07
wallyworld_till the provider starts03:07
wallyworld_but you'd need to talk to william03:07
jtvpleasesaygrantpleasesaygrantpleasesaygrant03:07
* jtv is in a timezone far, far from the UK03:08
wallyworld_readereadereadereade03:08
jtvbuggerbuggerbuggerbugger03:08
wallyworld_the main other person who would know is also in the uk03:08
thumperhaha03:08
jtvuk...  ISO country code for:03:08
jtvUkraine03:08
jtvThat helps03:08
thumperno it isn't03:08
jtv?03:09
wallyworld_i meant england03:09
jtvgb == united kingdom of great britain & northern ireland03:09
jtvwallyworld_: I figured.  Just doing some wishful thinking03:09
wallyworld_jtv: right now, i can't see why it has to be the environprovider which provides that info - i think some refactoring could fix the problem03:10
wallyworld_but i don't fully appreciate the finer details of the workflow to offer practical advice and understanding of the consequences03:11
jtvThat would mean the world to us at this stage.  We're currently stuck on this.03:11
wallyworld_jtv: maybe send an email to the list - william is good at responding03:11
jtvYes, he is.  Thanks, I'll do that.03:12
wallyworld_hopefully can be sorted for next week03:12
jtvWe have until...  This evening.  :/03:14
jtvI'm putting together the email now.03:14
bigjoolsjtv: iso country codes are fucked03:23
* bigjools relurks03:24
thumperjtv: UKRAINE   A2 = UA    A3 = UKR04:13
thumperjtv: however UK is not a 2 character country code for anything04:14
jtv!04:14
jtvDamn.04:14
jtvWell, I apologize.04:14
* thumper was bored so looked it up04:14
thumpergiven that domains for the uk finish with .uk04:15
thumperyou'd think it was the iso code04:15
thumperbut you were right on the .gb04:15
thumperwhich I don't think anyone sues04:15
thumperuses04:15
thumperjtv: perhaps ukraine and UK got together and agreed that neither should have 'UK'04:15
thumperjust to piss everyone off04:15
davecheneythumper: you asked for it, http://www.youtube.com/watch?v=rNu8XDBSn1004:16
thumperdavecheney: that's ok04:16
thumperdavecheney: I did think for a minute that you were rick rollingme04:16
davecheneydidn't the ukraine used to be called something else ?04:16
thumperdavecheney: like the USSR?04:16
davecheneythats the one04:17
thumperbefore it got broken into little pieces04:17
jtvWell they were a republic within the USSR.04:17
jtvNot an "independent republic" — those were parts of Russia and did not have the theoretical right of secession.04:17
* davecheney does not want to give the northern territory it's own top level domain04:17
jtv.aunt?04:18
davecheneynext thing you know we'd give QLD .xxxx04:18
jtv?04:18
davecheneyhttp://www.xxxx.com.au/04:19
jtvPhew.  I was taking a risk by loading up that one...04:20
jtvA neighbour had a visit from the MIB about having looked at Wikileaks.04:20
jtvBut this ain't so bad.  :)04:20
thumperwhich leads me to the joke: why do australians put four X's on their beer?04:21
davecheneyjtv: GTFO04:21
thumpera) because they can't spell beer04:21
jtvSounds good.  Go on.04:21
davecheney? there is a second answer ?04:21
thumperjtv: seriously, MIB?04:21
jtvWell no, I don't know what they were actually wearing.  But they were from the government and they were not friendly.04:21
thumperI heard that amazon have bought up .book .author and something else04:21
thumperwow04:22
davecheney.cloud ?04:22
thumperdon't recall04:22
thumperbigjools: built?04:22
jtvI always wanted to have to gov't agencies visi and ostro here: ostro.go.th & visi.go.th.04:22
davecheneyi remember the freeforall back in '98 when you could buy a $.com without having to own the trademark04:22
* bigjools points thumper to the fine url from earlier04:22
* thumper scrolls back looking for the url04:23
bigjoolspublished an hour ago04:25
bigjoolsmmm lunchtime dip in the pool was very nice04:25
thumperhmm...04:29
thumperdoesn't fix the problem04:29
thumpertests still sit doing nothing04:29
wallyworld_thumper: error message?04:30
thumper unknown option sslOnNormalPorts04:30
wallyworld_you sure the new one is being used?04:30
wallyworld_that implies it's still using the old one04:30
thumper Installed: 1:2.2.3-0ubuntu2+ssl04:30
wallyworld_hmmm04:31
* wallyworld_ has no idea04:31
thumperhmm, just installed mongodb, think i need the other three package04:31
thumperI thought it would do that04:31
wallyworld_i just untarred the tarball for mine - perhaps everything was included04:31
wallyworld_but i could have sworn there was just a single mongodb dir in there04:32
wallyworld_jtv: you sent your email to the list?04:33
jtvwallyworld_: you didn't see it?  I may have had the wrong email account active.  Let me retry.04:34
thumperwallyworld_: working now04:34
wallyworld_thumper: \o/04:34
wallyworld_what did you change, just install the extra packages04:34
wallyworld_jtv: yeah, didn't see it so thought i'd ask in case you mis sent it04:35
thumperyeah, just also installed mongodb-clients mongodb-dev mongodb-server04:35
wallyworld_it that all?04:35
thumperI thought that installing mongodb would bring in the others04:35
thumperyes04:35
wallyworld_i was trying to be sarcastic :-)04:35
thumperwallyworld_: I do get some failures though04:35
wallyworld_:-(04:35
thumperbut I think they are timing related04:35
wallyworld_so re running, different results?04:36
thumpercmd/jujud OOPS: 29 passed, 1 skipped, 2 FAILED, 3 FIXTURE-PANICKED, 14 MISSED04:36
wallyworld_5 failures, not good04:36
jtvThanks for checking, wallyworld_04:37
wallyworld_np04:37
thumperwallyworld_: is it in trunk now?04:37
thumperI'll get trunk and try again04:37
wallyworld_yah04:37
thumpernope, still failing tests for me04:39
* thumper runs all again and pastebins...04:40
* thumper takes kids to get fud04:40
wallyworld_pastebin?04:44
* wallyworld_ off to parent teacher interview, bbiab05:36
rogpeppefwereade: you've got a couple of reviews10:23
fwereaderogpeppe, lovely, tyvm10:23
rogpeppefwereade: i've got the next stage in the allWatcher out for review, if you fancy a look. it's all easy after that one. https://codereview.appspot.com/7594048/10:24
fwereaderogpeppe, I don't think I'll manage to do that properly before this afternoon, I'm a little bit involved with environs at the moment10:57
rogpeppefwereade: np10:57
fwereaderogpeppe, sorry, I had the beginnings of a go, but I need to use all my RAM to understand the whole thing clearly10:57
rogpeppefwereade: thanks. yeah, it's a little bit involved. not bad in the end, i think, but needs some thought.10:58
rogpeppefwereade: i have reasonable confidence it's well tested, at any rate :-)10:59
rogpeppe(that was by no means a backhanded reference to the destroy service tests BTW)11:03
fwereaderogpeppe, haha, np, I didn't take it as such ;p11:20
rogpeppefwereade: are you planning to start designating reviewers,11:25
rogpeppeBTW?11:25
fwereaderogpeppe, mramm has assigned that card to himself11:48
rogpeppefwereade: ah, cool11:48
rogpeppefwereade: i hadn't seen the card :-)11:48
fwereaderogpeppe, dimitern added it, mramm grabbed it -- it's like a well-oiled machine :)11:49
dimitern:)11:49
* rogpeppe was well-oiled last night11:49
rogpeppe:-)11:49
dimiternfwereade: tickets confirmed11:50
fwereadedimitern, awesomeness, tyvm11:50
dimiternfwereade: I'll update the wiki as well11:50
fwereadedimitern, yu rock11:50
dimiternfwereade: no worries :)11:51
dimiternhave you had a chance to look at yesterday's CL ?11:52
dimiternfwereade: ?11:54
fwereadedimitern, whoops, sorry11:55
fwereadedimitern, I don't see it in +activereviews, from what I saw I think it's ready to repropose without -wip11:55
dimiternfwereade: hmm.. I did not specify -wip last time - once you specify it does it stick? -wip=false is needed or smth?11:56
fwereadedimitern, hm, it's just at the bottom of the page for no clear eason11:57
fwereadedimitern, sorry11:57
dimiternfwereade: np11:58
* fwereade lunch12:06
rogpeppedimitern: some code to review, if you wanna: https://codereview.appspot.com/7594048/12:35
dimiternrogpeppe: on it12:42
rogpeppedimitern: thanks!12:42
wallyworld_rogpeppe: fwereade: i'd love a chat on the logging stuff. i hate email exchanges in code reviews, so impersonal12:44
rogpeppewallyworld_: yes, that would be great12:45
fwereadewallyworld_, rogpeppe: sgtm, when is good? now?12:45
rogpeppenow would be good for me12:45
wallyworld_good for me, then i can go to bed12:45
fwereaderogpeppe, wallyworld_: ok, I'll start a hangout12:45
fwereaderogpeppe, wallyworld_: https://plus.google.com/hangouts/_/09c5551027db88904e9a62bd3da34b261f46407b?authuser=0&hl=en12:46
dimiternwallyworld_: fwiw I agree with the suggestions about splitting the syslogd support from log.*f() refactoring and replacing all around the code - it needs to be done carefully12:46
wallyworld_it's already split12:47
mgzcan I join and lurk too?12:47
dimiternwallyworld_: oh, great then12:47
=== wedgwood_away is now known as wedgwood
dimiternfwereade: ping13:54
fwereadedimitern, pong -- sorry, it's still not done, I'm going to have to do reviews after the meeting13:55
dimiternfwereade: ah, the meeting, yes - np13:55
bacrogpeppe: ping14:04
dimiternbac: they have a kanban meeting at the moment14:17
bacdimitern: thanks.  no rush.14:17
fwereaderogpeppe, is https://codereview.appspot.com/7417051/ abandoned?14:39
rogpeppefwereade: no, i'll fix the file close issue and submit14:47
rogpeppefwereade: i think it's still worth doing14:47
fwereaderogpeppe, +114:47
fwereadedimitern, basically LGTM, but the SetCharm move is important, ping me if there's uncertainty14:48
fwereaderogpeppe, how about https://codereview.appspot.com/7610044/ ?14:49
=== wedgwood is now known as wedgwood_away
=== wedgwood_away is now known as wedgwood
rogpeppefwereade: ah, i thought i'd submitted that one.14:56
rogpeppefwereade: it really needs to go in.14:57
rogpeppefwereade: oh, i remember, i started running tests and got diverted14:58
bachi rogpeppe, would you have time to look at a branch that is behaving oddly?  perhaps we could have a hangout to chat.15:03
rogpeppebac: definitely.15:04
rogpeppebac: anytme15:04
rogpeppetime15:04
rogpeppefwereade: both those branches now submitted15:04
bacrogpeppe: it is at https://codereview.appspot.com/761004615:04
fwereaderogpeppe, cheers15:04
rogpeppebac: ha ha, you've got the .THIS deletion too.15:04
bacyep15:05
bacrogpeppe: starting hangout15:05
dimiternfwereade: cheers15:09
rogpeppefwereade: could you join us for a moment to verify some stuff about DestroyRelation, please? https://plus.google.com/hangouts/_/ade743831e17fc93a3d824612a93e8004534fcdd?authuser=0&hl=en15:10
* dimitern lunch15:18
fwereaderogpeppe, bac: working as intended, a unit of wordpress enters scope in setupScenario and thus has a reference to the relation15:49
rogpeppefwereade: ah! of course, that's the difference between the two places15:49
rogpeppefwereade: i'm stupid - i should have realised that15:49
fwereaderogpeppe, took me a little while to twig :)15:50
* fwereade is relieved15:50
rogpeppefwereade: always good to review the code again, eh? :-)15:50
fwereaderogpeppe, yeah :)15:50
fwereadebac, so go ahead and propose -- maybe add a comment to that effect so it's clear for readers15:51
rogpeppefwereade: 115:51
rogpeppe+115:51
fwereadebenji, ping15:56
benjifwereade: hi15:56
fwereadebenji, https://codereview.appspot.com/7460047/ and https://code.launchpad.net/~benji/juju-core/1130173/+merge/151555 don;t agree on whether it's been submitted -- would you look into it please?15:57
benjisure; looking15:57
fwereadebenji, tyvm15:59
benjifwereade: I figured it out.  I had a thinko in which I attempted to lbox propose the wrong branch and it reopened the merge proposal.  I verified that the code is indeed on the trunk and set the MP to Merged.16:00
fwereadebenji, cheers16:00
fwereadeniemeyer, btw you have a couple of approved branches16:07
dimiternI have a panic on store/ tests in trunk, just pulled16:12
dimiternanybody seen this? http://paste.ubuntu.com/5616924/ I'm just about to file a bug16:13
dimiternit's intermittent - I run it again now and it's ok16:14
dimiternI filed bug 1155681 for it16:17
_mup_Bug #1155681: intermittent failure (panic) in store/ tests TestBlitzKey <intermittent-failure> <juju-core:New> < https://launchpad.net/bugs/1155681 >16:17
hatchIs there anywhere that documents the relationship between a LP repo and CS path?16:23
niemeyerfwereade: Thanks!16:23
dimiternfwereade: moving f.SetCharm before fetching the charm in u.deploy() cause the steady state upgrade uniter tests to fail16:46
fwereadedimitern, ah, damn, I expected we'd have missed one of them16:47
fwereadedimitern, I presume they're just using the wrong things to wait for? or seriously broken?16:47
dimiternfwereade: they're waiting in vain for some time and then it timeouts16:48
fwereadedimitern, for what? paste me maybe?16:50
dimiternfwereade: just looking at the log, trying to figure out when.. i'll paste it16:50
fwereadedimitern, cheers16:51
dimiternfwereade: http://paste.ubuntu.com/5617031/16:51
dimiternfwereade: the funny thing (which I've seen before) is, that after that test failed the test runner seems stuck and no more test cases are executed (had to ^C it)16:52
fwereadedimitern, well, that should also be fixed ;p16:52
fwereadehatch, https://juju.ubuntu.com/docs/internals/charm-store.html has the "Publishing a Charm" section; and m_3 might be in a good position to tell you more16:54
hatchfwereade: thanks - rogpeppe actually pointed me to the code responsible as well16:55
hatchthanks16:55
dimiternfwereade: i agree, but it's something to do with how the uniter tests are executed in general it seems - once all pass it's ok, most of the time when one fails others are not affected - it's probably due to the waiting code16:55
fwereadedimitern, ISTM that the tests are waiting for the wrong behaviour -- we did change it a bit16:55
fwereadedimitern, now an attempted upgrade will have the unit's charm set to the target url not the source16:56
dimiternfwereade: yeah, i figured that much16:57
dimiternfwereade: so we need to carefully refactor all upgrade tests16:57
dimiternfwereade: *OR* just pass charm: 1 in waitUnit{} where it gets stuck16:58
fwereadedimitern, yeah, if you look at the following test case I think it's clear the omission is just a bug16:58
dimiternfwereade: :) comments are useful in these cases16:59
dimiternfwereade: running the tests again now16:59
fwereadedimitern, if you can think of a comment that would have helped, please feel free to add one :)16:59
dimiternfwereade: well, not now - but before :)17:00
dimiternfwereade: now all cases are similar (charm: 1) and all17:00
fwereadedimitern, yeah, I think it was just a bug17:00
fwereadedimitern, fundamentally racy, but we were lucky for some reason17:01
dimiternfwereade: adding charm:1 fixed that test, there was another failure in error upgrade tests - same cause, fixed - running again17:02
m_3hatch: currently lp:~<launchapd-id>/charms/precise/<charm-name>/trunk is the required format for it to show up in the store and then be deployed via `juju deploy cs:~<launchpad-id>/<charm-name>`17:03
hatchyeah I am going to file a ticket about that - I would like to be able to deploy a charm right from the repo using an absolute path17:04
m_3hatch: unless you have a compelling reason, stick with LTS charms atm please17:04
m_3hatch: by all means... there was a bug for that somewhere, dunno if it made it to juju-core17:05
hatchI'm working on the gui charm right now so requiring me to deploy to a specific branch isn't ideal - it's doable, just not ideal :)17:05
m_3hatch: we often use a local repo... ~/charms/precise/mycharm is available via `juju deploy --repository ~/charms local:mycharm`17:06
benjihatch: I'm pretty sure there is a way to deploy the charm against a particular branch of the GUI17:07
hatchhttp://paste.ubuntu.com/5617026/17:08
hatchis apparently the code in question17:08
hatchdoesn't look like it17:08
hatchohh gui yes17:08
hatchcharm no17:08
hatchIt's just a minor inconvenience that would be awesome if one could specify an absolute path to a remote branch17:09
m_3+117:09
bacfwereade: thanks for looking.  i'm unclear about your explanation, though.17:10
fwereadebac, ah, I'm sorry17:10
fwereadebac, in setupScenario, we call EnterScope on a RelationUnit for wordpress/017:11
fwereadebac, this mimics the unit agent joining the relation17:11
fwereadebac, and adds a reference to the relation17:11
fwereadebac, I would not be opposed to a setupScenario tweak that immediately leaves scope after entering17:11
bacso there are more parties to the relationship than just the services, thus causing it to hang around?17:11
bacfwereade: ok, i'll investigate doing that17:12
fwereadebac, the reason to enter/leave, rather than to do nothing, is because it's a subordinate relation: subordinate units are created on-demand, when there's a relevant principal participating in the relation17:13
rogpeppefwereade: i wouldn't mind that, i think.17:14
fwereaderogpeppe, cool, I have done that in one or two places in the past17:14
* rogpeppe still doesn't really understand what "entering scope" implies17:14
fwereaderogpeppe, becoming visible to ones counterparts17:14
fwereaderogpeppe, by creating a document whose _id encodes what counterparts ought to be able to see it17:15
rogpeppefwereade: ... and creating subordinates, presumably17:16
fwereaderogpeppe, yes: the txn also includes the creation of a relation unit settings doc; and sometimes a subordinate unit, when one is required for sanity and does not yet exist17:16
rogpeppefwereade: so that's not the usual way that subordinate units get created?17:17
fwereaderogpeppe, that's the only way subordinate units get created17:17
rogpeppefwereade: ah, i misread "required for sanity" then17:17
dimiternfwereade: whoohoo! all passed (after fixing 3 more places with the same issue)17:18
fwereaderogpeppe, the idea is that each principal is entirely responsible for its own subordinate(s)17:18
fwereaderogpeppe, the alternatives are icky17:18
mgzgo dimitern17:18
fwereaderogpeppe, create 100k units when we add a relation?17:19
fwereadedimitern, yay!17:19
rogpeppefwereade: yeah, seems reasonable.17:19
dimiternmgz: I'm very nearly there - go func() {} - multitasking :)17:19
dimiternfwereade: reproposed with the changes, if you think it's ready, I'll submit it (have 2 LGTM from TheMue already earlier)17:20
fwereadedimitern, tbh that first LGTM is no longer valid, there have been a lot of changes17:21
fwereadedimitern, better to work on merging it into the followup and shaking out what you can17:21
dimiternfwereade: yeah, I know - I wanted to ask him again, but it seems he's off today17:21
fwereadedimitern, yeah, back monday17:21
dimiternrogpeppe: maybe you can take a look? https://codereview.appspot.com/742504417:21
rogpeppedimitern: deep in debugging currently, but will do in a short while17:22
dimiternrogpeppe: cheers17:22
rogpeppefwereade, dimitern: here's the next in line in the allWatcher branches; not too far off now: https://codereview.appspot.com/781504417:45
dimiternrogpeppe: will look in 5m17:45
rogpeppedimitern: now looking at your branch17:46
rogpeppedimitern: ta!17:46
dimiternrogpeppe: it seems the diff is screwed17:46
dimiternrogpeppe: (mine, that is) - will repropose it now17:46
rogpeppedimitern: thanks - was just about to say17:46
dimiternrogpeppe: can you see it now?17:47
rogpeppedimitern: yup, thanks17:48
dimiternI suspect this issue occurs when you bzr push (or lbox propose) from a subdir - but don't have enough info to confirm this17:49
rogpeppedimitern: reviewed18:00
rogpepperight, time for me to go18:01
dimiternrogpeppe: tyvm18:01
rogpeppehave a great w/e everyone18:01
dimiternrogpeppe: g'nite!18:01
rogpeppedimitern: toi aussi!18:01
=== wedgwood is now known as wedgwood_away

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!