didrockshey mmrazik!07:17
didrocksmmrazik: FYI https://code.launchpad.net/~robru/webbrowser-app/packaging/+merge/15365007:17
didrocksI think you need to configure CI for it07:17
mmrazikdidrocks: its there.  for some reason the triggering was stuck. I'm using some locking mechanism and there was a stuck process holding the lock (i.e. running but stack)07:20
didrocksok :)07:20
mmrazikthis happened 2nd time in the last several months :-/07:20
didrocksmmrazik: the CI does use some kind of ppa?07:20
mmrazikdidrocks: oh... like a local repo?07:20
didrockslocal repo or ppa07:21
didrocksI would have except that some are failing.07:21
mmrazikdidrocks:  not really... maybe stuff like qt5-propper07:21
nonubyhow do I flip through an apps open windows like alt+tab but app specific (i.e. if i have 5 terminal windows open)07:23
mmrazikdidrocks: btw. the debian/rules is indeed broken in that merge proposal (AFAICS)07:24
didrocksmmrazik: oh? I missed that07:24
didrocksah tab/spaces i guess07:25
mzanettiSaviq: just readin your mail... what you mean with "But the notion of focus is limited to text entry fields." ?09:43
Saviqmzanetti, that in a touch-only interface there is no focusing, other than on a text entry field09:43
mzanettiSaviq: nope...09:44
Saviqmzanetti, with keyboard navigation you focus on items to navigate between them09:44
mzanettiSaviq: xbmcremote is fully navigatable with keyboard only. and there is one textfield in the whole app09:44
Saviqmzanetti, yeah09:44
Saviqmzanetti, of course09:44
mzanettiSaviq: there is always some focused element... touching with your finger just doesn't care about it09:45
Saviqmzanetti, but when you only use a touch interface, you wouldn't know, would you ;)09:45
mzanettiSaviq: infact, touching a mouse element puts the activeFocus to the next wrapping FocusScope09:45
Saviqmzanetti, yes, sure, but still, it doesn't affect a touch-only interface at all, does it09:46
mzanettiSaviq: no... but where do we have a touch-only interface?09:46
mzanettiok... right now the shell probably is :D but that needs to change09:47
Saviqmzanetti, yup ;)09:47
Saviqmzanetti, anyway, I know - the examples could've been better09:48
mzanettiSaviq: I just didn't understand that part...09:48
mzanettifully support everything else in that thread09:48
Saviqmzanetti, and if you guys prove me wrong (i.e. there won't be a use-case where we need to differentiate based on available input)09:48
SaviqI'll be happy as hell ;)09:49
mzanettiSaviq: well, I think there shouldn't. IMO its bad that notifications are click through on the desktop and not on the phone...09:49
mzanettibut thats another discussion again09:49
Saviqmzanetti, I agree09:50
Saviqmzanetti, but click-through on touch would be broken09:50
mzanettiSaviq: its also on the desktop :D09:50
Saviqmzanetti, that's disputable ;)09:50
Saviqmzanetti, but I do agree we need to revisit stuff like that09:51
mzanettiSaviq: I guess what you meant is not that theres no "focus" on touch ui's but rather there's no "onMouseOver" on touch uis. that makes a difference09:52
Saviqmzanetti, no, I meant focus09:53
Saviqmzanetti, as the only things that you do focus are text entries09:53
Saviqeven if behind the scenes focus travels with you09:53
mzanettiSaviq: not agreeing here... first, yes, it travels with you, which makes a difference implementation wise, and second, there are cases where you actually highlight it too - eg. copy/paste09:54
Saviqmzanetti, implementation wise, sure it makes a diff, but that's only when you plan to allow keyboard navigation09:55
Saviqif you don't care about keyboard nav, you don't need focus at all09:55
mzanettithats true... but we do care about that I guess... anyways, we're going round in circles... I think we both have the same opinion on how to handle the whole situation... no need to dispute over wordings :)09:56
Saviqmzanetti, c/p you mean selecting text in a browser? I don't know if I treat that as focus... even with our browser you can select text for c/p without focusing it09:56
Saviqmzanetti, yeah ;)09:56
Saviqmzanetti, I did mean, overall, that we should _not_ differentiate if at all possible09:57
Saviqbut if we _do_, then, if at all possible, not based on the abstract / arbitrary form factor variable09:57
mzanettifull ack09:57
mzanettitsdgeos: hey ho!10:14
mzanettitsdgeos: friendly reminder: https://code.launchpad.net/~mzanetti/autopilot/faqs/+merge/152864 :)10:14
tsdgeosah sorry10:14
tsdgeosi thought that had my implicit ok10:15
tsdgeosi'll give you the expliciti one :D10:15
mzanettitsdgeos: seems noone wants to top-approve as long as you have the Needs Fixing in there10:15
tsdgeosmzanetti: fixed, are you finding someone else to top approve? or want me to do it too?10:17
mzanettitsdgeos: its ok... probably thomi should top approve stuff that goes to python-autopilot10:18
tsdgeosSaviq: do you remember why we need the super friends ppa?10:31
tsdgeosSaviq: i don't have any package installed from it and stuff compiles/links just fine10:31
Cimitsdgeos, why qmluitests is kept separate?10:35
tsdgeosCimi: separate to what?10:35
Cimitsdgeos, unittests10:35
tsdgeosCimi: becasue it needs to open a window that needs gl and the builders don't have that thus make test would fail10:36
Cimitsdgeos, ah I see10:36
tsdgeosCimi: is https://code.launchpad.net/~unity-team/unity/phablet.crossfadeimage-tests/+merge/153221 ready for review? want me to have a look?10:38
Cimitsdgeos, ready10:39
Cimitsdgeos, I'm about to start testing dashbar botto swipe10:39
Saviqtsdgeos, we might only need it for quantal10:42
Saviqtsdgeos, the people lens uses libfriends10:42
tsdgeosSaviq: does it? i don't have libfriends here and it compiled fine :-S10:44
tsdgeosSaviq: ah, all goes thorough dee it seems10:45
Saviqtsdgeos, ok, it uses Dee directly10:45
tsdgeosso you don't need it on compile time10:45
Saviqtsdgeos, yeah10:46
tsdgeosso we probably need friends on runtime10:46
tsdgeosshall we add that to some of the apt-get install we do?10:46
Saviqtsdgeos, it's not a hard req10:46
tsdgeosSaviq: so https://code.launchpad.net/~aacid/unity/more_build_work/+merge/15374310:47
Saviqtsdgeos, we'll just have to describe it in the docs10:47
Saviqtsdgeos, and in that case drop the super-friends PPA10:47
tsdgeosright, let me drop it from that MR then10:48
tsdgeosquantal too, right?10:48
Cimiin the dashbar tests I need to have a model of the lenses, how do I create a fake one or use the existing?10:56
tsdgeosgood question :D10:59
tsdgeosdo you need to have fake ones to inject some values?10:59
tsdgeosor using the existing ones is ok?10:59
Cimitsdgeos, it's ok11:00
tsdgeosCimi: https://code.launchpad.net/~unity-team/unity/phablet.crossfadeimage-tests/+merge/153221 looks ok to me, any reason you did not put the "readonly" to running ?11:00
Cimitsdgeos, that part was added by mzanetti11:01
Cimitsdgeos, I am not sure we need it at all!!11:01
Cimimzanetti, why did you add running property?11:01
tsdgeosfor the waitForAnimation part i gather11:02
mzanettitsdgeos: Cimi: nope. I forgot... should be readonly11:02
tsdgeosmzanetti: can you update it and then i'll approve the MR11:02
Cimimzanetti, but why do we have it in the first place I meant?11:02
mzanettiCimi: to not have to rely on wait() to know when the animation is done11:03
Cimimzanetti, but it's not needed in unity11:03
Cimimzanetti, just for tests...11:03
mzanettiCimi: besides, it could be useful for implementations too when you want to make sure to not set a new image before the previous animation is completed11:03
Cimimmm ok11:04
mzanettiCimi: and its perfectly valid to add properties that ease up testing11:04
mzanettiCimi: as long as they don't kill memory or cpu11:04
Cimimzanetti, they make code more complex11:04
mzanettiCimi: I don't agree that adding one property exposing some state of a component makes code more complex...11:05
Cimimzanetti, one property is nothing11:05
Cimimzanetti, but one, two or other changes for each file11:05
Cimiwill increase complexity11:05
mzanettiCimi: sure... you shouldn't add 50 lines of javascript11:05
mzanettibut look at the tests... I think yours - with the wait for the animation - were way more complex then my version11:06
Cimimzanetti, anyway, this property might also be useful when using it, so it's good to have it11:06
mzanettiso this change actually simplifies the code - as tests are code too11:06
Cimimzanetti, I used wait to avoid adding properties indeed11:08
tsdgeoshving a look at the diff it seems the property simplifies the test quite a bit11:09
tsdgeosmzanetti: just add the readonly and let's approve it11:09
Cimitsdgeos, so how do I use the models?11:12
tsdgeosCimi: not sure, which file are you testing exactly11:12
Cimitsdgeos, dashbar11:12
tsdgeosCimi: i think injecting a fake model here makes more sense tbh11:13
mzanettitsdgeos: done11:16
Saviqmzanetti, https://pastebin.canonical.com/86996/ can you reduce that diff, please?11:16
Saviqmzanetti, looks like you didn't refresh before changing :/11:17
tsdgeosmzanetti: reject https://code.launchpad.net/~mzanetti/unity/xvbf-test/+merge/151928 right?11:17
mzanettiSaviq: oops11:18
Saviqmzanetti, I tried to sanitize the work items a bit, with correct milestones and such11:19
=== mmrazik is now known as mmrazik|lunch
mzanettiSaviq: is there a way to just revert my change again or do I manually undo the diff?11:19
mzanettitsdgeos: yes... I ca delete it11:21
tsdgeosmzanetti: ok11:21
tsdgeosCimi: mzanetti: what happened to https://code.launchpad.net/~mzanetti/unity/phablet-rename-notepad/+merge/151197 ?11:23
mzanettitsdgeos: have to ask Ugo11:24
mzanettiI'll do11:24
mzanettiSaviq: I hope it should be ok again... please have a quick check11:29
Saviqmzanetti, cheers11:29
mzanettitsdgeos: Ugo took care about the MP11:29
tsdgeosmzanetti: meaning?11:29
tsdgeoswe should approve ours?11:29
mzanettitsdgeos: what happened here is this:11:30
mzanettinotes-app got renamed. that requires changes in notes-app, the shell, and the image generation project - mostly at the same time11:30
mzanettiso when an app gets renamed I usually review all 3 MP's but don't top-approve any of them11:31
mzanettiand leave that to the developer of the app to make sure its in the correct order/timeframe11:31
mzanettiseems that approach has failed here11:31
mzanettibut its approved now11:32
tsdgeosok :-)11:32
tsdgeosmzanetti: if you add the readonly to lp:~mzanetti/unity/preview-play-button-size and lp:~unity-team/unity/phablet.crossfadeimage-tests we'll get down to only 12 branchs in review :D11:33
mzanettitsdgeos: I will...11:34
=== mmrazik|lunch is now known as mmrazik
tsdgeosCimi: i see you approved https://code.launchpad.net/~unity-team/unity/phablet-people-listview-carousel/+merge/153154 but not top approved, what is missing? you prefer someone else to have a look?11:36
Cimitsdgeos, yes11:39
tsdgeosCimi: ok, i can do another review, if you want, can you give me some edge cases i should check when running in the tablet, etc? so i can check those before reading the code and make sure it makes sense?11:40
Cimitsdgeos, I don't have a tablet11:41
Cimitsdgeos, I think the best idea would be playing with it and seeing if you can see regressions11:42
tsdgeosCimi: ok11:42
Cimitsdgeos, I tested and there aren't for me11:42
luvok guys, i tried to work on ubuntu online accounts but when running dpkg-buildpackacge in signon-plugin-oauth2-0.15 in raring i get this: http://pastebin.com/MhjPaf3w11:53
mmrazikdidrocks: we have some packaging changes (adding a subpackage with autopilot tests) for autopilot-qt11:55
mmrazikI assume that can't go into raring, right?11:55
didrocksmmrazik: autopilot-qt is still not in raring. I know that cyphermox was working on that some days ago11:56
mmrazikshall I branch lp:autopilot-qt into lp:autopilot-qt/raring and change the cupstream2distro-config stuff?11:56
mmrazikdidrocks: oh... right11:56
didrocksmmrazik: so coordinate with him first please11:56
didrocksmmrazik: maybe we can have everything in one shot :)11:56
tsdgeosgusch: do you have a tablet?12:02
luvok, i will just file a bug against signon-plugion-oauth2 when i get back home12:03
tsdgeosoh not even tablet is needed12:03
guschtsdgeos: yes12:04
tsdgeosgusch: https://code.launchpad.net/~unity-team/unity/phablet-people-listview-carousel/+merge/153154 needs fixing12:05
tsdgeoslooks like there is some vertical spacing missing12:05
tsdgeosor something12:05
tsdgeosi get lots of overlaps where the carousel is used12:05
mzanettitsdgeos: added the readonly on both... in the play-button one its a bit useless, but ok12:07
guschtsdgeos: ah - I see the implicitHeight is not fixed - I'll push an update12:08
tsdgeosmzanetti: maybe qml can do some optimization, won't hurt12:08
mzanettiyeah sure... I've added it already12:08
=== MacSlow is now known as MacSlow|lunch
guschtsdgeos: pushed12:10
guschtsdgeos: ups - no, there was an error12:11
tsdgeosgusch: can we get a test for the implicitheight? do you think it's hard?12:15
guschtsdgeos: so far I have tests for the JS only - and no plans to extend that12:15
guschtsdgeos: reason is, that I don't work on the shell anymore ...12:16
mzanettiSaviq: while testing PageHeader.qml we noticed this: https://pastebin.canonical.com/87001/12:17
tsdgeosgusch: :/12:17
tsdgeosgusch: ok, the MR still needs fixing though, on the tablet it looks very different from the current one (i.e. "too much" spacing)12:17
mzanettiSaviq: I think the PageHeader shouldn't directly access the greeter, instead that Connection should be outside the component12:17
Saviqmzanetti, yeah, bad shortcut12:18
tsdgeosgusch: i'll comment and let's see who fixes it since i guess you are not doing it because you are not a shell guy anymore12:18
guschtsdgeos: I pushed the update for the implicit height now12:18
mzanettiack... no problem... just wanted to know if you agree12:18
tsdgeosyep, seen12:18
Saviqmzanetti, this should probably be exposed on the shell12:18
Saviqmzanetti, accessing greeter directly _anywhere_ outside of Shell.qml is bad12:19
tsdgeoswoot, i can use the hud to add contants in the telephony app, someone has been wiring up stuff :-)12:31
Saviqtsdgeos, :)12:46
luvohh, i see the patch for fast window switching got some praise even on the reg http://www.theregister.co.uk/2013/03/04/ubuntu_13_04_review/page2.html :-) thanks guys!12:47
=== _salem is now known as salem_
kgunnSaviq: mzanetti hey guys, thanks for updating bp's, i am totally for using "13.04-month-5" monikers13:06
mzanettinp :)13:06
kgunnonly wonder was....will it "screw up" 13.04 reporting metrics13:06
kgunni asked warner but never got an answer13:06
Saviqkgunn, those are defined milestones13:06
* mzanetti doesn't know too much about how those metrics are collected13:07
kgunnSaviq: right, understand...but that work isn't targeting 13.04 as a whole13:07
kgunni'm still ok with it13:07
zvucihi is there a Mir for ubuntu desktop which i can try? thnx13:07
Saviqkgunn, true, I was just adhering after the ML discussion13:07
kgunnSaviq: what they get for not answering :)13:08
kgunni'm ok with it13:08
Saviqkgunn, ;)13:08
Saviqzvuci, http://unity.ubuntu.com/mir/ should help13:08
Saviqzvuci, there's also #ubuntu-mir13:08
kgunnzvuci: hang on digging13:08
zvucii was there13:08
zvucii mean is it working13:09
kgunnzvuci: https://wiki.edubuntu.org/Mir/GetInvolved13:09
zvucilike normal desktop13:09
kgunnzvuci: if you're curious about what we're trying to do and when read this http://voices.canonical.com/user/201/13:11
CimiSaviq, I'm creating a fake model for dashBar, the name should be reachable via lens.name, how do I fake this?13:14
Saviqmzanetti, a MockLens component with name as property?13:14
SaviqCimi, ^13:14
Saviqmzanetti, sorry13:15
CimiSaviq, where is MockLens?13:16
SaviqCimi, there isn't13:16
Cimiah ok13:16
SaviqCimi, you need to create it13:16
Cimiah ok13:16
CimiI thought we were reusing something13:16
zvucithnx kgunn i get the direction13:18
CimiSaviq, I'm lil confused: I have ListElement { MockLens { id: lens; name: "music" } } ?13:20
CimiI don't think, where am I failing?13:21
Cimiqt docs are not explaining this case13:21
SaviqCimi, ListElement is flat13:21
SaviqCimi, you can't use it like that13:21
Cimiah ok13:21
CimiSaviq, so what shall I use?13:22
SaviqCimi, I don't think it's possible without C++13:23
Saviqmzanetti, ideas ^?13:25
Saviqmzanetti, Cimi needs a list model that will expose a role "lens" that will have properties13:25
mzanettiSaviq: Cimi: hmm, I think you have to do it like we did with the filterGrid13:26
Saviqhmm /me tries with a JS array13:26
CimidashBar has source: "graphics/lensIcons/%1.png".arg(lens.name)13:26
Cimiit's the only bit used of the model13:26
davidcalledidrocks, hey13:26
SaviqCimi, we'll need the mock lens in other places, too13:30
=== MacSlow|lunch is now known as MacSlow
Cimimzanetti, we didn't test the filter grid afaics13:32
mzanettiCimi: no... not with testing. when we set them in the lens13:32
mzanettiCimi: the ListModel only holds the string names and the are actually loaded with a Loader where you can set other properties from the ListModel13:33
Cimiah I see13:33
Cimimzanetti, like Data ?13:34
mzanettiCimi: Data?13:34
mzanettiCimi: Like in DashHome.qml for example13:35
mzanettiCimi: you write the MockLens.qml as string in there and add the properties you want13:35
mzanettiCimi: later in the Loader you load the Mocklens.qml using the value from the model and in Loader.onCompleted: you set the rest of the properties in there13:36
mzanettisomething like that13:36
didrockshey davidcalle13:38
* Cimi lunch13:39
mzanettiSaviq: what exactly is the InputfilterArea supposed to do?13:39
Saviqmzanetti, it says to the input system "don't pass those events to the apps"13:40
mzanettiSaviq: I wrote tests for it... doesn't seem to worl13:40
mzanettiSaviq: however, seeing it imports Ubuntu.Application it might not work on desktop only13:40
Saviqmzanetti, you'd have to test that in another application13:40
Saviqmzanetti, and no, it won't work on desktop13:41
mzanettiSaviq: thats bad13:41
mzanettiI don't understand why we have the Ubuntu.Application not available on the desktop13:41
mzanettiit already caused tons of workarounds13:41
Saviqmzanetti, because no one wrote it13:41
Saviqmzanetti, we'd have to wrap BAMF and stuff13:41
Saviqmzanetti, and anyway it needs to be rewritten on top of Mir13:42
mzanettiSaviq: no... we just do that component loading in there instead of 5 times in each app13:42
mzanettiSaviq: not saying all the functionality needs to be there13:42
mzanettiSaviq: but this component loading workaround in every app is just insane13:42
Saviqmzanetti, of course13:42
davidcalledidrocks, how do you want to handle scopes depending on non-default music players? Depends on the music player and "enhances" it?13:42
didrocksdavidcalle: I would say "suggests" it13:43
didrocksdavidcalle: as a depends would pull it by default13:43
Saviqmzanetti, not sure what to tell you, we need that API available on the desktop, yes13:43
Saviqin that form or another13:43
davidcalledidrocks, I wasn't thinking of having them by default because of the depends, but indeed, suggests solves it.13:44
didrocksdavidcalle: let's have all scopes installed by default13:44
mzanettiSaviq: ok... anyways, I wrote some test but they fail of course - as the InputFilterArea does so too13:44
didrocksdavidcalle: then, you have the functionnality if it's installed13:44
Saviqmzanetti, but it needs to lose functionality like the InputFilterArea, as that's only supposed to be available for the shell13:44
didrocksdavidcalle: you just need to ensure it won't fail if not installed :)13:45
Saviqmzanetti, there13:45
davidcalledidrocks, tests should handle this case already. Will check.13:45
Saviqmzanetti, current Ubuntu.Application was thrown together on an as-needed basis13:46
Saviqwith no real long-term goal behind it13:46
didrocksdavidcalle: thanks13:46
mzanettiSaviq: yeah... I just remember back in december I wanted to move the loading inside the component because in all the apps we were introducing the workaround... someone said I shouldn't do that13:47
Saviqmzanetti, we  need to reevaluate what's available in that API and move stuff that's supposed to be available to applications out13:48
Saviqand preferably implement for X desktop13:48
mzanettiSaviq: yep. lets do that right after we are sufficient with testing13:49
Saviqmzanetti, can you add a work item to iteration 0, please?13:49
mzanettiSaviq: in the meantime, not sure what to do with this one... https://code.launchpad.net/~mzanetti/unity/phablet-test-inputfilterarea/+merge/153803 I think we could merge nevertheless as the qmluitests are not yet executed in jenkins anyways13:49
mzanettiSaviq: yes, I'll add the work item13:50
Saviqmzanetti, those tests wouldn't work anyway13:50
Saviqmzanetti, the InputFilterArea doesn't do anything in the scope of the current app13:50
Saviqi.e. shell13:50
Saviqmzanetti, it only informs the input system13:50
Saviqto _not_ deliver those events to other apps13:50
Saviqmzanetti, that's why I said you'd need a separate app to verify that it works13:51
mzanettigot it... ok. I'll make it happen. but in that case probably only once it works13:51
Saviqmzanetti, and testing that belongs to whatever provides that API anyway..13:52
* Saviq biab13:52
tsdgeosmzanetti: can you review https://code.launchpad.net/~aacid/unity/phablet_hud_results_test/+merge/153816 or want me to find someone else?14:24
mzanettitsdgeos: I can do14:25
tsdgeosgreat :-)14:25
mzanettitsdgeos: the test would be nicer using the _data() function... (for next time. don't need to change it now)14:29
tsdgeosmzanetti: oki :-)14:30
cyphermoxdidrocks: mmrazik: autopilot-qt is supposed to be ready, just needs the bootstrap commit IIRC14:31
didrockscyphermox: FFe is accepted?14:31
mmrazikcyphermox: ok. Do you think we can get the libautopilot-qt-autopilot subpackage as well?14:31
cyphermoxis that a merge pending?14:32
cyphermoxtoo many things at once, I haven't finished going through my checklist this morning14:32
cyphermoxdidrocks: yeah the ffe is approved provided we can get AA review14:39
didrocksI'm pretty sure you will a AA review :p14:40
didrocksI'm pretty sure I'll do it ;)14:40
=== dandrader_ is now known as dandrader|afk
cyphermoxyeah, not worried about that14:44
tsdgeosSaviq: did you have time for https://code.launchpad.net/~aacid/unity/more_build_work/+merge/153743 ?14:44
Saviqtsdgeos, at it now14:44
tsdgeoscool :-)14:44
cyphermoxdidrocks: https://code.launchpad.net/~mathieu-tl/autopilot-qt/bootstrap/+merge/15382714:45
cyphermoxduh, my 3G modem doesn't work with the new ModemManager :'(14:45
didrockscyphermox: looks good. However, i would add the bug # for the FFe while you are at it14:45
cyphermoxoh shucks14:46
cyphermoxof course14:46
Saviqtsdgeos, only thing that looks weird is: "quantal=true; if (raring) quantal=false" - maybe we should have "raring=false; if (raring) raring=true" instead? ;)14:47
cyphermoxdidrocks: I'd add it to the qa stack now as well14:47
Saviqtsdgeos, also, weren't you removing friends from there?14:48
tsdgeosSaviq: yeah, thought it was a bit weird too when i read it, now that we have a second opinion i'll change it14:48
cyphermoxdidrocks: where did you move the stack config to?14:48
tsdgeosSaviq: wasn't sure if i shall kill it from quantal too, i kill it too right?14:48
didrockscyphermox: great! so in tomorrow daily?14:48
didrockscyphermox: see my email a week ago, lp:cupstream2distro-config14:48
cyphermoxI want it in tomorrow daily14:48
Saviqtsdgeos, yeah, it's a soft dep, we'll talk about it in some docs14:48
tsdgeosgusch: saw my new comment?14:49
didrockscyphermox: mmrazik was talking about a new subpackage, maybe everything should land at the same time?14:49
tsdgeosmzanetti: and another small one https://code.launchpad.net/~aacid/unity/phablet_test_searchbar_set_query/+merge/15382814:49
didrockscyphermox: and please, unblock the current stack in manual publication mode while you are at it :)14:50
guschtsdgeos: ok - but what spaces?14:51
tsdgeosbetween the items of the carousel14:51
tsdgeose.g. with your version if i go to videos14:52
tsdgeosthere is spaces between them14:52
tsdgeoswith the current one they overlap14:52
guschtsdgeos: is it a one pixel space?14:53
tsdgeosgusch: no it's like 3014:53
tsdgeosi'll give you a screenshot14:54
guschtsdgeos:yes, thx14:54
tsdgeosSaviq: pushed the friends removal and raring/quantal logic switching14:55
Saviqtsdgeos, cheers, can you update the14:55
Saviqtsdgeos, actually, yeah - update debian/control with a "qt-components-ubuntu | qtdeclarative5-ubuntu-ui-toolkit-plugin" dep14:57
Saviqand we can redo the commit message to say "prepare for package renames"14:57
tsdgeosSaviq: is that the syntax?14:57
tsdgeos         qt-components-ubuntu (>= 0.1.5~) | qtdeclarative5-ubuntu-ui-toolkit-plugin,14:57
Saviqtsdgeos, yup, looks good14:58
=== dandrader|afk is now known as dandrader
guschtsdgeos: ah - I can see it - I guess it is a regression by the last change of Cimi - checking15:02
cyphermoxdidrocks: moo?15:02
cyphermox<didrocks> cyphermox: and please, unblock the current stack in manual publication mode while you are at it :)15:02
cyphermoxyou mean QA?15:02
tsdgeosgusch: ok, i was uploading the screenshots now :D15:02
didrockscyphermox: what we discussed in MP, yeah, QA ;)15:02
didrocksso done :)15:02
cyphermoxalright, yeah15:02
Saviqtsdgeos, FYI grep -q15:03
tsdgeosSaviq: ?15:04
Saviqtsdgeos, "grep > /dev/null" == "grep -q"15:04
kaleotvoss: can't make one on one today15:05
tsdgeosthe man page confuses me15:05
kaleotvoss: conflicting meetin15:05
tsdgeos"Exit immediately with zero status if any match is found, even if an error was detected."15:05
tsdgeosif there is an error do i want a  0?15:05
tvosskaleo, ack, same here15:06
Saviqtsdgeos, if a match was found, yes15:06
tsdgeosok, i'll change it15:06
Cimimzanetti, can you help me with the mocklens :D15:06
Saviqtsdgeos, you can go one line, even15:06
Saviqtsdgeos, if grep -q raring /etc/lsb-release; then15:06
mzanettiCimi: whats the issue?15:06
tsdgeossure, you can do all sort of stuff on bash :D15:07
Cimimzanetti, I don't understand at all15:07
tsdgeosi feel much more confortable with the other tbh15:07
Saviqtsdgeos, +115:07
tsdgeosSaviq: new grep pushed15:09
Saviqtsdgeos, cheers, that will be all, I think15:09
mzanettiCimi: more detailed please15:09
Cimimzanetti, you game me directions, a15:10
Cimi but I don't understand what I am supposed to do15:10
Cimiyou said I should write mocklens.qml as strings and add properties15:10
Cimiwhat you meant write as string, and which properties?15:10
mzanetticamerin: oh ok15:10
mzanetticamerin: sorry... should have been Cimi15:11
Cimiwhy I need a loader, what I need to load15:11
mzanettiCimi: ok.. give me a few minutes and I'll pastebin something together15:11
Cimimzanetti, thanks15:11
guschtsdgeos: now the spacing should be fixed again as well15:14
mzanettiCimi: hmm... actually that seems to be even easier... what exactly do you want to do?15:14
Cimimzanetti, dashBar needs15:16
Cimi"source: "graphics/lensIcons/%1.png".arg(lens.name)"15:16
Cimiso I guess I need a model with 5 items, music, people, home, apps, videos15:17
mzanettiCimi: hmm... first I'd recommend to make "lens" a property of the component... we should never access variables from outside the component15:18
mzanettiCimi: still around?15:23
Cimimzanetti, yes15:23
mzanettiCimi: do you agree with my previous statement?15:24
Cimimzanetti, I didn't understand :)15:24
mzanettiCimi: so... the Component DashBar.qml calls lens.something15:25
mzanettiCimi: however, "lens" is not defined in the while DashBar.qml15:25
Cimimzanetti, lens is in the model15:25
Cimimzanetti, there is a listview, each item has index, lens15:25
Saviqmzanetti, lens is a role15:26
mzanettiI see... sorry then15:26
mzanettiCimi: and whats the issue with just doing this:15:28
mzanettimodel: Lenses {}15:28
tsdgeosgusch: ahh much bettar15:29
guschtsdgeos: should 1:1 visual identical now again15:29
Saviqmzanetti, lenses are filtered15:32
tsdgeoshttps://code.launchpad.net/~mterry/unity/poeple-typo/+merge/153840 wops :S15:33
mzanettiSaviq: are they even if you don't wrap it in a SortFilterProxyModel?15:33
Saviqmzanetti, well, no, then they're not15:33
Saviqmzanetti, but TBH Lenses should be non-creatable15:34
tsdgeosif we have that typo ↑↑↑ how does it work?¿15:34
mterrytsdgeos, ::shrug::15:34
mzanettiSaviq: you mean setting it by a contextProperty?15:34
Saviqmzanetti, yes, and register as non-creatable15:34
Cimigusch, thanks for the fix15:35
Saviqtsdgeos, mterry, there's two places that populate that15:35
mzanettiSaviq: yeah ok... but then that's just the same for the tests...15:35
Cimigusch, fun enough, I fixed locally on friday, forgot to do bzr push :)15:35
Saviqtsdgeos, mterry, depending on whether the lens is loaded onCompleted or not15:35
tsdgeosSaviq: i see, gonna approve the change then15:35
Saviqtsdgeos, yeah, thanks15:35
mzanettiCimi: try with using model: Lenses {} for now. and if we change them to be non-creatable we need to do the same as tsdgeos does with the HUD (mocking it all with C++)15:35
guschCimi: ah - hehe - it was too easy, so I got the fix too fast ;)15:35
tsdgeosgusch: Cimi: did we find any way to evaualte if the listview is really better?15:40
tsdgeosor we just assume it's better because it'll have less elements15:41
Cimitsdgeos, people say it will consume less memory15:41
Cimitsdgeos, although I don't like the workaround15:41
Cimiand I prefer repeater coding-wise15:42
Cimibut we don't have other choices if we want to use listview15:42
guschtsdgeos: in my early test it saved a few MB (not a lot, and measurement were not very relieable)15:42
Cimigusch, those tests are not valid because you were using cacheBuffer I believe15:42
guschtsdgeos: but anyway - Repeater does scale well (think of having 100, or even more items)15:42
Cimidoes not you meant15:43
Cimilistview should scale better15:43
tsdgeosCimi: which "workaround" you mean?15:43
Cimitsdgeos, enlarging the area adding left and right negative margin15:43
tsdgeosah, ok15:44
tsdgeosit's a bit weird yeah, but with qml sometimes you have to do that stuff, it's not that horrible i think15:44
dandradermzanetti, I've replied to your comments and updated https://code.launchpad.net/~dandrader/unity/phablet_tst_FilterGrid/+merge/15359915:45
mzanettidandrader: the wait(100) is a bit... lets say - not that good15:47
dandraderlet me check if it works without that magic line :)15:47
dandradermzanetti, it does. will remove them now15:48
dandradermzanetti, btw, you can do "make testFilterGrid"15:48
mzanettidandrader: if you need to wait, use "tryCompare(filtergrid.height, filtergrid.totalContentHeight)" or something like this15:49
mzanettidandrader: albert did that in the autopilot tests and it seems to work fine15:49
mzanettidandrader: yeah, the cmake stuff you did is very nice15:49
dandradermzanetti, yes, I did this tryCompare thing in my update as well15:49
dandradermzanetti, pushed the wait(100) removal15:50
mzanettidandrader: it doesn't compile any more... I think you need to merge trunk and upgrade your libdee-qt-315:51
=== alan_g is now known as alan_g|tea
dandradermzanetti,  ok, will check that15:52
dandradermzanetti, it should just work if you take lp:unity/phablet and do a "bzr merge lp:~dandrader/unity/phablet_tst_FilterGrid". As opposed to using lp:~dandrader/unity/phablet_tst_FilterGrid directly15:57
mzanettidandrader: ok. I'll try15:58
mterrycyphermox, what's the story with indicator-head's red status?  Is it anything for unity-head to worry about?16:00
=== alan_g|tea is now known as alan_g
Saviqtsdgeos, hmm, why do I have to confirm apt-get like 6 times on initial ./build -s?16:04
cyphermoxmterry: I think it's probably safe, there's a commit that can't land and that I'll need to revert, but otherwise the tests seem to be failing .. are the same as are often failing16:05
tsdgeosSaviq: because we don't have any -y in the apt-get install16:05
cyphermoxmterry: perhaps sil can comment16:05
tsdgeosSaviq: can add16:05
Saviqtsdgeos, maybe we could have a -y option for the script...16:06
cyphermoxmterry: there hasn't been meaningful changes to indicators lately anyway16:06
Saviqtsdgeos, but adding -y everywhere sounds good enough16:06
* tsdgeos adds16:06
tsdgeosSaviq: pushed16:08
mzanettidandrader: I agree on the ResponsiveGridView comment. And with the last comment I'm just trying to push the mindset a bit... Often its not much more efforts to just add one testrow that checks if stuff triggers a crash when setting insane values for example16:08
mzanettidandrader: approving16:08
dandradermzanetti, ok, thanks16:10
Cimimzanetti, Lenses is in unity plugin?16:14
mzanettiSaviq: do we want something like this? https://code.launchpad.net/~juhapekka-piiroinen/ubuntu-ui-toolkit/bazaar-plugin-precommit-hook-for-makecheck/+merge/15384216:14
mzanettiCimi: yes16:14
Saviqmzanetti, looks good16:15
Cimimzanetti, I think I need to load it somehow from the makefile16:15
Saviqmzanetti, we should also check whitespaces :)16:15
mzanettiCimi: I fear you have to spend the effort to mock it out in C++. There is a Hud example already16:15
Cimimmm ok16:15
mzanettiSaviq: where? at the end of lines?16:15
Saviqmzanetti, and that no \t is used16:16
mzanettiSaviq: hm... could run astyle on stuff yeah16:16
Saviqtsdgeos, did you see https://code.launchpad.net/~aacid/unity/more_build_work at the top?16:17
Cimimzanetti, I'll go and study a bit this HudClient then16:17
tsdgeosSaviq: yeah, ignore that, it'll just work fine16:17
tsdgeosSaviq: happens because i push with "bzr push --stacked-on bzr+ssh://bazaar.launchpad.net/+branch/unity/phablet/" so that it does not take hours for each new branch16:18
Saviqtsdgeos, it doesn't work _just_ fine - bzr+http doesn't work, but yeah it works with bzr+ssh16:18
Saviqtsdgeos, good tip16:18
Saviqtsdgeos, wouldn't --stacked-on lp:unity/phablet work?16:18
tsdgeosSaviq: i remember it gave some error16:19
tsdgeosit was obviously the first thing i tried16:19
Saviqtsdgeos, mhm16:19
tsdgeoslet me try again16:19
mzanettiI think I tried it too after albert gave me the above line16:19
tsdgeosbzr: ERROR: Server sent an unexpected error: ('error', 'UnsupportedProtocol', 'Unsupported protocol for url "lp:unity/phablet"')16:19
tsdgeosSaviq: yeah bzr+http doesn't work, i suffered that once when trying to checkout from a non logged in VM16:21
tsdgeosbut tbh i can live with that if it means i push in 10 seconds instead of 10 minutes16:21
Saviqtsdgeos, guess how I found out ;)16:21
=== dandrader is now known as dandrader|afk
didrocksmmrazik: rev 82, adding unity-lens-photos please :)16:32
mmrazikdidrocks: done16:34
mmrazikdidrocks: btw. I'm still bootstrapping the local repo and using the PPA. At one point of time I'll need to remove the ppa and use the local repo only16:34
mmrazikunfortunately daily > bzr16:34
didrocksmmrazik: it was designed for that16:35
didrocksso that d > b16:35
didrocksis it a problem? things shouldn't build-dep on d*16:35
mmrazikdidrocks: sure.... I mean unfortunately for the bootstrapping purposes. I can't keep the PPA _and_ the local repo and hope the PPA will be irreleveant sooner or later16:35
didrocksmmrazik: ah, yeah, as we don't succeed a full stack build16:36
didrocksmmrazik: you don't have the merge back16:36
didrocksso dont' get the bumped revision16:36
CimiSaviq, I'm trying importing Unity from plugins dir16:38
Cimibut I get symbols errors16:38
SaviqCimi, ./run16:38
CimiQWARN  : qmltestrunner::UnknownTestFunc() file:///home/cimi/Development/phablet/phablet.dashBar_bottomswipe/tests/unittests/tst_DashBar.qml:19:1: plugin cannot be loaded for module ".home.cimi.Development.phablet.phablet.dashBar_bottomswipe.plugins.Unity": Cannot load library /home/cimi/Development/phablet/phablet.dashBar_bottomswipe/plugins/Unity/libUnity-qml.so: (/home/cimi/Development/phablet/phablet.dashBar_bottomswipe/plugins/Unity/libUnity-qml16:38
Cimi.so: undefined symbol: _ZTIN5unity4dash13PeoplePreviewE)16:38
Cimi     import "../../plugins/Unity"16:38
CimiSaviq, ^16:38
SaviqCimi, see what's set there16:38
SaviqCimi, you need to use the libs from ../unity_build/build16:39
Cimimzanetti, maybe we need to patch the unittests to import from that dir too?16:39
mzanettiCimi: that's already happened... should be merged soon16:40
mzanettiCimi: it'll come with this one https://code.launchpad.net/~dandrader/unity/phablet_tst_FilterGrid/+merge/15359916:41
Cimimzanetti, studying, thx16:41
Cimimzanetti, this is qmluitests though16:42
Cimimzanetti, not unittests dir16:42
mzanettiCimi: ah ok... yeah... can you create the same for those?16:42
mzanettiCimi: it also has the advantage that "make check" gets more verbose16:43
tsdgeosmzanetti: since you did the greeter are you checking mterry's https://code.launchpad.net/~mterry/unity/phablet-greeter-lightdm/+merge/152288 ?16:47
seb128mterry, hum, autopilot/jenkins are not happy :-(16:50
seb128mterry, they loop on "2013-03-18 15:40:26,617 dx-autopilot-ati INFO: Caught [Errno 111] Connection refused, retrying sshcheck(180)"16:50
seb128mterry, same for intel and nvidia it seems16:51
mibofrahi :))16:54
mterrytsdgeos, mzanetti: While I would love a review of that, I'm currently fixing that branch's autopilot tests and adding more.  But the functionality itself won't change16:54
mterryfginther, ^ to seb128 's comments16:54
mzanettitsdgeos: mterry: yes, can do16:55
mzanettitsdgeos: https://code.launchpad.net/~mzanetti/unity/phablet-make-check-hook/+merge/15386816:56
Cimimzanetti, what line 77 and 82 do?16:57
Cimithe if equals the elf?16:57
mzanettiCimi: 77: if (argc == 1)16:58
mzanettiCimi: 82 } else {16:58
Cimiah ok16:58
Cimimzanetti, it's a different syntax16:58
mzanettiCimi: 88: }16:58
mzanettiCimi: yes. cmake syntak is a bit weird sometimes... I also think adding the condition to else() and endif() is optional, but common practice16:59
Cimimzanetti, never used cmake before, just automake16:59
Cimiwas curious16:59
tsdgeosmzanetti: oh stealth stuff :D16:59
=== cyphase is now known as cyphase_
mzanettiCimi:  if you understood automake I guess you are the one that will answer all build system questions now :D17:00
* mzanetti bails out at latest in the 5th line of any autotools script17:00
Cimimzanetti, understood is a hard word :D17:00
MacSlowmzanetti, Saviq: "hud-client-1", which the build-script for unity-phablet needs... is meant to come from where?17:00
=== cyphase_ is now known as cyphase
Cimimzanetti, I used it in my libraries and cried when needed17:00
SaviqMacSlow, it's build locally17:00
=== cyphase is now known as cyphase_
tsdgeosmzanetti: how does that work? do i need to do it in each of the dirs? or once i do make install once it'll work everywhere?17:01
SaviqMacSlow, installed in ../unity_build/build/17:01
=== cyphase_ is now known as cyphase__
SaviqMacSlow, remember to use ./build17:01
tsdgeosMacSlow: did you do ./build -s ?17:01
Saviqit sets up PKG_CONFIG_DIR17:01
mzanettitsdgeos: see the desription17:01
mzanettitsdgeos: you have to install manually...17:01
tsdgeosmzanetti: doesn't answer my question :D17:01
tsdgeosmzanetti: for each of the repos or just once?17:01
tsdgeosi guess for each of the repos17:02
mzanettitsdgeos: hmm... I think just once for all17:02
* mzanetti tests to push something else17:02
=== cyphase__ is now known as cyphase
MacSlowSaviq, this is what I get... pastebin.ubuntu.com/562570817:02
mzanettitsdgeos: install once, use in all... which is probably not what we want...17:03
tsdgeosmzanetti: i don't want to run make qmluitests in qt-components repo17:03
tsdgeosMacSlow: did you do ./build -s ?17:03
SaviqMacSlow, go ./build_unity and see if hud is built/installed properly17:03
mzanettitsdgeos: yes. I agree. I'll fix it17:04
MacSlowtsdgeos, bummer... thx17:04
MacSlowSaviq, ./build_unity is a script here17:04
tsdgeosMacSlow: are you in raring or quantal?17:04
SaviqMacSlow, yeah, run it17:04
MacSlowtsdgeos, this is on a fresh 12.10 to raring update17:05
tsdgeosMacSlow: then you may want to wait for https://code.launchpad.net/~aacid/unity/more_build_work/+merge/153743 to be merged or merge it manually17:05
* tsdgeos eods17:05
tsdgeosafternoon/evening guys17:06
MacSlowtsdgeos, Saviq: doing the -s with ./build now17:06
MacSlowtsdgeos, good night17:06
SaviqMacSlow, what it does is run ./build_unity -s; ./build_unity17:06
seb128mterry, is there anyone else than fginther that knows about utah/jenkins/autopilot there?17:06
MacSlowSaviq, I'm waiting for ./build -s to finish first17:06
seb128mmrazik, ^?17:07
MacSlowSaviq, I guess after that issues should be gone17:07
SaviqMacSlow, yeah, that's what will happen17:07
mterryseb128, mmrazik should yeah17:07
SaviqMacSlow, and that, in turn, builds libunity, UnityCore, hud, people lens17:07
mmrazikseb128: whats up?17:07
Saviqand installs in ../unity_build/build/17:07
MacSlowSaviq, I'm still used to do everything manually :)17:07
seb128mmrazik, hey17:07
SaviqMacSlow, yeah we wasted too much time on doing things manually ;)17:07
seb128mmrazik, hum, autopilot/jenkins are not happy :-(17:07
seb128they loop on "2013-03-18 15:40:26,617 dx-autopilot-ati INFO: Caught [Errno 111] Connection refused, retrying sshcheck(180)"17:07
MacSlowSaviq, :)17:07
seb128mmrazik, e.g
MacSlowSaviq, we had to suffer so our users (3rd-party devs) will have a sweet time hacking on the phone17:08
mmrazikseb128: that looks like an utah issue. Not sure If I'll be able to do something with that. Let me check on KVM if there is something obvious17:09
seb128mmrazik, who would?17:09
mmrazikseb128: nuclearbob, jcollado ...17:09
mmrazikgema for escalating (if you need to)17:09
seb128mmrazik, can you ping them?17:09
MacSlowSaviq, hm... "./build -s" tries to fetch libnux-3.0-dev ?17:11
SaviqMacSlow, yeah, merge the branch tsdgeos mentioned17:11
SaviqMacSlow, or run with -n17:11
MacSlowSaviq, ah ... that's that issue... I see... thx17:11
Saviqthat will _not_ do local nux17:11
MacSlowgot to run... bbl17:14
=== kgunn is now known as kgunnAFK
=== naee is now known as eean
=== mhall119 is now known as mhall119|lunch
=== rsalveti_ is now known as rsalveti
=== dandrader|afk is now known as dandrader
=== mhall119|lunch is now known as mhall119
=== kgunnAFK is now known as kgunn
dandraderhow do I declare a QML property that can hold any js object?18:36
dandraderhmm, seems specifying the property type is optional18:40
Saviqdandrader, "property var name: value"18:53
Saviqdandrader, var can hold anything18:54
dandraderSaviq, thanks18:54
Saviqdandrader, http://qt-project.org/doc/qt-5.0/qtqml/qtqml-typesystem-basictypes.html18:54
luvis launchpad broken for you guys too? (cant log in ... Your page was stale.)18:59
luvmaybe it just requires 3rd party cookies, grrr19:01
om26erCimi, Hi!19:24
om26erCimi, the volume slider handler looks distorted and have looked like that since 12.10 Could you look into that please :)19:25
kgunnom26er: Cimi is awfully busy on getting our UnityNext testing up to snuff19:26
om26erkgunn, ouch, alright I will get someone else look into that.19:27
kgunnom26er: :) no problem19:27
kgunnjust that we really need to keep our focus19:27
kgunnor all these folks worrying about enuff time/people to do mir/unitynext19:27
kgunnwill be proven true19:28
kgunnom26er: and no worries...we all got needs, i understand :)19:28
om26erkgunn, Indeed that's a more important issue for the time being19:28
=== dandrader is now known as dandrader|afk
mterryseb128, any progress with utah/19:35
=== dandrader|afk is now known as dandrader
seb128mterry, we brough it to #qa, they think it's an installer issue, so we moved to #ubuntu-devel but they need to get debug logs for cjwatson19:47
seb128mterry, mmrazik was eod and I'm not sure anyone else was going to follow up on that, I will make sure to keep nagging tomorrow morning ;-)19:47
mterryseb128, thanks  :)19:48
seb128mterry, installer issue: apparently the username used for preseeding is not respected19:48
seb128mterry, yw19:48
=== kgunn is now known as kgunnAFK
mzanettimterry: looks great!21:12
mzanettimterry: https://code.launchpad.net/~mzanetti/unity/phablet-elide-user/+merge/153934 :D21:12
=== rsalveti_ is now known as rsalveti
mterrymzanetti, I'm working on a followup branch so that we don't need to rebuild to use the mock liblightdm-qt5-2 library21:20
=== salem_ is now known as _salem
cyphermoxmterry: hey21:29
cyphermoxcould you quickly review another small merge? https://code.launchpad.net/~mathieu-tl/libindicator/revert-indicator-ng/+merge/15393821:29
mterrycyphermox, done21:33

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!