/srv/irclogs.ubuntu.com/2013/03/20/#launchpad-dev.txt

StevenKwgrant: You have two LFAs with identical SHA1s and filesizes and the old binaries_size was counting them twice (so 18 + 18 = 36); whereas we now weed out duplicates so 1800:00
wgrantStevenK: LFAs or LFCs?00:03
StevenKwgrant: The LFA ids were different, I'm not sure if they were FK'd to the same LFC.00:08
wgrantStevenK: We were just distincting on LFC before, weren't we?00:14
wgrantI don't quite remember.00:14
wgrantBut anyway, yes, it seems likely the test is buggy00:14
StevenKwgrant: Both LFA and LFC are distinct.00:16
wgrantStevenK: Now or before?00:16
wgrantNow they are00:16
StevenKwgrant: Sorry, in the test, the two publications have distinct LFAs and LFCs.00:17
wgrantBut the LFCs are identical?00:17
StevenKwgrant: http://pastebin.ubuntu.com/5629884/00:17
wgrantRight, so normally librarian-gc would have coalesced them00:18
wgrantThe test is wrong00:18
StevenKSo I have no idea how it was coming up with 54.00:18
StevenKSince that's mentioned in a comment00:18
StevenK36 I get, but it's still wrong00:18
StevenKwgrant: http://pastebin.ubuntu.com/5629892/00:21
wgrantStevenK: Sounds good00:22
StevenKwgrant: That file was a bit crazy00:23
StevenKLess so now00:23
StevenKwgrant: The source query takes ~ 400 ms, the binary query is more like 1 second01:59
StevenK(For ubuntu-langpack)01:59
wgrantStevenK: Sounds OK02:24
wgrantStevenK: Tried on some Kubuntu PPAs?02:24
StevenKwgrant: You assume I know where some of them live.02:44
wgrantStevenK: ~kubuntu-ppa02:48
wgrantppa:kubuntu-ppa/backports is quick once the cache is hot02:48
wgrantWhen cold, the binary query took 11s. 6s of that was just finding the BPPHs, so inlining the size would have only saved 50%, even though it would also have been wrong.02:49
StevenKI thought about it a bit more02:49
StevenKWe could solve the dupe issue by also denorming a checksum02:49
wgrant   ->  HashAggregate  (cost=189318.78..189411.75 rows=9297 width=93) (actual time=11545.856..11547.182 rows=1719 loops=1)02:50
wgrant         ->  Nested Loop  (cost=737.92..189225.81 rows=9297 width=93) (actual time=3700.384..11534.203 rows=2587 loops=1)02:50
wgrantNot very effective02:50
wgrant~30% decrease in work02:50
StevenKSo the queries still need a little tuning, or there isn't much we can do?02:50
StevenKWithout a massive amount of design, that is.02:51
wgrantThere's not much we can do.02:56
StevenKwgrant: https://code.launchpad.net/~stevenk/launchpad/back-to-agpl/+merge/15425103:50
wgrantStevenK: most of that is the former lazr-js?03:53
wgrantYes03:54
wgrantr=me03:55
StevenKBleh, I do not understand these JS failures06:15
wgrantStevenK: Have you tried it locally?06:22
wgrantIt's possible that it makes the files too big or something06:22
wgrantWe've had that problem before, though it's meant to be fixed06:22
wgrantAh06:23
wgrantStevenK: You have some syntax issues06:23
wgrant=== modified file 'lib/lp/code/javascript/branchmergeproposal.nominate.js'06:23
wgrant=== modified file 'lib/lp/code/javascript/branchmergeproposal.status.js'06:23
wgrant=== modified file 'lib/lp/registry/javascript/team.js'06:23
wgrant=== modified file 'lib/lp/registry/javascript/team_mailinglists.js'06:23
wgrant=== modified file 'lib/lp/translations/javascript/pofile.js'06:24
StevenKwgrant: I've fixed all of those06:45
StevenKhttp://pastebin.ubuntu.com/5630415/06:48
wgrantStevenK: Does it work?06:49
StevenKwgrant: It only fixes 3 of the 7 failures06:49
wgrantStevenK: Have you examined the common files included by those broken tests?06:50
StevenKYes, they look fine to me06:51
=== jam1 is now known as jam
adeuringgood morning08:57
stub_http://pgfoundry.org/projects/emaj/10:19
stub_If that is what I think it is, it might give us an easier way to reset db state after running a test.10:19
stub_Not sure if it would be a win though from test speed perspective (faster doing the db reset, but inserts, updates and deletes will be slower)10:20
=== teknico__ is now known as teknico
=== almaisan-away is now known as al-maisan
=== BradCrittenden is now known as bac
=== teknico_ is now known as teknico
=== yofel_ is now known as yofel
=== wedgwood_away is now known as wedgwood
=== frankban_ is now known as frankban
czajkowskialoha16:09
czajkowskiadeuring: where is the best place to point a canonical person at to fix something in LP16:09
adeuringczajkowski: the most up to date knowledge have wgrant and StevenK. But i can help perhaps too16:10
adeuringor other people who retired fromLP development.16:11
czajkowskimfisch: what area do you want to try and fix I guess would be the best start16:11
czajkowskiadeuring: aye just timezones makes it kinda hard16:11
adeuringczajkowski: yeah, that's why i sugegsted "retired people" too ;)16:12
mfischhey czajkowski, I ran into a problem yesterday where I changed permissions on a script by accident, it was lost in the review because it's hidden in one line in all black text and looks like a "file header", all the reviewers missed it too16:12
mfischI was thinking this morning that permissions changes could be called out with colorization as well16:12
mfischI don't know anything about the LP code base, but I thought something like: foo.sh <red>-x</red> <green>+x</green>16:13
mfischthat seemed to be simple enough to call attention16:13
adeuringmfisch: so, that's about reviews? abentley might be able to help16:13
mfischyeah, about reviews16:14
mfischI'd be happy to try and fix it myself if I can get a kick-start in the right direction16:15
adeuringmfisch: a very vague pointer: the directory lib/lp/code/browser16:16
adeuringin the LP source code.16:16
adeuringbut you'd need to read how to build LP locally on dev.launchpad.net first16:16
mfischok16:17
mfischI'll grab the code and poke around and save this for 10% time16:17
adeuringmfisch: there are also some procedures, like having a pre-imp conversation (what we are beginning now, but I am not sure how far we can get, since i am not very familiar with this part of LP)16:18
mfischadeuring: ok, let me look into whether this is feasible too and then I'll talk to abentley too16:20
cjwatsonwouldn't that be in loggerhead?16:21
mfischstill pulling the code...16:21
cjwatsonoh, ok, not for the review interface I guess16:22
abentleymfisch: I believe you want to look at FormattersAPI.format_diff in lib/lp/app/browser/stringformatter.py16:23
cjwatsongeneral advice: reproducing it in the test suite early is generally much more fun than trying to run a local LP instance.16:23
cjwatsonIME.16:23
cjwatsonand you'll need a test anyway16:24
mfischokay good advice16:24
mfischat this rate I'll have the code by tomorrow16:24
* abentley is somewhat irked that the code parses the diff manually instead of using bzrlib.patches.parse_patches.16:27
=== deryck is now known as deryck[lunch]
=== matsubara is now known as matsubara-lunch
=== al-maisan is now known as almaisan-away
=== deryck[lunch] is now known as deryck
=== matsubara-lunch is now known as matsubara
=== Ursinha-afk is now known as Ursinha
=== wedgwood is now known as wedgwood_away

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!