| === _thumper_ is now known as thumper | ||
| === salem_ is now known as _salem | ||
| didrocks | sil2100: hey, how are you? | 08:06 |
|---|---|---|
| sil2100 | didrocks: hello! Fine, just doing late breakfast today ;) How about you? | 08:11 |
| didrocks | sil2100: well, still under a pile of things to deal with | 08:11 |
| didrocks | sil2100: and unfortunately, again, some autopilot tests are failing | 08:11 |
| didrocks | sil2100: and that's also blocking the 100 scopes | 08:11 |
| didrocks | sil2100: do you mind having a quick look, quick bisect if needed? | 08:12 |
| sil2100 | Uuuu | 08:12 |
| sil2100 | Ok, checking that then | 08:12 |
| didrocks | thanks :) | 08:12 |
| didrocks | sil2100: btw, I plan to kill the staging ppa as we either have the daily-build ppa | 08:12 |
| didrocks | sil2100: and if you need something in between as packaging is inline, it's just about bzr branch -r <rev> && bzr bd | 08:12 |
| didrocks | thoughts? | 08:12 |
| sil2100 | didrocks: fine with me currently ;) | 08:12 |
| sil2100 | It was useful when using quantal, but anyway lp:unity doesn't build properly on quantal anymore | 08:13 |
| sil2100 | Not sure if Trevinho or andyrock use staging still, but I suppose it's not a big deal to build a revision on your own | 08:13 |
| didrocks | sil2100: they should use raring anyway :) | 08:14 |
| didrocks | and yeah, not a big deal | 08:14 |
| didrocks | thanks sil2100 | 08:14 |
| didrocks | fginther: FYI ^ | 08:14 |
| sil2100 | So as far as I am concerned, we can let it RIP ;) | 08:14 |
| sil2100 | np | 08:14 |
| didrocks | sil2100: \o/ | 08:15 |
| didrocks | sil2100: keep me posted, I'm a little bit stressed about those regressions | 08:16 |
| didrocks | sil2100: if you need the rev number for the previous successful runs, I can give them to you | 08:16 |
| tsdgeos | mzanetti: ping-ie | 08:22 |
| mzanetti | tsdgeos: hey | 08:25 |
| tsdgeos | mzanetti: did you enable the running of qmluitests i saw? | 08:25 |
| mzanetti | tsdgeos: huh? where? | 08:25 |
| tsdgeos | maybe i saw wrong :D | 08:25 |
| mzanetti | I'm afraid | 08:25 |
| tsdgeos | ah right | 08:26 |
| tsdgeos | it's only the regular ones | 08:26 |
| tsdgeos | seen this failure https://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-autolanding/42/console ? | 08:27 |
| tsdgeos | mzanetti: ↑ | 08:27 |
| mzanetti | tsdgeos: yeah... I've seen this yesterday night once | 08:28 |
| mzanetti | tsdgeos: don't know yet whats wrong | 08:28 |
| tsdgeos | mzanetti: my test for dragging up the hud failed again, think i'll go with the retry pattern you created, that ok? | 08:32 |
| mzanetti | tsdgeos: is the dragging up the actual testcase or a helper? | 08:33 |
| tsdgeos | mzanetti: it is part of the testcase | 08:33 |
| mzanetti | tsdgeos: hmm.. yestderday you said it looked like its not dragging up far enough? | 08:34 |
| tsdgeos | i added another gu and didn't help | 08:34 |
| mzanetti | tsdgeos: ok... try that... in case something would be really broken the testcase would still reveal that... | 08:35 |
| tsdgeos | try that = retry? | 08:36 |
| mzanetti | tsdgeos: yes, we just need to make sure not to make them useless. but I guess its fine in this case too | 08:36 |
| tsdgeos | actually the first thing that fails is almost the first thing we test | 08:37 |
| tsdgeos | so i agree that if "something is really broken" | 08:37 |
| tsdgeos | it'll be found | 08:37 |
| === alan_g is now known as alan_g|afk | ||
| seb128 | hey unity-ers | 08:53 |
| seb128 | sil2100, hey, are you looking at the failing unity autopilot tests? (asking before having a look to not dup work) | 08:53 |
| sil2100 | seb128: yes | 08:59 |
| sil2100 | seb128: didrocks asked me in the morning already about those ;) | 09:00 |
| seb128 | sil2100, well I was wondering if you were already looking at it or if you needed help | 09:00 |
| seb128 | I wonder if those are still gcalctool issues | 09:02 |
| seb128 | sil2100, didrocks: gar, I think I know what's the issue is | 09:03 |
| seb128 | stupid one | 09:04 |
| seb128 | https://code.launchpad.net/~mathieu-tl/autopilot/gcalctool/+merge/154196 is buggy | 09:04 |
| seb128 | upstream reverted the .desktop name | 09:04 |
| seb128 | not the binary name | 09:04 |
| seb128 | so the process-name is wrong | 09:04 |
| seb128 | should be set back to gnome-calculator | 09:04 |
| seb128 | let me file a MR | 09:04 |
| * sil2100 sighs | 09:05 | |
| sil2100 | ;) | 09:05 |
| sil2100 | seb128: looking at unity release tests and indicator tests, well, it's not enough failures to be caused by just that | 09:06 |
| seb128 | it is | 09:06 |
| seb128 | we were around 3 | 09:06 |
| seb128 | we were around 30 last week | 09:06 |
| seb128 | and all icons* are due to that | 09:07 |
| sil2100 | Since I see gcalctool being opened | 09:07 |
| seb128 | sil2100, see the icon ones | 09:07 |
| seb128 | http://10.97.0.1:8080/job/ps-unity-autopilot-release-testing/126/label=autopilot-ati/testReport/junit/unity.tests.launcher.test_icon_behavior/LauncherDragIconsBehavior/test_can_drag_icon_below_bfb_Single_Monitor_outside_/ | 09:07 |
| seb128 | MismatchError: After 10.0 seconds test failed: [] != [<ApplicationLauncherIcon gcalctool.desktop id=126>] | 09:07 |
| seb128 | sil2100, they are opened but not closed for me | 09:07 |
| didrocks | seb128: good spot! | 09:08 |
| seb128 | didrocks, sil2100: https://code.launchpad.net/~seb128/autopilot/correct-calculator-name/+merge/154304 | 09:08 |
| didrocks | sil2100: btw, while we are at it, the indicators on nvidia had 3 failures | 09:08 |
| didrocks | sil2100: want free karma ^ | 09:08 |
| didrocks | sil2100: 1 on the other | 09:08 |
| didrocks | sil2100: so still have the same issue | 09:08 |
| didrocks | would be nice to get them working : | 09:08 |
| didrocks | :) | 09:08 |
| sil2100 | didrocks: I'm actually looking mostly at the indicator tests now, since those are failing less obviously ;) | 09:09 |
| didrocks | sil2100: sweet! | 09:09 |
| sil2100 | seb128: waiting for the merge diff to generate itself | 09:10 |
| didrocks | sil2100: click on the commit :p | 09:10 |
| sil2100 | didrocks: pfff ;p | 09:10 |
| sil2100 | ;) | 09:10 |
| sil2100 | I hate the test_super_h test, really really | 09:11 |
| didrocks | sil2100: but they are so super :p | 09:12 |
| sil2100 | I would hack-fix it by adding a silly sleep in front of it, grrr | 09:12 |
| seb128 | sil2100, diff is there | 09:12 |
| sil2100 | seb128: I approved it already ;) | 09:13 |
| === alan_g|afk is now known as alan_g | ||
| tsdgeos | Saviq: how do you test stuff with 30px/gu? got a retina display? | 09:35 |
| Saviq | tsdgeos, no | 09:35 |
| Saviq | mzanetti, ^ ? | 09:35 |
| tsdgeos | i can't see improvements | 09:35 |
| tsdgeos | the thing just shows partially on screen | 09:36 |
| tsdgeos | so it's hard to compare | 09:36 |
| Saviq | tsdgeos, make a screenshot ;) | 09:36 |
| tsdgeos | sure | 09:37 |
| tsdgeos | i was trying to compare animation | 09:37 |
| tsdgeos | but maybe that's not what i should be looking at :D | 09:37 |
| tsdgeos | i think i see the difference now | 09:40 |
| dandrader | The repository is incredibly big (~40 megs) comparing to what we actually have there. culprit is the history. I suppose we were adding and removing big (or a large number of small) graphical assets in the past? | 09:42 |
| mzanetti | Saviq: ? | 09:42 |
| dandrader | I wonder if it's feasible to remove that fat (i.e. stripping the graphical assets from bzr history) | 09:43 |
| tsdgeos | dandrader: it's because we "share" with "regular" unity | 09:43 |
| tsdgeos | mzanetti: it is about https://code.launchpad.net/~unity-team/unity/phablet.more-flexible-previews/+merge/150860 | 09:43 |
| dandrader | tsdgeos, hmm? | 09:43 |
| Saviq | tsdgeos, no it's not that | 09:43 |
| Saviq | tsdgeos, we just have all the assets that we had there before | 09:43 |
| Saviq | tsdgeos, like hardcoded images, backgrounds etc. | 09:44 |
| tsdgeos | Saviq: ok, i think dandrader was complaining about the push time, sorry | 09:44 |
| Saviq | mzanetti, tsdgeos had problems with checking the "flexible preview" MR - not enough screen real estate | 09:44 |
| tsdgeos | Saviq: mzanetti: https://code.launchpad.net/~unity-team/unity/phablet.more-flexible-previews/+merge/150860 changes the layout also in the tablet, is that ok? | 09:44 |
| dandrader | tsdgeos, the big repository size also reflects in push and branch time | 09:44 |
| Saviq | how do we test changes like that, btw? x/y/width/height ? | 09:44 |
| tsdgeos | makes the preview wider | 09:45 |
| tsdgeos | i agree it looks better | 09:45 |
| tsdgeos | but don't want designers coming after me :D | 09:45 |
| Saviq | mzanetti, you have the details ^ :) | 09:45 |
| mzanetti | tsdgeos: you can probably set GRID_UNIT_PX to 4 | 09:46 |
| mzanetti | that would scale everything down | 09:46 |
| tsdgeos | mzanetti: sure, as said, it changes the layouting for the nexus10 here | 09:47 |
| tsdgeos | is that expected by design? | 09:47 |
| nic-doffay | Could someone with compiz test a branch for me? | 09:48 |
| mzanetti | tsdgeos: what do you mean with change? | 09:48 |
| * tsdgeos gets some screenshots, it'll take a while | 09:48 | |
| dandrader | anyone voluteers to claim that review? https://code.launchpad.net/~dandrader/unity/phablet_tst_ResponsiveGridView/+merge/154310 | 09:51 |
| mzanetti | Cimi: ping | 09:51 |
| Cimi | mzanetti, pong | 09:51 |
| mmrazik | didrocks: 13.04 branches (cupstream2distro-config) should go to stacks/13.04/ , right? | 09:52 |
| mzanetti | Cimi: could you please help nic-doffay with his branch | 09:52 |
| didrocks | mzanetti: yeah, but not that week | 09:52 |
| didrocks | oupss mmrazik ^ | 09:52 |
| didrocks | mmrazik: I really don't have time to do that properly | 09:52 |
| Cimi | mm yes | 09:52 |
| mzanetti | hehe | 09:52 |
| didrocks | and we have the 100scopes, payement in dash | 09:52 |
| === dandrader is now known as dandrader|afk | ||
| Cimi | mzanetti, what do I need to do? | 09:52 |
| mmrazik | didrocks: we just need to adjust autolanding. So I'll just create the dir | 09:52 |
| mzanetti | Cimi: thanks. nic-doffay: send Cimi the link, he'll check it out | 09:52 |
| Cimi | mzanetti, nic-doffay ah no | 09:52 |
| tsdgeos | mzanetti: ok, it's not that different now that i see the screenshots, it just happens to wrap a word differently and changes the text "a lot" that is what gave me the tip | 09:53 |
| tsdgeos | http://imgur.com/eMTIS3s old | 09:53 |
| tsdgeos | http://imgur.com/A8eYJy0 new | 09:53 |
| Cimi | mzanetti, nic-doffay no raring here, and unity broken | 09:53 |
| Cimi | mzanetti, nic-doffay, MacSlow has raring I think :P (sorry mirco) | 09:53 |
| mzanetti | Cimi: no need to be raring | 09:53 |
| mzanetti | Cimi: its basic qmltests stuff | 09:54 |
| tsdgeos | mzanetti: so i'll approve i guess | 09:54 |
| Cimi | mzanetti, but I am not running compiz | 09:54 |
| MacSlow | Cimi, what's up? | 09:54 |
| mzanetti | tsdgeos: the thing this should fix is more the steps in between | 09:54 |
| didrocks | mmrazik: I told upstream to wait for next week :( | 09:55 |
| mmrazik | didrocks: cyphermox was pinging us yesterday | 09:55 |
| didrocks | mmrazik: if indicators doesn't want, they should be able to wait TBH | 09:55 |
| mmrazik | didrocks: ok | 09:55 |
| didrocks | for having autolanding set on trunk | 09:55 |
| mzanetti | tsdgeos: it should always look good, no matter how big the window is | 09:55 |
| tsdgeos | mzanetti: yes, i saw that, i was scared at the change at an "official" resolution | 09:55 |
| Cimi | mzanetti, so yes | 09:55 |
| Cimi | MacSlow, don't worry | 09:55 |
| Cimi | nic-doffay, ok branch? | 09:55 |
| Saviq | tsdgeos, mzanetti, there's no tests for the preview is there ;) | 09:55 |
| nic-doffay | Thanks Cimi: https://code.launchpad.net/~nicolas-doffay/unity/page-header-test | 09:56 |
| mzanetti | Saviq: no. not yet... this MP is hanging in the queue since before the feature freeze | 09:56 |
| Saviq | mzanetti, yeah I know | 09:56 |
| tsdgeos | Saviq: i know, but there weren't before, tbh it doesn't get us worse than we were and it's not really a new feature, so i myself wouldn't block on that, but if you prefer we can wait for it | 09:57 |
| Saviq | tsdgeos, nah, it's ok, let's clear the queue | 09:57 |
| * mzanetti can take care about testing the previews | 09:59 | |
| tsdgeos | dandrader|afk: i'll have a look at that MR | 10:00 |
| === dandrader|afk is now known as dandrader | ||
| dandrader | tsdgeos, thanks | 10:08 |
| Cimi | nic-doffay, so I tested, passes your tests, what's the one failing? | 10:25 |
| tsdgeos | mzanetti: mmrazik: https://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-autolanding/45/console ? | 10:26 |
| mzanetti | tsdgeos: hmm... no clue right now... persistent or temporary? | 10:28 |
| tsdgeos | first time i see it | 10:28 |
| tsdgeos | retry? | 10:28 |
| mmrazik | tsdgeos: retry. ps-panda-10 died | 10:29 |
| mmrazik | mzanetti: I start to fear these pandas are going to be hell | 10:29 |
| mmrazik | mzanetti: ps-panda-7 and -5 died yesterday | 10:29 |
| mmrazik | 10 today | 10:29 |
| tsdgeos | :S | 10:29 |
| mmrazik | we will be just restarting pandas all they long :-/ | 10:29 |
| nic-doffay | Cimi, how did you test it? | 10:29 |
| Cimi | nic-doffay, I edited the cmakelist | 10:30 |
| Cimi | nic-doffay, then I did make testPageHeader | 10:30 |
| nic-doffay | Can you go to test/qmluitests and run qmlscene tst_PageHeader.qml | 10:31 |
| nic-doffay | Cimi, ^ | 10:31 |
| Cimi | I can | 10:31 |
| Cimi | nic-doffay, and? | 10:31 |
| nic-doffay | Can you see the window Cimi | 10:34 |
| Cimi | nic-doffay, no | 10:34 |
| nic-doffay | You don't see qmlscene pop up at all Cimi ? | 10:35 |
| Cimi | nic-doffay, no | 10:36 |
| mzanetti | Cimi: it should be there... this is how it should look: http://wstaw.org/m/2013/03/19/plasma-desktopy16257.png | 10:38 |
| Cimi | mzanetti, well it's a file with a TestCase, obviusly it doesn't show | 10:39 |
| mzanetti | Cimi: ok... now I'm confused | 10:39 |
| mzanetti | yesterday it was wrapped in an Item | 10:40 |
| mzanetti | that might explain why it didn't work for nic | 10:40 |
| nic-doffay | I probably forgot to push my most recent changes. | 10:41 |
| nic-doffay | Let me check. | 10:41 |
| nic-doffay | Or rather I assumed I had. | 10:42 |
| nic-doffay | Doh! Cimi committed but not pushed soz. | 10:43 |
| nic-doffay | Can you pull and try again? | 10:44 |
| Cimi | nic-doffay, you also added an helloworld component under Components | 10:45 |
| Cimi | nic-doffay, watch out! :) | 10:45 |
| Cimi | nic-doffay, now shows up | 10:45 |
| Cimi | nic-doffay, you should move the PageHeader outside TestCase | 10:46 |
| Cimi | nic-doffay, you don't need to embed items inside TestCase, it's not requires | 10:46 |
| Cimi | nic-doffay, because all you care are the properties of PageHeader, and you can access *all* of them using the id | 10:47 |
| Cimi | pageHeader.propertyName | 10:47 |
| Saviq | MacSlow, your cpp would go into plugins/Notifications | 10:47 |
| Saviq | MacSlow, look in plugins/* to see how it's handled there | 10:47 |
| MacSlow | Saviq, so it has to become a pluging?! | 10:48 |
| MacSlow | Saviq, ok... didn't know that | 10:49 |
| Saviq | MacSlow, it doesn't _have_ to, but that's the best way | 10:49 |
| nic-doffay | Cimi, does the text show? | 10:49 |
| mzanetti | MacSlow: yep... make everything a plugin (with small exceptions - but I don't expect the notifications to be one of those) | 10:49 |
| Cimi | nic-doffay, it does once you move pageHeader outside the TestCase {} | 10:49 |
| nic-doffay | I'll do that then, thanks Cimi . | 10:50 |
| Saviq | MacSlow, you then go "import Ubuntu.Notifications 0.1" in the QML file when you need it | 10:50 |
| Saviq | MacSlow, I'll also have some comments, will reply to your email | 10:52 |
| didrocks | mmrazik: a lot of branches have been approved between few minutes and 2 hours ago and they are not merging: https://code.launchpad.net/ubuntu-scopes/+activereviews | 10:53 |
| tsdgeos | dandrader: made a new comment on the review, i think there's a row/column mixup in some variable names | 10:55 |
| dandrader | tsdgeos, ok, will check | 10:55 |
| MacSlow | Saviq, thx | 10:55 |
| mmrazik | didrocks: looking | 10:56 |
| dandrader | tsdgeos, right, it's mixed indeed | 10:57 |
| mzanetti | Saviq: I'm just catching up with blueprint changes | 11:00 |
| mzanetti | Saviq: transition to googletest? | 11:00 |
| mzanetti | can you elaborate? | 11:00 |
| mmrazik | didrocks: all were approved 10mins ago max | 11:00 |
| mmrazik | didrocks: I've triggered them manually | 11:00 |
| mmrazik | didrocks: but there is nothing wrong AFAICS | 11:00 |
| Saviq | mzanetti, yeah, for c++ tests (which we have almost none, so that transition will be easy) | 11:00 |
| didrocks | mmrazik: 10 minutes? | 11:00 |
| didrocks | let me recheck my email | 11:01 |
| Saviq | mzanetti, unless I'm not thinking about something? | 11:01 |
| didrocks | mmrazik: ok, I think that my thunderbird folder is stuck | 11:01 |
| didrocks | mmrazik: no email from the paste 1h30 on those branches | 11:01 |
| mzanetti | Saviq: I also don't really expect us to have non-Qt C++ stuff in unity-phablet | 11:01 |
| didrocks | mmrazik: sorry for the false positive, I should have rechecked on the branch itself | 11:01 |
| mmrazik | didrocks: no worries | 11:02 |
| mzanetti | Saviq: I don't really see the point in moving away from QtTest | 11:02 |
| Saviq | mzanetti, the point is to be consistent, and yes we will have non-Qt C++ stuff | 11:02 |
| Saviq | mzanetti, the "transport layer" of libunity, so all the APIs, will end up in the same repo | 11:03 |
| Saviq | so apart from implementations themselves | 11:03 |
| Saviq | everything that we expose as Unity APIs, will live with the shell in the same repo (obviously we need to reorganize the repo) | 11:04 |
| tsdgeos | mzanetti: can you reapprove https://code.launchpad.net/~aacid/unity/cleanHudApiWithFindChild/+merge/154067 i had to merge it with new stuff | 11:04 |
| Cimi | mzanetti, DashBar has properties like initialHeight and maxHeight, itemSize bla bla | 11:08 |
| Cimi | mzanetti, that obviusly have to be sane values | 11:09 |
| Cimi | mzanetti, (like setting 0 or negative will fail) | 11:09 |
| Cimi | mzanetti, does it make sense to test those? | 11:09 |
| davidcalle | seb128, stay in submarine, we still have a lot more one liner merge proposals for your inbox! ;) | 11:09 |
| seb128 | davidcalle, hehe, I wish there was a way to say "let me in the team so I can approve some MR if needed but stop spamming me" | 11:10 |
| gusch | tsdgeos mzanetti can you review? https://code.launchpad.net/~schwann/unity/rename-to-gallery-app/+merge/154324 | 11:11 |
| tsdgeos | gusch: works, want me to top approve already or need to coordinate stuff? | 11:13 |
| gusch | tsdgeos: you can just approve | 11:14 |
| tsdgeos | ok, done | 11:14 |
| gusch | tsdgeos: thx | 11:14 |
| tsdgeos | gusch: will you want a shell release today too? | 11:14 |
| gusch | tsdgeos: would be nice, but I have some links, so it works with the old one too (except the HUD) | 11:14 |
| tsdgeos | ok | 11:14 |
| gusch | tsdgeos: I put it back to "needs review" as mzanetti found an issue | 11:16 |
| tsdgeos | sorry :-& | 11:16 |
| tsdgeos | mzanetti: what is it? | 11:16 |
| tsdgeos | oh lol | 11:17 |
| tsdgeos | :D | 11:17 |
| dandrader | tsdgeos, is it ready to go now? https://code.launchpad.net/~dandrader/unity/phablet_tst_ResponsiveGridView/+merge/154310 | 11:20 |
| tvoss | kaleo, ping | 11:21 |
| davidcalle | didrocks, regarding https://bugs.launchpad.net/unity/+bug/1157660 is it with this morning merges on scopes? Because a reason for them not to appear can be a categy id mismatch between scopes and their respective master scopes, which has been merged only a moment ago for almost all scopes. | 11:22 |
| ubot5 | Launchpad bug 1157660 in Unity "We need to ensure that all scopes are started and search for by the server" [Undecided,New] | 11:22 |
| davidcalle | category* | 11:22 |
| didrocks | davidcalle: the server doesn't as well recommends everything | 11:23 |
| davidcalle | didrocks, ok | 11:23 |
| didrocks | davidcalle: anyway, it's a sanity check we need to do I guess :) | 11:23 |
| didrocks | so opened it more like "let's keep that on the radar" | 11:23 |
| davidcalle | didrocks, ok | 11:23 |
| gusch | tsdgeos mzanetti pushed the fix https://code.launchpad.net/~schwann/unity/rename-to-gallery-app/+merge/154324 | 11:26 |
| tsdgeos | aproved again | 11:27 |
| gusch | tsdgeos: thx | 11:27 |
| mzanetti | signed off | 11:27 |
| mzanetti | sorry for nitpicking... but it was so obvious out of line I had to mention it :D | 11:27 |
| === mmrazik is now known as mmrazik|lunch | ||
| tvoss | Saviq, ping | 11:39 |
| Saviq | tvoss, pong | 11:39 |
| MacSlow | mzanetti, Saviq: fyi... pushed my branch again... hooked up as a plugin (cmake picks it up now)... also made cleaner separation between frontend and backend | 11:45 |
| Saviq | MacSlow, I just replied | 11:45 |
| === dandrader is now known as dandrader|lunch | ||
| kaleo | tvoss: pong | 11:48 |
| tvoss | kaleo, cancel that, sent you an invite to an input method meeting next Monday, feel free to dispatch to the most appropriate person on your team | 11:48 |
| kaleo | k | 11:49 |
| kaleo | tvoss: I'm not sure I understand what it is though | 11:50 |
| tvoss | kaleo, integration of input method with the system and toolkits | 11:51 |
| tvoss | kaleo, I wasn't sure if sdk is interested, so I added you :) feel free to mark yourself optional, too | 11:51 |
| kaleo | tvoss: I'll add loicm | 11:52 |
| tvoss | kaleo, ack | 11:52 |
| === MacSlow is now known as MacSlow|lunch | ||
| === mmrazik|lunch is now known as mmrazik | ||
| Cimi | who wrote the original DashBar? | 12:01 |
| Cimi | just wondering if it is supposed to scroll if we have many lenses | 12:02 |
| mzanetti | Cimi: hmm... I think noone ever thought about having so many lens that it fills up the bar :D | 12:02 |
| mzanetti | Cimi: but yeah. very good point and also testcase | 12:02 |
| Cimi | mzanetti, there is sort of code already | 12:02 |
| Cimi | width: Math.min(Math.max(dashBar.width/2, units.gu(40)), count * itemSize) | 12:03 |
| om26er | Trevinho, hey | 12:13 |
| Trevinho | om26er: hi | 12:13 |
| om26er | Trevinho, in raring it seems when a window is opened maximized its not fully maximized | 12:14 |
| om26er | Trevinho, the right most part of the screen is occupied by the application that is opened behind | 12:14 |
| om26er | Trevinho, have you seen that ? | 12:14 |
| Trevinho | om26er: I don't... But both didrocks and andyrock did | 12:15 |
| om26er | Trevinho, then i will guess the bug is in good hands, i need not worry ;) | 12:16 |
| didrocks | yeah ;) | 12:17 |
| tsdgeos | mzanetti: https://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/142/artifact/qml_phone_shell.tests.testconfigurations.TestNexus10.test_hide_hud_click.ogv | 12:18 |
| tsdgeos | ?¿?¿?¿? | 12:18 |
| mzanetti | tsdgeos: dafuq | 12:20 |
| tsdgeos | exactly | 12:21 |
| tsdgeos | 36 seconds of nothing :D | 12:21 |
| mzanetti | tsdgeos: ah wait... this could happen if the shell doesn't load the home lens | 12:21 |
| tsdgeos | mzanetti: but the mouse didn't even try to click on the login field | 12:21 |
| mzanetti | tsdgeos: yeah... because it waits for the lens to be loaded and switched to the Home lens | 12:22 |
| mzanetti | tsdgeos: if that never happens the test aborts because the shell didn't start up | 12:22 |
| tsdgeos | i see | 12:22 |
| tsdgeos | so increase that 30? :D | 12:22 |
| mzanetti | tsdgeos: :/ | 12:23 |
| mzanetti | tsdgeos: I actually believe that wouldn't change anything | 12:23 |
| mzanetti | tsdgeos: I think theres something fishy in the logic that switches to the home screen | 12:24 |
| mzanetti | tsdgeos: as I've seen this on my desktop too every once in a while | 12:24 |
| tsdgeos | oh :/ | 12:24 |
| tsdgeos | may be | 12:24 |
| === dandrader|lunch is now known as dandrader | ||
| Cimi | mzanetti, how can I access first argument of an emitted signal through signalSpy? | 12:28 |
| Cimi | mzanetti, there's signalArguments but doesn't say much | 12:28 |
| === _salem is now known as salem_ | ||
| mzanetti | Cimi: in Qt/C++ you can get all the arguments as a QVariantList | 12:28 |
| Cimi | mzanetti, so not an easy way to access them in qml | 12:29 |
| mzanetti | Cimi: I guess in javascripts its just an array then | 12:29 |
| Cimi | ah ok | 12:29 |
| tsdgeos | can anyone quick review https://code.launchpad.net/~aacid/unity/run_on_devive_update_before_get/+merge/154348 ? | 12:30 |
| tsdgeos | it's an easy one, i promise :D | 12:31 |
| tsdgeos | mmrazik: ccache: FATAL: Could not create /var/cache/pbuilder/ccache/e/f/3bdb7d27ce3c81355980190e8fc4a4-1612312.o.tmp.stdout.ps-precise-server-amd64-smp.1608 (permission denied?) in https://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-autolanding/50/console | 12:32 |
| mmrazik | tsdgeos: looking | 12:32 |
| mzanetti | tsdgeos: approved | 12:32 |
| Cimi | Saviq, I am using model: Lenses {} : how do I get the number of lenses? model.count is undefined | 12:35 |
| Saviq | Cimi, did you look at lenses.cpp? | 12:35 |
| Cimi | no | 12:35 |
| Saviq | or lenses.h, even? | 12:35 |
| Saviq | do :) | 12:35 |
| Saviq | Cimi, http://bazaar.launchpad.net/~unity-team/unity/phablet/view/head:/plugins/Unity/lenses.h#L61 | 12:36 |
| Cimi | ok | 12:36 |
| Cimi | rowCount maybe | 12:36 |
| mmrazik | tsdgeos: No idea :-/ First time I see something like this. | 12:36 |
| mmrazik | lets see if it happens again | 12:37 |
| tsdgeos | mmrazik: maybe no free space? | 12:37 |
| Saviq | Cimi, note it's a method, not a property | 12:37 |
| mmrazik | tsdgeos: checked that. looks ok | 12:37 |
| tsdgeos | ok | 12:37 |
| Cimi | Saviq, indeed, that's why maybe | 12:37 |
| Cimi | :) | 12:37 |
| Cimi | Saviq, ok works | 12:38 |
| Cimi | Saviq, problem is, in my tests I want to be abstract I guess | 12:38 |
| Cimi | Saviq, so shouldn't be model.count the right usage? | 12:38 |
| Cimi | or I can keep using model.rowCount() in the tests, assuming I have Lenses {} as model? | 12:39 |
| Saviq | Cimi, rowCount() is required on models for a ListView | 12:39 |
| Cimi | ok | 12:40 |
| didrocks | sil2100: any news on the flacky tests? | 12:43 |
| === Pici` is now known as Pici | ||
| sil2100 | didrocks: with the gcalctool fix seb128 prepared, it's much better now - but the super_h super test will still fail from time to time, the proper fix to this issue requires some compiz hacking which I try to achieve, although I'm not sure if it's even worth the time ;p | 12:48 |
| Cimi | mzanetti, I have issues with signalSpy | 12:49 |
| sil2100 | didrocks: but I'm re-building indicator ap tests to see the results | 12:49 |
| didrocks | sil2100: ok thanks | 12:49 |
| Cimi | mzanetti, signalSpy detects two signals while there was only one | 12:49 |
| Cimi | detects to emitted signals | 12:50 |
| Cimi | *two | 12:50 |
| mzanetti | Cimi: you clear()ed it before? | 12:50 |
| sil2100 | didrocks: I already had a loose discussion about the lack of feedback from compiz during setting the compiz options, but it's a pain in the ass | 12:50 |
| Cimi | mzanetti, yes | 12:50 |
| didrocks | sil2100: yeah, should we set the trigger to 3? | 12:50 |
| didrocks | sil2100: as nvidia has 3 failures | 12:50 |
| didrocks | which is what is blocking the landing regularly | 12:50 |
| mzanetti | Cimi: hmm.. would need to see the branch then... | 12:50 |
| seb128 | sil2100, btw any news about https://code.launchpad.net/~sil2100/compiz/quickfix_1141079_raring/+merge/153430 ? | 12:50 |
| sil2100 | seb128: I fixed it up properly in the main compiz branch, but Sam also wants to have tests written for it - I'll try finishing those later today | 12:52 |
| sil2100 | Then we can have it merged | 12:52 |
| seb128 | sil2100, ok, thanks, we should have it fixed one way or another in raring | 12:52 |
| didrocks | 13:50:28 didrocks | sil2100: yeah, should we set the trigger to 3? | 12:52 |
| didrocks | 13:50:32 didrocks | sil2100: as nvidia has 3 failures | 12:52 |
| didrocks | sil2100: in case you missed it ^ :) | 12:52 |
| Cimi | mzanetti, ~unity-team/unity/phablet.dashBar_bottomswipe | 12:53 |
| Cimi | pushed | 12:53 |
| sil2100 | didrocks: no, let's maybe leave it as it is, if the proper fix will take too long I can always hack the super_h test, which would basically mean 2 less failing tests | 12:54 |
| Cimi | mzanetti, | 12:54 |
| Cimi | QDEBUG : qmltestrunner::DashBarTest::test_itemSelected() before click 0 | 12:54 |
| Cimi | QDEBUG : qmltestrunner::DashBarTest::test_itemSelected() onItemSelected, within DashBar | 12:54 |
| Cimi | QDEBUG : qmltestrunner::DashBarTest::test_itemSelected() after click 2 | 12:54 |
| sil2100 | didrocks: the one that is left was a failure caused by gcalctool, so it'll be fixed now anyway | 12:54 |
| Cimi | console.log("before click", signalSpy.count) | 12:54 |
| Cimi | // (item, x, y, button, modifiers, delay) | 12:54 |
| Cimi | mouseClick(dashBar, x, dashBar.height / 2, Qt.LeftButton, Qt.NoModifier, 0) | 12:54 |
| Cimi | console.log("after click", signalSpy.count) | 12:54 |
| didrocks | sil2100: ah, so we should relaunch? | 12:54 |
| mzanetti | Cimi: ckecking out... please avoid pasting more than 3 lines in an irc channel | 12:54 |
| mzanetti | even if its 2x3 lines :D | 12:55 |
| sil2100 | didrocks: I relaunched, waiting for the result ;p | 12:55 |
| didrocks | sil2100: argh, you only relaunched the testing job | 12:55 |
| didrocks | sil2100: not the full stack | 12:55 |
| didrocks | so we'll need to relaunch it later on again | 12:56 |
| didrocks | sil2100: let me stop it and relaunch the full stack | 12:56 |
| === MacSlow|lunch is now known as MacSlow | ||
| sil2100 | didrocks: argh, ok, sorry about that | 13:07 |
| didrocks | no worry :) | 13:09 |
| sil2100 | fginther: hello! | 13:11 |
| sil2100 | fginther: I think it is time... | 13:11 |
| sil2100 | fginther: I think it is time, to say goodbye to staging :'( | 13:11 |
| fginther | sil2100, I'm prepping an email | 13:12 |
| * sil2100 gets all teary | 13:12 | |
| fginther | sil2100,, it had a good run | 13:12 |
| sil2100 | Yes... | 13:12 |
| om26er | i marked this bug 1087534 critical. as it affects large number of users | 13:15 |
| ubot5 | bug 1087534 in unity (Ubuntu Raring) "[regression] Corrupted blurred overlays" [Critical,Confirmed] https://launchpad.net/bugs/1087534 | 13:15 |
| dandrader | mmrazik, what can I do about it? https://code.launchpad.net/~dandrader/unity/phablet_tst_ResponsiveGridView/+merge/154310/comments/336431 | 13:24 |
| mmrazik | dandrader: qml_phone_shell.tests.testconfigurations.TestNexus10.test_hide_hud_launcher is failing | 13:25 |
| mmrazik | dandrader: are you asking how to fix that? | 13:25 |
| mmrazik | dandrader: maybe this helps: https://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/148/ ? | 13:26 |
| dandrader | mmrazik, I didn't even manage to get this info :) | 13:26 |
| mmrazik | dandrader: I'm just working on fixing that | 13:26 |
| mmrazik | dandrader: i.e. fix the URLs in cases like this | 13:26 |
| dandrader | hmm, saw the line corresponding line in the log now | 13:27 |
| dandrader | from the channel backlog, seems like tsdgeos is already on it | 13:28 |
| Cimi | mzanetti, have an idea? I'm off for lunch btw | 13:29 |
| mzanetti | Cimi: sorry... haven't had the chance yet... | 13:29 |
| mterry | didrocks, cyphermox: thanks to whomever manually published unithy | 13:31 |
| mterry | excuse my lisp | 13:32 |
| didrocks | mterry: it's a join effort between seb128 and I | 13:32 |
| didrocks | mterry: we had some… experiments with UTAH and other stuff ;) | 13:32 |
| didrocks | so tried to unblocked everything | 13:32 |
| seb128 | mterry, hey, feeling better today? | 13:32 |
| didrocks | mterry: feeling better? | 13:32 |
| seb128 | mterry, we had some gnome-calculator having its .desktop renamed back to gcalcool.desktop fun as well :p | 13:33 |
| didrocks | oh right ;) | 13:33 |
| didrocks | almost forgot about it :p | 13:33 |
| mterry | I'm feeling a bit better ya | 13:35 |
| mterry | seb128, yeah I noticed that :-/ | 13:35 |
| tedg | mardy, I have gnome-keyring-daemon running on the Nexus 10, seems fine. Anything you want me to test specifically? | 13:44 |
| mardy | tedg: if you could also install libsecret-tools and play a bit with secret-tool, that would be great | 13:47 |
| mardy | tedg: like store a password, then retrieve it | 13:47 |
| tedg | mardy, Hmm, it's giving me an error: The '/org/freedesktop/secrets/aliases/default' object does not exist | 13:53 |
| tedg | mardy, I don't get that on my desktop, but the path doesn't exist there either... | 13:53 |
| tedg | Perhaps I need to restart to get the PAM module? | 13:53 |
| mardy | tedg: maybe it's a D-Bus object path | 13:54 |
| mterry | didrocks, is the unity team aware of UI Freeze coming up, just like they were for Feature Freeze? | 13:56 |
| tsdgeos | dandrader: failed again? | 13:56 |
| tsdgeos | sigh | 13:56 |
| dandrader | tsdgeos, yes. did you change anything? | 13:56 |
| tsdgeos | dandrader: no i just reapproved it :D | 13:57 |
| tsdgeos | it's a flacky test/code | 13:57 |
| tsdgeos | i mean other stuff is being merged fine | 13:57 |
| tsdgeos | it's not your fault | 13:57 |
| tedg | mardy, Hmm, not sure what's up. Probably just a lack of startup scripts though. | 13:57 |
| tsdgeos | dandrader: https://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/148/artifact/qml_phone_shell.tests.testconfigurations.TestNexus10.test_hide_hud_launcher.ogv | 13:57 |
| dandrader | hmmm, maybe we should deactivate the flaky test for now | 13:57 |
| tedg | mardy, Not having a proper boot on the touch stuff makes it hard to do A/B comparison. | 13:58 |
| dandrader | tsdgeos, yeah I watched it. nothing happens, right | 13:58 |
| tsdgeos | ah | 13:58 |
| tsdgeos | that's a second one | 13:58 |
| tsdgeos | fails in a different way | 13:58 |
| tsdgeos | this may actually be fixable | 13:58 |
| tedg | mardy, Do you think it's worth looking more? | 13:58 |
| tsdgeos | dandrader: leave it to me, i'll just reapprove your thing again | 13:59 |
| tsdgeos | and cross fingers :D | 13:59 |
| kgunn | hey anyone, i was working through instructions for building/running unityNext | 13:59 |
| dandrader | tsdgeos, yes, things happen in this new one | 13:59 |
| kgunn | had no prob | 13:59 |
| kgunn | building and running on phone shell on my desktop | 13:59 |
| tsdgeos | good :-) | 14:00 |
| mardy | tedg: unfortunately I don't know much of how it works | 14:00 |
| kgunn | but when i run ./run-on-device (& yes i did -s first) | 14:00 |
| tsdgeos | yes run-on-device still broken | 14:00 |
| mardy | tedg: you could try "echo mypassword | gnome-keyring-daemon --login" | 14:00 |
| tsdgeos | well not broken | 14:00 |
| tsdgeos | but https://code.launchpad.net/~aacid/unity/run_on_devive_update_before_get/+merge/154348 is missing | 14:01 |
| mzanetti | Cimi: its weird indeed... and I have seen the same when writing the Greeter tests | 14:01 |
| tsdgeos | kgunn: ↑↑ can you try adding this? | 14:01 |
| kgunn | tsdgeos: thanks | 14:01 |
| mzanetti | tsdgeos will fix it again :D | 14:01 |
| tsdgeos | fix what? | 14:01 |
| tedg | mardy, Yeah, I'm just curious what the goal is. I mean, when we have a proper desktop session and boot on the tablet things are likely to be drastically different. Right now it's a pile of hacks. | 14:01 |
| mzanetti | tsdgeos: you know the issue that SignalSpy.count equals 2 even though the signal has only be emitted once? | 14:02 |
| mardy | tedg: true, that's why IMHO it's essential to know how the users will log in | 14:02 |
| mardy | tedg: anyway, I also wrote to the GNOME keyring ML, let's see if we get some inputs from there; usually they are quite helpful | 14:03 |
| tsdgeos | mzanetti: first i hear | 14:03 |
| tedg | mardy, What do you mean? It'll be through lightdm, but in some cases there'll be an autologin password. | 14:03 |
| mzanetti | tsdgeos: I've seen it once and cimi now has the same issue... most likely its the combination of some bad code in signalspy and the way we use it. as it doesn't happen all the time | 14:03 |
| mardy | tedg: do the users type a password in order to login? | 14:04 |
| tedg | mardy, Not in all cases. Just like the desktop today. | 14:04 |
| tsdgeos | mzanetti: qtdeclarative is unstable as hell, i've been trying to get my improvement like 4 times, all of them tests failing in unrelated places | 14:05 |
| tsdgeos | actually ossi suggested me to wait a few days :D | 14:05 |
| mzanetti | hehe... is ossi actually with digia new? | 14:06 |
| mardy | tedg: OK, so in theory the same stuff that works on the desktop should work there too | 14:06 |
| tsdgeos | mzanetti: yep | 14:06 |
| tedg | mardy, yep | 14:07 |
| * tedg likes the symmetry of all conversations being at the same point in the channel | 14:07 | |
| mzanetti | wow! Cimi, I have some new findings... ping me when you're back | 14:07 |
| mardy | wow! Ted, I have some new finding... ping me when you're back | 14:10 |
| mardy | ;-) | 14:10 |
| Cimi | mzanetti, back | 14:11 |
| tsdgeos | mmrazik: https://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/153/console not existing? still not copied? | 14:12 |
| tsdgeos | or? | 14:12 |
| dandrader | mzanetti, do you clear your signalspy before using it. it can accumulate counts from other methods | 14:12 |
| mmrazik | tsdgeos: looks like it | 14:12 |
| mmrazik | tsdgeos: http://s-jenkins:8080/job/generic-mediumtests-runner/153/ | 14:12 |
| mzanetti | Cimi: I pushed a commit | 14:12 |
| dandrader | I mean, test methods | 14:12 |
| mzanetti | Cimi: it does not fix the issue, but makes it even more weird. | 14:12 |
| mmrazik | tsdgeos: oh... it says "Error during build publishing" | 14:13 |
| tsdgeos | what does that mean? | 14:13 |
| mzanetti | Cimi: there must be an issue in the SignalSpy. I'd say we need to use a fresh SignalSpy for every test case for now | 14:13 |
| mzanetti | dandrader: yes... clearing it | 14:13 |
| mmrazik | tsdgeos: https://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/153 | 14:13 |
| mmrazik | tsdgeos: I pushed the "Publish again" button | 14:14 |
| mzanetti | dandrader: signalSpy is 0 after clearing it, but then the next time its triggered it jumps to 2 immediately | 14:14 |
| tsdgeos | ah, ok | 14:14 |
| Cimi | mzanetti, I don't understand how to do it | 14:14 |
| Cimi | mzanetti, I am already clearing it | 14:14 |
| tsdgeos | mzanetti: another 36 seconds of nothing https://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/153/artifact/qml_phone_shell.tests.testconfigurations.TestNexus10.test_hide_hud_click.ogv | 14:14 |
| mzanetti | dandrader: weird thing, if I re-connect the signal it adds another one | 14:14 |
| dandrader | ah yeah, if you connect twice it will be called twice | 14:14 |
| Cimi | mzanetti, and jumps to 2, 4, 6, 8 | 14:14 |
| Cimi | mzanetti, try removing the compare | 14:15 |
| Cimi | mzanetti, and see the console.log | 14:15 |
| mzanetti | dandrader: the QML api has a string property for the signalName | 14:16 |
| mzanetti | dandrader: I expect setting that to "clicked", then "" and then again to "clicked" should first end up being connected only once, no? | 14:16 |
| dandrader | you could create your own object and connect the signal to it instead of using signal spy. so you can add a console.log everytime it's called etc. just to rule out any issue in signalspy itself | 14:17 |
| tsdgeos | maybe the qml api "forgets" to unconnect on change | 14:17 |
| tsdgeos | may be noone thought of that... | 14:17 |
| mzanetti | did that already | 14:17 |
| mzanetti | it IS only emitted once | 14:18 |
| dandrader | mzanetti, ok, then it looks like you might have a bug fix for signal spy coming your way | 14:19 |
| kgunn | dandrader: i was mulling over some MR's, just noticed some magic numbers & references to horiz/vert spacing, e.g. tst_ResponsiveGridView.qml | 14:19 |
| kgunn | will that work for diff screens/pix densities? | 14:19 |
| kgunn | and will change in orientation effect it ? | 14:20 |
| dandrader | kgunn, that test set specific sizes and checks for results from those hardcoded sizes | 14:20 |
| kgunn | dandrader: ah, so totally mocked...you don't care about a real target | 14:21 |
| dandrader | kgunn, no | 14:21 |
| dandrader | kgunn, but it will work for different pixel densities as it uses units.gu() instead of pixels directly | 14:21 |
| Cimi | mzanetti, I also tested changing target | 14:21 |
| Cimi | mzanetti, it does indeed increase by 1 | 14:22 |
| dandrader | kgunn, although that doesn't really matter for a unit test in the end | 14:22 |
| Cimi | mzanetti, so it jumps by 3 now | 14:22 |
| kgunn | dandrader: right...all just mocked for purpose of test | 14:27 |
| kgunn | suppose integration testing a bit diff | 14:28 |
| mzanetti | Cimi: yep... so definitely a bug in SingalSpy | 14:28 |
| Cimi | mzanetti, I can do a clear every for cycle | 14:32 |
| Cimi | mzanetti, and check for positive count | 14:32 |
| mzanetti | Cimi: that's how I worked around it for now, yes | 14:32 |
| Cimi | ok | 14:32 |
| mzanetti | Cimi: not ideal, but gets you going for now | 14:32 |
| Saviq | dednick, nic-doffay: standup? | 14:33 |
| nic-doffay | Yep one second Saviq | 14:33 |
| mzanetti | Cimi: feel free to revert my change again... its not any good. I just wanted to show that there must be something wrong in SignalSpy | 14:41 |
| Cimi | mzanetti, little help in getting the argument of signalSpy? | 14:42 |
| Cimi | mzanetti, console.log(signalSpy.signalArguments[i]); prints | 14:43 |
| Cimi | [object Object] | 14:43 |
| Cimi | is there a toString? :) | 14:43 |
| === dandrader is now known as dandrader|afk | ||
| Saviq | Cimi, the "small task" for this afternoon - please extract the CMake tweaks from your MR into a separate proposal | 14:43 |
| Cimi | Saviq, ok | 14:44 |
| mzanetti | Cimi: hmm... I never used the QML one with arguments so far. but try signalArguments[0][0]. | 14:44 |
| Cimi | ok | 14:44 |
| mzanetti | Cimi: could be a 2 dimensional array where the first one is the index of the emission | 14:44 |
| mzanetti | and the second one the index of the argument | 14:45 |
| Cimi | mmm weird | 14:45 |
| Cimi | hold on | 14:45 |
| * mzanetti is holding on | 14:46 | |
| Cimi | mzanetti, I found something even more weird | 14:46 |
| mzanetti | haha | 14:46 |
| Cimi | mzanetti, pushin in 10 sec | 14:46 |
| Cimi | mzanetti, pull | 14:48 |
| Cimi | mzanetti, oh no | 14:49 |
| Cimi | mzanetti, don't look | 14:49 |
| Cimi | mzanetti, I forgot I was using clear() | 14:50 |
| didrocks | mterry: re UIF: no, please feel free to send them an email | 14:56 |
| didrocks | mterry: if you do so, can you have QA, indicators and webapps guys on the loop? | 14:56 |
| mterry | didrocks, is there a single list that will hit them all? product-strategy? | 14:56 |
| didrocks | mterry: yeah, sounds the right list :) | 14:57 |
| mterry | didrocks, nice 1 day warning :) | 14:57 |
| didrocks | mterry: enough? :-) | 14:58 |
| === dandrader|afk is now known as dandrader | ||
| sil2100 | grr, new AP failures | 15:02 |
| pitti | Trevinho: thanks for the next review! Just back from meeting, but my head can't sustain more hacking today | 15:04 |
| Trevinho | pitti: no worries :) | 15:04 |
| Trevinho | pitti: anyway I think we can merge it as soon as you apply that patch | 15:04 |
| pitti | Trevinho: so the remaining issue is to apply your patch for the fallback on logout, right? | 15:05 |
| Trevinho | pitti: yes | 15:05 |
| Trevinho | pitti: I know is probably even too much, but it's always better to cover all the corner cases in the same way :) | 15:05 |
| Cimi | Saviq, I don't think I have time to seriously refactor the behaviour with the launcher for today :( | 15:05 |
| pitti | Trevinho: fair enough :) | 15:05 |
| Cimi | Saviq, I pushed the last fixes for the tests though, and removed the cmake modification https://code.launchpad.net/~unity-team/unity/phablet.dashBar_bottomswipe/+merge/150847 | 15:06 |
| pitti | Trevinho: actually, this doesn't look very complicated, I'll try/review that right now | 15:06 |
| Cimi | which is pushing (takes ages) | 15:06 |
| Saviq | Cimi, I understand, it's under ~unity-team, so someone will take over | 15:06 |
| Saviq | Cimi, tsdgeos has a trick for pushing - `bzr push --stacked-on bzr+ssh://.../unity/phablet` | 15:07 |
| Trevinho | pitti: no.. I just add a new special method, in the lambda form | 15:07 |
| Cimi | Saviq, having the tests running, now should be easier to port and see if still works fine | 15:07 |
| Saviq | Cimi, yup | 15:07 |
| pitti | Trevinho: the magic of C++ :) | 15:07 |
| didrocks | mmrazik: didn't follow/remember if you deployed the evolution scope | 15:07 |
| didrocks | for upstream merger | 15:07 |
| tsdgeos | Saviq: Cimi: for completion i just did bzr push --stacked-on bzr+ssh://bazaar.launchpad.net/+branch/unity/phablet/ lp:~aacid/unity/testShowLauncherCorrectly | 15:07 |
| Trevinho | pitti: yeah, c++11 is something to love :) | 15:07 |
| didrocks | mmrazik: just approved https://code.launchpad.net/~submarine/ubuntu-scopes/evolution-fix-packaging-tests/+merge/154119 if you want to track | 15:07 |
| pitti | Trevinho: ah, so that's factoring out the "except" plus "else" cases, nice | 15:07 |
| Trevinho | pitti: yeah... I would have preferred to pass the lambda to the call (without adding a new lambda) | 15:08 |
| Trevinho | pitti: but the signature would have inclduedd a gerror, and I should have generated one... | 15:08 |
| Trevinho | so, i preferred this one | 15:08 |
| pitti | so the test cases nicely cover all possible combinations now | 15:09 |
| mmrazik | didrocks: can't recall either | 15:10 |
| mmrazik | let me check | 15:10 |
| mmrazik | didrocks: looks like no autolanding there yet... going to fix it | 15:10 |
| didrocks | mmrazik: thanks! | 15:11 |
| didrocks | mmrazik: should be the latest one | 15:11 |
| Cimi | Saviq, https://code.launchpad.net/~unity-team/unity/phablet.unittests_new-cmake/+merge/154401 | 15:13 |
| Saviq | Cimi, thanks | 15:13 |
| pitti | Trevinho: MP updated | 15:14 |
| pitti | and with that, good night! | 15:14 |
| tsdgeos | mzanetti: https://code.launchpad.net/~aacid/unity/testShowLauncherCorrectly/+merge/154399 | 15:15 |
| Trevinho | pitti: good night, I'll approve the branch asap | 15:15 |
| pitti | thanks! | 15:16 |
| mzanetti | tsdgeos: I think Cimi extended your mouseFlick function to support being slower. might worth looking into that | 15:17 |
| tsdgeos | mzanetti: he did, this is autopilot stuff ;-) | 15:18 |
| mzanetti | haha | 15:18 |
| mzanetti | right | 15:18 |
| mzanetti | today is one of those days... | 15:18 |
| mzanetti | tsdgeos: I'll wait for -ci to report | 15:19 |
| tsdgeos | sure | 15:22 |
| tsdgeos | mzanetti: any idea how to tackle the "36 seconds of nothing" one? | 15:22 |
| === alan_g is now known as alan_g|tea | ||
| mzanetti | tsdgeos: tbh I think that needs to be fixed in code, not in the test | 15:22 |
| tsdgeos | sure | 15:23 |
| * tsdgeos opens "the code" | 15:23 | |
| mmrazik | didrocks: landed | 15:23 |
| didrocks | mmrazik: thanks! | 15:24 |
| === alan_g|tea is now known as alan_g | ||
| mzanetti | Saviq: fyi: https://code.launchpad.net/~mrazik/jenkins-launchpad-plugin/1149232/+merge/154388 | 15:27 |
| Saviq | mzanetti, thanks | 15:27 |
| tsdgeos | who's working on compiz nowadays? | 15:34 |
| seb128 | tsdgeos, not a lot of people, sil2100 is doing some work, smpillaz still some as community member as well | 15:34 |
| tsdgeos | ok | 15:35 |
| tsdgeos | something broke in it | 15:35 |
| seb128 | with qt menus? | 15:35 |
| tsdgeos | i've a weird regression regarding the kde open dialog popups | 15:35 |
| tsdgeos | not the same but maybe related | 15:35 |
| tsdgeos | do you have a pointer for that qt menus bug? | 15:35 |
| seb128 | tsdgeos, could be the same as https://code.launchpad.net/~sil2100/compiz/quickfix_1141079_raring/+merge/153430 | 15:35 |
| seb128 | bug #1141079 | 15:36 |
| ubot5 | bug 1141079 in compiz (Ubuntu) "[regression-r3606] Compiz broken with QT menus/floating controls in 13.04" [Undecided,In progress] https://launchpad.net/bugs/1141079 | 15:36 |
| tsdgeos | let's try to build compiz | 15:36 |
| mzanetti | mterry: I guess we (as in unity-phablet) are not really affected by the ui freeze mail you wrote, right? | 15:38 |
| mterry | mzanetti, right, this is just for raring | 15:38 |
| * mzanetti is still confused about raring | 15:39 | |
| sil2100 | tsdgeos, seb128: use this fix here: | 15:39 |
| sil2100 | https://code.launchpad.net/~sil2100/compiz/quickfix_1141079 | 15:39 |
| sil2100 | Since the one in the raring branch is causing a regression, this one here should be more safe | 15:39 |
| tsdgeos | ok | 15:40 |
| sil2100 | tsdgeos: still working on the test, since I never used the compiz testing environment | 15:43 |
| mterry | mzanetti, basically, raring is unchanged in original plan. just reduced from 18m support to 9m | 15:46 |
| mzanetti | mterry: yes. but what confuses me is what of the phablet stuff will be released to raring and what doesn't | 15:46 |
| mterry | mzanetti, ah. I don't think any? | 15:46 |
| mterry | mzanetti, besides qt5 and the qml gwibber rewrite | 15:47 |
| Saviq | tsdgeos, are you using colocated branches, by any chance? | 15:47 |
| mzanetti | mterry: autopilot-qt too I think... at least cyphermox is working towards it | 15:47 |
| Saviq | tsdgeos, ignore, unrelated | 15:48 |
| tsdgeos | Saviq: what's a colocated branch? | 15:48 |
| tsdgeos | ok :D | 15:48 |
| Saviq | tsdgeos, git-like | 15:48 |
| tsdgeos | ah | 15:48 |
| tsdgeos | nope | 15:48 |
| mzanetti | mterry: anyways, did you see my greeter comments? | 15:48 |
| Saviq | tsdgeos, so you can "bzr switch colo:branch" | 15:48 |
| Saviq | tsdgeos, without having checkouts all over the place | 15:48 |
| tsdgeos | i see | 15:49 |
| tsdgeos | nah, folders all over! | 15:49 |
| didrocks | davidcalle: https://code.launchpad.net/~submarine/unity-scope-home/more-masters/+merge/154397 \o/ | 15:54 |
| === alan_g is now known as alan_g|afk | ||
| mterry | mzanetti, yes I saw your comments, but am pretty busy now, so wont' fix for a bit | 15:55 |
| mzanetti | mterry: hmm... ok.. then I'll have to pick it up probably... as the current tests rely on demo-assets | 15:55 |
| didrocks | mterry: come on, I heard you are sleeping at night! | 15:56 |
| didrocks | you should stop during that :p | 15:56 |
| didrocks | commitment! ;) | 15:56 |
| mterry | didrocks, dream coding should be a thing | 15:56 |
| didrocks | +1 ;) | 15:56 |
| davidcalle | didrocks, ;) | 15:56 |
| didrocks | sil2100: keep up the good work! | 15:59 |
| === alan_g|afk is now known as alan_g | ||
| === mmrazik is now known as mmrazik|otp | ||
| tsdgeos | sil2100: hero! fixes my regression too :-) | 16:05 |
| tsdgeos | mzanetti: having a look at the dash loading thing, have you really sometimes gotten "nothing" after opening the greeter on your pc? | 16:07 |
| tsdgeos | the code looks pretty straighforward to me | 16:08 |
| tsdgeos | don't see where it could fail to load | 16:08 |
| tsdgeos | mzanetti: and given the test only fails in the nexus10 i'd blame cpu speed time | 16:08 |
| tsdgeos | why never fails in the nexus7 or nexus4 tests? | 16:09 |
| mzanetti | tsdgeos: well.. .here the shell crashes right now unless I start it with -geometry >= 1600x1200 | 16:11 |
| mzanetti | tsdgeos: which is also one of the things I can't really explain yet | 16:12 |
| mzanetti | tsdgeos: but sure... give it a shot with increasing wait time for starting the test | 16:12 |
| tsdgeos | Saviq: gusch would welcome a shell release for the gallery rename, shall I? | 16:26 |
| tsdgeos | mzanetti: https://code.launchpad.net/~aacid/unity/testShowLauncherCorrectly/+merge/154399 approved by CI | 16:27 |
| didrocks | fginther: do you mind giving it a little of bootspeed? https://code.launchpad.net/~submarine/unity-scope-home/more-masters/+merge/154397 | 16:37 |
| fginther | didrocks, it's merged | 16:37 |
| didrocks | fginther: waow, good work :-) | 16:37 |
| didrocks | fginther: pasting links on IRC, didn't know that feature :p | 16:38 |
| fginther | didrocks, *sigh* if only it were always that easy | 16:39 |
| didrocks | ahah :) | 16:39 |
| tsdgeos | Saviq: mzanetti: gusch: https://code.launchpad.net/~aacid/unity/release164/+merge/154438 | 16:53 |
| gusch | tsdgeos: approved | 17:03 |
| === mmrazik|otp is now known as mmrazik | ||
| tsdgeos | gusch: tx | 17:10 |
| Saviq | tsdgeos, gusch approved | 17:14 |
| tsdgeos | okidoki | 17:14 |
| * tsdgeos eods | 17:14 | |
| tsdgeos | tomorrow more | 17:14 |
| Saviq | tsdgeos, cheers | 17:14 |
| Saviq | made it! | 17:14 |
| gusch | tsdgeos: have fun | 17:15 |
| tsdgeos | if anyone has time for https://code.launchpad.net/~aacid/unity/fix_hud_test_stubborness/+merge/154446 it'd be cool | 17:15 |
| tsdgeos | if not i'll harass mzanetti tomorrow :D | 17:15 |
| * tsdgeos waves | 17:15 | |
| === kgunn is now known as kgunnAFK | ||
| mterry | fginther, mmrazik: https://code.launchpad.net/~ps-jenkins/unity/latestsnapshot/+merge/154442 failed due to lack of space on device? | 17:50 |
| mmrazik | mterry: looks like that | 17:50 |
| mmrazik | let me check | 17:50 |
| fginther | mterry, why is the diff empty? | 17:50 |
| mterry | fginther, do not know | 17:51 |
| === mmrazik is now known as mmrazik|otp | ||
| === alan_g is now known as alan_g|life | ||
| === mmrazik|otp is now known as mmrazik | ||
| fginther | mterry, back on the subject of https://code.launchpad.net/~ps-jenkins/unity/latestsnapshot/+merge/154442 | 18:19 |
| fginther | mterry, it looks jenkins was doing a build of trunk, there was nothing merged into the build due to the empty MP | 18:20 |
| mterry | fginther, looks like 5 hours ago, it already merged a latestsnapshot | 18:21 |
| fginther | mterry, indeed | 18:23 |
| didrocks | sil2100: still around? | 18:37 |
| === mmrazik is now known as mmrazik|eod | ||
| didrocks | fginther: mind having a look? https://code.launchpad.net/~submarine/unity-asset-pool/more-master-scopes-icons/+merge/154423 | 18:50 |
| didrocks | mterry: fginther: on the bad merge, it's my fault (well, cu2d bug) | 18:51 |
| didrocks | it's because a published stack was partially rebuilt | 18:51 |
| didrocks | (which is wrong ;)) | 18:51 |
| didrocks | but I know how to circumvent it | 18:52 |
| didrocks | just need… time :/ | 18:52 |
| fginther | didrocks, I reapproved to retry as it looks like a transient error. If it fails again, I'll take a closer look. | 18:55 |
| didrocks | thanks fginther | 18:55 |
| === mmrazik|eod is now known as mmrazik | ||
| === JanC_ is now known as JanC | ||
| === kgunnAFK is now known as kgunn | ||
| sil2100 | didrocks: yes ;) | 19:52 |
| sil2100 | didrocks: just starting my second shift! | 19:52 |
| didrocks | sil2100: second on the third right? | 19:53 |
| didrocks | sil2100: the 3rd is during you sleep night ;) | 19:53 |
| sil2100 | ;) | 19:53 |
| didrocks | sil2100: wait for 10 minutes, I'll get some new results | 19:54 |
| didrocks | sil2100: ok, I think it will be tomorrow. I'll probably need some of your autopilot-debugging magic :) | 20:00 |
| didrocks | sil2100: right now, we have too many false positive to work that out | 20:00 |
| sil2100 | didrocks: I saw some failures last time indicators got ran - I prepared a workaround for the super_h issue | 20:03 |
| sil2100 | Now making it even better | 20:04 |
| didrocks | sil2100: sweet! | 20:04 |
| didrocks | sil2100: if you have time, there is the ps-unity-100scopes-experimental-autopilot-release-testing | 20:04 |
| didrocks | job | 20:04 |
| didrocks | sil2100: there is 160 failures | 20:04 |
| sil2100 | HOLY SHIT | 20:04 |
| sil2100 | ;) | 20:04 |
| didrocks | but it's using the "old" autopilot | 20:05 |
| didrocks | and I can't run it with the new one | 20:05 |
| didrocks | but looking at unity trunk | 20:05 |
| sil2100 | Ah | 20:05 |
| didrocks | we got 100 failures with the "old" autopilot | 20:05 |
| didrocks | so there is still a gap of 60 :/ | 20:05 |
| bschaefer | there was some failure in autopilot starting an app window IIRC | 20:05 |
| bschaefer | in trunk, which could cause ~15-20 failure | 20:05 |
| didrocks | bschaefer: yeap, that's the -100 :) | 20:05 |
| sil2100 | hm, the old 'quantal' autopilot and unity tests was far from being perfect, but maybe it's some common error | 20:05 |
| bschaefer | didrocks, o nice | 20:06 |
| didrocks | sil2100: it's not quantal | 20:06 |
| didrocks | raring? | 20:06 |
| sil2100 | hm, would have to see which autopilot it is using then, what version exactly | 20:06 |
| didrocks | sil2100: it's using ppa:ubuntu-unity/experimental-prevalidation | 20:07 |
| didrocks | autopilot is 1.2daily13.03.18-0ubuntu1 | 20:07 |
| didrocks | but still, that would be -100 | 20:07 |
| didrocks | so we still have 60 new failures | 20:07 |
| didrocks | sil2100: would be good if you can spot some of the new issues that happened | 20:08 |
| didrocks | basically comparing | 20:08 |
| didrocks | ps-unity-100scopes-experimental-autopilot-release-testing | 20:08 |
| didrocks | and | 20:08 |
| didrocks | ps-unity-autopilot-release-testing, run 124 | 20:08 |
| didrocks | sil2100: as it's the 100 scopes, we probably have some legit failures, now, do we have 60 of them? | 20:09 |
| sil2100 | Will see in a moment and check | 20:10 |
| didrocks | thanks sil2100 ;) | 20:14 |
| didrocks | fginther will give a hand as well ^ | 20:14 |
| didrocks | thanks you both | 20:14 |
| seb128 | cyphermox, so, new autopilot-qt fun | 20:22 |
| seb128 | cyphermox, it uses qt-declarative that isn't available on ppc | 20:22 |
| seb128 | cyphermox, can you hack the arch lists to exclude ppc? | 20:22 |
| seb128 | as a workaround | 20:22 |
| davidcalle | kenvandine, thanks! | 21:12 |
| kenvandine | davidcalle, will the merger get these? | 21:14 |
| kenvandine | i noticed there was no CI run | 21:14 |
| davidcalle | kenvandine, I think so. | 21:14 |
| kenvandine | i don't want didrocks to wake up to an uninstallable PPA :) | 21:14 |
| davidcalle | kenvandine, it takes a little time to run afaict. And no ci run directly after my mp, because it only runs on Canonical people commits. | 21:15 |
| kenvandine | ah | 21:16 |
| davidcalle | kenvandine, but I think that the PPA needs a manual action at some point. Well, it will be ready, anyway. | 21:16 |
| tigrang | andyrock, hey | 21:36 |
| andyrock | tigrang, hey | 21:40 |
| kgunn | Saviq: this is done right ? [schwann] transition Carousel to ListView to reduce memory: INPROGRESS | 21:41 |
| tigrang | andyrock, it's tigrangab from LP, mind giving me a quick rundown on how the tests work? | 21:44 |
| andyrock | first of all have a look at test/test_application_launcher_icon.cpp | 21:45 |
| andyrock | tigrang, ^^^ | 21:45 |
| tigrang | andyrock, ok, I think I can figure out writing the test, now figuring out how to test the test | 21:50 |
| andyrock | tigrang, test the test? write and run it removing the patch | 21:51 |
| andyrock | it must fail | 21:51 |
| andyrock | then apply the patch againg | 21:51 |
| andyrock | *again | 21:51 |
| andyrock | run the test | 21:51 |
| tigrang | I mean, how to run the test | 21:51 |
| andyrock | ah | 21:51 |
| andyrock | just do | 21:52 |
| andyrock | ./test/test-getst --gtest_filter="TestApplicationLauncherIcon.TestName" | 21:52 |
| andyrock | tigrang, ^^^ | 21:52 |
| tigrang | thanks :) | 21:52 |
| andyrock | tigrang, np | 21:55 |
| === salem_ is now known as _salem | ||
| andyrock | tigrang, i've to go now | 22:08 |
| tigrang | ok | 22:08 |
| Saviq | kgunn, yes | 22:27 |
| cyphermox | seb128: sure | 22:43 |
| cyphermox | that's kind of annoying :( | 22:43 |
| seb128 | yeah | 22:43 |
| seb128 | cyphermox, thanks | 22:44 |
| cyphermox | what's the syntax for that again... any !powerpc? | 22:44 |
| === kgunn is now known as kgunnAFK | ||
| TheMuso | /c/c | 23:58 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
