| mhall119 | cjohnston: I still get 4 tests failing on your 1.4 branch | 01:24 |
|---|---|---|
| daker | oh god :( | 01:27 |
| mhall119 | daker: it's not all that bad | 01:29 |
| daker | it was 1 test 4 hours ago | 01:29 |
| daker | mhall119: can you pastebin the log ? | 01:29 |
| mhall119 | yeah, give me a minute, I'm reviewing a different branch atm | 01:31 |
| mhall119 | daker: http://paste.ubuntu.com/5630001/ it looks to be the same 4 tests that always failed for me on that branch | 01:35 |
| mhall119 | cjohnston: ^^ | 01:35 |
| cjohnston | 11.59.20 < cjohnston> mhall119: https://code.launchpad.net/~chrisjohnston/summit/propose-meeting-not-attendee/+merge/153465 is updated to fix the tests from the 1.4 MP | 01:39 |
| daker | ya we have fixed test_update_from_launchpad_sets_participant_essential, right ? | 01:39 |
| mhall119 | oh, you expected me to be paying attention? | 01:39 |
| cjohnston | no | 01:41 |
| mhall119 | heh, good | 01:43 |
| mhall119 | I have to approve your 1.4 branch first, then the propose-meeting one, otherwise tarmac will freak out won't it? | 01:44 |
| cjohnston | yes | 01:44 |
| cjohnston | mhall119: does line 23 of https://code.launchpad.net/~chrisjohnston/summit/propose-meeting-not-attendee/+merge/153465 look ok? | 01:45 |
| cjohnston | that's what seemed to be causing the grief | 01:45 |
| mhall119 | cjohnston: yeah, it shouldn't happen in reality | 01:46 |
| mhall119 | I approved the 1.4 branch, and reviewed the propose-meeting branch | 01:46 |
| mhall119 | so you just need to mark it approved once the 1.4 branch is landed by tarmac | 01:47 |
| cjohnston | ok | 01:47 |
| cjohnston | ty | 01:47 |
| mhall119 | np | 01:47 |
| === neunon is now known as snoonan | ||
| rsajdok | daker: still the same problem | 10:23 |
| cjohnston | mhall119: doanac` is now the summit expert | 21:35 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!