| === Ursinha-afk is now known as Ursula | ||
| StevenK | wgrant: https://code.launchpad.net/~stevenk/launchpad/validate-milestone-tags/+merge/155171 and https://code.launchpad.net/~stevenk/launchpad/fix-translations-opening-specify/+merge/155375 | 00:04 |
|---|---|---|
| wgrant | StevenK: Looking | 00:36 |
| wgrant | StevenK: Is the translations fixer now sharing-safe? | 00:44 |
| StevenK | wgrant: I doubt it, what's required for that? | 00:44 |
| wgrant | StevenK: Was it written after the big message sharing migration? | 00:45 |
| wgrant | We don't want to revive a one-off script if it's no longer safe. | 00:45 |
| StevenK | wgrant: It was used for Quantal, at least | 00:45 |
| wgrant | Was it? | 00:45 |
| StevenK | Since it was hardcoded for that series | 00:45 |
| wgrant | Oh, I guess so | 00:45 |
| wgrant | So yeah | 00:46 |
| StevenK | wgrant: I'm happy to add a check for series.status, too | 00:46 |
| wgrant | StevenK: How does generalising that script fix that bug? | 00:47 |
| wgrant | At best it is a semi-fix for bug #576822 | 00:47 |
| _mup_ | Bug #576822: Add an option to clean up after a failed run of copy-translations-from-parent.py <lp-translations> <tech-debt> <Launchpad itself:Triaged> < https://launchpad.net/bugs/576822 > | 00:47 |
| StevenK | Ah, that is probably the bug I was aiming for | 00:47 |
| StevenK | wgrant: However, it sort of addresses it, but allowing ops to scorched earth translations for a series | 00:48 |
| StevenK | But only if you squint | 00:48 |
| wgrant | It probably makes it non-critical | 00:48 |
| wgrant | StevenK: Have you tested that the script works? | 00:49 |
| wgrant | Given that there are no tests. | 00:49 |
| wgrant | AFAICT | 00:49 |
| StevenK | scripts/fix-translations-opening -s warty deletes nothing against my dev instance, but it doesn't croak | 00:50 |
| wgrant | Can you find a series with translations? | 00:51 |
| StevenK | wgrant: http://pastebin.ubuntu.com/5648155/ :-( | 00:53 |
| wgrant | StevenK: Yeah | 00:56 |
| wgrant | So, that's because there are diverged messages | 00:56 |
| wgrant | DELETE FROM translationmessage WHERE potemplate IS NOT NULL; on your dev DB, and try again | 00:57 |
| StevenK | wgrant: http://pastebin.ubuntu.com/5648169/ | 00:58 |
| wgrant | Right. | 00:59 |
| === Ursinha-afk is now known as Ursinha | ||
| StevenK | wgrant: Can haz review, or do you still have concerns? | 02:09 |
| wgrant | StevenK: I've approved one, got distracted by users for the other | 02:10 |
| StevenK | wgrant: Ah, missed that. Landing the translations one now that I've corrected its bug link. | 02:13 |
| wgrant | StevenK: Does bug tag validation also use valid_name? | 02:16 |
| wgrant | StevenK: And what's _field_names for? | 02:17 |
| StevenK | wgrant: _field_names is only used by +edit | 02:17 |
| wgrant | StevenK: Is there a reason for it to be used? | 02:18 |
| StevenK | I can't change the _field_names property to field_names, because then I can't set it in the superclass | 02:19 |
| wgrant | StevenK: Also, you have two or so extendFields methods that do nothing but upcall. They can be deleted. | 02:19 |
| StevenK | wgrant: Looks like bug tags do widget validation | 02:22 |
| === jtv1 is now known as jtv | ||
| === almaisan-away is now known as al-maisan | ||
| === al-maisan is now known as almaisan-away | ||
| nigelb | Hrm, critical bugs are down to 130 now? | 03:51 |
| nigelb | whoa. | 03:51 |
| wgrant | Below 120, I think | 03:52 |
| wgrant | Yeah, 118 | 03:52 |
| nigelb | Um, how big is the LP team now? Just the 3 of you? | 03:52 |
| wgrant | 2 | 03:53 |
| nigelb | 33 | 03:53 |
| nigelb | (grr) | 03:53 |
| nigelb | I counted laura as well. | 03:53 |
| wgrant | Ah, yeah, but 2 engineers :) | 03:53 |
| wgrant | And mysteriously we're still making better progress than the entire period that we weren't on maintenance. | 03:53 |
| nigelb | *sadface* | 03:53 |
| nigelb | haha | 03:53 |
| nigelb | Yeah, I was about to say that. | 03:53 |
| nigelb | I guess you aren't introducing new bugs now ;) | 03:53 |
| * StevenK is about to make it be 117 | 04:20 | |
| StevenK | And I'm hoping wgrant has a branch or two for me, but that might be too optimistic. | 04:20 |
| nigelb | I still have a wip branch that I haven't gotten around to. | 04:21 |
| StevenK | I need to figure out what to land next, I have the last 9 branches on devel | 04:22 |
| nigelb | has spm left Canonical? Or just no longer idling here? | 04:23 |
| StevenK | nigelb: Yeah, he's gone. :-/ | 04:23 |
| nigelb | aww, I miss the fun with him around :( | 04:24 |
| czajkowski | adeuring: hows things? | 09:02 |
| adeuring | czajkowski: work is fun, we have now even some sunshine -- can't complain :) | 09:03 |
| czajkowski | I have snow.. still | 09:03 |
| czajkowski | less than impressed, more due this weekend | 09:03 |
| czajkowski | some easter it's gonna be | 09:03 |
| === cjwatson_ is now known as cjwatson | ||
| === cjohnston_ is now known as cjohnston | ||
| === cjwatson_ is now known as cjwatson | ||
| === wedgwood_away is now known as wedgwood | ||
| === wedgwood is now known as Guest28578 | ||
| === almaisan-away is now known as al-maisan | ||
| === Ursinha_ is now known as Ursinha-afk | ||
| === chrischr1s is now known as chrischris | ||
| === al-maisan is now known as almaisan-away | ||
| === OutOfControl is now known as benonsoftware | ||
| === wedgwood is now known as wedgwood_away | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!