[02:07] * wgrant throws rocks at SKS [02:10] wgrant: Oh? [02:10] Its 404 message has changed [02:10] That's why we're getting oopses from it [02:10] But it doesn't actually crash the page [02:10] What's one of the OOPSes? [02:10] OOPS-7d16107fdc9d638d26333ce4668d524e [02:12] I thought we dealt with both 404 and 500? [02:12] We do [02:12] But if the error message isn't plausible, we raise a soft OOPS [02:12] Ah [02:13] And they changed it [02:13] Yes [02:24] wgrant: So I can't find any OOPSes for "[^:]DistroSeries:+localpackagediffs" [02:24] StevenK: Probably because nobody uses it, potentially because it doesn't work [02:31] StevenK: https://code.launchpad.net/~wgrant/launchpad/sks-404-msg/+merge/155647 [02:49] wgrant: No fair landing something [02:50] wgrant: Meh, that was probably fair enough to be a self-review. r=me [02:52] Probably [02:52] But the r=wgrant in the log was getting a bit boring [02:53] Haha [02:53] Only because the last 9 landings on the trot have been mine [02:56] wgrant: It does load, though [02:57] Of course, now it times out for me. [02:57] StevenK: What or who loads? [02:57] * StevenK shoots Murphy in the face. [02:57] Oh, +localpackagediffs? [02:57] https://launchpad.net/ubuntu/raring/+localpackagediffs [02:58] 7.87s [02:58] Nice [02:59] 52 queries/external actions issued in 7.43 seconds [02:59] Yeah [03:00] It spends 300ms looking up the DSDs, and then 3.5seconds grabbing the publications [03:00] Yeah [03:00] Explaining now [03:00] It's using SPR.spn, which is probably the main problem [03:00] I missed another one :( [03:01] Can you also explain why it runs the query four times? [03:01] It's Launchpad, not Santa Claus. [03:01] Hey, you were on the team that wrote that page, not me :) [03:01] But I'd get an OOPS and check what calls it [03:01] Because that's hilarious [03:02] Total runtime: 90667.543 ms [03:02] ooh yeah [03:02] 350ms->65ms by dropping the SPR join [03:03] wgrant: http://pastebin.ubuntu.com/5651202/ [03:03] Oh right [03:03] wgrant: Just check that I'm not going insane, and it is [03:03] This is the derpquery [03:03] That has the completely strange anti-optimisation technique [03:03] To try to prevent it from using the index that is probably now optimal [03:03] AND SourcePackagePublishingHistory.archive+0 = Archive.id [03:04] 3ms [03:04] * wgrant enbranchinates [03:04] Ah [03:04] I was going to do that [03:04] Beh eh [03:04] No' [03:04] I get the trivial ones today, to let me escape from translations crap :)_ [03:05] And all four of them are different [03:05] Meh [03:05] I'll make them not suck [03:05] derived_series vs parent_series [03:05] Then we can separately eliminate the dupes [03:05] Ah [03:05] Anyway [03:05] Not so bad once they're a direct index scan [03:05] What's the traceback? [03:05] Not sure which func it is [03:06] I guess I could just grep for +0... [03:06] That +0 might be a red herring [03:06] I was pulling it from the query log [03:07] No [03:07] I remember the query [03:07] eager_load_dsds [03:07] It was deliberately used as an anti-optimisation technique [03:08] And the archive join is just pointless [03:08] Twitch [03:08] It's limited to purpose PRIMARY, though [03:08] # XXX: GavinPanella 2011-06-23 bug=801097: The + 0 in the condition [03:09] # below prevents PostgreSQL from using the (archive, status) index on [03:09] # SourcePackagePublishingHistory, the use of which results in a [03:09] get the ID :) [03:09] # terrible query plan. [03:09] Yeah [03:09] But you know what we can do instead... [03:09] Fetch self.context.main_archive.id ? [03:09] wgrant: Anyway, damn you for stealing my bug [03:10] Hmm [03:10] Now I have to find another. [03:10] May not be able to do this,a ctually [03:10] Because it cares about the parent [03:10] "#899003 deadlock detected when importing .po file" is likely going to die as a case of your chainsawing ? [03:10] <_mup_> Bug #899003: deadlock detected when importing .po file < https://launchpad.net/bugs/899003 > [03:11] Unlikely [03:11] Unless I rewrite rosetta [03:11] Pity [03:11] Maybe I should destroy the puller [03:11] That will keep me out of trouble for a long while [03:11] Heh [03:11] But I have no idea where jelmer got up to [03:11] A very very long while [03:12] We can't just transition the branches of type MIRRORED to code imports and destroy it? [03:12] You can get rid of mirrored branches just by migrating the existing ones, really, but that won't obviate the need for the puller. [03:12] The puller is still used for imports [03:13] I'm thinking of the broken netstrings critical [03:13] Migrating MIRRORED branches and dropping the type might close it, or at least drop it to Low [03:14] I don't think so [03:32] StevenK: https://code.launchpad.net/~wgrant/launchpad/bug-1160461/+merge/155651 [03:33] wgrant: v = ? Really? [03:33] Really! [03:33] I can change it if you want [03:34] I would prefer view = [03:34] And you're not trying to force a long line to be short enough [03:36] wtf [03:36] dsd indices are terrible [03:40] StevenK: Fixed. [03:41] I just saw [03:41] You're a terrible person [03:41] r=me [03:42] Thanks [03:44] And the 1s DSD-finding query is now mysteriously 2ms [03:44] (* may actually be index, not actual mysteriousness) [03:45] Haha [03:59] StevenK: https://dogfood.launchpad.net/ubuntu/quantal/+localpackagediffs [03:59] And that's without the DSD index [03:59] Still slow, but that's hopefully just because DF is DF [04:10] StevenK: https://code.launchpad.net/~wgrant/launchpad/localpackagediffs-rargh/+merge/155657 [04:17] wgrant: What's the index out of interest? [04:19] (derived_series, status, difference_type) [04:19] Not going to add it for now [04:19] But it's something we might want to look at later [04:20] wgrant: Going to link 801097 to the MP? [04:20] A good point. [04:21] wgrant: r=me [04:21] Thanks. [04:26] * StevenK glares at the critical list [04:27] wgrant: I do wonder about a BugJob that does notification [04:27] But I worry that I'd get murdered [04:30] StevenK: Sort of [04:31] I'd get sort of murdered? [04:31] Deferring recipient calculation by storing the criteria in a table would work [04:31] But it's a fair bit of work [04:32] wgrant: Suggestions for what I should look at, then? [04:32] Um [04:32] Stuff. [04:32] And things :) [04:32] Thanks for being so very helpful. :-P [04:33] I do wonder how txlongpoll is run, WRT 960868 [04:33] It might almost be worth making another pass at the loggerhead criticals [04:33] You can probably fix several of those in one day [04:33] But it's loggerhead ... [05:06] wgrant: How do I land stuff against loggerhead? [05:07] Hmmm, we're 7 revs behind [05:17] Should just need to commit directly to trunk [05:17] Check the recent history [05:31] wgrant: We have no codebounce on staging/qas ? [05:32] StevenK: Yes, it's there === _mup__ is now known as _mup_ === teknico_ is now known as teknico === teknico_ is now known as teknico === BradCrittenden is now known as bac === frankban_ is now known as frankban [13:18] * jelmer waves [13:18] jelmer: boo [13:18] StevenK: migrating MIRRORED branches to code imports should do the trick [13:19] StevenK: I don't think there was a reason for not doing that, apart from the time it would take to manage that transition [13:19] czajkowski: hey hey :) === wedgwood_away is now known as wedgwood === wedgwood is now known as wedgwood_away === wedgwood_away is now known as wedgwood === wedgwood is now known as wedgwood_away === wedgwood_away is now known as wedgwood === teknico is now known as teknico_mobile === teknico_ is now known as teknico_mobile_ === teknico__ is now known as teknico === teknico__ is now known as teknico_mobile === bac_ is now known as bac === wedgwood is now known as wedgwood_away [23:54] StevenK: Can you QA your loggerhead thing? [23:56] StevenK: And shouldn't that LH task be Fix Committed?