/srv/irclogs.ubuntu.com/2013/03/28/#juju-gui.txt

hatchoh ok00:01
hatchgary_poster: just ran it through on ec2 and it completed successfully with ie and firefox both failing the unit tests first then retrying00:22
hatchso...yay!00:22
hatchnow....canonistack....00:22
gary_posterhatch, heh, weird, but kinda good.00:25
hatchI just forwarded you the response from sauce labs00:26
hatchbasically saying that it can't be caching00:26
hatchbut now....haircut :)00:27
hatchhave a good night00:27
gary_posteryou too hatch, thx00:27
=== rick_h_22 is now known as rick_h_droid
teknico rogpeppe, hi, are you landing your lp:~rogpeppe/juju-core/259-charm-relation-name branch soon? it's conflicting with trunk in state/state.go, and I'm not confident enough to fix it myself11:27
rogpeppeteknico: yeah, i was planning to land it any time now. would you like me to hold off for a bit?11:32
teknicorogpeppe, uh? not at all, why would I? please go ahead :-)11:34
rogpeppeteknico: oh, cool; sorry i misunderstood.11:34
teknicorogpeppe, my command of the English language is definitely not up to these kinds of nuances :-)11:35
rogpeppeteknico: your english is great! i wasn't quite clear what you wanted though.11:36
teknicorogpeppe, since the AddRelationResults struct is now going to contain just Endpoints []state.Endpoint , I wonder whether I even need to define it11:45
rogpeppeteknico: the result of an api call must always be a struct11:46
teknicorogpeppe, oh, ok then11:47
rogpeppeteknico: i think i was thinking it would probably be better as Endpoints map[string]state.Endpoint11:47
teknicorogpeppe, oh right, sorry, I neglected that part11:48
teknicothanks for reminding me11:48
teknicorogpeppe, uhm, actually yesterday you suggested returning map[serviceName]charm.Relation, I wonder which one's best11:51
rogpeppeteknico: sorry, that's what i mean11:51
rogpeppeteknico: you can't return state.Endpoint11:51
teknicoright11:51
=== benji___ is now known as benji
rogpeppeteknico: that branch has now landed11:57
teknicorogpeppe, awesome, thanks again for all your work!11:58
rogpeppeteknico: np11:58
gary_posterrick_h_, hi.  I haven't been looking too carefully at the latest css changes, but please don't break the degree of responsiveness we had before.  Things look more or less ok right now, but I get nervous when I read "The new header is not yet responsive." from huwshimi.  Note that I do currently see a regression on the behavior when I resize the window: the right and bottom scrollbars are in place when calculations a12:48
gary_posterre made, add then removed when the new size is set.  This leaves gray bars at the right and bottom when it happens.  The way we solved that in the past was to shrink the interface to the smallest acceptable size before calculating dimensions, and then expanding it back out.12:48
bacguihelp: last week did we agree to not require "one 'var' per variable" or to forbid it?12:48
rick_h_gary_poster: definitely, I make sure to qa these before they ok'ing them. I'm also nervous as he's trying to start big picture where I'd prefer if he worked from our browser code up12:48
bacexcept in the case where it is multiline12:48
gary_posterbac we agreed to have multiple single line variables per "var"12:49
bcsallerbac: for simple assignments I think we made it optional, for complex (multiline) assignments its required12:49
gary_posterbut one "var" per multiline variable12:49
gary_posteryeah, would be fine with what bcsaller said, though I don't remember that specifically.12:50
rick_h_gary_poster: yes, hatch caught the width issue and noted it in the MP but ok'd it. I'll create a bug and assign it to Huw. I asked him last night to create bugs where appropriate from the comments made in the last MP12:50
bacin cases of ambiguity defer to bcsaller is my rule12:50
bcsallerha12:50
gary_postercool thanks rick_h_ .  It is pertinent to both width and height.  sounds good.12:51
=== teknico is now known as teknico_away
benjigary_poster: am I making a "Stable" release or a "Developer" release?  My guess is "Stable" but... development doesn't seem all that stable right at the moment. :)13:03
gary_posterbenji why not?13:09
benjiit's just that we are undergoing very active development, which I suppose is reflected in the 0.x nature of the verison numbers.  I just wanted to be sure I was doing the right thing.13:10
gary_posterstable and dev both benji, but let's have a quick guichat to make sure I am on the same page with you13:13
benjik13:13
* frankban lunches13:18
rick_h_hatch: bcsaller looking to include a markdown converter, any opinions on a library? Currently looking at PageDown https://code.google.com/p/pagedown/wiki/PageDown13:19
bcsallerrick_h_: you mean different from the gallery one we already provide in a handlebars helper?13:20
* gary_poster was just trying to connect those dots13:20
rick_h_bcsaller: /me goes peeking in the tree for something that might already be ther13:21
bcsallerapp/views/utils.js markdown helper13:21
rick_h_bcsaller: never mind :) 13:21
hatchgary_poster: any ideas what to do when canonistack fails?14:01
gary_posterhatch, weep?  consider tackling other tasks?  stare out the window?  rotate in chair?14:02
hatchlol14:03
gary_posterhatch :-P for your branch just keep getting that prepped for review.  I have a plan for at least killing the canonistack failures faster14:04
gary_posterI sketched it last night14:04
gary_posterthe only problem is a dependency14:04
hatchgotcha ok I'll get this up right away14:04
gary_postercool14:04
teknicogary_poster, hi, sorry, I'm late14:14
gary_posterteknico, oh hai :-)14:14
gary_posterteknico, one sec14:15
teknicosure14:15
hatchugh I hate it when I commit and forget to run make lint before lbox :)14:23
hatchwe should change lbox so that it runs lint before check :D14:23
hatchproposed14:26
gary_posterjujugui call in 214:29
benjinoooooooooooooooooooooo14:29
* benji reboots14:29
bachatch: the modellist bubble event did work as you described.  thanks.14:46
hatchexcellent14:46
MakyoIt's a hard life.  http://ubuntuone.com/gallery/56atUQ5IHr3CkOXeT605zL/IMG_20130328_084932.JPG14:55
frankbanrogpeppe: re apiinfo in the uniter agent.conf, do we have a bug for that, or do you want me to file one?14:58
hatchMakyo: hehe14:58
rogpeppefrankban: yeah, if you could file one, that would be great. but perhaps phrase it slightly differently: "we want our charm to know the address of the API. we're currently doing it like this. this solution (in uniter agent.conf) might be better"15:06
frankbanrogpeppe: filed bug 116144315:12
_mup_Bug #1161443: Make the API address easily accessible by charms <juju-core:New> <juju-gui:Triaged> < https://launchpad.net/bugs/1161443 >15:12
rogpeppefrankban: thanks! (and i added a comment giving my preferred solution - i'm still not sure if fwereade will go for it though)15:13
frankbanrogpeppe: thanks, an env var would be great15:13
gary_posterhey frankban, where is the charm log in juju- core15:21
gary_posterI found charm15:21
gary_poster/var/lib/juju/agents/unit-juju-gui-0/charm15:21
frankbangary_poster: /var/log/juju/15:21
gary_posterah15:22
gary_postercool15:22
gary_posterthanks15:22
frankbangary_poster: welcome15:22
gary_posterrick_h_, benji, the scrollbars are a worse regression than I thought15:29
benjiscrollbars?15:29
gary_posterrick_h_, benji, yes, I think we may need to revrt before we release15:29
benjioh, the "regression" part was what is meant to me15:29
benjis/to/fo/15:29
gary_posteryes :-)15:29
benjis/fo/for/15:29
* benji goes back to typing school.15:29
benjik, I'll not release until that is fixed15:30
gary_posterbenji, rick_h_ no matter how big my browser is, whhen I go to https://ec2-54-235-226-84.compute-1.amazonaws.com/ (which is trunk) I see scroll bars until I adjust15:31
gary_postertrying on uistage as well15:31
gary_posterbtw frankban qa for charm is great.  ,arking...15:31
gary_postermarking...15:31
frankbangary_poster: :-)15:32
benjihttps://ec2-54-235-226-84.compute-1.amazonaws.com/ has scrollbars for me in Chrome, none in Firefox15:32
gary_posterbenji what about http://uistage.jujucharms.com:8080/15:33
* benji looks15:33
benjiFF OK15:33
benjiChrome OK too15:34
gary_posterbenji me too. :-/ ok call off the dogs.  I guess we can make a release.  weird that it is specific to go env15:35
benjiquite weird15:35
hatchanyone have any objection to me upgrading us to Node 0.10.1 now that the regression is fixed?15:41
hatchbcsaller: gary_poster changes have been re-proposed15:42
hatchbcsaller: created a slacktask for your comments15:51
hatchI*15:51
bcsallerhatch: thanks15:51
hatchmy dogs can hear my neighbours car door close from 2 houses down but somehow they can sit right infront of my sub while my music is on15:52
hatchthe force is strong with these ones15:52
frankbangary_poster: http://jujugui.wordpress.com/2013/03/28/deploying-the-gui-in-a-juju-core-environment/15:52
benjihatch: upgrading sounds fine to me, with due caution of course15:52
hatchhttp://starwars.com/This-Is-Madness/15:53
hatchugh I can't believe Ahsoka Tano won over Captain Rex15:53
hatchbenji: yep of course :)15:53
hazmatfrankban, cool16:00
hazmatfrankban, how does the gui charm know if its py or go?16:00
frankbanhazmat: it checks whether or not ../agent.conf exists16:01
benjigary_poster: this bit of the release process doesn't seem right: "Check that read and execute permissions for all are present on all files16:17
benji  and directories, especially in the ``node_modules/`` directory.16:17
benji"16:17
benjithe not-right part is that not all the files do have the a+x bit set16:17
benjishould it be more like "all files are a+r and the files in node_modules are a+rx"?16:18
benji(I am writing a "find" command that will verify this for us in one step that I will add to the release instructions.)16:18
gary_posterhatch: no objections to Node 10.116:26
gary_posterhatch I gave you a LGTM so will only re-review if you request.  would you like me to look at it again?16:26
gary_posterfrankban, cool :-)16:27
frankban:-)16:27
hatchgary_poster: no I think the emails were delayed16:28
hatchit's been merged for a while now :)16:28
gary_postercool hatch :-)16:28
gary_posterbenji maybe so.  OTOH we can clean up that tarball now16:28
gary_posterdo we need node_modules now?16:28
gary_posterI forget16:28
gary_posterbut don't think so16:28
benjiI have no idea.  Shall I investigte?16:28
benjior shall I make a release and a card to investigate?  <hint> <hint>16:29
gary_posterbenji :-) +116:29
benjiI'll assume that the instruction that they should be executable is erronious and I will remove it.  If I am wrong, QA will tell me.16:30
gary_posterok benji16:30
hatchbcsaller: I'm pretty sure that we can utilize the new YUI Promises stuff to avoid our multiple rendering stuff16:34
benjiall these double backticks irritate me; probably the single biggest failign of reST16:35
hatchjcsackett: are you around?16:41
jcsacketthatch: for some definition thereof, sure. :-)16:42
hatchhaha - just wondering if you had a sec for a guichat so I can explain the questions16:42
jcsacketthatch: sure. guichat?16:42
jcsackette.g. hangout?16:42
hatchyup16:42
hatchi'm in16:43
jcsackettin what? is there a saved one i don't know about?16:43
hatchpmd16:43
gary_posterrogpeppe, hi.  is the "put all the info in the watcher that we need" branch already in review or near review, out of more than merely idle curiosity? :-)16:47
rogpeppegary_poster: no, i've been on other fixes, i'm afraid16:47
gary_posterah ok understood16:48
rogpeppegary_poster: if benji wants to take the reins, that would be fine16:48
rogpeppegary_poster: currently i'm delving into a couple of odd looking bugs in the AllWatcher16:48
gary_posterrogpeppe, ok it sounds like we ought to take the expose stuff then.  thank you16:49
gary_posterexpsoing the attrs we need, I mean16:49
rogpeppegary_poster: that would be great if you could, thanks.16:49
gary_posternp, thank you16:49
rogpeppegary_poster: i think i'm better doing what i am currently16:49
gary_posterrogpeppe, that was what I heard as well :-)16:50
MakyoNexus 10 just showed up in a box, wrapped in bubble wrap, inside another box, inside a bag, inside another bag.  V. thorough.16:50
gary_poster:-)16:51
gary_posterglad it appeared16:51
MakyoGood timing, too.  Should start getting dog ready for vet.  Won't be long.16:52
hatchMakyo: that's how my paperwork showed up from head office too16:54
hatchwrapped in about 3 recursive layers16:54
hatch:D16:55
hatchmaybe it's a policy16:55
hatchlol16:55
MakyoHah, yeah :)16:55
MakyoNo US wall charger, but oh well, just USB.16:55
hatchnow all we have to do is figure out how to run 120volts through a USB cable and we will have a universal power system16:58
hatch:)16:58
MakyoStill want my wireless charger.16:59
MakyoAnyway, dog to vet.  Back in a few.16:59
hatchcya16:59
gary_posterbye16:59
hatch:lbox: command not found17:00
hatchwth17:00
hatchheh17:00
hatchgary_poster: yep it needs to be changed in the charm too - but that's another branch17:18
hatch:)17:18
gary_postercool hatch17:18
rogpeppegary_poster: you might be relieved to hear that the first bug wasn't actually a bug in the allWatcher itself, but in the testing infrastructure around it.17:21
gary_poster:-) cool rogpeppe 17:21
teknicorogpeppe, have a look sometime? https://codereview.appspot.com/809404517:21
rogpeppegary_poster: i'm still not sure how to fix it though :-)17:21
gary_posterrogpeppe, lol, I have confidence17:21
rogpeppeteknico: looking (makes light relief!)17:22
rogpeppegary_poster: the problem is that we create the allWatcher immediately the mongo State is created, but then the test stuff sets the admin password, and that then denies access to the currently-running allWatcher...17:23
gary_posterheh17:23
rogpeppegary_poster: it was one of those "what the frick is happening?" bugs17:24
gary_posteryeah, I can imagine17:24
benjiI see these errors in Firefox:17:27
benjiTimestamp: 03/28/2013 12:24:13 PM17:27
benjiError: not well-formed17:27
benjiSource File: http://jujucharms.com/search/json?search_text=series%3Aprecise%20owner%3Acharmers17:27
benjiLine: 1, Column: 117:27
benjiSource Code:17:27
benji{17:27
benjiit doesn't seem to affect the apps performance, but it is still disquieting17:27
rick_h_benji: hmm, the json from there passes json linting17:29
rick_h_benji: maybe the response isn't sending a content-type back and FF wants to try html on it or something?17:31
hatchrick_h_ the events stuff was moved to an attr on purpose to avoid cross instance issues17:32
hatchas prototype properties are shared cross instance17:32
rick_h_hatch: but cant' it just go into the same section ATTRS lives in?17:33
rick_h_{ _events: [], ATTRS }17:33
rick_h_isn't that all isntance related stuff there from Base?17:33
hatchoh you want it to be a static?17:33
hatchhonestly I've never put it there17:34
rick_h_hatch: well, I just don't want to create events and such tied up to something that doesn't need it like this17:34
hatchhmm17:34
rick_h_a Base drive ATTR is a lot heavier than a private property17:34
hatchwell...17:34
rick_h_'feels wrong'17:34
hatchif we don't define the property then we can use 'this._events'17:34
hatchthen it will be scoped to the instance17:34
rick_h_right, that's what I mean17:35
hatchalthough then we have to be VERY sure that we are never calling this._events when the context is different17:35
rick_h__events is meant for two things, creating events and destructor cleanup17:35
rick_h_how else should it be accessed?17:35
rogpeppeteknico: reviewed17:36
hatchassume we have a callback executed under some other context and we go this._events...17:36
hatchthen it will point to the wrong context and those events won't be detached17:36
hatchwhereas this.get('_events') will fail17:36
rick_h_we should just get to adding an extesion for Base that adds methods addEvent, cleanEvents17:36
hatchlol17:36
hatchagreed17:36
rick_h_well, that type of scope issue is always present in any JS work being done17:37
hatchyeah but usually it doesn't come with the penalty of zombie event listeners17:37
hatch:)17:37
hatchfor the record I totally agree with you17:37
rick_h_ok, is there a way to generate a unique id for an instance of Base?17:38
hatchI'm just erring on the side of caution17:38
rick_h_make events a global watcher and add all events to it. Then destructor references it on cleanup17:38
rick_h_at then we can track/check for left over events in tests/etc17:38
teknicorogpeppe, thanks, looking17:38
hatchhmm17:38
hatchnow that's an interesting approach17:38
rick_h_well for this branch it's referencing both _events and .get(_events) and I don't think a ATTR is the right place for this stuff17:39
rick_h_I'd vote investigating sticking it next to ATTRS and make sure it's instance scoped, if it's not then worst case just this._events = [] in the initializer17:39
rick_h_this is a really simple bit of code and scope shouldn't be an issue17:40
hatchsure ok ok17:42
jcsackettrick_h_, hatch: does handlebars provide any helpers to easily handle pluralizing? e.g. if extra is 1 "result" if extra is > 1 "results"?17:42
hatchnot that I know of17:42
rick_h_jcsackett: I find sometimes just changing the text is good. "View X more" 17:42
rick_h_no plurals needed :)17:42
jcsackettrick_h_: if you're good with that; you pointed out the wireframe's actually say "see x more results"17:43
rick_h_let UX catch us before we waste time on it17:43
rick_h_yea, so "See X more" then :)17:43
rick_h_but if it's pulled out from the method into a template we can easily change it to a functino call to do plurals if needed17:43
gary_posterhatch, bcsaller, I added docs about our Jenkins setup on the wiki page.  https://wiki.canonical.com/JujuGUICI#preview Good enough?17:43
bcsallerchecking17:44
jcsackettrick_h_: you alright with it remaining "see less" then? "see fewer" feels awkward.17:44
rick_h_really? less seems to not fit my tongue but I can't figure out why. 17:44
rick_h_jcsackett: but yea, if it's just my strangeness leave it for sure17:45
gary_posterfewer is count17:45
rick_h_where's deryck when you need some english 17:45
gary_posterhave no idea what you are talking about :-)17:45
jcsackettrick_h_: see gary's point. fewer is when you have a number.17:45
rick_h_gary_poster: in the search results you see XX by default with a link to "show more" and then when you show more the link is "show less"17:45
jcsackettwe could do "see X fewer", but that seems uneccesary for the intent.17:46
rick_h_jcsackett: maybe that's what's strange is that it's XX more (numbery) but not on the way back17:46
rick_h_jcsackett: yea, so just ignore me17:46
gary_posterwe are accustomed to "less" in vbrowser because it is viaual17:46
gary_postervisual17:46
gary_posterless information17:46
gary_posterfewer pieces of data17:46
jcsackettrick_h_: ignoring away. :-)17:46
rick_h_lol, "fewer pieces of data" though. It's not "less pieces of information" is it?17:47
bcsallergary_poster: If the wiki is the place we save the Jenkins script we should put a note at the top of that script saying to save any changes back to the wiki. Other than that looks good :)17:47
* rick_h_ goes back to english school...been too long17:47
gary_posterbcsaller, was doing that in description on jenkins.  will also put it at top of script.  Not sure if wiki is best place but it is OK and easy :-)17:48
rick_h_jcsackett: let me go play with a jsbin for a minute on the _event stuff. 17:48
gary_posterthank you for review17:48
teknicorogpeppe, re: AddRelation(endpoint0, endpoint1 string) -> (endpoints .. string), I guess I'll have to change DestroyRelation too17:48
jcsackettrick_h_: argue with jeff. i don't care, honestly, but i don't want to go back and forth between you two. :-P17:48
rick_h_jcsackett: rgr17:48
hatchgary_poster: looks good - thanks for doing that! bcsaller heh that script is a lot longer than our original lol!!!17:49
rogpeppeteknico: good call, yes please, thanks17:49
rogpeppeteknico: you could probably do it in the same CL if you wanted.17:50
gary_postercool thanks hatch17:50
teknicorogpeppe, that's what I'm doing, yes17:50
rogpeppegary_poster: so, my current take on the SetAdminPassword issue is that if you call SetAdminPassword, you poison all existing watchers. i *think* that's a reasonable stance, but YMMV.17:51
gary_posterrogpeppe, I think paranoia is reasonable for juju's use cases.  however the watcher seems like the wrong place to be paranoid17:53
rogpeppegary_poster: i don't see a reasonable alternative unfortunately.17:53
gary_posterif you are going to take that stance--and I think it is a reasonable one--then it would make more sense to dump users off and require reauthentication.  17:53
rogpeppegary_poster: they're all using the same mongo client, and that's been shut out17:54
rogpeppegary_poster: i think that's what will happen in practice actually17:54
gary_posterrogpeppe, but only when you try to use a watcher?17:54
gary_posterrogpeppe, I also think that ideally the error message would clearly indicate what's going on and why, but that's arguably nice to have in comparison17:55
rogpeppegary_poster: hmm, i've just realised my solution won't work. SetMongoPassword really does poison all other clients.17:56
gary_posterheh17:56
rogpeppegary_poster: and in this case we've got two clients17:56
gary_posterjuju itself being the other?17:56
rogpeppegary_poster: the one started by the dummy environ, which starts at Bootstrap time, and is what the API server is running on. and one in the juju.Conn which the clients are using.17:57
gary_posterwhere dummy environ == roughly "juju itself" in the context of the tests IIUC17:58
rogpeppegary_poster: on the first connection, the client connection sets the password (so that we can avoid sending it up plaintext in the cloudinit data)17:58
rogpeppegary_poster: yeah17:58
rogpeppegary_poster: and this *is* an issue for the real live environment, i now realise17:59
rick_h_hatch: so if we change _events to being set in the intializer so it's per instance does that change your LGTM for jcsackett? If so I'll cave and let the ATTR go just feels dirty, but maybe less error prone potential. 17:59
teknicorogpeppe, replied to your review, thanks. I added a few questions myself, please have another look17:59
rogpeppeteknico: will do (although i have to go *very* shortly, and won't be back until Tues, i'm afraid)17:59
hatchnope that's fine17:59
rick_h_jcsackett: ok? ^^17:59
gary_posterrogpeppe, I'm out Wed-Fri next week btw18:00
rogpeppegary_poster: ok, good to know18:00
hatchyou're right that it's more performant I was just concerned with the potential issues associated with it18:00
rick_h_hatch: understand. Yea, we need a better long term solution. 18:00
teknicorogpeppe, it's actually just *one* question :-)18:01
hatchrick_h_ when we do build this solution it should be done to be contributed back to yui18:01
rick_h_hatch: +118:01
rogpeppeteknico: replied18:03
teknicorogpeppe, thanks, have a great weekend!18:04
rogpeppeteknico: and you!18:04
teknicoI'm working tomorrow (but I'll be off on Monday) :-)18:04
rogpeppegary_poster: actually i've realised it's *not* an issue live (the bootstrap process creates a new user) and that points me to the right solution...18:06
rogpeppegary_poster: thanks for being a fine sounding board for my thoughts18:06
gary_posterah, make a new user?  echo chamber, perhaps ;-) but glad I helped18:06
rogpeppegary_poster: think of yourself as a stuffed bear :-) http://talkaboutquality.wordpress.com/2010/08/30/tell-it-to-your-teddy-bear/18:08
gary_posterlol18:08
rogpeppeam off now. happy weekends all.18:10
gary_posterhatch we don't need npm as a build dependency because node now includes it right?18:10
gary_posterbye rogpeppe !18:10
hatchgary_poster: correct - and verified locally18:11
gary_postercool thanks18:11
gary_posterLGTM18:11
hatchwhich I am kind of sketched out about because they are two different applications with obviously conflicting apis18:11
hatchhmm looks like I need to create a wordpress account18:13
hatchI gota spread my beliefs to the world!18:13
hatchgary_poster: do we know what happens if trunk commits happen prior to it completing a test? does it queue them up?18:14
hatchor run the latest18:14
gary_posterhatch, queu18:17
gary_postere18:17
hatchok good :)18:18
gary_posterbenji how goes release?18:18
hatchcould I get one more review on this 4ln diff :) https://codereview.appspot.com/8105043/18:19
hatchppllllleaaaasseee18:20
hatchgary_poster: anything in particular you would like me to tackle ?18:28
gary_posterhatch, yes.  congratulations on finishing CI.  We will improve it later as a separate task.  Meanwhile, we have a new "Story A"18:29
gary_posterI've created cards for the tasks, but I need to talk you through it.18:29
hatchsure - now?18:29
gary_posterI have a call with bac.  bac, can we postpone our call by 30 min or so?18:30
gary_posteror would now be better?18:30
hatchnope take your time18:30
bacgary_poster: either18:30
hatchI'll take a 30min lunch18:30
gary_posterhatch ok cool talk to you then18:30
gary_posterbac, joining18:30
benjigary_poster: back from lunch; I figured out the little problem I had (relating to version.js) and am in the middle of QA now18:33
gary_postercool benji thx18:41
benjiour two-factor auth setup is aweful; my phone and the server keep getting out of sync and have to be reset18:46
MakyoHm, Ubuntu's pretty on the tablet, though a little flaky. gary_poster - if I read the email right, I should put android on this, right?18:47
benjiwait!  this is staging, two factor auth doesn't work here.... <sigh>18:47
gary_posterMakyo, no18:47
gary_posterMakyo, Ubuntu touch.  Though you will probably want to flash it to get it to newest18:48
gary_posterdaily18:48
gary_posterMakyo will also forward you a few emails for contact and debugging info18:48
Makyogary_poster, thanks.  Can't open the browser on the current version :)18:48
gary_posterMakyo, heh18:48
gary_posterMakyo, to flash new version, you start in ubuntu (not bootloader, despite instructions that confused me) and do step 4 of https://wiki.ubuntu.com/Touch/Install18:50
gary_posterYou'll need step 1 before that18:50
gary_posterbut step 2 and 3 are unnecessary now18:50
gary_postersteps18:50
gary_posterhatch, I think the most recent Jenkins failure indicates that you broke the charm :-)18:54
gary_posteryay CI! :-)18:55
jcsackettrick_h_: sorry, was finally taking a lunch break. so, just in initializer create. this._events?18:59
rick_h_jcsackett: correct19:00
gary_posterhatch, http://pastebin.ubuntu.com/5656043/19:00
gary_posterthat's from charm machine from Jenkins19:00
gary_posterI'm going to make a fresh build locally and see if I can dupe19:00
hatchawwwww mann19:01
hatchoh wait19:01
hatchno that's a grunt error19:01
gary_posterhatch, dunno, that's from benji, and it is doc only :-/19:01
gary_posterso maybe a new spurious failure?19:01
hatchhmm19:02
benjior I screwed up the docs THAT bad19:02
gary_poster:-)19:02
hatchhow do you deploy the charm locally? I have always spun up ec2 instances :)19:04
gary_posterhatch, dunno, rerunning make was fine. :-/ maybe crazy virtualization issue?19:04
gary_posternever seen that one before19:04
hatchmaybe if we get an install error we should dump the machine and juju logs19:06
gary_postermaybe so19:07
gary_posterran make clean-all && make build19:07
gary_postereverything fine.19:07
hatchhmm that's odd19:07
gary_posterGoing to re-run test on jenkins19:07
gary_posterseems spurious19:07
gary_poster:-(19:07
gary_posterhatch guichat?19:08
hatchsure19:08
=== matsubara_ is now known as matsubara
bacgary_poster: my endpoints change introduces the new requirement that adding a service causes it to fetch the charm.  that modification is impacting lots of tests that assume the old behavior.  just giving you a heads up.19:55
gary_posterack bac sounds ok on the face of it19:55
hatchbcsaller: do you know what grunt modules we use?20:02
hatchyou were saying that we didn't upgrade because some modules needed to be updated20:02
bcsallerhatch: very little, just the spritegen stuff afaik. I cut a branch once that did more stuff with it, but with the 0.4 transition it wasn't time to change 20:03
hatchok and it looks like spritegen (node-spritesheet) isn't a grunt module20:03
hatch`npm show node-spritesheet`20:04
hatchand it was updated march 120:04
rick_h_hatch: when you get a second have a Y.View/events ? for you20:06
hatchsure20:07
hatchgo for it20:07
rick_h_hatch: so my events: {} aren't working and I recalled that there's some lazy-ness in there. Do you recall that all you have to do is this.get('container') to activiate it?20:08
rick_h_I thought I ran into something before but brain is not recalling20:08
rick_h_obviously, doing a this.get('container') in render isn't working so assuming it was something diff20:08
hatchon showView() those events are delegated on the container20:09
hatchso if there is no container then it can't delegate on anything20:09
rick_h_ah, only on showView?20:10
rick_h_I'm using a view in a view20:10
rick_h_so there's no 'showView' to handle this 20:10
hatchare you rendering the view?20:10
rick_h_hatch: rgr20:10
rick_h_https://code.launchpad.net/~rharding/juju-gui/clean_charmview/+merge/156054 line 129 is the start of the view I'm trying to get working/writing tests for. 20:11
hatchok one sec20:11
rick_h_line 343 is the rendering of it from the Fullscreen main view. 20:11
rick_h_hatch: cool, np20:11
hatchok just reviewed the view source and the events are attached on view initialization XOR when the container attribute is changed20:13
rick_h_hatch: hmm, ok. That's what I thought then. /me goes back to debugging20:14
hatchdoes tplNode.one('.bws-view-data') return a node?20:14
rick_h_hatch: yea20:16
hatchevent callbacks are supposed to be strings20:17
rick_h_hatch: doh!20:17
rick_h_I was also doing a this.set('container') before I rendered the template into the container so it didn't have any matches20:18
rick_h_hatch: there we go. Thanks!20:19
rick_h_Knew I was missing stupid20:19
hatch:D \o/20:19
gary_posterhatch what's the word on the test issue?  Making progress, or want to pair?  I can deploy trunk and see if it works for me.  You can too actually, trivially: juju deploy cs:~juju-gui/precise/juju-gui20:26
hatchI'm rolling it back to 0.8 to be sure it's an issue with the upgrade20:26
hatchI am thinking its an internal dependency failure20:27
gary_posterok20:27
hatchlike something inside the modules we require20:27
gary_postermaybe so20:27
hatchsome of the deps our deps rely on haven't been touched in fo'eva!20:28
hatchas in , say they require node >0.420:29
hatchlol20:29
hatchgary_poster: reverting back to 0.8 works just fine :/20:44
hatchso theer is some unsupported dependency somewhere in the dependency mess20:44
hatchso can I easily revert the changes?20:45
hatchor do I need to re-commit20:45
gary_posterhatch, tbh I forget.  I think the preferred way is to merge in reverse20:45
gary_posterlemme see if I can figure it out, oone sec20:45
hatchalright20:45
gary_posterhatch I think bzr merge -r38..37 will do what we want:20:48
gary_posterit changes trunk to revert your revision20:48
gary_posterwhich you will then commit as a new change, with a message about reverting20:48
gary_posterand push20:48
gary_posterlook at bzr diff after the merge to make sure it looks like what you want20:49
hatchalright thanks20:50
hatchgood news is that the CI tests all pass :)20:50
gary_posteryay! :-)20:51
gary_posteralso good news is that CI actually did what it is supposed to do!20:51
gary_posterkeep us from having a problem for long20:51
hatchhaha yay20:51
* hatch has the badge for the first person to actually breaking the build20:51
hatchlol20:51
hatchannnd done20:55
hatchi'll fire off another ci run20:55
hatchO K now to doing real work20:55
gary_posterthanks hatch :-)20:55
* hatch mumble rants about node.js dependencies20:56
gary_posterhatch, maybe make a bug to represent the fact that we still have a node issue that we want to resolve at some point?20:56
hatchyep20:56
* gary_poster suspects it will bother hatch until he fixes it with or without the bug :-)20:56
hatchlol yes it will20:57
hatchyay the tests are running on canonistack21:11
gary_posteryay21:14
hatchand more importantly passing :)21:14
gary_posterthat too :-)21:14
gary_posterbenji, I'm not going to send the email to Francesco.  I'll send it to you.  The more I dig into his the more I am skeptical that we will be able to accomplish this without Roger.  This is a big deal: I am afraid there may be some serious issues with the allwatcher.  AFAICT, the config and constraints are in their own separate docs, and I don't think they are watched by the allwatcher.  therefore, if they change, we 21:16
gary_posterwon't hear about it.  hopefully I am wrong.21:16
gary_posterAnyway, for Francesco, he has a task that he can get done.  If I do send him the email, it will be "if you get the other task done, think about this one, and maybe tell us if things are not as dark as they seem to me"21:17
hatchlooks like when the CI passes it just gives a link21:18
hatch:)21:18
benjigary_poster: ok21:19
gary_posterbcsaller, could you remind me what a relation's scope is in juju?  I only see "global" in improv output21:29
bcsallergary_poster: it can also be "container" for subordinate relations21:30
gary_posterbcsaller, ah ok.  nobody has those atm so it is always global, right?21:30
bcsallerif you add puppet and a sub relation you should see it as an example21:30
gary_posteroh ok21:31
gary_posterI see21:31
gary_posterthank you21:31
bcsallerthe sample env should really have a sub21:31
gary_posterbcsaller, btw notice that I added cards fro in-memory environment to story a21:33
gary_posteryou might want to dig in there if you feel like it21:33
bcsallergary_poster: ahh, nice21:34
bacguihelp: how does one deal with: extend failed, verify dependencies21:41
hatchstep 121:41
hatchverify dependencies21:41
hatch:P21:41
bcsallerha21:41
gary_poster:-P21:42
bacstep 0?21:42
hatchok but really haha21:42
hatchthat means that the object you're trying to extend doesn't exist21:42
hatchso unfortunately that's pretty much all the advice there is - you will need to track back to find out why it's undefined21:42
hatchthe good news, is that it's usually a typo, or you forgot to add the module into the sandbox21:43
hatchthose are the first places to check21:43
hatchthe next are syntax issues21:43
hatchwhich would cause the instantiation of the parent to fail21:43
bachatch: it seems to be transient, which is confusing21:44
hatchis this in tests?21:45
bacyeah21:45
hatchtry commenting out every other test case so it only loads your file21:45
hatch<!-- test cases -->21:46
hatchthen make sure that you have added the file into the merge-files (if required) or into the modules-debug21:46
hatchannnnd now I can't build trunk21:46
bachatch: it isn't a new test file, so none of that is applicable.21:47
hatchoh hmm21:47
hatchis the class you're trying to extend new?21:47
bacnot extending a new class.   just add some methods on a pre-existing one.21:50
hatchoh ok21:50
hatchthat sounds like a syntax error21:50
hatchtry linting it21:50
hatchor push the code up somewhere so I can take a peek21:51
bacthat's a good idea21:51
hatchgary_poster: looks like the CI failed even after retrying with similar issues21:52
hatchmaybe we should increase the attempts21:52
gary_posterhatch, oh you mean firefox?21:53
gary_postersuck.21:53
hatchoui oui21:53
gary_posternaginator worked, which is kind of nice. :-/21:54
bacdang, no syntax errors21:56
gary_posterI have no freaking idea hatch.  Yeah, do five retrys if the number of tests run < 100?21:56
gary_posterhatch, we will need to solve this, but I don't want to solve it now. 21:56
gary_posterI'll be back later.  must run21:57
hatchrick_h_ jcsackett either of you guys around?22:39
rick_h_hatch: what's up?22:39
hatchif you run describe.only('notifications' in test_notifications.js there is an extend failure22:40
hatchand the traceback points to the charm-slider.js22:40
hatchthis doesn't happen when you run all the tests22:40
rick_h_hatch: hmm, that sounds like the error I brought up before where it was the slider with a 0 item set causing issues22:40
* rick_h_ tries it out. 22:40
rick_h_hmmm, the 'base' in Base.create is undefined22:44
rick_h_so Y.ScrollView doesn't exist22:44
hatchdas very odd ya?22:44
rick_h_yea, but we had the same issues with TabView22:44
rick_h_I wonder if it's simliar22:44
rick_h_we never did figure out wtf with TabView, just cheated on it 22:45
rick_h_maybe the modules names aren't quite right? /me checks his requires vs the dir/file names in YUI22:45
rick_h_hmm, no they seem to match up22:46
hatchyeah I stared at it for a bit and coudln't figure it out22:46
hatchunfortunately this issue is stopping bac from resolving his issues22:46
hatchso should I create a critical ticket?22:46
rick_h_yea, I mean for some reason it's not fetching the required module.22:46
hatchyeah I have no idea what's up22:46
hatchas far as I can tell all of those modules ARE available22:47
rick_h_yea, I mean this is going to be a bit hard for jcsackett to figure out. The build/dep system in here is already hard to follow22:47
rick_h_Now if you remove the rest of the tests does it still do it?22:47
* rick_h_ wonders how the globalconfig is setup to fetch yui deps22:48
hatchrick_h_ looks like if I comment out every other test it all passes22:49
rick_h_yea, ok. So it's some kind of interaction. Ugh I hate this one test thing to rule them all. 22:49
rick_h_so yea, the YUI files are there in the build-debug which this is using I believe22:50
rick_h_so not an issue getting them into the build dir22:50
rick_h_and hitting the url directly works, so why is it not fetching the file...does it think it's already got it or something?22:50
hatchrick_h_ looks like test_model.js causes it to go wako22:51
rick_h_hmm, ok. That's good to know then. /me goes look into there22:51
hatch550ln test file....boooo22:51
hatchlol22:51
hatch390-54422:52
hatch^^ rick_h_ if you comment that out in test_models then it works22:52
rick_h_hatch: cool, now wtf since slider has nothing to do with models lol22:53
hatch394-41522:55
rick_h_but all that is, is just the beforeEach/afterEach22:55
rick_h_hmm, these tests aren't in a closure?22:56
rick_h_neither are the slider ones22:56
hatchthat block of tests has a describe inside a YUI.use() not outside like everything else22:57
hatchI bet that has something to do with it22:57
rick_h_oh, interesting22:57
hatchand I bet charm-slider is just failing becaise it's next22:58
hatchheh22:58
rick_h_notifications is next22:58
rick_h_but yea, something like that22:58
rick_h_not sure how slider fits into it all atm. 22:58
rick_h_hatch: so are you cool then tweaking that test and see if that helps?22:58
rick_h_I've got to get ready to put the boy to bed and can hop back in an hour or so. 22:59
rick_h_if you don't get to it, I'll try to adjust that test and see if we can clean this up22:59
hatchsure thing I'll create a new branch to try and fix this and see how far I get22:59
hatchping me when you get back if I haven't posted anything :)22:59
rick_h_ok, if you get done before I get back just shoot me an email if you need help carrying it through22:59
rick_h_hah, ok will do22:59
hatchrick_h_ just doing a quick hack job on it placing the yui inside the describe has solved the issue23:06
hatchso now to clean this code up23:06
rick_h_hatch: ok, awesome! Glad that worked out. Still wonder wtf caused it to blame slider, but fixed > * 23:23
hatchrick_h_ my guess is that it just happened to be the first module requiring a new dependency23:24
hatchbut thats just a twag23:24
rick_h_hatch: yea, all good23:24
rick_h_hatch: if you get a chance before tomorrow gets crazy pushing up my branch for review https://codereview.appspot.com/810304623:35
rick_h_thanks again for the help wtih the events. Stuck me for a bit :/23:35
hatchsure - I'm actually off tomorrow and monday but I'll stop in to goto the meeting and stuff so I'll probably do it then23:35
hatchno problem :)23:35
rick_h_hatch: ah ok. I can ask another from the team if you're afk23:35
rick_h_let me know. Thanks!23:35
hatchI need a faster machine to run these unit tests23:38
rick_h_yea, runs in 20s here (browser at least)23:38
hatchpfft23:39
hatch40s here23:39
rick_h_:P23:39
hatchlol23:39
rick_h_9s for test-debug23:39
rick_h_chrome must be slowing me down :)23:39
hatchlol it's all the DOM manipulations23:39
rick_h_yea23:39
hatchyeah I'm about 20s on the terminal23:40
gary_poster14 or 15 sec for me--go desktop!23:41
rick_h_yea, I've been debating a desktop this year23:41
hatchhaha23:42
rick_h_I've been laptop only so long, but with all this vm/lxc/etc going on I'm itching for something I can actually run an environment on nicely23:42
hatchyou two should stick around a bit so I can merge this fix into trunk tonight23:42
hatchit's proposing right now23:42
rick_h_hatch: I'll be around. Waiting for australians to show up adding more cards to the board bwuhahaha23:43
hatchlol23:43
hatchhow many ausies on your team?23:43
rick_h_though hmm, if everyone is off friday wonder if he is. This is his friday23:43
rick_h_hatch: just the one design guy on loaner :)23:43
hatchahhh haha gotcha23:45
hatchok patch has been proposed - QA please :D23:45
rick_h_linky?23:46
hatchoops https://codereview.appspot.com/8099047/23:46
rick_h_it's almost 8pm, don't make me wait for my email to update itself and sync :P23:46
hatchhaha mine is almost instant23:47
hatchI use postbox for osx23:47
hatchit's a stellar email client23:47
rick_h_I have a server pull gmail and work into into a single mailbox, filter it, and then I pull from taht23:47
hatchahh23:47
rick_h_so it takes 4-5min to get to my local mutt install23:47
rick_h_but one mailbox is nice23:48
hatchgary_poster: if you are still around could you review that branch please :)23:48
hatchbac: this branch will fix the issue you were having23:48
gary_posterok, but trying to run awaya as fast a spossible ;-)23:49
gary_postergood catch hatch.  LGTM23:49
hatchhaha thanks!23:50
hatchhave a good night23:50
gary_posteru 223:50
rick_h_hatch: qa'd with the notifications.only() and all happy. Thanks again for running that down. 23:51
rick_h_and proving jcsackett and I didn't do it :)23:51
hatchhaha np :D23:51
hatchnow I'm going to go sit on the couch and watch some TV :) I'll do your review in the am before the call23:52
rick_h_hatch: ty much kind sir. Have a good night23:53
hatchyou too!23:53
rick_h_droidjcsackett what if the number of results in the container is exactly the limit? what does the text for expander do? 23:58

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!