| benji | good virtual morning, frankban; did you get a chance to look at the AllWatcher any? | 12:20 |
|---|---|---|
| frankban | benji: not yet | 12:21 |
| benji | ok, I'll take a look at it and see what I find | 12:21 |
| frankban | benji: thanks. I am about to propose my current branch, then lunch, and then we could take a look together | 12:22 |
| benji | cool | 12:22 |
| gary_poster | thanks guys. Would love to hear that my concerns are paranoid and unfounded :-) | 12:23 |
| frankban | gary_poster, benji: do you know what is the corrent youdoc @param type when the value can be of any type? | 12:24 |
| gary_poster | OTOH, also happy to see progress on things that we know how to do, while leaving the rest for Roger's return | 12:24 |
| benji | I use {Object} when that is the case. | 12:24 |
| gary_poster | Do you mean {Object} ? | 12:24 |
| gary_poster | Yeah me too | 12:24 |
| frankban | cool, thanks | 12:24 |
| bac | hatch: thanks! | 12:27 |
| gary_poster | frankban, for bug 1161848, that sounds like a Go API fragility rather than an error on our side--it sounds like the charm is broken, but Juju is proceeding with what we asked it to do. Do I misunderstand? | 12:30 |
| _mup_ | Bug #1161848: Malformed charm metadata error when a charm is deployed using the API <juju-core:New> <juju-gui:Triaged> < https://launchpad.net/bugs/1161848 > | 12:30 |
| frankban | gary_poster: that's also my understanding | 12:32 |
| gary_poster | ok cool thanks frankban. so...do we actually need to do anything about it? | 12:33 |
| frankban | gary_poster: I guess we don't. That's why I moved that card to tracking. | 12:35 |
| gary_poster | got it frankban. thanks | 12:35 |
| frankban | gary_poster: np | 12:35 |
| * frankban lunches | 12:41 | |
| gary_poster | therve, hi. juju-gui 0.3.1 has the UX changes Andreas requested for bug 1156739. you can deploy the charm with that revision ("juju-gui-source=0.3.1") in the future to get this release. I have the improv version up for visual review here: https://ec2-23-22-86-50.compute-1.amazonaws.com/ | 13:41 |
| _mup_ | Bug #1156739: "environment LANDSCAPE" feels wrong <juju-gui:Fix Released by benji> < https://launchpad.net/bugs/1156739 > | 13:41 |
| therve | gary_poster, thanks, I'll pass it up | 13:43 |
| gary_poster | thanks therve | 13:43 |
| hatch | morning | 14:16 |
| gary_poster | morning | 14:17 |
| rick_h_ | morning | 14:18 |
| gary_poster | jujugui call in 2 | 14:28 |
| rick_h_ | hatch: thanks for the review. Comments and code pushed up this morning | 14:28 |
| gary_poster | hatch starting without you | 14:31 |
| hatch | rick_h_: I'll do your review now | 15:20 |
| rick_h_ | hatch: thanks! :) | 15:20 |
| hatch | frankban: yours after that | 15:20 |
| frankban | thanks hatch | 15:21 |
| hatch | gary_poster: I'm holding out that my test patch yesterday night will fix our odd failing test issue haha | 15:23 |
| * hatch crosses fingers | 15:23 | |
| hatch | ok both done | 15:26 |
| frankban | cool, thanks | 15:26 |
| rick_h_ | thanks again hatch, have a good weekend | 15:26 |
| hatch | you too - I'll likely still be around haha | 15:26 |
| hatch | ping me if ya need me :) | 15:27 |
| rick_h_ | hah, well don't hang around too much. Days off are good for you. | 15:27 |
| frankban | benji: are you available for a call re the allwatcher stuff? hangout? | 15:36 |
| benji | frankban: sure; give me one minute and we'll go to the hangout that shall not be named | 15:37 |
| frankban | benji: :-) cool | 15:37 |
| gary_poster | hatch, that would be great if so! | 15:38 |
| gary_poster | therve, is it helpful to keep that ec2 instance up, or can I can kill it? | 15:39 |
| gary_poster | I mean | 15:40 |
| gary_poster | https://ec2-23-22-86-50.compute-1.amazonaws.com/ | 15:40 |
| therve | gary_poster, you can kill it | 15:40 |
| gary_poster | thanks | 15:40 |
| gary_poster | therve, how can we expect to hear an official OK on this delivery? | 15:40 |
| therve | gary_poster, I need to pass this to someone else, I don't know | 15:41 |
| gary_poster | therve, want me to send an email to Dean and see if he is willing to sign off? | 15:41 |
| therve | gary_poster, yes, please | 15:42 |
| gary_poster | ok will do. thanks again | 15:42 |
| gary_poster | frankban, I'll handle Jenkins. | 15:56 |
| benji | gary_poster: frankban and I have come up with an approach for at least part of our current allwatcher issues and would like to discuss it with you | 15:57 |
| gary_poster | yay | 15:57 |
| frankban | gary_poster: thanks a lot | 15:57 |
| benji | in the hangout that must not be named | 15:57 |
| gary_poster | guichat! | 15:57 |
| bcsaller | doh! | 15:58 |
| Makyo | Tiny branch to match the core refactor: https://codereview.appspot.com/8158043/ | 16:23 |
| bac | thanks for the fix hatch! | 16:25 |
| * bac not really here | 16:25 | |
| hatch | no problem bac | 16:25 |
| * hatch also not really here | 16:25 | |
| * gary_poster really here! | 16:26 | |
| * Makyo \o/ | 16:27 | |
| gary_poster | :-) | 16:27 |
| rick_h_ | all these slackers here on their day off | 16:27 |
| rick_h_ | what's the world coming to | 16:27 |
| gary_poster | I know! | 16:27 |
| rick_h_ | we can't poke fun at the holiday'ing slackers if they keep doing stuff. I'll start to feel guilty soon | 16:28 |
| rick_h_ | hmm, speaking of which I think I'm going to slack my way to the coffee shop for some afternoon work. friday caffeine required | 16:29 |
| gary_poster | Makyo, my review makes no sense. It's just how I felt, what can I say. | 16:30 |
| Makyo | gary_poster, fits the branch! I'll take it :) | 16:30 |
| gary_poster | :-) | 16:30 |
| gary_poster | wow, now ec2 is taking a long time to start a machine up... | 17:21 |
| gary_poster | weird | 17:21 |
| teknico | there you go! some of the most awful, fragile, baroque Javascript code you ever saw! ;-) https://codereview.appspot.com/8162043 | 17:44 |
| * benji takes a late lunch. | 18:08 | |
| frankban | have a great weekend all | 18:19 |
| teknico | frankban, you too | 18:24 |
| rick_h_ | anyone around for a JS review? https://codereview.appspot.com/8166043/ | 18:36 |
| Makyo | rick_h_, sure. | 18:42 |
| gary_poster | https://codereview.appspot.com/8083044 | 18:57 |
| gary_poster | short CI review ^^^ | 18:58 |
| rick_h_ | thanks Makyo | 19:43 |
| rick_h_ | hah! most reviewed branch ever. | 19:55 |
| rick_h_ | thanks gary_poster, you caught the one that's a true bug/test fail :( | 19:56 |
| gary_poster | rick_h_, glad review helped, at least :-) | 19:56 |
| gary_poster | benji, if you are looking at relations, good news: teknico figured out that both Interface and Scope are in the Endpoint. https://codereview.appspot.com/8162043/ fwiw | 20:05 |
| benji | heh, I just noticed the same thing; I'm working on fleshing out the relation watcher now | 20:05 |
| gary_poster | awesome | 20:06 |
| gary_poster | Makyo thank you for review. rick_h_, you up for a review of a hack? :-/ https://codereview.appspot.com/8083044/ | 20:06 |
| rick_h_ | gary_poster: sure thing | 20:09 |
| gary_poster | thank you | 20:09 |
| benji | grr, import cycle! | 20:14 |
| * benji builds a yurt made out of crystals in order to meditate upon import cycles. | 20:15 | |
| rick_h_ | import cycles == circular imports in py? | 20:15 |
| benji | yep, except that they are illegal in go, so when you create one you get an error | 20:16 |
| benji | which in practice means that you have to restructure your app just to make the thing you want to do possible | 20:17 |
| rick_h_ | add some DI :P | 20:17 |
| rick_h_ | nothing like a global to fix your imports | 20:17 |
| benji | heh | 20:17 |
| rick_h_ | gary_poster: if you wanted to look over the fix for the markdown render it's up https://codereview.appspot.com/8166043, otherwise I'll roll with the LGTM I've got and land it | 20:20 |
| gary_poster | looking rick_h_ | 20:24 |
| gary_poster | +1 on the change rick_h_ including test | 20:27 |
| rick_h_ | gary_poster: thanks | 20:27 |
| gary_poster | yay, ci passed | 20:58 |
| benji | gary_poster: I sent the hand-off email. | 21:11 |
| benji | I'll see y'all Tuesday. | 21:11 |
| gary_poster | thank you benji. don't pull a uscle, and have a good weekend | 21:11 |
| gary_poster | muscle | 21:11 |
| benji | If I were Popeye I might be able to pull a uscle. | 21:12 |
| benji | One of the things I like about helping people move is that invariably someone says "You're stronger than you look." Thanks... I... guess. | 21:13 |
| rick_h_ | gary_poster: where's CI reporting to? | 21:14 |
| * rick_h_ is curious in case he breaks things one day... | 21:14 | |
| gary_poster | rick_h_, juju-gui@lists.ubuntu.com | 21:15 |
| gary_poster | rick_h_, https://lists.ubuntu.com/mailman/listinfo/juju-gui | 21:15 |
| rick_h_ | gary_poster: thanks | 21:15 |
| gary_poster | welcome | 21:15 |
| gary_poster | rick_h_, jcsackett and huwshimi ought to be on there too I think | 21:16 |
| gary_poster | oh huwshimi is already | 21:16 |
| rick_h_ | sinzui: jcsackett ^^ | 21:16 |
| jcsackett | yay, more email lists. :-P | 21:16 |
| gary_poster | :-) | 21:16 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!