[12:20] good virtual morning, frankban; did you get a chance to look at the AllWatcher any? [12:21] benji: not yet [12:21] ok, I'll take a look at it and see what I find [12:22] benji: thanks. I am about to propose my current branch, then lunch, and then we could take a look together [12:22] cool [12:23] thanks guys. Would love to hear that my concerns are paranoid and unfounded :-) [12:24] gary_poster, benji: do you know what is the corrent youdoc @param type when the value can be of any type? [12:24] OTOH, also happy to see progress on things that we know how to do, while leaving the rest for Roger's return [12:24] I use {Object} when that is the case. [12:24] Do you mean {Object} ? [12:24] Yeah me too [12:24] cool, thanks [12:27] hatch: thanks! [12:30] frankban, for bug 1161848, that sounds like a Go API fragility rather than an error on our side--it sounds like the charm is broken, but Juju is proceeding with what we asked it to do. Do I misunderstand? [12:30] <_mup_> Bug #1161848: Malformed charm metadata error when a charm is deployed using the API < https://launchpad.net/bugs/1161848 > [12:32] gary_poster: that's also my understanding [12:33] ok cool thanks frankban. so...do we actually need to do anything about it? [12:35] gary_poster: I guess we don't. That's why I moved that card to tracking. [12:35] got it frankban. thanks [12:35] gary_poster: np [12:41] * frankban lunches [13:41] therve, hi. juju-gui 0.3.1 has the UX changes Andreas requested for bug 1156739. you can deploy the charm with that revision ("juju-gui-source=0.3.1") in the future to get this release. I have the improv version up for visual review here: https://ec2-23-22-86-50.compute-1.amazonaws.com/ [13:41] <_mup_> Bug #1156739: "environment LANDSCAPE" feels wrong < https://launchpad.net/bugs/1156739 > [13:43] gary_poster, thanks, I'll pass it up [13:43] thanks therve [14:16] morning [14:17] morning [14:18] morning [14:28] jujugui call in 2 [14:28] hatch: thanks for the review. Comments and code pushed up this morning [14:31] hatch starting without you [15:20] rick_h_: I'll do your review now [15:20] hatch: thanks! :) [15:20] frankban: yours after that [15:21] thanks hatch [15:23] gary_poster: I'm holding out that my test patch yesterday night will fix our odd failing test issue haha [15:23] * hatch crosses fingers [15:26] ok both done [15:26] cool, thanks [15:26] thanks again hatch, have a good weekend [15:26] you too - I'll likely still be around haha [15:27] ping me if ya need me :) [15:27] hah, well don't hang around too much. Days off are good for you. [15:36] benji: are you available for a call re the allwatcher stuff? hangout? [15:37] frankban: sure; give me one minute and we'll go to the hangout that shall not be named [15:37] benji: :-) cool [15:38] hatch, that would be great if so! [15:39] therve, is it helpful to keep that ec2 instance up, or can I can kill it? [15:40] I mean [15:40] https://ec2-23-22-86-50.compute-1.amazonaws.com/ [15:40] gary_poster, you can kill it [15:40] thanks [15:40] therve, how can we expect to hear an official OK on this delivery? [15:41] gary_poster, I need to pass this to someone else, I don't know [15:41] therve, want me to send an email to Dean and see if he is willing to sign off? [15:42] gary_poster, yes, please [15:42] ok will do. thanks again [15:56] frankban, I'll handle Jenkins. [15:57] gary_poster: frankban and I have come up with an approach for at least part of our current allwatcher issues and would like to discuss it with you [15:57] yay [15:57] gary_poster: thanks a lot [15:57] in the hangout that must not be named [15:57] guichat! [15:58] doh! [16:23] Tiny branch to match the core refactor: https://codereview.appspot.com/8158043/ [16:25] thanks for the fix hatch! [16:25] * bac not really here [16:25] no problem bac [16:25] * hatch also not really here [16:26] * gary_poster really here! [16:27] * Makyo \o/ [16:27] :-) [16:27] all these slackers here on their day off [16:27] what's the world coming to [16:27] I know! [16:28] we can't poke fun at the holiday'ing slackers if they keep doing stuff. I'll start to feel guilty soon [16:29] hmm, speaking of which I think I'm going to slack my way to the coffee shop for some afternoon work. friday caffeine required [16:30] Makyo, my review makes no sense. It's just how I felt, what can I say. [16:30] gary_poster, fits the branch! I'll take it :) [16:30] :-) [17:21] wow, now ec2 is taking a long time to start a machine up... [17:21] weird [17:44] there you go! some of the most awful, fragile, baroque Javascript code you ever saw! ;-) https://codereview.appspot.com/8162043 [18:08] * benji takes a late lunch. [18:19] have a great weekend all [18:24] frankban, you too [18:36] anyone around for a JS review? https://codereview.appspot.com/8166043/ [18:42] rick_h_, sure. [18:57] https://codereview.appspot.com/8083044 [18:58] short CI review ^^^ [19:43] thanks Makyo [19:55] hah! most reviewed branch ever. [19:56] thanks gary_poster, you caught the one that's a true bug/test fail :( [19:56] rick_h_, glad review helped, at least :-) [20:05] benji, if you are looking at relations, good news: teknico figured out that both Interface and Scope are in the Endpoint. https://codereview.appspot.com/8162043/ fwiw [20:05] heh, I just noticed the same thing; I'm working on fleshing out the relation watcher now [20:06] awesome [20:06] Makyo thank you for review. rick_h_, you up for a review of a hack? :-/ https://codereview.appspot.com/8083044/ [20:09] gary_poster: sure thing [20:09] thank you [20:14] grr, import cycle! [20:15] * benji builds a yurt made out of crystals in order to meditate upon import cycles. [20:15] import cycles == circular imports in py? [20:16] yep, except that they are illegal in go, so when you create one you get an error [20:17] which in practice means that you have to restructure your app just to make the thing you want to do possible [20:17] add some DI :P [20:17] nothing like a global to fix your imports [20:17] heh [20:20] gary_poster: if you wanted to look over the fix for the markdown render it's up https://codereview.appspot.com/8166043, otherwise I'll roll with the LGTM I've got and land it [20:24] looking rick_h_ [20:27] +1 on the change rick_h_ including test [20:27] gary_poster: thanks [20:58] yay, ci passed [21:11] gary_poster: I sent the hand-off email. [21:11] I'll see y'all Tuesday. [21:11] thank you benji. don't pull a uscle, and have a good weekend [21:11] muscle [21:12] If I were Popeye I might be able to pull a uscle. [21:13] One of the things I like about helping people move is that invariably someone says "You're stronger than you look." Thanks... I... guess. [21:14] gary_poster: where's CI reporting to? [21:14] * rick_h_ is curious in case he breaks things one day... [21:15] rick_h_, juju-gui@lists.ubuntu.com [21:15] rick_h_, https://lists.ubuntu.com/mailman/listinfo/juju-gui [21:15] gary_poster: thanks [21:15] welcome [21:16] rick_h_, jcsackett and huwshimi ought to be on there too I think [21:16] oh huwshimi is already [21:16] sinzui: jcsackett ^^ [21:16] yay, more email lists. :-P [21:16] :-)