| gary_poster | bcsaller, are you safe in SF? | 12:51 |
|---|---|---|
| gary_poster | if he is it would be very early there... | 12:52 |
| rick_h_ | heh, zzzzzz | 12:52 |
| gary_poster | :-) | 12:52 |
| * rick_h_ goes to check for SF quakes or the like | 12:52 | |
| bac | hi gary_poster | 13:18 |
| gary_poster | hey bac | 13:18 |
| bac | hey i'm having some issues dealing with all of the legacy test failures my branch introduced. some are quite odd, including trying to create charms that claim to have no id, despite clearly passing one. | 13:19 |
| bac | gary_poster: do you have time to chat and maybe give me some ideas? | 13:19 |
| gary_poster | bac, sure. should I get a copy of branch? | 13:20 |
| bac | yeah, lp:~bac/juju-gui/get-endpoints | 13:20 |
| bac | let me push some debugging changes | 13:20 |
| gary_poster | k | 13:20 |
| bac | ok, grab now | 13:21 |
| gary_poster | k | 13:21 |
| bac | gary_poster: in guichat | 13:22 |
| gary_poster | ack, there soon | 13:22 |
| gary_poster | hey hatch, when you start, assuming you don't have anything in progress, why doncha pair with bac | 13:37 |
| bac | gary_poster: oh, i meant to mention, to do some of that debugging i had to extrace a variable declaration and assignment out of the big block of them in order for the debugger to not skip over it. an argument (too late) for 'one var per declaration'. | 13:38 |
| bac | ammo for the next time it comes up. :) | 13:39 |
| bac | s/extrace/extract | 13:39 |
| gary_poster | bac, oh, interesting! maybe microblog it--what you just said on IRC-- on the blog so you don't forget? up to you | 13:39 |
| bac | sure | 13:40 |
| hatch | morning | 13:57 |
| hatch | sure thing | 13:57 |
| rick_h_ | hatch: do you have details around the _yuid changing on a node? I tried to do some searching this weeekend but didn't find anything | 13:58 |
| rick_h_ | hatch: is there some condition that arises? Or it's just unreliable in general? | 13:58 |
| hatch | rick_h_: well the yuid doesn't change on the same node, but if it gets re-rendered then it will be different | 13:58 |
| rick_h_ | hatch: gotcha, but that should be ok as you target an indicator at a container node while you update it's contents. | 13:59 |
| rick_h_ | otherwise your indicator would vanish | 13:59 |
| hatch | yeah what I meant was that if your indicator node gets removed for whatever reason - then you try and show it | 13:59 |
| hatch | it'll show on a node that's not in the dom any longer | 13:59 |
| rick_h_ | hatch: right, but the point of this is to make sure the indicator is removed when a view is destroyed/the node goes away | 14:00 |
| rick_h_ | so for the lifetime of the view it should be good on the container, then the veiw goes away and all indicators used are wiped up | 14:01 |
| hatch | oh yes right - It would be more of a concern if it was more general use | 14:02 |
| rick_h_ | hatch: ok, yea. The point of this is just an extension to use on views to help make sure no indicator is left behind | 14:02 |
| rick_h_ | since it'll be used on a bunch of browser views. | 14:02 |
| rick_h_ | hatch: I can add docs to help narrow the written purpose if that helps. Aside from that can you give it a review look over sometime please? | 14:03 |
| hatch | oh yeah for sure | 14:03 |
| rick_h_ | hatch: cool thanks. Appreciate it | 14:03 |
| hatch | I'm just gona grab a coffee then I'll get right on it | 14:03 |
| rick_h_ | hatch: cool https://codereview.appspot.com/8186045/ to save you link hunting | 14:04 |
| hatch | bac: are you still having issues? | 14:21 |
| bac | hatch: working through them | 14:21 |
| hatch | alright, did you need me to take a look? | 14:21 |
| bac | hatch: if you have nothing else to do we could pair after the call. otherwise i could just keep going and maybe bug you if i get stuck | 14:22 |
| hatch | oh I have other stuff but could take a look if you need | 14:23 |
| hatch | so I guess lemme know | 14:23 |
| hatch | :) | 14:23 |
| hatch | bac: a comment on your blog post - you could put the breakpoint in the makeBar function :) | 14:25 |
| bac | hatch: you could. but what if makeBar is called in lots of other situations that are not interesting? | 14:26 |
| hatch | then life sux! | 14:27 |
| hatch | lol you make a good point though | 14:27 |
| hatch | I haven't actually ran into that before | 14:27 |
| Makyo | I have, but I've just used F10 to step over to the line I need. | 14:28 |
| rick_h_ | yea, I just do the debugger before the var declarations and run the function from the console | 14:28 |
| bac | Makyo: really? when i tried 'step over' it went to the next line out of the declaration | 14:28 |
| rick_h_ | the only time it's a really big pain is if it's foo=something(), bar=morestuff(foo) | 14:29 |
| hatch | rick_h_: yeah I don't like that layout | 14:29 |
| Makyo | bac, Hm. Let me make sure I'm not lying. This might've been a chained thing instead. | 14:29 |
| rick_h_ | in which case I probably end up breaking the var up | 14:29 |
| Makyo | Oops. jujugui call now. | 14:30 |
| gary_poster | oops thank you | 14:30 |
| hatch | O K now to see if I remember how this add relation code worked | 14:39 |
| hatch | heh | 14:39 |
| gary_poster | add unit? | 14:40 |
| hatch | yeah...see I even forgot what it's called | 14:40 |
| hatch | haha | 14:40 |
| gary_poster | :-) | 14:41 |
| hatch | so how was everyones Easter? Eat too much food? | 14:44 |
| gary_poster | kids go crazy with too much sugar | 14:47 |
| gary_poster | bac, do you know diff between []params.Port(nil) and []params.Port{} ? Test expects first and obtains second | 14:47 |
| hatch | I was thinking when I have kids I'll hide carrots and lettuce - afterall they are from a rabbit | 14:47 |
| hatch | haha | 14:48 |
| gary_poster | heh | 14:48 |
| Makyo | Bathed dogs, who then ran around at the dog park and got all gross again. | 14:48 |
| gary_poster | :-) | 14:48 |
| hatch | Makyo: yeah - it's impossiblet o keep dogs clean in the spring | 14:48 |
| * hatch clearly forgot how to type too | 14:48 | |
| rick_h_ | labs ftw | 14:48 |
| hatch | rick_h_: are you saying labs don't get dirty? | 14:49 |
| bac | gary_poster: i don't. | 14:49 |
| gary_poster | k thanks | 14:49 |
| rick_h_ | hatch: yea, their coats are super easy thankfully | 14:50 |
| bac | the second is obvious but i'm not familiar with the first | 14:50 |
| Makyo | Thankfully both the sheps have short coats, so they clean up easily. | 14:50 |
| hatch | rick_h_: oh haha - my dogs are only like 7" off the ground so they get dirty regardless :) | 14:50 |
| hatch | the app.js initializer is almost 200 lines...I think it needs to be split up hehe | 14:54 |
| rick_h_ | hatch: we have to go back to this multiple call business still as well. It's starting to get annoying heh | 14:56 |
| hatch | multiple dispatch? | 14:57 |
| rick_h_ | hatch: yea | 14:57 |
| hatch | agreed | 14:57 |
| * hatch lights the torches and hands one to rick_h_ | 14:57 | |
| rick_h_ | since I'm scolling down to view my work it keeps moving the windows focus on me | 14:57 |
| hatch | why don't you set your container to position absolute? :) | 14:58 |
| * rick_h_ loads weapon of CSS destruction | 14:58 | |
| hatch | haha it shouldn't break anything | 14:59 |
| hatch | although you'll probably have to set position relative on the container | 15:00 |
| hatch | which might break everything | 15:00 |
| hatch | :) | 15:00 |
| hatch | ohh funny story | 15:02 |
| hatch | I stepped through my garage roof yesterday | 15:03 |
| hatch | yesterday - a day | 15:03 |
| hatch | heh woops | 15:03 |
| bac | hey our wordpress blog has a fan. ronscubadiver from TX just like my post. we have an audience! | 15:04 |
| hatch | right...on! | 15:04 |
| hatch | gary_poster: are we using _'s in sandbox.js? | 15:05 |
| gary_poster | hatch, only for legacy bits | 15:05 |
| gary_poster | hatch which means the handlers | 15:05 |
| hatch | alright gotcha - I was kind of wondering if these shoudln't be in a closure so we didn't have to prefix them | 15:06 |
| hatch | it doesnt really matter | 15:06 |
| hatch | just thinking :) | 15:06 |
| hatch | jujugui - uistage is broken a conflicted file was comitted | 15:25 |
| gary_poster | hatch fixing not committed I don't think checking | 15:25 |
| * bac looks | 15:25 | |
| bac | gary_poster: you doing it? or me? | 15:25 |
| gary_poster | bac you thank you | 15:25 |
| gary_poster | bac lplease lemme know when done | 15:25 |
| hatch | gary_poster: am I correct that I can't test this add_unit code until I first implement get_service? | 15:29 |
| gary_poster | hatch, no. you need deploy, which you already have | 15:29 |
| gary_poster | hatch, deploy via the fake backend, get the service from the result, and then use that id for the add_unit | 15:30 |
| gary_poster | works? | 15:30 |
| gary_poster | you can actually provide the id explicitly and then you don't even need to look at the result | 15:30 |
| hatch | oh ok I need to manually trigger it | 15:30 |
| hatch | I was trying to figure out how add_unit was called from the UI | 15:31 |
| gary_poster | well, since you are not testing that part of the API, that makes sense to me | 15:31 |
| gary_poster | that's the test prep | 15:31 |
| bac | gary_poster: uistage happy again | 15:34 |
| gary_poster | cool thanks bac | 15:34 |
| gary_poster | rick_h_, ^^ | 15:34 |
| rick_h_ | gary_poster: thanks | 15:34 |
| gary_poster | ty | 15:34 |
| gary_poster | we really should deploy that from a charm | 15:34 |
| gary_poster | rick_h_, do you have a deployment plan for jujucharms.com, he said with a shudder? | 15:35 |
| rick_h_ | gary_poster: otp, sec | 15:36 |
| gary_poster | np | 15:36 |
| rick_h_ | gary_poster: so, from what I understand it's been handed off to #is to complete getting it deployed to prodstack. | 15:46 |
| rick_h_ | gary_poster: sinzui will know more/status than I at the moment ^ | 15:46 |
| gary_poster | rick_h_, but I meant the GUI itself | 15:47 |
| rick_h_ | gary_poster: oh, the deployment story I imagine is getting the gui charm up and running on prodstack under that domain. | 15:47 |
| gary_poster | rick_h_, and that won't be *any problem at all* will it ;-) | 15:47 |
| rick_h_ | gary_poster: I've got nothing about deploying gui than you guys have. I'm jumping on your train | 15:47 |
| rick_h_ | sorry, assumed it was a yellow problem and such :) | 15:48 |
| rick_h_ | gary_poster: well, honestly shuoldn't be since you guys don't have external services to HA and the like. The only thing will be gettnig HA proxy in front of the Gui and making sure multiple instances can run side by side. | 15:48 |
| gary_poster | rick_h_, ok, cool. I had the "jujucharms.com is for orange" in my head. glad we are ironing out. that could have been a nasty surprise | 15:48 |
| sinzui | No movement on our ticket. I did update it make it clear we have delivered our part for manage.jujucharms.com, and that it is required to deliver juju-gui as jujucharms.com | 15:49 |
| rick_h_ | gary_poster: definitely. Orange is moving jujucharms.com to management.jujucharms.com which is our charmworld pyramid app on prodstack | 15:49 |
| rick_h_ | gary_poster: jujucharms.com should be the prodstack deployed juju gui charm | 15:49 |
| gary_poster | yeah, in our configuratuion they shouldn't even need to talk to one another: it will be in-browser "juju" | 15:49 |
| rick_h_ | gary_poster: maybe you can sinzui and the people working on the gui charm should meet up and head off any craziness at the pass | 15:49 |
| gary_poster | so, rick_h_, the only challenge I know of will be that they will want to be able to get the tarball and any deb dependencies from their own locations | 15:50 |
| bac | hatch: can you confirm that browser_charm_view fails on trunk for you? | 15:50 |
| gary_poster | rick_h_, +1 | 15:50 |
| bac | it didn't look like anything i would've broken | 15:50 |
| gary_poster | bac I had to make clean before it passed | 15:50 |
| bac | err | 15:50 |
| * bac tries | 15:50 | |
| gary_poster | not ideal but I didn't have time to investimagate | 15:50 |
| bac | i'm glad to know 0 does not deeply equal 2 | 15:50 |
| Makyo | Out of control notifications. Back in a sec. | 15:50 |
| gary_poster | :) | 15:51 |
| hatch | bac sure | 15:51 |
| * hatch switches gears | 15:51 | |
| bac | hatch: nm, given gary_poster's report | 15:51 |
| * hatch switches back | 15:51 | |
| hatch | :) | 15:51 |
| gary_poster | sinzui, do you think depoyment is good topic for call in 8 minutes with group? | 15:52 |
| gary_poster | deployment of GUI on prodstack for jujucharms | 15:52 |
| sinzui | gary_poster, yes | 15:52 |
| gary_poster | ok cool | 15:52 |
| bac | thanks gary_poster. wfm now | 15:52 |
| gary_poster | cool bac | 15:52 |
| sinzui | gary_poster, as I hinted in the last call. We are waiting for manage.jujucharms.com to be deployed. It is a requirement for juju-gui to become jujucharms.com | 15:53 |
| gary_poster | sinzui, right. I didn't think about the fact that the GUI charm itself will need to be hardened for prodstack | 15:53 |
| gary_poster | I *think* I know what that will entail | 15:53 |
| gary_poster | and for our purposes I don't think it will be too much | 15:54 |
| gary_poster | just make it possible to get tarball and debs from custom locations | 15:54 |
| gary_poster | and not reach out to other locations in that case | 15:54 |
| rick_h_ | arosales: so with staging happy http://uistage.jujucharms.com:8080/bws/sidebar should load. Let it load then scroll down below the environment. | 16:12 |
| rick_h_ | arosales: click on the charm to view the details, same thing. Scroll down to see the start of display/tabs. No UX so it's just framing for the JS view/functionality vs look/feel :) | 16:13 |
| arosales | rick_h_: thanks. I'll take a look now . . . | 16:20 |
| hatch | rick_h_: pretty cool :) | 16:20 |
| hatch | hurry up and fix so I can demo the router stuff :P | 16:21 |
| hatch | s/fix/finish | 16:21 |
| hatch | gary_poster: in the tests I have state.deploy('cs:wordpress', function() {}); and then before that env.get('conn').onmessage(function(received) { ... }); but that callback is never triggered | 16:23 |
| hatch | am I missing how this works? | 16:24 |
| hatch | let me rephrase that | 16:24 |
| hatch | I am missing how this works | 16:24 |
| hatch | haha | 16:24 |
| gary_poster | hatch sorry calls | 16:40 |
| hatch | np I may have it | 16:40 |
| hatch | testing now | 16:41 |
| gary_poster | ok cool hatch. | 16:41 |
| hatch | gary_poster: still on a call? https://code.launchpad.net/~hatch/juju-gui/add-unit my test fails in mocha but passes in the browser | 17:00 |
| hatch | TypeError: JSON.stringify cannot serialize cyclic structures. (mocha-phanto│GET /juju-ui/assets/images/picker_1px.png 200 2ms - 965 | 17:00 |
| hatch | mjs/core_extensions.js:50) | 17:00 |
| hatch | it's also very slow +1s | 17:01 |
| gary_poster | no on call hatch. you mean fails in phantom right? | 17:01 |
| hatch | yeah...oh man I need another coffee or something hah | 17:01 |
| gary_poster | looking | 17:01 |
| hatch | I'm assuming I"m doing this wrong becuase there is no way that tests should take over 1s | 17:01 |
| gary_poster | verified symptoms hatch. now looking at code | 17:05 |
| hatch | thanks | 17:06 |
| hatch | my experience with the environment code is virtually 0 so I woudln't doubt I'm doing this wrong | 17:06 |
| gary_poster | hatch, let's guichat | 17:08 |
| hatch | alright | 17:08 |
| === matsubara is now known as matsubara-lunch | ||
| === Makyo is now known as Makyo|out | ||
| Makyo|out | Haircut time | 17:48 |
| hatch | gary_poster: http://pastebin.ubuntu.com/5668110/ | 17:54 |
| hatch | any input? | 17:54 |
| gary_poster | hatch, #1, clear out the delta stream, as we said | 17:55 |
| gary_poster | before you open | 17:55 |
| hatch | oh right - I had that in there but didn't appear to make any difference | 17:56 |
| hatch | I'll add it back | 17:56 |
| gary_poster | hatch #2, the fact that you are waiting 1 second means that you are still not returning an initial response (client.receive, like in the login op handler) | 17:56 |
| gary_poster | because waiting one second means that you are waiting for the delta stream | 17:57 |
| gary_poster | when you should be waiting for the client response | 17:57 |
| hatch | ahh ok | 17:57 |
| hatch | oh looks like I had a typo there | 17:57 |
| hatch | man we REALLY need to document attrs and events | 18:12 |
| gary_poster | hatch, write down the pain, because otherwise you will forget it | 18:13 |
| gary_poster | that is the specific things that you mean | 18:13 |
| hatch | yep for sure | 18:13 |
| === matsubara-lunch is now known as matsubara | ||
| bac | hatch: when you have some time i'd like to get some help | 18:21 |
| hatch | sure 5mins? | 18:21 |
| hatch | I have new neighbours today....wonder what they will be like | 18:22 |
| * hatch hopes they don't throw huge parties every weekend | 18:22 | |
| gary_poster | hatch, interestingly the unit tests were fine, without any retries, for two or three times in a row. The most recent ran the unit tests four times before it got a success, but at least it did eventually get a success. :-/ http://10.189.74.2:8080/job/jujugui-test-charm/206/console | 18:25 |
| hatch | man that's so irritating | 18:27 |
| hatch | it never fails in chrome though does it? | 18:27 |
| hatch | bac: ok I'm at a good break point | 18:27 |
| hatch | what's up? | 18:27 |
| === BradCrittenden is now known as bac__ | ||
| === bac__ is now known as bac | ||
| ahasenack | hi guys, | 18:47 |
| ahasenack | I deployed juju-gui using "stable", and /var/lib/juju/units/juju-gui-0/charm/juju-gui/build-prod/juju-ui/version.js confirms that | 18:47 |
| ahasenack | var jujuGuiVersionInfo=['0.3.1', '470']; | 18:47 |
| ahasenack | but I don't see a "landscape" link in the lower right corner, it's been a while since I last deployed this | 18:47 |
| ahasenack | maybe I'm just not finding it, where should it be, does someone know? | 18:48 |
| gary_poster | ahasenack, the link does not show up until landscape has annotated the environment | 18:48 |
| ahasenack | ah, ok | 18:48 |
| ahasenack | so I have some bug hunting to do :) | 18:48 |
| gary_poster | :-) | 18:48 |
| hatch | gary_poster: I think bac may have found our test failing issue | 18:53 |
| gary_poster | yay? | 18:53 |
| hatch | well whatever he is doing is causing the tests in application basics to fail | 18:53 |
| hatch | but randomly | 18:53 |
| hatch | sometimes it passes | 18:53 |
| gary_poster | :-) fun | 18:53 |
| hatch | sometimes 2 fail, sometimes 8 fail | 18:53 |
| gary_poster | sounds different to me | 18:53 |
| hatch | sure - but if you look at the test suite you'll notice that it doesn't clean up after itself | 18:57 |
| ahasenack | gary_poster: what would be a line in the logs that confirms landscape is sending the annotations? I have seen some like these: | 18:58 |
| gary_poster | hatch, if we fix it, I'd be thrilled :-) | 18:58 |
| ahasenack | 2013-04-01 14:48:40,793: juju.rapi.ws@DEBUG: send delta update [('service', 'change', {'charm': 'local:precise/keystone-213', 'annotations': {u'landscape-computers': u'%2Bservice%3Akeystone', u'gui-y': 153.5838711310003, u'gui-x': 570.5940154188667}, 'id': 'keystone'}), ('service', 'change', {'charm': 'local:precise/nova-compute-87', 'annotations': {u'landscape-computers': u'%2Bservice%3Anova-compute', u'gui-y': 277.31 | 18:58 |
| ahasenack | 58501443403, u'gui-x': 869.4793787934253}, 'id': 'nova-compute'})] | 18:58 |
| ahasenack | (send) | 18:58 |
| ahasenack | and | 18:58 |
| ahasenack | 2013-04-01 14:48:25,691: juju.rapi.ws@INFO: Process message {"op":"update_annotations","entity":"keystone","data":{"gui-x":570.5940154188667,"gui-y":153.5838711310003},"request_id":3} | 18:59 |
| ahasenack | but I'm not sure who sent them | 18:59 |
| ahasenack | other than that, no easy traceback on either side so far | 18:59 |
| ahasenack | still digging | 18:59 |
| gary_poster | ahasenack, the second one is unrelated | 18:59 |
| gary_poster | that is the gui annotating viaula location of a service | 19:00 |
| gary_poster | visual | 19:00 |
| gary_poster | the first is promising | 19:00 |
| ahasenack | yeah, figured (x-y coordinates) | 19:00 |
| hatch | viaula sounds like some medication name ;) | 19:00 |
| gary_poster | :-P | 19:00 |
| ahasenack | yeah, that first one has bits of a valid landscape link | 19:01 |
| ahasenack | the service:nova-compute part | 19:01 |
| ahasenack | it's a landscape computer search | 19:01 |
| gary_poster | ahasenack, if I had to guess, I would guess that the environment annotations are not being set/sent to the GUI | 19:01 |
| === Makyo|out is now known as Makyo | ||
| gary_poster | that provides the base of the URL | 19:01 |
| gary_poster | and it is what we use to determine if we should turn on the environment annotations | 19:01 |
| ahasenack | ok | 19:03 |
| gary_poster | ahasenack, ideally you would see these annotations in that stream. maybe look for the string "environment"? | 19:04 |
| gary_poster | ahasenack, other thinsg I can do to help, though it would take me a few minutes: | 19:04 |
| ahasenack | I can see landscape connecting to the api | 19:05 |
| gary_poster | - give you something to run in the browser to look at the annotations the the GUI knows about for the environment | 19:05 |
| ahasenack | I restarted that landscape service and I see the login op, and the api sending back a bunch of stuff | 19:05 |
| ahasenack | I need to watch for the other way around now | 19:05 |
| gary_poster | - give you something to run in the browser to ask Juju directly for annotations on the environment | 19:05 |
| ahasenack | in the "send delta update" bit, there are annotations in it | 19:06 |
| gary_poster | ahasenack, when it sent a bunch of struff did it include "environment" associated with an update_annotations op? | 19:06 |
| ahasenack | 'annotations': {u'landscape-computer': u'%2Bunit%3Aswift-proxy%252F1', u'landscape-needs-reboot': True} | 19:06 |
| ahasenack | I'll have to check, it's a long message | 19:06 |
| gary_poster | yeah, we established that services are getting annotations | 19:06 |
| gary_poster | yeah, grep it! :-) | 19:07 |
| ahasenack | no update_annotation yet | 19:08 |
| ahasenack | or "environment" | 19:08 |
| * hatch goes to eat | 19:08 | |
| gary_poster | I'm trying to verify on my side with test data | 19:08 |
| hatch | ding if ya need me | 19:08 |
| ahasenack | older bits of the logs do have it | 19:09 |
| ahasenack | hm, wait | 19:09 |
| ahasenack | that's the x-y position ones | 19:09 |
| gary_poster | 1 sec ahasenack I got something else for you to look for | 19:10 |
| bac | anyone seen google maps today? | 19:10 |
| ahasenack | the only "environment" string I have is | 19:10 |
| ahasenack | # grep environment api-agent.log | 19:10 |
| ahasenack | 2013-04-01 11:44:01,019: juju.agents.api@DEBUG: Received environment data. | 19:10 |
| gary_poster | ahasenack, I'm on crack, but I'm trying to wean myself off. ;-) see http://pastebin.ubuntu.com/5668359/ | 19:11 |
| gary_poster | ahasenack, those values are old | 19:11 |
| gary_poster | ahasenack, but the keys are correct | 19:11 |
| ahasenack | gary_poster: so, I should look for a log entry similar to that one, with those keys | 19:11 |
| gary_poster | in particular we have to have landscape-url, but all those keys are necessary | 19:11 |
| gary_poster | precisely ahasenack | 19:12 |
| ahasenack | yeah, no landscape-url anywhere | 19:12 |
| gary_poster | ahasenack, I'm suspicious that landscape is not giving us the keys we need anymore, then | 19:14 |
| gary_poster | well, even more suspicious, since I had already qa'd this on our end ;-) | 19:15 |
| ahasenack | gary_poster: ok, I'll file a bug on our side | 19:15 |
| gary_poster | thanks ahasenack | 19:15 |
| ahasenack | gary_poster: yeah, it changed to fix a bug | 19:15 |
| gary_poster | gotcha | 19:15 |
| ahasenack | wouldn't be the first time a bug was introduced by a fix | 19:15 |
| gary_poster | :-) no | 19:15 |
| bac | gary_poster: vacation request submitted. | 19:20 |
| rick_h_ | jcsackett: hatch if you guys get a few spare minutes :) https://codereview.appspot.com/8171047 | 19:34 |
| hatch | NEVAAAAAAA | 19:38 |
| hatch | rick_h_: is there a risk of that qa.json becoming stale? | 19:40 |
| Makyo | >:/ | 19:44 |
| rick_h_ | hatch: yea, but kind of the case with any sample data :/ | 19:46 |
| hatch | yeah true true | 19:46 |
| hatch | Makyo: don't like your hair? | 19:56 |
| Makyo | hatch, Nah, it came out fine. Don't like my wireless router, though. | 19:57 |
| hatch | Makyo: your new hair? http://1.bp.blogspot.com/-bJLQi7wKPU8/T7EH46gZ_gI/AAAAAAAABNU/eRblcqMK6GU/s400/09-mohawk.jpg | 19:57 |
| Makyo | hatch, I don't think I could quite pull that off.. :) | 19:58 |
| hatch | lol | 19:58 |
| hatch | how will you know unless you try? | 19:58 |
| hatch | you miss 100% of the shots you don't take :P | 19:58 |
| Makyo | Who's to say I haven't? | 19:58 |
| hatch | true true | 19:58 |
| Makyo | (ps: I haven't) | 19:59 |
| hatch | lol | 19:59 |
| hatch | gary_poster: in python.js ln 133 there is a line this.ws.send(msg) in _send_rpc() can you tell me where this is set? | 20:08 |
| gary_poster | looking hatch | 20:09 |
| hatch | oh I found it | 20:10 |
| hatch | heh | 20:10 |
| hatch | figures | 20:10 |
| hatch | :D | 20:10 |
| gary_poster | :-) k | 20:10 |
| hatch | basically I'm trying to track down an error with env.add_unit() | 20:10 |
| hatch | on the integration test | 20:11 |
| hatch | hey gary_poster you wrote the addUnit method in fakebackend.js right? | 20:20 |
| hatch | wait ignore that | 20:20 |
| hatch | this is my screwup | 20:20 |
| hatch | ok lets roll that back just a bit | 20:23 |
| hatch | :) | 20:23 |
| hatch | gary_poster: is it possible that the addUnit method doesn't return the proper formatted data? Or is it intentional that I'm supposed to match it to the real output? | 20:34 |
| gary_poster | hatch, there's only confidence if there is a test. :-) Let's see if there is a test for addUnit in the test_fakebackend file... | 20:35 |
| hatch | well it works | 20:36 |
| gary_poster | hatch, tests seem reasonable. if you think there's a problem, maybe try to write a breaking one? | 20:36 |
| hatch | it's output just doesn't match the native one | 20:36 |
| gary_poster | hatch, oh! no, that's the job of what you are writing | 20:36 |
| gary_poster | remember I said there was deterctive work involved? | 20:37 |
| gary_poster | detective, even | 20:37 |
| hatch | yep ok - so then I'll break these tests | 20:37 |
| hatch | and that's ok? | 20:37 |
| gary_poster | hatch, um? | 20:37 |
| gary_poster | hatch, let's have a guichat :-) | 20:37 |
| hatch | sure :) | 20:37 |
| jcsackett | hatch, Makyo, rick_h_: can two of you fine folks look at https://codereview.appspot.com/8071044 | 20:43 |
| Makyo | Sure, on it. | 20:43 |
| jcsackett | Makyo: thanks. | 20:43 |
| gary_poster | Makyo LGTM | 20:49 |
| Makyo | gary_poster, thanks | 21:04 |
| * Makyo walks dogs before it rains. | 21:04 | |
| gary_poster | :-) welcome | 21:04 |
| hatch | gary_poster: when you get a second could you check out https://codereview.appspot.com/8236043/ | 21:05 |
| hatch | I am pretty sure I got it this time | 21:05 |
| hatch | haha | 21:05 |
| * hatch has a thick skull sometimes | 21:05 | |
| gary_poster | hatch, yeah. Still a bit of trouble, I think. | 21:05 |
| gary_poster | sorry, hatch, but let's guichat | 21:05 |
| hatch | :'( | 21:06 |
| hatch | alright | 21:06 |
| hatch | gary_poster: code has been updated | 22:34 |
| gary_poster | hatch, just saw, looking | 22:35 |
| hatch | awesome | 22:35 |
| * hatch crosses fingers | 22:36 | |
| gary_poster | looks good hatch, doing silly normal review things :-) | 22:36 |
| gary_poster | will eventually result in a LGTM :-) | 22:37 |
| gary_poster | hatch, LGTM with small suggestion | 22:38 |
| hatch | thanks - sure I'll add that :) | 22:38 |
| hatch | I actually didn't know there was an isUndefined | 22:40 |
| hatch | :) | 22:40 |
| gary_poster | assert is a nice interface. I didn't start using it till I saw benji use it | 22:40 |
| * hatch wonders what assertion lib we are actually using | 22:40 | |
| gary_poster | chai | 22:40 |
| gary_poster | IIRC | 22:40 |
| gary_poster | at least that doc has worked well for me ;-) | 22:41 |
| hatch | haha perfect | 22:41 |
| hatch | hmm after I added assert(isUndefined(data.err)); I got a 'verify dependency' error | 22:44 |
| hatch | but now it's working just fine | 22:44 |
| hatch | there is definitely some leakage in some tests here | 22:44 |
| hatch | maybe after 13.04 we take a day and go through all of the suites to clean them up | 22:44 |
| hatch | assert.isUndefined(data.err); | 22:45 |
| hatch | i mean | 22:45 |
| hatch | bcsaller: able to take a look at my fakebackend branch for review? | 22:47 |
| bcsaller | hatch: got the link | 22:49 |
| bcsaller | ? | 22:49 |
| hatch | https://codereview.appspot.com/8236043/ | 22:49 |
| hatch | gary_poster: if you're still around - any idea which task you want me to tackle next so I can do some evening reading | 22:56 |
| hatch | bcsaller: I just copied that signature from a previous test | 23:14 |
| hatch | oh it looks like it's from python.js ln 227 | 23:15 |
| gary_poster | hey hatch. I'm here for a sec. you still here? | 23:50 |
| gary_poster | thanks for getting that branch landed. cool. | 23:50 |
| hatch | I am yep | 23:50 |
| hatch | I'm glad it's over :D | 23:50 |
| hatch | although I have a much much better understanding of what's going on | 23:50 |
| hatch | haha | 23:50 |
| gary_poster | :-() | 23:52 |
| gary_poster | :-) | 23:52 |
| gary_poster | first smiley: fat finger led to fat lip | 23:52 |
| hatch | haha | 23:52 |
| gary_poster | hatch, how about remove_units? it's all in a similar part of the world, so it would be a natural change. | 23:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
