StevenKwgrant: https://code.launchpad.net/~stevenk/launchpad/silence-yui-build/+merge/15727205:15
wgrantStevenK: Why not make it a proper make rule?05:18
wgrantStevenK: Can't you just skip extracting a version if it's already extracted?05:19
StevenK-$(RM) -r $(JS_BUILD_DIR)/yui-$$V; \05:23
StevenK+[ -d $(JS_BUILD_DIR)/yui-$$V/yui ] && continue; \05:23
StevenKwgrant: ^ ?05:23
wgrantStevenK: Probably, unless you want to rewrite it to use make properly.05:23
StevenKThat may print out No such file or directory for clean trees05:24
StevenKwgrant: I'm up for that, since that part of the Makefile shits me, I'm just not sure how to.05:24
wgrant-d shouldn't print anything05:24
StevenKwgrant: So having a target for build/js/yui-VERSION: sounds like a good plan, but I can't get make to do that for me05:39
wgrantStevenK: $(JS_BUILD_DIR)/yui-%:?05:40
StevenKwgrant: Well, I'd like a target for each version05:41
wgrantStevenK: That is a target for each version05:41
StevenKBut it won't expand for 3.3.0 and 3.5.105:41
wgrantWon't it?05:42
wgrantYou'll need another rule to depend on the targets for the two versions05:42
wgrantThat's what YUI_BUILDS is05:43
* StevenK stabs make05:55
StevenKThe directory exists, so skip the rule!05:55
StevenKwgrant: The MP is updated06:57
StevenKSee what you think of that06:57
=== almaisan-away is now known as al-maisan
StevenKThe changes are happy with a clean build and a build that already has a build/js07:03
wgrantStevenK: Why the YUI_TWO change?07:05
wgrantI guess it does clean up the console output a lot, and we never change it07:05
wgrantBut you can use digits in identifiers :)07:05
StevenKwgrant: Because I was sick of it making and copying every directory under yui_2.../build07:05
StevenKI can change the identifier to YUI2 if you wish07:06
wgrantOr YUI2_BUILD or something07:06
wgrantStevenK: Why'd you remove it from the comboloader?07:07
wgrantDo we not comboload YUI2?07:07
StevenKThat is not the comboloader07:08
StevenKCompare the makefile rule versus combo-rootdir07:08
wgrantIt's the thing that makes code available to the comboloader07:08
wgrantIsn't it?07:09
StevenKThey do the exact same thing, except that combo-rootdir's looks like it will make build/js/yui2/build rather than build/js/yui2/asset and friends07:09
StevenKwgrant: http://pastebin.ubuntu.com/5678948/ for matching goodness07:10
StevenKwgrant: It used to be, until rick did his horrible multiple YUI versions thing and then the makefile and combo-rootdir started doing it07:12
wgrantStevenK: What copies them into the comboloader root, then?07:12
wgrantOr does it just get symlinked...07:12
wgrantI can't remember07:12
StevenKwgrant: The make rule YUI_BUILDS will unpack them into the comboloader root07:13
StevenKcombo-rootdir will make a symlink to the default version, and populate build/js/lp07:13
StevenKwgrant: A further clean up would be to destroy combo-rootdir and do it all in make07:14
wgrantAnd then the comboloader grabs it from the symlink in /srv, which points directly at build/?07:15
StevenKbuild/js, yeah07:15
StevenK/srv/launchpad.dev/convoy -> /home/steven/launchpad/lp-branches/silence-yui-build/build/js07:16
wgrantSo combo-rootdir is now basically nothing07:16
StevenKLike I say, it makes the symlink and populates build/js/lp07:17
StevenKThose can be moved into make with a bit of fiddling07:17
wgrantBasically nothing :)07:17
wgrantYeah, probably worth doing that in a followup07:17
wgrantSeems silly to have it split07:17
StevenKI'm happy to leave this branch until Monday and finish the split07:18
wgrantSounds reasonable. Won't be much work07:18
wgrantWill be much cleaner07:18
=== al-maisan is now known as almaisan-away
=== almaisan-away is now known as al-maisan
=== al-maisan is now known as almaisan-away
=== jam1 is now known as jam
=== BradCrittenden is now known as bac
=== deryck is now known as deryck[lunch]
=== deryck[lunch] is now known as deryck
=== Ursinha_ is now known as Ursinha

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!