| StevenK | wgrant: https://code.launchpad.net/~stevenk/launchpad/silence-yui-build/+merge/157272 | 05:15 |
|---|---|---|
| wgrant | StevenK: Why not make it a proper make rule? | 05:18 |
| StevenK | Oh? | 05:18 |
| wgrant | StevenK: Can't you just skip extracting a version if it's already extracted? | 05:19 |
| StevenK | -$(RM) -r $(JS_BUILD_DIR)/yui-$$V; \ | 05:23 |
| StevenK | +[ -d $(JS_BUILD_DIR)/yui-$$V/yui ] && continue; \ | 05:23 |
| StevenK | wgrant: ^ ? | 05:23 |
| wgrant | StevenK: Probably, unless you want to rewrite it to use make properly. | 05:23 |
| StevenK | That may print out No such file or directory for clean trees | 05:24 |
| StevenK | wgrant: I'm up for that, since that part of the Makefile shits me, I'm just not sure how to. | 05:24 |
| wgrant | Why? | 05:24 |
| wgrant | -d shouldn't print anything | 05:24 |
| StevenK | wgrant: So having a target for build/js/yui-VERSION: sounds like a good plan, but I can't get make to do that for me | 05:39 |
| wgrant | StevenK: $(JS_BUILD_DIR)/yui-%:? | 05:40 |
| StevenK | wgrant: Well, I'd like a target for each version | 05:41 |
| wgrant | StevenK: That is a target for each version | 05:41 |
| StevenK | But it won't expand for 3.3.0 and 3.5.1 | 05:41 |
| wgrant | Won't it? | 05:42 |
| wgrant | You'll need another rule to depend on the targets for the two versions | 05:42 |
| wgrant | That's what YUI_BUILDS is | 05:43 |
| StevenK | Right | 05:44 |
| * StevenK stabs make | 05:55 | |
| StevenK | The directory exists, so skip the rule! | 05:55 |
| StevenK | wgrant: The MP is updated | 06:57 |
| StevenK | See what you think of that | 06:57 |
| === almaisan-away is now known as al-maisan | ||
| StevenK | The changes are happy with a clean build and a build that already has a build/js | 07:03 |
| wgrant | StevenK: Why the YUI_TWO change? | 07:05 |
| wgrant | I guess it does clean up the console output a lot, and we never change it | 07:05 |
| wgrant | But you can use digits in identifiers :) | 07:05 |
| StevenK | wgrant: Because I was sick of it making and copying every directory under yui_2.../build | 07:05 |
| StevenK | I can change the identifier to YUI2 if you wish | 07:06 |
| wgrant | Or YUI2_BUILD or something | 07:06 |
| wgrant | StevenK: Why'd you remove it from the comboloader? | 07:07 |
| wgrant | Do we not comboload YUI2? | 07:07 |
| StevenK | That is not the comboloader | 07:08 |
| StevenK | Compare the makefile rule versus combo-rootdir | 07:08 |
| wgrant | It's the thing that makes code available to the comboloader | 07:08 |
| wgrant | Isn't it? | 07:09 |
| StevenK | They do the exact same thing, except that combo-rootdir's looks like it will make build/js/yui2/build rather than build/js/yui2/asset and friends | 07:09 |
| StevenK | wgrant: http://pastebin.ubuntu.com/5678948/ for matching goodness | 07:10 |
| StevenK | wgrant: It used to be, until rick did his horrible multiple YUI versions thing and then the makefile and combo-rootdir started doing it | 07:12 |
| wgrant | StevenK: What copies them into the comboloader root, then? | 07:12 |
| wgrant | Or does it just get symlinked... | 07:12 |
| wgrant | I can't remember | 07:12 |
| StevenK | wgrant: The make rule YUI_BUILDS will unpack them into the comboloader root | 07:13 |
| StevenK | combo-rootdir will make a symlink to the default version, and populate build/js/lp | 07:13 |
| StevenK | wgrant: A further clean up would be to destroy combo-rootdir and do it all in make | 07:14 |
| wgrant | And then the comboloader grabs it from the symlink in /srv, which points directly at build/? | 07:15 |
| StevenK | build/js, yeah | 07:15 |
| StevenK | /srv/launchpad.dev/convoy -> /home/steven/launchpad/lp-branches/silence-yui-build/build/js | 07:16 |
| wgrant | Right | 07:16 |
| wgrant | Hm | 07:16 |
| wgrant | So combo-rootdir is now basically nothing | 07:16 |
| StevenK | No | 07:16 |
| StevenK | Like I say, it makes the symlink and populates build/js/lp | 07:17 |
| StevenK | Those can be moved into make with a bit of fiddling | 07:17 |
| wgrant | Basically nothing :) | 07:17 |
| wgrant | Yeah, probably worth doing that in a followup | 07:17 |
| wgrant | Seems silly to have it split | 07:17 |
| StevenK | I'm happy to leave this branch until Monday and finish the split | 07:18 |
| wgrant | Sounds reasonable. Won't be much work | 07:18 |
| wgrant | Will be much cleaner | 07:18 |
| === al-maisan is now known as almaisan-away | ||
| === almaisan-away is now known as al-maisan | ||
| === al-maisan is now known as almaisan-away | ||
| === jam1 is now known as jam | ||
| === BradCrittenden is now known as bac | ||
| === deryck is now known as deryck[lunch] | ||
| === deryck[lunch] is now known as deryck | ||
| === Ursinha_ is now known as Ursinha | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!