[05:15] wgrant: https://code.launchpad.net/~stevenk/launchpad/silence-yui-build/+merge/157272 [05:18] StevenK: Why not make it a proper make rule? [05:18] Oh? [05:19] StevenK: Can't you just skip extracting a version if it's already extracted? [05:23] - $(RM) -r $(JS_BUILD_DIR)/yui-$$V; \ [05:23] + [ -d $(JS_BUILD_DIR)/yui-$$V/yui ] && continue; \ [05:23] wgrant: ^ ? [05:23] StevenK: Probably, unless you want to rewrite it to use make properly. [05:24] That may print out No such file or directory for clean trees [05:24] wgrant: I'm up for that, since that part of the Makefile shits me, I'm just not sure how to. [05:24] Why? [05:24] -d shouldn't print anything [05:39] wgrant: So having a target for build/js/yui-VERSION: sounds like a good plan, but I can't get make to do that for me [05:40] StevenK: $(JS_BUILD_DIR)/yui-%:? [05:41] wgrant: Well, I'd like a target for each version [05:41] StevenK: That is a target for each version [05:41] But it won't expand for 3.3.0 and 3.5.1 [05:42] Won't it? [05:42] You'll need another rule to depend on the targets for the two versions [05:43] That's what YUI_BUILDS is [05:44] Right [05:55] * StevenK stabs make [05:55] The directory exists, so skip the rule! [06:57] wgrant: The MP is updated [06:57] See what you think of that === almaisan-away is now known as al-maisan [07:03] The changes are happy with a clean build and a build that already has a build/js [07:05] StevenK: Why the YUI_TWO change? [07:05] I guess it does clean up the console output a lot, and we never change it [07:05] But you can use digits in identifiers :) [07:05] wgrant: Because I was sick of it making and copying every directory under yui_2.../build [07:06] I can change the identifier to YUI2 if you wish [07:06] Or YUI2_BUILD or something [07:07] StevenK: Why'd you remove it from the comboloader? [07:07] Do we not comboload YUI2? [07:08] That is not the comboloader [07:08] Compare the makefile rule versus combo-rootdir [07:08] It's the thing that makes code available to the comboloader [07:09] Isn't it? [07:09] They do the exact same thing, except that combo-rootdir's looks like it will make build/js/yui2/build rather than build/js/yui2/asset and friends [07:10] wgrant: http://pastebin.ubuntu.com/5678948/ for matching goodness [07:12] wgrant: It used to be, until rick did his horrible multiple YUI versions thing and then the makefile and combo-rootdir started doing it [07:12] StevenK: What copies them into the comboloader root, then? [07:12] Or does it just get symlinked... [07:12] I can't remember [07:13] wgrant: The make rule YUI_BUILDS will unpack them into the comboloader root [07:13] combo-rootdir will make a symlink to the default version, and populate build/js/lp [07:14] wgrant: A further clean up would be to destroy combo-rootdir and do it all in make [07:15] And then the comboloader grabs it from the symlink in /srv, which points directly at build/? [07:15] build/js, yeah [07:16] /srv/launchpad.dev/convoy -> /home/steven/launchpad/lp-branches/silence-yui-build/build/js [07:16] Right [07:16] Hm [07:16] So combo-rootdir is now basically nothing [07:16] No [07:17] Like I say, it makes the symlink and populates build/js/lp [07:17] Those can be moved into make with a bit of fiddling [07:17] Basically nothing :) [07:17] Yeah, probably worth doing that in a followup [07:17] Seems silly to have it split [07:18] I'm happy to leave this branch until Monday and finish the split [07:18] Sounds reasonable. Won't be much work [07:18] Will be much cleaner === al-maisan is now known as almaisan-away === almaisan-away is now known as al-maisan === al-maisan is now known as almaisan-away === jam1 is now known as jam === BradCrittenden is now known as bac === deryck is now known as deryck[lunch] === deryck[lunch] is now known as deryck === Ursinha_ is now known as Ursinha