smspillazWalther: it is, you just need to enable it01:51
smspillazWalther: see the grid plugin options in ccsm01:51
smspillazquarter-split is not really as robust though, as we can't use the same constraints mechanism that we get with semimax windows01:52
=== jono is now known as Guest52708
mzanettigood morning07:11
tsdgeosmzanetti: welcome07:40
mzanettitsdgeos: hi07:40
Saviqmzanetti, welcome back07:41
mzanetticheers Saviq07:41
mzanettianything for me to catch up?07:42
Saviqmzanetti, business as usual I think07:43
mzanettiSaviq: ok.... going through my mails and then continue with jenkins07:43
Saviqmzanetti, yeah, I'd like to do a review of coverage with you - early next week?07:44
mzanettiSaviq: ok07:44
om26erTrevinho, Hi!08:00
seb128hey unity hackers09:20
seb128seems like the fix for https://bugs.launchpad.net/unity/+bug/1108956 broke some unity tests09:20
ubot5Launchpad bug 1108956 in unity (Ubuntu) "The dash closes when trying to switch from Command lens to home lens" [Low,Fix committed]09:20
seb128if you do e.g "super-m" "super", it used to open the music lens and then close the dash09:21
seb128now it does come back to the home lens on "super"09:21
seb128that breaks tests like09:21
seb128"The test left the dash open"09:21
davidcalledidrocks, https://code.launchpad.net/~davidc3/cupstream2distro-config/remove-scopes-target-branches/+merge/15730409:21
didrocksdavidcalle: thanks! I'm modifying unity-scope-home as well09:22
didrocksand commiting this09:22
seb128sil2100, hey09:22
seb128sil2100, ^ see, I just did some investigation on failing tests09:22
didrocksdavidcalle: pushed, thanks09:23
davidcalledidrocks, ty!09:23
didrocksfginther: once you are around, can you please deploy rev 149 from cupstream2distro-config?09:25
* didrocks does the daily-release deployement09:25
davidcalledidrocks, soon , we will have https://code.launchpad.net/unity-scope-ubuntuone too :) But it's still WIP09:25
didrocksdavidcalle: I heard about it! great :)09:25
nic-doffayStill up for review everyone: https://code.launchpad.net/~nicolas-doffay/unity/page-header-test/+merge/15524209:33
seb128sil2100, https://bugs.launchpad.net/unity/+bug/116491509:51
ubot5Launchpad bug 1164915 in unity (Ubuntu) "dash doesn't close when pressing <super> on a specific lens" [Undecided,New]09:51
Saviqnic-doffay, so, you want to fix PageHeader.qml to not reference "greeter" directly09:58
nic-doffayThat's right.09:59
Saviqnic-doffay, and then you want to provide a greeter-like object in the test that will have the "shown" property - and test whether changing that value affects the PageHeader accordingly09:59
nic-doffaySaviq, regarding the controls test, after looking taking a look at tst_Stage, would something similar to the following be suitable (taken from tst_Stage)? https://pastebin.canonical.com/88500/10:11
sil2100seb128: hi! Looking at those, sorry I didn't answer earlier, I fell asleep by accident ;)10:14
seb128sil2100, hey, I filed https://code.launchpad.net/~seb128/unity/1164915-fix/+merge/157313 with a revert and didrocks acked it10:15
nic-doffaySorry about that Saviq, back.10:15
seb128sil2100, sleeping is what night are for :p10:15
sil2100seb128: I know ;) Not feeling too well today though - indeed I see this regression here, strange that we didn't notice it earlier10:17
Saviqnic-doffay, well, yeah, but needs to be adapted to the case at hand, so you would have at least a button to trigger the search entry10:17
seb128sil2100, oh, get some rest if you are not feeling well10:17
Saviqnic-doffay, and a checkbox that mimics greeter.shown10:17
Saviqnic-doffay, and another checkbox to change the width10:17
seb128sil2100, in any case revert is on its way and we will retry tests to see what's the status, so no hurry for other changes10:18
nic-doffayWhat purpose does the AppControl serve Saviq ? I was mainly wondering about that. Is it specific to the Stage test?10:19
sil2100seb128: the ps-unity-autopilot-release-testing job?10:20
sil2100seb128: ah, the -generic- job I see10:21
seb128sil2100, right,
sil2100But this is really strange, since rev 3266 was around for quite a while IIRC, and we didn't notice this regression during unity-release-* jobs10:24
Saviqnic-doffay, yes10:29
Saviqnic-doffay, you won't need that10:29
seb128sil2100, did you have a successful run since?10:30
Saviqnic-doffay, you'll be fine with just standard buttons and checkboxes10:30
=== dandrader is now known as dandrader|afk
seb128sil2100, the commit landed on the 2nd and the run on the 3rd was
seb128sil2100, 157 fails10:31
sil2100seb128: now I see that the possible test run didn't really happen even10:31
sil2100seb128: so indeed it's the faulty commit10:32
sil2100Since the commit has been made after the test run10:32
nic-doffayWould you advise using this code from tst_Stage Saviq ? https://pastebin.canonical.com/88502/10:33
=== dandrader|afk is now known as dandrader
nic-doffayI'm mainly concerned about where to place all these test buttons.10:37
mzanettihey nic-doffay! How is it going?10:39
nic-doffayHow are you?10:39
mzanettinic-doffay: the PageHeader tests good now?10:39
mzanettinic-doffay: yeah, I'm great!10:39
nic-doffayAlmost there mzanetti just have to add some control tests. Feel free to give an opinion!10:39
mzanettinic-doffay: ok, I'll check it out10:40
nic-doffayMainly interested in placement in the test.10:40
nic-doffayI'm assuming the control test components shouldn't be put in an intrusive place. Are there any prefered standards etc?10:40
sil2100seb128: ps-generic-autopilot-release-testing uses unity straight from trunk?10:40
seb128sil2100, the daily staging ppa which is basically trunk I think10:42
mzanettinic-doffay: ok. I've checked it out now. doesn't look bad10:46
mzanettinic-doffay: didn't understand your question tho10:46
nic-doffayIt's regarding the control tests that Saviq suggested.10:46
nic-doffayWhere would an appropriate place to put all the testing components?10:47
nic-doffaymzanetti, ^10:47
Saviqnic-doffay, just next to the actual view you're testing10:47
Saviqnic-doffay, put a grid of checkbox/button | description10:47
Saviqnic-doffay, next to an Item that actually contains the tested component10:48
nic-doffayAre there any enforced standards? Because I was thinking of just putting it on the right.10:48
Saviqnic-doffay, yeah, just fine10:48
mzanettinic-doffay: also, don't use fixed numbers for width/height but rather use units.gu()... otherwise it won't work on different DPI screens10:48
Saviqmzanetti, indeed!10:48
sil2100seb128: since it's using daily-build, the next unity will be published in the PPA tomorrow I think - it still has the 6 hours-ago version in it10:48
Saviqnic-doffay, make sure to put the actual tested components in a separate components10:49
Saviqand then next to it the buttons and checkboxes10:49
nic-doffayYou mean to the actual test itself Saviq ?10:49
sil2100seb128: since from what I know it fetches unity once-per-day, at least that's how it was before10:50
mzanettiSaviq: is this about the checkboxes for properties as dandrader always puts in his tests?10:50
Saviqmzanetti, yup10:50
* mzanetti really likes those... in case a test fails its super easy to reproduce the failure10:50
nic-doffayI was planning on putting the control test item as a child of the root (UnityTestCase also being a child of the root)10:50
Saviqnic-doffay, in your case - put the PageHeader in a container10:51
Saviqnic-doffay, with clip: true10:51
Saviqnic-doffay, and then on the right a grid of button/checkbox | description10:51
Saviqnic-doffay, container == Item10:52
tsdgeosDoes anyone have an opinion on https://code.launchpad.net/~michihenning/unity/cpp-warnings/+merge/157010 ?10:53
tsdgeoseven a suggestion on how to fix the gpointer warning in a less ugly way?10:53
nic-doffaySaviq, yeah cool assumed the container would an Item, however what does clip: true do? I'm not familiar with that.10:54
tsdgeosmzanetti: remove the "#testedlines=301"?10:56
mzanettitsdgeos: ack10:58
mzanettitsdgeos: done10:58
tsdgeosmzanetti: ok, so i guess we accept that coarse approach for coverage for the moment? i.e. shall i approve?10:59
mzanettitsdgeos: imho yes. I think its useful and at least we would need it merged to prove its usefulness/failures11:00
mzanettiSaviq: your opinion? ^11:00
=== MacSlow is now known as MacSlow|lunch
sil2100Is there anyone here using precise, Unity-2D and 3 monitors at once that could verify a bug is fixed in -proposed?11:06
ubot5Launchpad bug 930147 in unity-2d "all panels have same window focus on multiple monitors unity2d" [Low,Fix committed]11:06
tsdgeossil2100: you really really want a small number of people :D11:16
tsdgeossil2100: when i was working on that i used virtualbox to create 3 monitors, works pretty well11:17
tsdgeossil2100: so i guess you could try to setup it yourself11:18
sil2100tsdgeos: oh ;) I actually tried to do a real hardware configuration for verifying that bug yesterday!11:18
tsdgeosi could do it again here but given i coded the fix that'd be cheating :D11:18
sil2100tsdgeos: since my old precise laptop has both DVI and SVGA (the round one) output11:18
tsdgeosdid you suceed in actually getting the 3 outputs?11:19
sil2100tsdgeos: but sadly 2 xservers was the max I could get, I could only mix twin-view with separate x-servers and such11:19
om26erpopey, Hi! whats the procedure to show the autopilot test results. shall the information be added to the bug report or is it fine to add that information to the merge proposal11:19
om26eror will it just work off the record over IRC with didrocks  ?11:19
tsdgeosi have 2 external outputs here but i think i can just enable one of them at a time11:19
sil2100tsdgeos: I'll try setting it up on VB here, or ask popey to try that once he appears11:20
sil2100tsdgeos: good to know you can do that on a VM ;p11:20
tsdgeossil2100: virtualbox lets you setup up to 64 monitors11:25
tsdgeoserr screens11:25
tsdgeosnot sure what would happen if you go that far :D11:25
om26ersil2100, ping11:26
=== om26er is now known as om26er]
=== om26er] is now known as om26er
sil2100om26er: pong11:28
om26ersil2100, is there an official procedure for unity/compiz sru ? I have prepared the branch and was asked to produce autopilot results to make sure no regression happened11:28
om26ersil2100, now we have the results that pope_y generated11:29
om26ersil2100, but where should those results go ?11:29
sil2100om26er: that's for precise, right? Usually when we do a precise unity/compiz release, we usually create for each a testing document on which we overview the result11:29
sil2100om26er: let me show you an example11:29
om26ersil2100, for both precise and quantal11:29
sil2100om26er: so, that's a doc for precise11:30
sil2100om26er: we usually do a diff between autopilot results from vanilla and autopilot results with the package installed11:30
om26ersil2100, things used to be much simpler back in the day ;)11:31
om26ersil2100, both with and without the changes applied have the same results for autopilot11:31
sil2100om26er: then, when needed, we either do the whole suite of manual tests or just those that could be 'related' to the issue11:31
om26erwow :O11:32
sil2100om26er: ok, so just create a testing doc like this, note there that the diff in autopilot results is empty and hm11:32
sil2100om26er: yea ;p It's not as easy as it looks like! For raring it's much simpler now ;)11:32
sil2100om26er: what bug-fix are you trying to release? Could you re-send the bug number?11:33
om26ersil2100, bug 99163711:33
ubot5bug 991637 in OEM Priority Project precise "unity launcher vanishes when switching to mirrored displays" [High,In progress] https://launchpad.net/bugs/99163711:33
om26eroem team wanted that fix released11:33
sil2100om26er: ok, so in this case, I think it would be good if you could also do manual tests related to the launcher and note if anything got broken or not11:35
sil2100om26er: i.e. tests from the manual-tests/ directory11:35
sil2100Launcher ones11:35
sil2100And I think everyone should be happy then ;)11:36
om26ersil2100, i have precise. I can test that. Don't have quantal though11:37
om26erbut i suppose thats required as well11:37
sil2100om26er: with this testing document (including the 0 diff for autopilot results and the launcher manual tests), the packaging branches and bug number(s), you can send it to the distro guys then11:37
sil2100om26er: yeah, sadly yes... I know popey has VM's for all releases, so maybe he could help once he's up and running11:37
om26ersil2100, he helped a lot already. ran all the tests on his VM11:38
om26eri will let you know where i get with this.11:38
om26ergiven didrocks is one of the distro guys i think he might be just happy with the autopilot tests as he said on the merge proposal11:39
didrocksom26er: this doesn't replace the manual tests11:39
sil2100om26er: ok! Sorry the process is so complicated, but after all the regressions we caused with SRU's in the past, the process had to get stricter11:39
didrocksom26er: and yeah, see what sil2100 is telling ^ :)11:39
didrockswe can't afford breaking the shell on existing release11:40
sil2100Since autopilot wasn't so good in the past, there's nothing better than the good'ol manual tests ;)11:40
om26erhope they are not too many tests11:40
om26erdidrocks, sure...11:40
nic-doffaySaviq, I just did some research on the clip parameter. So basically it ties into the Geometry and enforces scissoring. Is there a particular reason you recommended it be specifically enabled for the control test in PageHeader?11:41
=== dandrader is now known as dandrader|afk
=== MacSlow|lunch is now known as MacSlow
=== dandrader|afk is now known as dandrader
=== _salem is now known as salem_
didrockssil2100: hey, there are still other tests failing, mind having a look?12:45
didrockssil2100: run 1812:45
seb128some weird stuff happening12:46
seb128firefox got spawned from nowhere12:47
seb128leading to12:47
seb128"AssertionError: ('The following apps were started during the test and not closed: %r', [<BamfApplication 'Firefox Web Browser'>])"12:47
sil2100Really strange things are happening there12:49
sil2100Sometimes the dash doesn't show up on Super, or the application lens too12:49
sil2100And why are the lenses not searching anything for nvidia during the test_search suite?12:50
sil2100Something is badly broken, need to see the whole test result doc12:50
sil2100Ah, sorry, checked wrong build12:51
sil2100But I see the same happened for -ati12:52
seb128Trevinho, hum, seems like a bug of yours maybe?12:52
didrockssil2100: same on intel12:52
dandraderis there a well-known bug about compiz crash when you start Files(nautilus) in raring?12:52
seb128Trevinho, I can confirm locally12:52
seb128dandrader, yes12:52
seb128dandrader, it's fixed in the version we are trying to land12:52
dandraderseb128, do you known the number/url?12:53
didrocksseb128: firefox is spawn with the legal noticed12:53
Trevinhoseb128: let me check12:53
seb128didrocks, the nautilus one seems a real bug, I get it locally12:53
WaltherHmm. Compiz's "grid" plugin fails a bit with its cornertiling; is there going to be better support for quarter-screen splits?12:53
didrocksseb128: yeah, some with the trash changes can be impacted12:53
WaltherIn addition to the current half-screen split, I'd appreciate quarter splits very much at work12:53
Trevinhoseb128: it works here... mhmhm12:53
didrocksthe other seems to be at least firefox being spawn12:53
seb128dandrader, http://bazaar.launchpad.net/~unity-team/unity/trunk/revision/327312:53
seb128didrocks, yes12:53
Trevinhoseb128: os there a video of that?12:54
Trevinhoseb128: ahh12:54
Trevinhoseb128: mh I thought that it was done once without complains... Yes, need to fix AP12:54
seb128Trevinho, run "autopilot run unity.tests.launcher.test_icon_behavior.LauncherIconsTests.test_trash_open_does_not_prevent_nautilus_to_run" on your box12:55
dandraderseb128, thanks!12:55
seb128Trevinho, thanks12:55
didrocksTrevinho: do you mind looking at other failing in case of nautilus-related ones?12:56
Saviqtsdgeos, any reason why no top-approve on https://code.launchpad.net/~mzanetti/unity/phablet-deps-update/+merge/155701 ?12:56
mzanettiSaviq: no particular reason... we pinged you a while ago and as you didn't reply it was left as is12:57
Saviqnic-doffay, so that it doesn't draw outside of its container, is all12:58
Saviqmzanetti, yeah, just going through the back log12:58
Saviqmzanetti, approved12:59
Trevinhodidrocks: are them all related to this?12:59
didrocksTrevinho: probably not, some are due to firefox being spawn13:00
didrocksTrevinho: but would be nice to check if there are more than one related to your change13:00
Saviqmzanetti, tsdgeos, I'm going into a meeting now, might not make it for the standup, you'll manage, I hope :)13:02
mzanettiSaviq: ofc13:03
Saviqtsdgeos, mzanetti, can you take a look at https://jenkins.qa.ubuntu.com/job/unity-phablet-raring-i386-ci/157/console please13:04
sil2100I wonder what caused the legal screen to appear13:04
Saviqtsdgeos, mzanetti, it's happened in a bunch of CI runs now13:04
Saviqnot sure what introduced that13:04
sil2100Maybe the previous test did something13:05
tsdgeosSaviq: maybe the change i approved for cmake changes, but otoh that was approved  by ci and autloanding13:05
tsdgeosspeaking about http://bazaar.launchpad.net/~unity-team/unity/phablet/revision/53813:06
Saviqtsdgeos, yeah13:06
Saviqtsdgeos, here's a related comment https://code.launchpad.net/~michihenning/unity/phablet-unity-api-merge-tests/+merge/157326/comments/34438913:06
Saviqbut it's happened in https://code.launchpad.net/~michihenning/unity/phablet-unity-api-whitespace-test/+merge/157329 too13:06
didrockssil2100: so, you are more used to autopilot tests than I am13:06
didrockssil2100: but what I see is:13:07
didrocksthe legal notice was clicked (see other tests, the ! instead of the text)13:07
didrocksthe dash is maximized13:07
didrockswhich doesn't seem to be the case previously, right?13:07
didrocksso I think what happened is:13:07
didrocks- the dash was maximized for X reasons13:07
didrocks- we clicked on the bottom right of the screen in a test to dismiss the dash13:08
didrocks-> this in turned clicked on the legal notice13:08
didrocksso that root cause we must find is what made the dash to be maximized13:08
sil2100didrocks: that's similar to the thing I'm trying to find in the previous tests - so I think this theory might be the right thing ;)13:08
didrockssil2100: keep us posted13:09
mzanettitsdgeos: are you on that cmake issue or should I take care about it?13:09
tsdgeosmzanetti: if you can take care better13:09
kgunnmzanetti: welcome back!13:10
sil2100didrocks: btw. is the generic job executed differently than the previous unity release test jobs?13:10
mzanettikgunn: hi :)13:10
didrockssil2100: yeah, the job is basically the "autopilot" job, it's used by the oif, indicator, unity stacks with different parameters13:11
didrockssil2100: last run was with the 100scopes ppa13:11
didrockswhich isn't merged with latest trunk content but last unity release in ubuntu13:11
fgintherdidrocks, rev 149 deployed13:13
didrocksthanks fginther, btw, the --pin-ppa was important and it's now fixed :)13:14
tsdgeosdednick: i was wondering why you used 4 different UnityTestCase in https://code.launchpad.net/~nick-dedekind/unity/phablet-test-indicator-row/+merge/15707013:16
fgintherdidrocks, I saw that jibel fixed it, that was on my todo list for today.  For my education, what exactly does that script do?13:16
didrocksfginther: creating a file for telling "this ppa in argument has absolute priority over distro"13:16
didrocks"even if versions are lower than what is in the distro"13:16
didrocksand as we really want to test the ppa content… ;)13:17
sil2100didrocks: uno momento, will just finish lunch13:17
didrockssil2100: sure ;)13:18
fgintherdidrocks, ah thanks13:18
didrockssil2100: we have a big crasher in distro with nautilus, that's why we need to release it today FYI13:18
didrocksfginther: something else13:18
didrocksfginther: if the installer is failing13:18
didrocksthen the rsync part is failing as well13:18
didrockswhich is confusing I guess13:18
didrockscan you add || true to the rsync for collecting files?13:19
fgintherdidrocks, yes13:19
fgintherdidrocks, otherwise, is the generic job working as you expect?13:20
didrocksfginther: thanks! https://jenkins.qa.ubuntu.com/job/ps-generic-autopilot-release-testing/15/label=autopilot-nvidia/console is a good example13:20
didrocksfginther: otherwise, sounds perfect up to now :)13:20
didrocksfginther: we should keep the other jobs for 2 more days I guess13:20
didrocksfginther: and then we can kill them13:20
fgintherdidrocks, I will be sure to archive them, just in case13:20
didrocksfginther: yeah, and having the -generic job in a vcs somewhere?13:21
didrocksfor the scripts and so on13:21
fgintherdidrocks, mhmm jobs in vcs... that's another story...13:22
didrocksfginther: the template13:22
didrocksfginther: as you have templates that we are deploying13:22
didrocksbut yeah, in nutshell, it's really great to be able to only rely on one preseed and one jobs nowadays :)13:22
fgintherdidrocks, of course, that's an easier solution then what I was thinking13:24
didrocksfginther: as long as we have just one (well 3, one per config) hw, it's good. Maybe we'll need another job for the "apps" if they can run in a vm alone13:25
didrocksfginther: but yeah, let's try to minimize and having that parameterized :)13:25
seb128did anyone do changes to the unity panel service recently?13:26
fgintherdidrocks, we already do some app in a vm testing on the ci side. Definitely something to discuss in the future13:26
larsu_seb128: how recently?13:27
seb128larsu_, this week13:27
=== larsu_ is now known as larsu
didrocksfginther: I think this is a topic for next week in fact :)13:27
larsuseb128: phew, not me then :)13:28
didrocksfginther: with touch apps ported by mterry, kenvandine, robru and cyphermox to daily releases ;)13:28
fgintherdidrocks, right!13:28
seb128larsu, ;-)13:28
dandradertsdgeos, jeez... seems ld segfaulted while linking libFakeHudClientQml.so. Have you ever something like that before? https://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/164/console13:29
dednicktsdgeos: just wanted to separate the different test areas. there were alot of tests which were testing very similar things.13:30
tsdgeosdandrader: tried a retrigger?13:30
tsdgeosdednick: oki13:30
CimiSaviq, what makes sense to write tests now?13:45
CimiSaviq, listviewwithpageheader wasn't supposed to be refactored?13:45
SaviqCimi, yes, greyback will be on it13:45
Saviqonce he's done with usability13:46
tsdgeosmzanetti: the keyClick with chars was merged finally into Qt :)13:46
tsdgeostheir tests are ultra unstable, had to run like 3 times to get it merged in :D13:46
mzanettitsdgeos: \o/ will it make it into 5.1?13:46
tsdgeosmzanetti: yep, was merged into the stable branch that is supposed to be what will be 5.113:47
mzanettitsdgeos: awesome, thanks13:47
CimiSaviq, openeffect?13:47
mzanettitsdgeos: we have now 100+ qml tests :)13:47
CimiSaviq, the application ones will be killed after MIR I think13:47
mzanettiall green too13:47
SaviqCimi, there's a MP from paul13:47
SaviqCimi, redone, rather13:48
tsdgeosmzanetti: grand :-)13:49
tsdgeoskgunn: Saviq: so what kind of review where you thinking for "review high-risk components (Carousel, ListViewWithPageHeader, FilterGrid, SortFilterProxyModel)" ?13:53
kgunnCimi: meant to say...welcome back to you too13:53
Cimikgunn, thanks :)13:53
kgunntsdgeos: not sure...that's was Saviq's13:54
Saviqtsdgeos, I had just a close review of them in mind to see where we can improve, what's missing13:54
Saviqtsdgeos, there's definitely tests missing for the SFPM13:54
kgunntsdgeos: didn't gunter take care of Carousel13:54
Saviqtsdgeos, but LVWPH is a separate topic13:54
Saviqkgunn, we had to revert13:54
Saviqtsdgeos, so here's one ^13:54
Saviqtsdgeos, finding out what's the crash13:55
Saviqtsdgeos, and fixing / filing a bug with QT13:55
CimiSaviq, tile.qml?13:55
kgunntsdgeos: LVWPH is on greyback's todo list13:55
SaviqCimi, sure, sounds like a small candidate13:55
CimiSaviq, I can't see others :D13:55
tsdgeoskgunn: Saviq: ok, i'll split it into two at least giving LVWPH to greyback13:56
SaviqCimi, we have a coverage review planned for Monday13:56
kgunntsdgeos: yeah...LVWPH is there already in the Dash bp13:56
SaviqCimi, hope to come up from there with a list of testing-todo13:56
kgunntsdgeos: feel free to modify/split out the SFPM, filtergrid & Carousel13:57
greybacktsdgeos: yep, send it my way. The Usability stuff has finished up this afternoon, so I'm slowly getting back into it13:57
kgunngreyback: https://blueprints.launchpad.net/ubuntu/+spec/client-1303-unity-ui-dash13:57
kgunnits actually in that one ^13:57
greybackkgunn: ok, I'll move my postponed tasks to the month6 milestone and work on them13:58
kgunngreyback: cool...btw, thanks for the extra effort on usability13:58
greybackkgunn: move or copy actually?13:59
kgunngreyback: we're going with move13:59
kgunngreyback: each one has a vice & virtue in the tool13:59
greybackkgunn: yeah was pretty tight deadline :)13:59
greybackkgunn: move it is13:59
kgunngreyback: and there is no canonical convention...which i find strange :)13:59
greybackkgunn: convention....canonical... *confused*14:00
tsdgeosSaviq: any opinion on the TO_GPOINTER thing of https://code.launchpad.net/~michihenning/unity/cpp-warnings/+merge/157010 ?14:01
tsdgeosoh my14:01
tsdgeosme and gerry clashed on blueprint edition :D14:02
tsdgeosyou undid what i did14:02
Saviqtsdgeos, we gotta do what we gotta do14:02
greybackoh you're kidding14:02
tsdgeosyour last diff is14:02
tsdgeos- [aacid] review high-risk components (Carousel, FilterGrid, SortFilterProxyModel): TODO14:02
tsdgeos- [gerboland] review high-risk components (ListViewWithPageHeader): TODO14:02
tsdgeos+ [aacid] review high-risk components (Carousel, ListViewWithPageHeader, FilterGrid, SortFilterProxyModel): TODO14:02
tsdgeoswhich is exactly the reverse of my change14:02
* tsdgeos edits again14:03
greybacktsdgeos: that's appalling the tool lets that happen14:03
tsdgeosit is14:03
tsdgeosSaviq: ok14:03
Saviqgreyback, tsdgeos, yeah, been there, done that ;)14:04
seb128Trevinho, any look getting that unity/nautilus test fixed?14:16
seb128Trevinho, we would like to get unity landing today to fix the segfault on nautilus closing and we need tests to pass for that ;-)14:16
Trevinhoseb128: yes, sure... i've been busy until now to make the indicator branches to land, now they're going... So I've time for it :)14:19
Trevinhoseb128: also can we get a decision about https://bugs.launchpad.net/unity/+bug/1152477 ? doc team gave the +1... It would be nice to have and really it has low impact14:20
ubot5Launchpad bug 1152477 in Unity "[UIFe] Window list in right click context menu should indicate the focused window" [Medium,In progress]14:20
Trevinhoseb128: I've asked on #ubuntu-release, but I got nothing14:20
seb128Trevinho, you got +1 from the documentation team, let me check with the release guys, should be fine14:21
seb128oh, andyrock just asked there14:21
seb128I will make sure he gets a reply by doing direct ping on individuals if needed ;-)14:21
Trevinhoseb128: nice14:24
dandraderSaviq, should be good to go now: https://code.launchpad.net/~dandrader/unity/phablet_dashapp_dead_code/+merge/15715314:27
Saviqdandrader, right14:27
* Saviq needs more threads14:27
Saviqdandrader, did you kick jenkins into trying again?14:28
dandraderSaviq, I still didn't setup my VPN on raring14:28
Saviqdandrader, k, I'll do that14:28
dandraderSaviq, thanks!14:28
tsdgeossomeone approved the thing that builds in a builddir and now run doesn't work14:35
nic-doffayJust merged trunk with my branch and am getting this any ideas? https://pastebin.canonical.com/88536/14:36
ChrisTownsendsil2100: Hi14:37
tsdgeosnic-doffay: an apt-get failure?14:37
nic-doffaythat's right.14:37
nic-doffayHave one of the packages been removed?14:38
tsdgeosnic-doffay: what are you running?14:39
tsdgeosi mean which command?14:39
nic-doffay./build -s14:40
Saviqnic-doffay, remove unity-team/staging ppa14:40
nic-doffayThanks Saviq14:40
nic-doffayIs a remove ok14:40
nic-doffayor a total purge?14:40
SaviqI think it was "decomissioned"14:40
Saviqnic-doffay, you can't purge if there ppa isn't there I'm afraid14:41
sil2100ChrisTownsend: hello!14:41
Saviqnic-doffay, so just drop the .list file from /etc/apt/sources.list.d14:41
Saviqnic-doffay, and pray ;)14:41
sil2100ChrisTownsend: any ideas about the regression potentials?14:41
tsdgeoshttps://code.launchpad.net/~aacid/unity/follow_the_binary/+merge/157386 anyone?14:41
tsdgeosSaviq: nic-doffay: dednick: mzanetti: greyback: ↑↑↑14:42
Saviqtsdgeos, on it14:42
nic-doffayWill have a look now tsdgeos14:42
ChrisTownsendsil2100: I think the regression potential is very low.  Marco is also in agreement with this as he wrote the original code that has been in trunk for a while now.14:42
Trevinhosil2100, ChrisTownsend: yes no regressions so far... One possible regression is launching unity from terminal or killing it before starting it again and could cause undecorated-windows when they were maximized14:43
Trevinhosil2100, ChrisTownsend but it's very remote and only when hacking with it14:43
sil2100ChrisTownsend, Trevinho: ok!14:44
nic-doffaySaviq, out of interest why was Staging killed?14:44
dednicktsdgeos: ? why is it in builddir? shouldnt follow CMAKE_INSTALL_DATADIR?14:44
Saviqnic-doffay, dunno14:44
sil2100ChrisTownsend: about that one additional fix related to webapps - is it fixed properly in raring already?14:44
Saviqnic-doffay, but we got rid of staging PPAs all over14:44
ChrisTownsendsil2100: Yes, it is.  I put it in some time ago.14:45
Saviqnic-doffay, we're landing straight into distro14:45
=== salem_ is now known as _salem
Saviqnic-doffay, and you can grab the debs from CI14:45
sil2100ChrisTownsend: need to re-read the bug description ;)14:45
tsdgeosdednick: it's where the ./build script now puts it, Jussi changed it there and whoever did the review forgot the run script14:45
ChrisTownsendsil2100: Heh, no worries14:45
=== _salem is now known as salem_
dednicktsdgeos: ah. got latest just before that change.14:48
ChrisTownsendsil2100: Do you have any ideas when the next Unity SRUs should land for 12.04 and 12.10?14:49
kgunnnic-doffay: Saviq ...just fyi, Pete Woods will be doing the greeter backend14:49
nic-doffayOk kgunn . I'm assuming we'll hear more about this in the meeting on Monday?14:50
kgunnnic-doffay: i'd think so...just letting you know14:50
Saviqkgunn, k, we'll need to define the shell-facing API, even though it should be relatively simple14:50
kgunnSaviq: ok, maybe we should use a unit test to help define that :)14:52
=== dandrader is now known as dandrader|afk
Saviqkgunn, ;D14:52
=== dandrader|afk is now known as dandrader|lunch
Saviqanyone else in #gnome@gimpnet? ;)15:01
sil2100ChrisTownsend: not yet, but we'll try to push them out in the nearest time, as soon as possible15:02
sil2100ChrisTownsend: I'll get back to you once we have it planned out15:02
ChrisTownsendsil2100: Yes, please let me know.  Thanks!15:02
sil2100ChrisTownsend: I noticed that jenkins had some problems with https://code.launchpad.net/~townsend/unity/fix_1070715-6.0/+merge/155479 <- could you check the last jenkins error message?15:18
sil2100Since it seems it's failing somewhere around test_switcher_model.cpp15:18
ChrisTownsendsil2100: Yeah, I fixed that and pushed the change to the MP branch.15:19
ChrisTownsendsil2100: The MP just needs re-approved.15:19
nic-doffayLooks like I did a bad merge somewhere along the line, getting this compilation issue: https://pastebin.canonical.com/88548/15:21
sil2100ChrisTownsend: thanks! Re-approving15:21
ChrisTownsendsil2100: Thanks!15:21
Trevinhoseb128: https://code.launchpad.net/~3v1n0/unity/autopilot-nautilus-unregister/+merge/157409 (and maybe sil2100)?15:25
seb128Trevinho, thanks15:28
tsdgeostedg: see nic-doffay's log ↑↑↑15:31
nic-doffayI think I've found it.15:31
nic-doffayJust waiting for the compile.15:31
Saviqtsdgeos, just went through the FIXMEs, grand work15:39
kgunndednick: btw, which fixme did you happen to nail ?15:40
kgunnsuppose i could look at mp's...15:41
kgunnnvmd...got it15:42
dednickkgunn: ok. was just about to paste :)15:42
seb128sil2100, mterry: any opinion on https://code.launchpad.net/~3v1n0/unity/autopilot-nautilus-unregister/+merge/15740915:46
seb128Trevinho, why can't you use the register_known_application()?15:46
mterryseb128, looking15:46
seb128mterry, it's to fix
Trevinhoseb128: since we need to unregister it at the end of the test, I'd prerfer not to duplicate the efforts and adding an utility function15:47
Trevinhothat does registration and unregistration15:47
mterryseb128, seems reasonable15:48
mterrya little special casy for 2 uses15:48
seb128I don't have a strong opinion, it seems a bit weird to special case nautilus15:48
mterrybut may be useful more often in future15:48
mterryseb128, you think maybe have the util function take a parameter?15:49
seb128mterry, if that applies to other apps, yes15:49
seb128Trevinho, what is special about nautilus?15:49
mterryTrevinho, do you ever use other apps?15:49
Trevinhomterry, seb128: I've to write other tests for nautilus, and that will happen...15:49
seb128is that likely to be useful in other cases?15:49
Trevinhoseb128: nautilus is the file-manager, is not just an app :)15:49
seb128ok, fair enough15:50
Trevinhoseb128: also it's better not to rewrite the same strings twice or more...15:50
seb128Trevinho, mterry: that's good enough for me, I'm flagging it approved, thanks ;-)15:50
bschaefer:(, sorry, when I had made that fix earlier all seemed well!15:50
Trevinhonice ;)15:50
didrocksbschaefer: you meant *those* fixes :-)15:50
didrockshey bschaefer!15:50
seb128bschaefer, hey, which one, the dash closing one or the test one? ;-)15:50
bschaeferdidrocks, well it fixed 1 test, and made 3 more :), but yeaah15:51
seb128bschaefer, we had to revert 2 commits of yours today15:51
bschaefergeez what?15:51
didrocksbschaefer: and made 200+ failures :p15:51
* bschaefer goes into the corner15:51
seb128bschaefer, http://bazaar.launchpad.net/~unity-team/unity/trunk/revision/3277 as well15:51
didrocksbschaefer: more seriously, when you add tests and modify the behavior, please rerun at least the autopilot area you touched ;)15:52
bschaeferseb128, dang...i was fixing up a different branch, there. Thanks for getting on it quickly though!15:52
Trevinhodidrocks: that's something very invasive, you know, right? :)15:53
bschaeferdidrocks, yeah, i try to but sometimes I don't have an hour of downtime :(15:53
Trevinhoat least, without having another machine just for AP15:53
didrocksTrevinho: guest session :)15:53
didrocksbschaefer: yeah, but the consequence is that we lost several hours today15:53
seb128bschaefer, yw, sorry about the reverts, but we are trying to land an unity update to fix the "segfaults when closing nautilus" issue that is in raring atm, so we tried to get tests to turn green before european eod15:53
bschaeferdidrocks, very true, shortcuts are never good, sorry!15:54
didrocksbschaefer: so no blame, just being a little bit more careful in the future :)15:54
bschaeferyeah :)15:54
didrocksbschaefer: so, the upload will close your bugs though15:54
didrocksbschaefer: we'll need to reopen them15:54
bschaeferseb128, no worries! The seg fault is waay more important15:54
didrocksto not loose tracks15:54
* bschaefer goes to reopen bugs15:54
didrocksbschaefer: it's not uploaded yet!15:54
didrocksbschaefer: the tests are still running after the second revert ;)15:54
bschaeferdidrocks, o well, ill keep an eye on when it goes through then :)15:55
seb128andyrock, Trevinho: you got your UIFe acked15:55
didrocksbschaefer: ok, let's both keep an eye on it in case we missed it :)15:55
andyrockseb128, thanks :)15:55
bschaeferdidrocks, sounds good :)15:55
Trevinhoseb128: yes, thanks I was just reading it15:57
Trevinhoseb128: it wasn't "mine", a community guy did it, but I do care about contributions! :)15:57
nic-doffaytsdgeos, no win on that compile issue btw16:05
nic-doffayMy cmake diff is minor too: https://pastebin.canonical.com/88553/16:06
tsdgeosnic-doffay: you have hud twice in there?16:12
nic-doffaytsdgeos, doh!16:12
nic-doffayDo I?16:12
nic-doffayJust noticed it!16:12
nic-doffayThat's weird though, I removed it and tried compiling again to no avail (the most recent attempt)16:13
nic-doffayLet me double check again...16:13
sil2100bschaefer: hi!16:21
sil2100You saw my revert, right?16:21
bschaefersil2100, yup! Sorry about all the problems!16:21
sil2100bschaefer: no problem ;) Just hope you don't mind we so quickly reverted it, but it seemed as the fastest way ;)16:29
sil2100bschaefer: good luck on finding the root cause!16:30
sil2100Have a nice weekend guys!16:30
bschaefersil2100, o no that was the best way atm, cause if what I did caused ~200 problems...yeeah16:30
=== francisco is now known as Guest49443
=== dandrader|lunch is now known as dandrader
mzanettiSaviq: u around?16:46
Saviqmzanetti, yeah16:55
greybacknice weekend folks!16:55
mzanettigreyback: have fun!16:55
greybackmzanetti: you too16:55
mzanettiSaviq: some good and some bad news for you16:55
Saviqgreyback, cheers16:56
Saviqmzanetti, just for me?16:56
mzanettiSaviq: good ones first: http://s-jenkins:8080/job/unity-phablet-qmluitests/16:56
mzanettiwe have now stats included for C++ code16:56
mzanettiSaviq: the bad news is that "make sometests" still stops as soon as the first test fails16:56
Saviqmzanetti, hmm because it's a target, and if anything for a target fails the target fails...16:58
mzanettigoogling didn't give a quick solution for this16:58
mzanettimaybe our cmake master renato has a clue16:58
Saviqmzanetti, yeah, it'd be best if we could have multiple test targets, right?17:00
mzanettiSaviq: hmm... each test a single target and then call "make alltests" ?17:00
Saviqmzanetti, well, that would mean alltests is a target...17:00
Saviqmzanetti, so still fail == stop17:00
Saviqmzanetti, but with add_test() it's not like that17:01
Saviqmzanetti, the quickest I can think of is having a -DCMAKE_WHATEVER_VAR17:01
Saviqmzanetti, and add_test() based on that var17:02
Saviqmzanetti, but yeah, let's talk with some CMake gurus next week17:02
kgunnmzanetti: is what you guys are talking about why the test report doesn't look correct?17:02
mzanettikgunn: yeah... as soon as one test fails, execution stops17:03
kgunnhave a good weekend17:03
Saviqkgunn, yeah, the difference between the testing framework in CMake and generic targets17:04
Saviqkgunn, is that if any of the dependencies of a target fails, it stops17:04
Saviqkgunn, which is not the case for tests17:04
kgunnSaviq: totally...should be isolated17:05
Saviqkgunn, but we need different test suites, so we can't just add everything as a test, 'cause it will fail in jenkins17:05
Saviqduring package building17:05
Saviqwe'll sort it out :)17:05
=== tvoss is now known as tvoss|dinner
kgunnSaviq: thanks...it did solve that mystery for me, .e.g why17:06
Saviqkgunn, yeah17:06
kgunnthe test report looked wrong17:06
Saviqkgunn, have a nice weekend, talk to you Mondat17:09
SaviqMonday, even17:09
kgunnyou too!17:10
mzanettiyay! coverage is climbing :)17:24
nic-doffayLooks like that's a day for me. Have a good weekend all.17:24
=== salem_ is now known as _salem
mzanettiSaviq: so I don't feel useless today, here's a MP before I'm off for the weekend: https://code.launchpad.net/~mzanetti/unity/more-stats/+merge/15744117:28
=== _salem is now known as salem_
=== salem_ is now known as _salem
=== _salem is now known as salem_
=== dandrader is now known as dandrader|afk
=== dandrader|afk is now known as dandrader
Saviqbschaefer, hey, you need to make sure to look through pending merges20:22
Saviqbschaefer, https://code.launchpad.net/~michihenning/unity/phablet-unity-api-merge-1/+merge/15674620:22
Saviqbschaefer, that fixes the warnings you posted a branch for (and then some)20:23
bschaeferSaviq, right, that would be a good idea20:23
Saviqactually not that branch...20:23
bschaeferSaviq, let me reject those branchs that are dups20:23
bschaeferSaviq, sometimes those larger branchs are hard to go through quickly, I try to keep mine small...20:24
Saviqbschaefer, yeah, we're kind of in a transition phase20:24
Saviqso we'll have some big diffs coming20:24
Saviqthis one https://code.launchpad.net/~michihenning/unity/fix-c-linkage-1163719/+merge/15675120:25
* bregma thinks big diffs are a negative contribution to overall code quality20:25
bschaeferSaviq, cool, im actually just kind of trying to wrap my head around the new code base, and qml :)20:25
bschaeferSaviq, o nice20:25
Saviqbregma, +120:25
bregmabschaefer, how big was that 100-scopes MP?20:25
bschaeferbregma, ugg...50,000 lines20:25
bschaeferSaviq, yeah, nice! Hes is a bit more clear on whats being assigned as well :)20:26
Saviqbschaefer, that particular MP should be smaller - it should have a prerequisite20:27
Saviqbut I'm not sure now whether it's safe to make the other one a prereq, will pick that up with the author next week20:27
bschaeferSaviq, oo, forgetting to that can increase the diff a bit :)20:27
Saviqbschaefer, it's not even about forgetting, people are still learning the ways :)20:28
bschaeferSaviq, that as well! There always seems to be a bunch to learn :)20:28
bschaeferSaviq, also, that gtest/gmock linked was much simpler! I might go changed unity...20:29
Saviqbschaefer, about that20:29
* bschaefer is also unsure what the goal was with gtest/gmock with the phablet20:29
Saviqbschaefer, couldn't you just use ${CMAKE_CURRENT_BINARY_DIR}/gtest to build it in wherever we actually build the code in?20:29
Saviqbschaefer, right now there's barely any c++ code in lp:unity/phablet20:30
Saviqbschaefer, but that's going to change20:30
bschaeferSaviq, right, im also pretty new to cmake as well :)20:30
bschaeferSaviq, I saw some changes land that build things in builddir now which is nicer then what I had20:30
Saviqbschaefer, we're going to keep all the API implementations in lp:unity-to-be20:31
Saviq(not literally)20:31
bschaefer:), the libunity stuff?20:31
Saviqyeah, the new libunity20:31
* bschaefer has a lot to learn about the current stack20:31
Saviqto avoid breakage / incompatibility / desynchronization20:32
bschaeferyeah, sounds good. That might be a better place for the gtest stuff as well20:32
Saviqwhich we've had too many  in the past20:32
bschaeferis that what you were talking about with the new c++ stuff landing? Or different c++ stuff?20:32
Saviqbschaefer, about gtest... so yeah, actually we have an20:33
Saviqbschaefer, yeah the shell will become just a part of the project20:33
Saviqbschaefer, those big dumps are gearing towards that happening20:33
bschaeferSaviq, well sweet, i can reject my gtest branch as well :), michi is getting  a lot of good stuff ready :)20:34
* Saviq tries if adding the prerequisite will work20:34
bschaeferSaviq, cool, lots of things happening :), I just started looking at the code yesterday soo im still picking up where things are...20:34
bschaeferSaviq, is there a current bug tracker for the phablet? Cause unity/phablet had like 4 bugs in it20:35
Saviqbschaefer, the public tracker is under lp:touch-preview-images20:44
Saviqfor now20:44
bschaeferSaviq, cool, and looking through the other merges, my only MP left that I don't think anyone has done is this:20:45
Saviqbschaefer, approved, thanks20:49
bschaeferSaviq, cool, thanks!20:49
bschaeferc ya20:49
=== salem_ is now known as _salem
=== bschaefer_ is now known as bschaefer

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!