* mariusko has brokes juju-gui again...11:31
frankbanmariusko: you deployed using lp:juju-gui as juju-gui-source?11:33
benjiis anyone else having problems logging onto the kanban board?12:02
rick_h_benji: I had to re-login over the weekend but in it ok today12:03
benjiit is acting flaky12:03
=== gary_poster|away is now known as gary_poster
gary_posterhi everybody!12:06
gary_posteryeah, can't log in to kanban12:07
frankbanbac: re bug 1164593: missed to specify that the described behavior happens when the GUI is connected to juju-core. I just updated the bug accordingly, sorry about that.12:08
_mup_Bug #1164593: GUI hangs on the service detail view <juju-gui:Triaged by bac> < https://launchpad.net/bugs/1164593 >12:08
bacfrankban: ok, thanks12:09
gary_posterbenji it worked for me if I went to http leankit.  That redirected to https, and then it worked.  Pretty annoying though12:10
gary_posterdidn't really work :-(12:10
gary_postermm, retrying worked12:11
benjiI finally managed to get in but I'm afraid to click on anything because it might break.  It feels like they have one or more app servers in a LB pool that is acting up12:11
gary_posterah ok12:12
* frankban lunches12:14
gary_posterhey benji. what's the story with the "expose service config information via Go API" card, do you know?  kanban still flaky so can't see description, if there is one12:18
benjigary_poster: I'm wondering if it was found to be a duplicate.12:19
gary_posteroh cool benji.  so we have service config and constraints in go api deltas, to your knowledge?12:19
benjigary_poster: oh, I was (quite) sick Friday, which you may not know because I forgot to put it in the system which I am doing right now.12:20
gary_posterkanban board behavior not cool12:20
gary_posteroh! ok, benji, glad you are better12:20
benjiI'm not certain, but I am 90% sure someone (can't remember who) said that it was on Friday.12:20
benji[oh dude, was so sick; barely back to vertical now]12:21
gary_posterugh :-/12:21
benjiI suggest we kill the card and let it raise itself as a zombie if need-be12:21
gary_posterbenji, "it was on Friday" -> what was on Friday?12:22
gary_posterkill card...mm...this will remind me to resolve the question, which I need to do :-)12:23
benjisaid "it was [a duplicate] on Friday"12:23
gary_posteroh ok12:23
benjiEnglish, you so crazy.12:23
gary_posterok thanks.  will leave card for now until I get confirmation that service config is done12:23
=== teknico_ is now known as teknico
mariuskofrankban: nope, stable13:12
mariuskoI also struggle with with a CSS-less site with "Loading the Juju GUI"13:12
mariuskoIf I don't make the URL different by adding ?something13:13
mariuskoI wonder if the caching settings are wrong13:13
teknicogary_poster, hi, yes, config get and set are in, I don't know what else that card could refer to13:13
gary_posterteknico, awesome!  the deltas, though?13:13
benjido we need deltas for config?  Are we sure we use them in the app?13:14
teknicogary_poster, don't know about them13:15
gary_posterrogpeppe, hi! it looks like we are making good progress.  I'm not clear yet on whether we have the config information in the go deltas yet, but AFAICT after quick zooming this morning, that is either done, or the last go-side change we need.  Yay!  On a related note for the future, I have a suspicion that the juju core API for annotations may introduce the possibility of unpleasant race conditions across annotation 13:16
gary_postersources, and this may be a practical concern when we bring Landscape annotations into the fold, for instance.  Specifically, if Landscape annotates an object with Landscape annotations, and we annotate an object with x,y locations, in the Python API (merged updates) there is no chance of a race condition between the two.  In the Go API, IIUC, we must get annotations, change them, and set them, which introduces a rac13:16
gary_postere condition across concerns13:16
gary_postersorry, had to finish that up :-P13:16
gary_posterbenji, good question.13:17
gary_posterWe certainly expect them to be on the model13:17
gary_posterand config can change dynamically13:18
gary_posteras opposed to constraints13:18
gary_posterso it would idealy be in the deltas13:18
gary_postermariusko, what charm13:18
gary_postermariusko, the ~juju-gui charm will become the official charm once jujucharms.com is flushed13:19
gary_posterWe test with that before release, and we run CI tests with it and trunk several times a day13:19
gary_postermariusko, if the problem is when deploying with that charm, we'll jump on it asap.  we have seen neither of the problems you report ourselves though, fwiw.13:21
gary_poster(which is definitely not to imply they do not exist()13:21
frankbanmariusko: you can try removing the appcache from chrome://appcache-internals/ 13:22
gary_postergood call on the CSS frankban 13:22
frankbangary_poster: FWIW, I bootstrapped a juju-core env ~5 hours ago, and I don't see the settings in the delta stream, nor the status13:23
gary_posterfrankban, I wrote a novel to rogpeppe above which included a concern about the Go annotation API.  Does that concern make sense to you?13:23
gary_posterfrankban, ah :-(13:23
gary_posterthe status we definitely need now13:24
gary_posterthe config we will need but we *might* be able to do it after 13.0413:24
frankbangary_poster: do we also need the constraints? I remember you said we get them from the charm maybe?13:24
rogpeppegary_poster: hiya13:26
rogpeppegary_poster: i'm not sure i see why you need to get-change-set annotations13:27
gary_posterfrankban, no, we get is_subordinate form the charm.  constraints and config have value in the delta stream only when we are viewing them explicitly, and possibly when we are editing them.  We would want to be able to see when the config changed as an alert, I suspect.  also, a nice to have would be to see changes while you are editing them.  We could push both of those off to post 13.04 if what I describe are the on13:28
gary_posterly use cases, and if we already explicitly get/update the constraints and config when we look at them now13:28
rogpeppegary_poster: i think we can set x and y without affecting landscape annotations13:28
gary_posterrogpeppe, ah ok, I wanted to verify my memory of the API before I bothered you, but I was losing state in my brain so I had to dump :-) .  DO I remember correctly that the Go API is to set all annotations?13:28
gary_posterah no!13:28
gary_posteryou can set an annotation to null13:29
gary_posterand that removes it13:29
rogpeppegary_poster: empty string, but yes13:29
gary_posterrogpeppe, ok cool, sorry for the noise on that then.  excellent.  So in terms of status of the deltas:13:29
gary_poster- we need status in there13:29
gary_poster- config is nice to have13:30
gary_poster- constraints is also nice to have, and lower priority13:30
rogpeppegary_poster: i'm getting there; i've done quite a bit of refactoring (the allWatcher is now in its own package) and next up should be the statuses.13:30
gary_posterrogpeppe, great!  I certanly saw a lot of work from you fly by13:31
gary_posterrogpeppe, AIUI this Thursday is the "we really should have everything in Raring now" and next Thursday is "um, sorry, it is too late, you can't even have bug fixes"13:31
gary_posterrogpeppe, when would be the soonest to hope for statuses in the deltas?  Also, I take it that these changes are entirely on your plate?13:33
rogpeppegary_poster: hopefully by end tomorrow, if implementation goes to plan13:36
gary_posterok cool rogpeppe thanks.  let me/us know if there's something we can usefully put in our plate13:37
frankbangary_poster, rogpeppe: I think this is related: bug 116184813:37
_mup_Bug #1161848: Malformed charm metadata error when a charm is deployed using the API <juju-core:New> <juju-gui:Triaged> < https://launchpad.net/bugs/1161848 >13:37
frankbanmore recently, when ServiceDeploy is called, I started seeing juju-core panics13:38
rogpeppefrankban: interesting; thanks for the report. related to what?13:38
gary_posterthank you, yes frankban.  My understanding is that this is not specific to the API though, right?13:38
gary_posterrogpeppe, related to us being done successfully, I think :-)13:38
rogpeppefrankban: was that against a newly bootstrapped environment?13:39
frankbangary_poster: the API call is what juju-core expects. I am grabbing logs about the panic13:39
frankbanrogpeppe: against an env bootstrapped ~5 hours ago13:39
frankban(this morning)13:39
rogpeppefrankban: with --upload-tools, presumably?13:40
rogpeppefrankban: have you tried doing "juju deploy minecraft" against the same environment?13:40
gary_posterfrankban, I expected that this error would also happen if you tried to deploy minecraft without the GUI, was my question.  13:40
gary_poster(without the API)13:41
rogpeppefrankban: i'm surprised there's a difference between the api deploy and the cmd line deploy, actually13:41
gary_poster(right, that was what I was trying to say)13:43
frankbanrogpeppe, gary_poster: the cmd line deploy works well, here is the error and the subsequent panic when ServiceDeploy is called via the API: http://pastebin.ubuntu.com/5689443/13:44
frankbanrogpeppe: nad yes, --upload-tools was used13:44
rogpeppefrankban: ah!13:44
gary_posterfrankban, so we probably now have two bugs, yeah?  the panic because of the home, and the relation name problem13:45
gary_posterrogpeppe, if you want us to get some people to work on these, and consult on you initially for fixes, that would be great by me.13:46
gary_posterconsult with you initially for fixes13:46
rogpeppegary_poster: that would be great, thanks!13:46
gary_posterI noticed my preposition use today was a bit off generally :-P13:47
rogpeppegary_poster: i feel a little overloaded right now13:47
gary_posterrogpeppe, completely understood.  I'll find some people and send them your way for a pre-imp discussion, and then hopefully we can get out of your hair13:47
gary_postermm... frankban and/or teknico, are either of you up for those?13:48
frankbangary_poster: yes, this seems a different bug. but I am confused about "relation name". you mean the charm not found error?13:49
gary_posterfrankban, your bug (https://bugs.launchpad.net/juju-gui/+bug/1161848) doesn't report a missing charm as I read it ('malformed charm metadata found in state: charm "mysql" has mismatched    relation name ""; expected "shared-db"')13:50
_mup_Bug #1161848: Malformed charm metadata error when a charm is deployed using the API <juju-core:New> <juju-gui:Triaged> < https://launchpad.net/bugs/1161848 >13:50
gary_posterdo I misunderstand13:50
rogpeppefrankban: check out recent remarks on #juju-dev13:51
frankbangary_poster: yes. so I think we have 3 different issues. 1) CharmInfo returns "charm not found", 2) ServiceDeploy generates a panic and 3) the old bug, that could be still valid13:51
hatchgooood morning13:51
gary_postermorning hatch13:52
gary_posterfrankban, ack.  1 and 2 seem related to me, but that's a guess.13:53
rogpeppegary_poster: this branch factors out the allwatcher: https://codereview.appspot.com/8458044/13:53
gary_postercool rogpeppe!  So if we want to refactor the allwatcher we will still have that base for what we want.13:53
frankbangary_poster: seeing the discussion in #juju-dev, I have the same impression13:53
teknicogary_poster, yep13:54
rogpeppegary_poster: exactly. the new package gives the basis for any combined watcher you might want to concoct13:54
rick_h_jcsackett: hatch or others can I beg for some reviews today please? https://codereview.appspot.com/8513043 for huw and https://codereview.appspot.com/8488043/ for myself13:54
rogpeppegary_poster: it's the change i was putting off, but it became necessary.13:54
hatchrick_h_: sure13:54
rick_h_hatch: ty kindly sir13:55
gary_posterah ok rogpeppe13:55
gary_posterfrankban, also we can't tackle 3 until 2 is handled, rt?13:55
frankbangary_poster: yes13:55
gary_posteror at least it will be more difficult13:55
gary_postercool.  you working on 1 and/or 2 then frankban?  If so, suggest with Roger soon, and planned handoff with someone tbd (maybe me and I would rope in someone with more go experience?)if it takes you past your EoD13:57
gary_postersuggesting talking with Roger soon, I meant13:57
frankbangary_poster: sounds good13:57
gary_postercool thank you13:57
rick_h_luca____: howdy, heads up. I promised you and jovan2 an link to view for the config tab on the browser: http://uistage.jujucharms.com:8080/bws/fullscreen/precise/apache2-2 and click on the configuration tab below14:08
rick_h_hatch: did they update getData to look for the data- attribute? I could have sworn that was the big confusion with that when they added it. It didn't work at all with the attributes in the dom14:11
hatchrick_h_: yeah a long long time ago14:12
hatchit now works for both14:12
hatchI forgot about that confusion :)14:12
rick_h_hatch: hmm, ok. I guess I got in my head that it's never what I expect since so ditched its use.14:12
rick_h_hatch: ok cool then. missed that change/update along the way I guess14:12
rick_h_hatch: thanks for the look over14:12
hatchyeah that's fine - It doesn't really matter which one you use I was just pointing it out14:13
hatchno problem14:13
rick_h_hatch: yea, good to know :) I'd still not know they changed it.14:13
hatchdoes Huw's branch need QA?14:14
rick_h_hatch: you can, but it's pretty simple just add a column/not. Not much to it14:14
rick_h_no real crazy style/etc stuff to check works correctly. 14:15
frankbanrogpeppe: please ping me when you are available for a pre-imp call re bug 116622414:15
_mup_Bug #1166224: Panic when calling ServiceDeploy via the juju-core API <juju-core:Triaged> <juju-gui:Triaged> < https://launchpad.net/bugs/1166224 >14:15
gary_posterteknico, thanks for readthedocs improvement :-)14:15
luca____rick_h_: cheers Rick, I'll check it out14:15
rogpeppefrankban: will do. in a call right now14:15
frankbanrogpeppe: thanks14:16
rick_h_luca____: yea, so feel free then to mark that up and we can update the designs if needed/etc. 14:16
gary_posterMakyo, benji, bac, teknico you all have readthedocs privs: thank you for getting me your user names14:16
teknicogary_poster, mp, I also put a requirement for Sphinx in there14:16
bacgary_poster: yay14:16
teknicogary_poster, yeah, I noticed ;-)14:16
frankbangary_poster: my rtd account is, surprisingly, frankban14:18
gary_posterfrankban, :-P you are added14:18
frankban:-) thanks14:18
jovan2rick_h_: I like the layout of the configuration options. I would put the default value before the explanatory text though.14:24
rick_h_jovan2: ok. can move that without an issue.14:24
rick_h_I'll drive-by that in the branch I've got going right now14:25
jovan2rick_h_ cheers14:25
gary_posterHey bac, thank you very much for reviewing/helping BjornT.  That looks like it was more work for you than I had expected, and I'm sorry about that, but I'm glad he is unblocked14:26
hatchrick_h_: ugh I hate how less's mixins look like class names14:26
rick_h_hatch: +1 14:27
bacgary_poster: it was no problem.  easier to review his changes than to do the work!14:27
gary_poster:-) cool14:27
bacgary_poster: he made one change that will help us in that it will avoid looking at the archives14:27
rick_h_hatch: so when you convert it all over to sass let me know :) 14:27
gary_posterbac, oh excellent14:27
hatchI wish sass wasn't written in ruby14:27
rogpeppefrankban: ready when you are14:27
rick_h_hatch: I'll do the review14:27
hatchrick_h_: haha it probably woudln't be THAT much work14:28
rick_h_hatch: https://github.com/Kronuz/pyScss is what I use in my projects. python ftw14:28
hatchmost of the stuff is identical14:28
hatchlol of course you do :P14:28
rick_h_hatch: well I wasn't going to isntall ruby just for css compiling :P14:28
hatchlol good point14:28
hatchthis machine has so much garbage installed and modified it's a miracle it's even still running14:29
jcsackettrick_h_: got a second to chat?14:29
frankbanrogpeppe: cool, https://plus.google.com/hangouts/_/02bb45411739e441fe107c9f66e2a8cc36ba4ba7?authuser=0&hl=en#14:30
rick_h_jcsackett: yep, sure thing14:33
rick_h_hatch: I'm goign to kick you14:33
mariuskogary_poster: testing it now, but it is broken: "nodejs : Conflicts: npm"14:33
mariuskoIt must stop installing npm, as it is included in nodejs package14:33
gary_postermariusko, I saw that when it landed but it worked for me.  hatch, ^^^.  mariusko I am unhappy that you are encountering issues that we don't see, and apologize. :-(  Send me an email @ gary.poster@canonical.com with the commands you are running, even if they are obvious, and I will run them myself, fix what I can and we can go from there.14:36
gary_posterwhere "going from there" hopefully includes figuring out what we are missing in our QA14:37
mariuskoIt's not anything special, and it is not so easy to reproduce, as it works first, and then fails. It could be too little memory on the machines that causes it to fail14:39
hatchrick_h_: what did I do now?14:45
rick_h_hatch: I specifically moved that from an ATTR into a function because of your hate for 'empty attrs' 14:45
hatchbut it's not empty14:46
rick_h_hatch: I started out with it as an attr and a getter and moved it to a function before -cr for you :)14:46
hatchit would be a flag14:46
rick_h_hatch: no, it's completely based on the class.name 14:46
hatchnew charmBrowser({fullscreen: true});14:46
rick_h_hatch: no, look at what isFullscreen() does. It checks for a match in the class name14:46
hatchmariusko: gary_poster: one of our dependencies doesn't like Node 10 so I had to roll it back to 0.814:47
rick_h_the MainView is extended by SidebarView and FullscreenView to provide the different bits, but they're so common in most places. 14:47
hatchis the charm still trying to install 10?14:47
hatchI think it's going to be fragile - if someone changes the name and then all of a sudden the fullscreen stops working it's going to be very hard to diagnose14:48
hatchdon't you think?14:48
rick_h_hatch: right, but there's a test that it is correct so the test will fail right away14:48
rick_h_hatch: but the render code and the template is shared between fullscreen/sidebar. Only fullscreen template needs to add a column to fill some space. 14:49
hatchyeah I saw that....hmm14:49
rick_h_hatch: so the best way is to create a simple check var the template can key off of to determine if it can use 'wide view' or 'narrow view' in the process14:49
hatchyeah - I suppose it's ok with that test14:49
rick_h_hatch: and if I do it manually with an ATTR then every call site has to be kept in sync vs a class name which is safer imo14:49
Makyogary_poster, ping.14:52
hatchmariusko: can you check which version of node is being installed? it should be 8.2214:53
hatchMakyo: I see you assigned yourself to that odd bug14:55
hatchany ideas about what's going on?14:55
Makyohatch, Not yet, adding a ton of logging, though.14:56
hatchI spent a few minutes on it and I am almost 100% certain it's a D3 'bug'14:56
hatchbug is in quotes because it's probably caused by our code14:56
Makyohatch, yeah, there are a few places where position is set and I'm wondering if something's getting knocked around there.  Digging the debugging console at least.14:58
gary_posterMakyo, sorry, missed you.  on call15:04
Makyogary_poster, np, two quick questions when you get a moment.15:04
hatchfrankban: there were no changes with slider in 3.10 so will have to investigate further but maybe once PR2 comes out15:06
frankbanhatch: sounds good, I don't think is an high priority problem15:07
hatchfrankban: and for the record I approve of your YUI version restriction :)15:10
hatchrick_h_: when you next talk to Huw could you ask him why he is mixing units? re the fix for the button height issue15:16
hatchpt & px15:16
rick_h_hatch: k, will do. 15:16
mariuskohatch: nope, it is 0.10.3-1chl1~precise115:18
bacfrankban: i understand the problem with bug 1164593.  when i implemented the go API for ServiceGet i only returned the data required by 'juju get <svc>'.  but the python API included more information.  so now i will add the constraints and other  required bits to the Go api.15:19
_mup_Bug #1164593: GUI hangs on the service detail view when connected to juju-core <juju-gui:In Progress by bac> < https://launchpad.net/bugs/1164593 >15:19
hatchmariusko: thanks for checking - hmm that's very odd because the most recent code in lp uses the legacy repo which I was sure topped out at 8.22,15:19
frankbanbac: great15:19
mariuskohatch: which ppa? The charm itself is an old one for precise15:20
hatchmariusko: here is the line in question http://bazaar.launchpad.net/~juju-gui/charms/precise/juju-gui/trunk/view/head:/hooks/utils.py#L8115:20
hatchohh you're not running from trunk15:20
hatchsorry I'm still new to this game so I don't know all of the questions to ask yet :D15:21
hatchthere is the PPA - so it looks like in trunk it should still be deploying 8.2215:22
mariuskobah, now it won't install and then not upgrade or retry15:23
hatchwould you like me to give it a go using latest ?15:33
hatchI can spin up some instances but it might take a while :)15:33
hatchit's entirely possible that the dependency has been updated to work with 10 now and this is another issue entirely15:37
hatchbcsaller: did you need another review on your annotations branch?15:39
bcsallerhatch: making the changes gary wants now so I can push another soon15:39
hatchalright no problem15:39
mariuskohatch: hmm, the line is correct: BUILD_REPOSITORIES = ('ppa:chris-lea/node.js-legacy',)15:48
hatchmariusko: alright I'll spin up some instances to debug this15:51
gary_posterMakyo, questions now or in/after daily call?15:54
Makyogary_poster, in would be fine.15:55
hatchmariusko: ok instances are being spun up so I'll get back to you once I have something15:55
hatchgary_poster: I can't log into the kanban so can you pm me that link?15:59
gary_posterjujugui call now15:59
gary_posterCalledProcessError: Command '['ssh', 'ubuntu@', 'sudo', 'service', 'juju-api-improv', 'restart']' returned non-zero exit status 25516:00
mariuskohatch: i think there might be some machine reuse going on here. currentry trying a new node16:07
mariusko / instance16:07
hatchmariusko: I'm actually getting some 503's on a bunch of other PPA's16:08
* mariusko got it working now. Let's see how long it lasts.16:16
bacMakyo, bcsaller: i just noticed the rendering of the service blocks in FF on OS X is whack.  the inner circle is at the bottom right corner and the indicator ring is outside the box altogether.16:29
Makyobac, anything in the console?16:29
bcsallerbac: Is that true after the 1st delta? Its mostly thowing an error before the draw is done16:30
bcsallerdeath before translation!16:30
bac[12:30:36.523] Firefox can't establish a connection to the server at ws://uistage.jujucharms.com:8081/ws. @ http://uistage.jujucharms.com:8080/juju-ui/assets/all-yui.js:2816:30
bcsallerI think there would be an actual exception in our code for that to happen16:31
benjiIs the unit view expected to work with the go backend?  I just get a loading message.  There are no (related) errors in the JS console.16:41
benjiI can't help but think I'm doing something wrong.  Every time I try to do anything with the gui and go it is a slow, painful process.16:41
benjidoes deploying work with the go backend?17:00
=== deryck is now known as deryck[afk]
rogpeppegary_poster: next CL in the pipe: https://codereview.appspot.com/848704417:29
rogpeppegary_poster: next up: statuses!17:29
teknicobenji, the answer is in the mailing list ;-)17:29
gary_posteryay! :-)17:29
teknicobenji, specifically in the "Handing off bug #1166224" message17:31
_mup_Bug #1166224: Panic when calling ServiceDeploy via the juju-core API <juju-core:Triaged> <juju-gui:In Progress> < https://launchpad.net/bugs/1166224 >17:31
rogpeppegary_poster: ah, darn, i forgot to write a load of tests17:32
MakyoI found a work-around for #1159870 but it involves enforcing two-finger dragging.  It works, but isn't very discoverable.  Perhaps something we can tool-tip?17:41
_mup_Bug #1159870: Viewing service from popup on mobile causes service svg element to move  <juju-gui:Triaged by makyo> < https://launchpad.net/bugs/1159870 >17:41
hatchMakyo: wasn't two finger dragging the default anyways?17:52
Makyohatch, well, it was the one that worked properly :)17:53
hatchhaha ok ok17:54
hatchso when it's two finger drag it doesn't jump when you view services?17:54
Makyohatch, correct.  It still attempts to fire drag events, but if we go with two-finger drag, we can set a flag to break out of drag if there is only one touch.17:55
hatchoh awesome17:55
hatchnice find!17:55
hatchthat was driving me nuts17:55
MakyoMeeee too.17:55
MakyoEspecially because, previously, panning wasn't working.17:56
MakyoIs now, though.17:56
benji(back from lunch now) teknico: thanks for the info18:11
teknicobenji, yw18:14
hatchrick_h_: any idea why the valuechange woudln't trigger in the browser search tests?18:18
hatch'browser search widget' to be specific18:18
hatchthe one with the 200ms timeout18:18
rick_h_hatch: looking. It's not triggered? 18:20
hatchsometimes it even hits the 20s mocha timeout (if we remove the timeout in the test)18:20
rick_h_gary_poster: oh hmm, it's based on a _poll time in the YUI code18:20
rick_h_so maybe there's an issue with the test/poll interval crossing there?18:20
rick_h_value-change is used to detect things like pasting in which doen't fire events like keyup/etc to watch for changes. 18:21
rick_h_to do that it runs a 50ms poll by default looking for changes to the value18:21
hatchyeah I've never seen it fail in the real world18:23
rick_h_hatch: yea, I've not seen it locally at all. Second, I'm debugging a failing test for some new code atm and I'll go back and look at that test and see if there's a shortcut/way to tinker with it18:24
hatchthanks - I tried wrapping it in a timeout to set the value but no luck18:25
hatchmaybe if we set it repeatedly18:25
rick_h_hatch: so I'm wondering if we can change the _poll interval on the module to be less/quicker18:25
rick_h_actually that sounds familiar18:26
rick_h_hatch: yea, so looking at that test I added a timeout to help make sure the poll event had a chance to fire18:32
rick_h_hatch: and I'd bet that on slower hardware/etc it's not getting to I guess...18:32
hatchwell sure but one would think that it should fire in 200ms18:33
rick_h_hatch: so maybe we can change this in the test http://yuilibrary.com/yui/docs/api/files/event-valuechange_js_event-valuechange.js.html#l4418:34
hatchthat's a long time really18:34
hatchahh change it to poll faster?18:34
rick_h_down to single digit and it'll just poll like mad for the length of the test18:34
rick_h_but it's a single one just to make sure the event it wired correctly18:34
rick_h_not even the whole suite of tests for that module need it, just the one test18:34
rick_h_hatch: yea, just off the top of my head 18:34
rick_h_hatch: but yea, with a 50ms poll interval I had thought 4x as long would be good for this18:35
rick_h_so maybe it's not the case, but only thing I can think of that would case it to fail intermittantly18:36
BradCrittendenguihelp: when using firefox (testing against juju-core) if i'm on the service page and click on constraints attempting to go to http://localhost:8888/:gui:/service/mysql/constraints/ i then get trapped by the unsupported browser warning and then am shown the canvas.  is this a new issue?18:38
=== BradCrittenden is now known as bac
bacdumb question.  no one has been able to do what i just described until the fix i just made...at least not with go juju18:41
Makyobac, can't get that to happen, but this is on improv18:47
hatchrick_h_: what tells the build script to include the widget files?18:47
benjibac: no idea; I have a similar problem just double-clicking on a service18:48
bacbenji: that's the bug i'm working on18:48
bacbenji: you get a hang or browser trap?18:48
benjibac: forever "18:48
rick_h_hatch: include the JS of them? or what18:48
rick_h_hatch: they're added to the modules-debug right?18:49
bacbenji: yeah, that'll be fixed soon18:49
hatchrick_h_: basically charm-search.js is not being loaded in prod tests18:49
rick_h_hatch: oh hmm. am I missing a YUI.use in that file?18:49
* rick_h_ looks18:49
rick_h_I mean it works sometimes right? so wtf?18:50
hatchthis is failing all the time18:50
hatchcharm-search.js is not included in the all-yui.js18:50
rick_h_hatch: second, I've borked things up locally here atm18:55
hatchnp take your time, we are taking a lunch break18:58
hatchlemme know when you're able to take a peek and I'll get you the branch and details18:59
rick_h_hatch: k, is there supposed to be something more to it? 19:00
rick_h_than adding to modules-debug that is19:00
gary_posterhatch, your bug report about PyJujuAPI: same thing!  works in debug, fails in prod, at least for me19:02
gary_posterlunch now ;-)19:02
hatchgary_poster: yep yep19:02
hatchrick_h_: setting describe.only() on browser search widget causes the tests to fail on sh test-server.sh prod true19:03
hatchUncaught TypeError: Cannot read property 'widgets' of undefined19:03
hatchrick_h_: lp:~gary/juju-gui/testclean is the branch we are hacking on19:04
hatchnow I'm lunching19:04
rick_h_hatch: cool, will thanks19:04
jcsackettrick_h_: so, with the changes to the container, we're left a little unclear on behavior. i'm assuming clicking the little arrow expands and the arrow changes for "less"; does the num in parenthesis do anything? does it show the total, or how many more there are...?19:19
bcsallerhttps://codereview.appspot.com/8315046/ could use another review he says as he heads to lunch19:19
rick_h_jcsackett: we can check with luca and jovan (not in channel atm) but I assumed it just showed the total count of items19:19
rick_h_jcsackett: so it would not change 19:19
jcsackettrick_h_: ok.19:20
rogpeppegary_poster: tests now done...19:39
rogpeppegary_poster: *now* for status :-)19:39
gary_posterrogpeppe, :-) awesome19:40
rogpeppegary_poster: even better, the new tests exposed a significant bug...19:40
gary_posterthat does always feel good19:40
rogpeppegary_poster: in the new code19:40
rick_h_hatch: when you get back let me know. Your branch lp:~gary/juju-gui/testclean works for test-prod for me, however I was working on lp:~rharding/juju-gui/event_tracker and that was throwing a buildCfg error creating the object definition on charm-search and I can't figure out why. 19:46
gary_posterrick_h_, to provoke, you do the following:19:47
gary_poster./test-server.sh prod true19:47
rick_h_gary_poster:  cool thanks looking19:48
jcsackettrick_h_ and hatch: can y'all look at https://codereview.appspot.com/8488045/19:50
jcsackettrick_h_: i didn't update the template for the design we have now in this branch; i did it in a follow up that's on rietveld, but has this one as a dependent.19:50
hatchgary_poster: so any ideas over lunch? :)19:56
rick_h_hatch: so the widgets are loaded as part of app.js, not yui-all.js19:58
rick_h_hatch: and that's never loaded in the test file links that gary_poster gave me19:58
rick_h_hatch: so maybe you can fill me in on the diff between the yui-all and app.js and how that works with tests?19:59
gary_postersorry, missed the first ping19:59
gary_posterrick_h_, you have stumbled upon a mystery wrapped within an enigma...or at least something I've forgotten most of :-P19:59
rick_h_hatch: I can move widgets in modules-debug to their own category like the others loaded into app.js (things like the d3 and prettify are in yui-all.js)20:00
rick_h_but yea, I don't see tests loading app.js, I'm not sure atm how tests do work now that I see this lol20:01
hatchso THAT's why it works when we load everything20:01
hatchhmm I really don't like that20:01
gary_posterwell, but why is app.js loading when we run everything20:01
rick_h_yea, app.js is loaded when we run everything, looking to see 'who/why'20:02
hatchwell because we instantiate it in test_app.js20:02
gary_posterthe file?20:02
gary_posterthsi is in prod20:02
gary_posterso everything should be compressed20:02
rick_h_some other test/file/etc is loading app.js somehow I think20:02
hatchwell but that shouldn't matter20:03
gary_posterfwiw, I verified that adding app.js to index.html makes everything better20:03
rick_h_hatch: so yea, I'm not sure, still working through this20:03
hatchbecause when we include the browser-search-widget module it should pull in everyuthing that it needs20:04
rick_h_I mean if app.js isn't in the tests how to the tests for everything juju.. work?20:04
gary_posteryeah exactly20:04
rick_h_hatch: well, it's not pulling in app.js. That's not a YUI module or the like20:04
rick_h_hatch: there's noting in the YUI system to pull/load that in20:04
rick_h_I mean http://localhost:8084/test/index.html?grep=juju%20unit%20view fails as well20:05
rick_h_because app.js isn't loaded and there's no such thing as Y.juju as far as the test is concerned20:06
hatchwell that should be loaded in the tests that need it20:06
hatchmaybe I'm totally missing what you're saying20:06
gary_posterapp.js is not in modules hatch20:06
rick_h_sec, I've got to get my headset and such20:06
gary_posterI'm there20:06
* Makyo dogs-walk.20:15
=== deryck[afk] is now known as deryck
hatchthanks rick20:17
jcsackettis there any way to make lbox/rietveld play nice with pipes/prereq branches?20:20
rick_h_hatch: you guys still on?20:24
rick_h_hatch: sorry, battery died on me mid-call20:24
rick_h_k, sec20:24
rick_h_jcsackett: -req=lp:.... flag20:24
jcsackettrick_h_: ah, ok.20:25
rick_h_jcsackett: cool thanks for the updates20:36
jcsackettrick_h_: yw.20:36
jcsackettrick_h_: the charm container/sidebar integration is up as well, as is the followup for the container design.20:44
jcsacketthttps://codereview.appspot.com/8529044/ and https://codereview.appspot.com/8529043/20:44
rick_h_jcsackett: looking20:46
rick_h_jcsackett: ok, comments on everything20:49
rick_h_jcsackett: hatch if you guys get a sec: https://codereview.appspot.com/849104520:52
rick_h_hatch: ^^ is the event tracking extension to auto clean and applied in an initial set of uses20:52
rick_h_hatch: I could not find any way in YUI to track anytime someone did a xx.on() to auto catch them :(20:52
rick_h_hatch: so not sure it can go upstream, but maybe the 'idea' can. 20:53
rick_h_and with that...I'm spent. phew20:53
baca find juju-core branch for review if anyone would like: https://codereview.appspot.com/853204321:04
* bac -> dogwalk21:05
jcsackettrick_h_: do we need to keep the _renderSlider thing? or, honestly, any of the slider code?21:16
rick_h_droidno I don't think so. 21:17
jcsackettok, i'm going to start another branch to kill it all.21:17
rick_h_droidjcsackett it'll just be another container21:17
rick_h_droidjcsackett :-( 21:17
jcsacketthatch: can i trouble you for three short reviews?21:25
hatchthree? wow hah21:26
jcsacketthatch, awesome, thanks. they build on each other. https://codereview.appspot.com/8488045/ https://codereview.appspot.com/8529043/ and https://codereview.appspot.com/8529044/21:27
rick_h_droidhe cheats with bzr pipes :-P 21:28
jcsackettcheats nothing. i am *awesome* with bzr pipes.21:29
* rogpeppe likes bzr pipes too21:41
hatchwhats a bzr pipe?21:48
hatchjcsackett: reviews all done all LGTM with a couple questions on some21:52
hatchgary_poster: so that test is failing because 'scrollview-base-ie' is not being merged into the rollup any longer21:57
rick_h_droidhatch the slider and thus scroll view is going away22:08
rick_h_droidkilled by UX. jcsackett just started a branch to remove it all 22:08
hatchoh interesing, what's the ETA? We can't land this branch as-is because that test fails22:08
rick_h_droidhatch tomorrow 22:09
hatchoh awesome, ok then I won't spend any time on debugging it22:10
hatchalthough maybe I should as this file 'should' be being able to be merged in22:10
bcsallerhttps://codereview.appspot.com/8315046/ could still use a second review22:21
rogpeppegary_poster: unit and machine status now done; just testing, then will propose22:31
hatchbcsaller: Ican do it before EOD22:34
bcsallerhatch: thanks22:35
hatchI wish it would tell me what in my deepEquals doesn't match22:38
rogpeppehatch: i sometime use github.com/davecgh/go-spew/spew22:46
hatchthat 404'd22:46
hatchalthough I'm not sure something for go would help me with js :)22:46
rogpeppehatch: go get github.com/davecgh/go-spew/spew22:46
rogpeppehatch: ah!22:47
rogpeppehatch: i didn't know js had deepEquals22:47
hatchit's part of the assert lib22:47
hatchjavascript has everything - it's just usually not included by default in the lang :)22:48
hatchthats why we have libraries22:48
rogpeppeif anyone's waiting on UnitInfo.Status and MachineInfo.Status, i've got a branch proposed that adds them22:48
hatchand lots of them :D22:48
rogpeppehatch: :-)22:48
rogpeppei'm off now22:48
rogpeppenight all22:48
hatchbcsaller: you were saying I needed to try and do some subordinate relationship?22:52
hatchgot a second to bring me up to speed on what that was about?22:52
gary_posterhatch ah, cool.  easy fix?  back later22:58
hatchgary_poster: it should actually have already been fixed (see merge-files) for some reason that is no longer being considered. Although rich mentioned that jc is removing that scroll view tomorrow anyways so it won't actually be an issue...but we should still find out why that file isn't being included me thinks.23:23
hatchbcsaller: review done23:41
bcsallerhatch: thank you23:42
hatchgoing to take a break - I'll bbl to try and hammer our more of the relations stuff23:43

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!