| * mariusko has brokes juju-gui again... | 11:31 | |
| mariusko | broken | 11:31 |
|---|---|---|
| frankban | mariusko: you deployed using lp:juju-gui as juju-gui-source? | 11:33 |
| benji | is anyone else having problems logging onto the kanban board? | 12:02 |
| rick_h_ | benji: I had to re-login over the weekend but in it ok today | 12:03 |
| benji | it is acting flaky | 12:03 |
| === gary_poster|away is now known as gary_poster | ||
| gary_poster | hi everybody! | 12:06 |
| gary_poster | yeah, can't log in to kanban | 12:07 |
| frankban | bac: re bug 1164593: missed to specify that the described behavior happens when the GUI is connected to juju-core. I just updated the bug accordingly, sorry about that. | 12:08 |
| _mup_ | Bug #1164593: GUI hangs on the service detail view <juju-gui:Triaged by bac> < https://launchpad.net/bugs/1164593 > | 12:08 |
| bac | frankban: ok, thanks | 12:09 |
| gary_poster | benji it worked for me if I went to http leankit. That redirected to https, and then it worked. Pretty annoying though | 12:10 |
| gary_poster | oh | 12:10 |
| gary_poster | didn't really work :-( | 12:10 |
| gary_poster | mm, retrying worked | 12:11 |
| benji | I finally managed to get in but I'm afraid to click on anything because it might break. It feels like they have one or more app servers in a LB pool that is acting up | 12:11 |
| gary_poster | ah ok | 12:12 |
| * frankban lunches | 12:14 | |
| gary_poster | hey benji. what's the story with the "expose service config information via Go API" card, do you know? kanban still flaky so can't see description, if there is one | 12:18 |
| benji | gary_poster: I'm wondering if it was found to be a duplicate. | 12:19 |
| gary_poster | oh cool benji. so we have service config and constraints in go api deltas, to your knowledge? | 12:19 |
| benji | gary_poster: oh, I was (quite) sick Friday, which you may not know because I forgot to put it in the system which I am doing right now. | 12:20 |
| gary_poster | kanban board behavior not cool | 12:20 |
| gary_poster | oh! ok, benji, glad you are better | 12:20 |
| benji | I'm not certain, but I am 90% sure someone (can't remember who) said that it was on Friday. | 12:20 |
| benji | [oh dude, was so sick; barely back to vertical now] | 12:21 |
| gary_poster | ugh :-/ | 12:21 |
| benji | I suggest we kill the card and let it raise itself as a zombie if need-be | 12:21 |
| gary_poster | sorry | 12:21 |
| gary_poster | benji, "it was on Friday" -> what was on Friday? | 12:22 |
| gary_poster | kill card...mm...this will remind me to resolve the question, which I need to do :-) | 12:23 |
| benji | said "it was [a duplicate] on Friday" | 12:23 |
| gary_poster | oh ok | 12:23 |
| benji | English, you so crazy. | 12:23 |
| gary_poster | :-) | 12:23 |
| gary_poster | ok thanks. will leave card for now until I get confirmation that service config is done | 12:23 |
| === teknico_ is now known as teknico | ||
| mariusko | frankban: nope, stable | 13:12 |
| mariusko | I also struggle with with a CSS-less site with "Loading the Juju GUI" | 13:12 |
| mariusko | If I don't make the URL different by adding ?something | 13:13 |
| mariusko | I wonder if the caching settings are wrong | 13:13 |
| teknico | gary_poster, hi, yes, config get and set are in, I don't know what else that card could refer to | 13:13 |
| gary_poster | teknico, awesome! the deltas, though? | 13:13 |
| benji | do we need deltas for config? Are we sure we use them in the app? | 13:14 |
| teknico | gary_poster, don't know about them | 13:15 |
| gary_poster | rogpeppe, hi! it looks like we are making good progress. I'm not clear yet on whether we have the config information in the go deltas yet, but AFAICT after quick zooming this morning, that is either done, or the last go-side change we need. Yay! On a related note for the future, I have a suspicion that the juju core API for annotations may introduce the possibility of unpleasant race conditions across annotation | 13:16 |
| gary_poster | sources, and this may be a practical concern when we bring Landscape annotations into the fold, for instance. Specifically, if Landscape annotates an object with Landscape annotations, and we annotate an object with x,y locations, in the Python API (merged updates) there is no chance of a race condition between the two. In the Go API, IIUC, we must get annotations, change them, and set them, which introduces a rac | 13:16 |
| gary_poster | e condition across concerns | 13:16 |
| gary_poster | sorry, had to finish that up :-P | 13:16 |
| gary_poster | benji, good question. | 13:17 |
| gary_poster | We certainly expect them to be on the model | 13:17 |
| gary_poster | and config can change dynamically | 13:18 |
| gary_poster | as opposed to constraints | 13:18 |
| gary_poster | so it would idealy be in the deltas | 13:18 |
| gary_poster | mariusko, what charm | 13:18 |
| gary_poster | mariusko, the ~juju-gui charm will become the official charm once jujucharms.com is flushed | 13:19 |
| gary_poster | We test with that before release, and we run CI tests with it and trunk several times a day | 13:19 |
| gary_poster | mariusko, if the problem is when deploying with that charm, we'll jump on it asap. we have seen neither of the problems you report ourselves though, fwiw. | 13:21 |
| gary_poster | (which is definitely not to imply they do not exist() | 13:21 |
| frankban | mariusko: you can try removing the appcache from chrome://appcache-internals/ | 13:22 |
| gary_poster | good call on the CSS frankban | 13:22 |
| frankban | gary_poster: FWIW, I bootstrapped a juju-core env ~5 hours ago, and I don't see the settings in the delta stream, nor the status | 13:23 |
| gary_poster | frankban, I wrote a novel to rogpeppe above which included a concern about the Go annotation API. Does that concern make sense to you? | 13:23 |
| gary_poster | frankban, ah :-( | 13:23 |
| gary_poster | the status we definitely need now | 13:24 |
| gary_poster | the config we will need but we *might* be able to do it after 13.04 | 13:24 |
| frankban | gary_poster: do we also need the constraints? I remember you said we get them from the charm maybe? | 13:24 |
| rogpeppe | gary_poster: hiya | 13:26 |
| rogpeppe | gary_poster: i'm not sure i see why you need to get-change-set annotations | 13:27 |
| gary_poster | frankban, no, we get is_subordinate form the charm. constraints and config have value in the delta stream only when we are viewing them explicitly, and possibly when we are editing them. We would want to be able to see when the config changed as an alert, I suspect. also, a nice to have would be to see changes while you are editing them. We could push both of those off to post 13.04 if what I describe are the on | 13:28 |
| gary_poster | ly use cases, and if we already explicitly get/update the constraints and config when we look at them now | 13:28 |
| rogpeppe | gary_poster: i think we can set x and y without affecting landscape annotations | 13:28 |
| gary_poster | rogpeppe, ah ok, I wanted to verify my memory of the API before I bothered you, but I was losing state in my brain so I had to dump :-) . DO I remember correctly that the Go API is to set all annotations? | 13:28 |
| gary_poster | ah no! | 13:28 |
| gary_poster | you can set an annotation to null | 13:29 |
| gary_poster | and that removes it | 13:29 |
| gary_poster | right? | 13:29 |
| rogpeppe | gary_poster: empty string, but yes | 13:29 |
| gary_poster | rogpeppe, ok cool, sorry for the noise on that then. excellent. So in terms of status of the deltas: | 13:29 |
| gary_poster | - we need status in there | 13:29 |
| gary_poster | - config is nice to have | 13:30 |
| gary_poster | - constraints is also nice to have, and lower priority | 13:30 |
| rogpeppe | gary_poster: i'm getting there; i've done quite a bit of refactoring (the allWatcher is now in its own package) and next up should be the statuses. | 13:30 |
| gary_poster | rogpeppe, great! I certanly saw a lot of work from you fly by | 13:31 |
| gary_poster | rogpeppe, AIUI this Thursday is the "we really should have everything in Raring now" and next Thursday is "um, sorry, it is too late, you can't even have bug fixes" | 13:31 |
| gary_poster | rogpeppe, when would be the soonest to hope for statuses in the deltas? Also, I take it that these changes are entirely on your plate? | 13:33 |
| rogpeppe | gary_poster: hopefully by end tomorrow, if implementation goes to plan | 13:36 |
| gary_poster | ok cool rogpeppe thanks. let me/us know if there's something we can usefully put in our plate | 13:37 |
| gary_poster | on | 13:37 |
| frankban | gary_poster, rogpeppe: I think this is related: bug 1161848 | 13:37 |
| _mup_ | Bug #1161848: Malformed charm metadata error when a charm is deployed using the API <juju-core:New> <juju-gui:Triaged> < https://launchpad.net/bugs/1161848 > | 13:37 |
| frankban | more recently, when ServiceDeploy is called, I started seeing juju-core panics | 13:38 |
| rogpeppe | frankban: interesting; thanks for the report. related to what? | 13:38 |
| gary_poster | thank you, yes frankban. My understanding is that this is not specific to the API though, right? | 13:38 |
| gary_poster | rogpeppe, related to us being done successfully, I think :-) | 13:38 |
| rogpeppe | frankban: was that against a newly bootstrapped environment? | 13:39 |
| frankban | gary_poster: the API call is what juju-core expects. I am grabbing logs about the panic | 13:39 |
| frankban | rogpeppe: against an env bootstrapped ~5 hours ago | 13:39 |
| frankban | (this morning) | 13:39 |
| rogpeppe | frankban: with --upload-tools, presumably? | 13:40 |
| rogpeppe | frankban: have you tried doing "juju deploy minecraft" against the same environment? | 13:40 |
| gary_poster | frankban, I expected that this error would also happen if you tried to deploy minecraft without the GUI, was my question. | 13:40 |
| gary_poster | (without the API) | 13:41 |
| rogpeppe | frankban: i'm surprised there's a difference between the api deploy and the cmd line deploy, actually | 13:41 |
| gary_poster | (right, that was what I was trying to say) | 13:43 |
| frankban | rogpeppe, gary_poster: the cmd line deploy works well, here is the error and the subsequent panic when ServiceDeploy is called via the API: http://pastebin.ubuntu.com/5689443/ | 13:44 |
| gary_poster | ahha | 13:44 |
| frankban | rogpeppe: nad yes, --upload-tools was used | 13:44 |
| rogpeppe | frankban: ah! | 13:44 |
| frankban | s/nad/and | 13:44 |
| gary_poster | frankban, so we probably now have two bugs, yeah? the panic because of the home, and the relation name problem | 13:45 |
| gary_poster | rogpeppe, if you want us to get some people to work on these, and consult on you initially for fixes, that would be great by me. | 13:46 |
| gary_poster | consult with you initially for fixes | 13:46 |
| rogpeppe | gary_poster: that would be great, thanks! | 13:46 |
| gary_poster | I noticed my preposition use today was a bit off generally :-P | 13:47 |
| rogpeppe | gary_poster: i feel a little overloaded right now | 13:47 |
| gary_poster | rogpeppe, completely understood. I'll find some people and send them your way for a pre-imp discussion, and then hopefully we can get out of your hair | 13:47 |
| gary_poster | mm... frankban and/or teknico, are either of you up for those? | 13:48 |
| frankban | gary_poster: yes, this seems a different bug. but I am confused about "relation name". you mean the charm not found error? | 13:49 |
| gary_poster | frankban, your bug (https://bugs.launchpad.net/juju-gui/+bug/1161848) doesn't report a missing charm as I read it ('malformed charm metadata found in state: charm "mysql" has mismatched relation name ""; expected "shared-db"') | 13:50 |
| _mup_ | Bug #1161848: Malformed charm metadata error when a charm is deployed using the API <juju-core:New> <juju-gui:Triaged> < https://launchpad.net/bugs/1161848 > | 13:50 |
| gary_poster | do I misunderstand | 13:50 |
| rogpeppe | frankban: check out recent remarks on #juju-dev | 13:51 |
| frankban | gary_poster: yes. so I think we have 3 different issues. 1) CharmInfo returns "charm not found", 2) ServiceDeploy generates a panic and 3) the old bug, that could be still valid | 13:51 |
| hatch | gooood morning | 13:51 |
| gary_poster | morning hatch | 13:52 |
| gary_poster | frankban, ack. 1 and 2 seem related to me, but that's a guess. | 13:53 |
| rogpeppe | gary_poster: this branch factors out the allwatcher: https://codereview.appspot.com/8458044/ | 13:53 |
| gary_poster | cool rogpeppe! So if we want to refactor the allwatcher we will still have that base for what we want. | 13:53 |
| frankban | gary_poster: seeing the discussion in #juju-dev, I have the same impression | 13:53 |
| teknico | gary_poster, yep | 13:54 |
| rogpeppe | gary_poster: exactly. the new package gives the basis for any combined watcher you might want to concoct | 13:54 |
| rick_h_ | jcsackett: hatch or others can I beg for some reviews today please? https://codereview.appspot.com/8513043 for huw and https://codereview.appspot.com/8488043/ for myself | 13:54 |
| gary_poster | great | 13:54 |
| rogpeppe | gary_poster: it's the change i was putting off, but it became necessary. | 13:54 |
| hatch | rick_h_: sure | 13:54 |
| rick_h_ | hatch: ty kindly sir | 13:55 |
| gary_poster | ah ok rogpeppe | 13:55 |
| gary_poster | frankban, also we can't tackle 3 until 2 is handled, rt? | 13:55 |
| frankban | gary_poster: yes | 13:55 |
| gary_poster | or at least it will be more difficult | 13:55 |
| gary_poster | cool. you working on 1 and/or 2 then frankban? If so, suggest with Roger soon, and planned handoff with someone tbd (maybe me and I would rope in someone with more go experience?)if it takes you past your EoD | 13:57 |
| gary_poster | suggesting talking with Roger soon, I meant | 13:57 |
| frankban | gary_poster: sounds good | 13:57 |
| gary_poster | cool thank you | 13:57 |
| rick_h_ | luca____: howdy, heads up. I promised you and jovan2 an link to view for the config tab on the browser: http://uistage.jujucharms.com:8080/bws/fullscreen/precise/apache2-2 and click on the configuration tab below | 14:08 |
| rick_h_ | hatch: did they update getData to look for the data- attribute? I could have sworn that was the big confusion with that when they added it. It didn't work at all with the attributes in the dom | 14:11 |
| hatch | rick_h_: yeah a long long time ago | 14:12 |
| hatch | it now works for both | 14:12 |
| hatch | I forgot about that confusion :) | 14:12 |
| rick_h_ | hatch: hmm, ok. I guess I got in my head that it's never what I expect since so ditched its use. | 14:12 |
| rick_h_ | hatch: ok cool then. missed that change/update along the way I guess | 14:12 |
| rick_h_ | hatch: thanks for the look over | 14:12 |
| hatch | yeah that's fine - It doesn't really matter which one you use I was just pointing it out | 14:13 |
| hatch | no problem | 14:13 |
| rick_h_ | hatch: yea, good to know :) I'd still not know they changed it. | 14:13 |
| hatch | :) | 14:14 |
| hatch | does Huw's branch need QA? | 14:14 |
| rick_h_ | hatch: you can, but it's pretty simple just add a column/not. Not much to it | 14:14 |
| rick_h_ | no real crazy style/etc stuff to check works correctly. | 14:15 |
| frankban | rogpeppe: please ping me when you are available for a pre-imp call re bug 1166224 | 14:15 |
| _mup_ | Bug #1166224: Panic when calling ServiceDeploy via the juju-core API <juju-core:Triaged> <juju-gui:Triaged> < https://launchpad.net/bugs/1166224 > | 14:15 |
| gary_poster | teknico, thanks for readthedocs improvement :-) | 14:15 |
| luca____ | rick_h_: cheers Rick, I'll check it out | 14:15 |
| rogpeppe | frankban: will do. in a call right now | 14:15 |
| frankban | rogpeppe: thanks | 14:16 |
| rick_h_ | luca____: yea, so feel free then to mark that up and we can update the designs if needed/etc. | 14:16 |
| gary_poster | Makyo, benji, bac, teknico you all have readthedocs privs: thank you for getting me your user names | 14:16 |
| teknico | gary_poster, mp, I also put a requirement for Sphinx in there | 14:16 |
| gary_poster | cool | 14:16 |
| bac | gary_poster: yay | 14:16 |
| teknico | gary_poster, yeah, I noticed ;-) | 14:16 |
| gary_poster | ;-) | 14:17 |
| frankban | gary_poster: my rtd account is, surprisingly, frankban | 14:18 |
| gary_poster | frankban, :-P you are added | 14:18 |
| gary_poster | :-) | 14:18 |
| frankban | :-) thanks | 14:18 |
| jovan2 | rick_h_: I like the layout of the configuration options. I would put the default value before the explanatory text though. | 14:24 |
| rick_h_ | jovan2: ok. can move that without an issue. | 14:24 |
| rick_h_ | I'll drive-by that in the branch I've got going right now | 14:25 |
| jovan2 | rick_h_ cheers | 14:25 |
| gary_poster | Hey bac, thank you very much for reviewing/helping BjornT. That looks like it was more work for you than I had expected, and I'm sorry about that, but I'm glad he is unblocked | 14:26 |
| hatch | rick_h_: ugh I hate how less's mixins look like class names | 14:26 |
| rick_h_ | hatch: +1 | 14:27 |
| bac | gary_poster: it was no problem. easier to review his changes than to do the work! | 14:27 |
| gary_poster | :-) cool | 14:27 |
| bac | gary_poster: he made one change that will help us in that it will avoid looking at the archives | 14:27 |
| rick_h_ | hatch: so when you convert it all over to sass let me know :) | 14:27 |
| hatch | lol | 14:27 |
| gary_poster | bac, oh excellent | 14:27 |
| hatch | I wish sass wasn't written in ruby | 14:27 |
| rogpeppe | frankban: ready when you are | 14:27 |
| rick_h_ | hatch: I'll do the review | 14:27 |
| hatch | rick_h_: haha it probably woudln't be THAT much work | 14:28 |
| rick_h_ | hatch: https://github.com/Kronuz/pyScss is what I use in my projects. python ftw | 14:28 |
| hatch | most of the stuff is identical | 14:28 |
| hatch | lol of course you do :P | 14:28 |
| rick_h_ | hatch: well I wasn't going to isntall ruby just for css compiling :P | 14:28 |
| hatch | lol good point | 14:28 |
| hatch | this machine has so much garbage installed and modified it's a miracle it's even still running | 14:29 |
| jcsackett | rick_h_: got a second to chat? | 14:29 |
| frankban | rogpeppe: cool, https://plus.google.com/hangouts/_/02bb45411739e441fe107c9f66e2a8cc36ba4ba7?authuser=0&hl=en# | 14:30 |
| hatch | brb | 14:32 |
| rick_h_ | jcsackett: yep, sure thing | 14:33 |
| rick_h_ | hatch: I'm goign to kick you | 14:33 |
| mariusko | gary_poster: testing it now, but it is broken: "nodejs : Conflicts: npm" | 14:33 |
| mariusko | It must stop installing npm, as it is included in nodejs package | 14:33 |
| gary_poster | mariusko, I saw that when it landed but it worked for me. hatch, ^^^. mariusko I am unhappy that you are encountering issues that we don't see, and apologize. :-( Send me an email @ gary.poster@canonical.com with the commands you are running, even if they are obvious, and I will run them myself, fix what I can and we can go from there. | 14:36 |
| gary_poster | where "going from there" hopefully includes figuring out what we are missing in our QA | 14:37 |
| mariusko | It's not anything special, and it is not so easy to reproduce, as it works first, and then fails. It could be too little memory on the machines that causes it to fail | 14:39 |
| hatch | rick_h_: what did I do now? | 14:45 |
| rick_h_ | hatch: I specifically moved that from an ATTR into a function because of your hate for 'empty attrs' | 14:45 |
| hatch | but it's not empty | 14:46 |
| rick_h_ | hatch: I started out with it as an attr and a getter and moved it to a function before -cr for you :) | 14:46 |
| hatch | it would be a flag | 14:46 |
| hatch | no? | 14:46 |
| rick_h_ | hatch: no, it's completely based on the class.name | 14:46 |
| hatch | new charmBrowser({fullscreen: true}); | 14:46 |
| rick_h_ | hatch: no, look at what isFullscreen() does. It checks for a match in the class name | 14:46 |
| hatch | mariusko: gary_poster: one of our dependencies doesn't like Node 10 so I had to roll it back to 0.8 | 14:47 |
| rick_h_ | the MainView is extended by SidebarView and FullscreenView to provide the different bits, but they're so common in most places. | 14:47 |
| hatch | is the charm still trying to install 10? | 14:47 |
| hatch | hmm | 14:48 |
| hatch | I think it's going to be fragile - if someone changes the name and then all of a sudden the fullscreen stops working it's going to be very hard to diagnose | 14:48 |
| hatch | don't you think? | 14:48 |
| rick_h_ | hatch: right, but there's a test that it is correct so the test will fail right away | 14:48 |
| rick_h_ | hatch: but the render code and the template is shared between fullscreen/sidebar. Only fullscreen template needs to add a column to fill some space. | 14:49 |
| hatch | yeah I saw that....hmm | 14:49 |
| rick_h_ | hatch: so the best way is to create a simple check var the template can key off of to determine if it can use 'wide view' or 'narrow view' in the process | 14:49 |
| hatch | yeah - I suppose it's ok with that test | 14:49 |
| rick_h_ | hatch: and if I do it manually with an ATTR then every call site has to be kept in sync vs a class name which is safer imo | 14:49 |
| Makyo | gary_poster, ping. | 14:52 |
| hatch | mariusko: can you check which version of node is being installed? it should be 8.22 | 14:53 |
| hatch | Makyo: I see you assigned yourself to that odd bug | 14:55 |
| hatch | any ideas about what's going on? | 14:55 |
| Makyo | hatch, Not yet, adding a ton of logging, though. | 14:56 |
| hatch | I spent a few minutes on it and I am almost 100% certain it's a D3 'bug' | 14:56 |
| hatch | bug is in quotes because it's probably caused by our code | 14:56 |
| hatch | haha | 14:56 |
| Makyo | hatch, yeah, there are a few places where position is set and I'm wondering if something's getting knocked around there. Digging the debugging console at least. | 14:58 |
| gary_poster | Makyo, sorry, missed you. on call | 15:04 |
| Makyo | gary_poster, np, two quick questions when you get a moment. | 15:04 |
| hatch | frankban: there were no changes with slider in 3.10 so will have to investigate further but maybe once PR2 comes out | 15:06 |
| frankban | hatch: sounds good, I don't think is an high priority problem | 15:07 |
| hatch | frankban: and for the record I approve of your YUI version restriction :) | 15:10 |
| hatch | rick_h_: when you next talk to Huw could you ask him why he is mixing units? re the fix for the button height issue | 15:16 |
| hatch | pt & px | 15:16 |
| rick_h_ | hatch: k, will do. | 15:16 |
| mariusko | hatch: nope, it is 0.10.3-1chl1~precise1 | 15:18 |
| bac | frankban: i understand the problem with bug 1164593. when i implemented the go API for ServiceGet i only returned the data required by 'juju get <svc>'. but the python API included more information. so now i will add the constraints and other required bits to the Go api. | 15:19 |
| _mup_ | Bug #1164593: GUI hangs on the service detail view when connected to juju-core <juju-gui:In Progress by bac> < https://launchpad.net/bugs/1164593 > | 15:19 |
| hatch | mariusko: thanks for checking - hmm that's very odd because the most recent code in lp uses the legacy repo which I was sure topped out at 8.22, | 15:19 |
| frankban | bac: great | 15:19 |
| mariusko | hatch: which ppa? The charm itself is an old one for precise | 15:20 |
| hatch | mariusko: here is the line in question http://bazaar.launchpad.net/~juju-gui/charms/precise/juju-gui/trunk/view/head:/hooks/utils.py#L81 | 15:20 |
| hatch | ohh you're not running from trunk | 15:20 |
| hatch | sorry I'm still new to this game so I don't know all of the questions to ask yet :D | 15:21 |
| hatch | https://launchpad.net/~chris-lea/+archive/node.js-legacy | 15:22 |
| hatch | there is the PPA - so it looks like in trunk it should still be deploying 8.22 | 15:22 |
| mariusko | bah, now it won't install and then not upgrade or retry | 15:23 |
| hatch | :/ | 15:32 |
| hatch | would you like me to give it a go using latest ? | 15:33 |
| hatch | I can spin up some instances but it might take a while :) | 15:33 |
| hatch | it's entirely possible that the dependency has been updated to work with 10 now and this is another issue entirely | 15:37 |
| teknico | ok | 15:37 |
| hatch | bcsaller: did you need another review on your annotations branch? | 15:39 |
| bcsaller | hatch: making the changes gary wants now so I can push another soon | 15:39 |
| hatch | alright no problem | 15:39 |
| mariusko | hatch: hmm, the line is correct: BUILD_REPOSITORIES = ('ppa:chris-lea/node.js-legacy',) | 15:48 |
| hatch | mariusko: alright I'll spin up some instances to debug this | 15:51 |
| mariusko | great | 15:51 |
| gary_poster | Makyo, questions now or in/after daily call? | 15:54 |
| Makyo | gary_poster, in would be fine. | 15:55 |
| gary_poster | cool | 15:55 |
| hatch | mariusko: ok instances are being spun up so I'll get back to you once I have something | 15:55 |
| hatch | gary_poster: I can't log into the kanban so can you pm me that link? | 15:59 |
| gary_poster | jujugui call now | 15:59 |
| gary_poster | CalledProcessError: Command '['ssh', 'ubuntu@10.55.61.25', 'sudo', 'service', 'juju-api-improv', 'restart']' returned non-zero exit status 255 | 16:00 |
| gary_poster | https://docs.google.com/a/canonical.com/spreadsheet/ccc?key=0Aia4W3c4fbL-dFlYQm1Zd1dGTVE5S2o4ZUVLam5IMnc#gid=0 | 16:00 |
| mariusko | hatch: i think there might be some machine reuse going on here. currentry trying a new node | 16:07 |
| mariusko | / instance | 16:07 |
| hatch | mariusko: I'm actually getting some 503's on a bunch of other PPA's | 16:08 |
| * mariusko got it working now. Let's see how long it lasts. | 16:16 | |
| bac | Makyo, bcsaller: i just noticed the rendering of the service blocks in FF on OS X is whack. the inner circle is at the bottom right corner and the indicator ring is outside the box altogether. | 16:29 |
| Makyo | bac, anything in the console? | 16:29 |
| bcsaller | bac: Is that true after the 1st delta? Its mostly thowing an error before the draw is done | 16:30 |
| bcsaller | death before translation! | 16:30 |
| bac | [12:30:36.523] Firefox can't establish a connection to the server at ws://uistage.jujucharms.com:8081/ws. @ http://uistage.jujucharms.com:8080/juju-ui/assets/all-yui.js:28 | 16:30 |
| bcsaller | I think there would be an actual exception in our code for that to happen | 16:31 |
| benji | Is the unit view expected to work with the go backend? I just get a loading message. There are no (related) errors in the JS console. | 16:41 |
| benji | I can't help but think I'm doing something wrong. Every time I try to do anything with the gui and go it is a slow, painful process. | 16:41 |
| benji | does deploying work with the go backend? | 17:00 |
| === deryck is now known as deryck[afk] | ||
| rogpeppe | gary_poster: next CL in the pipe: https://codereview.appspot.com/8487044 | 17:29 |
| rogpeppe | gary_poster: next up: statuses! | 17:29 |
| teknico | benji, the answer is in the mailing list ;-) | 17:29 |
| gary_poster | yay! :-) | 17:29 |
| teknico | benji, specifically in the "Handing off bug #1166224" message | 17:31 |
| _mup_ | Bug #1166224: Panic when calling ServiceDeploy via the juju-core API <juju-core:Triaged> <juju-gui:In Progress> < https://launchpad.net/bugs/1166224 > | 17:31 |
| rogpeppe | gary_poster: ah, darn, i forgot to write a load of tests | 17:32 |
| gary_poster | :-/ | 17:32 |
| Makyo | I found a work-around for #1159870 but it involves enforcing two-finger dragging. It works, but isn't very discoverable. Perhaps something we can tool-tip? | 17:41 |
| _mup_ | Bug #1159870: Viewing service from popup on mobile causes service svg element to move <juju-gui:Triaged by makyo> < https://launchpad.net/bugs/1159870 > | 17:41 |
| hatch | Makyo: wasn't two finger dragging the default anyways? | 17:52 |
| Makyo | hatch, well, it was the one that worked properly :) | 17:53 |
| hatch | haha ok ok | 17:54 |
| hatch | so when it's two finger drag it doesn't jump when you view services? | 17:54 |
| Makyo | hatch, correct. It still attempts to fire drag events, but if we go with two-finger drag, we can set a flag to break out of drag if there is only one touch. | 17:55 |
| hatch | oh awesome | 17:55 |
| hatch | nice find! | 17:55 |
| hatch | that was driving me nuts | 17:55 |
| Makyo | Meeee too. | 17:55 |
| Makyo | Especially because, previously, panning wasn't working. | 17:56 |
| Makyo | Is now, though. | 17:56 |
| benji | (back from lunch now) teknico: thanks for the info | 18:11 |
| teknico | benji, yw | 18:14 |
| hatch | rick_h_: any idea why the valuechange woudln't trigger in the browser search tests? | 18:18 |
| hatch | 'browser search widget' to be specific | 18:18 |
| hatch | the one with the 200ms timeout | 18:18 |
| rick_h_ | hatch: looking. It's not triggered? | 18:20 |
| gary_poster | intermittently | 18:20 |
| hatch | sometimes it even hits the 20s mocha timeout (if we remove the timeout in the test) | 18:20 |
| rick_h_ | gary_poster: oh hmm, it's based on a _poll time in the YUI code | 18:20 |
| rick_h_ | so maybe there's an issue with the test/poll interval crossing there? | 18:20 |
| rick_h_ | value-change is used to detect things like pasting in which doen't fire events like keyup/etc to watch for changes. | 18:21 |
| rick_h_ | to do that it runs a 50ms poll by default looking for changes to the value | 18:21 |
| hatch | yeah I've never seen it fail in the real world | 18:23 |
| rick_h_ | hatch: yea, I've not seen it locally at all. Second, I'm debugging a failing test for some new code atm and I'll go back and look at that test and see if there's a shortcut/way to tinker with it | 18:24 |
| hatch | thanks - I tried wrapping it in a timeout to set the value but no luck | 18:25 |
| hatch | maybe if we set it repeatedly | 18:25 |
| hatch | haha | 18:25 |
| rick_h_ | hatch: so I'm wondering if we can change the _poll interval on the module to be less/quicker | 18:25 |
| rick_h_ | actually that sounds familiar | 18:26 |
| rick_h_ | hatch: yea, so looking at that test I added a timeout to help make sure the poll event had a chance to fire | 18:32 |
| rick_h_ | hatch: and I'd bet that on slower hardware/etc it's not getting to I guess... | 18:32 |
| hatch | well sure but one would think that it should fire in 200ms | 18:33 |
| rick_h_ | hatch: so maybe we can change this in the test http://yuilibrary.com/yui/docs/api/files/event-valuechange_js_event-valuechange.js.html#l44 | 18:34 |
| hatch | that's a long time really | 18:34 |
| hatch | ahh change it to poll faster? | 18:34 |
| rick_h_ | down to single digit and it'll just poll like mad for the length of the test | 18:34 |
| rick_h_ | but it's a single one just to make sure the event it wired correctly | 18:34 |
| rick_h_ | not even the whole suite of tests for that module need it, just the one test | 18:34 |
| rick_h_ | hatch: yea, just off the top of my head | 18:34 |
| rick_h_ | hatch: but yea, with a 50ms poll interval I had thought 4x as long would be good for this | 18:35 |
| rick_h_ | so maybe it's not the case, but only thing I can think of that would case it to fail intermittantly | 18:36 |
| BradCrittenden | guihelp: when using firefox (testing against juju-core) if i'm on the service page and click on constraints attempting to go to http://localhost:8888/:gui:/service/mysql/constraints/ i then get trapped by the unsupported browser warning and then am shown the canvas. is this a new issue? | 18:38 |
| === BradCrittenden is now known as bac | ||
| bac | dumb question. no one has been able to do what i just described until the fix i just made...at least not with go juju | 18:41 |
| Makyo | bac, can't get that to happen, but this is on improv | 18:47 |
| hatch | rick_h_: what tells the build script to include the widget files? | 18:47 |
| benji | bac: no idea; I have a similar problem just double-clicking on a service | 18:48 |
| bac | benji: that's the bug i'm working on | 18:48 |
| bac | benji: you get a hang or browser trap? | 18:48 |
| benji | bac: forever " | 18:48 |
| rick_h_ | hatch: include the JS of them? or what | 18:48 |
| benji | Loading..." | 18:48 |
| hatch | yah | 18:48 |
| rick_h_ | hatch: they're added to the modules-debug right? | 18:49 |
| bac | benji: yeah, that'll be fixed soon | 18:49 |
| hatch | yep | 18:49 |
| benji | yay! | 18:49 |
| hatch | rick_h_: basically charm-search.js is not being loaded in prod tests | 18:49 |
| rick_h_ | hatch: oh hmm. am I missing a YUI.use in that file? | 18:49 |
| * rick_h_ looks | 18:49 | |
| rick_h_ | I mean it works sometimes right? so wtf? | 18:50 |
| hatch | this is failing all the time | 18:50 |
| hatch | charm-search.js is not included in the all-yui.js | 18:50 |
| hatch | file | 18:50 |
| rick_h_ | hatch: second, I've borked things up locally here atm | 18:55 |
| hatch | np take your time, we are taking a lunch break | 18:58 |
| hatch | lemme know when you're able to take a peek and I'll get you the branch and details | 18:59 |
| rick_h_ | hatch: k, is there supposed to be something more to it? | 19:00 |
| rick_h_ | than adding to modules-debug that is | 19:00 |
| gary_poster | hatch, your bug report about PyJujuAPI: same thing! works in debug, fails in prod, at least for me | 19:02 |
| gary_poster | lunch now ;-) | 19:02 |
| hatch | gary_poster: yep yep | 19:02 |
| hatch | rick_h_: setting describe.only() on browser search widget causes the tests to fail on sh test-server.sh prod true | 19:03 |
| hatch | Uncaught TypeError: Cannot read property 'widgets' of undefined | 19:03 |
| hatch | rick_h_: lp:~gary/juju-gui/testclean is the branch we are hacking on | 19:04 |
| hatch | now I'm lunching | 19:04 |
| hatch | :) | 19:04 |
| rick_h_ | hatch: cool, will thanks | 19:04 |
| jcsackett | rick_h_: so, with the changes to the container, we're left a little unclear on behavior. i'm assuming clicking the little arrow expands and the arrow changes for "less"; does the num in parenthesis do anything? does it show the total, or how many more there are...? | 19:19 |
| bcsaller | https://codereview.appspot.com/8315046/ could use another review he says as he heads to lunch | 19:19 |
| rick_h_ | jcsackett: we can check with luca and jovan (not in channel atm) but I assumed it just showed the total count of items | 19:19 |
| rick_h_ | jcsackett: so it would not change | 19:19 |
| jcsackett | rick_h_: ok. | 19:20 |
| rogpeppe | gary_poster: tests now done... | 19:39 |
| rogpeppe | gary_poster: *now* for status :-) | 19:39 |
| gary_poster | rogpeppe, :-) awesome | 19:40 |
| rogpeppe | gary_poster: even better, the new tests exposed a significant bug... | 19:40 |
| gary_poster | that does always feel good | 19:40 |
| rogpeppe | gary_poster: in the new code | 19:40 |
| gary_poster | cool | 19:40 |
| rick_h_ | hatch: when you get back let me know. Your branch lp:~gary/juju-gui/testclean works for test-prod for me, however I was working on lp:~rharding/juju-gui/event_tracker and that was throwing a buildCfg error creating the object definition on charm-search and I can't figure out why. | 19:46 |
| gary_poster | rick_h_, to provoke, you do the following: | 19:47 |
| gary_poster | ./test-server.sh prod true | 19:47 |
| gary_poster | then | 19:47 |
| gary_poster | http://localhost:8084/test/index.html?grep=sandbox.PyJujuAPI | 19:47 |
| gary_poster | and/or | 19:47 |
| gary_poster | http://localhost:8084/test/index.html?grep=browser%20search%20widget | 19:48 |
| rick_h_ | gary_poster: cool thanks looking | 19:48 |
| jcsackett | rick_h_ and hatch: can y'all look at https://codereview.appspot.com/8488045/ | 19:50 |
| jcsackett | rick_h_: i didn't update the template for the design we have now in this branch; i did it in a follow up that's on rietveld, but has this one as a dependent. | 19:50 |
| hatch | back | 19:56 |
| hatch | gary_poster: so any ideas over lunch? :) | 19:56 |
| rick_h_ | hatch: so the widgets are loaded as part of app.js, not yui-all.js | 19:58 |
| rick_h_ | hatch: and that's never loaded in the test file links that gary_poster gave me | 19:58 |
| rick_h_ | hatch: so maybe you can fill me in on the diff between the yui-all and app.js and how that works with tests? | 19:59 |
| gary_poster | sorry, missed the first ping | 19:59 |
| gary_poster | rick_h_, you have stumbled upon a mystery wrapped within an enigma...or at least something I've forgotten most of :-P | 19:59 |
| rick_h_ | hatch: I can move widgets in modules-debug to their own category like the others loaded into app.js (things like the d3 and prettify are in yui-all.js) | 20:00 |
| rick_h_ | but yea, I don't see tests loading app.js, I'm not sure atm how tests do work now that I see this lol | 20:01 |
| hatch | ahhh | 20:01 |
| hatch | so THAT's why it works when we load everything | 20:01 |
| hatch | s/load/run | 20:01 |
| hatch | hmm I really don't like that | 20:01 |
| gary_poster | well, but why is app.js loading when we run everything | 20:01 |
| rick_h_ | yea, app.js is loaded when we run everything, looking to see 'who/why' | 20:02 |
| hatch | well because we instantiate it in test_app.js | 20:02 |
| gary_poster | instantiate? | 20:02 |
| gary_poster | the file? | 20:02 |
| gary_poster | thsi is in prod | 20:02 |
| gary_poster | so everything should be compressed | 20:02 |
| hatch | ohhh | 20:02 |
| hatch | yes | 20:02 |
| rick_h_ | some other test/file/etc is loading app.js somehow I think | 20:02 |
| hatch | well but that shouldn't matter | 20:03 |
| gary_poster | fwiw, I verified that adding app.js to index.html makes everything better | 20:03 |
| rick_h_ | hatch: so yea, I'm not sure, still working through this | 20:03 |
| hatch | because when we include the browser-search-widget module it should pull in everyuthing that it needs | 20:04 |
| rick_h_ | I mean if app.js isn't in the tests how to the tests for everything juju.. work? | 20:04 |
| gary_poster | yeah exactly | 20:04 |
| rick_h_ | hatch: well, it's not pulling in app.js. That's not a YUI module or the like | 20:04 |
| rick_h_ | hatch: there's noting in the YUI system to pull/load that in | 20:04 |
| rick_h_ | I mean http://localhost:8084/test/index.html?grep=juju%20unit%20view fails as well | 20:05 |
| rick_h_ | because app.js isn't loaded and there's no such thing as Y.juju as far as the test is concerned | 20:06 |
| hatch | well that should be loaded in the tests that need it | 20:06 |
| hatch | maybe I'm totally missing what you're saying | 20:06 |
| gary_poster | app.js is not in modules hatch | 20:06 |
| hatch | guichat? | 20:06 |
| rick_h_ | sec, I've got to get my headset and such | 20:06 |
| gary_poster | I'm there | 20:06 |
| * Makyo dogs-walk. | 20:15 | |
| === deryck[afk] is now known as deryck | ||
| hatch | thanks rick | 20:17 |
| jcsackett | is there any way to make lbox/rietveld play nice with pipes/prereq branches? | 20:20 |
| rick_h_ | hatch: you guys still on? | 20:24 |
| hatch | yep | 20:24 |
| rick_h_ | hatch: sorry, battery died on me mid-call | 20:24 |
| rick_h_ | k, sec | 20:24 |
| rick_h_ | jcsackett: -req=lp:.... flag | 20:24 |
| jcsackett | rick_h_: ah, ok. | 20:25 |
| jcsackett | thanks | 20:25 |
| rick_h_ | jcsackett: cool thanks for the updates | 20:36 |
| jcsackett | rick_h_: yw. | 20:36 |
| jcsackett | rick_h_: the charm container/sidebar integration is up as well, as is the followup for the container design. | 20:44 |
| jcsackett | https://codereview.appspot.com/8529044/ and https://codereview.appspot.com/8529043/ | 20:44 |
| rick_h_ | jcsackett: looking | 20:46 |
| rick_h_ | jcsackett: ok, comments on everything | 20:49 |
| rick_h_ | jcsackett: hatch if you guys get a sec: https://codereview.appspot.com/8491045 | 20:52 |
| rick_h_ | hatch: ^^ is the event tracking extension to auto clean and applied in an initial set of uses | 20:52 |
| rick_h_ | hatch: I could not find any way in YUI to track anytime someone did a xx.on() to auto catch them :( | 20:52 |
| rick_h_ | hatch: so not sure it can go upstream, but maybe the 'idea' can. | 20:53 |
| rick_h_ | and with that...I'm spent. phew | 20:53 |
| bac | a find juju-core branch for review if anyone would like: https://codereview.appspot.com/8532043 | 21:04 |
| bac | s/find/fine | 21:04 |
| * bac -> dogwalk | 21:05 | |
| jcsackett | rick_h_: do we need to keep the _renderSlider thing? or, honestly, any of the slider code? | 21:16 |
| rick_h_droid | no I don't think so. | 21:17 |
| jcsackett | ok, i'm going to start another branch to kill it all. | 21:17 |
| rick_h_droid | jcsackett it'll just be another container | 21:17 |
| rick_h_droid | jcsackett :-( | 21:17 |
| jcsackett | hatch: can i trouble you for three short reviews? | 21:25 |
| hatch | three? wow hah | 21:26 |
| hatch | sure | 21:26 |
| jcsackett | hatch, awesome, thanks. they build on each other. https://codereview.appspot.com/8488045/ https://codereview.appspot.com/8529043/ and https://codereview.appspot.com/8529044/ | 21:27 |
| hatch | alright | 21:28 |
| rick_h_droid | he cheats with bzr pipes :-P | 21:28 |
| jcsackett | cheats nothing. i am *awesome* with bzr pipes. | 21:29 |
| * rogpeppe likes bzr pipes too | 21:41 | |
| hatch | whats a bzr pipe? | 21:48 |
| hatch | jcsackett: reviews all done all LGTM with a couple questions on some | 21:52 |
| hatch | gary_poster: so that test is failing because 'scrollview-base-ie' is not being merged into the rollup any longer | 21:57 |
| rick_h_droid | hatch the slider and thus scroll view is going away | 22:08 |
| rick_h_droid | killed by UX. jcsackett just started a branch to remove it all | 22:08 |
| hatch | oh interesing, what's the ETA? We can't land this branch as-is because that test fails | 22:08 |
| rick_h_droid | hatch tomorrow | 22:09 |
| hatch | oh awesome, ok then I won't spend any time on debugging it | 22:10 |
| hatch | although maybe I should as this file 'should' be being able to be merged in | 22:10 |
| bcsaller | https://codereview.appspot.com/8315046/ could still use a second review | 22:21 |
| rogpeppe | gary_poster: unit and machine status now done; just testing, then will propose | 22:31 |
| hatch | bcsaller: Ican do it before EOD | 22:34 |
| bcsaller | hatch: thanks | 22:35 |
| hatch | I wish it would tell me what in my deepEquals doesn't match | 22:38 |
| rogpeppe | hatch: i sometime use github.com/davecgh/go-spew/spew | 22:46 |
| hatch | that 404'd | 22:46 |
| hatch | although I'm not sure something for go would help me with js :) | 22:46 |
| rogpeppe | hatch: go get github.com/davecgh/go-spew/spew | 22:46 |
| rogpeppe | hatch: ah! | 22:47 |
| rogpeppe | hatch: i didn't know js had deepEquals | 22:47 |
| hatch | it's part of the assert lib | 22:47 |
| hatch | javascript has everything - it's just usually not included by default in the lang :) | 22:48 |
| hatch | thats why we have libraries | 22:48 |
| rogpeppe | if anyone's waiting on UnitInfo.Status and MachineInfo.Status, i've got a branch proposed that adds them | 22:48 |
| hatch | and lots of them :D | 22:48 |
| rogpeppe | https://codereview.appspot.com/8534043/ | 22:48 |
| rogpeppe | hatch: :-) | 22:48 |
| rogpeppe | i'm off now | 22:48 |
| rogpeppe | night all | 22:48 |
| hatch | night! | 22:49 |
| hatch | bcsaller: you were saying I needed to try and do some subordinate relationship? | 22:52 |
| hatch | got a second to bring me up to speed on what that was about? | 22:52 |
| bcsaller | sure | 22:52 |
| hatch | guichat? | 22:52 |
| bcsaller | joining | 22:53 |
| gary_poster | hatch ah, cool. easy fix? back later | 22:58 |
| hatch | gary_poster: it should actually have already been fixed (see merge-files) for some reason that is no longer being considered. Although rich mentioned that jc is removing that scroll view tomorrow anyways so it won't actually be an issue...but we should still find out why that file isn't being included me thinks. | 23:23 |
| hatch | bcsaller: review done | 23:41 |
| bcsaller | hatch: thank you | 23:42 |
| hatch | going to take a break - I'll bbl to try and hammer our more of the relations stuff | 23:43 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!