[02:10] slangasek: you'll need to talk to the people from distro about it === mmrazik is now known as mmrazik|afk [06:08] hey duflu! [06:10] didrocks: Good morning [06:12] duflu: FYI, the 0.9.9 wasn't that raring compatible, you missed 2 new features that were in and not in raring + a string break [06:12] duflu: has to finish really late to convince the release team to get it in on Friday :/ [06:13] didrocks: Hmm. The diff said I had a clean copy of lp:compiz/raring :/ ... [06:13] OK, please point out what's missing and I can fix it [06:14] duflu: well, it's in now, but from: https://lists.ubuntu.com/archives/raring-changes/2013-April/008744.html [06:14] duflu: there are: [06:14] * Showdesktop plugin: Wishlist/Feature-Request: Implement "Random" [06:14] movement direction option (LP: #1161343) [06:14] Launchpad bug 1161343 in Compiz "Showdesktop plugin: Wishlist/Feature-Request: Implement "Random" movement direction option" [Undecided,Fix committed] https://launchpad.net/bugs/1161343 [06:15] and * [needs-packaging] Wishlist: Missing plug-In: Freewins (Freely [06:15] Transformable Windows) (LP: #1012194) [06:15] Launchpad bug 1012194 in compiz (Ubuntu) "[needs-packaging] Wishlist: Missing plug-In: Freewins (Freely Transformable Windows) -> not shipped in any .install file in raring" [Wishlist,Fix released] https://launchpad.net/bugs/1012194 [06:15] (the second is a false listing I guess) [06:15] duflu: also, there is in those merge Show desktop -> Show Desktop [06:15] duflu: I think this is breaking translation, so should be reverted [06:16] didrocks: I'm confused. That stuff was never in lp:compiz/raring ... [06:16] duflu: no, it was in 0.9.9 [06:16] duflu: we landed /raring in raring [06:16] I didn't go missing. It just moved to lp:compiz/0.9.10 [06:16] and you wanted us to land 0.9.9 [06:16] so, the content of 0.9.9 needed to be raring compatible [06:17] what I asked and you told me yes before I moved to that branch [06:20] didrocks: hi, wrt bug #763148, how do you want this merge proposal for 0.9.9? Smash everything into a single cherry-pick commit? [06:20] bug 763148 in compiz (Ubuntu) "Adding/Removing an external monitor causes open windows to move to another workspace" [Medium,In progress] https://launchpad.net/bugs/763148 [06:21] slangasek: hey, still awake? ;) yeah, a single commit is fine, you can just reference the other one in lp:compiz if you wish in the comment [06:24] didrocks: ok, cool [07:36] Saviq: good morning [07:36] mzanetti, hey [07:36] Saviq: https://code.launchpad.net/~mzanetti/unity/more-stats/+merge/157441 [07:36] :D [07:48] mzanetti: why this [07:48] ? [07:48] -if(buildtype_lower MATCHES coverage) [07:48] +IF(CMAKE_BUILD_TYPE MATCHES [cC][oO][vV][eE][rR][aA][gG][eE]) [07:48] tsdgeos, 'cause we're lowering the build type? [07:48] Saviq: read the +/. [07:48] +/- [07:48] Saviq: that was working previously too [07:49] tsdgeos, before it matched cOvErAgE, too [07:49] tsdgeos: because all other projects use it this way and our jenkins hooks use this string to identify if a project supports coverage [07:49] tsdgeos, I can't see nothing wrong with that? [07:49] it's making something more complex for no reason? [07:49] tsdgeos, [07:50] ug [07:50] tsdgeos: you think I should change the jenkins hook instead? that would be possible too. I opted for this for consitency with apps [07:50] mzanetti, no [07:50] what's wrong with "if(buildtype_lower MATCHES coverage)"? [07:50] mzanetti, that will work ^ [07:50] * Saviq has eyes problems [07:50] are you guys getting my messages? [07:50] mzanetti, yes [07:50] we are [07:50] :) [07:50] mzanetti, we have the "buildtype_lower" var [07:50] mzanetti, that's CMAKE_BUILD_TYPE.toLower() [07:51] Saviq: yeah... as I said... I either revert this change and change our jenkins hooks [07:51] mzanetti, and the empty endif() is "new style" === alan_g is now known as alan_g|afk [07:51] mzanetti, why would you change it? [07:51] dude [07:51] mzanetti, there's no need to change? [07:51] because all other projects use it this way and our jenkins hooks [07:51] cOvErAgE is properly lowercased to coverage, no? [07:51] copy paste not working either [07:52] mzanetti, or do you just mean for the sake of consistency? [07:52] yes [07:52] Saviq: ^ [07:52] Saviq: I can revert the change here and change the jenkins hooks [07:52] mzanetti, then yeah, the "new way" is to lowercase it [07:52] and match the exact string [07:52] ok [07:54] sorry... :D [07:58] mzanetti, tsdgeos, does make testIndicatorRow work for you? [07:58] * mzanetti checks [07:58] it did on friday [07:59] tsdgeos, but it's using ChewieUI directly [07:59] and it doesn't now [07:59] * tsdgeos scratches head [08:00] no... doesn't work [08:01] note for myself: we need to enable the qmluitests in CI asap... [08:02] yes we do :D [08:04] Saviq: it's not using chewieui [08:04] dednick, actually, wanted to ask here [08:04] tsdgeos, yeah, I see [08:04] it's using a fake one [08:04] maybe the problem it's not finding it [08:04] ? [08:04] dednick, do the IndicatorRow tests work for you? [08:07] ahh, i think i see the problem [08:08] it has to do with the move of builddir != srcdir [08:08] dednick, yes [08:08] dednick, ^ [08:08] yesser [08:08] i'll propose a MR [08:08] tsdgeos, cheers [08:09] dednick, tsdgeos is on it [08:09] ok === alan_g|afk is now known as alan_g [08:10] if you're testing using qmltestrunner, you need to include the test dir import path. But it should be working using make qmluitests. [08:13] Saviq: dednick: https://code.launchpad.net/~aacid/unity/make_indicator_row_test_work_again/+merge/157600 [08:13] Saviq: tsdgeos: updated https://code.launchpad.net/~mzanetti/unity/more-stats/+merge/157441 [08:13] Saviq: tsdgeos: requires this now too: https://code.launchpad.net/~mzanetti/pbuilderjenkins/update-some-hook/+merge/157599 [08:14] mzanetti, hmm, the grep won't match, will it? [08:15] tsdgeos: i think the hud may need the same? [08:15] dednick: nope [08:15] Saviq: I changed buildtype_lower to cmake_build_type_lower to at least allow a little bit of consistency [08:15] dednick: hud is actually compiling things [08:15] mzanetti, yeah, I see [08:15] ah [08:15] mzanetti, nice hack, btw :D [08:15] Saviq: for what? [08:15] mzanetti, the hook [08:16] mzanetti, the grep through CMakeLists.txt ;) [08:16] Saviq: that was here before my :) I think mmrazik created those initially [08:16] mzanetti, is there autolanding for lp:pbuilderjenkins ? [08:17] mzanetti, yeah, I'm not saying it's yours, don't you worry ;) [08:17] Saviq: autolanding yes. but I need to manually upgrade the package on all jenkins nodes [08:17] mzanetti, but that's why we didn't understand the need to update the hook ;) [08:17] Saviq: hehe, yeah [08:20] Saviq, tsdgeos: ah, my cmake files were old. hadn't updated to use builddir. wihch is why it was working for me. All fixed. [08:25] does anyone know why when i load an item in the testrunner it's smaller thatn the size set? loading with qmlscene sets the correct size. [08:30] dednick, did you set the size on the top level component? [08:30] Saviq: yes [08:31] dednick, hum, not sure, qmltestrunner is just a QQuickView as any other... [08:35] Saviq: seems to happen with all the qmluitests [08:35] dednick: Saviq: yep... known bug [08:36] dednick: should be fixed in Qt 5.1 [08:36] dednick: shouldn't cause issues with tests though... [08:37] Saviq: there's no reason you didn't top-approve except the order of merging, right? [08:37] mzanetti, I usually wait for Jenkins to do its thing [08:37] mzanetti: ok. thanks. [08:37] Saviq: ack [08:38] which is now... all fine... I'll top-approve [08:39] mzanetti, beat me to it :P [08:41] Saviq: sorry... I forget that every time... may I ask you to approve this as mmrazik is ooo today? https://code.launchpad.net/~mzanetti/pbuilderjenkins/update-some-hook/+merge/157601 [08:42] mzanetti, sure [08:44] mzanetti: just wondering, what's missing for the qmluitests integration thingie? [08:44] tsdgeos: the MP with the coverage thingie from before [08:45] so almost there? [08:45] tsdgeos: yep [08:45] cool :) [08:49] mzanetti, approved [08:49] cheers [08:51] Cimi: ping [08:51] tsdgeos, pong [08:51] Cimi: if running tst_ResponsiveFlowView.qml with qmlscene can you open the comboboxes? [08:52] tsdgeos, mmm not if Iremember [08:52] may be that it used to work for the other test? [08:53] i do remember playing with that manually [08:53] was i dreaming [08:53] ? [08:53] tsdgeos, try responsivegridview [08:53] doesn't work either [08:54] maybe the ui toolkit changed?¿ [08:55] tsdgeos, asksdkguys? [08:55] sure [08:55] what i am asking here is [08:56] it should open, right? [08:56] do you see any reason it should not? [08:56] * Cimi reads code [09:01] need to reboot, back in a sec [09:04] Saviq: hehe... that was too easy after all: https://code.launchpad.net/~mzanetti/unity/dont-halt-on-test-failure/+merge/157607 [09:07] mzanetti, orly? [09:07] mzanetti, `make check` doesn't need it [09:07] mzanetti, it only runs make test [09:08] oh right... we changed that... lemme check [09:10] Saviq: updated [09:15] mzanetti, you should update runtests for the move from in-tree builds to builddir [09:15] Saviq: where is builddir? [09:15] mzanetti, "builddir" [09:15] mzanetti, if you go ./build [09:16] mzanetti, it will build in builddir now, out of tree [09:16] Saviq: runtests supports in-source and builddirs in the root [09:16] e.g. source-dir at .. [09:16] mzanetti, ah, so ../runtests.sh, got it [09:17] Saviq: yeah... jenkins builds in a subdir too... so thats supported already [09:17] Saviq: the only thing not supported is build dirs totally outside the source... that would require passing a parameter for the src-dir I guess [09:18] mzanetti, we could always just .cmake it [09:18] mzanetti, but it's fine for now === mmrazik is now known as mmrazik|afk [09:35] tsdgeos, it's weird [09:35] tsdgeos, I'm trying the one in the ubuntu-ui-toolkit demos [09:35] tsdgeos, not sure how is it supposed to behave [09:35] i pinged zsombi in #ubuntu-touch and got half an answer :-/ [09:36] ASSERT failure in QList::at: "index out of range", file /home/tsdgeos/qt5/build/qtbase/include/QtCore/../../../../qtbase/src/corelib/tools/qlist.h, line 452 [09:36] wops :D [09:42] Hey guys, still getting build errors with my branch, Jenkin's reports a success though. https://pastebin.canonical.com/88624/ [09:43] nic-doffay: that's build -s ? [09:43] It is tsdgeos [09:44] nic-doffay: is it a clean build? [09:45] It was tsdgeos [09:45] nic-doffay: can you try build -s -c just to make sure? [09:45] sure, I'll let you know when it's completed. [09:47] nic-doffay: you have the version of build_unity that contains stuff like [09:47] HUD_REV=365 [09:47] right? [09:47] I'm not sure tsdgeos [09:48] nic-doffay: open the file and check the first lines of the file [09:48] tsdgeos, that's the version I have. [09:49] nic-doffay: you were on quantal? [09:49] tsdgeos, correct [09:49] maybe there's a linking issue in the hud code in quantal [09:53] tsdgeos, why would it affect quantal but not raring? [09:53] it might [09:53] pulse libraries may have different libs linked in or whatnot [09:55] Who should I talk to about this? [09:56] tsdgeos, ^ [09:57] nic-doffay: try pete-woods [09:57] or tedg when he wakes up [09:57] Thanks tsdgeos, will do. [09:57] nic-doffay: otoh maybe you want to update to raring? [09:58] How stable is it atm tsdgeos ? [09:58] works fine here [09:58] Cool, I'll just update then. [10:24] on Tile.qml, there's a GridView.onRemove, what's that? [10:27] Saviq: about the carousel-listview crash, at the moment i'm doing the evil eyes at dee-qt, can't prove is its fault (yet) but it's doing nasty stuff afaics [10:28] tsdgeos, where is it crashing? [10:28] Cimi: deep inside modelview code in Qt [10:28] Cimi, http://qt-project.org/doc/qt-5.0/qtquick/qml-qtquick2-gridview.html#onRemove-signal [10:29] Saviq, yes but why inside tile? [10:29] Saviq, it is catched if tile has a gridview as direct parent? [10:30] Cimi, not a direct one, any parent [10:30] mmm [10:30] Cimi, but indeed it should probably be in http://qt-project.org/doc/qt-5.0/qtquick/qml-qtquick2-gridview.html#remove-prop instead [10:31] Cimi, Gerry should be able to comment on why he did put it in Tile [10:32] Saviq, also, line 86 of that file, it changes the GridView.delayRemove property of AbstractButton? [10:32] ok [10:33] Cimi, GridView is an attached property of GridView delegates [10:33] Cimi, so yeah, scratch my "any parent" comment [10:33] Saviq, what will happen if I use Tile outside a gridview? [10:33] Cimi, so changing GridView.delayRemove on root means it will change delayRemove on that [10:33] Cimi, http://qt-project.org/doc/qt-5.0/qtquick/qml-qtquick2-gridview.html#delayRemove-prop [10:34] just warnings I suppose [10:34] Cimi, it will complain about missing GridView [10:34] ok [10:34] is that ok to accept? [10:34] Cimi, the Tiles were only ever supposed to be GridView delegates [10:35] Cimi, so sounds like yeah, it's fine === alan_g is now known as alan_g|tea [10:42] tsdgeos, about https://code.launchpad.net/~michihenning/unity/declspec/+merge/157578/comments/345009 [10:42] yep? [10:42] tsdgeos, we'll be moving/splitting the shell under "src/shell", "qml/shell" folders [10:43] tsdgeos, and the rename I believe is to prevent naming confusion [10:43] ah [10:43] makes sense [10:43] tsdgeos, so yeah, all source goes under src/ [10:43] all (some? we'll have to see) QML+JS goes under qml/ [10:44] public headers go under include/ [10:44] etc. [10:45] ok === alan_g|tea is now known as alan_g [10:48] MacSlow, ping [10:49] Il'l modify the jenkins ci job now.. please ping me if you encounter unexpected failures [10:51] mzanetti, yay [10:54] Saviq, pong === MacSlow is now known as MacSlow|lunch [11:15] qt 5.1 alpha out [11:30] tsdgeos, did we change something to the build system? [11:31] tsdgeos, after doing build in root of unity phablet [11:31] and I go to qmluitests, run make test or make testTile (working on Tile), it complains of no rule or target [11:31] Cimi: yes, we changed some things [11:31] Cimi: we have a builddir now [11:31] cd builddir [11:31] and make test there [11:32] mm where? [11:32] in builddir root? [11:32] yep [11:32] tsdgeos, how to run qmluitests? [11:32] same way [11:32] make qmluitests [11:32] in the builddir [11:41] mzanetti: wrong link https://code.launchpad.net/~unity-team/unity/phablet.test_responsiveflowview/+merge/157343/comments/345112 [11:42] mzanetti: still contains s-jenkins on it [11:42] question. I am in Tile.qml and I need to test the animation that happens when I remove a tile [11:42] what I do is getting the item before removing the element (var ItemRemoved = gridView.itemAt(units.gu(4), units.gu(4)) [11:43] then I do model.remove(0,1) (I can see the element removing with the animation) [11:43] but the line after that is tryCompare(itemRemoved, "opacity", 0) which is undefined because the item was remvoed [11:43] *removed [11:44] what's the best way to deal with that? [11:54] tsdgeos: oops. my IRC client was detached... anyways, its fixed now [11:55] anyone a small test review? https://code.launchpad.net/~mzanetti/unity/phablet-tile-tests/+merge/157630 [12:02] dandrader, you around? [12:08] mzanetti, I was testing Tile as well, do you know how to test the gredview remove? [12:08] Cimi: in a meeting right now... [12:08] ok [12:08] I'll ping you when done [12:18] didrocks: hi! I still see quite a lot of failures on the generic autopilot job, I'll be looking into those now === MacSlow|lunch is now known as MacSlow [12:27] sil2100: are we parallelizing the compiz ci builds ? [12:31] smspillaz: now I have no idea ;/ Maybe fginther` would know [12:31] fginther`: ping, you around? === alan_g is now known as alan_g|lunch [12:47] Note to developers: Unity doesn't seem to handle a portrait display too well - when changing desktops the "splash screen" that shows consists of landscaped screens, in Appearances / background screen the display is in landscape mode, etc [12:51] Walther: file a bug against compiz stating that the wall plugin doesn't handle the portrait case [12:51] (for the live previews) === _salem is now known as salem_ [12:52] smspillaz: thanks for the specifics [12:55] sil2100: excellent! thanks. I think it's the 100scopes jobs you are talking about [13:03] Cimi: hey [13:07] sil2100: hey, so just do double check [13:08] sil2100: if you do something like ctest -D ExperimentalMemCheck -R .Xorg. all those tests that are being marked as failed in valgrind in CI pass locally right ? [13:08] * cyphermox publishes indicators to raring [13:08] cyphermox: \o/ [13:10] smspillaz: let me double check that - but I was doing make test before with integration tests enabled and all was green [13:10] There is a condition I know about which might cause them to fail under valgrind [13:10] but I haven't seen it recently [13:11] cyphermox: hey... any news regarding the autopilot-qt tests? we would need to add some more tests but would like to get that one merged first [13:12] mzanetti: remind me what you mean by that? [13:12] cyphermox: https://code.launchpad.net/~mzanetti/autopilot-qt/add-tests/+merge/153695 [13:14] mzanetti: ok, just waiting for ubuntu-release to review [13:14] (approving the bug) [13:15] cyphermox, thanks for publishing indicators! [13:15] np [13:18] Saviq: https://jenkins.qa.ubuntu.com/job/unity-phablet-ci/ [13:18] isn't it beautiful? [13:18] mzanetti, I love our test count :D [13:18] kgunn, ^ [13:19] only 250 to go until we overtake Mir :D [13:19] * smspillaz takes his 1414 tests and goes home [13:19] #humblebrag [13:19] mzanetti: Saviq ...that feels pretty good to see :) [13:19] smspillaz: I got one failure when running the tests with the command you specified, let me paste it to you on priv [13:24] Saviq: ah you have 666 then :) [13:24] davmor2, no, not really ;) [13:24] Saviq: that or 1337 [13:24] davmor2, we just went up from ~20 to ~160 in one go :D [13:29] sil2100, smspillaz, compiz-ci should be built in parallel [13:31] fginther`: thanks! [13:35] Saviq: Ha nice :) === alan_g|lunch is now known as alan_g [13:49] Saviq: I just came across all those small files like VideosFilterGrid, VideosCarousel [13:49] Saviq: they basically don't add functionality in respect to FilterGrid, Carousel etc [13:49] mzanetti, yeah, they just use it [13:49] didrocks: so anyway, currently the generic autopilot job is for 100scopes, yes? Is it high-priority to get those fixed, or is it pushed back now that 100scopes didn't go in? [13:49] Saviq: however, if we're clever we _could_ run the FilterGrid tests ON them and see if it still works [13:49] mzanetti, true [13:50] sil2100: no, the generic autopilot job is… generic [13:50] sil2100: so used for oif, indicators, unity, both raring and head, as well as 100scopes [13:50] didrocks: ah, so it varies between builds [13:50] sil2100:right ;) [13:50] Good to know *notes it down* [13:50] sil2100: you can look at the parameters [13:50] sil2100: you have the job, release, ppa parameters specified [13:50] didrocks: since I saw that 100scopes was the latest, though the failures are more generic [13:51] i.e. the latest build was from 100scopes [13:51] sil2100: yep, maybe we should remerge first unity against it [13:51] dednick: do you have some time for that? unity trunk latest rev has good results… ^ [13:53] didrocks: sure. [13:53] thanks :) [13:53] sil2100: so, let's look tomorrow's result with those latest tests === dandrader is now known as dandrader|afk [13:55] didrocks: r3283 ? [13:55] mzanetti, do you know how to test the gridview remove for the tile? [13:56] mzanetti, there is an animation [13:56] dednick: exactly :) [13:57] Cimi: create a GridView and call model.add() and remove() on its model [13:57] Saviq: do you have a second to confirm you can reproduce the crash on my simple test? [13:57] didrocks, dednick: some failures will go away since lp:unity had the dash-overlay-button fixes reverted [13:57] tsdgeos, hit me [13:57] Which was causing some failures (the dash maximized bug) [13:57] sil2100: yeah, that's my guess, so let's wait for tomorrow :) [13:57] Cimi: and use a tryCompare for the SequentialAnimation in there for finish [13:57] mzanetti, yes I did that [13:57] mzanetti, but it removes the item [13:57] sil2100: but latest time we synced that with trunk, it was a release, not a random # [13:58] mzanetti, so I don't have the item anymore [13:58] mzanetti, to test the funcion [13:58] Ok ;) [13:58] Let's see where it will lead us then [13:58] Saviq: https://chinstrap.canonical.com/~aacid/qml_model_crasher.tar.gz [13:58] Cimi: right... [13:58] mzanetti, http://paste.ubuntu.com/5689471/ [13:58] sil2100, hey, do you know why https://code.launchpad.net/~seb128/autopilot/correct-majhongg-name/+merge/157372 didn't get merged, didrocks approved it on friday [13:58] mzanetti, line 6 fails [13:58] Cimi: you could make sure that the item does not get deleted immediately, but only after the time the animation takes [13:59] mzanetti, what? [13:59] seb128: I think fginther` didnt' redeploy head for qa with it? [13:59] mzanetti, I believe fakeModel.remove takes the time for the animation also [13:59] tsdgeos, yup [13:59] didrocks, oh, ok [13:59] Cimi: remove() blocks? no... [14:00] * Cimi puts a console.log [14:00] Cimi: anyways... not really sure how much sense it makes to test this... [14:00] mzanetti, you're right [14:00] mzanetti, ok [14:00] I'll just approve yours then [14:00] Saviq: so that's it, i can't find anything you could blame in that code, so it's a Qt bug, not that it matters much, still crashing :D [14:00] Cimi: sorry again for the collision... :/ [14:01] mzanetti, no worries, I was losing time ttrying to test this :) [14:01] mzanetti, you think we should add // for testing [14:02] mzanetti, next to objectName = "" in the Tile.qml file? [14:02] Cimi: hmm... I think objectNames are in 99% of the cases used for testing [14:02] ok [14:02] Saviq: the trick is the double remove and using the listView.count as part of the delegate [14:02] Cimi: besides, if you remove it Jenkins will tell you that it was needed for testing [14:03] seb128: I know about it, I was poking fginther` about it just a few minutes ago [14:03] Saviq: so what's the next step, want me to try finding a fix or just report the bug and walk away? [14:03] seb128: and he's on it right now [14:03] sil2100, ok [14:03] sil2100, shame that you dupped work there :-( === fginther` is now known as fginther [14:03] seb128: that's just like a one liner ;p Still have that branch there, need to remove it [14:04] tsdgeos, report, try and fix, please [14:04] oka [14:04] tsdgeos, you decide when you've had enough [14:04] :D [14:04] Cimi: you had tests for DashBar, right? [14:04] mzanetti, yes [14:04] seb128: so no problem ;) [14:05] mzanetti, but we're waiting SDK [14:05] Cimi: ah ok... was just wondering why stats still say no tests for it [14:05] * fginther growns [14:05] Cimi: do you have a link for the MP? [14:05] fginther: hey ho [14:06] * fginther and groan as well [14:06] mzanetti, https://code.launchpad.net/~unity-team/unity/phablet.dashBar_bottomswipe/+merge/150847 [14:08] didrocks, the "to_transition" bit is throwing off the auto-merger tools [14:09] * fginther starts work on a fix [14:09]