thumperfwereade_: around?00:01
fwereade_thumper, yeah, kinda00:02
thumperfwereade_: got time for a 5 min chat?00:02
thumperfwereade_: got a few quick questions00:02
fwereade_thumper, sure, would you start it please?00:02
thumperfwereade_: https://plus.google.com/hangouts/_/096d99c30b8876a0dec1471a202468258e010074?authuser=0&hl=en00:03
fwereade_thumper, hmm: type StringSet map[string]bool00:13
fwereade_thumper, then you can just return StringSet{}00:13
thumperthat doesn't give enough type hiding IMO00:13
thumperit exposes the map functions that I don't want there00:13
fwereade_thumper, fair enough00:14
fwereade_thumper, just a thought :)00:14
* thumper afk00:16
mrammdavecheney: just got back00:59
bigjoolstrying to keep up with core changes in the maas branch is hard - what do we need  to fix errors about missing MongoURL on machine config?03:13
jtvHi there — anyone else getting this test failure for a nonexistent function, environs.Setenv()?03:43
jtvenvirons/tools_test.go:344: undefined: environs.Setenv03:44
thumperI know what that is...03:46
thumperbut I don't get that error03:46
thumperSetenv is "exported" in export_test.go (I think)03:46
bigjoolsthumper: I get it too FWIW03:49
thumperhmm... I haven't tested with latest trunk03:49
thumperjust yesterday :)03:49
thumpervar Setenv = setenv03:50
jtvYes, the theory works.  Having some trouble with the practice.03:51
* thumper had tests pass03:52
* thumper pulls latest03:52
thumperand retries03:52
thumperok, it passes for me on raring with tip of trunk03:53
thumperjtv: are you sure you are using tip? and have no changes?03:53
jtvI'm not sure of anything, really.  I'll see if I can run it in another configuration.03:54
jtvNo change so far...03:55
jtvAh!  Got it.03:55
jtvIt passes when I run "go test launchpad.net/juju-core/environs"03:55
jtv—not when I run "go test ./environs"03:56
jtvSo it must be the softlinking again.03:56
jtvOne test failure because of that difference in all of environs nicely hits the bitter spot: not enough to make you think there's a systemic problem with the way you're running the tests, enough to make you stop and look for problems in the actual code.03:59
bigjoolsjtv: what do you mean by softlinking?03:59
jtvMy $GOPATH/src/launchpad.net/juju-core is softlinked to a branch.04:00
davecheneyjtv: that'll screw you every time04:09
jtvYes, especially with the feature branch now.  Can't really afford to colocate such different worlds.04:09
bigjoolsjtv: it's not that then, I don't do that04:18
bigjoolsjtv: I am using native colo, works very well04:19
arosalesdavecheney, let me know if you still hit the 20 compute limit on hp cloud04:38
davecheneyarosales: just saw your mail04:38
davecheneywill try again04:38
arosalesdavecheney, the 200 limit bump should apply to the juju-scale-test project04:38
arosalesbut as I learned things can be different than expected :-)04:39
davecheneythird times' a charm04:39
thumperdavecheney: []string(nil) is a nil slice? whereas []string{} is an empty slice?04:40
thumperok, my tests pass now04:42
thumperif you take params(values... string)04:42
thumperand don't pass anything in04:42
thumperyou get a nil slice, not an empty slice04:42
davecheneynormally this doesn't matter04:43
davecheneybut gocheck cares04:43
arosalesdavecheney, :-)04:44
davecheneym_3: ping04:46
* thumper proposes the hacking for the day05:21
* davecheney listens05:22
davecheneythumper: i'll LGTM your proposal if yuou rename trivial to utils05:22
davecheneyor util05:22
thumperI didn't really want to do that until we agreed on a name :-|05:23
thumperbut I do want to rename trivial05:23
davecheneythat's my deal, take it or leave it05:23
thumperor kill it and move the content05:23
thumperI can wait05:24
davecheneyi'll also accept that05:24
thumperI'll propose another branch first thing monday to move / change the trivial package to util(s)05:24
thumperdavecheney: I wanted a set to deal with the bootstrap fake series05:25
thumperwhich is now the top of the pipeline05:25
davecheneywhat is the CL again ?05:25
thumperfor what?05:26
thumperit seems you can't add a prereq for something already proposed05:26
davecheneythumper: nope05:26
thumperoh well, friday calls, and warsaw's second law says time to stop :)05:26
davecheneyfucking prereqs05:27
thumperdavecheney: have a good weekend05:27
davecheneyyou too mate05:28
rogpeppedavecheney: hiya06:04
rogpeppedavecheney: i don't want to rename trivial to utils. we deliberately decided against utils as a name.06:05
davecheneyi understand06:06
davecheneyi still side with tim06:06
davecheneythe only thing worse than having a utils package, is having two of them06:06
rogpeppedavecheney: i'm ok with a utils *directory*06:30
rogpeppedavecheney: which is what he's actually done06:31
rogpeppedavecheney: so utils/trivial, utils/cloudinit, etc06:31
davecheneythat is gold plating it06:31
rogpeppedavecheney: i don't think so06:31
rogpeppedavecheney: the problem with a "utils" package is it becomes a huge grab-bag of random stuff06:32
rogpeppedavecheney: but that's not a problem if each thing is in its own package, and we just use the "utils" name to keep the root name space uncluttered06:32
rogpeppedavecheney: (see my recent comments on https://codereview.appspot.com/8672044/)06:33
davecheneyrogpeppe: i feel that encourages not one utils package, but a forrest of them06:33
rogpeppedavecheney: i think that's ok - each package can be small and simple and targetted to what it needs to do. i suggest reserving the name for leaf dependencies which could be as well implemented outside juju-core.06:34
rogpeppedavecheney: so nothing that imports juju-core/log, for example06:34
davecheneywe can have different opinions here06:35
rogpeppedavecheney: ping06:58
m_3davecheney: pong07:07
rogpeppem_3: are you around for a very brief chat?07:07
rogpeppem_3: i want to knock up a minimal version of the juju-wait tool and want to make sure i'm doing the right thing first07:08
m_3rogpeppe: really can't atm... about to board a plane07:08
rogpeppem_3: :-) ok!07:08
m_3yikes... lemme see07:09
rogpeppem_3: short story: juju-wait (machine|unit)07:09
rogpeppem_3: waits for machine or unit to come into a stable state07:09
m_3yeah, sorry man... that's just too ambitious atm... I'm trying to see if we're past our account limit on hp in the few minutes before the flight07:09
rogpeppem_3: exits with non-zero if it ended in an error state07:09
rogpeppem_3: okeydokey07:10
m_3stable is one of "started, start-error, install-error" or the equiv?07:10
rogpeppem_3: yup07:10
rogpeppem_3: brings you to a state where you can query status and find out what's actually gone on.07:11
m_3rogpeppe: and then it'd be nice to actually get the error state easily from there07:11
m_3rogpeppe: ack right07:11
rogpeppem_3: ok, i'll print the error state07:12
rogpeppem_3: or perhaps i'll always print the final state07:12
m_3we can filter status to get the state of the thing we're waiting on, but filters would be cool again at some point07:12
m_3it'd be great to also get the final state07:12
m_3but shell exit codes are important07:13
rogpeppem_3: agreed. i'm wanting this to take less than an hour though :-)07:13
m_3ok, yeah, and we can totally refine over time07:13
m_3just being able to wait for a set of states to be reached07:13
m_3that'll rock07:13
rogpeppem_3: juju-wait machine [state....] ?07:13
rogpeppem_3: waits for any of the given states to be reached?07:14
m_3by service instead?07:14
rogpeppem_3: ah...07:14
rogpeppem_3: that's more interesting. wait for *all* units in the service to reach the given state?07:14
m_3juju wait mysql "started | start-error"07:15
m_3or perhaps just a unit07:15
rogpeppem_3: just a unit has more obvious semantics07:15
m_3that's all that's needed right now... `juju wait mysql/0 --state=...`07:15
m_3something along those lines07:16
rogpeppem_3: juju wait mysql/0 'started|.*error' ?07:17
rogpeppem_3: i.e. a regexp for the acceptable stages07:17
m_3davecheney: I started 30 instances from ubuntu@ might not have connectivity to wait them out and shut them down... please check on it in an hour or so if you can07:17
m_3davecheney: shut em down either way... then you can play if the numbers are up07:18
m_3rogpeppe: dude, that syntax would rock07:18
rogpeppem_3: cool. that's also more trivial to do.07:18
m_3rogpeppe: that'd be great... probably all we'd need07:18
rogpeppem_3: wonderful, just what i want hear07:19
rogpeppem_3: just units for the time being, no machines or other things?07:19
m_3rogpeppe: right07:19
rogpeppem_3: great07:19
rogpeppem_3: thanks - that's very helpful!07:19
m_3rogpeppe: prob not worth the time to work up any other logical expressions of state ( ! & | )07:20
m_3rogpeppe: regexps'll be awesome07:20
rogpeppem_3: juju wait -v mysql/0 '.*error'07:20
rogpeppem_3: wait for anything *but* the given regexp07:20
rogpeppem_3: analagous to grep -v07:20
m_3yup... but really we can add tha tlater07:21
rogpeppem_3: ok, cool07:21
m_3rogpeppe: thanks!07:21
davecheneym_3: hey07:42
davecheneyi was going to ask you about building that mongodb package07:42
davecheneybut I figured it out from your instruciotns07:42
dimiternrogpeppe, fwereade_: looking for a critical eye on the log deuglifying CL - now with JUJU: and prefixes removed - https://codereview.appspot.com/8674043/08:23
rogpeppedimitern: looking08:23
rogpeppedimitern: reviewed08:27
dimiternrogpeppe: cheers08:28
fwereade_dimitern, please drop all the JUJU: crap08:29
fwereade_dimitern, not just JUJU08:29
dimiternfwereade_: I did, didn't I?08:29
fwereade_dimitern, ERROR jujutest blah command failed: BAM!08:29
fwereade_dimitern, ERROR command failed: BAM!08:29
dimiternfwereade_: so rogpeppe is suggesting to drop the "command" from there, do you agree?08:30
dimiternfwereade_: but leave the command name08:30
fwereade_dimitern, not necessarily -- IMO that's out of scope08:30
fwereade_dimitern, no, drop the command name too please08:31
fwereade_dimitern, none of the JUJU:... stuff needs to exist08:31
dimiternrogpeppe: agreed?08:31
fwereade_dimitern, rogpeppe: "command failed: %v" is a useful final thing to note, right?08:31
dimiternfwereade_: well, which command was that?08:32
fwereade_dimitern, the one you just ran08:32
rogpeppefwereade_: i suppose so, although the command will print that anyway, i suppose. hmm, but maybe not to the log file08:32
fwereade_dimitern, I am not interested in catering to goldfishes ;p08:32
rogpeppefwereade_: it was just the redundancy of "jujutest foo" and "command"08:32
rogpeppefwereade_: FWIW i think that the final message printed by a failing juju command *should* be prefixed by the name of the command08:33
rogpeppefwereade_: but not necessarily the log message08:33
fwereade_rogpeppe, and honestly I am not *very* interested in logging the CLI stuff -- I'd hope we'd have an Infof in supercommand, maybe, saying what we're running, and leave it at that08:33
dimiternok, I'll drop both the "command" and the command name from the log message08:34
fwereade_rogpeppe, doesn't sound unreasonable08:34
rogpeppefwereade_: yeah. the logging stuff is interesting from a CLI p.o.v. because it's what gets printed for --verbose/debug08:34
fwereade_dimitern, please just stick to the task as given ;p08:34
rogpeppedimitern: if you drop the command name, you can leave "command"08:34
fwereade_rogpeppe, yeh, I see the job of log in a CLI context as feedback not logging IYSWIM08:34
fwereade_rogpeppe, dimitern: messing with "command failed" is out of scope08:35
fwereade_rogpeppe, dimitern: we discussed this on the lists and crafted it carefully so as not to piss away too much time08:35
rogpeppefwereade_: +108:35
dimiternfwereade_, rogpeppe: so finally, leave just "ERROR command failed: xyz" instead of "ERROR jujutest blah command failed: xyz" ?08:36
rogpeppedimitern: yup08:36
dimiternok, submitting with that change then08:42
dimiternfwereade_: I need a crash course talk for the constraints implementation for openstack :)08:48
* TheMue happily discovered that the endpoints in relation keys are sorted, so the tests are not only "green by accident".08:52
dimiternrogpeppe: what happened yesterday with the SetProvisioned() issue? you said you found the problem, but didn't share08:58
rogpeppedimitern: i was running into the incompatible tools issue08:58
rogpeppedimitern: i was using an older client with uploaded tools08:59
dimiternrogpeppe: so your setup was flawed, not the code?08:59
rogpeppedimitern: so it was creating the Machine in mongo without the new fields08:59
rogpeppedimitern: so the assertion failed08:59
rogpeppedimitern: yes, but...08:59
dimiternrogpeppe: right! I was beginning to get concerned08:59
rogpeppedimitern: it was good because it made me aware of a new and quite subtle potential compatibility issue to watch out for09:00
dimiternrogpeppe: incompatible schema? it's not new i think09:00
rogpeppefwereade_: have you seen this bug, BTW? https://bugs.launchpad.net/juju-core/+bug/116815409:00
rogpeppedimitern: it's *how* it's incompatible that's interesting09:01
rogpeppedimitern: i had assumed that we could add fields without necessarily being incompatible09:01
dimiternrogpeppe: ah, right :)09:01
rogpeppedimitern: and that can be true, but not if we assume that they start life as set.09:02
dimiternrogpeppe: this opens a potentially vast can of worms in the code, where we need to care about fields not being there, when they should be, all kinds of failing asserts..09:03
dimiternrogpeppe: and i suppose that was the reason for the log file being so huge after 2h?09:03
rogpeppedimitern: i think it's only a problem when we're asserting that something is an empty string09:03
rogpeppedimitern: yeah, the provisioner was constantly falling over and being restarted09:04
dimiternrogpeppe: how about asserting on non-empty field, which isn't there?09:05
rogpeppedimitern: i don't think that's a problem09:05
dimiternrogpeppe: cool09:05
rogpeppedimitern: the assertion will fail as it did in our example yesterday09:05
dimiternrogpeppe: but it's essentially the same failure as if the field was there, but with a different value09:06
rogpeppedimitern: yes, which is fine. if we assert that field=="value" then we don't care about the difference between field=="" and field==nil.09:07
rogpeppefwereade_: you might've missed my comment: have you seen this bug? https://bugs.launchpad.net/juju-core/+bug/116815409:14
rogpeppefwereade_: it's a bit concerning, but may be trivial to fix09:14
fwereade_rogpeppe, responded, I'm not certain there's a juju problem there so much as a charm problem09:15
dimiternfwereade_: and how about a quick chat about openstack constraints?09:17
rogpeppefwereade_: ah, interesting. what charm hooks need to run before the unit can be destroyed?09:17
fwereade_rogpeppe, broadly speaking, once it starts it expects to pass through install, config-changed, start before top and suicide09:18
rogpeppefwereade_: ah, i'd forgotten there was a stop hook09:18
fwereade_dimitern, sure09:19
fwereade_dimitern, would you start a hangout please?09:19
rogpeppefwereade_: yeah, i think that if install or start fail, we should allow unit removal without resolving the error.09:20
rogpeppefwereade_: i wonder if actually we should allow the stop hook to run regardless.09:21
dimiternfwereade_: https://plus.google.com/hangouts/_/143d8b05982bc269466e8bb2402d68e8d0018523?authuser=0&hl=en09:21
rogpeppefwereade_: the reason for the charm failing is that it tried to do "apt-get install -y --force-yes python-shell-toolbox" which failed (error: Unable to locate package python-shell-toolbox)09:24
fwereade_rogpeppe, sorry, could have sworn I sent a reply09:57
rogpeppefwereade_: a reply to the bug? you did.09:58
fwereade_rogpeppe, that hook failure sounds like a charm problem rather than a juju problem09:58
rogpeppefwereade_: yup09:58
fwereade_rogpeppe, ok, so I'm not too bothered there09:58
rogpeppefwereade_: but i think it should be possible to destroy a failed unit09:58
fwereade_rogpeppe, unless we're deploying it on the wrong series or something and killing it that way?09:58
rogpeppefwereade_: because calling "resolved" on it might lead to worse problems09:59
fwereade_rogpeppe, like what?09:59
rogpeppefwereade_: like subsequent hooks fail or behave badly because the previous hook has failed but been "resolved" without any actual resolution10:00
fwereade_rogpeppe, then if you must you can painstakingly `resolved` your way through it to destruction10:00
rogpeppefwereade_: also, if i call destroy on a unit that's in an error state, i think it's reasonable to assume that i want to kill it, not let it carry on.10:00
rogpeppefwereade_: yeah, i think that's wrong - lots of work for no gain.10:01
fwereade_rogpeppe, STRONGLY disagree10:01
fwereade_rogpeppe, you might want to kill it but you still have to resolve it and walk it through an orderly shutdown10:01
fwereade_rogpeppe, fancy features for skipping that need careful thought10:01
rogpeppefwereade_: this is particularly true for install/start hook failures10:02
rogpeppefwereade_: i don't mind too much about later failures10:02
fwereade_rogpeppe, so long as there's a clear boundary I'm ok extending the window10:03
rogpeppefwereade_: if a charm has failed to install, i want to be able to blow it away, and i can't see any particular reason why we shouldn't allow that10:03
fwereade_rogpeppe, but not now10:03
fwereade_rogpeppe, there is a path to resolution10:03
fwereade_rogpeppe, it may suck but it exists10:03
rogpeppefwereade_: fair enough10:03
* fwereade_ bbiab10:05
rvbafwereade_: we've fixed most of the problems you pointed out… we're landing the MAAS provider feature branch right now.10:05
jtvAll the important ones are fixed.10:05
jtvfwereade_: feature branch has landed...  see the MP for another note, on your comment #2 — if it's weird, it's EC2's kind of weirdness so I don't think it needs changing right now.10:12
* dimitern bbiab10:23
* TheMue loves merging conflicts *gnarf*10:28
fwereade_rogpeppe, ping11:04
rogpeppefwereade_: pong11:04
fwereade_            assertNothingHappens(c, upgraderDone)11:04
fwereade_rogpeppe, in jujud/upgrader_test.go11:04
rogpeppefwereade_: i'm just fixing that exact code11:04
rogpeppefwereade_: it's crack11:04
fwereade_rogpeppe, fucking tell me about it11:04
rogpeppefwereade_: it's nearly done11:04
rogpeppefwereade_: it was from before i knew that interlinked table-driven tests were an anti-pattern11:05
fwereade_rogpeppe, I am a little surprised that you are doing it given that I said I would, though11:05
rogpeppefwereade_: i said i'd fix the upgrader tests11:05
fwereaderogpeppe, I said, not sure if you saw: I am a little surprised that you are doing it given that I said I would, though11:07
rogpeppe[12:05:56] <rogpeppe> fwereade_: i said i'd fix the upgrader tests11:07
rogpeppefwereade: to be compatible with both old and new dev-versions11:07
rogpeppefwereade: and you said "yes please" AFAIR11:08
rogpeppefwereade: 'cos i knew they'd be a hassle11:08
fwereaderogpeppe, as I recall you said they needed to be fixed, and I said I knew, and that they fit well with what I was currently doing11:08
rogpeppefwereade: oh, crossed wires, sorry11:08
rogpeppefwereade: how far down the road are you?11:09
rogpeppefwereade: i've unfucked the tests in principle; i just need to get them to pass now.11:09
fwereaderogpeppe, I have spent about 12 hours straight unfucking upgrades11:09
fwereaderogpeppe, and I have a green build11:09
rogpeppefwereade: oh, ok, cool./11:09
rogpeppefwereade: i've only spent the last 2.11:10
fwereaderogpeppe, and I am on a sanity pass through11:10
rogpeppefwereade: assertNothingHappens could never be triggered11:10
rogpeppefwereade: because the channel never gets sent to11:10
rogpeppefwereade: i think it probably did in an earlier incarnation which changed.11:10
fwereaderogpeppe, however I did just spot that that can't possibly work, yeah11:10
rogpeppefwereade: i changed it to: http://paste.ubuntu.com/5701129/11:11
rogpeppefwereade: good word :-)11:12
dimiternmramm: ping11:21
TheMue*hmpf* test fails after merge, but sure it will be easy11:23
TheMuefwereade: could you pls take a look at https://codereview.appspot.com/8705043. it's still wip, i will add more test scenarios (multiple relations, peer relations), but i would like a feedback about the current approach by you11:50
fwereadeTheMue, will do shortly11:50
* TheMue just has been called for lunch, bbiab11:50
TheMuefwereade: great, thx11:50
dimiternthe trunk is now broken12:49
dimiternenvirons/maas/environ.go:7:2: import "launchpad.net/gomaasapi": cannot find package12:49
TheMuedimitern: did you go get it?12:50
rvbadimitern: we just merged the MAAS provider.  You need to get the lib gomaasapi.12:50
dimiternTheMue: I tried go get launchpad.net/gomaasapi/...12:50
dimiternand it reported: # launchpad.net/gomaasapi/example12:51
dimitern../gomaasapi/example/live_example.go:45: not enough arguments in call to gomaasapi.NewAuthenticatedClient12:51
dimiterngo get launchpad.net/gomaasapi (w/o /... works) though12:51
TheMuedimitern: ouch, so gomaasapi is broken and the trunk fails as a result of this12:51
rvbadimitern: let me look into it…12:52
dimiternrvba: now running go build ./... && go test ./... in juju-core/12:52
dimiternrvba: but the same fails inside gomaasapi with the error above12:53
rvbadimitern: I'm on it.  We updated something in gomaasapi but forgot to update the 'live_example.go' file.12:54
dimiternrvba: cheers12:54
dimiternrvba: always run "go build ./... && go test ./..." successfully before submitting please12:55
dimiternrvba: juju-core tests pass12:55
rvbadimitern: we did got the tests to pass before merging.12:55
dimiternrvba: I mean in the dependencies as well, like gomaasapi12:56
dimiternso juju-core trunk is not broken after all, sorry12:57
mrammdimitern: pong12:59
dimiternmramm: sorry, I wanted to ask about the swap days after US flights13:00
dimiternmramm: but I figured I can ask in oakland :)13:00
dimiternmramm: anyway, I updated the calendar with my holiday leave in june (10-25) and for europython in july (1-5), filed swap days, etc. in cadmin13:01
mrammdimitern: great -- I saw the calendar updates13:02
mrammbut will login to cadmin and approve stuff13:02
dimiternmramm: cheers, actually probably jam needs to approve these still, but anyway13:03
mramm right!13:04
TheMuemramm: btw, during oakland we have a national holiday. i'll take it together with the swap days and two of my holidays of last year in the week after oakland.13:15
rvbadimitern: the fix has landed.  I'll also land a fix to make sure that kind of breakage does not happen again (i.e. to make sure that the content of examples/ [which is not tested by the unit tests] compiles).13:20
dimiternrvba: that's good, but now I see another error:13:21
dimitern# launchpad.net/gomaasapi/templates13:21
dimiterntemplates/source_test.go:11: undefined: GomaasapiTestSuite13:21
rvbadimitern: that's fixed in my next branch :)13:21
dimiternrvba: ah, cool13:21
TheMuedimitern: hehe, that's real wip13:23
rvbadimitern: all fixed now.13:41
dimiternrvba: indeed, thanks!13:42
=== wedgwood_away is now known as wedgwood
dimiterni still can't find the kanban g+ link :(14:01
dimiternmramm: can you send it please? I'll add it to my calendar manuallt14:02
dimiternah! found it! sorry14:02
fwereadeTheMue, I'm not to sure about https://codereview.appspot.com/8705043/14:41
fwereadeTheMue, where did you get that data format from?14:41
fwereaderogpeppe, dimitern: the upgrade-juju stuff is here: https://codereview.appspot.com/8663045/14:44
rogpeppefwereade: woo!14:45
TheMuefwereade: by daves code and my interpretation of the py code14:45
TheMuefwereade: i have to step out for i thin 1h. will ping you then again.14:45
* fwereade now has to dust off the provision-time changes and see how badly they rotted in the last day14:46
rogpeppefwereade: and in return, juju-wait: https://codereview.appspot.com/871004314:46
rogpeppedimitern: ^14:46
dimiternfwereade: will take a look a bit later14:46
dimiternrogpeppe: and at yours too14:46
rogpeppedimitern: ta!14:46
* dimitern needs to think a bit, so going for a short run - bbi30m14:47
jtvWould anyone be interested in having a makefile?  There are a few advantages that come from convenience...  Suggestion is at https://codereview.appspot.com/871104315:15
rogpeppejtv: +0; i don't think i'd ever use it.15:29
rogpeppejtv: but i wouldn't mind it being around15:29
rogpeppefwereade: any chance of a review of https://codereview.appspot.com/8710043/ ?16:27
rogpeppefwereade: i'm a fair way into your upgrade-juju review, BTW16:27
dimiternrogpeppe: i'm on it now16:27
rogpeppedimitern: cool, thanks16:27
dimiternrogpeppe: reviewed16:41
rogpeppedimitern: ta!16:41
dimiternfwereade: your internet connection sure is flaky today16:53
rogpeppefwereade: you've got a first round of review comments17:05
rogpeppefwereade: hmm, what's our rationale for not letting agent version change in config again?17:08
fwereaderogpeppe, it's just a way to mess up the upgrade process afaict17:18
rogpeppefwereade: ah, of course.17:18
fwereaderogpeppe, having no way except the approved one to change it feels like a win to me17:19
rogpeppefwereade: might be good to add a comment there17:19
rogpeppefwereade: +117:19
fwereaderogpeppe, definitely17:19
rogpeppefwereade: i *knew* there was a good reason!17:19
fwereaderogpeppe, sorry, btw, I need to stop for a while, I don't think I'll manage to finish it today17:19
rogpeppefwereade: ok17:19
fwereaderogpeppe, if I do it'll be late17:19
rogpeppefwereade: sure17:19
rogpeppefwereade: i need to stop soon too17:20
* fwereade strikes out in search of pizza17:20
rogpeppefwereade: hopefully i'll get to the end of your review17:20
* rogpeppe quite fancies pizza17:20
rogpeppefwereade: have a great weekend!17:20
dimiternfwereade: reviewed as well17:30
dimiterni have to stop17:31
dimiternhappy weekends everyone!17:31
rogpeppem_3: ping17:48
rogpeppem_3: if you're around at some point, please could you take a look at https://codereview.appspot.com/8710043/ and see if it looks like something you could use17:48
rogpepperight, that's me done17:51
rogpeppeg'night all and happy weekends too17:51
=== deryck is now known as deryck[lunch]
=== BradCrittenden is now known as bac
m_3[6~[6~/win 219:29
TheRealMue<7nick TheMue19:31
=== TheRealMue is now known as TheMue
=== deryck[lunch] is now known as deryck
=== arosales_ is now known as arosales
=== wedgwood is now known as wedgwood_away

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!