[05:27] Hi, I want to know if it's possible to run custom shell commands from the dash, for example a function created in .bashrc === tvoss|sick is now known as tvoss [05:59] anyone with 3 or 4 monitors? https://bugs.launchpad.net/unity-2d/+bug/930147 would need testing on 12.04 [05:59] Launchpad bug 930147 in unity-2d "all panels have same window focus on multiple monitors unity2d" [Low,Fix committed] [06:03] wow, three monitors. [06:03] stupid intel GPUs only have 2 PLLs [06:07] hey Mirv [06:07] Mirv: any progress on the skype/qt4 issue? [06:29] hey didrocks. I didn't get new answers yesterday, but I haven't found any similar crash reports on other libqtwebkit4 rdepends (like amarok, arora, k3b, ktorrent, rekonq, quassel), so I believe it's skype only. [06:30] but I'm not certain if anyone is willing to upload skype with the LD_PRELOAD hack... [06:30] Mirv: do you mind adding a comment on the bug report + ping jdstrand who had concerns with it? [06:30] didrocks: ok [06:30] Mirv: if he agrees, I can sponsor it :) [06:30] (the hack) [06:30] Mirv: just ping me so that we can conclude that today if possible :) [06:32] ok, I'll ping + send e-mail [06:32] thanks ;) [07:13] hi [07:17] good morning [07:17] this is about ubuntu interface ? [07:19] jim00234: yeah [07:22] why they choose a tablet interface for a desktop os? [07:27] because it's not a tablet interface [07:47] hey sil2100, how is it going? [07:48] didrocks: hi! Had to do tax-related stuff in the morning so I'm starting just now ;) [07:48] sil2100: did you get to the new package yesterday evening, or not yet? [07:48] sil2100: what's on your plate, to sum up? ;) [07:49] (and what I've eventually to review since Tuesday) [07:50] didrocks: I have the packaging prepared according to the guidelines for android-audiosystem, will be doing testing on my system yet before proposing a merge [07:50] sil2100: excellent! do not hesitate to poke me for a review :) [07:51] sil2100: how are you going to test it manually btw? just curious :) [07:51] I had some build problems due to the changes yesterday ;p some strange dpkg- things [07:51] sil2100: needing help? [07:54] mzanetti: any reason we don't publish generic-mediumtests-builder jobs in the public jenkins? [07:56] tsdgeos: yeah... because it's not supposed to fail unless all the other builders fail too. [07:56] :D [07:56] tsdgeos: which has been working 100% reliable until yesterday [07:56] seen the answer i just gave to michi? [07:56] no [07:56] link? [07:57] https://code.launchpad.net/~michihenning/unity/phablet-coverage-tests/+merge/157781 [07:59] mzanetti: do you have a minute for hangout? I want to discuss some tests-autopilot-jenkins-job-thingy-yes-I-cant-make-a-more-fuzzy-title-but-will-try ;) [07:59] Saviq: pushed the nested proxy rolenames test [08:00] tsdgeos: really weird... the mediumtests-builder is exactly the same as the i386-ci expect it builds without coverage measurements and does not execute tests [08:00] tsdgeos, nice [08:00] didrocks: sure [08:00] mzanetti: shrug [08:01] tsdgeos: well... it does execute the core "make check" suite [08:01] tsdgeos: as pbuilder does that on its own [08:01] right [08:01] mzanetti: https://plus.google.com/hangouts/_/1ce5181c7e07bfd3df3ccb932563480d1966d625?authuser=0&hl=en [08:52] What's the best way to type check in QML? [08:53] nic-doffay, there's no way to do that unfortunately [08:53] nic-doffay, the only thing is «typeof something, "object"» [08:53] nic-doffay: https://bugreports.qt-project.org/browse/QTBUG-24799 [08:54] Saviq, hmm ok. [08:54] nic-doffay, we could try and use a hack [08:54] nic-doffay, by declaring properties of certain types [08:54] and trying to assign the values to them [08:54] * mzanetti wonders if the problem isn't somewhere else... [08:55] I haven't felt the need for it in more than 10000 lines of QML [08:55] mzanetti, it's for the interface tests [08:55] mzanetti, when we want to make sure that an exposed property is of a certain type [08:56] tsdgeos, so that really means the QTBUG re: nested proxy roleNames is fixed? [08:57] Saviq: not really, the bug is about nested proxies, not nested "our" proxies [08:57] Saviq: hmm, ok... how about something like this? http://stackoverflow.com/questions/332422/how-do-i-get-the-name-of-an-objects-type-in-javascript [08:57] didrocks: hmmm... [08:57] didrocks: can I poke you about something? [08:57] sil2100: isn't what you have just done? ;-) sure, what's up? [08:58] tsdgeos, hmm right [08:58] Saviq: next step in "improving" our proxy is checking if they correctly return sourceModel()->roleNames from the QSortFilterProxyModel and then remove our implementation, but i'd like to defer that a bit (and get this one merged), working on the hud prototype now [08:58] tsdgeos, sure, approved already [08:59] i did fix it for the QIdentityProxyModel almost for sure [08:59] don't remember if also proposed a fix for the SortFilter one [08:59] didrocks: so... I have a situation I don't really understand ;) The android-audiosystem package, I wanted to build it locally but it fails - the reason is, the debian/rules they use uses dh and override_dh_auto_build/clean/install [08:59] didrocks: the package itself uses .sh scripts to build, so there's no 'real' buildsystem that dh can use [08:59] didrocks: now, the thing I don't understand... [09:00] sil2100: hangout + screensharing maybe? [09:00] we can look at that together :) [09:00] Does anyone know if it's possible to get a view on all blueprint workitems assigned to a user? [09:00] didrocks: when building it locally with bzr bd, it fails building, as the override hooks for build, clean and install doesn't work [09:00] sil2100: maybe a good training for both of us ;) [09:00] Saviq, just a reminder about that email for the interface tests with a summary of what needs to be done. [09:00] didrocks: but when building on a PPA, I saw it working fine :o OK, one moment and I'll prepare for a hangout [09:01] Got to connect the power and things like that [09:01] sil2100: and dress up! :p [09:01] nic-doffay, yeah, I'm on it, but doing it properly from the get go, so might not make it today [09:03] No problem, still got things to implement. Taking slightly longer due to QML noobness too. [09:05] didrocks: invited you [09:09] mzanetti, I'll have a look, thanks [09:12] mzanetti, "[native code]" :/ [09:13] mzanetti, the constructor.toString() just tries to print the source of the constructor [09:13] but obviously that only works in JS [09:13] Saviq: right... [09:13] [native code] :D Hooray for propert code [09:13] proper [09:15] and even root.constructor.name is empty [09:15] where root is a Rectangle [09:15] it's actually an empty string [09:16] so yeah, the only solution I can think of is declaring a property of a type [09:16] and check if assignment works [09:16] but that's probably not really reliable... [09:19] hmm seems to work, actually [09:21] mzanetti, what do you think? [09:22] Saviq: I could immagine implicit casts happening at some cases [09:22] mzanetti, yeah, but if the property is of a type [09:23] Saviq: what kind of type? [09:23] mzanetti, well, you're right [09:23] I don't think you can distinguish a ByteArray from a String [09:23] while it might work for QObject* types [09:24] but especially basic types will be implicitly casted, and Polymorphic types might be problematic too [09:24] mzanetti, well, basic types we can check with typeof [09:24] mzanetti, the only problematic ones are objects [09:24] and enums, which are just numbers, but that should be somewhat fine [09:25] still, it would be something [09:25] Saviq: not really sure if the approach of checking types in a untyped language is the right one [09:25] maybe we should have some C++ tests for that? [09:26] mzanetti, we want to test the QML interface [09:26] and sure, we could test it in C++ [09:26] and it actually will be tested in C++, too [09:27] I guess the most sensible approach would be to split them... checking types of QML items in javascript feels like the sledgehammer method [09:27] mzanetti, and well, QML is typed [09:27] Saviq: yeah... but the engine it runs in is not [09:28] mzanetti, so deferring to it (by trying to assign a value to a typed property) to QML [09:28] Saviq: might as well be enough... actually if QML casts it implecitly and the test passes it will most certainly also work in real code - casted or not [09:28] mzanetti, I'd really like to avoid splitting the test, it's supposed to be a definition of the API in a sense [09:29] yeah exactly [09:29] mzanetti, and obviously when the aforementioned bug is fixed [09:30] right... that would help, yeah [09:30] we can move to a more proper way, but I'd rather not split it out [09:32] Saviq: the bug was last edited in Jul 2012 by a guy who has most likely been fired the same day as I was... wouldn't hope too much tbh [09:32] mzanetti, lol [09:33] mzanetti, yeah, I rather thought we'd have to take care of it if we really want it [09:33] but that's fine [09:34] Saviq: but doesn't sound too hard actually... How about creating a simple qml plugin that just the type comparison as a C++ method? I guess that could be possible [09:34] mzanetti, indeed [09:34] or would you need to include all the types there? [09:35] mzanetti, don't think so [09:35] mzanetti, if you define a component in pure QML [09:35] you can still pass it back to C++ [09:35] question is how do you get its type hierarchy, then [09:36] Saviq: for QObjects it would be easy [09:36] and I guess to pass them to QML they have to be QObjects anyways [09:36] mzanetti, exactly [09:36] obj->metaObject() [09:36] right [09:37] * Saviq hacks [09:40] did someone fix the startup crash of qml-phone-shell? [09:49] mzanetti, what startup crash? the one on the phone [09:49] ? [09:49] Saviq: no, on the desktop [09:50] Saviq: but its back now... just hat a lot of lucky runs [09:50] mzanetti, I barely ever see it crash [09:51] Saviq: happens in most of the cases for me [09:51] mzanetti, but I did manage to make Qt crash, by trying to pass a component (not an instance) to C++ ;) [09:51] Saviq: passing -geometry 1600x1400 or so decreases likelyhood [09:51] hehe [09:51] we'll have to compare by string, unfortunately [09:52] Saviq: can you remember what exactly was the reason for copying the ListItems? [09:52] mzanetti, there were a bunch, just look at the diffs [09:52] mzanetti, greyback was the one that did most of it, IIRC [09:53] mzanetti: which listitems? [09:53] seb128: hey, a friend of mine has just upgraded to 13.04, but his applications/defaults.list had not the proper handler for inode/directory... Is that only applied after fresh-install? [09:53] greyback: Components/ListItems/* [09:54] greyback: unity-phablet [09:54] seb128: I didn't do that manually as far i remember [09:54] Trevinho, maybe he has a local config for his user? [09:54] Trevinho, we don't overwrite user configs [09:54] seb128: no, changing it manually on /usr/share/applications, fixed it [09:54] weird [09:54] seb128: it was only a global thing [09:54] yeah [09:55] well it you changed it manually we can't get debug infos now [09:55] mzanetti: they're heavily customized versions of SDK ListItems. [09:55] seb128: damn :P, I can revert it back... :P [09:55] Trevinho, next time somebody has the issue tell them to keep the system in buggy state for debugging [09:55] Trevinho, that will not restore the timestamp from before you changed it... [09:55] greyback: yeah. I'm in the process of determining if we need to keep them or if we should go back to upstream ones at some point [09:55] Trevinho, so we don't know when the file was updated before your edit [09:56] seb128: oh... I'm sorry :/ [09:56] Trevinho, it's supposed to work on update, dunno what happened there [09:56] Trevinho, no worry [09:56] Trevinho, dpkg -l | grep desktop-file-utils [09:56] seb128: fine, I've other PC to upgrade anyway [09:57] mzanetti: mostly the customisations are for lists with section headers which have transparent backgrounds - and the section headers stick to the top of the view. Right now listview draws the section header on top of the delegate, but if there's transparency you see both. [09:57] Trevinho, can you get the dpkg info? [09:58] Trevinho, did you get a conffile diff prompt during the upgrade? [09:58] mzanetti: It's a workaround for what I suspect is a Qt bug [09:58] Trevinho, the issue is that the file is stored in /etc, so it preserve local changes [09:58] Trevinho, and some buggy software edit the files for you, which makes the system think you edited the file and want your old version preserve [09:59] Trevinho, acrobat reader does that iirc, and some others [09:59] greyback: I find it hard to believe that the ListView section header has such a bug [09:59] seb128: ah, he has 0.21-0ubuntu3 anyway [10:00] seb128: but if one changed that file should't it keep the .dkpg-old or original? [10:00] mzanetti: open the SDK component gallery. You'll see it there right away in the list on the left [10:00] Trevinho, well, when there is a change it asks you what to do on upgrade [10:00] seb128: yeah, sure [10:00] Trevinho, it shows you the diff and ask if you want to install the version of the package or keep your local one [10:01] Trevinho, ls /etc/gnome/defaults.list* [10:01] ? [10:01] greyback: where can I find that again? [10:01] the components gallery [10:02] mzanetti, ubuntu-ui-toolkit-examples [10:03] mzanetti: From the Dash, search for "Qt Components". You may have it installed. If not, lp:ubuntu-ui-toolkit, qmake, make, and run ./launch-demos. [10:03] no dash here [10:03] but found it [10:03] * Trevinho running between rooms like a crazy... [10:03] mzanetti, /usr/lib/ubuntu-ui-toolkit/demos/launch_componentshowcase [10:04] seb128: yeah, so it seems that the old one was kept [10:04] mzanetti, and I don't actually think is a bug in its usual definition, it's just an omission [10:04] seb128: apparently there were some google- earth and acroreader changes on it [10:04] Saviq, greyback: yeah... QML does not do any clipping on its own. [10:04] Trevinho, that's your issue, those are buggy and modify the file [10:05] seb128: yeah :/ [10:05] in our case that does suck indeed a little bit [10:05] mzanetti, yeah, there should really be an option to enable clipping under the section header [10:05] seb128: what would be the proper way for doing that for them? just a proper .desktop file or a local setting? [10:05] mzanetti, it's just assuming you will always have a background in your section header [10:05] Saviq: InverseClippingArea :D [10:05] mzanetti, ;) [10:06] mzanetti, if I go `some_function(Rectangle)`, do you know of a way to then create an object of that type? [10:06] Trevinho, what mimetype google-earth needs to claim? if nothing else is using the same mimetype they don't need to set a default [10:06] Trevinho, acroread is a bit trickier [10:07] * mzanetti thinks [10:07] mzanetti, or is that at all supported [10:07] Trevinho, the current xdg spec doesn't allow for a new installed package to take over a default, opensuse has hacks for that and they suggested them on the xdg list some years ago [10:07] Trevinho, but that never went to a conclusion [10:07] mzanetti, I seem to get an Object from that just fine, but it doesn't seem to have any members :/ [10:07] seb128: ah, I see [10:08] seb128: I guess that using a defaults.list.d/ would be a solution, isn't it? [10:08] seb128: with priority-names .... i.e. 00_adobe.....list [10:08] Saviq: I would need to try experimenting... could immagine to get a Loader somehow to create an object from its name [10:09] mzanetti, don't think so, it either takes a Component (which Rectangle is not) [10:09] mzanetti, or a source file [10:09] same as Qt.createComponent, really [10:09] Qt.createObject() ? [10:10] or was it Component.createObject()... that wouldn't help either in that case :/ [10:10] yeah, it was Component [10:10] there is Qt.createQmlObject [10:10] but that doesn't help either [10:12] Trevinho, right [10:13] Trevinho, some of the discussion/proposal for improvements were around "by desktop default" as well [10:13] Saviq: what you could do - not the most elegant thing though - is to have a file with all the Types wrapped in a Component {} and a getByName() that returns the Component... [10:13] let's make new standards! :) [10:13] Trevinho, e.g http://lists.freedesktop.org/archives/xdg/2011-February/011806.html [10:13] Saviq: actually pretty ugly... [10:13] mzanetti, yeah, what with custom types [10:13] mzanetti, I'll just go for string comparison [10:13] Saviq: yeah... would require constant extending [10:15] greyback: so in your opinion we can't get rid of them but rather should write test cases in our codebase? [10:16] * mzanetti wonders how to test clipping - which is really the only thing they do :D [10:16] mzanetti: for now we're stuck with them. I also think it's a bug, or at least an omission in Qt. [10:17] mzanetti: you could test to make sure that the math is correct, so it's clipping the correct height [10:21] greyback, but some of the changes were upstreamable to SDK, no? [10:21] mzanetti, please make sure of that ^ [10:22] Saviq: mzanetti: yes they could be upstreamed, that would be option 2. But I think option1 is seeing if we can fix ListView [10:22] greyback, right [10:22] greyback, but there were some other changes [10:23] greyback, like the height of the item to (not) include the separator [10:24] Saviq: yep, those bits can go upstream, but I know the SDK's ListItems are due to be reviewed heavily so I'd be tempted to hang on for that first [10:24] right [10:25] +1 [10:25] that doesn't seem to be a task to do in between our testing efforts [10:26] Saviq: I'll postpone them then... given that the basics (size and clicking) are already tested through the peoplepreview now [10:27] mzanetti, k [10:31] this is ridiculous [10:31] 14/16 Test #14: whitespace ...........................***Failed 0.55 sec [10:31] /home/phablet/shell/builddir/CMakeFiles/CompilerIdC/CMakeCCompilerId.c: trailing whitespace in lines 224, 279 [10:31] /home/phablet/shell/builddir/CMakeFiles/CompilerIdCXX/CMakeCXXCompilerId.cpp: trailing whitespace in lines 212, 267 [10:31] really? [10:35] tsdgeos: I don't think this is intentional [10:36] tsdgeos: but yeah... in my opinion we should do license and whitespace checks _before_ the build run, not afterwards, or this kind of things will keep on biting [10:43] tsdgeos, yes, really [10:44] tsdgeos, just make test before you push [10:44] tsdgeos, ah [10:44] paulliu: you around? [10:44] Saviq: and how do i fix whitespace there? [10:44] if i may ask? ;-) [10:44] tsdgeos, wait, that should be handled [10:44] tsdgeos, the script ignores stuff in ${CMAKE_BINARY_DIR} [10:44] it does [10:44] or, should [10:44] it is true [10:45] the problem is that i was dpkg-building [10:45] tsdgeos, should work just the same [10:45] on a "dirty" checkout [10:45] tsdgeos, ah [10:45] tsdgeos, :P [10:45] tsdgeos, bzr bd -S [10:45] so the builddir was not really the ${CMAKE_BINARY_DIR} [10:45] tsdgeos, or bzr bd [10:45] tsdgeos, that will only take files checked in (modified, too) [10:46] mzanetti, did you ever get expectFail() in QtQuickTest to work? [10:47] Saviq: never tried tbh [10:47] Saviq: didn't know existed [10:47] ;) [10:47] Saviq: I use verify(something != something) or the like [10:48] mzanetti, yeah, not working with exceptions ;) [10:48] mzanetti, http://pastebin.ubuntu.com/5701083/ that, more or less, works [10:48] Saviq: don't use exceptions with Qt :D [10:48] mzanetti, yeah, it was automagic [10:48] need to protect [10:49] Saviq: isInstanceOf.... is that the thing you hacked together? [10:49] mzanetti, yeah [10:49] Saviq: and you attached it to every object? [10:50] mzanetti, no, not yet [10:50] I guess I'll see a MP that explains it at some point... just curious how you did it [10:50] mzanetti, just a Q_INVOKABLE now [10:50] mzanetti, testObject is just an object from a plugin [10:50] Saviq: ah... ok... net yet the actual objects to be tsted [10:51] mzanetti, yes they are [10:51] * Saviq pastes the whole thing [10:53] mzanetti, http://pastebin.ubuntu.com/5701091/ [10:54] Saviq: ok... got it... this line comfused me: testObject.isInstanceOf(testObject, "QQuickItem") [10:55] Saviq: I got the impression that suddenly all objects know of isInstanceOf [10:55] mzanetti, yeah, WIP [10:56] mzanetti, I think that should do for now [10:56] Saviq: seems good imho [10:56] Saviq: autopilot does the same btw [10:57] mzanetti, I'll build it into UnityTestCase [10:57] Saviq: while you're at it... mind moving UnityTestCase to /tests/imports/ [10:57] Saviq: we're using it in unittests too now [10:57] mzanetti, yup [10:57] thanks [11:00] hmm === MacSlow is now known as MacSlow|lunch [11:01] hey guys [11:02] mzanetti, tsdgeos hmm, plugins vs. imports vs. modules? [11:02] Saviq: good question [11:02] Saviq: context? [11:02] hey kgunn [11:02] mzanetti, tsdgeos, SDK uses "modules", we use "plugins", mzanetti just mentioned "imports" [11:03] hey kgunn [11:03] Saviq: are 3 different things [11:03] Saviq: a Module would be something like Ubuntu.Components [11:03] Saviq: plugins is c++ stuff loaded as a plugin into the enigne [11:03] Saviq: imports is small qml or .js file imports [11:04] mzanetti, Ubuntu.Components has a plugin, too [11:04] Saviq: yeah... a module can consist of plugins and imports [11:04] mzanetti, now we're talking ;) [11:04] QQuick 2.0 is a module [11:05] mzanetti, so module[plugins (C++), imports (qml)] [11:05] Saviq: rule of thumb, yeah... [11:05] mzanetti, but then do we want them separately in our root? [11:05] that's 3 import paths where one should generally suffice [11:05] and then [11:05] Saviq: you thinking about moving the FakeHud plugin etc too? [11:06] mzanetti, considering [11:06] mzanetti, want to avoid duplicates [11:06] mzanetti, where we, for example, need mocked Unity or something [11:06] Saviq: hmm... could make sense... could cause things I don't see now though [11:06] mzanetti, so yeah that was my question, too [11:06] but yeah... I guess a mock-hud plugin could indeed be useful in some other places than the hud qmluitests [11:06] should we have /modules, /plugins /imports /tests/modules /tests/plugins /tests/imports [11:07] Saviq: doesn't sound like a friday afternoon task, but would sound like a clean solution, yeah [11:07] mzanetti, lol [11:07] mzanetti, you've learned something there :D [11:08] :D [11:08] So, Im on Kubuntu and I have the unity webapps thing coming up on my chromium. I have 3 questions: 1. what is this?/what does it do? 2. If its useful, how do I install it (it currently gives me a html file of a LP page when I try install it) 3. if its not useful on kubuntu, how do I get rid of it... ? [11:10] jussi:+1. I think its weird that all the browsers pop up those webapps thingies when not running unity... however, I don't think #unity is the right channel to ask this :D [11:10] jussi: try something like #webapps [11:10] jussi: i don't think it does anything in kubuntu, just click "don't ask me anymore". That's what i did [11:10] hrm, #webapps ? not seen that, but Ill give it a try... [11:11] mzanetti: that channel doesnt exist :/ [11:11] tsdgeos: I dont have that option... :/ [11:12] jussi: #ubuntu-webapps [11:12] it was there in firefox at least afair [11:12] tsdgeos: http://i.imgur.com/tIdd2yN.png [11:12] mzanetti: ahh, that makes sense [11:12] ok, that's definitely not what i got in firefox [11:13] it was more combo-like [11:13] and you could say "ignore me forever" [11:14] yeah, I asked in -webapps, lets see what they say [11:44] we have a typo in the license checker :D [11:44] Found 1 license prolems: [11:44] mzanetti: ↑↑ where is that code? [11:45] tsdgeos: I think somewhere in tests/ [11:45] tsdgeos: depends... we have 2 license checkers [11:45] really? grep sound nothing [11:45] may it be the jenkins one? [11:45] tsdgeos: one in jenkins that runs before the build [11:45] that one [11:45] tsdgeos: and one in the tests from Michi [11:46] tsdgeos: lp:ps-qa-tools [11:47] tsdgeos: where is the typo? [11:47] "Found 1 license prolems:" [11:47] hehe... right [11:47] https://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/498/console [11:47] maybe it was fixed [11:47] tsdgeos: http://10.97.9.46/hooks/A10checklicenseheaders [11:47] nope [11:47] grep doensn't find it there either [11:48] there = ps-qa-tools [11:48] tsdgeos: then lp:pbuilderjenkins [11:48] sorry [11:50] mzanetti: https://code.launchpad.net/~aacid/pbuilderjenkins/fix_typo/+merge/158572 [11:50] dednick: something weird happened in https://code.launchpad.net/~nick-dedekind/unity/phablet-test-panel/+merge/157927 [11:51] it says you removed and added tests/qmluitests/Panel/qml/CMakeLists.txt :D [11:51] tsdgeos: I guess you don't mind if it takes a week or two until it is actually installed on all jenkins nodes? [11:51] tsdgeos: otherwise you would need to make a release [11:51] mzanetti: lol no [11:51] can't live without that fixed [11:51] mzanetti: hi [11:51] tickling my inner mind [11:51] j/k [11:52] i was just doing something for 3 min before lunch is ready [11:52] paulliu: hey. I just wanted to ask on where you stand with the IndicatorMenuWindow tests to avoid conflicts [11:52] paulliu: but I've found your branch [11:53] paulliu: I'm writing tests for Panel/Menus/Overview* right now. [11:53] mzanetti: ok [11:56] Trevinho, btw, want to use https://bugs.launchpad.net/ubuntu/+source/tomboy/+bug/961680 for the tomboy issue (you told me to open a bug yesterday)? [11:56] Launchpad bug 961680 in tomboy (Ubuntu) "New note window (when clicking "Create New Note" from indicator icon) sometimes doesn't take focus" [Undecided,New] [11:57] seb128: ah, yeh... it would be nice if we could track all these issues on bug 627195 [11:57] bug 627195 in Ubuntu One Client "Window management - Apps raised from indicators sometimes dont have the focus" [Undecided,In progress] https://launchpad.net/bugs/627195 [11:57] Trevinho, wfm === _salem is now known as salem_ [12:13] sigh, frustrating that there isnt anyone awake in -webapps. perhaps Ill have better luck in US wake up time [12:14] seb128: this is an hackish way yo get the click event timestamp, though: http://paste.ubuntu.com/5701235/ :) [12:15] Trevinho, nice little hack ;-) [12:17] seb128: in theory the only other way we have is use gtk_main_do_event and using it it in lidbusmenu to activate the gtk-menu used in the libappindicator (so that gtk_get_current_event_time will work)... the problem is that building a nice fake event that bypassess the gtk checks is not that easy... [12:17] seb128: gtk activate should include a timestamp parameter... that would fix things for good [12:18] right [12:18] Saviq: was just about to get onto another test case and was going to take a look at DashContent. Says to talk to you first? [12:23] anyone up for a test review? https://code.launchpad.net/~mzanetti/unity/phablet.test-indicators-overview/+merge/158587 [12:28] mzanetti: sure [12:31] Saviq, need your approval here: https://code.launchpad.net/~dandrader/unity/phablet_improve_cmake_add_qml_test/+merge/158386 [12:32] dandrader, you don't exactly need mine :D === MacSlow|lunch is now known as MacSlow [12:44] mzanetti: done. comment added. [12:49] dednick, hey, now that I look at it again, when you provide a mock Lenses object to it [12:49] dednick, should be fairly testable [12:49] Saviq: yep. that's what i thought as well. [12:50] dednick, so yeah, have at it [12:53] mzanetti, https://code.launchpad.net/~dandrader/unity/phablet_improve_cmake_add_qml_test/+merge/158386 got time to check this? :) [13:04] dandrader: yes [13:04] mzanetti, thanks! [13:04] this is a pre-req for another merge proposal that is pending [13:08] dednick: good catch! thanks. fixed [13:08] dandrader, some minor nitpicks [13:09] Saviq: oh... you have it already. should I still review or did you a complete review already? [13:09] mzanetti, yeah, it's done [13:10] Cimi: you around? [13:10] mzanetti, yup [13:10] Cimi: there are a couple of MPs from you in the queue that are waiting to be fixed [13:10] https://code.launchpad.net/~unity-team/unity/phablet.test_IndicatorItem/+merge/157919 [13:10] https://code.launchpad.net/~unity-team/unity/phablet.test_greeter-clock/+merge/157859 [13:11] ok [13:11] will do now [13:12] i hear that the launcher can be resized to 8px now [13:12] is that true? [13:15] mzanetti, first one pushed [13:17] also the latter [13:19] Saviq, done [13:19] Cimi: first one approved [13:20] dandrader, I meant there's a rogue space before "${ARGN}" [13:20] Saviq, ah, right [13:21] Saviq, fixed [13:21] dandrader, cheers [13:22] >now that you can resize launcher icon size to min of 8 pxl, why the change hasnt been reflected on the slider opt in Appearance applet? [13:22] >i hate that my custom launcher size always get reset to 32px everytime i open the applet to change wallpaper [13:22] Cimi: on the second one... would you mind fixing lines 42 - 44 [13:25] hope that is just oversight and will be fixed in daily updates [13:25] or should i file a bug report on that? [13:29] excalibr: yeah, sounds like a bug [13:30] excalibr: better report if you want it to be fixed anytime soon [13:31] which package should i file it under? [13:32] excalibr: the package where the broken slider comes from [13:33] tsdgeos, standup? [13:33] greyback, ^ [13:34] mzanetti, what's that? [13:34] do we have a new line here? [13:35] Cimi: every file should end with a newline [13:37] mzanetti: i think it's gnome-control-center-unity [13:37] Cimi: and your merge removed it [13:37] k. filling a bug report now, hopefully someone will notice it [13:38] mzanetti, done [13:38] mzanetti, curiosity, why is that needed? [13:38] Cimi: I'll explain after the standup [13:38] ok [13:48] Cimi: ah, i see your name is against it in the test blueprint. [13:49] dednick, https://code.launchpad.net/~unity-team/unity/phablet.dashBar_bottomswipe/+merge/150847 [13:49] Cimi: so.... As I wrote in the MP, this most likely wouldn't harm us in a CMakeLists.txt. [13:49] Cimi: but the rationale behind it is this: [13:50] immagine a foo.h file that contains a class definition but no newline at the end [13:50] now the according .cpp file does this: [13:50] #include foo.h [13:50] #include bar.h [13:51] if foo.h does not have a newline at the end the result after preprocessing would look like [13:51] };#include bar.h [13:51] ok, then I'll start working on DashPeople.qml [13:51] test for DashPeople.qml. [13:51] paulliu: cool. make sure to put it into the blueprint and the doc [13:51] Cimi: understood? [13:52] ok [13:52] mzanetti, yep! thx [13:54] https://bugs.launchpad.net/ubuntu/+source/gnome-control-center-unity/+bug/1168409 [13:54] done [13:55] mzanetti: regarding your coverage review doc. Should we be updating that as we write the tests? [13:55] fginther: hey, around? [13:55] didrocks, morning [13:56] fginther: how are you? [13:56] didrocks, excellent, just found the gensymbols problem [13:56] fginther: ah, was about to ask you if you saw it :) [13:57] fginther: there were still some sedding somewhere? are we sure everything is nuked now? [13:57] dead and burried ;) [13:57] Launchpad bug 1168409 in gnome-control-center-unity (Ubuntu) "Min slider value for launcher icon size needs to be updated" [Undecided,New] [13:57] waow, ubot5 with almost 3 minutes a lag ;) [13:57] didrocks, the 100scopes stack had that in there, Looking at it, I think it's just a copy and paste error [13:58] Cimi: You need some help with the Unity plugin? [13:58] dednick, yup [13:59] dednick, do you need the plugin too? [14:00] Cimi: ya. i need lens related objects [14:00] havent looked into it much, but i'm guessing Lenses & Lens [14:01] yes [14:01] dednick, I suppose we need to copy the files from the real unity plugins, for those two objects, and fake everything that is real? [14:04] Cimi: not really sure. I was able to get away with just using qml objects for the Indicator tests for the most part. So it might be easier not to use the c++ objects. Would be easier to control the test data as well. [14:04] mmm [14:04] dednick: please... no need to be precise... just drop in your name if you started something to avoid collisions [14:04] ie for Lenses just use a ListModel === rsalveti is now known as Rsalveti_ === Rsalveti_ is now known as rsalveti [14:05] dednick, but for lens we need other things [14:05] maybe [14:07] Cimi: i think as long as the object can be modelled in qml we should try stick with that. you can still have functions and such on the objects. But if it does start to get complicated then may need to use c++. [14:07] Cimi: unless you've done it all already :) [14:07] ok [14:07] I might try doing a Lens [14:07] nope [14:07] :D [14:08] it also means you dont have to recompile every time you test ;) [14:12] dednick, even more [14:12] dednick, it means I don't have to write c++ :) [14:12] hehe [14:13] I need a tea or I sleep on the chair [14:13] it has been an intense week [14:15] Cimi: actually, looking at the code i think we may be out of luck. lenses needs to return objects. dont think we can do that with ListElements [14:16] so c++ might be the way :( [14:16] dednick, do we need those objects? [14:16] yeah. lens. [14:17] dednick, and we can't have a Lens property? [14:17] inside lenses? [14:17] it's the ListElement that requires the property. and i dont believe so [14:21] Cimi: have you got a plugin working? or shall i write a quick plugin and we can add the necessary to that? [14:21] dednick, the latter [14:21] ok. [14:21] I can write a quickplugin too [14:21] but empty === hggdh_ is now known as hggdh [14:34] sil2100: hey, do you need some afternoon check? :) [14:46] Cimi: lp:~nick-dedekind/unity/phablet.fake-unity-plugin [14:46] mzanetti: easy one https://code.launchpad.net/~unity-team/unity/remove_roleschanged_signal/+merge/158634 [14:47] tsdgeos: approved [14:48] Saviq: oops, completely forgot, I was afk. Sorry [14:49] Cimi: for anything in the dash test folder that you want to run using qmlscene or the test runner, you need to do "QML2_IMPORT_PATH=../../../builddir/tests/qmluitests/Dash/qml/" [14:49] Cimi if you want to add a qmluitest in the makefile, you need to "add_qml_test(TestName IMPORT_PATH ${CMAKE_CURRENT_BINARY_DIR}/qml)" [14:49] didrocks: will get back to you in an hour, ok :) ? [14:49] sil2100: I will probably go EOW in an hour [14:50] sil2100: did you get any issue? since this morning? I thought that would take a couple of hours at most TBH [14:54] didrocks: no, it's all fine, it builds and installs on the chroot, been consulting all other steps, since there are no tests in this branch [14:55] didrocks: ah, and btw. a dh_install in the dh_override_auto_install is not needed it seems! [14:55] didrocks: it calls dh_install anyway ;) [14:55] dednick, next time push to ~unity-team [14:55] Even when dh_auto_install is not called anyway [14:55] sil2100: I still want something with --fail-missing :) [14:55] sil2100: I guess it's the script that we can doing that ;) [14:55] Cimi: ah. yeah i'll do that. [14:56] Cimi: updated [14:58] didrocks: yes, --fail-missing is added and working! [14:58] didrocks: there were some files missing though ;p [14:58] sil2100: great! :) [14:58] sil2100: needing any other help? do you think you will finish in the next hour? [14:58] greyback: I've approved this but now there's a conflict in autolanding: https://code.launchpad.net/~gerboland/unity/lvwph-tests/+merge/158336 [14:59] mzanetti: am on it [15:02] Cimi: updated [15:02] fek [15:02] mzanetti: ok fix pushed [15:02] greyback: ack. I'll recheck [15:03] didrocks: I'll be filling a merge request this very moment, since I'm afraid there will be anyway some modifications requested from reviewers ;) [15:04] sil2100: ok ;) [15:05] greyback: something seems to have gone wrong... tst_FilterGrid is not passing on your branch any more [15:06] mzanetti: hmmm, let me try [15:07] when use run_on_device, most of the time qml-phone-shell crashes a couple of seconds after start up (while it's still loading date and filling up dash). I have to try it a couple of times to get it to finish its initialization successfully [15:07] do you guys experience this as well? [15:07] s/loading date/loading data [15:08] dandrader: I have this on the desktop... gdb doesn't print too much useful stuff [15:09] mzanetti, hmm, on my desktop it doesn't crash. [15:09] dandrader: it does here around 50% of the times when I launch it with no arguments [15:09] dandrader: when I pass -geometry with some large values, it doesn't happen any more [15:09] mzanetti, but you don't get any crash with run_on_device? [15:09] mzanetti: fix pushed. Bad merge by me [15:10] dandrader: to be honest I didn't try in a while. but I remember that when this started on the desktop for me, the device didn't show it [15:10] dandrader: I get it sometimes too yes. Do you have applications running on the phone? Sometimes I think that's related [15:10] greyback: so once more testing proved useful :) [15:10] greyback, not that I'm aware of [15:11] s/not/nothing [15:11] mzanetti: :P === dandrader is now known as dandrader|afk [15:13] greyback: ok. approved. cheers [15:13] mzanetti: thank you [15:26] Cimi: seems you're out of luck... yet another conflict: https://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-autolanding/198/console === dandrader|afk is now known as dandrader [15:28] mzanetti, fixed [15:37] didrocks: ah, shit, the MR link: [15:37] https://code.launchpad.net/~sil2100/android-audiosystem/packaging_review/+merge/158647 [15:45] sil2100: really minor comments done :) [15:46] sil2100: we can add that afterwards :) [15:46] sil2100: think about filing the spreadsheet if you didn't yet [15:46] didrocks: filled in the relevant parts, trying to find a solution to the no-tests-executed [15:47] great! ;) [15:54] didrocks: hm, but from what I see dh_clean is executed? I mean, in the buildlog I see dh_clean mentioned [15:54] sil2100: dh_clean and not dh clean, right? [15:55] dh clean as well [15:55] dpkg-buildpackage: host architecture armhf [15:55] fakeroot debian/rules clean [15:55] dh clean [15:55] dh_testdir [15:55] debian/rules override_dh_auto_clean [15:56] And dh_clean somewhere later [15:56] sil2100: ok, fine with me then :) [15:56] But looking at the copyright to make sure [16:04] didrocks: never made the bootstrapping commit, so tell me if that's how you do it if there are UNRELEASED changes in the changelog [16:05] sil2100: you pushed? [16:05] ok, looking :) [16:05] sil2100: perfect! [16:06] sil2100: once you have checked the copyright, tell me, I'll top approve :) [16:06] sil2100: ah also, something else to check, the build-dep, that they are correct ;) [16:08] didrocks: I checked if they're in main, but will check if all build-deps are needed ;) As for the copyright, it seems correct, at least LGPL for the 2 directories as listed and apache for everything else [16:08] I saw a few files with UNKNOWN licenses, but that's fine? [16:09] sil2100: open them [16:09] sil2100: sometimes, they are manually written and licencecheck doesn't catch them [16:09] sil2100: also, check the authors (hence the --copyright) [16:10] sil2100: if nothing is told, there are considered under the same license than other files in the directory they are in [16:13] Ah ha! Found some small ones [16:13] :) [16:22] didrocks: what's the short version of a BSD version? [16:23] sil2100: I see http://paste.ubuntu.com/5701911/ quite frequently [16:23] didrocks: just a quick note that if jstrand didn't ping you, he updated the skype bug report bug #1155327 that he isn't blocking the workaround [16:23] bug 1155327 in skype (Ubuntu Raring) "skype crashed with SIGSEGV in malloc@plt()" [High,In progress] https://launchpad.net/bugs/1155327 [16:23] Mirv: oh great! yeah, I didn't get any ping :) [16:24] Mirv: do you know where we can that in for the skype package? [16:24] Mirv: because we don't have it in the repo? [16:25] I think it's only in the microsoft package, isn't it? [16:26] ah, steve will take care of the partner archive, great :) [16:28] didrocks: pushed a copyright mod ;) [16:28] sil2100: trusting you (we'll do another review when NEWing anyway as files will certainly change) [16:28] sil2100: build-deps are ok? === dandrader is now known as dandrader|lunch [16:30] didrocks: yes, steve commented about it it seems [16:31] didrocks: yep! Build-deps checked now [16:31] All ok [16:32] sil2100: approved! :) [16:32] sil2100: let's put it in the daily release system on Monday [16:33] sil2100: and ensure you filed everything in the spreadsheet :) [16:34] didrocks: as for the tests, there are no tests there and as I discussed with the developers, it seems it might not make sense to work on adding them since the package will be obsolate anyway [16:34] sil2100: see the note I added on the spreadsheet :) [16:35] didrocks: ah, thanks ;) I was trying to access my pandaboard at home for testing remotely, but it seems I wasn't really prepared for that [16:35] So I'll simply install it on it tomorrow once I'm back [16:35] sil2100: sounds good :) [16:36] sil2100: so yeah, let's add it to a stack together on Monday [16:41] \o/ === jhodapp is now known as jhodapp|brb === jhodapp|brb is now known as jhodapp [17:16] Cimi: didnt see you there. I just sent you an email. I've updated the branch with a lenses model. [17:17] doenst do much at the moment. just contains some static lens objects which don't do anything. [17:17] also added some test lens views for the DashContent tests. === dandrader|lunch is now known as dandrader [18:08] kgunn, is there any document or video showing how the tablet version of unity should look like? specially the side stage thing [18:16] dandrader: let me dig a little....& Katie is owner of this from design === tvoss is now known as tvoss|test === tvoss|test is now known as tvoss [18:19] dandrader: ~6:10 in this video http://www.youtube.com/watch?v=Z5kGaIRCRKA [18:20] kgunn, thanks@ [18:20] ! [18:21] dandrader: and the doc https://docs.google.com/a/canonical.com/document/d/1rMiiF_hRoV6SkOhau7UQRf6mAUHhnjKVVrZmdEYp3Uw/edit?usp=drive_web [19:05] cyphermox, if you're not too busy, I finally have the qa stack fully transitioned: https://code.launchpad.net/~fginther/cupstream2distro-config/qa-stack-update/+merge/158197 [19:06] awesome! [19:08] reviewed. === dandrader is now known as dandrader|afk === jhodapp is now known as jhodapp|bbiab === dandrader|afk is now known as dandrader === jhodapp|bbiab is now known as jhodapp === hggdh_ is now known as hggdh === salem_ is now known as _salem === eeanm is now known as eean