| rick_h_ | hatch: man, I'm getting things working but requiring a lot of moving of code around. | 00:17 |
|---|---|---|
| rick_h_ | hatch: might need to ask a favor to help me get reviewed a giant diff through as there's no way to do this in 800 lines | 00:17 |
| hatch | hmm I didn't think it was going to be THAT much work | 00:17 |
| hatch | but yeah I can definitely help review :) | 00:17 |
| rick_h_ | heh, well so far I've created two new views, templates, and removed a ton of code | 00:17 |
| hatch | removed code.....awwwww yeahhhhhh | 00:18 |
| rick_h_ | and since sidebar and fullscreen shared code I can't change one without needing to update the other to match | 00:19 |
| rick_h_ | but I do like how things are getting simpler | 00:19 |
| rick_h_ | 60 line sidebar Y.View with comments :) | 00:20 |
| hatch | egggcelent - so now that you have put in all of this work, do you think that this was the right approach? | 00:20 |
| hatch | :D | 00:20 |
| rick_h_ | yea, there's still a couple of hacky things to work out at the subapp level | 00:20 |
| rick_h_ | I'm not a fan how you can only showView() one and not the others because there's these 'routes' that don't work like normal routes | 00:21 |
| rick_h_ | but at least the fugly is contained | 00:21 |
| hatch | yeah that's been on the drawing board for a while - being able to define multiple containers and then showview into those containers under a single app | 00:21 |
| rick_h_ | not done yet and only working on sidebar 877 lines (+373/-280) 8 files modified | 00:21 |
| hatch | haha - is it possible to break it up into logical components to make the review a bit easier? | 00:22 |
| rick_h_ | I'll do my best but it's kind of a house of cards to rework how dispatch through the views worked | 00:22 |
| hatch | yeah I understand :) | 00:22 |
| hatch | it's ok - but now I have to run for supper | 00:23 |
| hatch | have a good night | 00:23 |
| rick_h_ | party on | 00:23 |
| * gary_poster sees new review but needs to stop tonight. Might try to sneak in review tomorrow but mostly will be weekending. have a great weekend everybodt | 00:32 | |
| gary_poster | y | 00:32 |
| Makyo | You too | 00:32 |
| * Makyo out too, owes James dinner. | 00:32 | |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!