| === wedgwood_away is now known as wedgwood | ||
| === wedgwood is now known as wedgwood_away | ||
| thumper | morning | 20:53 |
|---|---|---|
| fwereade_ | thumper, heyhey | 21:01 |
| thumper | hi fwereade_ | 21:01 |
| thumper | fwereade_: just reading some review comments | 21:01 |
| thumper | why do I feel like I'm wading in treacle? | 21:01 |
| * fwereade_ sighs a little | 21:01 | |
| fwereade_ | thumper, I do not get what's going on there | 21:02 |
| thumper | there seems to be some fundamental differences in design opinion | 21:02 |
| fwereade_ | thumper, yeah... I have developed a nose for things-people-won't-like and tend to avoid them where possible, but I haven't been able to comprehend the underpinnings | 21:03 |
| thumper | there are fundamentals and techniques... | 21:03 |
| fwereade_ | thumper, in particular the "abstraction too far" business | 21:03 |
| * thumper doesn't want to preech to the converted | 21:03 | |
| thumper | I've not read all the comments yet | 21:04 |
| thumper | I need to go through them... | 21:04 |
| fwereade_ | thumper, yeah, I suspect we'd just loudly agree with each other for a bit | 21:04 |
| thumper | :) | 21:04 |
| thumper | so you have a branch that changes the precise/local env default for tools upload to? | 21:05 |
| fwereade_ | thumper, I have something that by default uploads to host, default, and precise | 21:36 |
| fwereade_ | thumper, I feel somewhat bad about the code dumps I have been indulging in this weekend | 21:37 |
| fwereade_ | thumper, but it turns out that when you're trying to integrate things you end up uncovering a lot of weirdness... the sort with tentacles | 21:37 |
| thumper | :) | 21:48 |
| * thumper does something to make dave happier | 22:07 | |
| thumper | fwereade_: still around? | 22:24 |
| fwereade_ | thumper, yeah | 22:24 |
| thumper | fwereade_: care to comment on the trivial->utils proposal? | 22:25 |
| thumper | fwereade_: it is entirely mechanical | 22:25 |
| thumper | fwereade_: although I did want to have utils.ReadYaml and utils.WriteYaml move into a package utils/yaml and change the methods to Read and Write | 22:25 |
| thumper | fwereade_: then the code would be yaml.Read instead of utils.ReadYaml | 22:26 |
| thumper | fwereade_: but I held myself back | 22:26 |
| fwereade_ | thumper, I'd still consider that mechanical, but yeah, why not, save it for another day :) | 22:26 |
| thumper | :) | 22:26 |
| thumper | namespaces are a honking good idea, lets do more of those | 22:26 |
| thumper | so says the zen of python | 22:26 |
| fwereade_ | thumper, LGTM trivial | 22:28 |
| thumper | w00t | 22:28 |
| thumper | now just to wait for dave to turn up | 22:28 |
| thumper | fwereade_: I have a few comments on the set one | 22:28 |
| thumper | fwereade_: I'm not strictly attached to StringSet | 22:28 |
| fwereade_ | thumper, in case it's not clear, btw, "trivial" means "go ahead and merge it" | 22:29 |
| thumper | fwereade_: what I really want is a generic set | 22:29 |
| thumper | fwereade_: oh, I didn't realise that | 22:29 |
| * thumper goes and merges then... | 22:29 | |
| fwereade_ | thumper, (even if it wasn't trivial, the urge to badge that one trivial would have been almost overwhelming) | 22:29 |
| thumper | haha | 22:29 |
| thumper | fwereade_: set.NewStrings ... are you happy with that name? | 22:30 |
| thumper | and set.Strings as the type? | 22:30 |
| * thumper wants set.Set<string> | 22:30 | |
| thumper | but hey | 22:30 |
| fwereade_ | thumper, set.NewStrings and set.Strings SGTM | 22:30 |
| * thumper nods and edits | 22:31 | |
| thumper | once the submission is noe | 22:31 |
| thumper | done | 22:31 |
| thumper | I did it in the pipe prior to set | 22:31 |
| thumper | I will get a clash on directory names | 22:31 |
| thumper | but I'll resolve that | 22:31 |
| thumper | and move forwards | 22:31 |
| fwereade_ | thumper, (but please keep the useful methods that make it a set) | 22:31 |
| thumper | fwereade_: oh, I will | 22:32 |
| thumper | don't worry about that | 22:32 |
| thumper | :) | 22:32 |
| fwereade_ | :) | 22:32 |
| * thumper does a little research on python set methods and c++ set methods to get precedence | 22:32 | |
| * thumper pushes latest string set changes | 22:43 | |
| * thumper takes the care quickly to an engineering place, bbs | 23:07 | |
| davecheney | packaging ... packaging ... packaging | 23:32 |
| thumper | davecheney: morning | 23:39 |
| thumper | davecheney: I think we should have more namespaces, not less... | 23:40 |
| thumper | set.Strings makes more sense than utils.Strings | 23:40 |
| davecheney | thumper: i disagree | 23:40 |
| thumper | since the rename that rog wanted | 23:40 |
| davecheney | if you want to write java, write java | 23:41 |
| davecheney | but i honestly can't give a fuck about this bikeshedding | 23:41 |
| thumper | this isn't about java | 23:41 |
| * davecheney goes to change his vote on that CL | 23:41 | |
| * thumper likes the zen of python | 23:42 | |
| davecheney | thumper: you've got 2 | 23:42 |
| thumper | and lots of c++ namespaces | 23:42 |
| davecheney | submit it | 23:42 |
| thumper | davecheney: ta | 23:42 |
| thumper | davecheney: how about https://codereview.appspot.com/8701043/ ? | 23:51 |
| * davecheney is looking | 23:55 | |
| davecheney | thumper: do you have a test for | 23:57 |
| davecheney | var s set.StringSet | 23:57 |
| davecheney | s.Add("hello"); s.Add("world") | 23:57 |
| davecheney | ? | 23:57 |
| thumper | davecheney: yep | 23:57 |
| davecheney | ok, cool | 23:57 |
| thumper | TestUninitialized | 23:57 |
| thumper | I found myself wanting all the methods to work propery with uninitialized variables. | 23:58 |
| davecheney | yeah, that is very nice | 23:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!