=== wedgwood_away is now known as wedgwood === wedgwood is now known as wedgwood_away [20:53] morning [21:01] thumper, heyhey [21:01] hi fwereade_ [21:01] fwereade_: just reading some review comments [21:01] why do I feel like I'm wading in treacle? [21:01] * fwereade_ sighs a little [21:02] thumper, I do not get what's going on there [21:02] there seems to be some fundamental differences in design opinion [21:03] thumper, yeah... I have developed a nose for things-people-won't-like and tend to avoid them where possible, but I haven't been able to comprehend the underpinnings [21:03] there are fundamentals and techniques... [21:03] thumper, in particular the "abstraction too far" business [21:03] * thumper doesn't want to preech to the converted [21:04] I've not read all the comments yet [21:04] I need to go through them... [21:04] thumper, yeah, I suspect we'd just loudly agree with each other for a bit [21:04] :) [21:05] so you have a branch that changes the precise/local env default for tools upload to? [21:36] thumper, I have something that by default uploads to host, default, and precise [21:37] thumper, I feel somewhat bad about the code dumps I have been indulging in this weekend [21:37] thumper, but it turns out that when you're trying to integrate things you end up uncovering a lot of weirdness... the sort with tentacles [21:48] :) [22:07] * thumper does something to make dave happier [22:24] fwereade_: still around? [22:24] thumper, yeah [22:25] fwereade_: care to comment on the trivial->utils proposal? [22:25] fwereade_: it is entirely mechanical [22:25] fwereade_: although I did want to have utils.ReadYaml and utils.WriteYaml move into a package utils/yaml and change the methods to Read and Write [22:26] fwereade_: then the code would be yaml.Read instead of utils.ReadYaml [22:26] fwereade_: but I held myself back [22:26] thumper, I'd still consider that mechanical, but yeah, why not, save it for another day :) [22:26] :) [22:26] namespaces are a honking good idea, lets do more of those [22:26] so says the zen of python [22:28] thumper, LGTM trivial [22:28] w00t [22:28] now just to wait for dave to turn up [22:28] fwereade_: I have a few comments on the set one [22:28] fwereade_: I'm not strictly attached to StringSet [22:29] thumper, in case it's not clear, btw, "trivial" means "go ahead and merge it" [22:29] fwereade_: what I really want is a generic set [22:29] fwereade_: oh, I didn't realise that [22:29] * thumper goes and merges then... [22:29] thumper, (even if it wasn't trivial, the urge to badge that one trivial would have been almost overwhelming) [22:29] haha [22:30] fwereade_: set.NewStrings ... are you happy with that name? [22:30] and set.Strings as the type? [22:30] * thumper wants set.Set [22:30] but hey [22:30] thumper, set.NewStrings and set.Strings SGTM [22:31] * thumper nods and edits [22:31] once the submission is noe [22:31] done [22:31] I did it in the pipe prior to set [22:31] I will get a clash on directory names [22:31] but I'll resolve that [22:31] and move forwards [22:31] thumper, (but please keep the useful methods that make it a set) [22:32] fwereade_: oh, I will [22:32] don't worry about that [22:32] :) [22:32] :) [22:32] * thumper does a little research on python set methods and c++ set methods to get precedence [22:43] * thumper pushes latest string set changes [23:07] * thumper takes the care quickly to an engineering place, bbs [23:32] packaging ... packaging ... packaging [23:39] davecheney: morning [23:40] davecheney: I think we should have more namespaces, not less... [23:40] set.Strings makes more sense than utils.Strings [23:40] thumper: i disagree [23:40] since the rename that rog wanted [23:41] if you want to write java, write java [23:41] but i honestly can't give a fuck about this bikeshedding [23:41] this isn't about java [23:41] * davecheney goes to change his vote on that CL [23:42] * thumper likes the zen of python [23:42] thumper: you've got 2 [23:42] and lots of c++ namespaces [23:42] submit it [23:42] davecheney: ta [23:51] davecheney: how about https://codereview.appspot.com/8701043/ ? [23:55] * davecheney is looking [23:57] thumper: do you have a test for [23:57] var s set.StringSet [23:57] s.Add("hello"); s.Add("world") [23:57] ? [23:57] davecheney: yep [23:57] ok, cool [23:57] TestUninitialized [23:58] I found myself wanting all the methods to work propery with uninitialized variables. [23:59] yeah, that is very nice