| frankban | hi rogpeppe: would you like to take another view at https://codereview.appspot.com/8716043. It includes s/st.client.Call/st.call/ in all the client calls. | 09:55 |
|---|---|---|
| rogpeppe | frankban: looking | 09:55 |
| frankban | rogpeppe: thanks | 09:55 |
| rogpeppe | frankban: nicer when using .call(), isn't it? :-) | 09:56 |
| frankban | rogpeppe: absolutely, less code and repetition | 09:56 |
| rogpeppe | frankban: thanks for making the changes | 09:57 |
| frankban | my pleasure | 09:57 |
| rogpeppe | frankban: LGTM | 09:58 |
| frankban | rogpeppe: cool! merging | 09:59 |
| gary_poster | teknico, sorry I was in a rush I guess, but yes, your shrinkwrap docs were excellent and much appreciated. :-) | 12:08 |
| gary_poster | and hi | 12:09 |
| teknico | gary_poster, hi, thanks, it feels like getting docs right on first try is even less likely than code :-) | 12:10 |
| gary_poster | hiya bac. fix fakebackend addRelation is still in landing on kanban. I'm guessing that is an oversight? | 12:10 |
| bac | gary_poster: yeah, i'll move it | 12:10 |
| gary_poster | teknico, :-) | 12:10 |
| gary_poster | thanks bac | 12:10 |
| gary_poster | rick_h_, hi. I marked "remove charm panel for the charm browser integration" as blocked on the charm browser being ready. Even if/when it is ready I'd like to hear what the plans are before we do them (my basic goal being the usual "does everything still work after this commit" | 12:13 |
| gary_poster | ) | 12:13 |
| * teknico lunches | 12:18 | |
| rick_h_ | gary_poster: rgr, makes sense | 12:18 |
| gary_poster | thx | 12:36 |
| benji | gary_poster: I suppose the high priority cards in story 1 are the best to draw from, in particular the ones that require changes to juju-core. Is that right? | 12:40 |
| gary_poster | benji, absolutely (though I hope that none of those actually require juju-core changes; I don't think they do) | 12:41 |
| gary_poster | uistage is down | 12:41 |
| gary_poster | I'm trying to figure out why and get it back | 12:41 |
| benji | gary_poster: oh, I mesread the "Implement resolved in the Go environment" bug. I don't think any have juju-core-side work. | 12:42 |
| gary_poster | benji, good. relatedly, my understanding of bug 1169167 (thank you for filing) is that we are currently getting constraints, but not config; and that we can work around that absence in the GUI by explicitly getting service data before rendering the pertinent pages. Are things better than I understood (config is also included in the deltas, as your bug implies) or otherwise different? | 12:45 |
| gary_poster | "currently getting" == "currently getting from the watcher deltas" | 12:45 |
| benji | my understanding (from frankban, hi frankban!) is that both the config and constraint data is coming in via watcher, but neither is wired up yet | 12:46 |
| gary_poster | ok great | 12:46 |
| frankban | benji, gary_poster: looking to the ServiceInfo structure (which I suppose it is included in the delta), I see "Constraints constraints.Value", but not the settings. So I guess the constraints are there, not the settings, as Gary mentioned. | 12:49 |
| gary_poster | teknico, shrinkwrap is broken somehow on uistage | 12:49 |
| gary_poster | frankban, ack thanks | 12:49 |
| gary_poster | teknico, if you are around let me know and I will ask you to help me diagnose on guichat | 12:50 |
| frankban | rogpeppe: do you confirm? ^^^ | 12:50 |
| frankban | rogpeppe: re: constraints and settings in delta | 12:50 |
| benji | gary_poster: I'll ammend the bug. | 12:50 |
| benji | Shall I add another about adding config data? | 12:50 |
| frankban | gary_poster: any error from uistage make? | 12:50 |
| rogpeppe | frankban: you don't get settings yet | 12:51 |
| gary_poster | (I told rogpeppe that we could work around the config being absent from the deltas for now; it is a nice to have) | 12:51 |
| gary_poster | rogpeppe, if we can get it in the next day that would be cool, but not counting on it :-) | 12:51 |
| frankban | rogpeppe: but we get constraints, right? | 12:51 |
| rogpeppe | frankban: yes | 12:51 |
| gary_poster | frankban, yes make fails with npm error | 12:51 |
| frankban | gary_poster: npm version? | 12:52 |
| frankban | gary_poster: and nodejs? | 12:52 |
| gary_poster | error is Error: No compatible version found: chai@'chai@1.5.x' | 12:52 |
| gary_poster | which is odd because it then says that 1.5.0 is a valid install target | 12:52 |
| frankban | benji: time for a quick review? https://codereview.appspot.com/8768043 | 12:53 |
| benji | frankban: sure | 12:53 |
| frankban | benji: thanks | 12:53 |
| gary_poster | frankban nodejs is 0.8.11, npm is 1.1.62. I will see if I can update | 12:53 |
| frankban | gary_poster: I had npm errors in trunk, resolved updating npm and node from the ppa | 12:53 |
| gary_poster | ack thanks | 12:53 |
| frankban | gary_poster: after updating I have $ npm -v | 12:54 |
| frankban | 1.2.18 | 12:54 |
| frankban | [master]frankban@syd76:~/devel/juju/ui/bug-1168449-releation-names$ nodejs -v | 12:54 |
| frankban | v0.10.4 | 12:54 |
| gary_poster | yeah, same here locally | 12:54 |
| teknico | back | 12:55 |
| teknico | gary_poster, getting there | 12:55 |
| benji | I think I'll add "LGTM" to my email signature. | 12:56 |
| frankban | :-) | 12:59 |
| gary_poster | uistage is back thanks to frankban and teknico | 13:10 |
| teknico | yay! | 13:11 |
| bac | hi gary_poster | 13:18 |
| gary_poster | hi bac | 13:18 |
| bac | gary_poster: in reviewing my destroy service branch makyo suggested that the corresponding units and machines should also be removed | 13:19 |
| gary_poster | bac, I saw | 13:19 |
| bac | gary_poster: i agree about removing units and have done that | 13:19 |
| bac | gary_poster: but what about machines? if they need to be removed should removeUnits take care of that? | 13:19 |
| bac | currently it doesn't | 13:19 |
| gary_poster | bac, interesting question: AIUI pyJuju keeps machines around and jujucore does not. Given our current goals, I think an XXX with that comment, with the expectation that we will add a "removeMachines" flag to removeUnits when we implement the Go side of the sandbox, is a good way forward. | 13:21 |
| bac | gary_poster: good idea. doing that and landing my branch. | 13:22 |
| gary_poster | awesome, thanks | 13:22 |
| frankban | rogpeppe: I am confused about "ResolvedResults" in params.go: I think it is not used anywhere, and the Resolved call just returns an error | 13:25 |
| rogpeppe | frankban: looking | 13:25 |
| hatch | good morning all - looking for 2x reviews -> (at least one familiar with relationships) https://codereview.appspot.com/8735043/ | 13:25 |
| rogpeppe | frankban: looks bogus to me. i think it can go. | 13:26 |
| gary_poster | hatch, I'm doing one (and marked it on kanban) | 13:27 |
| gary_poster | and good morning :-) | 13:27 |
| hatch | alright thanks :) | 13:27 |
| frankban | benji: in case you already investigated, does goenv.resolved need something back from the api backend? | 13:27 |
| benji | frankban: I don't know that yet. Shall I look? | 13:28 |
| hatch | benji: I noticed that you used Y.Object.each() on an array in your last landed branch, why use that vs Y.Array.each? | 13:28 |
| gary_poster | Or even Y.each | 13:28 |
| benji | hatch: I changed it to Y.Array.each as suggested. Did that message not get sent from Rietveld? | 13:29 |
| frankban | benji: no rush, please let me know when you figure it out | 13:29 |
| hatch | benji: oh I just looked at the merge and it showed that Y.Object.each was still being used | 13:29 |
| frankban | hatch: what's the difference between Y.Array.each and [].forEach? | 13:30 |
| benji | that's because "lbox submit" doesn't update the review. It should. | 13:30 |
| * gary_poster guesses browser support | 13:30 | |
| hatch | frankban: if the browser supports it....nothing :) | 13:31 |
| hatch | well it executes the callback under the proper context | 13:31 |
| hatch | that would have to be manually defined (which isnt' really an issue) if going straight native | 13:32 |
| frankban | hatch: do you know if forEach is supported by all the browsers we support? | 13:32 |
| hatch | see http://yuilibrary.com/yui/docs/api/files/yui_js_yui-array.js.html#l96 | 13:32 |
| hatch | frankban: it is | 13:32 |
| hatch | I think all of the array methods we use are | 13:33 |
| gary_poster | benji, hatch, we should be using Y.Array.each in app/views/service.js on the env.genericConstraints. Pre-existing problem to benji's branch | 13:34 |
| benji | gary_poster: I'll make up a quick fix branch and throw in a couple of little things I have lying around | 13:35 |
| gary_poster | cool thanks benji | 13:35 |
| benji | branch stew I call it | 13:35 |
| gary_poster | :-) | 13:35 |
| hatch | ahh yeah I see that on line 652 | 13:35 |
| hatch | frankban: I created a ticket to discuss switching to use native methods https://canonical.leankit.com/Boards/View/102529849 feel free to comment on it if you would likke | 13:43 |
| frankban | hatch: cool | 13:44 |
| rick_h_ | jcsackett: https://code.launchpad.net/~rharding/juju-gui/update-urls is the branch I'm working on | 13:45 |
| hatch | rick_h_: need review on 8768044? | 13:45 |
| rick_h_ | hatch: sinzui was going to grab it in a sec | 13:46 |
| hatch | alrighty | 13:46 |
| rick_h_ | hatch: but jcsackett will need a second one in a few min | 13:46 |
| * sinzui is reading it | 13:46 | |
| rick_h_ | hatch: once lbox burns enough cpu cycles | 13:46 |
| hatch | heh - I noticed it doesn't put both cores into 100% on my machine | 13:46 |
| hatch | I have been meaning to investigate | 13:46 |
| rick_h_ | hatch: that'd be cool if it ran test-debug/test-prod at once in diff cores | 13:48 |
| hatch | hehe I agree! | 13:49 |
| sinzui | rick_h_, do "we" dislike the "unless" handlebar helper? | 13:49 |
| rick_h_ | sinzui: no opinion that I know of but it's not come up. | 13:50 |
| sinzui | thank you | 13:50 |
| rick_h_ | sinzui: if you're not a fan it'd be great if we can land but add a card/bug for a followup drive by branch | 13:50 |
| sinzui | I am not a fan of an empty if-block, but the else-block has code | 13:51 |
| sinzui | "unless" is used for if-not and huw might not know that | 13:51 |
| rick_h_ | sinzui: yea, I've got that on a 'bring up to him' but I wanted to look over the file in full more carefuly and pull notes together I send him at EOD here. | 13:52 |
| rick_h_ | sinzui: so we're not having the monday sync call today correct? We had it friday. | 13:53 |
| sinzui | rick_h_, I have it on my calendar still. Antonio was looking to move it. | 13:54 |
| rick_h_ | sinzui: ok, I wasn't sure if friday replaced it this week | 13:55 |
| hatch | gary_poster: if possible could you QA the relation code? Just so we can be sure there isn't any other odd issues like last time? | 13:55 |
| gary_poster | hatch, will do. I'm being picky in the code too, because I don't understand some of it at first reading. | 13:56 |
| hatch | sure no problem | 13:56 |
| gary_poster | but trying to be helpful too :-) | 13:56 |
| jcsackett | hatch, rick_h_: if you have the time https://codereview.appspot.com/8612045 | 14:07 |
| jcsackett | lbox has burned its cycles. :-P | 14:07 |
| rick_h_ | jcsackett: will do | 14:07 |
| hatch | done | 14:14 |
| gary_poster | hatch quick chat in guichat? | 14:24 |
| hatch | 5 mins? I just have some eggs in the pan :) | 14:24 |
| gary_poster | hatch sure | 14:25 |
| hatch | ok egged up | 14:31 |
| hatch | gary_poster: guichat? | 14:31 |
| gary_poster | hatch come on by :-) | 14:32 |
| benji | gary_poster: little branch here https://codereview.appspot.com/8770044 | 14:58 |
| benji | hatch: you might be interested in reviewing this branch, it quiets the linter down: https://codereview.appspot.com/8770044 | 14:58 |
| hatch | sure I'll check it out | 14:58 |
| rick_h_ | jcsackett: the api guides use 'term' for the search phrase | 15:00 |
| rick_h_ | jcsackett: so I was wondering if you mind doing a s/text/term/g | 15:01 |
| jcsackett | rick_h_: i would rather update the api guides. | 15:01 |
| jcsackett | rather than landing another branch against charmworld just to get this rolling. | 15:01 |
| jcsackett | do you really have a strong concern about term/text? | 15:02 |
| rick_h_ | jcsackett: just hate 'text' as it's so generic and was looking to sync with the api docs. I didn't realize the server side wasn't term as well :( | 15:02 |
| jcsackett | rick_h_: i don't really know that "text" is generic...it is, in fact, a "text" search, right? | 15:02 |
| jcsackett | and yeah, the api is already implemented with text rather than term. | 15:03 |
| jcsackett | see the link in my reply. | 15:03 |
| rick_h_ | jcsackett: then yea match the server and I've got a good card for 'slack time' one day :) | 15:03 |
| rick_h_ | jcsackett: the last thing was yuo were doing extra work in the test than just create the data source and update it in the instance. | 15:04 |
| rick_h_ | jcsackett: but I guess that was to get the url updated to check? | 15:04 |
| rick_h_ | jcsackett: if that's the case ignore me | 15:04 |
| jcsackett | rick_h_: the extra calls are to change sendRequest into something that captures data in a way the test can interrogate. | 15:08 |
| rick_h_ | jcsackett: right, you wanted more than the res of makeRequest. I folow now. Just seemed extra work from the test I'd done before | 15:08 |
| rick_h_ | jcsackett: ignore me, all good. | 15:08 |
| jcsackett | rick_h_: cool, thanks. :-) | 15:09 |
| jcsackett | rick_h_: you want me to update the API guides? | 15:09 |
| jcsackett | or leave them alone and you'll do your slack card one day? | 15:09 |
| rick_h_ | jcsackett: :/ I guess. No sense having bad known info out there. It'll bite me down the road when I go to look at how to generate an api req by hand for that | 15:09 |
| jcsackett | rick_h_: when you say api guides, you mean the "Api sketch" doc in g drive, yeah? | 15:10 |
| rick_h_ | jcsackett: rgr | 15:10 |
| jcsackett | rick_h_: actually, reading the api sketch, term is used as a parameter when looking for autocompletion. | 15:13 |
| rick_h_ | well as per above, ignore me | 15:14 |
| jcsackett | so term=apa will return interfaces, owners, charms, etc, that you might want to autcomplete too. there's no mention of term used for full-text; just a mention of text=apache2 as an example in some searches. | 15:14 |
| jcsackett | rick_h_: just updating you, so you know what's in there. :-) | 15:14 |
| rick_h_ | let me know how wrong I am please kthx :) | 15:15 |
| jcsackett | less letting you know how wrong you are, more letting you know you have more work to do in your future slack time. :-) | 15:15 |
| gary_poster | hatchm I'm having to get my laptop on raring working. almost done, I think... | 15:21 |
| gary_poster | hatch ^^^ | 15:21 |
| hatch | ooo living on the edge :) | 15:21 |
| gary_poster | :-) on the laptop, at least | 15:21 |
| hatch | I usually wait a couple months so others can deal with the driver issues lol | 15:22 |
| hatch | I don't think I can upgrade my laptop to 13.04 because it was originally installed with wubi and 13.04 doesn't have wubi | 15:23 |
| hatch | I could be wrong with that though | 15:23 |
| hatch | I should probably ask | 15:26 |
| bac | hi frankban, i'm having trouble accessing a gui charm launched on juju-core on ec2 | 15:26 |
| bac | frankban: i set the juju-gui-source but juju status still shows it as a cs: charm | 15:27 |
| bac | frankban: password of 'passwd' is rejected. has something changed i missed? | 15:27 |
| bac | frankban: nm, i see admin-secret now works... | 15:29 |
| frankban | bac: auth is now enabled on juju-core api, you should use your admin-secret | 15:29 |
| frankban | heh | 15:29 |
| bac | frankban: i'd accidentally cut-n-pasted the secret-key, not admin-secret. thx. | 15:30 |
| Makyo | Thank goodness I don't have that 53 mile commute anymore. http://ubuntuone.com/3OEL5eifsK690J9p0dRzX7 | 15:42 |
| hatch | Makyo: awesome! | 15:43 |
| hatch | overnight? | 15:43 |
| Makyo | In the last six hours. | 15:43 |
| Makyo | Still coming down like crazy., | 15:44 |
| hatch | right on! I wish I was there | 15:44 |
| benji | frankban: to answer your question from earlier: no, resolved doesn't return anything (other than an error indicator) and the front-end doesn't need it to, either | 15:46 |
| frankban | benji: cool, thanks | 15:47 |
| gary_poster | If anyone pinged me in the past 15 minutes, I didn't see it, so please re-ping | 15:49 |
| gary_poster | 20, even | 15:49 |
| gary_poster | and meanwhile... | 15:50 |
| gary_poster | jujugui, please update kanban board. I'll review soon | 15:50 |
| gary_poster | hatch, I'm in guichat. Things are kinda sorta working. :-/ | 15:50 |
| gary_poster | jujugui call in 2 | 15:58 |
| gary_poster | Makyo, starting | 16:01 |
| teknico | hatch, https://plus.google.com/hangouts/_/02bb45411739e441fe107c9f66e2a8cc36ba4ba7?authuser=0&hl=en ? | 16:15 |
| benji | gary_poster: are the bugs I'll be filing "High-Priority Maintenance"? | 16:22 |
| gary_poster | benji, good question. at this stage in the game they are all kind of flowing together into "things we have to fix in order to deliver." Yeah, I think that sounds right | 16:22 |
| benji | k | 16:23 |
| gary_poster | benji, but please put the high priority marker on them in the card | 16:23 |
| benji | k | 16:23 |
| * gary_poster will think of some better name for that lane in the future :-P | 16:23 | |
| gary_poster | or someone will tell me of one :-) | 16:23 |
| benji | gary_poster: I suggest "Story Alpha" | 16:24 |
| gary_poster | benji :-P there actually is intended to be some meaning to the "maintenance" part of the name :-) | 16:25 |
| benji | Just ribbing you on the "Story 1"/"Story A" thing | 16:25 |
| gary_poster | :-) | 16:25 |
| gary_poster | rogpeppe, you available for a quick call? I was writing you another novel, and I think talking might be better :-) | 16:28 |
| rogpeppe | gary_poster: definitely. give me a few minutes and i'll ping you | 16:29 |
| gary_poster | thanks rogpeppe | 16:29 |
| === deryck is now known as deryck[lunch] | ||
| hatch | rick_h_: avail to chat now? | 16:41 |
| rick_h_ | hatch: sure | 16:43 |
| hatch | ok in guichat | 16:43 |
| Makyo | Really need to shovel the deck. Back in a few. | 16:45 |
| hatch | gary_poster: ok done the calls so whenever you want to continue with that relations stuff | 17:00 |
| gary_poster | cool hatch. My call now is cancelled. I'm kind of hungry though. Maybe call in 20? | 17:01 |
| hatch | sounds good | 17:01 |
| gary_poster | cool tty then | 17:01 |
| hatch | restarting the CI - it hung | 17:01 |
| rick_h_ | gary_poster: jcastro ping'ed me asking about the gui on the tablet and the uistage url is showing the circles but not the squares/etc. | 17:03 |
| rick_h_ | gary_poster: did that get working? He's asking if yuo could email a status update for the gui on the tablet to robbie and cc him. | 17:04 |
| gary_poster | rick_h_, tell him to reload, and give him Makyo as contact | 17:04 |
| gary_poster | rick_h_, sure will do. | 17:04 |
| rick_h_ | gary_poster: thanks | 17:04 |
| gary_poster | Makyo, I'm going to forward your email to Kapil, plus a note about the reload for circles -> squares | 17:04 |
| Makyo | gary_poster, ack. Hoping it's just a cache thing. | 17:05 |
| rick_h_ | hah just got as text to nvm it works!! | 17:05 |
| rick_h_ | gary_poster: Makyo ^^ | 17:05 |
| gary_poster | :-) | 17:05 |
| gary_poster | rick_h_, sent Jorge and Robbie the email anyway. Makyo, cc'd you. | 17:08 |
| Makyo | rick_h_, Hah, yeah, probably the cache, then. Should be fine on reloads, since the cache will be populated. | 17:08 |
| rick_h_ | cool, thanks guys | 17:09 |
| Makyo | Should look into gzipping the svg assets. | 17:09 |
| rick_h_ | sounds like they're having fun at the conference | 17:09 |
| gary_poster | :-) cool | 17:09 |
| === matsubara_ is now known as matsubara-lunch | ||
| benji | semantic difference between go- and python-back-ends: the go back-end resolves the unit as a whole while the python back-end can resolve just a unit or a unit/relation pair | 17:17 |
| rick_h_ | hatch: https://codereview.appspot.com/8679045 is the up and ready for destruction :) | 17:52 |
| hatch | haha alright do I need to qa it? | 17:53 |
| rick_h_ | hatch: hmm, you can. You have to hit each url manually. I can give you a list | 17:53 |
| rick_h_ | oh actually I need to add the commit message on there still doh | 17:53 |
| === matsubara-lunch is now known as matsubara | ||
| rick_h_ | hatch: I think just the code for now will be cool and QA once the missing bits get added. | 17:54 |
| hatch | alright sure | 17:54 |
| rick_h_ | it's a bit of a regression for us atm. | 17:54 |
| rick_h_ | but urls ftw | 17:54 |
| hatch | CI hung again it looks like it was only able to requisition a single machine | 17:55 |
| === deryck[lunch] is now known as deryck | ||
| bcsaller | Makyo: Might you have time soon to help look over my charm branch? | 18:09 |
| hatch | rick_h_: done - few things to chat about in the review | 18:21 |
| rick_h_ | hatch: looking now | 18:21 |
| Makyo | bcsaller, These docs are getting out of hand, but I'm at a good stopping point now. | 18:21 |
| bcsaller | Makyo: up to you. lp:~bcsaller/charms/precise/juju-gui/sandbox-charm/ has the current. I'm testing my latest updates now. I'd also be happy to walk you through the changes | 18:23 |
| rick_h_ | hatch: did yuo want to chat then? | 18:24 |
| hatch | sure | 18:25 |
| hatch | guichat | 18:26 |
| rick_h_ | rgr | 18:26 |
| Makyo | bcsaller, looking through diff over lunch, give me a few, then I'll QA best I can. | 18:34 |
| bcsaller | Makyo: happy to answer questions, there is both new code and new features | 18:36 |
| hatch | gary_poster: back from lunch yet? :) | 18:41 |
| gary_poster | hatch, sorry, yeah, been back. | 18:42 |
| hatch | no problem, I'm at a good point to get back onto the relation stuff if you are available | 18:42 |
| gary_poster | hatch, cool,let's do it. see you in guichat in 2 min. | 18:43 |
| Makyo | bcsaller, looks fairly straight forward. What backend should I test first? | 19:01 |
| bcsaller | Makyo: sandbox: true, staging: true is the config set we want right now | 19:02 |
| bcsaller | Makyo: you're the first to look at the new backend code, that looked sane to you? | 19:02 |
| Makyo | bcsaller, yeah, I think so. I wasn't expecting the chain/merge stuff, but it makes sense when I read throughit. | 19:08 |
| bcsaller | Makyo: yeah, composition patterns rather than inheritance | 19:09 |
| Makyo | bcsaller, yeah, makes sense. | 19:09 |
| * bac reboots | 19:15 | |
| Makyo | bcsaller, Testing's going okay so far, minus EC2 problems. | 19:44 |
| bcsaller | If I was doing core dev right now I think I'd be working on a Docker provider, local provisioning of units should only take seconds and the way it is now is driving me crazy | 19:49 |
| Makyo | A pox on all self-signed certs. | 20:09 |
| Makyo | I'm getting "SyntaxError: JSON.parse: unexpected end of data" now, though, which is new. | 20:09 |
| bcsaller | I haven't seen that one | 20:10 |
| Makyo | I'm trying to figure out how to make firebug break on errors, so I can figure out what it's talking about. | 20:10 |
| Makyo | Oh, derp. | 20:11 |
| bcsaller | Makyo: any update? | 20:20 |
| Makyo | bcsaller, Trying to dig into the uglified source. | 20:21 |
| Makyo | bcsaller, from the look of it, sandbox isn't being set in config.js | 20:24 |
| Makyo | Making sure it's not just a cache problem. | 20:24 |
| Makyo | Yeah, not cached. | 20:25 |
| Makyo | So it's trying to connect to pyjuju's ws, which isn't running. | 20:25 |
| bcsaller | Makyo: it should be set, that would be a real issue, I haven't seen that not work. The improv server doesn't run in a sandbox though, the ws faked on the client | 20:27 |
| * benji records in the Big Book of Things About Working from Home... Danger 27: chatty pest control guy | 20:28 | |
| Makyo | bcsaller, yeah, not seeing a sandbox attribute in config.js | 20:29 |
| Makyo | Should note that I forgot to specify the juju-gui-source and changed it later with juju set, I'm sure that regens the config.js file, but I'm chcking | 20:30 |
| bcsaller | benji: chatty pests are worse | 20:34 |
| benji | lol | 20:34 |
| bac | benji: i really need a pest control guy. we've got a mouse who has eaten/contaminated about $200 of food last week. | 20:35 |
| Makyo | bcsaller, damn, config on install wasn't applied, bet it was a typo on my part. Trying with set. | 20:35 |
| bcsaller | Makyo: I might properly have triggered the change in the case you're looking at either though, been checking into it | 20:36 |
| benji | bac: yow (I think the previous owners of this house (the ones that had it forclosed and taken away from them) had a bad rodent problem, judging from all the mummified ones I found when I tore out the kitchen; makes the fees seem worth it) | 20:37 |
| bac | i got a good whack at him the other night with a broom. missed but he ran away and hasn't been back yet | 20:38 |
| bac | of course there is no food out for him now. that may have more to do with it | 20:38 |
| bcsaller | Isn't this the Future with a capital 'F'? Why do we still have rodent home invasions? | 20:39 |
| bcsaller | Makyo: I pushed an update that may help in that case, but calling set might do it as well. | 20:40 |
| Makyo | bcsaller, Alright. This thing's being stupid anyway. | 20:44 |
| bac | gary_poster: the config/settings bug is marked as blocked. any info? | 20:50 |
| gary_poster | bac, yes, Roger might magically fix it in the watcher between now and tomorrow evening. If he does, then this card will mean work A, otherwise it will mean work B. | 20:51 |
| Makyo | Had to resolve a unit to destroy a service due to hook failed, then had to terminate the machine, now the whole environment's hosed. | 20:51 |
| gary_poster | So, since we can do either after the go env is frozen, we are waiting for roger, bac | 20:51 |
| Makyo | Or, maybe just status? | 20:51 |
| bac | gary_poster: "A" being adding it to serviceInfo handler? | 20:51 |
| gary_poster | bac, right | 20:52 |
| bac | ok. | 20:52 |
| * bac does QA while waiting for two reviews, he said in his most aggressive passive voice. | 20:54 | |
| gary_poster | heh | 20:54 |
| gary_poster | jujugui ^^^ | 20:54 |
| Makyo | Running into https://bugs.launchpad.net/juju-core/+bug/1168155 again, sorry this is taking a while bcsaller | 20:56 |
| Makyo | _mup_, not a fan? #1168155 | 20:57 |
| Makyo | :( | 20:57 |
| bcsaller | Makyo: I understand about it taking a while, I appreciate you looking it. I fought with this over the weekend and each iteration takes far too long | 20:57 |
| bcsaller | Makyo: you might change the hash on your ec2 control-bucket or delete the s3 bucket directly | 20:58 |
| Makyo | bcsaller, Yeah, starting over anyway. | 20:59 |
| rogpeppe | gary_poster: ping | 21:00 |
| gary_poster | hey rogpeppe | 21:00 |
| rogpeppe | gary_poster: i've just discovered a slightly annoying wrinkle | 21:01 |
| rogpeppe | gary_poster: to the service config watching stuff | 21:01 |
| gary_poster | bcsaller, "each iteration takes far too long": I want to explore that with juju core for 13.10 | 21:01 |
| gary_poster | rogpeppe, uh-oh? | 21:01 |
| rogpeppe | gary_poster: which is that watching the settings collection doesn't actually tell us all the current values of the settings | 21:01 |
| rogpeppe | gary_poster: because the settings collection only holds values that have been set explicitly | 21:02 |
| gary_poster | as opposed to defaults? | 21:02 |
| rogpeppe | gary_poster: yup | 21:02 |
| gary_poster | hm | 21:02 |
| gary_poster | rogpeppe, I don't think that's too bad | 21:02 |
| rogpeppe | gary_poster: so... you do *theoretically* have all the info you need to do the defaulting | 21:02 |
| gary_poster | rogpeppe, right, we always work off of a model | 21:02 |
| gary_poster | and the model isinstantiated with data from call to get service info | 21:03 |
| gary_poster | which I am pretty sure has the settings | 21:03 |
| rogpeppe | gary_poster: you can get the defaults from the charm metadata | 21:03 |
| * bac -> dogwalk. bbiab. | 21:03 | |
| gary_poster | rogpeppe, ok, we already have that too, and mutate the service on the basis of it for the endpoints | 21:04 |
| gary_poster | so we can set up the initial values from the charm at that point | 21:04 |
| rogpeppe | gary_poster: so the question is: is it easier for me to do the "right thing" than for you to cope with the wrong thing at your end? | 21:04 |
| gary_poster | rogpeppe, where the right thing is to include defaults? | 21:05 |
| rogpeppe | gary_poster: yeah | 21:05 |
| rogpeppe | gary_poster: although... i'm not totally sure | 21:05 |
| rogpeppe | gary_poster: it's actually unnecessary network traffic | 21:05 |
| gary_poster | rogpeppe, if you are contacting me, I suspect it is not trivial on your side. I think it will approach trivial on our side, and I don't mind the semantics in the abstract. Not 100% convenient, but not horrible. I wouldn't mind if you only sent us config changes, in fact, and might think about this approach as an approximation thereof | 21:06 |
| rogpeppe | gary_poster: ok, that sounds good | 21:07 |
| gary_poster | cool thanks rogpeppe | 21:07 |
| rogpeppe | gary_poster: i'll go with that for now | 21:07 |
| gary_poster | cool | 21:07 |
| rogpeppe | gary_poster: the implementation is basically done, i think - "just" the tests to go | 21:07 |
| gary_poster | rogpeppe, :-) great! | 21:07 |
| Makyo | bcsaller, ip-10-212-73-147:2013/04/15 21:17:21 INFO worker/uniter: HOOK ValueError: Unable to use staging with go backend | 21:18 |
| bcsaller | Makyo: thats true :) | 21:19 |
| bcsaller | no improv and we only implement the pyjuju protocol for sandbox currently | 21:20 |
| Makyo | bcsaller, alright. Should I test something other than staging: true, sandbox: true? | 21:20 |
| bcsaller | I suppose the next would be to verify a normal python install on ec2, I've done it locally but not there yet. If that works then the charm is still valid for its primary use-case | 21:21 |
| bcsaller | Makyo: ^^ | 21:21 |
| Makyo | bcsaller, alright, will do. | 21:22 |
| bcsaller | thanks | 21:22 |
| Makyo | bcsaller, looking good. | 21:34 |
| bcsaller | Makyo: thank you :) | 21:41 |
| gary_poster | bcsaller, I have to run. where are we with charm? | 21:52 |
| Makyo | Checks out on python and go (before I messed it up) | 21:52 |
| Makyo | gary_poster, bcsaller ^^^ | 21:52 |
| gary_poster | Makyo, great! You tried the new features as well, with sandbox and the "look someplace else" functionality? prob hard to qa that last one | 21:53 |
| Makyo | gary_poster, just straight deployments, but I can. | 21:54 |
| gary_poster | Makyo, thank you. sandbox should be relatively easy to test (within constraints of what sandbox privides | 21:54 |
| Makyo | gary_poster, alright, on that one now. | 21:55 |
| gary_poster | Makyo, the other functionality might be best tested by verifying that deploying it fails, then logging in and verifying that no ppas are installed in etc/apt/sources.list.d. | 21:56 |
| gary_poster | maybe you or ben have better idea | 21:56 |
| gary_poster | running | 21:56 |
| gary_poster | back later | 21:56 |
| gary_poster | must write email about charm to is tonight | 21:56 |
| bcsaller | gary_poster: I think we can use the branch for now, and then do another rev once its code reviewed | 21:57 |
| gary_poster | cool thanks bcsaller. shoot me a mail with branch pls | 21:57 |
| gary_poster | ttyl | 21:57 |
| * bcsaller nods | 21:57 | |
| hatch | am I supposed to be able to create a relation from wordpress to puppet in the UI? or do I need to do something fancy to get the subordinate relations? | 22:06 |
| Makyo | gary_poster, bcsaller Good to go on sandbox. | 22:07 |
| bcsaller | :) | 22:07 |
| hatch | ohh | 22:07 |
| hatch | do we support deploying subordinates in the sandbox? | 22:07 |
| hatch | I don't get the subordinate UI in the sandbox after deploying puppet | 22:08 |
| bcsaller | hatch: if we don't its a bug | 22:08 |
| hatch | alrighty I'll file | 22:09 |
| bcsaller | hatch: I think we previously set a flag on the incoming delta that might not be happening in deploy. I expect there is that and not joining peer relations that might be issues with sandbox deploy at this time | 22:09 |
| hatch | alright - so because of that I can't create a subordinate relationship to QA | 22:10 |
| hatch | but normal relationships are good | 22:10 |
| hatch | https://bugs.launchpad.net/juju-gui/+bug/1169350 | 22:13 |
| Makyo | Alright, dogwalking time. | 22:14 |
| bac | hi Makyo, still here? | 22:14 |
| Makyo | bac sure, for a minute or so | 22:14 |
| bac | Makyo: sorry to keep you. doing QA and wondered if there was a bug for the trail of artifacts left on the canvas when dragging around a service? | 22:15 |
| Makyo | bac, not seen that yet, but dragging a service only updates element attributes, not create new elements. Can you check in the DOM through firebug/JS tools? If there are extras, definitely worth a bug. | 22:16 |
| bac | Makyo: will do. have a nice walk. | 22:17 |
| Makyo | bac, cheers | 22:17 |
| rick_h_ | hatch: updated per your review. Working on jcsackett's now. If you get a sec can you toss a LGTM or even a LGTM with the following XXX so I can finish/land it later tonight if possible? | 22:17 |
| bcsaller | hatch: in looking at it, removeUnit checks service.get('is_subordinate') but I think for service its just get('subordinate') (no 'is') | 22:17 |
| hatch | bcsaller: if you get a chance before EOD https://codereview.appspot.com/8735043/ | 22:18 |
| hatch | hmm | 22:18 |
| bcsaller | hatch: I can do it now, the charm is 'good enough' for now | 22:18 |
| hatch | rick_h_: sure thing lemme take a peek | 22:18 |
| hatch | rick_h_: which patch set should I be looking at? | 22:23 |
| hatch | 4? | 22:23 |
| rick_h_ | hatch: yea, latest. | 22:23 |
| hatch | alright | 22:23 |
| rick_h_ | hatch: no hurry. I won't get back to it for a couple of hours | 22:23 |
| hatch | rick_h_: done! | 22:26 |
| rick_h_ | hatch: thanks again | 22:27 |
| bcsaller | hatch: thanks, nice branch | 22:37 |
| hatch | right on | 22:38 |
| hatch | thanks | 22:38 |
| hatch | great comments ;) | 22:39 |
| rick_h_ | feel the <3 | 22:40 |
| hatch | I didnt know about passing to done() that's pretty cool | 22:42 |
| rogpeppe | gary_poster: https://codereview.appspot.com/8761045/ | 22:46 |
| Makyo | Walking two young dogs in 8" of wet snow is basically the worst. | 22:46 |
| rick_h_ | Makyo: love when my neighbor snow plows a circle in his yard for his little dog to go out in. Like a nascar track of space taller than it is | 22:47 |
| Makyo | rick_h_, Haha, awesome :D We had to do that for Zephyr when he was a puppy. http://www.flickr.com/photos/ranna/4056585833/in/set-72157594409039347 | 22:48 |
| Makyo | Of course, now he can set his head on the dining room table without stretching, so really, he should be the one shoveling. | 22:49 |
| bac | why does our 'high priority maintenance' section have so many low-priority bugs? | 22:51 |
| hatch | low priority high priority is still higher priority than normal priority | 22:51 |
| hatch | context is everything ;) | 22:51 |
| Makyo | bac, some of those were deprioritized in order to get essential tablet stuff done before ODS. | 22:52 |
| bac | Makyo: it was more of a philosophical question/smart-ass observation. :) | 22:52 |
| bac | good night gents. | 22:53 |
| Makyo | bac, hah, goodnight | 22:53 |
| bac | be nice to someone tonight | 22:53 |
| Makyo | +10000 | 22:53 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!