=== wedgwood_away is now known as wedgwood
=== wedgwood is now known as wedgwood_away
=== Ursinha-afk is now known as Ursinha
StevenKwgrant: Do you want to help me with my YUI3 Calendar branch?04:32
StevenKwallyworld_:  82 files changed, 48 insertions(+), 26310 deletions(-)04:32
wallyworld_StevenK: what did you delete?04:33
StevenKwallyworld_: YUI204:33
wallyworld_at last04:33
wallyworld_how's lp going?04:33
StevenKYeah, but my YUI3 calender has a few problems04:33
wgrantStevenK: I don't know much YUI, but I can try04:34
StevenKMaybe I'll turn wallyworld_ upside down and shake him until some clues fall out04:34
wallyworld_StevenK: what calendar implementation did you use?04:34
StevenKwallyworld_: Y.Calendar from YUI 3.9.104:34
StevenK(Which is now the YUI version used on LP if you're a beta-tester)04:35
wallyworld_it's been so long since i did yui i didn't even realise/remember they had a std calendar widget04:35
wgrantIt's new. That was part of the motivation for the upgrade.04:35
wallyworld_what sort of issues are there?04:35
StevenK     * Looks like rubbish, and is transparent04:35
StevenK     * Needs an X to dismiss04:35
StevenK     * Need to handle time input04:35
StevenK     * Clicking Choose will create a new calendar04:35
StevenK     * The selection function does not fire04:35
StevenKThose are my current issues04:36
wallyworld_so just minor glitches then :-)04:36
wallyworld_with the (x) to dismiss, you could look at how the lazr overlays are done04:36
StevenKI'm happy to push up the branch, but it's *massive* due to YUI2 dying04:36
wallyworld_the lazr overlays add an (x) if i recall correctly04:37
StevenKwallyworld_: It's a node that calls div_node.hide(); on click, I just haven't done it04:37
wallyworld_what's the main bit you are stuck on?04:38
StevenKThat's what I've spent Friday afternoon and this morning chasing04:39
wgrantIs there Y.Calendar CSS that you have to include?04:40
StevenKDone so04:41
StevenK+++ buildout-templates/bin/combine-css.in2013-04-12 04:38:34 +000004:41
StevenK+    'yui/calendar/assets/calendar-core.css',04:41
StevenK+    'yui/calendar/assets/skins/sam/calendar.css',04:41
StevenK+    'yui/calendar/assets/skins/sam/calendar-skin.css',04:41
wallyworld_are there any examples to work from? surely the transparency is just a misapplied style or something?04:43
wallyworld_with the selection issue, does the registered click handler get called? can you firebug that issue?04:44
StevenKwallyworld_: The calendar machinery creates an enclosing <div> for the calendar, but I couldn't figure out what style/class to set04:45
StevenKwallyworld_: I've set breakpoints inside the function that is supposed to fire, but it doesn't happen. I was going to read the JS to see if I can work out what events it emits.04:46
wallyworld_from memory, with the lp pretty overlays etc, we define our own css using selectors based on the full generated yui class names04:46
wallyworld_perhaps you could try something simple like a red background to ensure you selectors are correct (use fb to look at the exact class names to define your selector)04:47
wallyworld_the function that is supposed to fire - is that an onclick handler or something?04:47
StevenKcalendar.on('selectionChange', function(e) {04:48
wallyworld_is there a yui calendar api you are using to register it, or it is a construction attribute, or...?04:48
StevenKwallyworld_: http://yuilibrary.com/yui/docs/calendar/04:49
StevenKAnd in calendar-base:         this.fire("selectionChange", {newSelection: this._getSelectedDatesList()});04:50
wallyworld_you used this example? http://yuilibrary.com/yui/docs/calendar/calendar-simple.html04:52
wallyworld_does a debug print inside your selection function print out?04:52
wallyworld_are there any yui errors? since they may prevent the handler from registering04:52
StevenKwallyworld_: Changing the style to include background-color:red; impacts the page so that works at least04:54
wallyworld_the page or the calendar itself?04:54
StevenKThe <div> that contains the calendar04:55
StevenKHm, maybe that is the answer.04:55
wallyworld_and the style you changed was in lp css?04:55
StevenKwallyworld_: No, the style tag when the <div> is created04:55
wallyworld_there's default styling that comes with the widget, and for that you need to say <div id="lpcal" class="yui3-skin-sam"  ....04:56
wallyworld_but i think in lp we use our own css stuff04:57
wallyworld_but for starters, see if adding the yui3-skin-sam style works04:57
wallyworld_classname i mean04:57
wallyworld_if that works, you could copy the default yui styling into a lp css file and rebrand as required04:58
StevenKwallyworld_: class="yui3-skin-sam" on the div has no effect04:58
StevenKstyle="position:absolute;background-color:white;" makes it non-transparent, but then it doesn't look like a usual LP popup04:59
wallyworld_you sure the yui3 skin css is being packaged in with the lp stuff?04:59
StevenK.yui3-skin-sam button.lazr-btn{background:transparent05:00
StevenKThat could be a large clue05:00
wallyworld_where did you get that line from?05:00
wallyworld_it still seems that the combos.css is missing the calendar css stuff05:03
wallyworld_is the yui3 calendar source in the lp tree?05:04
wallyworld_and have you checked the build scripts to ensure the calendar css is being included?05:05
wallyworld_StevenK: see combine-css.in05:06
StevenKwallyworld_: I've changed that in this branch, see the four line of +... I pasted above05:07
wallyworld_ah right05:07
wallyworld_and you used fb to double check the rendered class name for the containing div is as required to pick up the styles from the combo.css?05:08
wallyworld_or you could use fb to see what styles are actually being applied05:11
wallyworld_and if the ones from the calendar.css are not there, then there's a problem with the class names being used05:11
StevenKMy plan to create a PrettyOverlay and then render the calendar inside that is not going well06:36
adeuringgood morning07:58
=== Gwaihir_ is now known as Gwaihir
=== wedgwood_away is now known as wedgwood
=== beuno_ is now known as beuno
=== deryck is now known as deryck[lunch]
=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
=== matsubara_ is now known as matsubara-lunch
=== matsubara-lunch is now known as matsubara
=== deryck[lunch] is now known as deryck
=== wedgwood is now known as wedgwood_away

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!