[04:32] <StevenK> wgrant: Do you want to help me with my YUI3 Calendar branch?
[04:32] <StevenK> wallyworld_:  82 files changed, 48 insertions(+), 26310 deletions(-)
[04:33] <wallyworld_> StevenK: what did you delete?
[04:33] <StevenK> wallyworld_: YUI2
[04:33] <wallyworld_> \o/
[04:33] <wallyworld_> at last
[04:33] <wallyworld_> how's lp going?
[04:33] <StevenK> Yeah, but my YUI3 calender has a few problems
[04:34] <wgrant> StevenK: I don't know much YUI, but I can try
[04:34] <StevenK> Maybe I'll turn wallyworld_ upside down and shake him until some clues fall out
[04:34] <wallyworld_> StevenK: what calendar implementation did you use?
[04:34] <StevenK> wallyworld_: Y.Calendar from YUI 3.9.1
[04:35] <StevenK> (Which is now the YUI version used on LP if you're a beta-tester)
[04:35] <wallyworld_> it's been so long since i did yui i didn't even realise/remember they had a std calendar widget
[04:35] <wgrant> It's new. That was part of the motivation for the upgrade.
[04:35] <wallyworld_> what sort of issues are there?
[04:35] <StevenK>      * Looks like rubbish, and is transparent
[04:35] <StevenK>      * Needs an X to dismiss
[04:35] <StevenK>      * Need to handle time input
[04:35] <StevenK>      * Clicking Choose will create a new calendar
[04:35] <StevenK>      * The selection function does not fire
[04:36] <StevenK> Those are my current issues
[04:36] <wallyworld_> so just minor glitches then :-)
[04:36] <wallyworld_> with the (x) to dismiss, you could look at how the lazr overlays are done
[04:36] <StevenK> I'm happy to push up the branch, but it's *massive* due to YUI2 dying
[04:37] <wallyworld_> the lazr overlays add an (x) if i recall correctly
[04:37] <StevenK> wallyworld_: It's a node that calls div_node.hide(); on click, I just haven't done it
[04:38] <wallyworld_> what's the main bit you are stuck on?
[04:39] <StevenK> http://wedontsleep.org/~steven/new-calendar.jpg
[04:39] <StevenK> That's what I've spent Friday afternoon and this morning chasing
[04:40] <wgrant> Is there Y.Calendar CSS that you have to include?
[04:41] <StevenK> Done so
[04:41] <StevenK> +++ buildout-templates/bin/combine-css.in	2013-04-12 04:38:34 +0000
[04:41] <StevenK> +    'yui/calendar/assets/calendar-core.css',
[04:41] <StevenK> +    'yui/calendar/assets/skins/sam/calendar.css',
[04:41] <StevenK> +    'yui/calendar/assets/skins/sam/calendar-skin.css',
[04:43] <wallyworld_> are there any examples to work from? surely the transparency is just a misapplied style or something?
[04:44] <wallyworld_> with the selection issue, does the registered click handler get called? can you firebug that issue?
[04:45] <StevenK> wallyworld_: The calendar machinery creates an enclosing <div> for the calendar, but I couldn't figure out what style/class to set
[04:46] <StevenK> wallyworld_: I've set breakpoints inside the function that is supposed to fire, but it doesn't happen. I was going to read the JS to see if I can work out what events it emits.
[04:46] <wallyworld_> from memory, with the lp pretty overlays etc, we define our own css using selectors based on the full generated yui class names
[04:47] <wallyworld_> perhaps you could try something simple like a red background to ensure you selectors are correct (use fb to look at the exact class names to define your selector)
[04:47] <wallyworld_> the function that is supposed to fire - is that an onclick handler or something?
[04:48] <StevenK> calendar.on('selectionChange', function(e) {
[04:48] <wallyworld_> is there a yui calendar api you are using to register it, or it is a construction attribute, or...?
[04:49] <StevenK> wallyworld_: http://yuilibrary.com/yui/docs/calendar/
[04:50] <StevenK> And in calendar-base:         this.fire("selectionChange", {newSelection: this._getSelectedDatesList()});
[04:52] <wallyworld_> you used this example? http://yuilibrary.com/yui/docs/calendar/calendar-simple.html
[04:52] <wallyworld_> does a debug print inside your selection function print out?
[04:52] <wallyworld_> are there any yui errors? since they may prevent the handler from registering
[04:54] <StevenK> wallyworld_: Changing the style to include background-color:red; impacts the page so that works at least
[04:54] <wallyworld_> the page or the calendar itself?
[04:55] <StevenK> The <div> that contains the calendar
[04:55] <StevenK> Hm, maybe that is the answer.
[04:55] <wallyworld_> and the style you changed was in lp css?
[04:55] <StevenK> wallyworld_: No, the style tag when the <div> is created
[04:56] <wallyworld_> there's default styling that comes with the widget, and for that you need to say <div id="lpcal" class="yui3-skin-sam"  ....
[04:57] <wallyworld_> but i think in lp we use our own css stuff
[04:57] <wallyworld_> but for starters, see if adding the yui3-skin-sam style works
[04:57] <wallyworld_> classname i mean
[04:58] <wallyworld_> if that works, you could copy the default yui styling into a lp css file and rebrand as required
[04:58] <StevenK> wallyworld_: class="yui3-skin-sam" on the div has no effect
[04:59] <StevenK> style="position:absolute;background-color:white;" makes it non-transparent, but then it doesn't look like a usual LP popup
[04:59] <wallyworld_> you sure the yui3 skin css is being packaged in with the lp stuff?
[05:00] <StevenK> .yui3-skin-sam button.lazr-btn{background:transparent
[05:00] <StevenK> That could be a large clue
[05:00] <wallyworld_> where did you get that line from?
[05:00] <StevenK> combo.css
[05:03] <wallyworld_> it still seems that the combos.css is missing the calendar css stuff
[05:04] <wallyworld_> is the yui3 calendar source in the lp tree?
[05:05] <wallyworld_> and have you checked the build scripts to ensure the calendar css is being included?
[05:06] <wallyworld_> StevenK: see combine-css.in
[05:07] <StevenK> wallyworld_: I've changed that in this branch, see the four line of +... I pasted above
[05:07] <wallyworld_> ah right
[05:08] <wallyworld_> and you used fb to double check the rendered class name for the containing div is as required to pick up the styles from the combo.css?
[05:11] <wallyworld_> or you could use fb to see what styles are actually being applied
[05:11] <wallyworld_> and if the ones from the calendar.css are not there, then there's a problem with the class names being used
[06:35] <StevenK> Ugh
[06:36] <StevenK> My plan to create a PrettyOverlay and then render the calendar inside that is not going well
[07:58] <adeuring> good morning